Re: [RFC PATCH v1 00/11] Create fast idle path for short idle periods

2017-07-13 Thread Li, Aubrey
On 2017/7/13 16:36, Peter Zijlstra wrote: > On Wed, Jul 12, 2017 at 02:32:40PM -0700, Andi Kleen wrote: > >>> It uses the normal idle path, it just makes the NOHZ enter fail. >> >> Which is only a small part of the problem. > > Given the data so far provided it was by far the biggest problem. If

Re: [RFC PATCH v1 00/11] Create fast idle path for short idle periods

2017-07-13 Thread Li, Aubrey
On 2017/7/13 22:53, Peter Zijlstra wrote: > On Thu, Jul 13, 2017 at 10:48:55PM +0800, Li, Aubrey wrote: > >> - totally from arch_cpu_idle_enter entry to arch_cpu_idle_exit return costs >> 9122ns - 15318ns. >> In this period(arch idle), rcu_idle_ent

Re: [RFC PATCH v1 00/11] Create fast idle path for short idle periods

2017-07-13 Thread Li, Aubrey
On 2017/7/13 23:20, Paul E. McKenney wrote: > On Thu, Jul 13, 2017 at 04:53:11PM +0200, Peter Zijlstra wrote: >> On Thu, Jul 13, 2017 at 10:48:55PM +0800, Li, Aubrey wrote: >> >>> - totally from arch_cpu_idle_enter entry to arch_cpu_idle_exit return costs >>> 9

Re: [RFC PATCH v1 00/11] Create fast idle path for short idle periods

2017-07-13 Thread Li, Aubrey
On 2017/7/14 2:28, Peter Zijlstra wrote: > On Thu, Jul 13, 2017 at 11:13:28PM +0800, Li, Aubrey wrote: >> On 2017/7/13 22:53, Peter Zijlstra wrote: > >>> Fixing C-state selection by creating an alternative idle path sounds so >>> very wrong. >> >> This o

Re: [RFC PATCH v1 00/11] Create fast idle path for short idle periods

2017-07-10 Thread Li, Aubrey
On 2017/7/10 16:46, Peter Zijlstra wrote: > On Mon, Jul 10, 2017 at 09:38:30AM +0800, Aubrey Li wrote: >> We measured 3%~5% improvemnt in disk IO workload, and 8%~20% improvement in >> network workload. > > Argh, what a mess :/ > > So how much of the gain is simply due to skipping NOHZ? netperf

Re: [RFC PATCH v1 00/11] Create fast idle path for short idle periods

2017-07-10 Thread Li, Aubrey
On 2017/7/11 1:27, Andi Kleen wrote: > On Mon, Jul 10, 2017 at 06:42:06PM +0200, Peter Zijlstra wrote: >> On Mon, Jul 10, 2017 at 07:46:09AM -0700, Andi Kleen wrote: So how much of the gain is simply due to skipping NOHZ? Mike used to carry a patch that would throttle NOHZ. And that is a

Re: [RFC PATCH v1 00/11] Create fast idle path for short idle periods

2017-07-11 Thread Li, Aubrey
On 2017/7/12 1:58, Christoph Lameter wrote: > On Tue, 11 Jul 2017, Frederic Weisbecker wrote: > >>> --- a/kernel/time/tick-sched.c >>> +++ b/kernel/time/tick-sched.c >>> @@ -787,6 +787,7 @@ static ktime_t tick_nohz_stop_sched_tick(struct >>> tick_sched *ts, >>> if (!ts->tick_stopped) { >>>

Re: [RFC PATCH v1 00/11] Create fast idle path for short idle periods

2017-07-11 Thread Li, Aubrey
On 2017/7/12 0:09, Frederic Weisbecker wrote: > On Tue, Jul 11, 2017 at 11:41:57AM +0200, Peter Zijlstra wrote: >> >>> - totally from arch_cpu_idle_enter entry to arch_cpu_idle_exit return costs >>> 9122ns - 15318ns. >>> --In this period, rcu_idle_enter costs 1985ns - 2262ns, rcu_idle_exit >>>

Re: [RFC PATCH v1 04/11] sched/idle: make the fast idle path for short idle periods

2017-07-11 Thread Li, Aubrey
On 2017/7/12 2:11, Paul E. McKenney wrote: > On Tue, Jul 11, 2017 at 06:33:55PM +0200, Frederic Weisbecker wrote: >> On Tue, Jul 11, 2017 at 05:58:47AM -0700, Paul E. McKenney wrote: >>> On Mon, Jul 10, 2017 at 09:38:34AM +0800, Aubrey Li wrote: From: Aubrey Li The system will enter

Re: [RFC PATCH v1 00/11] Create fast idle path for short idle periods

2017-07-11 Thread Li, Aubrey
On 2017/7/12 0:34, Peter Zijlstra wrote: > On Tue, Jul 11, 2017 at 06:09:27PM +0200, Frederic Weisbecker wrote: > - tick_nohz_idle_enter costs 7058ns - 10726ns - tick_nohz_idle_exit costs 8372ns - 20850ns >>> >>> Right, those are horrible expensive, but skipping them isn't 'hard', the >>

Re: [RFC PATCH v1 04/11] sched/idle: make the fast idle path for short idle periods

2017-07-11 Thread Li, Aubrey
On 2017/7/12 13:03, Paul E. McKenney wrote: > On Wed, Jul 12, 2017 at 11:19:59AM +0800, Li, Aubrey wrote: >> On 2017/7/12 2:11, Paul E. McKenney wrote: >>> On Tue, Jul 11, 2017 at 06:33:55PM +0200, Frederic Weisbecker wrote: >>>> On Tue, Jul 11, 2017 at 05:58:47AM

Re: [RFC PATCH v1 00/11] Create fast idle path for short idle periods

2017-07-17 Thread Li, Aubrey
On 2017/7/14 12:05, Paul E. McKenney wrote: > > More specifically: rcu_needs_cpu(), rcu_prepare_for_idle(), > rcu_cleanup_after_idle(), rcu_eqs_enter(), rcu_eqs_enter_common(), > rcu_dynticks_eqs_enter(), do_nocb_deferred_wakeup(), > rcu_dynticks_task_enter(), rcu_eqs_exit(), rcu_eqs_exit_common(),

Re: [RFC PATCH v1 00/11] Create fast idle path for short idle periods

2017-07-17 Thread Li, Aubrey
On 2017/7/17 17:21, Peter Zijlstra wrote: > On Fri, Jul 14, 2017 at 09:03:14AM -0700, Andi Kleen wrote: >> fast idle doesn't have an upper bound. >> >> If the prediction exceeds the fast idle threshold any C state can be used. >> >> It's just another state (fast C1), but right now it has an own thr

Re: [RFC PATCH v1 00/11] Create fast idle path for short idle periods

2017-07-17 Thread Li, Aubrey
On 2017/7/17 21:58, Peter Zijlstra wrote: > On Mon, Jul 17, 2017 at 09:24:51PM +0800, Li, Aubrey wrote: >> On 2017/7/14 12:05, Paul E. McKenney wrote: >>> >>> More specifically: rcu_needs_cpu(), rcu_prepare_for_idle(), >>> rcu_cleanup_after_idle(), r

Re: [RFC PATCH v1 00/11] Create fast idle path for short idle periods

2017-07-17 Thread Li, Aubrey
On 2017/7/18 3:23, Peter Zijlstra wrote: > On Fri, Jul 14, 2017 at 09:26:19AM -0700, Andi Kleen wrote: >>> And as said; Daniel has been working on a better predictor -- now he's >>> probably not used it on the network workload you're looking at, so that >>> might be something to consider. >> >> Der

Re: [RFC PATCH v1 00/11] Create fast idle path for short idle periods

2017-07-17 Thread Li, Aubrey
On 2017/7/18 3:48, Arjan van de Ven wrote: > On 7/17/2017 12:23 PM, Peter Zijlstra wrote: >> Of course, this all assumes a Gaussian distribution to begin with, if we >> get bimodal (or worse) distributions we can still get it wrong. To fix >> that, we'd need to do something better than what we curr

Re: [RFC PATCH v1 00/11] Create fast idle path for short idle periods

2017-07-17 Thread Li, Aubrey
On 2017/7/18 14:43, Thomas Gleixner wrote: > On Mon, 17 Jul 2017, Andi Kleen wrote: > >>> We need a tradeoff here IMHO. I'll check Daniel's work to understand how/if >>> it's better than menu governor. >> >> I still would like to see how the fast path without the C1 heuristic works. >> >> Fast pat

Re: [RFC PATCH v1 00/11] Create fast idle path for short idle periods

2017-07-18 Thread Li, Aubrey
On 2017/7/18 23:20, Paul E. McKenney wrote: >> 2) for rcu idle enter/exit, I measured the details which Paul provided, and >> the result matches with what I have measured before, nothing notable found. >> But it still makes more sense if we can make rcu idle enter/exit hooked with >> tick off. (it

Re: [RFC PATCH v1 00/11] Create fast idle path for short idle periods

2017-07-18 Thread Li, Aubrey
On 2017/7/18 15:19, Thomas Gleixner wrote: > On Mon, 17 Jul 2017, Andi Kleen wrote: >> On Tue, Jul 18, 2017 at 08:43:53AM +0200, Thomas Gleixner wrote: >>> On Mon, 17 Jul 2017, Andi Kleen wrote: >>> > We need a tradeoff here IMHO. I'll check Daniel's work to understand > how/if > it's

Re: [RFC PATCH v1 00/11] Create fast idle path for short idle periods

2017-07-19 Thread Li, Aubrey
On 2017/7/19 22:48, Paul E. McKenney wrote: > On Wed, Jul 19, 2017 at 01:44:06PM +0800, Li, Aubrey wrote: >> On 2017/7/18 23:20, Paul E. McKenney wrote: >> >>>> 2) for rcu idle enter/exit, I measured the details which Paul provided, and >>>> the result m

Re: [RFC PATCH v1 00/11] Create fast idle path for short idle periods

2017-07-19 Thread Li, Aubrey
On 2017/7/19 15:55, Thomas Gleixner wrote: > On Wed, 19 Jul 2017, Li, Aubrey wrote: >> On 2017/7/18 15:19, Thomas Gleixner wrote: >>> You can very well avoid it by taking the irq timings or whatever other >>> information into account for the NOHZ decision. >>&g

Re: [RFC PATCH v2 0/8] Introduct cpu idle prediction functionality

2017-11-29 Thread Li, Aubrey
Hi, Thanks Rafael's comments against V2. I'd like to ping here to see which direction this proposal should go and what fundamental change this proposal should make. I'm also open to any suggestions if my proposal is not on the right way. Thanks, -Aubrey On 2017/9/30 15:20, Aubrey Li wrote: > We

[tip:x86/reboot] x86, reboot: Add EFI and CF9 reboot methods into the default list

2014-03-05 Thread tip-bot for Li, Aubrey
Commit-ID: a4f1987e4c5489a3877eaa7451a68d28c5a3f664 Gitweb: http://git.kernel.org/tip/a4f1987e4c5489a3877eaa7451a68d28c5a3f664 Author: Li, Aubrey AuthorDate: Sun, 2 Mar 2014 18:39:02 +0800 Committer: H. Peter Anvin CommitDate: Wed, 5 Mar 2014 15:27:07 -0800 x86, reboot: Add EFI and

[tip:x86/platform] x86/platform: New Intel Atom SOC power management controller driver

2014-07-25 Thread tip-bot for Li, Aubrey
Commit-ID: 93e5eadd1f6e7f45c31aa327c42ac52e4df5ff6f Gitweb: http://git.kernel.org/tip/93e5eadd1f6e7f45c31aa327c42ac52e4df5ff6f Author: Li, Aubrey AuthorDate: Mon, 30 Jun 2014 14:08:42 +0800 Committer: H. Peter Anvin CommitDate: Fri, 25 Jul 2014 14:11:29 -0700 x86/platform: New Intel

[tip:x86/platform] x86/pmc_atom: Eisable a few S0ix wake up events for S0ix residency

2014-07-25 Thread tip-bot for Li, Aubrey
Commit-ID: b00055cade45379fb6a51798b70ef520d7555c5f Gitweb: http://git.kernel.org/tip/b00055cade45379fb6a51798b70ef520d7555c5f Author: Li, Aubrey AuthorDate: Mon, 30 Jun 2014 14:09:38 +0800 Committer: H. Peter Anvin CommitDate: Fri, 25 Jul 2014 14:11:58 -0700 x86/pmc_atom: Eisable a

[tip:x86/platform] x86/pmc_atom: Expose PMC device state and platform sleep state

2014-07-25 Thread tip-bot for Li, Aubrey
Commit-ID: f855911c1f481734191615a7438a396f52a915dc Gitweb: http://git.kernel.org/tip/f855911c1f481734191615a7438a396f52a915dc Author: Li, Aubrey AuthorDate: Mon, 30 Jun 2014 14:10:33 +0800 Committer: H. Peter Anvin CommitDate: Fri, 25 Jul 2014 14:12:14 -0700 x86/pmc_atom: Expose PMC

[tip:x86/urgent] x86/platform, acpi: Bypass legacy PIC and PIT in ACPI hardware reduced mode

2015-03-16 Thread tip-bot for Li, Aubrey
Commit-ID: 7486341a98f26857f383aec88ffa10950087c3a1 Gitweb: http://git.kernel.org/tip/7486341a98f26857f383aec88ffa10950087c3a1 Author: Li, Aubrey AuthorDate: Wed, 11 Mar 2015 16:09:00 +0800 Committer: Ingo Molnar CommitDate: Thu, 12 Mar 2015 12:07:13 +0100 x86/platform, acpi: Bypass

<    1   2   3   4