Re: [PATCH v2 2/5] pci:host: Add Altera PCIe host controller driver

2015-08-03 Thread Ley Foon Tan
On Fri, Jul 31, 2015 at 8:34 PM, Marc Zyngier wrote: > On 31/07/15 11:15, Ley Foon Tan wrote: >> This patch adds the Altera PCIe host controller driver. >> >> Signed-off-by: Ley Foon Tan >> --- >> drivers/pci/host/Kconfig | 8 + >> drivers/pci/hos

Re: [PATCH v2 3/5] pci: altera: Add Altera PCIe MSI driver

2015-08-03 Thread Ley Foon Tan
On Fri, Jul 31, 2015 at 8:12 PM, Marc Zyngier wrote: > On 31/07/15 11:15, Ley Foon Tan wrote: >> This patch adds Altera PCIe MSI driver. This soft IP supports configurable >> number of vectors, which is a dts parameter. > > I've reviewed the initial drop of this code;

Re: [PATCH v2 3/5] pci: altera: Add Altera PCIe MSI driver

2015-08-03 Thread Ley Foon Tan
On Mon, Aug 3, 2015 at 6:53 PM, Marc Zyngier wrote: > On 03/08/15 11:37, Ley Foon Tan wrote: >>>> + msg->address_lo = lower_32_bits(addr); >>>> + msg->address_hi = upper_32_bits(addr); >>>> + msg->data = data->hwirq;

Re: [PATCH v3 3/5] pci: altera: Add Altera PCIe MSI driver

2015-08-10 Thread Ley Foon Tan
On Fri, Aug 7, 2015 at 10:44 PM, Marc Zyngier wrote: > On 07/08/15 08:43, Ley Foon Tan wrote: >> This patch adds Altera PCIe MSI driver. This soft IP supports configurable >> number of vectors, which is a dts parameter. >> >> Signed-off-by: Ley Foon Tan >>

Re: [PATCH v3 2/5] pci:host: Add Altera PCIe host controller driver

2015-08-10 Thread Ley Foon Tan
On Fri, Aug 7, 2015 at 10:34 PM, Marc Zyngier wrote: > On 07/08/15 08:42, Ley Foon Tan wrote: >> This patch adds the Altera PCIe host controller driver. >> >> Signed-off-by: Ley Foon Tan >> --- >> drivers/pci/host/Kconfig | 7 + >> drivers/pci/hos

Re: [PATCH v3 4/5] Documentation: dt-bindings: pci: altera pcie device tree binding

2015-08-10 Thread Ley Foon Tan
On Fri, Aug 7, 2015 at 3:43 PM, Ley Foon Tan wrote: > This patch adds the bindings for Altera PCIe host controller driver and > Altera PCIe MSI driver. > > Signed-off-by: Ley Foon Tan > --- > .../devicetree/bindings/pci/altera-pcie-msi.txt| 27 > .../de

[PATCH v7 1/6] arm: add msi.h to Kbuild

2015-09-20 Thread Ley Foon Tan
Include asm-generic/msi.h to support CONFIG_GENERIC_MSI_IRQ_DOMAIN. This to fix compilation error: "include/linux/msi.h:123:21: fatal error: asm/msi.h: No such file or directory" Signed-off-by: Ley Foon Tan --- arch/arm/include/asm/Kbuild | 1 + 1 file changed, 1 insertion(+) diff --

[PATCH v7 3/6] pci:host: Add Altera PCIe host controller driver

2015-09-20 Thread Ley Foon Tan
This patch adds the Altera PCIe host controller driver. Signed-off-by: Ley Foon Tan --- drivers/pci/host/Kconfig | 8 + drivers/pci/host/Makefile | 1 + drivers/pci/host/pcie-altera.c | 591 + 3 files changed, 600 insertions(+) create mode

[PATCH v7 2/6] pci: add Altera PCI vendor ID

2015-09-20 Thread Ley Foon Tan
Signed-off-by: Ley Foon Tan --- include/linux/pci_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index d9ba49c..08e4462 100644 --- a/include/linux/pci_ids.h +++ b/include/linux/pci_ids.h @@ -1550,6 +1550,8 @@ #define

[PATCH v7 6/6] MAINTAINERS: Add Altera PCIe and MSI drivers maintainer

2015-09-20 Thread Ley Foon Tan
Signed-off-by: Ley Foon Tan --- MAINTAINERS | 16 1 file changed, 16 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7ba7ab7..eeb9ec9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7938,6 +7938,14 @@ F: include/linux/pci* F: arch/x86/pci/ F: arch/x86

[PATCH v7 4/6] pci: altera: Add Altera PCIe MSI driver

2015-09-20 Thread Ley Foon Tan
This patch adds Altera PCIe MSI driver. This soft IP supports configurable number of vectors, which is a dts parameter. Signed-off-by: Ley Foon Tan Reviewed-by: Marc Zyngier --- drivers/pci/host/Kconfig | 8 + drivers/pci/host/Makefile | 1 + drivers/pci/host/pcie-altera

[PATCH v7 5/6] Documentation: dt-bindings: pci: altera pcie device tree binding

2015-09-20 Thread Ley Foon Tan
This patch adds the bindings for Altera PCIe host controller driver and Altera PCIe MSI driver. Signed-off-by: Ley Foon Tan --- .../devicetree/bindings/pci/altera-pcie-msi.txt| 28 + .../devicetree/bindings/pci/altera-pcie.txt| 49 ++ 2 files changed

[PATCH v7 0/6] Altera PCIe host controller driver with MSI support

2015-09-20 Thread Ley Foon Tan
5/7/28/395 [v2]: https://lkml.org/lkml/2015/7/31/267 [v3]: http://www.kernelhub.org/?msg=811940&p=2 [v4]: https://lkml.org/lkml/2015/8/17/141 [v5]: https://lkml.org/lkml/2015/8/25/238 [v6]: https://lkml.org/lkml/2015/9/1/177 Ley Foon Tan (6): arm: add msi.h to Kbuild pci: add Altera PCI

[PATCH 2/2] PCI: Build setup-irq.o for nios2

2015-09-22 Thread Ley Foon Tan
nios2 requires setup-irq.o to provide pci_fixup_irqs() implementation. Signed-off-by: Ley Foon Tan --- drivers/pci/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/Makefile b/drivers/pci/Makefile index 73e4af4..db8efcd 100644 --- a/drivers/pci/Makefile +++ b/drivers/pci

[PATCH 0/2] Add PCI support on nios2 architecture

2015-09-22 Thread Ley Foon Tan
This patchset adding pci support for nios2 architecture. It requires pci_fixup_irqs() from setup-irq.c. Ley Foon Tan (2): nios2: Add architectural support for PCIe PCI: Build setup-irq.o for nios2 arch/nios2/Kconfig| 24 + arch/nios2/include/asm/Kbuild | 2

[PATCH 1/2] nios2: Add architectural support for PCIe

2015-09-22 Thread Ley Foon Tan
This patch add pcie support on nios2 platform. Signed-off-by: Ley Foon Tan --- arch/nios2/Kconfig| 24 + arch/nios2/include/asm/Kbuild | 2 +- arch/nios2/include/asm/io.h | 11 +- arch/nios2/include/asm/pci.h | 50

Re: [PATCH 1/2] nios2: Add architectural support for PCIe

2015-09-22 Thread Ley Foon Tan
On Tue, Sep 22, 2015 at 4:18 PM, Arnd Bergmann wrote: > On Tuesday 22 September 2015 15:19:26 Ley Foon Tan wrote: >> + >> +config PCI_SYSCALL >> + def_bool PCI > > IIRC, PCI_SYSCALL is deprecated and you should just leave that > turned off. > > In any ca

Re: [PATCH 07/31] Add debugger entry points for NIOS2

2016-01-28 Thread Ley Foon Tan
On Fri, Jan 29, 2016 at 3:46 AM, Jeffrey Merkey wrote: > This patch series adds an export which can be set by system debuggers to > direct the hard lockup and soft lockup detector to trigger a breakpoint > exception and enter a debugger if one is active. It is assumed that if > someone sets this

Re: [PATCH 1/2] PCI: altera: Fix configuration type based on secondary number

2019-06-11 Thread Ley Foon Tan
On Thu, May 30, 2019 at 11:25 PM Lorenzo Pieralisi wrote: > > On Fri, May 24, 2019 at 02:07:25PM +0800, Ley Foon Tan wrote: > > This fix issue when access config from PCIe switch. > > > > Stratix 10 PCIe controller does not support Type 1 to Type 0 conversion > >

[PATCH v2] PCI: altera: Fix configuration type based on secondary number

2019-06-11 Thread Ley Foon Tan
targeting the immediate device on the link. The PCIe controller send Type 1 config TLP if the targeting bus is larger than the secondary bus, which is when the TLP is targeting the device not immediate on the link. Signed-off-by: Ley Foon Tan --- v2: - Add get_tlp_header() function. --- drivers/pci

Re: [PATCH] PCI: altera-msi: Allow building as module

2019-05-15 Thread Ley Foon Tan
On Wed, May 15, 2019 at 9:59 PM Lorenzo Pieralisi wrote: > > On Tue, May 14, 2019 at 01:35:20PM +0800, Ley Foon Tan wrote: > > On Wed, Apr 24, 2019 at 12:57 PM Ley Foon Tan > > wrote: > > > > > > Altera MSI IP is a soft IP and is only available

[GIT PULL] arch/nios2 fix for v4.11

2017-04-04 Thread Ley Foon Tan
Hi Linus There is one arch/nios2 fix for v4.11. Please consider pulling. Regards Ley Foon The following changes since commit a71c9a1c779f2499fb2afc0553e543f18aff6edf:   Linux 4.11-rc5 (2017-04-02 17:23:54 -0700) are available in the git repository at:   git://git.kernel.org/pub/scm/linux/ke

Re: [PATCH 1/1] nios2: implement flush_dcache_mmap_lock/unlock

2017-04-11 Thread Ley Foon Tan
lock) > +#define flush_dcache_mmap_unlock(mapping) \ > +   spin_unlock_irq(&(mapping)->tree_lock) > >  #endif /* _ASM_NIOS2_CACHEFLUSH_H */ > -- > 2.11.0 > Acked-by: Ley Foon Tan Regards Ley Foon

Re: [PATCH] nios2: reserve boot memory for device tree

2017-04-02 Thread Ley Foon Tan
gt; Reported-by: Guenter Roeck > Reference: http://lkml.kernel.org/r/20170226210338.GA19476@roeck-us.n > et > Tested-by: Guenter Roeck > Signed-off-by: Tobias Klauser Acked-by: Ley Foon Tan Thanks for the fix. Will add this for 4.11. Regards Ley Foon > --- >  arch/nios2/ker

[GIT PULL] arch/nios2 update for v4.16-rc1

2018-02-11 Thread Ley Foon Tan
Hi Linus Here is nios2 update for v4.16-rc1. Please consider pulling. Regards Ley Foon The following changes since commit d8a5b80568a9cb66810e75b182018e9edb68e8ff:   Linux 4.15 (2018-01-28 13:20:33 -0800) are available in the git repository at:   git://git.kernel.org/pub/scm/linux/kernel/git

Re: linux-next: Signed-off-by missing for commits in the nios2 tree

2018-02-11 Thread Ley Foon Tan
On Mon, 2018-02-12 at 09:20 +1100, Stephen Rothwell wrote: > Hi Ley, > > Commits > >   5d13c7317998 ("nios2: dts: Remove leading 0x and 0s from bindings > notation") >   e0691ebb33c1 ("nios2: defconfig: Cleanup from old Kconfig options") > > are missing a Signed-off-by from their committer. > >

Re: linux-next: Signed-off-by missing for commits in the nios2 tree

2018-02-11 Thread Ley Foon Tan
On Mon, 2018-02-12 at 13:14 +1100, Stephen Rothwell wrote: > Hi Ley, > > On Mon, 12 Feb 2018 09:23:49 +0800 Ley Foon Tan om> wrote: > > > > > > On Mon, 2018-02-12 at 09:20 +1100, Stephen Rothwell wrote: > > > > > > > > > Commits > &

Re: [PATCH 10/11] nios2: kconfig: Remove blank help text

2018-02-01 Thread Ley Foon Tan
rch/nios2/Kconfig > +++ b/arch/nios2/Kconfig > @@ -152,7 +152,6 @@ menu "Advanced setup" > >  config ADVANCED_OPTIONS > bool "Prompt for advanced kernel configuration options" > -   help > >  comment "Default settings for advanced configuration options are > used" > depends on !ADVANCED_OPTIONS > -- > 2.14.1 > Acked-by: Ley Foon Tan

[GIT PULL] arch/nios2 update for v4.14-rc1

2017-09-15 Thread Ley Foon Tan
Hi Linus Here is nios2 update for v4.14-rc1. Please consider pulling. Regards Ley Foon The following changes since commit 569dbb88e80deb68974ef6fdd6a13edb9d686261:   Linux 4.13 (2017-09-03 13:56:17 -0700) are available in the git repository at:   git://git.kernel.org/pub/scm/linux/kernel/gi

[PATCH] PCI: altera: Poll for link training status after retraining the link

2016-08-15 Thread Ley Foon Tan
Poll for link training status is cleared before poll for link up status. This can help to get the reliable link up status, especially when PCIe is in Gen 3 speed. Signed-off-by: Ley Foon Tan --- drivers/pci/host/pcie-altera.c | 45 ++ 1 file changed, 37

Re: [PATCHv2 4/4] nios2: dts: 10m50: Add tx-threshold parameter

2016-10-03 Thread Ley Foon Tan
/nios2/boot/dts/10m50_devboard.dts > @@ -83,6 +83,7 @@ > fifo-size = <32>; > reg-io-width = <4>; > reg-shift = <2>; > + tx-threshold = <16>; > }; > > sysid: sysid@18001528 { Acked-by: Ley Foon Tan

[PATCH] PCI: altera: Retrain link in rootport mode only

2016-08-15 Thread Ley Foon Tan
-off-by: Ley Foon Tan --- drivers/pci/host/pcie-altera.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c index 58eef99..6477738 100644 --- a/drivers/pci/host/pcie-altera.c +++ b/drivers/pci/host/pcie-altera.c @@ -139,6 +139,9

<    2   3   4   5   6   7