check at very beginning of spi_imx_u32_swap_u[8|16](),
> to avoid such crash.
>
> Signed-off-by: Jiada Wang
> Reported-by: Leonard Crestez
Tested-by: Leonard Crestez
On Wed, 2017-07-12 at 13:36 +0200, Rafael J. Wysocki wrote:
> On Wed, Jul 12, 2017 at 1:29 PM, Leonard Crestez
> wrote:
> >
> > This checks that the cpufreq driver actually sets the requested
> > frequency.
> This won't work on modern x86 with APERF/MPERF (s
On Fri, 2017-07-14 at 09:48 +0100, Srinivas Kandagatla wrote:
> On 12/07/17 07:36, Shawn Guo wrote:
> > > +static int nvmem_cell_read_u32(struct device* dev, const char *cell_id,
> > > u32 *val)
> > > +{
> > > + struct nvmem_cell *cell;
> > > + void *buf;
> > > + size_t len;
> > > +
> > > + cell
: https://lkml.org/lkml/2017/7/6/426
Leonard Crestez (5):
thermal: imx: Add nvmem-cells alternate binding for OCOTP access
nvmem: core: Add nvmem_cell_read_u32
thermal: imx: Add support for reading OCOTP through nvmem
ARM: dts: imx6sx: Use nvmem-cells for tempmon
ARM: dts: imx6ul: Add imx6ul
This function does a quick and easy read of an u32 value without any
kind of resource management code on the consumer side.
Signed-off-by: Leonard Crestez
---
drivers/nvmem/core.c | 37 +
include/linux/nvmem-consumer.h | 8
2 files changed
nn
Signed-off-by: Leonard Crestez
---
arch/arm/boot/dts/imx6sx.dtsi | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
index f16b9df..580af30 100644
--- a/arch/arm/boot/dts/imx6sx.dtsi
+++ b/arch/ar
This works identically to imx6sx-tempmon on both imx6ul and imx6ull.
It just needs to be defined in dts.
Signed-off-by: Leonard Crestez
---
arch/arm/boot/dts/imx6ul.dtsi | 19 +++
1 file changed, 19 insertions(+)
diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts
-by: Leonard Crestez
---
drivers/thermal/imx_thermal.c | 103 ++
1 file changed, 73 insertions(+), 30 deletions(-)
diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c
index fb648a4..130405c 100644
--- a/drivers/thermal/imx_thermal.c
because it still
works fine on imx6qdl series chips.
In theory this problem could be solved by adding a reference to the
OCOTP clock instead but it is better to hide such details in a specific
nvmem driver.
Signed-off-by: Leonard Crestez
---
Documentation/devicetree/bindings/thermal/imx-thermal.txt
This checks that the cpufreq driver actually sets the requested
frequency.
Signed-off-by: Leonard Crestez
---
I've been looking at using kselftests for imx. This patch exposes an
issue with the imx6 cpufreq driver on imx6sx where frequencies are set
incorrectly because of clk mishandling.
On Tue, 2017-07-04 at 11:54 -0700, Eduardo Valentin wrote:
> On Mon, Jun 19, 2017 at 04:40:43PM +0300, Leonard Crestez wrote:
> >
> > On imx6sx accessing the ocotp memory area directly is wrong because the
> > ocotp clock needs to be enabled first. Fix this by reinterpretin
interesting.
Link: https://lkml.org/lkml/2017/6/19/333
Leonard Crestez (4):
thermal: imx: Add nvmem-cells alternate binding for OCOTP access
thermal: imx: Add support for reading OCOTP through nvmem
ARM: dts: imx6sx: Use nvmem-cells for tempmon
ARM: dts: imx6ul: Add imx6ul-tempmon
-by: Leonard Crestez
---
drivers/thermal/imx_thermal.c | 131 --
1 file changed, 101 insertions(+), 30 deletions(-)
diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c
index fb648a4..ffbd579 100644
--- a/drivers/thermal/imx_thermal.c
This works identically to imx6sx-tempmon on both imx6ul and imx6ull.
It just needs to be defined in dts.
Signed-off-by: Leonard Crestez
---
arch/arm/boot/dts/imx6ul.dtsi | 17 +
1 file changed, 17 insertions(+)
diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts
because it still
works fine on imx6qdl series chips.
In theory this problem could be solved by adding a reference to the
OCOTP clock instead but it is better to hide such details in a specific
nvmem driver.
Signed-off-by: Leonard Crestez
---
Documentation/devicetree/bindings/thermal/imx-thermal.txt
nn
Signed-off-by: Leonard Crestez
---
arch/arm/boot/dts/imx6sx.dtsi | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
index f16b9df..5cfee85 100644
--- a/arch/arm/boot/dts/imx6sx.dtsi
+++ b/arch/ar
On Wed, 2017-06-14 at 18:12 -0700, Thomas Garnier wrote:
> Ensure the address limit is a user-mode segment before returning to
> user-mode. Otherwise a process can corrupt kernel-mode memory and
> elevate privileges [1].
>
> The set_fs function sets the TIF_SETFS flag to force a slow path on
> ret
On Tue, 2017-07-18 at 09:04 -0700, Thomas Garnier wrote:
> On Tue, Jul 18, 2017 at 7:36 AM, Leonard Crestez
> wrote:
> >
> > On Wed, 2017-06-14 at 18:12 -0700, Thomas Garnier wrote:
> > >
> > > Ensure the address limit is a user-mode segment before retur
On Thu, 2017-07-13 at 14:25 +0530, Viresh Kumar wrote:
> On 12-07-17, 14:29, Leonard Crestez wrote:
> >
> > This checks that the cpufreq driver actually sets the requested
> > frequency.
> >
> > Signed-off-by: Leonard Crestez
> >
> > ---
> >
ogic.
The definition of pll1_sys is changed to imx_clk_fixed_factor so that it's
never disabled.
Signed-off-by: Leonard Crestez
---
Some potential issues:
In theory pll1_sys could be explictly kept enabled from cpufreq. It's not
clear this would be better since the intention is to never
On Tue, 2017-07-18 at 12:04 -0700, Thomas Garnier wrote:
> On Tue, Jul 18, 2017 at 10:18 AM, Leonard Crestez
> wrote:
> > On Tue, 2017-07-18 at 09:04 -0700, Thomas Garnier wrote:
> > > On Tue, Jul 18, 2017 at 7:36 AM, Leonard Crestez
> > > wrote:
> > &
On Thu, 2017-12-07 at 06:36 +0100, Oleksij Rempel wrote:
>
> On 07.12.2017 00:11, Christoph Hellwig wrote:
> >
> > >
> > > void (*pm_power_off_prepare)(void);
> > > +EXPORT_SYMBOL(pm_power_off_prepare);
> > EXPORT_SYMBOL_GPL for something this deeply internal, please.
> Ok,
> probably all other
On Fri, 2017-08-25 at 10:07 +0100, Srinivas Kandagatla wrote:
> On 14/07/17 15:11, Leonard Crestez wrote:
> >
> > This function does a quick and easy read of an u32 value without any
> > kind of resource management code on the consumer side.
> >
> &g
he rate is change to deal
with this. Otherwise from the clk framework perspective pll1_sys is
unused and gets turned off.
Signed-off-by: Leonard Crestez
---
Changes since v1:
- Link: https://lkml.org/lkml/2017/7/19/302
- Only keep pll1_sys enabled until after ARM rate is changed.
- Incorporate more
t it should work at least at the
Kconfig level.
> Fixes: 7fe5ba04fcdc ("thermal: imx: Add support for reading OCOTP through
> nvmem")
> Signed-off-by: Arnd Bergmann
Reviewed-by: Leonard Crestez
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 07
the original
patch should be reverted first, separately? In this particular case the
series fixing the bug actually includes the revert.
Anyway, I check that this v3 works on my board which was reproducing
the issue while booting from nfs (imx6sl-evk). The most likely reason
it's easy to reproduce here is a network driver issue where headers are
not correctly aligned to 4. This causes lots of alignment faults.
Tested-by: Leonard Crestez
--
Regards,
Leonard
On Wed, Mar 22, 2017 at 5:01 PM, Philipp Zabel wrote:
> On Wed, 2017-03-22 at 08:26 -0500, Rob Herring wrote:
> >
> > Similar to the previous commit, convert drivers open coding OF graph
> > parsing to use drm_of_find_panel_or_bridge instead.
> >
> > This changes some error messages to debug mes
eauto boards.
Link: https://lists.freedesktop.org/archives/dri-devel/2017-May/141233.html
Fixes: ebc944613567 ("drm: convert drivers to use drm_of_find_panel_or_bridge")
Signed-off-by: Leonard Crestez
---
This relies on drm_of_find_panel_or_bridge returning -ENODEV
specifically if no remo
.
Link: https://lists.freedesktop.org/archives/dri-devel/2017-May/141233.html
Fixes: ebc944613567 ("drm: convert drivers to use drm_of_find_panel_or_bridge")
Signed-off-by: Leonard Crestez
---
This relies on drm_of_find_panel_or_bridge returning -ENODEV
specifically if no remote is fou
'ascii' codec can't encode character u'\u0303' in
position 24: ordinal not in range(128)
Avoid this by explicitly casting to (void *) inside the gdb expression.
Signed-off-by: Leonard Crestez
---
scripts/gdb/linux/dmesg.py | 2 +-
1 file changed, 1 insertion(+),
It is never desirable lx-dmesg to fail on string decoding errors, not
even if the log buffer is corrupt.
Signed-off-by: Leonard Crestez
---
scripts/gdb/linux/dmesg.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/gdb/linux/dmesg.py b/scripts/gdb/linux/dmesg.py
On Fri, 2017-06-23 at 18:02 +0200, Jan Kiszka wrote:
> On 2017-06-23 16:20, Leonard Crestez wrote:
> >
> > It is never desirable lx-dmesg to fail on string decoding errors,
> > not
> > even if the log buffer is corrupt.
> >
> > Signed-off-by: Leonard
'ascii' codec can't encode character u'\u0303' in
position 24: ordinal not in range(128)
Avoid this by explicitly casting to (void *) inside the gdb expression.
Signed-off-by: Leonard Crestez
Reviewed-by: Jan Kiszka
---
Changes since v1:
* Fix title (use
this is
definitely not true for encoding='ascii', unknown characters are
replaced with U+FFFD REPLACEMENT CHARACTER and they fail to encode back
to ascii.
Signed-off-by: Leonard Crestez
---
Changes since v1:
* Add encoding='utf8'
* Only do an explicit encode for python2. On
On Tue, 2017-05-30 at 11:05 -0700, Florian Fainelli wrote:
> On 05/30/2017 10:34 AM, Leonard Crestez wrote:
> > These bits seem to be lost after a suspend/resume cycle so just set them
> > again.
> >
> > This patch fixes ethernet suspend/resume on imx6ul-14x14-evk boa
On Tue, 2017-05-30 at 11:10 -0700, Florian Fainelli wrote:
> On 05/30/2017 10:34 AM, Leonard Crestez wrote:
> > Right now mach-imx6ul registers a fixup for the ksz8081 phy. The same
> > register values can be set through the micrel phy driver by using dts
> > properties
On Tue, 2017-05-30 at 15:19 -0700, Florian Fainelli wrote:
> On 05/30/2017 03:08 PM, Leonard Crestez wrote:
> > On Tue, 2017-05-30 at 11:05 -0700, Florian Fainelli wrote:
> > > Should not we actually call kszphy_config_init() in order to restore
> > > broadcast an
These bits seem to be lost after a suspend/resume cycle so just set them
again. Do this by splitting the handling of these bits into a function
that is also called on resume.
This patch fixes ethernet suspend/resume on imx6ul-14x14-evk boards.
Signed-off-by: Leonard Crestez
---
drivers/net/phy
esume. Calling config_init directly could be an option but
on some HW variants it does extra stuff like parsing devicetree options.
That would not be appropriate for resume code.
Leonard Crestez (2):
ARM: dts: imx6ul-14x14-evk: Add ksz8081 phy properties
net: phy: micrel: Restore led_mode and cl
Right now mach-imx6ul registers a fixup for the ksz8081 phy. The same
register values can be set through the micrel phy driver by using dts
properties.
This seems preferable and allows cleanly fixing suspend/resume.
Signed-off-by: Leonard Crestez
Reviewed-by: Fabio Estevam
---
arch/arm/boot
On Mon, 2017-05-01 at 03:31 -0700, jiada_w...@mentor.com wrote:
> From: Jiada Wang
>
> previously burst length (BURST_LENGTH) is always set to equal
> to bits_per_word, causes a 10us gap between each word in
> transfer, which significantly affects performance.
>
> This patch uses 32 bits transfe
On Mon, 2017-06-05 at 13:37 +0800, Shawn Guo wrote:
> On Tue, May 30, 2017 at 07:11:19PM +0300, Leonard Crestez wrote:
> >
> > Suspend and resume on imx6ull is currenty not working because of some
> > missed checks where behavior should match imx6ul.
> >
> &g
On Fri, 2017-06-02 at 16:59 +0530, Viresh Kumar wrote:
> The transition_latency_ns represents the maximum time it can take for
> the hardware to switch from/to any frequency for a CPU.
>
> The transition_latency_ns is used currently for two purposes:
>
> o To check if the hardware latency is over
Suspend and resume on imx6ull is currenty not working because of some
missed checks where behavior should match imx6ul.
Signed-off-by: Leonard Crestez
---
arch/arm/mach-imx/pm-imx6.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-imx/pm-imx6.c b/arch/arm
x6qdl. But this would be an unrelated cleanup and affect other chips
as well (everything other that imx6qdl).
Changes since v1 https://lkml.org/lkml/2017/5/30/584 :
* Split adding MXC_CPU_IMX6ULL into a separate patch
* While we're at it fix soc_id reading "Unknown"
Leonard Cre
Support for imx6ull is already present but it's based on
of_machine_is_compatible("fsl,imx6ull") checks. Add it to the MXC_CPU_*
enumeration as well.
This also fixes /sys/devices/soc0/soc_id reading "Unknown".
Signed-off-by: Leonard Crestez
---
arch/arm/mach-imx/cpu
On Wed, 2017-06-07 at 03:38 +, Anson Huang wrote:
> > -Original Message-
> > From: Shawn Guo [mailto:shawn...@kernel.org]
> > Sent: 2017-06-07 11:21 AM
> > To: Anson Huang
> > Cc: Leonard Crestez ; Peter Chen
> > ; linux-kernel@vger.kernel.or
On Wed, 2017-05-10 at 15:55 +0200, Philipp Zabel wrote:
> On Wed, 2017-05-10 at 16:17 +0300, Leonard Crestez wrote:
> >
> > Not having an endpoint bound in DT should not cause a failure here,
> > there are fallbacks. So explicitly accept a missing endpoint.
> >
&
On Thu, 2017-06-08 at 13:45 -0300, Fabio Estevam wrote:
> On Thu, Jun 8, 2017 at 1:26 PM, Leonard Crestez wrote:
>
> >
> > + tempmon: tempmon {
> > + compatible = "fsl,imx6ul-tempm
On Fri, 2017-06-09 at 15:46 +0200, Lothar Waßmann wrote:
> On Fri, 9 Jun 2017 13:58:15 +0300 Leonard Crestez wrote:
> > On Thu, 2017-06-08 at 13:45 -0300, Fabio Estevam wrote:
> > > On Thu, Jun 8, 2017 at 1:26 PM, Leonard Crestez wrote:
> > > > +
On Mon, 2017-06-12 at 12:40 +0200, Lothar Waßmann wrote:
> On Fri, 9 Jun 2017 18:34:44 +0300 Leonard Crestez wrote:
> >
> > On Fri, 2017-06-09 at 15:46 +0200, Lothar Waßmann wrote:
> > >
> > > On Fri, 9 Jun 2017 13:58:15 +0300 Leonard Crestez wrote:
> > &
On Wed, 2017-05-03 at 17:59 +0200, Marek Vasut wrote:
> On 05/03/2017 04:58 PM, Leonard Crestez wrote:
> > On Wed, 2017-05-03 at 16:26 +0200, Marek Vasut wrote:
> > > 2) It actually fixes a problem with the voltage rails such that the DVFS
> > > works without leavin
On Wed, 2017-05-03 at 21:33 +0200, Marek Vasut wrote:
> On 05/03/2017 07:58 PM, Leonard Crestez wrote:
> > On Wed, 2017-05-03 at 17:59 +0200, Marek Vasut wrote:
> > > On 05/03/2017 04:58 PM, Leonard Crestez wrote:
> > > > On Wed, 2017-05-03 at 16:26 +0200, Marek
On Fri, 2017-05-05 at 09:18 +0800, Shawn Guo wrote:
> On Thu, May 04, 2017 at 04:34:14PM +0200, Marek Vasut wrote:
> > If you model the
> > power distribution correctly, the OPP hackery can be removed.
> The OPP hackery can be removed even without reg_arm/reg_soc modeling.
> That's why we can do h
rev. C, rev. B is reported to still work.
Signed-off-by: Leonard Crestez
CC: sta...@vger.kernel.org
---
It is not known exactly why setting these higher voltages causes crashes.
Maybe this means that it's not appropriate to CC stable?
Removing this override is a correct change anyway be
Enable more common cpufreq governors in imx defconfig because this is
very useful for testing. In particular you can't use cpufreq-set -f
$FREQ without explicitly defining CONFIG_CPU_FREQ_GOV_USERSPACE=y.
Signed-off-by: Leonard Crestez
---
It might make sense for all governors to be enabl
On Wed, 2017-05-03 at 16:26 +0200, Marek Vasut wrote:
> On 05/03/2017 03:57 PM, Shawn Guo wrote:
> >
> > On Tue, Apr 25, 2017 at 07:28:06PM +0200, Marek Vasut wrote:
> > >
> > > On 04/25/2017 07:23 PM, Leonard Crestez wrote:
> > > >
> > > &
Enable cpuidle support on i.MX6DL starting from IMX_CHIP_REVISION_1_1.
This also makes the code cleaner because 6q and 6dl actually have
different revision histories.
Signed-off-by: Bai Ping
Signed-off-by: Leonard Crestez
---
Changes since v1: https://www.spinics.net/lists/arm-kernel
On Mon, 2017-09-18 at 11:08 -0700, Stefano Stabellini wrote:
On Fri, 15 Sep 2017, Greg KH wrote:
> On Thu, Sep 14, 2017 at 04:23:05PM -0700, Stefano Stabellini wrote:
> > Hi all,
> >
> > We are getting reports from Xen on ARM users about DMA issues. The
> > problem is that the commit below
> > (7e
On Sun, 2017-08-27 at 15:58 +0200, Pierre-Hugues Husson wrote:
> Extend the driver to support Ricoh RC5T619.
> Support the additional regulators and slightly different voltage ranges.
>
> @@ -101,10 +131,7 @@ static int rn5t618_regulator_probe(struct
> platform_device *pdev)
> config.dev =
Fix this by making the arrays flat. This also saves a little memory
because the regulator_desc arrays become smaller.
Signed-off-by: Leonard Crestez
Fixes: 83b2a3c2ab24 ("regulator: rn5t618: add RC5T619 PMIC support")
---
An alternative would be to restore the check if (!regulators[i].
Setting trip points is supported by the imx thermal driver and it is
useful to be able to test this without adjusting config.
Signed-off-by: Leonard Crestez
---
arch/arm/configs/imx_v6_v7_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/imx_v6_v7_defconfig
b/arch
This seems to work fine with the existing imx thermal driver on both 6ul
and 6ull. It was just missing in dts.
Signed-off-by: Leonard Crestez
---
arch/arm/boot/dts/imx6ul.dtsi | 8
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts
On Thu, 2017-08-03 at 09:32 +0200, Sébastien Szymanski wrote:
> On 08/03/2017 04:03 AM, Shawn Guo wrote:
> > On Fri, Jul 28, 2017 at 10:36:33AM +0200, Sébastien Szymanski wrote:
> > > Setting the frequency higher than 528Mhz actually sets the ARM
> > > clock to 528MHz. That's because PLL2 is used a
the addr_limit_user_check call at the beginning of the loop.
> >
> > Fixes: 73ac5d6a2b6a ("arm/syscalls: Check address limit on user-
> > mode return")
> > Reported-by: Leonard Crestez
> > Signed-off-by: Thomas Garnier
> Any comments on this patch set
On Wed, 2017-07-19 at 15:42 +0530, Viresh Kumar wrote:
> If transition_delay_us isn't defined by the cpufreq driver, the default
> value of transition delay (time after which the cpufreq governor will
> try updating the frequency again) is currently calculated by multiplying
> transition_latency (n
On Tue, 2017-08-08 at 12:00 +0100, Srinivas Kandagatla wrote:
> On 08/08/17 08:21, Zhang Rui wrote:
> > On Tue, 2017-07-25 at 16:08 +0800, Shawn Guo wrote:
> > > On Fri, Jul 14, 2017 at 05:11:08PM +0300, Leonard Crestez wrote:
> > > > On newer imx SOCs accessing O
On Fri, 2017-07-28 at 10:58 +0530, Viresh Kumar wrote:
> On 27-07-17, 19:54, Leonard Crestez wrote:
> > On Wed, 2017-07-26 at 11:36 +0530, Viresh Kumar wrote:
> > > Without this patch the sampling rate of ondemand governor will be 109
> > > ms. And after this patch it wo
On Mon, 2017-06-19 at 16:40 +0300, Leonard Crestez wrote:
> On imx6sx accessing the ocotp memory area directly is wrong because the
> ocotp clock needs to be enabled first. Fix this by reinterpreting the
> fsl,tempmon-data phandle as a reference to a nvmem_device and doing all
> the
On Mon, 2017-06-19 at 07:02 +0200, Oleksij Rempel wrote:
> Export pm_power_off_prepare. It is needed to implement power off on
> Freescale/NXP iMX6 based boards with external power management
> integrated circuit (PMIC).
>
> Signed-off-by: Oleksij Rempel
> ---
> kernel/reboot.c | 1 +
> 1 file c
On Mon, 2017-06-19 at 07:02 +0200, Oleksij Rempel wrote:
> One of the Freescale recommended sequences for power off with
> external
> PMIC is the following:
> ...
> 3. SoC is programming PMIC for power off when standby is asserted.
> 4. In CCM STOP mode, Standby is asserted, PMIC gates SoC suppli
hermal has completed probing.
If imx-thermal is compiled as a module then the system can hang on
probe.
This makes IMX_THERMAL depend on NVMEM_IMX_OCOTP but that driver seems
be already available for all chips that contain tempmon so it's
acceptable.
Reported-by: Lothar Waßmann
Signed-off-by:
On Wed, 2017-07-26 at 11:36 +0530, Viresh Kumar wrote:
> On 25-07-17, 14:54, Leonard Crestez wrote:
> > This patch made it's way into linux-next and it seems to cause imx socs
> > to almost always hang around their max frequency with the ondemand
> > governor, even w
Commit-ID: 4ce54af8b33d3e21ca935fc1b89b58cbba956051
Gitweb: https://git.kernel.org/tip/4ce54af8b33d3e21ca935fc1b89b58cbba956051
Author: Leonard Crestez
AuthorDate: Wed, 24 Jul 2019 15:53:24 +0300
Committer: Ingo Molnar
CommitDate: Thu, 25 Jul 2019 15:41:31 +0200
perf/core: Fix
301 - 374 of 374 matches
Mail list logo
