Re: [PATCH 0/3] infiniband: IB/hns: Hisilicon RoCE support

2016-03-12 Thread Leon Romanovsky
On Fri, Mar 11, 2016 at 06:37:08PM +0800, Lijun Ou wrote: 1) It is redundant to write "infiniband" and "IB" in one title to mention relevant subsystem, since it is the same. Please take a look on the other submissions here on the list and use similar construction. 2) Please use version number in

Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support

2016-03-12 Thread Leon Romanovsky
On Fri, Mar 11, 2016 at 06:37:09PM +0800, Lijun Ou wrote: > The driver for Hisilicon RoCE is a platform driver. > The driver will support mulitple versions of hardware. Currently only "v1" > for hip06 SOC is supported. > The driver includes two parts: common driver and hardware-specific > operation

Re: [PATCH 2/3] net: hns: add Hisilicon RoCE support

2016-03-13 Thread Leon Romanovsky
On Mon, Mar 14, 2016 at 09:12:28AM +0800, Yankejian (Hackim Yim) wrote: > > > On 2016/3/12 18:43, Leon Romanovsky wrote: > > On Fri, Mar 11, 2016 at 06:37:10PM +0800, Lijun Ou wrote: > >> It added hns_dsaf_roce_reset routine for roce driver. > >> RoCE is a feat

Re: [PATCH 1/5] mlx4: add missing braces in verify_qp_parameters

2016-03-14 Thread Leon Romanovsky
ontained curly braces from the > start, as the update_gid() function in the same patch correctly does. > > Signed-off-by: Arnd Bergmann > Fixes: 54679e148287 ("mlx4: Implement QP paravirtualization and maintain > phys_pkey_cache for smp_snoop") Thanks, looks good. Review

Re: [PATCH 4/4] infiniband: hns: add Hisilicon RoCE support(Kconfig)

2016-03-06 Thread Leon Romanovsky
On Fri, Mar 04, 2016 at 04:41:17PM +0800, Wei Hu(Xavier) wrote: > This submit add Kconfig. It needs be part of previous patch. > > Signed-off-by: Wei Hu(Xavier) > Signed-off-by: oulijun ^^^.. -- Is this first name or second name? > --- > drivers/infiniband/Kconfig |

Re: [PATCH 0/4] infiniband: hns: Hisilicon RoCE support

2016-03-06 Thread Leon Romanovsky
On Fri, Mar 04, 2016 at 04:41:13PM +0800, Wei Hu(Xavier) wrote: > The Hisilicon Network Substem(hns) is a long term evolution IP which is > supposed to be used in Hisilicon ICT SoC. RoCE is a feature of hns. > The driver for Hisilicon RoCE engine is a platform driver. > The driver will support muli

Re: [PATCH 1/4] net: hns: add Hisilicon RoCE support(the dependent routine)

2016-03-06 Thread Leon Romanovsky
Please rewrite your title to be without (...). On Fri, Mar 04, 2016 at 04:41:14PM +0800, Wei Hu(Xavier) wrote: > It added hns_dsaf_roce_reset routine for roce driver. > RoCE is a feature of hns. > In hip06 SOC, in roce reset process, it's needed to configure > dsaf channel reset,port and sl map in

Re: [PATCH RESEND] qib:Fix concurrent access in the function, qib_init_iba6120_funcs

2016-03-07 Thread Leon Romanovsky
On Mon, Mar 07, 2016 at 04:34:04PM +, Marciniszyn, Mike wrote: > > This fixes concurrent access in the function, qib_init_iba6120_funcs by > > locking > > around the calls to when setting up f_sendctrl and f_set_armlauch function > > pointers to the functions, sendctrl_6120_mod qib_set_6120_ar

Re: [PATCH] IB/mlx5: fix VFs callback function prototypes

2016-03-23 Thread Leon Romanovsky
ilable. > > Signed-off-by: Arnd Bergmann > Fixes: eff901d30e6c ("IB/mlx5: Implement callbacks for manipulating VFs") Thanks, Reviewed-by: Leon Romanovsky

Re: linux-next: Tree for Mar 23 (infiniband: mlx5)

2016-03-23 Thread Leon Romanovsky
On Wed, Mar 23, 2016 at 10:26:35AM -0700, Randy Dunlap wrote: > On 03/22/16 19:22, Stephen Rothwell wrote: > > Hi all, > > > > Please do not add any v4.7 related material to your linux-next included > > trees until after v4.6-rc1 is released. > > > > Changes since 20160322: > > > > on i386 or x

Re: call attention to review

2016-03-23 Thread Leon Romanovsky
On Thu, Mar 24, 2016 at 01:50:30PM +0800, oulijun wrote: > Hi, >I am Lijun Ou. I have sent the PATCH v4 of HiSilicon RoCE driver at March > 22, 2016. > if you are convenient, please help to review. Welcome to give your reviewing. Hi Lijun, Please read whole document which describes how to sub

Re: [PATCH v3 2/3] IB/hns: Add HiSilicon RoCE driver support

2016-03-19 Thread Leon Romanovsky
On Sat, Mar 19, 2016 at 06:50:57PM +0800, Lijun Ou wrote: > The driver for HiSilicon RoCE is a platform driver. > The driver will support multiple versions of hardware. Currently only "v1" > for hip06 SoC is supported. > The driver includes two parts: common driver and hardware-specific > operation

Re: [PATCHv6 1/3] rdmacg: Added rdma cgroup controller

2016-02-21 Thread Leon Romanovsky
On Sun, Feb 21, 2016 at 07:41:08PM +0530, Parav Pandit wrote: > CONFIG_CGROUP_RDMA > > On Sun, Feb 21, 2016 at 7:15 PM, Leon Romanovsky wrote: > > On Sun, Feb 21, 2016 at 05:03:05PM +0530, Parav Pandit wrote: > >> On Sun, Feb 21, 2016 at 1:13 PM, Leon Romanovsky wrot

Re: [PATCHv6 1/3] rdmacg: Added rdma cgroup controller

2016-02-21 Thread Leon Romanovsky
On Sun, Feb 21, 2016 at 05:03:05PM +0530, Parav Pandit wrote: > On Sun, Feb 21, 2016 at 1:13 PM, Leon Romanovsky wrote: > > On Sat, Feb 20, 2016 at 04:30:04PM +0530, Parav Pandit wrote: > > Can you place this ifdef before declaring struct rdma_cgroup? > Yes. I missed out

Re: [PATCHv6 1/3] rdmacg: Added rdma cgroup controller

2016-02-21 Thread Leon Romanovsky
On Sat, Feb 20, 2016 at 04:30:04PM +0530, Parav Pandit wrote: > Added rdma cgroup controller that does accounting, limit enforcement > on rdma/IB verbs and hw resources. > > Added rdma cgroup header file which defines its APIs to perform > charing/uncharing functionality and device registration wh

Re: [PATCH 2/5] x86, mpx: do not set ->vm_ops on mpx VMAs

2015-07-13 Thread Leon Romanovsky
, > * so stop immediately and return an error. This > * probably results in a SIGSEGV. > */ > - if (!is_mpx_vma(vma)) > + if (!(vma->vm_flags & VM_MPX)) > return -EINVAL;

Re: [PATCH 2/5] x86, mpx: do not set ->vm_ops on mpx VMAs

2015-07-13 Thread Leon Romanovsky
On Mon, Jul 13, 2015 at 3:29 PM, Kirill A. Shutemov wrote: > Leon Romanovsky wrote: >> Hi Kirill, >> >> On Mon, Jul 13, 2015 at 1:54 PM, Kirill A. Shutemov >> wrote: >> > >> > MPX setups private anonymous mapping, but uses vma->vm_ops too. &

Re: [PATCH 0/2] InfiniBand-iSER: Refactoring for two function implementations

2015-12-27 Thread Leon Romanovsky
On Sun, Dec 27, 2015 at 01:36:30PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 27 Dec 2015 13:12:10 +0100 > Subject: [PATCH 0/2] InfiniBand-iSER: Refactoring for two function > implementations Just a note for the future submissions (no need to respin), we are using differe

Re: [PATCH 0/2] InfiniBand-iSER: Refactoring for two function implementations

2015-12-27 Thread Leon Romanovsky
p label "err" > in two functions (which are working without clean-up there). > > Markus Elfring (2): > One jump label less in iser_reg_sig_mr() > One jump label less in isert_reg_sig_mr() Looks good, Reviewed-by: Leon Romanovsky > > drivers/infiniband/ulp/iser/

[PATCH] checkpatch.pl: perform commit ID check from external to git folder

2020-06-11 Thread Leon Romanovsky
From: Leon Romanovsky The execution of scripts/checkpatch.pl in folder outside of git produces complains about invalid commit ID, despite having valid one. ➜ /tmp /home/leonro/src/kernel/scripts/checkpatch.pl \ --root=/home/leonro/src/kernel \ --color=always \ --summary

[PATCH] fs: Delete always true compilation define

2020-06-11 Thread Leon Romanovsky
From: Leon Romanovsky In commit 1027abe8827b ("[PATCH] merge locate_fd() and get_unused_fd()") the existing "#if 1" was moved from one place to another. Originally that compilation define was set for the sanity check and more than 12 years later it is safe to remove it.

Re: [PATCH] checkpatch.pl: perform commit ID check from external to git folder

2020-06-11 Thread Leon Romanovsky
On Thu, Jun 11, 2020 at 11:22:41AM -0700, Joe Perches wrote: > On Thu, 2020-06-11 at 15:59 +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > The execution of scripts/checkpatch.pl in folder outside of git produces > > complains about invalid commit I

[PATCH rdma-next 0/6] Cleanup mlx5_ib main file

2020-07-02 Thread Leon Romanovsky
From: Leon Romanovsky Over the years, the main.c file grew above all imagination and was >8K LOC of the code. This caused to a huge burden while I started to work on ib_flow allocation patches. This series implements long standing "internal" wish to move flow logic from the mai

[PATCH rdma-next 0/3] Global per-type support for QP counters

2020-07-02 Thread Leon Romanovsky
From: Leon Romanovsky Hi, This series from Mark extends netlink interface to allow automatic binding of QP counters based on their type, in very similar manner to already existing per-PID ability. Thanks Mark Zhang (3): RDMA/counter: Add PID category support in auto mode RDMA/counter

Re: [PATCH rdma-next 0/6] Cleanup mlx5_ib main file

2020-07-02 Thread Leon Romanovsky
On Thu, Jul 02, 2020 at 10:08:09AM -0300, Jason Gunthorpe wrote: > On Thu, Jul 02, 2020 at 11:18:03AM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Over the years, the main.c file grew above all imagination and was >8K > > LOC of the code. This c

[PATCH rdma-next v1 0/7] Introduce UAPIs to query UCONTEXT, PD and MR properties

2020-06-30 Thread Leon Romanovsky
From: Leon Romanovsky Changelog v1: * Replaced "KABI" word with "UAPI". * Set IOVA as an optional attribute upon query MR. v0: https://lore.kernel.org/lkml/20200616105531.2428010-1-l...@kernel.org ---

[PATCH rdma-next v1 0/4] ib_core allocation patches

2020-06-30 Thread Leon Romanovsky
From: Leon Romanovsky Changelog v1: * Removed empty "//" comment * Deleted destroy_rwq_ind_table from object tree * One patch was accepted, so rebased on latest for-upstream v0: https://lore.kernel.org/lkml/20200624105422.1452290-1-l...@

Re: [PATCH rdma-next v1 0/4] ib_core allocation patches

2020-06-30 Thread Leon Romanovsky
On Tue, Jun 30, 2020 at 01:18:51PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Changelog > v1: > * Removed empty "//" comment > * Deleted destroy_rwq_ind_table from object tree > * One patch was accepted, so rebased on latest for-upstream >

Re: [PATCH v4] IB/sa: Resolving use-after-free in ib_nl_send_msg

2020-06-25 Thread Leon Romanovsky
On Tue, Jun 23, 2020 at 07:13:09PM -0700, Divya Indi wrote: > Commit 3ebd2fd0d011 ("IB/sa: Put netlink request into the request list before > sending")' > - > 1. Adds the query to the request list before ib_nl_snd_msg. > 2. Moves ib_nl_send_msg out of spinlock, hence safe to use gfp_mask as is. >

Re: [PATCH v4] IB/sa: Resolving use-after-free in ib_nl_send_msg

2020-06-25 Thread Leon Romanovsky
On Thu, Jun 25, 2020 at 10:11:07AM -0700, Divya Indi wrote: > Hi Leon, > > Please find my comments inline - > > On 6/25/20 3:09 AM, Leon Romanovsky wrote: > > On Tue, Jun 23, 2020 at 07:13:09PM -0700, Divya Indi wrote: > >> Commit 3ebd2fd0d011 ("IB/sa: Put ne

[PATCH rdma-rc 0/3] Fixes to mlx5_ib driver

2020-07-07 Thread Leon Romanovsky
From: Leon Romanovsky Hi, This is patchset of independent fixes to mlx5_ib driver. Thanks Aya Levin (1): IB/mlx5: Fix 50G per lane indication Leon Romanovsky (1): RDMA/mlx5: Set PD pointers for the error flow unwind Maor Gottlieb (1): RDMA/mlx5: Use xa_lock_irqsave when access to SRQ

Re: [PATCH] rds: send: Replace sg++ with sg = sg_next(sg)

2020-07-07 Thread Leon Romanovsky
On Wed, Jul 08, 2020 at 03:42:52AM +, Xu Wang wrote: > Replace sg++ with sg = sg_next(sg). > > Signed-off-by: Xu Wang > --- > net/rds/send.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/rds/send.c b/net/rds/send.c > index 68e2bdb08fd0..57d03a6753de 100644 > ---

Re: [PATCH][next] IB/hfi1: Use fallthrough pseudo-keyword

2020-07-07 Thread Leon Romanovsky
On Tue, Jul 07, 2020 at 12:39:42PM -0500, Gustavo A. R. Silva wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary > fall-through markings when it is the case. > > [1] > https://www.kernel.org/doc/ht

[PATCH rdma-next 0/2] Align write() and ioctl() paths

2020-07-08 Thread Leon Romanovsky
From: Leon Romanovsky Hi, The discussion about RWQ table patch revealed incosistency with use of usecnt, complex unwind flows without any reason and difference between write() and ioctl() paths. This series extends infrastructure to be consistent, reliable and predicable in regards of commit

[PATCH rdma-rc 0/2] Two small fixes to the mlx5_ib

2020-06-18 Thread Leon Romanovsky
From: Leon Romanovsky Hi, The following two fixes are user-visible one. The first patch is needed to continue to use RAW_PACKET QPs after PR [1] is merged and new FW will be released. The second patch fixes wrongly reported GID. Thanks [1] https://github.com/linux-rdma/rdma-core/pull/745

[PATCH rdma-next v1 0/2] Convert XRC to use xarray

2020-06-23 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v1: Changed ib_dealloc_xrcd_user() do not iterate over tgt list, because it is expected to be empty. v0: https://lore.kernel.org/lkml/20200621104110.53509-1-l...@kernel.org Two small patches to simplify and improve XRC logic. Thanks Maor Gottlieb (2): RDMA

Re: [PATCH v3] IB/sa: Resolving use-after-free in ib_nl_send_msg

2020-06-13 Thread Leon Romanovsky
On Tue, Jun 09, 2020 at 07:45:21AM -0700, Divya Indi wrote: > Hi Leon, > > Thanks for taking the time to review. > > Please find my comments inline - > > On 6/9/20 12:00 AM, Leon Romanovsky wrote: > > On Mon, Jun 08, 2020 at 07:46:16AM -0700, Divya Indi wrote: > >&

Re: [PATCH blk-next 1/2] blk-mq-rdma: Delete not-used multi-queue RDMA map queue code

2020-10-05 Thread Leon Romanovsky
On Mon, Oct 05, 2020 at 10:38:17AM +0200, Christoph Hellwig wrote: > On Fri, Oct 02, 2020 at 01:20:35PM -0700, Sagi Grimberg wrote: > >> Well, why would they change it? The whole point of the infrastructure > >> is that there is a single sane affinity setting for a given setup. Now > >> that setti

Re: [PATCH rdma-next v4 4/4] RDMA/umem: Move to allocate SG table from pages

2020-09-30 Thread Leon Romanovsky
On Tue, Sep 29, 2020 at 04:59:29PM -0300, Jason Gunthorpe wrote: > On Sun, Sep 27, 2020 at 09:46:47AM +0300, Leon Romanovsky wrote: > > @@ -296,11 +223,17 @@ static struct ib_umem *__ib_umem_get(struct ib_device > > *device, > > goto umem_release; > &g

Re: [PATCH] [v2] wireless: Initial driver submission for pureLiFi devices

2020-09-30 Thread Leon Romanovsky
On Wed, Sep 30, 2020 at 11:01:27AM +0300, Kalle Valo wrote: > Leon Romanovsky writes: > > >> diff --git a/drivers/net/wireless/purelifi/Kconfig > > b/drivers/net/wireless/purelifi/Kconfig > >> new file mode 100644 > >> index ..ff05eaf0a8d4 &g

Re: [PATCH] [v2] wireless: Initial driver submission for pureLiFi devices

2020-09-30 Thread Leon Romanovsky
On Wed, Sep 30, 2020 at 11:05:49AM +0300, Kalle Valo wrote: > Leon Romanovsky writes: > > >> --- /dev/null > >> +++ b/drivers/net/wireless/purelifi/Kconfig > >> @@ -0,0 +1,38 @@ > >> +# SPDX-License-Identifier: GPL-2.0 > >> +config

Re: [PATCH] [v2] wireless: Initial driver submission for pureLiFi devices

2020-09-30 Thread Leon Romanovsky
On Wed, Sep 30, 2020 at 12:11:24PM +0200, Johannes Berg wrote: > On Wed, 2020-09-30 at 12:55 +0300, Leon Romanovsky wrote: > > On Wed, Sep 30, 2020 at 11:01:27AM +0300, Kalle Valo wrote: > > > Leon Romanovsky writes: > > > > > > > > diff --git a/drive

Re: [PATCH rdma-next v4 4/4] RDMA/umem: Move to allocate SG table from pages

2020-09-30 Thread Leon Romanovsky
On Wed, Sep 30, 2020 at 12:14:06PM -0300, Jason Gunthorpe wrote: > On Wed, Sep 30, 2020 at 06:05:15PM +0300, Maor Gottlieb wrote: > > This is right only for the last iteration. E.g. in the first iteration in > > case that there are more pages (left_pages), then we allocate > > SG_MAX_SINGLE_ALLOC. 

Re: [PATCH blk-next 0/2] Delete the get_vector_affinity leftovers

2020-09-30 Thread Leon Romanovsky
On Tue, Sep 29, 2020 at 12:13:56PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > There are no drivers that implement .get_vector_affinity(), so delete > the RDMA function and simplify block code. > > Thanks > > P.S. Probably it should go through block tree

[PATCH rdma-next v5 2/4] tools/testing/scatterlist: Rejuvenate bit-rotten test

2020-10-04 Thread Leon Romanovsky
From: Tvrtko Ursulin A couple small tweaks are needed to make the test build and run on current kernels. Signed-off-by: Tvrtko Ursulin Cc: Maor Gottlieb Signed-off-by: Leon Romanovsky --- tools/testing/scatterlist/Makefile | 3 ++- tools/testing/scatterlist/linux/mm.h | 35

[PATCH rdma-next v5 0/4] Dynamicaly allocate SG table from the pages

2020-10-04 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v5: * Use sg_init_table to allocate table and avoid changes is __sg_alloc_table * Fix offset issue v4: https://lore.kernel.org/lkml/20200927064647.3106737-1-l...@kernel.org * Fixed formatting in first patch. * Added fix (clear tmp_netnts) in first patch to

[PATCH rdma-next v5 1/4] lib/scatterlist: Add support in dynamic allocation of SG table from pages

2020-10-04 Thread Leon Romanovsky
h the Infiniband driver that allocates a single page for hold the pages. For 1TB memory registration, the temporary buffer would consume only 4KB, instead of 2GB. Signed-off-by: Maor Gottlieb Reviewed-by: Christoph Hellwig Signed-off-by: Leon Romanovsky --- drivers/gpu/drm/i915/gem/i915_gem_userptr.c

[PATCH rdma-next v5 3/4] tools/testing/scatterlist: Show errors in human readable form

2020-10-04 Thread Leon Romanovsky
From: Tvrtko Ursulin Instead of just asserting dump some more useful info about what the test saw versus what it expected to see. Signed-off-by: Tvrtko Ursulin Cc: Maor Gottlieb Signed-off-by: Leon Romanovsky --- tools/testing/scatterlist/main.c | 44 1 file

[PATCH rdma-next v5 4/4] RDMA/umem: Move to allocate SG table from pages

2020-10-04 Thread Leon Romanovsky
600.0MB After512001.2MB Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/umem.c | 94 +- 1 file changed, 12 insertions(+), 82 deletions(-) diff --git a/drivers/infiniband/core/umem.c b

Re: [PATCH-next 0/4] RDMA: sprintf to sysfs_emit conversions

2020-10-07 Thread Leon Romanovsky
On Wed, Oct 07, 2020 at 07:36:23PM -0700, Joe Perches wrote: > A recent commit added a sysfs_emit and sysfs_emit_at to allow various > sysfs show functions to ensure that the PAGE_SIZE buffer argument is > never overrun and always NUL terminated. Unfortunately but the sysfs_emit commit is not in r

Re: [PATCH 1/5] mm: Introduce mm_struct.has_pinned

2020-10-07 Thread Leon Romanovsky
On Mon, Sep 28, 2020 at 12:50:03PM -0700, Linus Torvalds wrote: > On Mon, Sep 28, 2020 at 12:36 PM Linus Torvalds > wrote: > > > > So I'll do the pte wrprotect/restore removal. Anybody willing to do > > and test the sequence count approach? > > So the wrprotect removal is trivial, with most of it

Re: [PATCH-next 0/4] RDMA: sprintf to sysfs_emit conversions

2020-10-08 Thread Leon Romanovsky
On Wed, Oct 07, 2020 at 10:52:15PM -0700, Joe Perches wrote: > On Thu, 2020-10-08 at 08:41 +0300, Leon Romanovsky wrote: > > On Wed, Oct 07, 2020 at 07:36:23PM -0700, Joe Perches wrote: > > > A recent commit added a sysfs_emit and sysfs_emit_at to allow various > > > sys

[PATCH blk-next 2/2] RDMA/core: Delete not-implemented get_vector_affinity

2020-09-29 Thread Leon Romanovsky
From: Leon Romanovsky There are no drivers that support .get_vector_affinity(), so delete it. Fixes: 9afc97c29b03 ("mlx5: remove support for ib_get_vector_affinity") Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/device.c | 1 - include/rdma/ib_verbs.h

[PATCH blk-next 1/2] blk-mq-rdma: Delete not-used multi-queue RDMA map queue code

2020-09-29 Thread Leon Romanovsky
From: Leon Romanovsky The RDMA vector affinity code is not backed up by any driver and always returns NULL to every ib_get_vector_affinity() call. This means that blk_mq_rdma_map_queues() always takes fallback path. Fixes: 9afc97c29b03 ("mlx5: remove support for ib_get_vector_affinity&quo

[PATCH blk-next 0/2] Delete the get_vector_affinity leftovers

2020-09-29 Thread Leon Romanovsky
From: Leon Romanovsky There are no drivers that implement .get_vector_affinity(), so delete the RDMA function and simplify block code. Thanks P.S. Probably it should go through block tree. Leon Romanovsky (2): blk-mq-rdma: Delete not-used multi-queue RDMA map queue code RDMA/core: Delete

Re: [PATCH blk-next 1/2] blk-mq-rdma: Delete not-used multi-queue RDMA map queue code

2020-09-29 Thread Leon Romanovsky
On Tue, Sep 29, 2020 at 12:20:46PM +0200, Christoph Hellwig wrote: > On Tue, Sep 29, 2020 at 12:13:57PM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > The RDMA vector affinity code is not backed up by any driver and always > > returns NULL to every ib

Re: [PATCH v2 0/4] mm: Break COW for pinned pages during fork()

2020-09-29 Thread Leon Romanovsky
On Sun, Sep 27, 2020 at 12:35:59PM -0700, Linus Torvalds wrote: > On Fri, Sep 25, 2020 at 3:26 PM Peter Xu wrote: > > > > This series is majorly inspired by the previous discussion on the list [1], > > starting from the report from Jason on the rdma test failure. > > Ok, this is now in my git tree

Re: [PATCH v2] net/mlx5e: Fix use of freed pointer

2020-09-29 Thread Leon Romanovsky
On Tue, Sep 29, 2020 at 11:15:49AM +0100, Alex Dewar wrote: > If the call to mlx5_fc_create() fails, then shared_counter will be freed > before its member, shared_counter->counter, is accessed to retrieve the > error code. Fix by using an intermediate variable. > > Addresses-Coverity: CID 1497153:

Re: [PATCH] [v2] wireless: Initial driver submission for pureLiFi devices

2020-09-29 Thread Leon Romanovsky
On Mon, Sep 28, 2020 at 03:49:49PM +0530, Srinivasan Raju wrote: > This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC > and LiFi-XL USB devices, which provide lightweight, highspeed secure and > fully networked wireless communications via light. > > This driver implementation has been bas

[PATCH rdma-rc 0/3] Fixes to coming PR

2020-10-11 Thread Leon Romanovsky
From: Leon Romanovsky Leon Romanovsky (2): RDMA/core: Postpone uobject cleanup on failure till FD close RDMA/core: Make FD destroy callback void Maor Gottlieb (1): RDMA/ucma: Fix use after free in destroy id flow drivers/infiniband/core/rdma_core.c | 45

Re: [PATCH v3 -next] vdpa: mlx5: change Kconfig depends to fix build errors

2020-09-25 Thread Leon Romanovsky
On Fri, Sep 25, 2020 at 07:29:24PM +0800, Jason Wang wrote: > > On 2020/9/25 下午6:19, Michael S. Tsirkin wrote: > > On Fri, Sep 25, 2020 at 10:20:05AM +0300, Leon Romanovsky wrote: > > > On Thu, Sep 24, 2020 at 12:02:43PM -0400, Michael S. Tsirkin wrote: > > > > O

[PATCH rdma-next v3 0/9] Track memory allocation with restrack DB help

2020-09-26 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v3: * Rebased on already accepted patches. * Added mlx4 special QPs to the list of not-tracked QPs (dropped previous mlx4 special QP patch). * Separated to two patches change in return value of cma_listen_* routines. * Changed commit messages and added Fixes

[PATCH rdma-next v1 00/10] Prepare drivers to move QP allocation to ib_core

2020-09-26 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v1: * Rebased * Fixed commit messages. * Changed "fallthrough" to be "break". v0: https://lore.kernel.org/lkml/20200910140046.1306341-1-l...@kernel.org - Hi, This s

Re: [PATCH 1/5] mm: Introduce mm_struct.has_pinned

2020-09-26 Thread Leon Romanovsky
On Sat, Sep 26, 2020 at 03:28:32PM -0700, Linus Torvalds wrote: > On Fri, Sep 25, 2020 at 6:15 PM Linus Torvalds > wrote: > > > > I think that over the weekend I'll do Peter's version but with the > > "page_mapcount() == 1" check, because I'm starting to like that > > better than the mm->has_pinn

[PATCH rdma-next v4 1/4] lib/scatterlist: Add support in dynamic allocation of SG table from pages

2020-09-26 Thread Leon Romanovsky
h the Infiniband driver that allocates a single page for hold the pages. For 1TB memory registration, the temporary buffer would consume only 4KB, instead of 2GB. Signed-off-by: Maor Gottlieb Reviewed-by: Christoph Hellwig Signed-off-by: Leon Romanovsky --- drivers/gpu/drm/i915/gem/i915_gem_userptr.c

[PATCH rdma-next v4 3/4] tools/testing/scatterlist: Show errors in human readable form

2020-09-26 Thread Leon Romanovsky
From: Tvrtko Ursulin Instead of just asserting dump some more useful info about what the test saw versus what it expected to see. Signed-off-by: Tvrtko Ursulin Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- tools/testing/scatterlist/main.c | 44

[PATCH rdma-next v4 0/4] Dynamicaly allocate SG table from the pages

2020-09-26 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v4: * Fixed formatting in first patch. * Added fix (clear tmp_netnts) in first patch to fix i915 failure. * Added test patches v3: https://lore.kernel.org/linux-rdma/20200922083958.2150803-1-l...@kernel.org/ * Squashed Christopher's suggestion to

[PATCH rdma-next v4 4/4] RDMA/umem: Move to allocate SG table from pages

2020-09-26 Thread Leon Romanovsky
600.0MB After512001.2MB Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/umem.c | 92 +- 1 file changed, 12 insertions(+), 80 deletions(-) diff --git a/drivers/infiniband/core/umem.c b

[PATCH rdma-next v4 2/4] tools/testing/scatterlist: Rejuvenate bit-rotten test

2020-09-26 Thread Leon Romanovsky
From: Tvrtko Ursulin A couple small tweaks are needed to make the test build and run on current kernels. Signed-off-by: Tvrtko Ursulin Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- tools/testing/scatterlist/Makefile | 3 ++- tools/testing/scatterlist/linux/mm.h | 35

Re: [PATCH][next] net/mlx5e: Fix potential null pointer dereference

2020-09-28 Thread Leon Romanovsky
x/mlx5/core/en_tc.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky

Re: [PATCH 2/3] net/mlx5e: Clean up error handling in mlx5e_alloc_flow()

2020-09-28 Thread Leon Romanovsky
On Sun, Sep 27, 2020 at 12:32:52PM +0100, Alex Dewar wrote: > The variable flow is used after being allocated but before being > null-checked, which will cause a null pointer dereference if the > allocation failed. Fix this and tidy up the error-checking logic in this > function. > > Addresses-Cove

Re: [PATCH 3/3] net/mlx5e: Fix use of freed pointer

2020-09-28 Thread Leon Romanovsky
On Sun, Sep 27, 2020 at 12:32:53PM +0100, Alex Dewar wrote: > If the call to mlx5_fc_create() fails, then shared_counter will be freed > before its member, shared_counter->counter, is accessed to retrieve the > error code. Fix by using an intermediate variable. > > Addresses-Coverity: CID 1497153:

[PATCH rdma-next v3 0/6] Add Enhanced Connection Established (ECE)

2020-05-26 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v3: * Rebased on top of ebd6e96b33a2 RDMA/ipoib: Remove can_sleep parameter from iboib_mcast_alloc * Updated rdma_reject patch to include newly added RTR ulp * Remove empty hunks added by rebase * Changed signature of rdma_reject so kernel users will

Re: [PATCH] net/mlx5: reduce stack usage in qp_read_field

2020-05-04 Thread Leon Romanovsky
On Mon, May 04, 2020 at 05:41:56PM +0200, Arnd Bergmann wrote: > On Sun, May 3, 2020 at 7:30 AM Leon Romanovsky wrote: > > On Thu, Apr 30, 2020 at 04:37:14PM +0200, Arnd Bergmann wrote: > > > On Thu, Apr 30, 2020 at 7:22 AM Leon Romanovsky wrote: > > > > > > W

[PATCH rdma-next 0/3] mlx5 QP cleanup (cont.)

2020-05-05 Thread Leon Romanovsky
From: Leon Romanovsky Hi, This short series continue to cleanup qp.c file, which grew to be completely unmaintainable. Thanks Leon Romanovsky (2): RDMA/mlx5: Update mlx5_ib to use new cmd interface RDMA/mlx5: Move all WR logic from qp.c to separate file Max Gurtovoy (1): RDMA/mlx5

[PATCH rdma-next 0/9] Enable asynchronous event FD per object

2020-05-06 Thread Leon Romanovsky
From: Leon Romanovsky >From Yishai: This series enables applicable events objects (i.e. QP, SRQ, CQ, WQ) to be created with their own asynchronous event FD. Before this series any affiliated event on an object was reported on the first asynchronous event FD that was created on the cont

[PATCH rdma-next 00/10] Various clean ups to ib_cm

2020-05-06 Thread Leon Romanovsky
From: Leon Romanovsky >From Jason, These are intended to be no-functional change edits that tidy up the code flow or coding style. Thanks Danit Goldberg (1): RDMA/cm: Remove unused store to ret in cm_rej_handler Jason Gunthorpe (9): RDMA/addr: Mark addr_resolve as might_sleep() RDMA

Re: [PATCH net-next] mlx5: Restore err assignment in mlx5_mdev_init

2020-06-02 Thread Leon Romanovsky
On Mon, Jun 01, 2020 at 09:07:48PM -0700, Nathan Chancellor wrote: > On Sun, May 31, 2020 at 12:58:10PM +0300, Leon Romanovsky wrote: > > On Fri, May 29, 2020 at 10:54:48PM -0700, Nathan Chancellor wrote: > > > Clang warns: > > > > > > drivers/net/ethernet/mella

Re: [PATCH 09/10] treewide: Remove uninitialized_var() usage

2020-06-04 Thread Leon Romanovsky
2 +- > net/sched/sch_fq_codel.c | 2 +- > net/sched/sch_fq_pie.c | 2 +- > net/sched/sch_hfsc.c | 2 +- > net/sched/sch_htb.c | 2 +- > net/sched/sch_sfq.c | 2 +- > net/sunrpc/svcsock.c | 4 ++-- > net/sunrpc/xprtsock.c| 10 +- > net/tls/tls_sw.c | 2 +- > sound/core/control_compat.c | 2 +- > sound/isa/sb/sb16_csp.c | 2 +- > sound/usb/endpoint.c | 2 +- > 184 files changed, 284 insertions(+), 285 deletions(-) Thanks, Reviewed-by: Leon Romanovsky # drivers/infiniband and mlx4/mlx5

Re: [PATCH] IB/mlx4: Replace zero-length array with flexible-array

2020-05-13 Thread Leon Romanovsky
On Wed, May 13, 2020 at 03:33:35PM -0300, Jason Gunthorpe wrote: > On Thu, May 07, 2020 at 01:59:21PM -0500, Gustavo A. R. Silva wrote: > > The current codebase makes use of the zero-length array language > > extension to the C90 standard, but the preferred mechanism to declare > > variable-length

Re: linux-next: manual merge of the mlx5-next tree with the rdma tree

2020-05-13 Thread Leon Romanovsky
On Thu, May 14, 2020 at 12:59:20PM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the mlx5-next tree got a conflict in: > > drivers/infiniband/hw/mlx5/main.c > > between commit: > > 2be08c308f10 ("RDMA/mlx5: Delete create QP flags obfuscation") > > from the rdma tree a

Re: [PATCH] net/mlx5: Add a missing macro undefinition

2020-06-06 Thread Leon Romanovsky
et/mellanox/mlx5/core/main.c | 2 ++ > 1 file changed, 2 insertions(+) "should be undefined" is s little bit over statement, but overall the patch is good. Fixes: fca22e7e595f ("net/mlx5: ODP support for XRC transport is not enabled by default in FW") Thanks, Reviewed-by: Leon Romanovsky

Re: [PATCH][next] RDMA/mlx5: remove duplicated assignment to resp.response_length

2020-06-06 Thread Leon Romanovsky
nused value") > Signed-off-by: Colin Ian King > --- > drivers/infiniband/hw/mlx5/qp.c | 2 -- > 1 file changed, 2 deletions(-) > Thanks, Acked-by: Leon Romanovsky

[RFC PATCH -rc] gcov: Protect from uninitialized number of functions provided by GCC

2020-08-27 Thread Leon Romanovsky
From: Leon Romanovsky The kernel compiled with GCC 10.2.1 and KASAN together with GCOV enabled produces the following splats while reloading modules. First splat [1] is generated due to the situation that gcov_info can be both user and kernel pointer, the memcpy() during kmemdup() causes to

Re: [RFC PATCH -rc] gcov: Protect from uninitialized number of functions provided by GCC

2020-08-27 Thread Leon Romanovsky
On Thu, Aug 27, 2020 at 04:39:32PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > The kernel compiled with GCC 10.2.1 and KASAN together with GCOV enabled > produces the following splats while reloading modules. > > First splat [1] is generated due to the situation

Re: [PATCH rdma-next 1/4] gcov: Open-code kmemdup() to work correctly with kernel and user space pointers

2020-09-02 Thread Leon Romanovsky
On Wed, Sep 02, 2020 at 10:38:20AM -0700, Linus Torvalds wrote: > On Wed, Sep 2, 2020 at 1:55 AM Leon Romanovsky wrote: > > > > The kernel with KASAN and GCOV enabled generates the following splat > > due to the situation that gcov_info can be both user and kernel pointer.

Re: [PATCH -rc 0/4] Protect from GCC garbage input in GCOV

2020-09-02 Thread Leon Romanovsky
On Wed, Sep 02, 2020 at 10:42:55AM -0700, Linus Torvalds wrote: > On Wed, Sep 2, 2020 at 1:55 AM Leon Romanovsky wrote: > > > > Bottom line, GCOV is broken on GCC 10.2. > > The patches don't really make sense to me. > > How about we just disable GCOV with t

Re: [PATCH -rc 0/4] Protect from GCC garbage input in GCOV

2020-09-02 Thread Leon Romanovsky
On Wed, Sep 02, 2020 at 11:24:50AM -0700, Linus Torvalds wrote: > On Wed, Sep 2, 2020 at 10:52 AM Leon Romanovsky wrote: > > > > Are you suggesting something like this? > > > > diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig > > index 3110c77230c7..bc0e355f

Re: [PATCH rdma-next 1/4] gcov: Open-code kmemdup() to work correctly with kernel and user space pointers

2020-09-02 Thread Leon Romanovsky
On Wed, Sep 02, 2020 at 11:27:14AM -0700, Linus Torvalds wrote: > On Wed, Sep 2, 2020 at 10:46 AM Leon Romanovsky wrote: > > > > Definitely my explanation is wrong, but it was my interpretation of > > "BUG: KASAN: global-out-of-bounds in kmemdup+0x43/0x70" line. I

Re: [PATCH rdma-next 2/4] gcov: Use proper duplication routine for const pointer

2020-09-03 Thread Leon Romanovsky
On Thu, Sep 03, 2020 at 10:56:38AM +0200, Rasmus Villemoes wrote: > On 02/09/2020 10.55, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > The filename is a const pointer, so use the proper string duplication > > routine that takes into account const identifier

[PATCH rdma-next 4/4] RDMA/umem: Move to allocate SG table from pages

2020-09-03 Thread Leon Romanovsky
600.0MB After512001.2MB Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/umem.c | 93 +- 1 file changed, 14 insertions(+), 79 deletions(-) diff --git a/drivers/infiniband/core/umem.c b/drivers

[PATCH rdma-next 2/4] lib/scatterlist: Add support in dynamically allocation of SG entries

2020-09-03 Thread Leon Romanovsky
. * Add a function to chain SGE to the next page. Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- include/linux/scatterlist.h | 29 ++ lib/scatterlist.c | 110 2 files changed, 91 insertions(+), 48 deletions(-) diff --git a

[PATCH rdma-next 3/4] lib/scatterlist: Add support in dynamic allocation of SG table from pages

2020-09-03 Thread Leon Romanovsky
with the Infiniband driver that allocates a single page for hold the pages. For 1TB memory registration, the temporary buffer would consume only 4KB, instead of 2GB. Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- include/linux/scatterlist.h | 10 +++ lib/scatterl

[PATCH rdma-next 0/4] scatterlist: add sg_alloc_table_append function

2020-09-03 Thread Leon Romanovsky
From: Leon Romanovsky >From Maor: This series adds a new constructor for a scatter gather table. Like sg_alloc_table_from_pages function, this function merges all contiguous chunks of the pages a into single scatter gather entry. In contrast to sg_alloc_table_from_pages, the new API all

[PATCH rdma-next 1/4] lib/scatterlist: Refactor sg_alloc_table_from_pages

2020-09-03 Thread Leon Romanovsky
more SGEs. Since sg_alloc_table_from_pages allocate exactly the number of chunks, therefore chunks are equal to the number of SG entries. Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- lib/scatterlist.c | 75 --- 1 file change

Re: [PATCH rdma-next 0/4] scatterlist: add sg_alloc_table_append function

2020-09-03 Thread Leon Romanovsky
On Thu, Sep 03, 2020 at 05:32:17PM +0200, Christoph Hellwig wrote: > Patch 1 never made it through. Thanks, I sent it now and the patch is seen in ML. https://lore.kernel.org/linux-rdma/20200903153217.ga21...@lst.de/T/#t

[PATCH rdma-next 00/10] Restore failure of destroy commands

2020-08-24 Thread Leon Romanovsky
From: Leon Romanovsky Hi, This series restores the ability to fail on destroy commands, due to the fact that mlx5_ib DEVX implementation interleaved ib_core objects with FW objects without sharing reference counters. In a retrospective, every part of the mlx5_ib flow is correct. It started

[PATCH rdma-next 00/14] Track memory allocation with restrack DB help

2020-08-24 Thread Leon Romanovsky
From: Leon Romanovsky The resource tracker has built-in kref counter to synchronize object release. It makes restrack perfect choice to be responsible for the memory lifetime of any object in which restrack entry is embedded. In order to make it, the restrack was changed to be mandatory and all

[PATCH rdma-next 0/8] Cleanup and fix the CMA state machine

2020-09-02 Thread Leon Romanovsky
From: Leon Romanovsky >From Jason: The RDMA CMA continues to attract syzkaller bugs due to its somewhat loose operation of its FSM. Audit and scrub the whole thing to follow modern expectations. Overall the design elements are broadly: - The ULP entry points MUST NOT run in parallel with e

[PATCH rdma-next 0/2] Convert RWQ and MW to general allocation scheme

2020-09-02 Thread Leon Romanovsky
From: Leon Romanovsky Continue with allocation patches. Leon Romanovsky (2): RDMA: Clean MW allocation and free flows RDMA: Convert RWQ table logic to ib_core allocation scheme drivers/infiniband/core/device.c| 2 + drivers/infiniband/core/uverbs_cmd.c| 45

<    3   4   5   6   7   8   9   10   11   >