Re: [PATCH] PCI: merge slot and bus reset implementations

2021-04-07 Thread Leon Romanovsky
On Wed, Apr 07, 2021 at 01:53:56PM +0530, ameynarkhed...@gmail.com wrote: > On 21/04/07 10:23AM, Leon Romanovsky wrote: > > On Tue, Apr 06, 2021 at 08:16:26AM -0600, Alex Williamson wrote: > > > On Sun, 4 Apr 2021 11:04:32 +0300 > > > Leon Romanovsky wrote: > >

Re: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Leon Romanovsky
On Wed, Apr 07, 2021 at 08:28:45AM +, Dexuan Cui wrote: > > From: Leon Romanovsky > > Sent: Wednesday, April 7, 2021 1:15 AM > > > ... > > > int gdma_test_eq(struct gdma_context *gc, struct gdma_queue *eq) > > > { > > >

Re: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Leon Romanovsky
On Wed, Apr 07, 2021 at 08:40:13AM +, Dexuan Cui wrote: > > From: Leon Romanovsky > > Sent: Wednesday, April 7, 2021 1:10 AM > > > > <...> > > > > > +int gdma_verify_vf_version(struct pci_dev *pdev) > > > +{ > > > +

Re: [PATCH] PCI: merge slot and bus reset implementations

2021-04-07 Thread Leon Romanovsky
On Wed, Apr 07, 2021 at 06:36:01PM +0530, ameynarkhed...@gmail.com wrote: > On 21/04/07 03:30PM, Leon Romanovsky wrote: > > On Wed, Apr 07, 2021 at 01:53:56PM +0530, ameynarkhed...@gmail.com wrote: > > > On 21/04/07 10:23AM, Leon Romanovsky wrote: > > > > On Tue, Ap

Re: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Leon Romanovsky
On Wed, Apr 07, 2021 at 02:41:45PM +, Haiyang Zhang wrote: > > > > -Original Message- > > From: Leon Romanovsky > > Sent: Wednesday, April 7, 2021 8:51 AM > > To: Dexuan Cui > > Cc: da...@davemloft.net; k...@kernel.org; KY Srinivasan > &g

Re: [PATCH for-next v3 1/2] IB/cma: Introduce rdma_set_min_rnr_timer()

2021-04-01 Thread Leon Romanovsky
On Wed, Mar 31, 2021 at 08:43:13PM +0200, Håkon Bugge wrote: > Introduce the ability for kernel ULPs to adjust the minimum RNR Retry > timer. The INIT -> RTR transition executed by RDMA CM will be used for > this adjustment. This avoids an additional ib_modify_qp() call. > > rdma_set_min_rnr_timer

Re: [PATCH -next] RDMA/uverbs: Fix -Wunused-function warning

2021-04-01 Thread Leon Romanovsky
~~~ > > Make these functions inline to fix this warnings. > > Signed-off-by: YueHaibing > --- > include/rdma/uverbs_ioctl.h | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky

Re: [PATCH] PCI: merge slot and bus reset implementations

2021-04-01 Thread Leon Romanovsky
On Thu, Apr 01, 2021 at 05:37:16AM +, Raphael Norwitz wrote: > Slot resets are bus resets with additional logic to prevent a device > from being removed during the reset. Currently slot and bus resets have > separate implementations in pci.c, complicating higher level logic. As > discussed on t

Re: [RFC V2 PATCH 11/12] HV/Netvsc: Add Isolation VM support for netvsc driver

2021-04-18 Thread Leon Romanovsky
On Tue, Apr 13, 2021 at 11:22:16AM -0400, Tianyu Lan wrote: > From: Tianyu Lan > > In Isolation VM, all shared memory with host needs to mark visible > to host via hvcall. vmbus_establish_gpadl() has already done it for > netvsc rx/tx ring buffer. The page buffer used by vmbus_sendpacket_ > pageb

[PATCH rdma-next 0/3] CMA fixes

2021-04-18 Thread Leon Romanovsky
From: Leon Romanovsky Another round of fixes to cma.c Parav Pandit (1): RDMA/cma: Skip device which doesn't support CM Shay Drory (2): RDMA/core: Fix check of device in rdma_listen() RDMA/core: Add CM to restrack after successful attachment to a device drivers/infiniband/core/

Re: [RFC v1 PATCH 3/3] driver: update all the code that use soc_device_match

2021-04-18 Thread Leon Romanovsky
On Mon, Apr 19, 2021 at 12:27:22PM +0800, Alice Guo (OSS) wrote: > From: Alice Guo > > Update all the code that use soc_device_match because add support for > soc_device_match returning -EPROBE_DEFER. > > Signed-off-by: Alice Guo > --- > drivers/bus/ti-sysc.c | 2 +- >

Re: [PATCH] net/rds: Avoid potential use after free in rds_send_remove_from_sock

2021-04-20 Thread Leon Romanovsky
On Tue, Apr 06, 2021 at 07:09:12PM -0500, Aditya Pakki wrote: > In case of rs failure in rds_send_remove_from_sock(), the 'rm' resource > is freed and later under spinlock, causing potential use-after-free. > Set the free pointer to NULL to avoid undefined behavior. > > Signed-off-by: Aditya Pakki

Re: [PATCH] net/rds: Avoid potential use after free in rds_send_remove_from_sock

2021-04-20 Thread Leon Romanovsky
On Tue, Apr 20, 2021 at 12:09:06PM +0300, Leon Romanovsky wrote: > On Tue, Apr 06, 2021 at 07:09:12PM -0500, Aditya Pakki wrote: > > In case of rs failure in rds_send_remove_from_sock(), the 'rm' resource > > is freed and later under spinlock, causing potential use-aft

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

2021-03-16 Thread Leon Romanovsky
On Mon, Mar 15, 2021 at 06:32:32PM +, Raphael Norwitz wrote: > On Mon, Mar 15, 2021 at 10:29:50AM -0600, Alex Williamson wrote: > > On Mon, 15 Mar 2021 21:03:41 +0530 > > Amey Narkhede wrote: > > > > > On 21/03/15 05:07PM, Leon Romanovsky wrote: > > &g

Re: [PATCH v5 03/24] wfx: add Makefile/Kconfig

2021-03-16 Thread Leon Romanovsky
On Mon, Mar 15, 2021 at 05:21:35PM +0100, Jérôme Pouiller wrote: > Hi Leon, > > On Monday 15 March 2021 16:11:52 CET Leon Romanovsky wrote: > > On Mon, Mar 15, 2021 at 02:24:40PM +0100, Jerome Pouiller wrote: > > > From: Jérôme Pouiller > > > >

[PATCH master] module: remove never implemented MODULE_SUPPORTED_DEVICE

2021-03-17 Thread Leon Romanovsky
From: Leon Romanovsky MODULE_SUPPORTED_DEVICE was added in pre-git era and never was implemented. We can safely remove it, because the kernel has grown to have many more reliable mechanisms to determine if device is supported or not. Signed-off-by: Leon Romanovsky --- Hi Linus, I'm se

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

2021-03-17 Thread Leon Romanovsky
On Wed, Mar 17, 2021 at 03:54:47PM +0530, Amey Narkhede wrote: > On 21/03/17 06:20AM, Leon Romanovsky wrote: > > On Mon, Mar 15, 2021 at 06:32:32PM +, Raphael Norwitz wrote: > > > On Mon, Mar 15, 2021 at 10:29:50AM -0600, Alex Williamson wrote: > > > > On M

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

2021-03-17 Thread Leon Romanovsky
On Wed, Mar 17, 2021 at 04:53:09PM +0530, Amey Narkhede wrote: > On 21/03/17 01:02PM, Leon Romanovsky wrote: > > On Wed, Mar 17, 2021 at 03:54:47PM +0530, Amey Narkhede wrote: > > > On 21/03/17 06:20AM, Leon Romanovsky wrote: > > > > On Mon, Mar 15, 2021 at 06:32:32P

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

2021-03-17 Thread Leon Romanovsky
On Wed, Mar 17, 2021 at 06:47:18PM +0530, Amey Narkhede wrote: > On 21/03/17 01:47PM, Leon Romanovsky wrote: > > On Wed, Mar 17, 2021 at 04:53:09PM +0530, Amey Narkhede wrote: > > > On 21/03/17 01:02PM, Leon Romanovsky wrote: > > > > On Wed, Mar 17, 2021 at 03:54:4

Re: [PATCH][next] RDMA/mlx5: Fix missing assignment of rc when calling mlx5_ib_dereg_mr

2021-03-17 Thread Leon Romanovsky
On Tue, Mar 16, 2021 at 09:51:17AM +, Colin King wrote: > From: Colin Ian King > > The assignment of the return code to rc when calling mlx5_ib_dereg_mr is > missing and there is an error check on an uninitialized rc. Fix this by > adding in the assignment. > > Addresses-Coverity: ("Uninitiali

Re: [PATCH master] module: remove never implemented MODULE_SUPPORTED_DEVICE

2021-03-18 Thread Leon Romanovsky
On Wed, Mar 17, 2021 at 01:17:32PM -0700, Linus Torvalds wrote: > On Wed, Mar 17, 2021 at 3:46 AM Leon Romanovsky wrote: > > > > I'm sending this patch to you directly because it is much saner to > > apply it in one place instead of multiple patches saga that will > &

Re: [PATCH] rxrpc: rxkad: replace if (cond) BUG() with BUG_ON()

2021-03-18 Thread Leon Romanovsky
On Wed, Mar 17, 2021 at 11:38:38AM +0800, Jiapeng Chong wrote: > Fix the following coccicheck warnings: > > ./net/rxrpc/rxkad.c:1140:2-5: WARNING: Use BUG_ON instead of if > condition followed by BUG. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > net/rxrpc/rxkad.c | 5 ++---

Re: [PATCH] virtio_net: replace if (cond) BUG() with BUG_ON()

2021-03-18 Thread Leon Romanovsky
On Wed, Mar 17, 2021 at 01:57:15PM +0800, Jiapeng Chong wrote: > Fix the following coccicheck warnings: > > ./drivers/net/virtio_net.c:1551:2-5: WARNING: Use BUG_ON instead of if > condition followed by BUG. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > drivers/net/virtio_n

Re: [PATCH] Add MHI bus support and driver for T99W175 5G modem

2021-03-18 Thread Leon Romanovsky
On Tue, Mar 16, 2021 at 05:42:37AM -0700, Jarvis Jiang wrote: > T99W175 using MBIM or RmNet over PCIe interface with > MHI protocol support. > Ported from IPQ8072 platform, including MHI, MBIM, RmNet > > Supporting below PCI devices: > > PCI_DEVICE(0x17cb, 0x0300) > PCI_DEVICE(0x17cb, 0x0301) >

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

2021-03-18 Thread Leon Romanovsky
On Wed, Mar 17, 2021 at 11:31:40AM -0600, Alex Williamson wrote: > On Wed, 17 Mar 2021 15:58:40 +0200 > Leon Romanovsky wrote: > > > On Wed, Mar 17, 2021 at 06:47:18PM +0530, Amey Narkhede wrote: > > > On 21/03/17 01:47PM, Leon Romanovsky wrote: > > > > On W

[PATCH rdma-next 0/6] Fix memory corruption in CM

2021-03-18 Thread Leon Romanovsky
From: Leon Romanovsky Hi, This series from Mark fixes long standing bug in CM migration logic, reported by Ryan [1]. Thanks [1] https://lore.kernel.org/linux-rdma/cafmmrnx9cg--nunzjfm8ywqfaetsmawv4eogkb3a0+hnjdt...@mail.gmail.com/ Mark Zhang (6): Revert "IB/cm: Mark stale CM id'

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

2021-03-18 Thread Leon Romanovsky
On Thu, Mar 18, 2021 at 07:52:52PM +0530, Amey Narkhede wrote: > On 21/03/18 11:09AM, Leon Romanovsky wrote: > > On Wed, Mar 17, 2021 at 11:31:40AM -0600, Alex Williamson wrote: > > > On Wed, 17 Mar 2021 15:58:40 +0200 > > > Leon Romanovsky wrote: > > > > &

Re: [PATCH net-next 4/7] net: ipa: ipa_stop() does not return an error

2021-04-10 Thread Leon Romanovsky
On Fri, Apr 09, 2021 at 01:07:19PM -0500, Alex Elder wrote: > In ipa_modem_stop(), if the modem netdev pointer is non-null we call > ipa_stop(). We check for an error and if one is returned we handle > it. But ipa_stop() never returns an error, so this extra handling > is unnecessary. Simplify t

Re: [PATCH v2] PCI: merge slot and bus reset implementations

2021-04-11 Thread Leon Romanovsky
Raphael Norwitz > --- > drivers/pci/pci.c | 19 +++ > include/linux/pci.h | 1 + > 2 files changed, 12 insertions(+), 8 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky

Re: [PATCH net-next 4/7] net: ipa: ipa_stop() does not return an error

2021-04-11 Thread Leon Romanovsky
On Sun, Apr 11, 2021 at 08:09:55AM -0500, Alex Elder wrote: > On 4/11/21 1:34 AM, Leon Romanovsky wrote: > > On Fri, Apr 09, 2021 at 01:07:19PM -0500, Alex Elder wrote: > >> In ipa_modem_stop(), if the modem netdev pointer is non-null we call > >> ipa_stop(). We check

Re: [PATCH net-next 4/7] net: ipa: ipa_stop() does not return an error

2021-04-12 Thread Leon Romanovsky
On Sun, Apr 11, 2021 at 08:42:15AM -0500, Alex Elder wrote: > On 4/11/21 8:28 AM, Leon Romanovsky wrote: > >> I think *not* checking an available return value is questionable > >> practice. I'd really rather have a build option for a > >> "__need_not

Re: [PATCH net 1/2] net: hns3: Remove the left over redundant check & assignment

2021-04-03 Thread Leon Romanovsky
On Sat, Apr 03, 2021 at 02:35:19AM +0100, Salil Mehta wrote: > This removes the left over check and assignment which is no longer used > anywhere in the function and should have been removed as part of the > below mentioned patch. > > Fixes: 012fcb52f67c ("net: hns3: activate reset timer when call

Re: [PATCH] PCI: merge slot and bus reset implementations

2021-04-04 Thread Leon Romanovsky
On Thu, Apr 01, 2021 at 10:56:16AM -0600, Alex Williamson wrote: > On Thu, 1 Apr 2021 15:27:37 +0300 > Leon Romanovsky wrote: > > > On Thu, Apr 01, 2021 at 05:37:16AM +, Raphael Norwitz wrote: > > > Slot resets are bus resets with additional logic to prevent a device

Re: [PATCH] RDMA/addr: potential uninitialized variable in ib_nl_process_good_ip_rsep()

2021-04-04 Thread Leon Romanovsky
On Fri, Apr 02, 2021 at 02:47:23PM +0300, Dan Carpenter wrote: > The nla_len() is less than or equal to 16. If it's less than 16 then > end of the "gid" buffer is uninitialized. > > Fixes: ae43f8286730 ("IB/core: Add IP to GID netlink offload") > Signed-off-by: Dan Carpenter > --- > I just spott

Re: [PATCH v3] IB/mlx5: Reduce max order of memory allocated for xlt update

2021-04-04 Thread Leon Romanovsky
lag in the > gfp_mask before during fetching the free pages. This patch adds this flag > to the mask. > > Signed-off-by: Praveen Kumar Kannoju > --- > drivers/infiniband/hw/mlx5/mr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks a lot, Acked-by: Leon Romanovsky

Re: [PATCH] RDMA/addr: potential uninitialized variable in ib_nl_process_good_ip_rsep()

2021-04-04 Thread Leon Romanovsky
On Sun, Apr 04, 2021 at 04:13:17PM +0300, Mark Bloch wrote: > On 4/4/21 1:33 PM, Leon Romanovsky wrote: > > On Fri, Apr 02, 2021 at 02:47:23PM +0300, Dan Carpenter wrote: > >> The nla_len() is less than or equal to 16. If it's less than 16 then > >> end of t

Re: [PATCH] net/mlx5: fix kfree mismatch in indir_table.c

2021-04-04 Thread Leon Romanovsky
/mlx5/core/esw/indir_table.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky

[PATCH rdma-next 00/10] Enable relaxed ordering for ULPs

2021-04-04 Thread Leon Romanovsky
From: Leon Romanovsky >From Avihai, Relaxed Ordering is a PCIe mechanism that relaxes the strict ordering imposed on PCI transactions, and thus, can improve performance. Until now, relaxed ordering could be set only by user space applications for user MRs. The following patch series enab

[PATCH rdma-next 03/10] RDMA/iser: Enable Relaxed Ordering

2021-04-04 Thread Leon Romanovsky
From: Avihai Horon Enable Relaxed Ordering for iser. Relaxed Ordering is an optional access flag and as such, it is ignored by vendors that don't support it. Signed-off-by: Avihai Horon Reviewed-by: Max Gurtovoy Reviewed-by: Michael Guralnik Signed-off-by: Leon Romanovsky --- dr

[PATCH rdma-next 01/10] RDMA: Add access flags to ib_alloc_mr() and ib_mr_pool_init()

2021-04-04 Thread Leon Romanovsky
ib_alloc_mr() and ib_mr_pool_init() users. Signed-off-by: Avihai Horon Reviewed-by: Max Gurtovoy Reviewed-by: Michael Guralnik Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/mr_pool.c | 7 +- drivers/infiniband/core/rw.c | 12 ++-- drivers/infiniband/core

[PATCH rdma-next 04/10] RDMA/rtrs: Enable Relaxed Ordering

2021-04-04 Thread Leon Romanovsky
From: Avihai Horon Enable Relaxed Ordering fro rtrs client and server. Relaxed Ordering is an optional access flag and as such, it is ignored by vendors that don't support it. Signed-off-by: Avihai Horon Reviewed-by: Michael Guralnik Signed-off-by: Leon Romanovsky --- drivers/infin

[PATCH rdma-next 05/10] RDMA/srp: Enable Relaxed Ordering

2021-04-04 Thread Leon Romanovsky
From: Avihai Horon Enable Relaxed Ordering for srp. Relaxed Ordering is an optional access flag and as such, it is ignored by vendors that don't support it. Signed-off-by: Avihai Horon Reviewed-by: Max Gurtovoy Reviewed-by: Michael Guralnik Signed-off-by: Leon Romanovsky --- dr

[PATCH rdma-next 07/10] cifs: smbd: Enable Relaxed Ordering

2021-04-04 Thread Leon Romanovsky
From: Avihai Horon Enable Relaxed Ordering for smbd. Relaxed Ordering is an optional access flag and as such, it is ignored by vendors that don't support it. Signed-off-by: Avihai Horon Reviewed-by: Michael Guralnik Signed-off-by: Leon Romanovsky --- fs/cifs/smbdirect.c

[PATCH rdma-next 08/10] net/rds: Enable Relaxed Ordering

2021-04-04 Thread Leon Romanovsky
From: Avihai Horon Enable Relaxed Ordering for rds. Relaxed Ordering is an optional access flag and as such, it is ignored by vendors that don't support it. Signed-off-by: Avihai Horon Reviewed-by: Michael Guralnik Signed-off-by: Leon Romanovsky --- net/rds/ib_frmr.c | 7 +++ 1

[PATCH rdma-next 06/10] nvme-rdma: Enable Relaxed Ordering

2021-04-04 Thread Leon Romanovsky
From: Avihai Horon Enable Relaxed Ordering for nvme. Relaxed Ordering is an optional access flag and as such, it is ignored by vendors that don't support it. Signed-off-by: Avihai Horon Reviewed-by: Max Gurtovoy Reviewed-by: Michael Guralnik Signed-off-by: Leon Romanovsky --- drivers

[PATCH rdma-next 09/10] net/smc: Enable Relaxed Ordering

2021-04-04 Thread Leon Romanovsky
From: Avihai Horon Enable Relaxed Ordering for smc. Relaxed Ordering is an optional access flag and as such, it is ignored by vendors that don't support it. Signed-off-by: Avihai Horon Reviewed-by: Michael Guralnik Signed-off-by: Leon Romanovsky --- net/smc/smc_ib.c | 3 ++- ne

[PATCH rdma-next 10/10] xprtrdma: Enable Relaxed Ordering

2021-04-04 Thread Leon Romanovsky
From: Avihai Horon Enable Relaxed Ordering for xprtrdma. Relaxed Ordering is an optional access flag and as such, it is ignored by vendors that don't support it. Signed-off-by: Avihai Horon Reviewed-by: Michael Guralnik Signed-off-by: Leon Romanovsky --- net/sunrpc/xprtrdma/frwr_ops.c

[PATCH rdma-next 02/10] RDMA/core: Enable Relaxed Ordering in __ib_alloc_pd()

2021-04-04 Thread Leon Romanovsky
From: Avihai Horon Enable Relaxed Ordering in __ib_alloc_pd() allocation of the local_dma_lkey. This will take effect only for devices that don't pre-allocate the lkey but allocate it per PD allocation. Signed-off-by: Avihai Horon Reviewed-by: Michael Guralnik Signed-off-by: Leon Roman

[PATCH rdma-next 2/8] RDMA/cma: Skip device which doesn't support CM

2021-04-04 Thread Leon Romanovsky
specific switchdev device Hence, when a IB device doesn't support IB CM or IW CM, avoid adding such device to the cma list. Signed-off-by: Parav Pandit Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/cma.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --

[PATCH rdma-next 0/8] Generalize if ULP supported check

2021-04-04 Thread Leon Romanovsky
From: Leon Romanovsky Hi, This series adds new callback to check if ib client is supported/not_supported. Such general callback allows us to save memory footprint by not starting on devices that not going to work on them anyway. Thanks Parav Pandit (8): RDMA/core: Check if client supports

[PATCH rdma-next 3/8] IB/cm: Skip device which doesn't support IB CM

2021-04-04 Thread Leon Romanovsky
device consist of 512 ports and also avoids unnecessary initialization for all above 3 types of devices. Signed-off-by: Parav Pandit Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/cm.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH rdma-next 7/8] net/smc: Move to client_supported callback

2021-04-04 Thread Leon Romanovsky
From: Parav Pandit Use newly introduced client_supported() callback to avoid client additional if the RDMA device is not of IB type. Signed-off-by: Parav Pandit Signed-off-by: Leon Romanovsky --- net/smc/smc_ib.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a

[PATCH rdma-next 5/8] IB/IPoIB: Skip device which doesn't have InfiniBand port

2021-04-04 Thread Leon Romanovsky
From: Parav Pandit Skip RDMA device which doesn't have InfiniBand ports using newly introduced client_supported() callback. Signed-off-by: Parav Pandit Signed-off-by: Leon Romanovsky --- drivers/infiniband/ulp/ipoib/ipoib_main.c | 13 + 1 file changed, 13 insertions(+)

[PATCH rdma-next 4/8] IB/core: Skip device which doesn't have necessary capabilities

2021-04-04 Thread Leon Romanovsky
for a RDMA device consist of 128 ports. Signed-off-by: Parav Pandit Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/multicast.c | 15 ++- drivers/infiniband/core/sa_query.c | 15 ++- 2 files changed, 28 insertions(+), 2 deletions(-) diff --git a/drivers/infin

[PATCH rdma-next 1/8] RDMA/core: Check if client supports IB device or not

2021-04-04 Thread Leon Romanovsky
not for a given IB device, client combination. Signed-off-by: Parav Pandit Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/device.c | 3 +++ include/rdma/ib_verbs.h | 9 + 2 files changed, 12 insertions(+) diff --git a/drivers/infiniband/core/device.c b/drivers

[PATCH rdma-next 6/8] IB/opa_vnic: Move to client_supported callback

2021-04-04 Thread Leon Romanovsky
From: Parav Pandit Move to newly introduced client_supported callback Avoid client registration using newly introduced helper callback if the IB device doesn't have OPA VNIC capability. Signed-off-by: Parav Pandit Signed-off-by: Leon Romanovsky --- drivers/infiniband/ulp/opa

[PATCH rdma-next 8/8] net/rds: Move to client_supported callback

2021-04-04 Thread Leon Romanovsky
From: Parav Pandit Use newly introduced client_supported() callback to avoid client additional if the RDMA device is not of IB type or if it doesn't support device memory extensions. Signed-off-by: Parav Pandit Signed-off-by: Leon Romanovsky --- net/rds/ib.c | 20 +--- 1

Re: [PATCH] RDMA/addr: potential uninitialized variable in ib_nl_process_good_ip_rsep()

2021-04-04 Thread Leon Romanovsky
On Mon, Apr 05, 2021 at 08:41:41AM +0300, Dan Carpenter wrote: > Could you send that and give me a reported-by? I'm going AFK for a > week. Sure, we will handle it. Thanks for the report. > > regards, > dan carpenter >

Re: [PATCH rdma-next 1/8] RDMA/core: Check if client supports IB device or not

2021-04-05 Thread Leon Romanovsky
On Mon, Apr 05, 2021 at 09:20:32AM +0300, Gal Pressman wrote: > On 05/04/2021 8:49, Leon Romanovsky wrote: > > From: Parav Pandit > > > > RDMA devices are of different transport(iWarp, IB, RoCE) and have > > different attributes. > > Not all clients are

Re: [PATCH net 1/2] net: hns3: Remove the left over redundant check & assignment

2021-04-05 Thread Leon Romanovsky
On Mon, Apr 05, 2021 at 12:26:37PM +, Salil Mehta wrote: > Hi Leon, > Thanks for the review. > > > From: Leon Romanovsky [mailto:l...@kernel.org] > > Sent: Sunday, April 4, 2021 7:26 AM > > To: Salil Mehta > > Cc: da...@davemloft.net; k...@kernel.org; net...@

Re: [PATCH rdma-next 00/10] Enable relaxed ordering for ULPs

2021-04-05 Thread Leon Romanovsky
On Mon, Apr 05, 2021 at 03:41:15PM +0200, Christoph Hellwig wrote: > On Mon, Apr 05, 2021 at 08:23:54AM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > >From Avihai, > > > > Relaxed Ordering is a PCIe mechanism that relaxes the strict orde

Re: [PATCH rdma-next 00/10] Enable relaxed ordering for ULPs

2021-04-05 Thread Leon Romanovsky
On Tue, Apr 06, 2021 at 10:37:38AM +0800, Honggang LI wrote: > On Mon, Apr 05, 2021 at 08:23:54AM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > From Avihai, > > > > Relaxed Ordering is a PCIe mechanism that relaxes the strict ordering > >

Re: [PATCH rdma-next 00/10] Enable relaxed ordering for ULPs

2021-04-05 Thread Leon Romanovsky
On Mon, Apr 05, 2021 at 11:42:31PM +, Chuck Lever III wrote: > > > > On Apr 5, 2021, at 4:07 PM, Jason Gunthorpe wrote: > > > > On Mon, Apr 05, 2021 at 03:41:15PM +0200, Christoph Hellwig wrote: > >> On Mon, Apr 05, 2021 at 08:23:54AM +0300, Leon R

Re: [PATCH rdma-next 01/10] RDMA: Add access flags to ib_alloc_mr() and ib_mr_pool_init()

2021-04-05 Thread Leon Romanovsky
On Mon, Apr 05, 2021 at 08:27:16AM -0700, Bart Van Assche wrote: > On 4/4/21 10:23 PM, Leon Romanovsky wrote: > > diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h > > index bed4cfe50554..59138174affa 100644 > > --- a/include/rdma/ib_verbs.h > > ++

Re: [PATCH rdma-next 01/10] RDMA: Add access flags to ib_alloc_mr() and ib_mr_pool_init()

2021-04-05 Thread Leon Romanovsky
On Mon, Apr 05, 2021 at 03:46:18PM +0200, Christoph Hellwig wrote: > On Mon, Apr 05, 2021 at 08:23:55AM +0300, Leon Romanovsky wrote: > > From: Avihai Horon > > > > Add access flags parameter to ib_alloc_mr() and to ib_mr_pool_init(), > > and refactor relevant code

Re: [PATCH rdma-next 01/10] RDMA: Add access flags to ib_alloc_mr() and ib_mr_pool_init()

2021-04-05 Thread Leon Romanovsky
On Tue, Apr 06, 2021 at 07:27:17AM +0200, Christoph Hellwig wrote: > On Tue, Apr 06, 2021 at 08:23:28AM +0300, Leon Romanovsky wrote: > > The same proposal (enable unconditionally) was raised during > > submission preparations and we decided to follow same pattern > > as othe

Re: [PATCH rdma-next 02/10] RDMA/core: Enable Relaxed Ordering in __ib_alloc_pd()

2021-04-05 Thread Leon Romanovsky
On Mon, Apr 05, 2021 at 02:01:16PM -0400, Tom Talpey wrote: > On 4/5/2021 1:23 AM, Leon Romanovsky wrote: > > From: Avihai Horon > > > > Enable Relaxed Ordering in __ib_alloc_pd() allocation of the > > local_dma_lkey. > > > > This will take effect only

Re: [PATCH v15 2/4] phy: Add media type and speed serdes configuration interfaces

2021-02-20 Thread Leon Romanovsky
On Thu, Feb 18, 2021 at 05:14:49PM +0100, Steen Hegelund wrote: > Provide new phy configuration interfaces for media type and speed that > allows e.g. PHYs used for ethernet to be configured with this > information. > > Signed-off-by: Lars Povlsen > Signed-off-by: Steen Hegelund > Reviewed-by: An

Re: [PATCH net-next RFC v4] net: hdlc_x25: Queue outgoing LAPB frames

2021-02-20 Thread Leon Romanovsky
On Fri, Feb 19, 2021 at 12:28:12PM -0800, Xie He wrote: > On Fri, Feb 19, 2021 at 10:39 AM Jakub Kicinski wrote: > > > > Not entirely sure what the argument is about but adding constants would > > certainly help. > > Leon wants me to replace this: > > dev->needed_headroom = 3 - 1; > > with this: >

Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO

2021-02-20 Thread Leon Romanovsky
On Fri, Feb 19, 2021 at 06:32:26PM -0500, Julian Braha wrote: > commit 6e61907779ba99af785f5b2397a84077c289888a > Author: Julian Braha > Date: Fri Feb 19 18:20:57 2021 -0500 > > drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO > > When RDMA_RXE is enabled and CRYPTO is disa

Re: [PATCH] rtw88: 8822ce: fix wifi disconnect after S3/S4 on HONOR laptop

2021-02-20 Thread Leon Romanovsky
On Sat, Feb 20, 2021 at 04:46:02PM +0800, Hao Chen wrote: > When the laptop HONOR MagicBook 14 sleep to S3/S4, the laptop can't > resume. > The dmesg of kernel report: > "[ 99.990168] pcieport :00:01.2: can't change power state > from D3hot to D0 (config space inaccessible) > [ 99.993334] r

Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO

2021-02-22 Thread Leon Romanovsky
On Mon, Feb 22, 2021 at 10:39:20AM +0800, Zhu Yanjun wrote: > On Sun, Feb 21, 2021 at 2:49 PM Leon Romanovsky wrote: > > > > On Fri, Feb 19, 2021 at 06:32:26PM -0500, Julian Braha wrote: > > > commit 6e61907779ba99af785f5b2397a84077c289888a > > > Author: Julian B

Re: [PATCH v2 -next] IB/mlx5: Add missing error code

2021-02-22 Thread Leon Romanovsky
vx.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Thanks, Acked-by: Leon Romanovsky And please don't send new version of patches as a reply-to, it is annoying like hell. Thanks

Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO

2021-02-22 Thread Leon Romanovsky
On Mon, Feb 22, 2021 at 12:46:45PM -0400, Jason Gunthorpe wrote: > On Mon, Feb 22, 2021 at 08:26:10AM -0800, Randy Dunlap wrote: > > On 2/22/21 7:58 AM, Jason Gunthorpe wrote: > > > On Mon, Feb 22, 2021 at 03:00:03PM +0200, Leon Romanovsky wrote: > > >> On Mon, Fe

Re: [PATCH -next] net/mlx5_core: remove unused including

2020-12-08 Thread Leon Romanovsky
On Tue, Dec 08, 2020 at 11:22:26AM -0800, Jakub Kicinski wrote: > On Mon, 7 Dec 2020 20:14:00 +0800 Zou Wei wrote: > > Remove including that don't need it. > > > > Signed-off-by: Zou Wei > > --- > > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 1 - > > 1 file changed, 1 deletion(-) > > > >

Re: [resend/standalone PATCH v4] Add auxiliary bus support

2020-12-04 Thread Leon Romanovsky
> > Co-developed-by: Kiran Patil > > Co-developed-by: Ranjani Sridharan > > Co-developed-by: Fred Oh > > Co-developed-by: Leon Romanovsky > > Signed-off-by: Kiran Patil > > Signed-off-by: Ranjani Sridharan > > Signed-off-by: Fred Oh > > Signed-

Re: [resend/standalone PATCH v4] Add auxiliary bus support

2020-12-04 Thread Leon Romanovsky
> > Co-developed-by: Kiran Patil > > Co-developed-by: Ranjani Sridharan > > Co-developed-by: Fred Oh > > Co-developed-by: Leon Romanovsky > > Signed-off-by: Kiran Patil > > Signed-off-by: Ranjani Sridharan > > Signed-off-by: Fred Oh > > Signed-

Re: [PATCH v2 0/9] Add support for Microsoft Surface System Aggregator Module

2020-12-05 Thread Leon Romanovsky
ome with very strong justifications why it is not fit yet. I'm sorry to say, but this series is not ready to be merged yet. NAK: Leon Romanovsky Thanks

Re: [PATCH v2 07/17] driver core: Add fwnode_init()

2020-12-05 Thread Leon Romanovsky
On Fri, Nov 20, 2020 at 06:02:22PM -0800, Saravana Kannan wrote: > There are multiple locations in the kernel where a struct fwnode_handle > is initialized. Add fwnode_init() so that we have one way of > initializing a fwnode_handle. > > Signed-off-by: Saravana Kannan > --- > drivers/acpi/propert

Re: [PATCH v2 08/17] driver core: Add fwnode link support

2020-12-05 Thread Leon Romanovsky
On Fri, Nov 20, 2020 at 06:02:23PM -0800, Saravana Kannan wrote: > Add support for creating supplier-consumer links between fwnodes. It is > intended for internal use the driver core and generic firmware support > code (eg. Device Tree, ACPI), so it is simple by design and the API > provided is li

Re: [PATCH v13 0/4] userspace MHI client interface driver

2020-12-06 Thread Leon Romanovsky
On Tue, Dec 01, 2020 at 09:59:53PM -0700, Jeffrey Hugo wrote: > On 12/1/2020 7:55 PM, Jakub Kicinski wrote: > > On Tue, 1 Dec 2020 13:48:36 -0700 Jeffrey Hugo wrote: > > > On 12/1/2020 1:03 PM, Jakub Kicinski wrote: > > > > On Tue, 1 Dec 2020 12:40:50 -0700 Jeffrey Hugo wrote: > > > > > On 12/1/202

Re: [PATCH v2 0/9] Add support for Microsoft Surface System Aggregator Module

2020-12-06 Thread Leon Romanovsky
On Sun, Dec 06, 2020 at 09:32:30AM +0100, Greg Kroah-Hartman wrote: > On Sun, Dec 06, 2020 at 09:07:05AM +0200, Leon Romanovsky wrote: > > On Thu, Dec 03, 2020 at 10:26:31PM +0100, Maximilian Luz wrote: > > > Hello, > > > > > > Here is version two of the Surfac

Re: [PATCH v2 0/9] Add support for Microsoft Surface System Aggregator Module

2020-12-06 Thread Leon Romanovsky
On Sun, Dec 06, 2020 at 09:41:21AM +0100, Hans de Goede wrote: > Hi Leon, > > On 12/6/20 8:07 AM, Leon Romanovsky wrote: > > On Thu, Dec 03, 2020 at 10:26:31PM +0100, Maximilian Luz wrote: > >> Hello, > >> > >> Here is version two of the Surface Syste

Re: [PATCH v2 0/9] Add support for Microsoft Surface System Aggregator Module

2020-12-06 Thread Leon Romanovsky
On Sun, Dec 06, 2020 at 05:58:32PM +0900, Blaž Hrastnik wrote: > > > > > More on that, the whole purpose of proposed interface is to debug and > > > not intended to be used by any user space code. > > > > The purpose is to provide raw access to the Surface Serial Hub protocol, > > just like we prov

Re: [PATCH v2 0/9] Add support for Microsoft Surface System Aggregator Module

2020-12-06 Thread Leon Romanovsky
On Sun, Dec 06, 2020 at 11:04:06AM +0100, Hans de Goede wrote: > Hi, > > On 12/6/20 9:56 AM, Leon Romanovsky wrote: > > On Sun, Dec 06, 2020 at 09:41:21AM +0100, Hans de Goede wrote: > >> Hi Leon, > >> > >> On 12/6/20 8:07 AM, Leon Romanovsky wrote: >

Re: [PATCH v2 0/9] Add support for Microsoft Surface System Aggregator Module

2020-12-06 Thread Leon Romanovsky
On Sun, Dec 06, 2020 at 11:33:40AM +0100, Maximilian Luz wrote: > On 12/6/20 10:06 AM, Leon Romanovsky wrote:> On Sun, Dec 06, 2020 at > 05:58:32PM +0900, Blaž Hrastnik wrote: > > > > > > > > > More on that, the whole purpose of proposed interface is to debug a

Re: [PATCH v2 0/9] Add support for Microsoft Surface System Aggregator Module

2020-12-06 Thread Leon Romanovsky
On Sun, Dec 06, 2020 at 11:41:46AM +0100, Hans de Goede wrote: > Hi, > > On 12/6/20 11:33 AM, Leon Romanovsky wrote: > > On Sun, Dec 06, 2020 at 11:04:06AM +0100, Hans de Goede wrote: > > > > >> But there is a difference between being careful and just nacking &

Re: [PATCH v2 0/9] Add support for Microsoft Surface System Aggregator Module

2020-12-06 Thread Leon Romanovsky
On Sun, Dec 06, 2020 at 04:58:52PM +0100, Maximilian Luz wrote: > On 12/6/20 8:07 AM, Leon Romanovsky wrote: > > On Thu, Dec 03, 2020 at 10:26:31PM +0100, Maximilian Luz wrote: > > > Hello, > > > > > > Here is version two of the Surface System Aggregator M

Re: possible deadlock in _destroy_id

2020-11-24 Thread Leon Romanovsky
gt; > > > but task is already holding lock: > > 8c684748 (lock#6){+.+.}-{3:3}, at: cma_add_one+0x55c/0xce0 > > drivers/infiniband/core/cma.c:4902 > > Leon, this is caused by > > commit c80a0c52d85c49a910d0dc0e342e8d8898677dc0 > Author: Leon Romanovsky >

[PATCH bpf-next] kbuild: Restore ability to build out-of-tree modules

2020-12-01 Thread Leon Romanovsky
From: Leon Romanovsky The out-of-tree modules are built without vmlinux target and request to recompile that target unconditionally causes to the following compilation error. [root@server kernel]# make <..> make -f ./scripts/Makefile.modpost make -f ./scripts/Makefile.modfinal make[3]:

Re: [PATCH bpf-next] kbuild: Restore ability to build out-of-tree modules

2020-12-01 Thread Leon Romanovsky
On Tue, Dec 01, 2020 at 10:01:23AM -0800, Andrii Nakryiko wrote: > On Tue, Dec 1, 2020 at 6:37 AM Leon Romanovsky wrote: > > > > From: Leon Romanovsky > > > > The out-of-tree modules are built without vmlinux target and request > > to recompile that target uncond

Re: [PATCH bpf-next] kbuild: Restore ability to build out-of-tree modules

2020-12-01 Thread Leon Romanovsky
On Tue, Dec 01, 2020 at 01:44:46PM -0800, Andrii Nakryiko wrote: > On Tue, Dec 1, 2020 at 11:32 AM Leon Romanovsky wrote: > > > > On Tue, Dec 01, 2020 at 10:01:23AM -0800, Andrii Nakryiko wrote: > > > On Tue, Dec 1, 2020 at 6:37 AM Leon Romanovsky wrote: > > >

Re: [Ksummit-discuss] crediting bug reports and fixes folded into original patch

2020-12-03 Thread Leon Romanovsky
On Wed, Dec 02, 2020 at 08:02:27PM -0800, Dan Williams wrote: > On Wed, Dec 2, 2020 at 3:44 PM Vlastimil Babka wrote: > > > > Hi, > > > > there was a bit of debate on Twitter about this, so I thought I would bring > > it > > here. Imagine a scenario where patch sits as a commit in -next and there

Re: linux-next: build warning after merge of the rdma tree

2020-12-03 Thread Leon Romanovsky
On Thu, Dec 03, 2020 at 06:42:19PM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the rdma tree, today's linux-next build (htmldocs) produced > this warning: > > drivers/infiniband/core/verbs.c:1206: warning: Function parameter or member > 'caller' not described in 'ib_create_named_qp'

Re: [Ksummit-discuss] crediting bug reports and fixes folded into original patch

2020-12-03 Thread Leon Romanovsky
On Thu, Dec 03, 2020 at 10:36:56AM +0100, Geert Uytterhoeven wrote: > On Thu, Dec 3, 2020 at 10:35 AM Leon Romanovsky wrote: > > On Wed, Dec 02, 2020 at 08:02:27PM -0800, Dan Williams wrote: > > > On Wed, Dec 2, 2020 at 3:44 PM Vlastimil Babka wrote: > > > > there

Re: [resend/standalone PATCH v4] Add auxiliary bus support

2020-12-03 Thread Leon Romanovsky
On Thu, Dec 03, 2020 at 04:07:42PM +0100, Greg KH wrote: > On Wed, Dec 02, 2020 at 04:54:24PM -0800, Dan Williams wrote: > > PS: Greg I know I promised some review on newcomer patches to help with > > your queue, unfortunately Intel-internal review is keeping my plate > > full. Again, I do not want

Re: [Ksummit-discuss] crediting bug reports and fixes folded into original patch

2020-12-03 Thread Leon Romanovsky
On Thu, Dec 03, 2020 at 07:30:44PM +0100, Greg KH wrote: > On Thu, Dec 03, 2020 at 12:40:47PM +0200, Leon Romanovsky wrote: > > On Thu, Dec 03, 2020 at 10:36:56AM +0100, Geert Uytterhoeven wrote: > > > On Thu, Dec 3, 2020 at 10:35 AM Leon Romanovsky wrote: > > > >

Re: [PATCH 0/4] Expose and manage PCI device reset

2021-03-14 Thread Leon Romanovsky
On Fri, Mar 12, 2021 at 11:04:48PM +0530, ameynarkhed...@gmail.com wrote: > From: Amey Narkhede > > PCI and PCIe devices may support a number of possible reset mechanisms > for example Function Level Reset (FLR) provided via Advanced Feature or > PCIe capabilities, Power Management reset, bus rese

[PATCH rdma-next 0/2] Spring cleanup

2021-03-14 Thread Leon Romanovsky
From: Leon Romanovsky Bunch of cleanup in RDMA subsystem. Leon Romanovsky (2): RDMA: Fix kernel-doc compilation warnings RDMA: Delete not-used static inline functions drivers/infiniband/hw/cxgb4/iw_cxgb4.h| 11 -- drivers/infiniband/hw/cxgb4/t4.h | 33

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

2021-03-15 Thread Leon Romanovsky
On Mon, Mar 15, 2021 at 08:34:09AM -0600, Alex Williamson wrote: > On Mon, 15 Mar 2021 14:52:26 +0100 > Pali Rohár wrote: > > > On Monday 15 March 2021 19:13:23 Amey Narkhede wrote: > > > slot reset (pci_dev_reset_slot_function) and secondary bus > > > reset(pci_parent_bus_reset) which I think are

<    1   2   3   4   5   6   7   8   9   10   >