Re: [PATCH 06/20] IB/ipoib: drop useless LIST_HEAD

2018-12-23 Thread Leon Romanovsky
mantic patch that fixes this problem is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > identifier x; > @@ > - LIST_HEAD(x); > ... when != x > // > > Fixes: 31c02e215700 ("IPoIB: Avoid using stale last_send counter when reaping > AHs&quo

Re: [PATCH] PCI: Add no-D3 quirk for Mellanox ConnectX-[45]

2019-01-07 Thread Leon Romanovsky
On Mon, Jan 07, 2019 at 09:01:29PM -0700, Jason Gunthorpe wrote: > On Sun, Jan 06, 2019 at 09:43:46AM +1100, Benjamin Herrenschmidt wrote: > > On Sat, 2019-01-05 at 10:51 -0700, Jason Gunthorpe wrote: > > > > > > > Interesting. I've investigated this further, though I don't have as > > > > many ne

Re: [PATCH] infiniband: bnxt_re: qplib: Check the return value of send_message

2018-12-31 Thread Leon Romanovsky
On Wed, Dec 26, 2018 at 12:56:22PM -0600, Aditya Pakki wrote: > In bnxt_qplib_map_tc2cos(), bnxt_qplib_rcfw_send_message() can return > an error value. The fix returns the error from the latter function > upstream. > > Signed-off-by: Aditya Pakki > --- > drivers/infiniband/hw/bnxt_re/qplib_sp.c |

Re: [PATCH -next] IB/qib: Add missing err handle for qib_user_sdma_rb_insert

2019-01-02 Thread Leon Romanovsky
On Wed, Jan 02, 2019 at 10:12:24AM -0700, Jason Gunthorpe wrote: > On Fri, Dec 21, 2018 at 10:19:38AM +0800, YueHaibing wrote: > > It should goto err handle if qib_user_sdma_rb_insert fails, > > other than success return. > > > > Fixes: 67810e8c3c01 ("RDMA/qib: Remove all occurrences of BUG_ON()")

Re: [PATCH -next] IB/qib: Add missing err handle for qib_user_sdma_rb_insert

2019-01-02 Thread Leon Romanovsky
On Wed, Jan 02, 2019 at 12:07:40PM -0700, Jason Gunthorpe wrote: > On Wed, Jan 02, 2019 at 08:40:50PM +0200, Leon Romanovsky wrote: > > On Wed, Jan 02, 2019 at 10:12:24AM -0700, Jason Gunthorpe wrote: > > > On Fri, Dec 21, 2018 at 10:19:38AM +0800, YueHaibing wrote: > >

Re: [PATCH] infiniband/qedr: Potential null ptr dereference of qp

2018-12-24 Thread Leon Romanovsky
On Mon, Dec 24, 2018 at 12:24:45PM -0600, Aditya Pakki wrote: > idr_find() may fail and return a NULL pointer. The fix checks the > return value of the function and returns an error in case of NULL. > > Signed-off-by: Aditya Pakki > --- > drivers/infiniband/hw/qedr/qedr_iw_cm.c | 2 ++ > 1 file c

Re: [PATCH] infiniband: add checks for the status of nla_put

2018-12-26 Thread Leon Romanovsky
On Tue, Dec 25, 2018 at 08:11:39PM -0600, Kangjie Lu wrote: > The fix inserts multiple checks for nla_put, and issues warnings if it > fails. > > Signed-off-by: Kangjie Lu > --- I didn't look very close, but it strange that failure in nla_put() doesn't follow by canceling of netlink message. Plu

Re: [PATCH] infiniband: fix a missing check of nla_put

2018-12-26 Thread Leon Romanovsky
On Tue, Dec 25, 2018 at 08:05:48PM -0600, Kangjie Lu wrote: > nla_put() may fail. The fix adds a check for its return value, and > returns -EMSGSIZE if it fails. > > Signed-off-by: Kangjie Lu > --- > drivers/infiniband/core/addr.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) The sam

Re: WARNING in __put_task_struct (2)

2018-10-09 Thread Leon Romanovsky
0)={0x0, 0x18, > > 0xfa00, {0x0, &(0x7f000300)={0x}, 0x13f}}, > > 0x20) > > write$RDMA_USER_CM_CMD_SET_OPTION(r0, &(0x7f0002c0)={0xe, 0x18, > > 0xfa00, @id_afonly={&(0x7f00)=0x1, r1, 0x0, 0x2, 0x4}}, 0x20) > > write$RDMA_USER_CM_CMD_RESOLVE

Re: [PATCH] RDMA/hns: Use 64-bit arithmetic instead of 32-bit

2018-10-29 Thread Leon Romanovsky
On Thu, Oct 18, 2018 at 08:17:10PM -0400, Doug Ledford wrote: > On Thu, 2018-10-18 at 14:01 +0300, Leon Romanovsky wrote: > > On Thu, Oct 18, 2018 at 10:02:58AM +0200, Gustavo A. R. Silva wrote: > > > Cast *max_num_sg* to u64 in order to give the compiler complete > >

Re: WARNING: ODEBUG bug in free_task

2018-10-11 Thread Leon Romanovsky
On Wed, Oct 10, 2018 at 02:59:38PM +0200, Dmitry Vyukov wrote: > On Tue, Oct 9, 2018 at 7:14 PM, syzbot > wrote: > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:ae16eea39a86 Add linux-next specific files for 20181008 > > git tree: linux-next > > console output

Re: [PATCH] RDMA/hns: Use 64-bit arithmetic instead of 32-bit

2018-10-18 Thread Leon Romanovsky
On Thu, Oct 18, 2018 at 10:02:58AM +0200, Gustavo A. R. Silva wrote: > Cast *max_num_sg* to u64 in order to give the compiler complete > information about the proper arithmetic to use. > > Notice that such variable is used in a context that expects an > expression of type u64 (64 bits, unsigned) an

Re: [PATCH 1/2] IB/mlx4: Enable debug print of SMPs

2018-09-17 Thread Leon Romanovsky
anged, 1 insertion(+), 1 deletion(-) > Thanks, Acked-by: Leon Romanovsky signature.asc Description: PGP signature

Re: [PATCH 2/2] IB/mlx4: Add port and TID to MAD debug print

2018-09-17 Thread Leon Romanovsky
gt; Thanks, Acked-by: Leon Romanovsky signature.asc Description: PGP signature

Re: [PATCH 0/4] IB: decrease large contigous allocation

2018-09-18 Thread Leon Romanovsky
On Tue, Sep 18, 2018 at 08:46:23AM -0600, Jason Gunthorpe wrote: > On Tue, Sep 18, 2018 at 04:03:42PM +0300, Jan Dakinevich wrote: > > The size of mlx4_ib_device became too large to be allocated as whole > > contigous > > block of memory. Currently it takes about 55K. On architecture with 4K page

Re: (subset) [PATCH vhost 0/7] vdpa/mlx5: Add support for resumable vqs

2023-12-04 Thread Leon Romanovsky
ust to > update the map. When resumable vqs are supported it is enough to > suspend the vqs, set the new maps, and then resume the vqs. > > [...] Applied, thanks! [1/7] vdpa/mlx5: Expose resumable vq capability https://git.kernel.org/rdma/rdma/c/b24910e1be0e76 Best regards, -- Leon Romanovsky

Re: [PATCH vhost 0/7] vdpa/mlx5: Parallelize device suspend/resume

2024-08-04 Thread Leon Romanovsky
On Fri, Aug 02, 2024 at 09:14:28AM -0400, Michael S. Tsirkin wrote: > On Fri, Aug 02, 2024 at 10:20:17AM +0300, Dragos Tatulea wrote: > > This series parallelizes the mlx5_vdpa device suspend and resume > > operations through the firmware async API. The purpose is to reduce live > > migration downt

Re: [PATCH vhost 0/7] vdpa/mlx5: Parallelize device suspend/resume

2024-08-04 Thread Leon Romanovsky
On Sun, Aug 04, 2024 at 09:39:29AM -0400, Michael S. Tsirkin wrote: > On Sun, Aug 04, 2024 at 11:48:39AM +0300, Leon Romanovsky wrote: > > On Fri, Aug 02, 2024 at 09:14:28AM -0400, Michael S. Tsirkin wrote: > > > On Fri, Aug 02, 2024 at 10:20:17AM +0300, Dragos Tatulea wrote: &

Re: [RFC PATCH 6/7] RDMA/rxe: Add support for Send/Recv/Write/Read operations with ODP

2022-09-08 Thread Leon Romanovsky
On Wed, Sep 07, 2022 at 11:43:04AM +0900, Daisuke Matsuda wrote: > rxe_mr_copy() is used widely to copy data to/from a user MR. requester uses > it to load payloads of requesting packets; responder uses it to process > Send, Write, and Read operaetions; completer uses it to copy data from > respons

Re: [RFC PATCH v2 0/7] On-Demand Paging on SoftRoCE

2022-11-16 Thread Leon Romanovsky
On Fri, Nov 11, 2022 at 06:22:21PM +0900, Daisuke Matsuda wrote: > This patch series implements the On-Demand Paging feature on SoftRoCE(rxe) > driver, which has been available only in mlx5 driver[1] so far. <...> > Daisuke Matsuda (7): > IB/mlx5: Change ib_umem_odp_map_dma_single_page() to ret

Re: [PATCH for-next v3 1/7] RDMA/rxe: Convert triple tasklets to use workqueue

2022-12-28 Thread Leon Romanovsky
On Wed, Dec 28, 2022 at 10:56:11AM -0600, Bob Pearson wrote: > On 12/23/22 00:51, Daisuke Matsuda wrote: > > In order to implement On-Demand Paging on the rxe driver, triple tasklets > > (requester, responder, and completer) must be allowed to sleep so that they > > can trigger page fault when page

Re: [Patch v5 0/5] RDMA/mana_ib

2023-09-11 Thread Leon Romanovsky
On Thu, Sep 07, 2023 at 09:52:34AM -0700, sharmaa...@linuxonhyperv.com wrote: > From: Ajay Sharma > > Change from v4: > Send qp fatal error event to the context that > created the qp. Add lookup table for qp. > > Ajay Sharma (5): > RDMA/mana_ib : Rename all mana_ib_dev type variables to mib_de

Re: [PATCH 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver

2021-02-14 Thread Leon Romanovsky
On Mon, Feb 15, 2021 at 02:06:53PM +0900, Nobuhiro Iwamatsu wrote: > Add dwmac-visconti to the stmmac driver in Toshiba Visconti ARM SoCs. > This patch contains only the basic function of the device. There is no > clock control, PM, etc. yet. These will be added in the future. > > Signed-off-by: No

Re: [PATCH 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver

2021-02-15 Thread Leon Romanovsky
On Mon, Feb 15, 2021 at 04:28:09PM +0900, Nobuhiro Iwamatsu wrote: > Hi, > > Thanks for your review. > > On Mon, Feb 15, 2021 at 08:07:21AM +0200, Leon Romanovsky wrote: > > On Mon, Feb 15, 2021 at 02:06:53PM +0900, Nobuhiro Iwamatsu wrote: > > > Add dwmac-visconti t

Re: [PATCH net-next RFC v3] net: hdlc_x25: Queue outgoing LAPB frames

2021-02-15 Thread Leon Romanovsky
On Sun, Feb 14, 2021 at 11:27:03PM -0800, Xie He wrote: > When sending packets, we will first hand over the (L3) packets to the > LAPB module. The LAPB module will then hand over the corresponding LAPB > (L2) frames back to us for us to transmit. > > The LAPB module can also emit LAPB (L2) frames a

Re: [PATCH net-next RFC v3] net: hdlc_x25: Queue outgoing LAPB frames

2021-02-15 Thread Leon Romanovsky
On Mon, Feb 15, 2021 at 09:23:32AM -0800, Xie He wrote: > On Mon, Feb 15, 2021 at 1:25 AM Leon Romanovsky wrote: > > > > > + /* When transmitting data: > > > + * first we'll remove a pseudo header of 1 byte, > > > + * then the LAPB module

Re: [PATCH net-next RFC v3] net: hdlc_x25: Queue outgoing LAPB frames

2021-02-15 Thread Leon Romanovsky
On Mon, Feb 15, 2021 at 11:08:02AM -0800, Xie He wrote: > On Mon, Feb 15, 2021 at 10:54 AM Leon Romanovsky wrote: > > > > On Mon, Feb 15, 2021 at 09:23:32AM -0800, Xie He wrote: > > > On Mon, Feb 15, 2021 at 1:25 AM Leon Romanovsky wrote: > > > > >

Re: [PATCH] vdpa/mlx5: Extract correct pointer from driver data

2021-02-15 Thread Leon Romanovsky
On Tue, Feb 16, 2021 at 07:50:22AM +0200, Eli Cohen wrote: > struct mlx5_vdpa_net pointer was stored in drvdata. Extract it as well > in mlx5v_remove(). > > Fixes: 74c9729dd892 ("vdpa/mlx5: Connect mlx5_vdpa to auxiliary bus") > Signed-off-by: Eli Cohen > --- > drivers/vdpa/mlx5/net/mlx5_vnet.c |

Re: [PATCH] vdpa/mlx5: Extract correct pointer from driver data

2021-02-15 Thread Leon Romanovsky
On Tue, Feb 16, 2021 at 08:42:26AM +0200, Eli Cohen wrote: > On Tue, Feb 16, 2021 at 08:35:51AM +0200, Leon Romanovsky wrote: > > On Tue, Feb 16, 2021 at 07:50:22AM +0200, Eli Cohen wrote: > > > struct mlx5_vdpa_net pointer was stored in drvdata. Extract it as well >

Re: [PATCH net-next RFC v3] net: hdlc_x25: Queue outgoing LAPB frames

2021-02-15 Thread Leon Romanovsky
On Mon, Feb 15, 2021 at 11:30:25PM -0800, Xie He wrote: > On Mon, Feb 15, 2021 at 10:04 PM Leon Romanovsky wrote: > > > > On Mon, Feb 15, 2021 at 11:08:02AM -0800, Xie He wrote: > > > On Mon, Feb 15, 2021 at 10:54 AM Leon Romanovsky wrote: > > > > > > &g

Re: [net-next v2] octeontx2-af: cn10k: Fixes CN10K RPM reference issue

2021-02-16 Thread Leon Romanovsky
On Tue, Feb 16, 2021 at 05:09:36PM +0530, Geetha sowjanya wrote: > This patch fixes references to uninitialized variables and > debugfs entry name for CN10K platform and HW_TSO flag check. > > Fixes: 3ad3f8f93c81 ("octeontx2-af: cn10k: MAC internal loopback support"). > Signed-off-by: Geetha sowjan

Re: [PATCH] vdpa/mlx5: Extract correct pointer from driver data

2021-02-16 Thread Leon Romanovsky
On Tue, Feb 16, 2021 at 02:45:40PM +0200, Eli Cohen wrote: > On Tue, Feb 16, 2021 at 09:37:34AM +0200, Leon Romanovsky wrote: > > On Tue, Feb 16, 2021 at 08:42:26AM +0200, Eli Cohen wrote: > > > On Tue, Feb 16, 2021 at 08:35:51AM +0200, Leon Romanovsky wrote: > > > >

Re: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Leon Romanovsky
On Wed, Apr 07, 2021 at 03:05:26PM +, Haiyang Zhang wrote: > > > > -Original Message- > > From: Leon Romanovsky > > Sent: Wednesday, April 7, 2021 10:55 AM > > To: Haiyang Zhang > > Cc: Dexuan Cui ; da...@davemloft.net; > > k...@ker

Re: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-08 Thread Leon Romanovsky
On Wed, Apr 07, 2021 at 09:59:52PM +, Dexuan Cui wrote: > > From: Leon Romanovsky > > Sent: Wednesday, April 7, 2021 5:45 AM > > > > > > > > BTW, you don't need to write { 0 }, the {} is enough. > > > > > > Thanks for the suggesti

Re: [PATCH RESEND] block:bounce: fix call inc_|dec_zone_page_state on different pages confuse value of NR_BOUNCE

2015-04-13 Thread Leon Romanovsky
>bv_page, NR_BOUNCE); > to->bv_page = mempool_alloc(pool, q->bounce_gfp); > + inc_zone_page_state(to->bv_page, NR_BOUNCE); > > if (rw == WRITE) { > char *vto, *vfrom; > -- > 2.2.2.dirty > > -- >

Re: [RFC 2/3] mm: make optimistic check for swapin readahead

2015-06-14 Thread Leon Romanovsky
et, unmapped); > if (ret) { > node = khugepaged_find_target_node(); > /* collapse_huge_page will return with the mmap_sem released > */ > -- > 1.9.1 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the

Re: [RFC 2/3] mm: make optimistic check for swapin readahead

2015-06-14 Thread Leon Romanovsky
On Mon, Jun 15, 2015 at 8:43 AM, Rik van Riel wrote: > On 06/15/2015 01:40 AM, Leon Romanovsky wrote: >> On Sun, Jun 14, 2015 at 6:04 PM, Ebru Akagunduz >> wrote: >>> This patch makes optimistic check for swapin readahead >>> to increase thp collapse rate. Before

Re: [RFC 2/3] mm: make optimistic check for swapin readahead

2015-06-15 Thread Leon Romanovsky
On Mon, Jun 15, 2015 at 5:05 PM, Rik van Riel wrote: > > On 06/14/2015 11:04 AM, Ebru Akagunduz wrote: > > This patch makes optimistic check for swapin readahead > > to increase thp collapse rate. Before getting swapped > > out pages to memory, checks them and allows up to a > > certain number. It

Re: [RFC v3 4/4] shmem: Add support for generic FS events

2015-06-16 Thread Leon Romanovsky
> } > - if (error == -ENOSPC && !once++) { > + if (error == -ENOSPC) { > + if (!once++) { > info = SHMEM_I(inode); > spin_lock(&info->lock); > shmem_recalc_inode(inode); > spin_unlock(&info->lock); >

Re: [RFC v3 3/4] ext4: Add support for generic FS events

2015-06-16 Thread Leon Romanovsky
= EXT4_SB(sb); > + struct ext4_super_block *es = sbi->s_es; > + ext4_fsblk_t rsv_blocks; > + ext4_fsblk_t nblocks; > + > + nblocks = percpu_counter_sum_positive(&sbi->s_freeclusters_counter) - > + percpu_counter_sum_positive(

Re: [RFC PATCH 01/12] mm: add a new config to manage the code

2015-06-08 Thread Leon Romanovsky
; in > the body to majord...@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: mailto:"d...@kvack.org";> em...@kvack.org -- Leon Romanovsky | Independent Linux Consultant www.leon.nu | l...@leon.nu -- To unsubscribe from

Re: [RFC PATCH 01/12] mm: add a new config to manage the code

2015-06-08 Thread Leon Romanovsky
nf.o HOSTCC scripts/kconfig/zconf.tab.o HOSTLD scripts/kconfig/conf *** Default configuration is based on 'x86_64_defconfig' # # configuration written to .config # ➜ linux-mm git:(dev) ✗ grep CONFIG_MEMORY_MIRROR .config CONFIG_MEMORY_MIRROR=y > > -Tony -- Leon Romanovsky

Re: [PATCH] net, swap: Remove a warning and clarify why sk_mem_reclaim is required when deactivating swap

2015-06-10 Thread Leon Romanovsky
t;sk_forward_alloc >= SK_MEM_QUANTUM) 1410 __sk_mem_reclaim(sk); 1411 } > sk_mem_reclaim(sk); > } > EXPORT_SYMBOL_GPL(sk_clear_memalloc); > -- > 2.4.2 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in >

Re: [PATCH rdma-next 3/5] RDMA/hns: Increase checking CMQ status timeout value

2018-05-22 Thread Leon Romanovsky
On Thu, May 17, 2018 at 04:02:51PM +0800, Wei Hu (Xavier) wrote: > This patch increases checking CMQ status timeout value and > uses the same value with NIC driver to avoid deficiency of > time. > > Signed-off-by: Wei Hu (Xavier) > --- > drivers/infiniband/hw/hns/hns_roce_hw_v2.h | 2 +- > 1 file

Re: [PATCH rdma-next 2/5] RDMA/hns: Modify uar allocation algorithm to avoid bitmap exhaust

2018-05-22 Thread Leon Romanovsky
On Thu, May 17, 2018 at 04:02:50PM +0800, Wei Hu (Xavier) wrote: > This patch modified uar allocation algorithm in hns_roce_uar_alloc > function to avoid bitmap exhaust. > > Signed-off-by: Wei Hu (Xavier) > --- > drivers/infiniband/hw/hns/hns_roce_device.h | 1 + > drivers/infiniband/hw/hns/hns_

Re: [PATCH rdma-next 5/5] RDMA/hns: Fix the illegal memory operation when cross page

2018-05-22 Thread Leon Romanovsky
On Thu, May 17, 2018 at 04:02:53PM +0800, Wei Hu (Xavier) wrote: > This patch fixed the potential illegal operation when using the > extend sge buffer cross page in post send operation. The bug > will cause the calltrace. > > Reported-by: Jie Chen > Reported-by: Xiping Zhang (Francis) > Fixes: b1

Re: [PATCH rdma-next 3/5] RDMA/hns: Increase checking CMQ status timeout value

2018-05-22 Thread Leon Romanovsky
On Wed, May 23, 2018 at 02:15:48PM +0800, Wei Hu (Xavier) wrote: > > > On 2018/5/23 14:09, Wei Hu (Xavier) wrote: > > > > On 2018/5/23 13:49, Leon Romanovsky wrote: > >> On Thu, May 17, 2018 at 04:02:51PM +0800, Wei Hu (Xavier) wrote: > >>> This patch i

Re: [PATCH rdma-next 2/5] RDMA/hns: Modify uar allocation algorithm to avoid bitmap exhaust

2018-05-23 Thread Leon Romanovsky
On Wed, May 23, 2018 at 02:49:35PM +0800, Wei Hu (Xavier) wrote: > > > On 2018/5/23 14:05, Leon Romanovsky wrote: > > On Thu, May 17, 2018 at 04:02:50PM +0800, Wei Hu (Xavier) wrote: > >> This patch modified uar allocation algorithm in hns_roce_uar_alloc > >>

Re: [PATCH rdma-next 2/5] RDMA/hns: Modify uar allocation algorithm to avoid bitmap exhaust

2018-05-23 Thread Leon Romanovsky
On Wed, May 23, 2018 at 03:12:45PM +0800, Wei Hu (Xavier) wrote: > > > On 2018/5/23 15:00, Leon Romanovsky wrote: > > On Wed, May 23, 2018 at 02:49:35PM +0800, Wei Hu (Xavier) wrote: > >> > >> On 2018/5/23 14:05, Leon Romanovsky wrote: > >>> On Thu, May

Re: KASAN: stack-out-of-bounds Read in rdma_bind_addr (2)

2018-04-03 Thread Leon Romanovsky
#syz dup: kernel BUG at lib/string.c:LINE! (3) On Thu, Mar 29, 2018 at 03:01:02PM -0700, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > 0b412605ef5f5c64b31f19e2910b1d5eba9929c3 (Thu Mar 29 01:07:23 2018 +) > Merge tag 'drm-fixes-for-v4.16-rc8' of > git://people.

Re: linux-next: manual merge of the rdma tree with the rdma-fixes tree

2018-05-02 Thread Leon Romanovsky
On Mon, Apr 30, 2018 at 08:55:35PM -0400, Doug Ledford wrote: > On Tue, 2018-05-01 at 10:10 +1000, Stephen Rothwell wrote: > > Hi all, > > > > Today's linux-next merge of the rdma tree got a conflict in: > > > > drivers/infiniband/sw/rxe/rxe_resp.c > > > > between commit: > > > > 9fd4350ba895 (

Re: [PATCH] IB/mad: Use ID allocator routines to allocate agent number

2018-05-29 Thread Leon Romanovsky
On Tue, May 29, 2018 at 09:38:08AM +0200, Hans Westgaard Ry wrote: > The agent TID is a 64 bit value split in two dwords. The least > significant dword is the TID running counter. The most significant > dword is the agent number. In the CX-3 shared port model, the mlx4 > driver uses the most signi

Re: [PATCH] IB/mad: Use ID allocator routines to allocate agent number

2018-05-29 Thread Leon Romanovsky
On Tue, May 29, 2018 at 11:54:59AM +0300, Leon Romanovsky wrote: > On Tue, May 29, 2018 at 09:38:08AM +0200, Hans Westgaard Ry wrote: > > The agent TID is a 64 bit value split in two dwords. The least > > significant dword is the TID running counter. The most significant > &g

Re: [PATCH] IB/nes: fix nes_netdev_start_xmit()'s return type

2018-04-24 Thread Leon Romanovsky
On Tue, Apr 24, 2018 at 03:15:45PM +0200, Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too. >

Re: [PATCH] IB/nes: fix nes_netdev_start_xmit()'s return type

2018-04-25 Thread Leon Romanovsky
On Tue, Apr 24, 2018 at 08:36:12PM +0300, Leon Romanovsky wrote: > On Tue, Apr 24, 2018 at 03:15:45PM +0200, Luc Van Oostenryck wrote: > > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > > which is a typedef for an enum type, but the implemen

Re: [PATCH] IB/ipoib: fix ipoib_start_xmit()'s return type

2018-04-25 Thread Leon Romanovsky
ng 'netdev_tx_t' in this driver too. > > Signed-off-by: Luc Van Oostenryck > --- > drivers/infiniband/ulp/ipoib/ipoib_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky signature.asc Description: PGP signature

Re: linux-next: manual merge of the net-next tree with the rdma tree

2019-02-28 Thread Leon Romanovsky
On Wed, Feb 27, 2019 at 11:24:51AM -0500, Doug Ledford wrote: > On Wed, 2019-02-27 at 11:25 +1100, Stephen Rothwell wrote: > > Hi all, > > > > Today's linux-next merge of the net-next tree got a conflict in: > > > > drivers/infiniband/hw/mlx4/Kconfig > > > > between commit: > > > > 6fa8f1afd337

[PATCH -next] x86/apic: Reduce print level of CPU limit announcement

2019-03-26 Thread Leon Romanovsky
From: Leon Romanovsky Kernel is booted with less possible CPUs (possible_cpus kernel boot option) than available CPUs will have prints like this: [1.131039] APIC: NR_CPUS/possible_cpus limit of 8 reached. Processor 55/0x1f ignored. [1.132228] ACPI: Unable to map lapic to logical cpu

Re: [PATCH -next] x86/apic: Reduce print level of CPU limit announcement

2019-03-26 Thread Leon Romanovsky
On Tue, Mar 26, 2019 at 01:29:54PM +0100, Rafael J. Wysocki wrote: > On Tue, Mar 26, 2019 at 1:02 PM Leon Romanovsky wrote: > > > > From: Leon Romanovsky > > > > Kernel is booted with less possible CPUs (possible_cpus kernel boot > > option) than availabl

Re: [PATCH -next] x86/apic: Reduce print level of CPU limit announcement

2019-03-26 Thread Leon Romanovsky
On Tue, Mar 26, 2019 at 04:12:27PM +0100, Rafael J. Wysocki wrote: > On Tue, Mar 26, 2019 at 3:41 PM Leon Romanovsky wrote: > > > > On Tue, Mar 26, 2019 at 01:29:54PM +0100, Rafael J. Wysocki wrote: > > > On Tue, Mar 26, 2019 at 1:02 PM Leon Romanovsky wrote: &g

Re: [PATCH -next] x86/apic: Reduce print level of CPU limit announcement

2019-03-26 Thread Leon Romanovsky
On Tue, Mar 26, 2019 at 05:30:22PM +0100, Rafael J. Wysocki wrote: > On Tue, Mar 26, 2019 at 4:32 PM Leon Romanovsky wrote: > > > > On Tue, Mar 26, 2019 at 04:12:27PM +0100, Rafael J. Wysocki wrote: > > > On Tue, Mar 26, 2019 at 3:41 PM Leon Romanovsky wrote: > > &g

Re: [PATCH -next] x86/apic: Reduce print level of CPU limit announcement

2019-03-26 Thread Leon Romanovsky
On Tue, Mar 26, 2019 at 07:08:07PM +0100, Rafael J. Wysocki wrote: > On Tue, Mar 26, 2019 at 6:53 PM Leon Romanovsky wrote: > > > > On Tue, Mar 26, 2019 at 05:30:22PM +0100, Rafael J. Wysocki wrote: > > > On Tue, Mar 26, 2019 at 4:32 PM Leon Romanovsky wrote: > > &g

[PATCH -next v1] x86/apic: Reduce print level of CPU limit announcement

2019-03-27 Thread Leon Romanovsky
From: Leon Romanovsky Kernel is booted with less possible CPUs (possible_cpus kernel boot option) than available CPUs will have prints like this: [1.131039] APIC: NR_CPUS/possible_cpus limit of 8 reached. Processor 55/0x1f ignored. [1.132228] ACPI: Unable to map lapic to logical cpu

Re: [PATCH -next v1] x86/apic: Reduce print level of CPU limit announcement

2019-03-27 Thread Leon Romanovsky
On Wed, Mar 27, 2019 at 02:17:40AM -0700, Joe Perches wrote: > On Wed, 2019-03-27 at 11:09 +0200, Leon Romanovsky wrote: > > Kernel is booted with less possible CPUs (possible_cpus kernel boot > > option) than available CPUs will have prints like this: > [] > > diff --gi

Re: [PATCH -next v1] x86/apic: Reduce print level of CPU limit announcement

2019-03-27 Thread Leon Romanovsky
On Wed, Mar 27, 2019 at 02:49:02AM -0700, Joe Perches wrote: > On Wed, 2019-03-27 at 11:38 +0200, Leon Romanovsky wrote: > > On Wed, Mar 27, 2019 at 02:17:40AM -0700, Joe Perches wrote: > > > On Wed, 2019-03-27 at 11:09 +0200, Leon Romanovsky wrote: > > > > Kernel is

Re: [PATCH -next v1] x86/apic: Reduce print level of CPU limit announcement

2019-03-27 Thread Leon Romanovsky
On Wed, Mar 27, 2019 at 11:53:37AM +0200, Leon Romanovsky wrote: > On Wed, Mar 27, 2019 at 02:49:02AM -0700, Joe Perches wrote: > > On Wed, 2019-03-27 at 11:38 +0200, Leon Romanovsky wrote: > > > On Wed, Mar 27, 2019 at 02:17:40AM -0700, Joe Perches wrote: > > > > On

Re: [PATCH -next v1] x86/apic: Reduce print level of CPU limit announcement

2019-03-27 Thread Leon Romanovsky
On Wed, Mar 27, 2019 at 11:18:15AM +0100, Borislav Petkov wrote: > On Wed, Mar 27, 2019 at 12:11:33PM +0200, Leon Romanovsky wrote: > > ok, I tested your variant and it still prints a t least on my systems, > > Probably because your loglevel is set to debug. And no, we don'

Re: [PATCH -next v1] x86/apic: Reduce print level of CPU limit announcement

2019-03-27 Thread Leon Romanovsky
On Wed, Mar 27, 2019 at 12:14:52PM +0100, Borislav Petkov wrote: > On Wed, Mar 27, 2019 at 12:50:24PM +0200, Leon Romanovsky wrote: > > It is how we are internally running verification and development, > > with KERN_DEBUG level, we need it to catch bugs. > > And what is the

Re: [PATCH -next v1] x86/apic: Reduce print level of CPU limit announcement

2019-03-27 Thread Leon Romanovsky
On Wed, Mar 27, 2019 at 12:49:17PM +0100, Borislav Petkov wrote: > On Wed, Mar 27, 2019 at 01:36:28PM +0200, Leon Romanovsky wrote: > > At the end, it is reduced to our usage, we are running QEMU inside > > docker to test kernel changes with limitation on number of CPUs to use. >

Re: WARNING in cma_exit_net

2019-04-01 Thread Leon Romanovsky
On Mon, Apr 01, 2019 at 02:45:54PM -0300, Jason Gunthorpe wrote: > On Mon, Apr 01, 2019 at 10:36:05AM -0700, syzbot wrote: > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:e3ecb83e Add linux-next specific files for 20190401 > > git tree: linux-next > > console o

Re: KASAN: use-after-free Read in cma_check_port

2019-04-01 Thread Leon Romanovsky
#syz dup: WARNING in cma_exit_net On Mon, Apr 01, 2019 at 10:35:06AM -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:e3ecb83e Add linux-next specific files for 20190401 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt

Re: WARNING in cma_exit_net

2019-04-02 Thread Leon Romanovsky
On Tue, Apr 02, 2019 at 04:39:12PM -0700, Bart Van Assche wrote: > On Mon, 2019-04-01 at 21:29 +0300, Leon Romanovsky wrote: > > On Mon, Apr 01, 2019 at 02:45:54PM -0300, Jason Gunthorpe wrote: > > > On Mon, Apr 01, 2019 at 10:36:05AM -0700, syzbot wrote: > > > >

Re: [PATCH v3 0/1] Use HMM for ODP v3

2019-04-11 Thread Leon Romanovsky
On Wed, Apr 10, 2019 at 11:41:24AM -0400, jgli...@redhat.com wrote: > From: Jérôme Glisse > > Changes since v1/v2 are about rebase and better comments in the code. > Previous cover letter slightly updated. > > > This patchset convert RDMA ODP to use HMM underneath this is motivated > by stronger c

Re: [PATCH v2 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver

2021-02-13 Thread Leon Romanovsky
On Fri, Feb 12, 2021 at 11:58:04AM +0900, Nobuhiro Iwamatsu wrote: > Add dwmac-visconti to the stmmac driver in Toshiba Visconti ARM SoCs. > This patch contains only the basic function of the device. There is no > clock control, PM, etc. yet. These will be added in the future. > > Signed-off-by: No

Re: [PATCH v15 2/4] phy: Add media type and speed serdes configuration interfaces

2021-02-23 Thread Leon Romanovsky
On Tue, Feb 23, 2021 at 05:52:14PM +0530, Kishon Vijay Abraham I wrote: > Hi Leon, > > On 22/02/21 1:30 pm, Steen Hegelund wrote: > > Hi Leon, > > > > On Sun, 2021-02-21 at 07:59 +0200, Leon Romanovsky wrote: > >> EXTERNAL EMAIL: Do not click links or open

Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO

2021-02-24 Thread Leon Romanovsky
On Tue, Feb 23, 2021 at 11:05:45PM +0100, Arnd Bergmann wrote: > On Tue, Feb 23, 2021 at 10:54 PM Julian Braha wrote: > > On Tuesday, February 23, 2021 4:26:44 PM EST Arnd Bergmann wrote: > > > On Tue, Feb 23, 2021 at 9:46 PM Julian Braha > > > wrote: > > > > > > > > I have other similar patches

Re: [PATCH v5 6/6] docs: ABI: Add sysfs documentation interface of dw-xdata-pcie driver

2021-02-11 Thread Leon Romanovsky
On Thu, Feb 11, 2021 at 10:08:43AM +0100, Gustavo Pimentel wrote: > This patch describes the sysfs interface implemented on the dw-xdata-pcie > driver. > > Signed-off-by: Gustavo Pimentel > --- > Documentation/ABI/testing/sysfs-driver-xdata | 46 > > 1 file changed,

Re: [PATCH v5 1/6] misc: Add Synopsys DesignWare xData IP driver

2021-02-11 Thread Leon Romanovsky
On Thu, Feb 11, 2021 at 10:08:38AM +0100, Gustavo Pimentel wrote: > Add Synopsys DesignWare xData IP driver. This driver enables/disables > the PCI traffic generator module pertain to the Synopsys DesignWare > prototype. > > Signed-off-by: Gustavo Pimentel > --- > drivers/misc/dw-xdata-pcie.c | 3

Re: [PATCH v5 1/6] misc: Add Synopsys DesignWare xData IP driver

2021-02-11 Thread Leon Romanovsky
On Thu, Feb 11, 2021 at 01:32:13PM +0100, Greg Kroah-Hartman wrote: > On Thu, Feb 11, 2021 at 01:42:43PM +0200, Leon Romanovsky wrote: > > On Thu, Feb 11, 2021 at 10:08:38AM +0100, Gustavo Pimentel wrote: > > > Add Synopsys DesignWare xData IP driver. This driver enables/disa

Re: [PATCH v5 1/6] misc: Add Synopsys DesignWare xData IP driver

2021-02-11 Thread Leon Romanovsky
On Thu, Feb 11, 2021 at 03:02:03PM +0100, Greg Kroah-Hartman wrote: > On Thu, Feb 11, 2021 at 03:50:19PM +0200, Leon Romanovsky wrote: > > On Thu, Feb 11, 2021 at 01:32:13PM +0100, Greg Kroah-Hartman wrote: > > > On Thu, Feb 11, 2021 at 01:42:43PM +0200, Leon Romanovsky wrote: &

Re: [PATCH net-next RFC v4] net: hdlc_x25: Queue outgoing LAPB frames

2021-02-18 Thread Leon Romanovsky
On Tue, Feb 16, 2021 at 12:18:13PM -0800, Xie He wrote: > When sending packets, we will first hand over the (L3) packets to the > LAPB module. The LAPB module will then hand over the corresponding LAPB > (L2) frames back to us for us to transmit. > > The LAPB module can also emit LAPB (L2) frames a

Re: [PATCH net-next RFC v4] net: hdlc_x25: Queue outgoing LAPB frames

2021-02-18 Thread Leon Romanovsky
On Thu, Feb 18, 2021 at 01:07:13AM -0800, Xie He wrote: > On Thu, Feb 18, 2021 at 12:57 AM Leon Romanovsky wrote: > > > > It is nice that you are resending your patch without the resolution. > > However it will be awesome if you don't ignore review comments and fi

Re: [PATCH net-next RFC v4] net: hdlc_x25: Queue outgoing LAPB frames

2021-02-18 Thread Leon Romanovsky
On Thu, Feb 18, 2021 at 09:36:54AM -0800, Xie He wrote: > On Thu, Feb 18, 2021 at 2:37 AM Leon Romanovsky wrote: > > > > It is not me who didn't explain, it is you who didn't want to write clear > > comment that describes the headroom size without need of &quo

Re: [PATCH net 0/4] Fix W=1 compilation warnings in net/* folder

2021-02-02 Thread Leon Romanovsky
On Tue, Feb 02, 2021 at 03:59:38PM +0100, Eric Dumazet wrote: > On Tue, Feb 2, 2021 at 3:57 PM Leon Romanovsky wrote: > > > > On Tue, Feb 02, 2021 at 03:34:37PM +0100, Eric Dumazet wrote: > > > On Tue, Feb 2, 2021 at 2:55 PM Leon Romanovsky wrote: > > >

Re: [PATCH net 3/4] net/core: move ipv6 gro function declarations to net/ipv6

2021-02-02 Thread Leon Romanovsky
On Tue, Feb 02, 2021 at 03:57:07PM +0100, Eric Dumazet wrote: > On Tue, Feb 2, 2021 at 2:56 PM Leon Romanovsky wrote: > > > > From: Leon Romanovsky > > > > Fir the following compilation warnings: > > 1031 | INDIRECT_CALLABLE_SCOPE void udp_v6_early_demux(stru

Re: [PATCH net 1/4] ipv6: silence compilation warning for non-IPV6 builds

2021-02-02 Thread Leon Romanovsky
On Tue, Feb 02, 2021 at 08:29:09AM -0800, Jakub Kicinski wrote: > On Tue, 2 Feb 2021 15:55:41 +0200 Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > The W=1 compilation of allmodconfig generates the following warning: > > > > net/ipv6/icmp.c:448:6: w

[PATCH net-next v1 0/4] Fix W=1 compilation warnings in net/* folder

2021-02-03 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v1: * Removed Fixes lines. * Changed target from net to be net-next. * Patch 1: Moved function declaration to be outside config instead games with if/endif. * Patch 3: Moved declarations to new header file. v0: https://lore.kernel.org/lkml

[PATCH net-next v2 0/4] Fix W=1 compilation warnings in net/* folder

2021-02-03 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v2: * Patch 3: Added missing include file. v1: https://lore.kernel.org/lkml/20210203101612.4004322-1-l...@kernel.org * Removed Fixes lines. * Changed target from net to be net-next. * Patch 1: Moved function declaration to be outside config instead games

[PATCH net 2/4] ipv6: move udp declarations to net/udp.h

2021-02-02 Thread Leon Romanovsky
From: Leon Romanovsky Fix the following compilation warning: net/ipv6/udp.c:1031:30: warning: no previous prototype for 'udp_v6_early_demux' [-Wmissing-prototypes] 1031 | INDIRECT_CALLABLE_SCOPE void udp_v6_early_demux(struct sk

[PATCH net 1/4] ipv6: silence compilation warning for non-IPV6 builds

2021-02-02 Thread Leon Romanovsky
From: Leon Romanovsky The W=1 compilation of allmodconfig generates the following warning: net/ipv6/icmp.c:448:6: warning: no previous prototype for 'icmp6_send' [-Wmissing-prototypes] 448 | void icmp6_send(struct sk_buff *skb, u8 type, u8 code, __u32 info, | ^

[PATCH net 3/4] net/core: move ipv6 gro function declarations to net/ipv6

2021-02-02 Thread Leon Romanovsky
From: Leon Romanovsky Fir the following compilation warnings: 1031 | INDIRECT_CALLABLE_SCOPE void udp_v6_early_demux(struct sk_buff *skb) net/ipv6/ip6_offload.c:182:41: warning: no previous prototype for ‘ipv6_gro_receive’ [-Wmissing-prototypes] 182 | INDIRECT_CALLABLE_SCOPE struct sk_buff

[PATCH net 4/4] netfilter: move handlers to net/ip_vs.h

2021-02-02 Thread Leon Romanovsky
From: Leon Romanovsky Fix the following compilation warnings: net/netfilter/ipvs/ip_vs_proto_tcp.c:147:1: warning: no previous prototype for 'tcp_snat_handler' [-Wmissing-prototypes] 147 | tcp_snat_handler(struct sk_buff *skb, struct ip_vs_protocol *pp, | ^~~~ net

[PATCH net 0/4] Fix W=1 compilation warnings in net/* folder

2021-02-02 Thread Leon Romanovsky
From: Leon Romanovsky Hi, This short series fixes W=1 compilation warnings which I experienced when tried to compile net/* folder. Thanks Leon Romanovsky (4): ipv6: silence compilation warning for non-IPV6 builds ipv6: move udp declarations to net/udp.h net/core: move ipv6 gro function

Re: [PATCH net 0/4] Fix W=1 compilation warnings in net/* folder

2021-02-02 Thread Leon Romanovsky
On Tue, Feb 02, 2021 at 03:34:37PM +0100, Eric Dumazet wrote: > On Tue, Feb 2, 2021 at 2:55 PM Leon Romanovsky wrote: > > > > From: Leon Romanovsky > > > > Hi, > > > > This short series fixes W=1 compilation warnings which I experienced > > when trie

Re: [PATCH net-next] mlx5: Restore err assignment in mlx5_mdev_init

2020-05-31 Thread Leon Romanovsky
On Fri, May 29, 2020 at 10:54:48PM -0700, Nathan Chancellor wrote: > Clang warns: > > drivers/net/ethernet/mellanox/mlx5/core/main.c:1278:6: warning: variable > 'err' is used uninitialized whenever 'if' condition is true > [-Wsometimes-uninitialized] > if (!priv->dbg_root) { > ^

Re: [PATCH] RDMA/hns: Uninitialized variable in modify_qp_init_to_rtr()

2020-05-31 Thread Leon Romanovsky
> --- > drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky

[PATCH rdma-next v2 0/7] Enable asynchronous event FD per object

2020-05-19 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v2: * Added READ_ONCE to all default_async_file calls * Rebased on latest rdma/wip/jgg-for-next * Removed uninitalized_var?() * Simplified uverbs_free_srq() * Put uverbs_finalize_uobj_create() after object is finalized v1: https://lore.kernel.org/lkml

[PATCH rdma-next 0/3] Cleanups to flow creation paths

2020-07-30 Thread Leon Romanovsky
From: Leon Romanovsky Very straightforward cleanup. Thanks Leon Romanovsky (3): RDMA/mlx5: Simplify multiple else-if cases with switch keyword RDMA/mlx5: Replace open-coded offsetofend() macro RDMA: Remove constant domain argument from flow creation call drivers/infiniband/core

[PATCH rdma-rc 0/3] Simple fixes to DIM and mlx5

2020-07-30 Thread Leon Romanovsky
From: Leon Romanovsky Hi, First patch fixes an issue observed after auto-PID series was merged, but because the bug that not-initialized mutex existed before, the patch is sent to -rc. Other two patches are fixing unwind flows and appropriate for -rc. Thanks Leon Romanovsky (3): RDMA/mlx5

Re: [Linux-kernel-mentees] [PATCH net] rds: Prevent kernel-infoleak in rds_notify_queue_get()

2020-07-30 Thread Leon Romanovsky
On Thu, Jul 30, 2020 at 03:20:26PM -0400, Peilin Ye wrote: > rds_notify_queue_get() is potentially copying uninitialized kernel stack > memory to userspace since the compiler may leave a 4-byte hole at the end > of `cmsg`. > > In 2016 we tried to fix this issue by doing `= { 0 };` on `cmsg`, which

<    1   2   3   4   5   6   7   8   9   10   >