There is no need to call kfree while using devm_kzalloc,
remove it from *_device_init function.
Signed-off-by: Leon Romanovsky
---
drivers/mfd/tps65912-core.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/tps65912-core.c b/drivers/mfd/tps65912-core.c
index
Signed-off-by: Leon Romanovsky
---
drivers/mfd/sec-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
index 77ee26ef..5b740a3 100644
--- a/drivers/mfd/sec-core.c
+++ b/drivers/mfd/sec-core.c
@@ -121,7 +121,7 @@ static struct
In case mfd_add_devices will fail, it will call to mfd_remove_devices
by itself and return non-zero value.
Signed-off-by: Leon Romanovsky
---
drivers/mfd/sec-core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
index
On Fri, May 17, 2013 at 1:13 AM, Samuel Ortiz wrote:
> Hi Leon,
>
> On Wed, May 15, 2013 at 01:53:56PM +0300, Leon Romanovsky wrote:
>> Signed-off-by: Leon Romanovsky
>> ---
>> drivers/mfd/sec-core.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
&
Hi Samuel,
On Wed, May 15, 2013 at 12:19 PM, Leon Romanovsky wrote:
> There is no need to call kfree while using devm_kzalloc,
> remove it from *_device_init function.
>
> Signed-off-by: Leon Romanovsky
> ---
> drivers/mfd/tps65912-core.c | 5 ++---
> 1 file change
On Fri, May 17, 2013 at 8:58 PM, Joe Perches wrote:
> On Fri, 2013-05-17 at 20:50 +0300, Leon Romanovsky wrote:
>> On Fri, May 17, 2013 at 1:13 AM, Samuel Ortiz wrote:
>> > On Wed, May 15, 2013 at 01:53:56PM +0300, Leon Romanovsky wrote:
>> >> diff --git a/driver
On Tue, May 28, 2013 at 7:24 PM, Andy Shevchenko
wrote:
> On Tue, May 28, 2013 at 12:02 PM, Lee Jones wrote:
>> On Mon, 27 May 2013, Leon Romanovsky wrote:
>
>>> > > + init_data = devm_kzalloc(&tps65912->dev,
>
> There is an obvious typo: no need of &a
at
the beginning (for example - .o)
>
> Fubo.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the
On Wed, Dec 12, 2012 at 8:50 AM, Fubo Chen wrote:
> On Wed, Dec 12, 2012 at 5:12 PM, Leon Romanovsky wrote:
>> On Wed, Dec 12, 2012 at 7:05 AM, Fubo Chen wrote:
>>>
>>> On Wed, Dec 12, 2012 at 3:37 PM, Namjae Jeon wrote:
>>> > + /* dot and dotdot de
qp, which is the only field we access in the rollback_qp
> anyway.
>
> Fixes: 3050b9985024 ("IB/rxe: Fix race condition between requester and
> completer")
> Signed-off-by: Arnd Bergmann
Thanks Arnd,
It is much cleaner approach.
Reviewed-by: Leon Romanovsky
signature.asc
Description: PGP signature
On Tue, Sep 20, 2016 at 04:56:35PM +, Salil Mehta wrote:
>
>
> > -Original Message-
> > From: Leon Romanovsky [mailto:l...@kernel.org]
> > Sent: Thursday, September 15, 2016 11:13 AM
> > To: Salil Mehta
> > Cc: dledf...@redhat.com; Huwei (X
: https://lkml.org/lkml/2016/9/1/609
>
> All fixes have been done & tested by Oulijun and Huwei.
>
> V1->V2: * PATCH 3/20 and 13/20 have been dropped after rework
> of comments by Leon Romanovsky on V1 patch.
> * New patch "Fix for removal of redundan
On Mon, Jun 20, 2016 at 12:37:40PM +0800, Wei Hu (Xavier) wrote:
>
>
> On 2016/6/17 17:58, Leon Romanovsky wrote:
> >On Thu, Jun 16, 2016 at 10:35:16PM +0800, Lijun Ou wrote:
> >>This patch mainly added icm support for RoCE. It initializes icm
> >>which manage
On Mon, Jun 20, 2016 at 03:49:24PM +0800, Wei Hu (Xavier) wrote:
>
>
> On 2016/6/20 14:06, Leon Romanovsky wrote:
> >On Mon, Jun 20, 2016 at 12:37:40PM +0800, Wei Hu (Xavier) wrote:
> >>
> >>On 2016/6/17 17:58, Leon Romanovsky wrote:
> >>>On Thu, Jun
On Mon, Jun 20, 2016 at 05:48:15PM +0800, Wei Hu (Xavier) wrote:
>
>
> On 2016/6/20 17:27, Leon Romanovsky wrote:
> >On Mon, Jun 20, 2016 at 03:49:24PM +0800, Wei Hu (Xavier) wrote:
> >>
> >>On 2016/6/20 14:06, Leon Romanovsky wrote:
> >>>On Mon, Jun
On Thu, Jun 16, 2016 at 10:35:14PM +0800, Lijun Ou wrote:
> This patch added the operation for cmd, and added some functions
> for initializing eq table and selecting cmd mode.
>
> Signed-off-by: Wei Hu
> Signed-off-by: Nenglong Zhao
> Signed-off-by: Lijun Ou
> ---
> PATCH v9/v8/v7/v6:
> - No c
On Tue, Jun 21, 2016 at 06:50:51PM +0800, Wei Hu (Xavier) wrote:
>
>
> On 2016/6/20 21:33, Leon Romanovsky wrote:
> >On Thu, Jun 16, 2016 at 10:35:14PM +0800, Lijun Ou wrote:
> >>This patch added the operation for cmd, and added some functions
> >>for initializin
On Tue, Jun 21, 2016 at 12:37:39PM +0800, Wei Hu (Xavier) wrote:
>
>
> On 2016/6/20 21:04, Leon Romanovsky wrote:
> >On Mon, Jun 20, 2016 at 05:48:15PM +0800, Wei Hu (Xavier) wrote:
> >>
> >>On 2016/6/20 17:27, Leon Romanovsky wrote:
> >>>On Mon, Jun
On Tue, Jun 21, 2016 at 09:01:57PM +0800, Wei Hu (Xavier) wrote:
>
>
> On 2016/6/21 19:28, Leon Romanovsky wrote:
> >On Tue, Jun 21, 2016 at 06:50:51PM +0800, Wei Hu (Xavier) wrote:
> >>
> >>On 2016/6/20 21:33, Leon Romanovsky wrote:
> >>>On Thu, Jun
On Thu, Jul 28, 2016 at 01:49:49PM +0530, Bhaktipriya Shridhar wrote:
> A dedicated workqueue has been used since the work items are being used
> on a memory reclaim path. WQ_MEM_RECLAIM has been set to guarantee forward
> progress under memory pressure.
>
> The workqueue has a single work item. H
On Fri, Jul 29, 2016 at 08:22:37AM -0400, Tejun Heo wrote:
> Hello,
>
> On Thu, Jul 28, 2016 at 12:37:35PM +0300, Leon Romanovsky wrote:
> > Did you test this patch? Did you notice the memory reclaim path nature
> > of this work?
>
> The conversion uses WQ_MEM_RECLAIM
On Wed, Sep 07, 2016 at 08:37:23PM +0530, Parav Pandit wrote:
> Hi Leon,
>
> >> Signed-off-by: Parav Pandit
> >> +static struct rdmacg_resource_pool *
> >> +get_cg_rpool_locked(struct rdma_cgroup *cg, struct rdmacg_device *device)
> >> +{
> >> + struct rdmacg_resource_pool *rpool;
> >> +
> >>
On Fri, Sep 09, 2016 at 06:30:47PM +0800, Salil Mehta wrote:
> From: Lijun Ou
>
> The mtu should be validated when modify qp,so we check it.
>
> Signed-off-by: Lijun Ou
> Signed-off-by: Peter Chen
> Reviewed-by: Wei Hu (Xavier)
> Signed-off-by: Salil Mehta
> ---
> drivers/infiniband/hw/hns/h
On Fri, Sep 09, 2016 at 06:30:41PM +0800, Salil Mehta wrote:
> From: Lijun Ou
>
> This lock will be used in query port interface, and will be called
> while IB device was registered to OFED frame. So, the lock of iboe
> must be initiated before IB device was registered.
Sorry,
what did you mean b
On Fri, Sep 09, 2016 at 06:30:44PM +0800, Salil Mehta wrote:
> From: Lijun Ou
>
> Some pointers have not be checked when they are null,
> so we add check for them.
>
> Signed-off-by: Lijun Ou
> Signed-off-by: Dongdong Huang(Donald)
> Reviewed-by: Wei Hu (Xavier)
> Signed-off-by: Salil Mehta
On Wed, Sep 14, 2016 at 02:09:37AM +, Salil Mehta wrote:
>
>
> > -Original Message-
> > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-
> > ow...@vger.kernel.org] On Behalf Of Leon Romanovsky
> > Sent: Tuesday, September 13, 2016 7:50 AM
>
On Fri, Sep 09, 2016 at 06:30:43PM +0800, Salil Mehta wrote:
> From: Lijun Ou
>
> While post failed, hns roce should return the wr failed to user.
> We omitted this while qp type is wrong and fixed it.
>
> Signed-off-by: Lijun Ou
> Signed-off-by: Dongdong Huang(Donald)
> Reviewed-by: Wei Hu (Xa
On Fri, Sep 09, 2016 at 06:30:34PM +0800, Salil Mehta wrote:
> From: Lijun Ou
>
> The pointer ctrl may be null, so we add check for it.
>
> Signed-off-by: Lijun Ou
> Reviewed-by: Wei Hu
> Signed-off-by: Salil Mehta
> ---
> drivers/infiniband/hw/hns/hns_roce_hw_v1.c |6 ++
> 1 file chan
On Fri, Sep 09, 2016 at 06:30:49PM +0800, Salil Mehta wrote:
> From: Lijun Ou
>
> The rq head in qpc was zero will miss the rq wqes which
> have be sent, so here we should take the real value.
>
> Signed-off-by: Lijun Ou
> Reviewed-by: Wei Hu (Xavier)
> Signed-off-by: Salil Mehta
> ---
> driv
On Fri, Sep 09, 2016 at 06:30:51PM +0800, Salil Mehta wrote:
> From: Lijun Ou
>
> It doesn't need to assign for the filed of qp state in qpc separately
> when qp happen to migrate state which supported in RoCE engine v1.
>
> Signed-off-by: Lijun Ou
> Reviewed-by: Wei Hu (Xavier)
> Signed-off-by
t :(.
Sorry
>
> 4.8 dates are close by (2 weeks) and there are two git trees involved
> (that might cause merge error to Linus) so if there are no issues, I
> would like to make request to Doug to consider it for 4.8 early on.
>
> Parav
>
> On Mon, Sep 12, 2016 at 10:37 AM, L
On Wed, Aug 31, 2016 at 02:07:25PM +0530, Parav Pandit wrote:
> Added rdma cgroup controller that does accounting, limit enforcement
> on rdma/IB verbs and hw resources.
>
> Added rdma cgroup header file which defines its APIs to perform
> charing/uncharing functionality. It also defined APIs for R
r.
>
> Signed-off-by: Chris Wilson
I assume that it passed 0-day builds.
Except the commit message, which doesn't follow SubmittingPatches guide,
it looks good.
Reviewed-by: Leon Romanovsky
Thanks
signature.asc
Description: PGP signature
On Wed, Aug 24, 2016 at 04:44:50AM +0800, Salil Mehta wrote:
> This patch is meant to add support of ACPI to the Hisilicon RoCE
> driver.
>
> Changes done are primarily meant to detect the type and then either
> use DT specific or ACPI spcific functions. Where ever possible,
> this patch tries to m
On Wed, Aug 24, 2016 at 02:25:12PM +, Salil Mehta wrote:
>
> It looks like we should retain the int as a return type or if you have
> some other opinion or if I have missed something here please share :)
Thanks for the explanation.
>
> Best regards
> Salil
signature.asc
Description: PGP sig
t/mellanox/mlx4/fw_qos.c | 6 +++---
> drivers/net/ethernet/mellanox/mlx4/fw_qos.h | 10 +-
> 3 files changed, 16 insertions(+), 16 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky
signature.asc
Description: PGP signature
On Wed, Aug 16, 2017 at 10:29:40AM +0100, Colin King wrote:
> From: Colin Ian King
>
> The function mlx5_ib_get_vector_affinity is local to the source
> and does not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'mlx5_ib_get_vector_affinity' was not declared
On Wed, Aug 16, 2017 at 02:42:50PM +0100, Colin King wrote:
> From: Colin Ian King
>
> Trivial fix to spelling mistakes in the mlx4 driver.
>
> Signed-off-by: Colin Ian King
> ---
> drivers/net/ethernet/mellanox/mlx4/cmd.c| 16
> drivers/net/ethernet/mellanox/mlx4/fw_qos.c |
On Wed, Aug 16, 2017 at 03:02:31PM +0100, Colin Ian King wrote:
> On 16/08/17 14:58, Leon Romanovsky wrote:
> > On Wed, Aug 16, 2017 at 02:42:50PM +0100, Colin King wrote:
> >> From: Colin Ian King
> >>
> >> Trivial fix to spelling mistakes in the mlx4 driver
ned-off-by: Bhumika Goyal
> ---
> * Changes in v2- Combine all the followup patches and the constification
> patches into a series.
>
> drivers/infiniband/core/cma_configfs.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky
signature.asc
Description: PGP signature
; 1 file changed, 10 insertions(+), 11 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky
signature.asc
Description: PGP signature
On Wed, Oct 18, 2017 at 05:12:02PM +0800, Wei Hu (Xavier) wrote:
>
>
> On 2017/10/18 16:42, Wei Hu (Xavier) wrote:
> >
> >
> > On 2017/10/1 0:10, Leon Romanovsky wrote:
> > > On Sat, Sep 30, 2017 at 05:28:59PM +0800, Wei Hu (Xavier) wrote:
> > > > If
On Fri, Oct 27, 2017 at 02:30:11PM +0200, Thomas Bogendoerfer wrote:
> If there is no SFP module plugged into a port of mlx5 cards
> 'cat /sys/class/infniband/mlx5_X/ports/1/rate' returns Invalid argument.
> This causes tools like 'ibstat' to malfunction. This change adjusts mlx5
> to all other RoC
On Fri, Oct 27, 2017 at 09:34:18AM +0200, SF Markus Elfring wrote:
> >> Add a jump target so that a bit of exception handling can be better reused
> >> at the end of this function.
> >
> > I'm not sure this is that big of a win.
>
> Such a view is appropriate because I proposed just another small a
On Thu, Oct 26, 2017 at 06:12:31PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Thu, 26 Oct 2017 17:54:15 +0200
>
> Add a jump target so that a bit of exception handling can be better reused
> at the end of this function.
>
> This issue was detected by using the Coccinelle softwa
On Thu, Oct 26, 2017 at 08:33:39PM -0400, Dennis Dalessandro wrote:
> On 10/26/2017 12:12 PM, SF Markus Elfring wrote:
> > From: Markus Elfring
> > Date: Thu, 26 Oct 2017 17:54:15 +0200
> >
> > Add a jump target so that a bit of exception handling can be better reused
> > at the end of this functi
On Sun, Oct 29, 2017 at 10:20:18AM +0300, Moni Shoua wrote:
> On Fri, Oct 27, 2017 at 6:59 PM, Thomas Bogendoerfer
> wrote:
> > Following crash happens, if crc algorithm couldn't be allocated:
> >
> > [ 1087.989072] rdma_rxe: loaded
> > [ 1097.855397] PCLMULQDQ-NI instructions are not detected.
>
On Mon, Oct 30, 2017 at 09:04:36AM +0100, SF Markus Elfring wrote:
> >>> I mean you aren't really making the code any smaller
> >>
> >> Would anybody like to check corresponding effects in more detail
> >> after a specific function call was replaced by a goto statement?
> >
> > You are supposed to
loc_shash("crc32", 0, 0);
> - if (IS_ERR(rxe->tfm)) {
> + tfm = crypto_alloc_shash("crc32", 0, 0);
> + if (IS_ERR(tfm)) {
> pr_err("failed to allocate crc algorithm err:%ld\n",
> -PTR_ERR(rxe->tfm));
> - return PTR_ERR(rxe->tfm);
> +PTR_ERR(tfm));
> + return PTR_ERR(tfm);
> }
> + rxe->tfm = tfm;
Thanks,
Reviewed-by: Leon Romanovsky
signature.asc
Description: PGP signature
On Wed, Oct 14, 2015 at 11:17 AM, Heloise NH wrote:
> Signed-off-by: Heloise NH
The patch is a correct one, however can you update the subject and
description to be more informative?
Please add that new_inode() function can fail for allocation only.
> ---
> drivers/infiniband/hw/ipath/ipath_fs.
On Wed, Oct 14, 2015 at 5:17 PM, Marciniszyn, Mike
wrote:
>> > Subject: [PATCH] fix return value error
>> >
>>
>> I checked returns in configfs (-ENOMEM), proc (-ENOENT), proc-sys (-
>> ENOMEM), ramfs (-ENOSPC), vfs (-ENOMEM).
>>
>> Not entirely consistent but this matches the majority.
>>
>> I ag
On Sun, Oct 25, 2015 at 12:17 PM, Muhammad Falak R Wani
wrote:
Please follow standard naming convention for the patches.
It should be [PATCH v2 1/4] and not [PATCH 1/4 v2].
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.
On Tue, Oct 27, 2015 at 11:19 AM, Dan Carpenter
wrote:
> On Sun, Oct 25, 2015 at 01:21:11PM +0200, Leon Romanovsky wrote:
>> On Sun, Oct 25, 2015 at 12:17 PM, Muhammad Falak R Wani
>> wrote:
>> Please follow standard naming convention for the patches.
>> It shoul
gion->vm_start < last->vm_top);
>
> lastp = p;
> }
> --
> 2.5.0
>
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majord...@kvack.org. For more info on Linux MM,
> see: http://www.linux-
On Sun, Oct 04, 2015 at 07:04:06PM -0700, Davidlohr Bueso wrote:
> On Sun, 04 Oct 2015, Leon Romanovsky wrote:
>
> >On Sun, Oct 4, 2015 at 9:18 AM, Geliang Tang wrote:
> >>BUG_ON() already contain an unlikely compiler flag. Drop it.
> >It is not the case if CONFIG_B
From: Leon Romanovsky
Signed-off-by: Leon Romanovsky
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index c79f306a936a..6be664ed0527 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5444,6 +5444,7 @@ F:drivers/iommu/exynos-iommu.c
EZchip
On Sat, Jul 14, 2018 at 06:57:01PM +0300, Or Gerlitz wrote:
> On Sat, Jul 14, 2018 at 2:50 AM, Qing Huang wrote:
> > When a CX5 device is configured in dual-port RoCE mode, after creating
> > many VFs against port 1, creating the same number of VFs against port 2
> > will flood kernel/syslog with
On Tue, Jul 10, 2018 at 04:14:10PM +0200, Michal Hocko wrote:
> On Tue 10-07-18 16:40:40, Leon Romanovsky wrote:
> > On Mon, Jul 09, 2018 at 02:29:08PM +0200, Michal Hocko wrote:
> > > On Wed 27-06-18 09:44:21, Michal Hocko wrote:
> > > > This is the v2 of RFC based
On Thu, Jan 25, 2018 at 06:22:59PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the rdma tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> ERROR: "init_rcu_head" [drivers/infiniband/ulp/srpt/ib_srpt.ko] undefined!
>
> Caused by commit
>
> a11253142e6d ("IB
/ipoib/ipoib_ethtool.c
> > b/drivers/infiniband/ulp/ipoib/ipoib_ethtool.c
> > index 874b243..7871379 100644
> > --- a/drivers/infiniband/ulp/ipoib/ipoib_ethtool.c
> > +++ b/drivers/infiniband/ulp/ipoib/ipoib_ethtool.c
> > @@ -178,7 +178,7 @@ static inline int ib_speed_enum_to_int(int speed)
> > static int ipoib_get_link_ksettings(struct net_device *netdev,
> > struct ethtool_link_ksettings *cmd)
> > {
> > - struct ipoib_dev_priv *priv = netdev_priv(netdev);
> > + struct ipoib_dev_priv *priv = ipoib_priv(netdev);
> > struct ib_port_attr attr;
> > int ret, speed, width;
> >
>
> Suggesting to remove kernel oops from commit log message, fix is trivial.
Please don't, they are useful.
>
> Reviewed-by: Yuval Shaia
>
Thanks,
Reviewed-by: Leon Romanovsky
signature.asc
Description: PGP signature
On Sun, May 14, 2017 at 06:41:13PM +0200, Peter Rosin wrote:
> As is, a failure message is printed unconditionally, which is confusing.
> And noisy.
>
> Fixes: 8d4d159f25a7 ("i2c: mux: provide more info on failure in
> i2c_mux_add_adapter")
> Signed-off-by: Peter Rosin
> ---
> drivers/i2c/i2c-mu
nd 64 equals destination size [-Wstringop-truncation]
>
> We need to use strlcpy() to make sure the string is nul-terminated.
>
> Signed-off-by: Xiongfeng Wang
> ---
> drivers/infiniband/core/cma_configfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thank
On Mon, Jan 22, 2018 at 03:24:15AM -0800, Kees Cook wrote:
> As described in: https://bugzilla.redhat.com/show_bug.cgi?id=822754
>
> Attempting an RDS connection from the IP address of an IPoIB interface
> to itself causes a kernel panic due to a BUG_ON() being triggered.
> Making the test less str
and/hw/mthca/mthca_user.h | 112
> ---
> 1 file changed, 112 deletions(-)
> delete mode 100644 drivers/infiniband/hw/mthca/mthca_user.h
>
Thanks,
Reviewed-by: Leon Romanovsky
signature.asc
Description: PGP signature
t; drivers/infiniband/hw/mlx5/main.c:359:24: warning: Value stored
> to 'mdev' during its initialization is never read
>
> Signed-off-by: Colin Ian King
> ---
> drivers/infiniband/hw/mlx5/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks,
Acke
On Mon, Jan 15, 2018 at 11:53:21AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> Today's linux-next merge of the rdma tree got a conflict in:
>
> drivers/infiniband/hw/mlx5/main.c
>
> between commits:
>
> 8978cc921fc7 ("{net,ib}/mlx5: Don't disable local loopback multicast
> traffic when needed
On Tue, Mar 06, 2018 at 10:59:02PM -0800, syzbot wrote:
> Hello,
>
> syzbot hit the following crash on upstream commit
> ce380619fab99036f5e745c7a865b21c59f005f6 (Tue Mar 6 04:31:14 2018 +)
> Merge tag 'please-pull-ia64_misc' of
> git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux
>
> So
On Wed, Mar 07, 2018 at 09:44:23AM +0100, Dmitry Vyukov wrote:
> On Wed, Mar 7, 2018 at 8:23 AM, Leon Romanovsky wrote:
> > On Tue, Mar 06, 2018 at 10:59:02PM -0800, syzbot wrote:
> >> Hello,
> >>
> >> syzbot hit the following crash on upstream commit
> >
On Thu, Mar 22, 2018 at 02:10:21PM +0100, Dmitry Vyukov wrote:
> This bug is actively happening several times per day, if such bug is
> closed syzbot will open another bug on the next crash.
> This bug has a reproducer, why do you think it is invalid?
I tried to reproduce it on latest rdma-next an
On Thu, Mar 22, 2018 at 02:36:55PM +0100, Dmitry Vyukov wrote:
> On Thu, Mar 22, 2018 at 2:20 PM, Leon Romanovsky wrote:
> > On Thu, Mar 22, 2018 at 02:10:21PM +0100, Dmitry Vyukov wrote:
> >> This bug is actively happening several times per day, if such bug is
> >&
On Thu, Mar 22, 2018 at 03:47:41PM +0100, Dmitry Vyukov wrote:
> On Thu, Mar 22, 2018 at 3:29 PM, Leon Romanovsky wrote:
> > On Thu, Mar 22, 2018 at 02:36:55PM +0100, Dmitry Vyukov wrote:
> >> On Thu, Mar 22, 2018 at 2:20 PM, Leon Romanovsky
> >> wrote:
> >>
On Thu, Mar 22, 2018 at 05:13:58PM +0200, Leon Romanovsky wrote:
> On Thu, Mar 22, 2018 at 03:47:41PM +0100, Dmitry Vyukov wrote:
> > On Thu, Mar 22, 2018 at 3:29 PM, Leon Romanovsky
> > wrote:
> > > On Thu, Mar 22, 2018 at 02:36:55PM +0100, Dmitry Vyukov wrote:
> >
On Thu, Mar 08, 2018 at 04:40:58PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> aa0de36a40f4 ("RDMA/mlx5: Fix integer overflow while resizing CQ")
>
> is missing a Signed-off-by from its author.
Doug, something went wrong with your scripts
In patchworks it is with SOB and lengthy com
On Thu, Mar 08, 2018 at 08:28:45AM -0500, Doug Ledford wrote:
> On Thu, 2018-03-08 at 08:09 +0200, Leon Romanovsky wrote:
> > On Thu, Mar 08, 2018 at 04:40:58PM +1100, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > Commit
> > >
> > >
On Wed, Sep 26, 2018 at 06:43:42PM +0300, Jan Dakinevich wrote:
> On Wed, 19 Sep 2018 00:23:51 +0300
> Leon Romanovsky wrote:
>
> > On Tue, Sep 18, 2018 at 08:46:23AM -0600, Jason Gunthorpe wrote:
> > > On Tue, Sep 18, 2018 at 04:03:42PM +0300, Jan Dakinevich wr
On Wed, Nov 21, 2018 at 11:04:32AM +1100, Stephen Rothwell wrote:
> Hi Leon,
>
> Today's linux-next merge of the mlx5-next tree got a conflict in:
>
> drivers/infiniband/hw/mlx5/main.c
>
> between commit:
>
> 9afc97c29b03 ("mlx5: remove support for ib_get_vector_affinity")
>
> from the rdma tre
On Mon, Nov 19, 2018 at 05:19:10PM +0800, Kenneth Lee wrote:
> On Mon, Nov 19, 2018 at 05:14:05PM +0800, Kenneth Lee wrote:
> > Date: Mon, 19 Nov 2018 17:14:05 +0800
> > From: Kenneth Lee
> > To: Leon Romanovsky
> > CC: Tim Sell , linux-...@vger.kernel.org,
> &g
On Wed, Dec 05, 2018 at 01:10:50PM +1100, Stephen Rothwell wrote:
> Hi Doug,
>
> On Tue, 04 Dec 2018 20:33:08 -0500 Doug Ledford wrote:
> >
> > FWIW this will go away in a day or two. I merged mlx5-next into rdma
> > for-next in order to take a series that depended on it.
>
> Understood, thanks.
On Tue, Dec 04, 2018 at 01:52:54AM +, Jason Gunthorpe wrote:
> On Tue, Dec 04, 2018 at 11:47:31AM +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the rdma tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > ERROR: "mlx5_get_send_wqe" [drivers/infi
On Thu, Jun 28, 2018 at 11:17:43AM +0200, Jan Kara wrote:
> On Wed 27-06-18 19:42:01, John Hubbard wrote:
> > On 06/27/2018 10:02 AM, Jan Kara wrote:
> > > On Wed 27-06-18 08:57:18, Jason Gunthorpe wrote:
> > >> On Wed, Jun 27, 2018 at 02:42:55PM +0200, Jan Kara wrote:
> > >>> On Wed 27-06-18 13:59
On Sun, Jul 01, 2018 at 11:10:04PM -0700, John Hubbard wrote:
> On 07/01/2018 10:52 PM, Leon Romanovsky wrote:
> > On Thu, Jun 28, 2018 at 11:17:43AM +0200, Jan Kara wrote:
> >> On Wed 27-06-18 19:42:01, John Hubbard wrote:
> >>> On 06/27/2018 10:02 AM, Jan Kara wrote
On Mon, Jul 02, 2018 at 02:02:34PM -0700, Tarick Bedeir wrote:
> rdma_ah_find_type() can reach into ib_device->port_immutable with a
> potentially out-of-bounds port number, so check that the port number is
> valid first.
>
> Fixes: 44c58487d51a ("IB/core: Define 'ib' and 'roce' rdma_ah_attr types"
t; drivers/infiniband/hw/mlx5/cong.c | 9 +
> drivers/infiniband/hw/mlx5/mr.c | 32 ---
> 2 files changed, 9 insertions(+), 32 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky
signature.asc
Description: PGP signature
On Tue, Jul 10, 2018 at 11:17:40AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> Today's linux-next merge of the rdma tree got a conflict in:
>
> drivers/infiniband/core/uverbs_cmd.c
>
> between commit:
>
> 4fae7f170416 ("RDMA/uverbs: Fix slab-out-of-bounds in
> ib_uverbs_ex_create_flow")
>
> f
On Mon, Jul 09, 2018 at 04:51:08PM +0300, Jan Dakinevich wrote:
> An array of pointers to SRPT contexts in ib_device is over 30KiB even
> in default case, in which an amount of contexts is 4095. The patch
> is intended to weed out large contigous allocation for non-DMA memory.
kvmalloc* doesn't "w
On Tue, Jul 10, 2018 at 03:08:38PM +, Bart Van Assche wrote:
> On Tue, 2018-07-10 at 08:39 +0300, Leon Romanovsky wrote:
> > On Mon, Jul 09, 2018 at 04:51:08PM +0300, Jan Dakinevich wrote:
> > > An array of pointers to SRPT contexts in ib_device is over 30KiB even
> &g
On Tue, Jul 10, 2018 at 04:14:10PM +0200, Michal Hocko wrote:
> On Tue 10-07-18 16:40:40, Leon Romanovsky wrote:
> > On Mon, Jul 09, 2018 at 02:29:08PM +0200, Michal Hocko wrote:
> > > On Wed 27-06-18 09:44:21, Michal Hocko wrote:
> > > > This is the v2 of RFC based
On Wed, Jun 27, 2018 at 10:07:26AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> Today's linux-next merge of the rdma tree got a conflict in:
>
> drivers/infiniband/core/uverbs_cmd.c
>
> between commit:
>
> 940efcc8889f ("RDMA/uverbs: Protect from attempts to create flows on
> unsupported QP")
On Fri, May 25, 2018 at 11:29:59PM +0200, Arnd Bergmann wrote:
> Several subsystems depend on INFINIBAND_ADDR_TRANS, which in turn depends
> on INFINIBAND. However, when with CONFIG_INIFIBAND=m, this leads to a
> link error when another driver using it is built-in. The
> INFINIBAND_ADDR_TRANS depen
t; + */
> + if (owning_process)
> + put_task_struct(owning_process);
> + return;
> + }
> + }
> + }
> +
> + /* need to protect from a race on closing the vma as part of
O, general cleanup exit point is needed in this function (goto ...),
but your fix is good enough too. Thanks for doing it.
Reviewed-by: Leon Romanovsky
signature.asc
Description: PGP signature
On Mon, Jun 18, 2018 at 10:11:13AM +0200, Christoph Hellwig wrote:
> On Sun, Jun 17, 2018 at 01:10:04PM -0700, Dan Williams wrote:
> > I believe kernel behavior regression is a primary concern as now
> > fallocate() and truncate() can randomly fail where they didn't before.
>
> Fail or block foreve
On Tue, Jul 03, 2018 at 07:44:25AM -0700, Tarick Bedeir wrote:
> On Mon, Jul 2, 2018 at 11:21 PM Leon Romanovsky wrote:
> >
> > On Mon, Jul 02, 2018 at 02:02:34PM -0700, Tarick Bedeir wrote:
> > > rdma_ah_find_type() can reach into ib_device->port_immutable with a
>
On Tue, Jun 12, 2018 at 05:07:39PM -0700, Matthew Wilcox wrote:
> On Tue, Jun 12, 2018 at 02:33:22PM -0600, Jason Gunthorpe wrote:
> > > @@ -377,13 +378,24 @@ struct ib_mad_agent *ib_register_mad_agent(struct
> > > ib_device *device,
> > > goto error4;
> > > }
> > >
> > > - spin_lock_i
On Wed, Jun 13, 2018 at 04:49:47PM -0700, Cong Wang wrote:
> In ucma_event_handler() we lock the mutex like this:
>
> mutex_lock(&ctx->file->mut);
> ...
> mutex_unlock(&ctx->file->mut);
>
> which seems correct, but we could translate it into this:
>
> f = ctx->file;
> mutex_lock(&f->mut);
> ...
> f
On Wed, Jun 13, 2018 at 11:21:54PM -0700, Cong Wang wrote:
> On Wed, Jun 13, 2018 at 10:34 PM, Leon Romanovsky wrote:
> >
> > Hi Cong,
> >
> > If the compiler optimizes the first line (mutex_lock) as you wrote,
> > it will reuse "f" for the second l
On Mon, Dec 10, 2018 at 03:27:59PM +0800, YueHaibing wrote:
> Remove duplicated include.
>
> Signed-off-by: YueHaibing
> ---
> drivers/infiniband/hw/mlx5/mlx5_ib.h | 1 -
> 1 file changed, 1 deletion(-)
>
Thanks,
Acked-by: Leon Romanovsky
signature.asc
Description: PGP signature
On Sat, Dec 22, 2018 at 02:13:35AM -0600, Gustavo A. R. Silva wrote:
> Currently, if uverbs_attr_ptr_get_array_size() fails, the returned error
> turns into a huge value, once it is being store into a variable of type
> size_t (unsigned long), hence never actually reporting such error and
> causing
cci
>
> Fixes: 4c8fb2986d44 ("net/mlx5e: Increase VF representors' SQ size to 128")
> CC: Gavi Teitz
> Signed-off-by: kbuild test robot
> ---
Dave,
Can you please apply this small fix?
Thanks,
Reviewed-by: Leon Romanovsky
signature.asc
Description: PGP signature
oblem is as follows:
> (http://coccinelle.lip6.fr/)
>
> //
> @@
> identifier x;
> @@
> - LIST_HEAD(x);
> ... when != x
> //
>
> Fixes: 244cd96adb5f ("net_sched: remove list_head from tc_action")
> Signed-off-by: Julia Lawall
>
Thanks,
Reviewed-by: Leon Romanovsky
signature.asc
Description: PGP signature
1 - 100 of 1087 matches
Mail list logo
