Re: [PATCH 2.6.10-rc3][PPC32] Fix Motorola PReP (PowerstackII Utah) PCI IRQ map

2005-02-22 Thread Leigh Brown
Sebastian Heutling said: > Meelis Roos wrote: > >>> The PCI IRQ map for the old Motorola PowerStackII (Utah) boards was >>> incorrect, but this breakage wasn't exposed until 2.5, and finally >>> fixed >>> until recently by Sebastian Heutling <[EMAIL PROTECTED]>. >> >> >> Yesterday I finally got aro

Re: Spurious timeouts in mvmdio

2013-12-03 Thread Leigh Brown
Hi Russell and Nicolas, Apologies for taking so long to respond to this thread. On 2013-12-03 12:40, Russell King - ARM Linux wrote: On Tue, Dec 03, 2013 at 07:23:46AM -0500, Jason Cooper wrote: On Mon, Dec 02, 2013 at 04:15:54PM +0100, Nicolas Schichan wrote: [...] 11:31 < shesselba> kos_to

Re: Spurious timeouts in mvmdio

2013-12-03 Thread Leigh Brown
On 2013-12-03 22:45, Sebastian Hesselbarth wrote: On 12/03/2013 09:57 PM, Leigh Brown wrote: [...] Nicolas' patch should fix the issue, but I prefer the following as it is more correct, as it only adjusts the timeout when calling wait_event_timeout(). As I said above,I believe the po

Re: Spurious timeouts in mvmdio

2013-12-03 Thread Leigh Brown
On 2013-12-03 23:17, Sebastian Hesselbarth wrote: On 12/04/2013 12:20 AM, Leigh Brown wrote: On 2013-12-03 22:45, Sebastian Hesselbarth wrote: On 12/03/2013 09:57 PM, Leigh Brown wrote: [...] Nicolas' patch should fix the issue, but I prefer the following as it is more correct, as it

Re: Spurious timeouts in mvmdio

2013-12-16 Thread Leigh Brown
On 2013-12-16 18:07, Nicolas Schichan wrote: On 12/04/2013 12:42 AM, Russell King - ARM Linux wrote: Alternatively, code it like this instead. drivers/net/ethernet/marvell/mvmdio.c | 32 +++- 1 files changed, 15 insertions(+), 17 deletions(-) diff --git a/dri

[PATCH] net: mvmdio: fix interrupt timeout handling

2013-12-19 Thread Leigh Brown
ix ensures a minimum timeout of 2 jiffies, ensuring wait_event_timeout will always wait at least 1 jiffie. Issue reported by Nicolas Schichan. Tested-by: Nicolas Schichan Signed-off-by: Leigh Brown --- drivers/net/ethernet/marvell/mvmdio.c | 6 ++ 1 file changed, 6 insertions(+) diff

Re: [PATCH] net: mvmdio: fix interrupt timeout handling

2013-12-19 Thread Leigh Brown
On 2013-12-19 11:33, Sebastian Hesselbarth wrote: +if (timeout < 2) + timeout = 2; Hi Leigh, above two lines have a whitespace issue. Crap, you are correct. I will fix it and send another patch. Regards, Leigh. -- To unsubscribe from

[PATCH v2] net: mvmdio: fix interrupt timeout handling

2013-12-19 Thread Leigh Brown
o 1 jiffies, causing premature timeouts. This fix ensures a minimum timeout of 2 jiffies, ensuring wait_event_timeout will always wait at least 1 jiffie. Issue reported by Nicolas Schichan. Tested-by: Nicolas Schichan Signed-off-by: Leigh Brown --- drivers/net/ethernet/marvell/mvmdio.c | 6 +

Re: [PATCH v2] net: mvmdio: fix interrupt timeout handling

2013-12-19 Thread Leigh Brown
On 2013-12-19 17:43, Jason Gunthorpe wrote: On Thu, Dec 19, 2013 at 01:09:48PM +, Leigh Brown wrote: This version corrects the whitespace issue. orion_mdio_wait_ready uses wait_event_timeout to wait for the SMI interrupt to fire. wait_event_timeout waits for between "timeout - 1

Re: [PATCH V2 0/4] clk: mvebu: Improve clock drift

2014-09-03 Thread Leigh Brown
tches should go through the clk subsystem, whereas the third one should go to the arm-soc through the mvebu tree. The last one is just to fix a typo I found while I was reading the clk code. This is working superbly for me on my Mirabox, and ntpd is now completely stable. Tested-by: Leigh Brown

Re: [PATCH 1/4] clk: mvebu: Fix clk frequency value if SSCG is enabled

2014-08-31 Thread Leigh Brown
Hi Gregory, On 2014-08-29 12:43, Gregory CLEMENT wrote: When the SSCG (Spread Spectrum Clock Generator) is enabled, it shifts the frequency of the clock. The percentage is no more than 1% but when the clock is used for a timer it leads to a clock drift. Thank you so much for this series. I'm

Re: [PATCH 1/4] clk: mvebu: Fix clk frequency value if SSCG is enabled

2014-08-31 Thread Leigh Brown
On 2014-08-31 23:25, Leigh Brown wrote: [...] /* NB: 0.96% = 0.0048 or 3/625 */ freq_swing_half = (((u64)high_bound - (u64)low_bound) * (u64)system_clk * 3); do_div(freq_swing_half, (625 * high_bound)); Sigh. The comment should be: /* NB: half of 0.96% is 0.0048 or 3/625