I am thinking Srini meant in the sd_mod driver module.
#define SD_FLUSH_TIMEOUT (60 * HZ)
Laurence
On Fri, Sep 20, 2013 at 4:32 PM, Greg KH wrote:
> On Fri, Sep 20, 2013 at 12:32:27PM -0700, K. Y. Srinivasan wrote:
>> The SD_FLUSH_TIMEOUT value is currently hardcoded.
>
> Hardcoded where? Plea
se addresses in any of the task pointers, so how do I get
the task descriptors on the wait queues from these in the crash dump.
Thanks for the help.
Laurence Oberman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Mo
Hello,
I figured out the answer to my previous question.
I used the equivalent of the list_entry MACRO to get the values
>From the crash dump.
Thanks
Laurence
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo
t; {
> return ((struct scsi_cmnd *)ncmd_ptr) - 1;
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Patch makes sense, look good to me.
Reviwed-by: Laurence Oberman
const char *buf, size_t count)
{
struct scsi_disk *sdkp = to_scsi_disk(dev);
unsigned int val;
int err;
if (!capable(CAP_SYS_ADMIN))
return -EACCES;
err = kstrtouint(buf, 10, &val); *****
if (err)
#include
> #endif
> --
> 2.9.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
I compiled and tested this with no issues on my mlx5 test bed.
Reviewed-by Laurence Oberman
Tested-by Laurence Oberman
On Fri, 2018-01-12 at 20:57 +, Bart Van Assche wrote:
> On Tue, 2018-01-09 at 08:29 -0800, Tejun Heo wrote:
> > Currently, blk-mq timeout path synchronizes against the usual
> > issue/completion path using a complex scheme involving atomic
> > bitflags, REQ_ATOM_*, memory barriers and subtle me
On Thu, 2018-01-18 at 16:23 -0500, Mike Snitzer wrote:
> On Thu, Jan 18 2018 at 3:58P -0500,
> Bart Van Assche wrote:
>
> > On Thu, 2018-01-18 at 15:48 -0500, Mike Snitzer wrote:
> > > For Bart's test the underlying scsi-mq driver is what is
> > > regularly
> > > hitting this case in __blk_mq_tr
On Thu, 2018-01-18 at 17:01 -0500, Mike Snitzer wrote:
> On Thu, Jan 18 2018 at 4:39pm -0500,
> Bart Van Assche wrote:
>
> > On Thu, 2018-01-18 at 16:23 -0500, Mike Snitzer wrote:
> > > On Thu, Jan 18 2018 at 3:58P -0500,
> > > Bart Van Assche wrote:
> > >
> > > > On Thu, 2018-01-18 at 15:48
On Thu, 2018-01-18 at 22:24 +, Bart Van Assche wrote:
> On Thu, 2018-01-18 at 17:18 -0500, Laurence Oberman wrote:
> > OK, I ran 5 at once of 5 separate mount points.
> > I am using 4k block sizes
> > Its solid consistent for me. No stalls no gaps.
>
> Hi Laurence,
t, and
> > what we need to do is to return the queue busy info to caller, so
> > that caller can deal with it well.
> >
> > Fixes: 396eaf21ee ("blk-mq: improve DM's blk-mq IO merging via
> > blk_insert_cloned_request feedback")
> > Rep
On Mon, 2018-01-15 at 20:17 +0800, Ming Lei wrote:
> On Sun, Jan 14, 2018 at 06:40:40PM -0500, Laurence Oberman wrote:
> > On Thu, 2018-01-04 at 14:32 -0800, Vinson Lee wrote:
> > > Hi.
> > >
> > > HP ProLiant DL360p Gen8 with Smart Array P420i boots to the log
On Mon, 2018-01-15 at 07:01 -0800, Hellwig, Christoph wrote:
> Laurence, I'm a little confused. Is this the same issue we just
> fixed,
> or is this an issue showing up with the fix?
>
> E.g. what kernel versions or trees are affected?
Hello Christoph
This showed up on a combined tree of Mikes
On Mon, 2018-01-15 at 18:43 +0100, Thomas Gleixner wrote:
> On Tue, 16 Jan 2018, Ming Lei wrote:
> > These two patches fixes IO hang issue reported by Laurence.
> >
> > 84676c1f21 ("genirq/affinity: assign vectors to all possible CPUs")
> > may cause one irq vector assigned to all offline CPUs, th
On Tue, 2018-01-16 at 12:25 +0100, Thomas Gleixner wrote:
> On Tue, 16 Jan 2018, Ming Lei wrote:
>
> > On Mon, Jan 15, 2018 at 09:40:36AM -0800, Christoph Hellwig wrote:
> > > On Tue, Jan 16, 2018 at 12:03:43AM +0800, Ming Lei wrote:
> > > > Hi,
> > > >
> > > > These two patches fixes IO hang iss
On Tue, 2018-01-16 at 15:22 +, Don Brace wrote:
> > -Original Message-
> > From: Laurence Oberman [mailto:lober...@redhat.com]
> > Sent: Tuesday, January 16, 2018 7:29 AM
> > To: Thomas Gleixner ; Ming Lei > .com>
> > Cc: Christoph Hel
tstanding);
> }
This looks like it would work for the x86_64 and arm because of how its
defined architecture specific for the x86_64 and the arm64
I guess its up to Don and the driver folks and if its worth the change.
I am generally not a fan of messing with these barrier things though.
Reviewed-by: Laurence Oberman
to extend the hard lockup timer in the console code.
Note that this also affects the soft lockup detector
Signed-off-by: Laurence Oberman
---
Documentation/admin-guide/kernel-parameters.txt | 8
kernel/watchdog.c | 7 +++
2 files changed, 15 insertions
command line. The detector can only be
completely disabled.
Add a new watchdog_thresh= command line parameter to allow boot time
control over the threshold. It works in the same way as the sysctl and
affects both the soft and the hard lockup detectors.
Signed-off-by: Laurence Oberman
to avoid the hard lockups in the console code.
Signed-off-by: Laurence Oberman
---
init/main.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/init/main.c b/init/main.c
index e4a3160..5882750 100644
--- a/init/main.c
+++ b/init/main.c
@@ -977,6 +977,15 @@ static int __init
to avoid the hard lockups in the console code.
Signed-off-by: Laurence Oberman
---
init/main.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/init/main.c b/init/main.c
index e4a3160..5882750 100644
--- a/init/main.c
+++ b/init/main.c
@@ -977,6 +977,15 @@ static int __init
to avoid the hard lockups in the console code.
Signed-off-by: Laurence Oberman
---
Documentation/admin-guide/kernel-parameters.txt | 8
init/main.c | 9 +
2 files changed, 17 insertions(+)
diff --git a/Documentation/admin-guide/kernel
to avoid the hard lockups in the console code.
Signed-off-by: Laurence Oberman
---
Documentation/admin-guide/kernel-parameters.txt | 7 +++
init/main.c | 8
2 files changed, 15 insertions(+)
diff --git a/Documentation/admin-guide/kernel
git tree, please drop us a
> note to help improve the system]
>
> url:https://github.com/0day-ci/linux/commits/Laurence-Oberman/V3-
> init-main-c-Enable-watchdog_thresh-control-from-kernel-line/20181025-
> 015902
> base: https://github.com/thesofproject/linux master
> co
to avoid the hard lockups in the console code.
Signed-off-by: Laurence Oberman
Acked-by: Randy Dunlap
---
Documentation/admin-guide/kernel-parameters.txt | 7 +++
init/main.c | 11 +++
2 files changed, 18 insertions(+)
diff --git a/Documentation
r_template(&tcm_qla2xxx_ops);
When I first saw this I thought, no way, it must be used, but when I
had a closer look and checked its indeed not used or even made
external.
This looks OK to me.
Reviewed-by: Laurence Oberman
On Wed, 2021-02-03 at 03:15 +, Chaitanya Kulkarni wrote:
> On 2/2/21 18:39, Ming Lei wrote:
> > + /* fall through */
> > case REQ_OP_WRITE_ZEROES:
> > - return 0;
>
> I don't think returning 1 for write-zeroes is right,
> did you test this patch with write-zeores enable
On Wed, 2021-02-03 at 08:50 -0500, Laurence Oberman wrote:
> On Wed, 2021-02-03 at 03:15 +, Chaitanya Kulkarni wrote:
> > On 2/2/21 18:39, Ming Lei wrote:
> > > + /* fall through */
> > > case REQ_OP_WRITE_ZEROES:
> > > - return 0;
> >
[xfs]
> > process_one_work+0x1b6/0x350
> > worker_thread+0x53/0x3e0
> > ? process_one_work+0x350/0x350
> > kthread+0x11b/0x140
> > ? __kthread_bind_mask+0x60/0x60
> > ret_from_fork+0x22/0x30
> >
> > This patch fixes blk_recalc_rq_segments to be awa
On Thu, 2021-02-04 at 11:43 -0500, Laurence Oberman wrote:
> On Thu, 2021-02-04 at 10:27 +0800, Ming Lei wrote:
> > On Mon, Feb 01, 2021 at 11:48:50AM -0500, David Jeffery wrote:
> > > When a stacked block device inserts a request into another block
> &
shost_printk(KERN_DEBUG, fnic->lport-
> >host,
> + "Start VLAN Discovery\n");
> fnic_event_enq(fnic, FNIC_EVT_START_VLAN_DISC);
> break;
> case FIP_VLAN_SENT:
This looks good to me.
Reviewed-by: Laurence Oberman
s.action &
> + if (sa_ctx->fpga_xfrm->accel_xfrm.attrs.action ==
> MLX5_ACCEL_ESP_ACTION_DECRYPT)
> ida_free(&fipsec->halloc, sa_ctx->sa_handle);
>
Looks correct to me with enum mlx5_accel_esp_action action;
Reviewed-by Laurence Oberman
I need more of the stack if you have it, the screenshot is not attached.
Thanks
Laurence
On Sun, Nov 30, 2014 at 6:11 AM, Richard Weinberger
wrote:
> On Sat, Nov 29, 2014 at 11:52 AM, Simon Danner wrote:
>> Hello,
>> i get the following crash after i try to copy files from a broken
>> external h
est()
>
> Thanks,
> //richard
>
>> Thanks
>> Simon
>>
>> On Sun, 2014-11-30 at 10:58 -0500, Laurence Oberman wrote:
>>> I need more of the stack if you have it, the screenshot is not attached.
>>> Thanks
>>> Laurence
>>>
>>>
3 99
21:49:23 sdg 163840213 320 512 0 000 512
125 447 3 99
21:49:24 sdg 18944 0 37 512 0 000 512
19 442 29
21:49:25 sdg 0 000 0 000 0
0
that is reported as working.
So other changes in 4.4 must be "abusing" this high value.
Reviewed-by Laurence Oberman
Laurence Oberman
Principal Software Maintenance Engineer
Red Hat Global Support Services
- Original Message -
From: "Johannes Thumshirn"
To: "Mart
Johannes
OK , yes thanks for pointing out the commit.
Laurence Oberman
Principal Software Maintenance Engineer
Red Hat Global Support Services
- Original Message -
From: "Johannes Thumshirn"
To: "Laurence Oberman"
Cc: "Johannes Thumshirn" , "M
Simple change, looks fine to me.
Reviewed-by: Laurence Oberman
Laurence Oberman
Principal Software Maintenance Engineer
Red Hat Global Support Services
- Original Message -
From: "Denys Vlasenko"
To: "James Bottomley"
Cc: "Denys Vlasenko" , "Hir
On Fri, 2019-09-27 at 17:26 +0200, Martin Wilck wrote:
> On Mon, 2019-09-23 at 11:31 +0530, Milan P. Gandhi wrote:
> > Couple of users had requested to print the SCSI command age along
> > with command failure errors. This is a small change, but allows
> > users to get more important information
intf(logbuf + off, logbuf_len - off,
> + "cmd-age=%lus", cmd_age);
> +
> out_printk:
> dev_printk(KERN_INFO, &cmd->device->sdev_gendev, "%s", logbuf);
> scsi_log_release_buffer(logbuf);
>
This looks to be a useful debug addition to me, and the code looks
correct.
I believe this has also been tested by Milan in our lab.
Reviewed-by: Laurence Oberman
- Original Message -
> From: "Laurence Oberman"
> To: "Jan Kara"
> Cc: "Johannes Weiner" , "Hugh Dickins"
> , "Linus Torvalds"
> , "Dave Chinner" , "Chris
> Leech" , "Linux
> Kern
);
> + kfree(buf);
> + snic_req_free(snic, rqi);
> ret = -EINVAL;
>
> goto error;
> --
> 2.8.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Looks fine to me
Reviewed-by Laurence Oberman
return ERR_PTR(-EINVAL);
> }
> *p++ = '\0';
> --
> 2.8.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Simple change, and its fine
Reviewed-by Laurence Oberman
> if (*base == 0)
> - return (ENOMEM);
> + return -ENOMEM;
> if (!request_region(*base, 256, "aic7xxx"))
> - return (ENOMEM);
> + return -ENOMEM;
> return (0);
> }
>
> @@ -369,16 +369,16 @@ ahc_linux_pci_reserve_mem_region(struct ahc_softc *ahc,
> if (start != 0) {
> *bus_addr = start;
> if (!request_mem_region(start, 0x1000, "aic7xxx"))
> - error = ENOMEM;
> + error = -ENOMEM;
> if (error == 0) {
> *maddr = ioremap_nocache(start, 256);
> if (*maddr == NULL) {
> - error = ENOMEM;
> + error = -ENOMEM;
> release_mem_region(start, 0x1000);
> }
> }
> } else
> - error = ENOMEM;
> + error = -ENOMEM;
> return (error);
> }
>
> diff --git a/drivers/scsi/aic7xxx/aic7xxx_pci.c
> b/drivers/scsi/aic7xxx/aic7xxx_pci.c
> index 22d5a94..40e1c9b 100644
> --- a/drivers/scsi/aic7xxx/aic7xxx_pci.c
> +++ b/drivers/scsi/aic7xxx/aic7xxx_pci.c
> @@ -806,7 +806,7 @@ ahc_pci_config(struct ahc_softc *ahc, const struct
> ahc_pci_identity *entry)
>
> error = ahc_reset(ahc, /*reinit*/FALSE);
> if (error != 0)
> - return (ENXIO);
> + return -ENXIO;
>
> if ((ahc->features & AHC_DT) != 0) {
> u_int sfunct;
> @@ -2387,7 +2387,7 @@ static int
> ahc_raid_setup(struct ahc_softc *ahc)
> {
> printk("RAID functionality unsupported\n");
> - return (ENXIO);
> + return -ENXIO;
> }
>
> static int
> --
> 2.5.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Patch looks simple as the change is straightforward.
However can you make the code consistent, some have parenthesis in return, some
not.
How did this work before though if it was returning non-negative to the caller
or upper layer
Has this been tested to work with the changes
Reviewed-by Laurence Oberman
scribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Looks fine, small comment is that the function call prior to check in the
fucntion sets up variables etc.
So is more expensive than a simple NULL check prior.
Reviewed-by: Laurence Oberman
if (err_warn_bit_map & (u64)((u64)1 << i)) {
> err_warn = i;
> break;
> }
> --
> 2.9.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Looks fine to me.
Reviewed-by: Laurence Oberman
- Original Message -
> From: "Alexander Alemayhu"
> To: "Colin King"
> Cc: "Sathya Prakash" , "Chaitra P B"
> , "Suganath Prabu
> Subramani" , "James E . J . Bottomley"
> , "Martin K .
> Petersen" , "MPT-FusionLinux pdl"
> ,
> linux-s...@vger.kernel.org, linux-kernel@vger.kernel.org
- Original Message -
> From: "Jan Kara"
> To: "Johannes Weiner"
> Cc: "Hugh Dickins" , "Linus Torvalds"
> , "Dave Chinner"
> , "Chris Leech" , "Linux Kernel
> Mailing List"
> , "Lee Duncan" ,
> open-is...@googlegroups.com, "Linux SCSI List"
> , linux-bl...@vger.kernel.org, "Christoph
* Combine with controller limits */
> q->limits.max_sectors = min(rw_max, queue_max_hw_sectors(q));
> --
> 2.9.3
>
>
Looks good to me and addresses the issue we faced.
FInal confirmation this change is OK to come from Martin or James.
Reviewed-by: Laurence Oberman
; + int rc;
>
> if (mr->npages && mr->pages) {
> rc = bnxt_qplib_free_fast_reg_page_list(&rdev->qplib_res,
> --
> 2.10.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Makes sense, looks fine.
Reviewed-by: Laurence Oberman
t;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Looks fine:
Reviewed by: Laurence Oberman
"offload request, unexpected complection\n");
> + "offload request, unexpected completion\n");
> return;
> }
>
> --
> 2.8.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Simple fix
Reviewed-by Laurence Oberman
On 07/07/2017 11:03 AM, Jens Axboe wrote:
On 07/07/2017 09:00 AM, Christoph Hellwig wrote:
On Thu, Jul 06, 2017 at 12:55:04PM +0300, Meelis Roos wrote:
Also we're trying to move people away from the cciss driver, can you
check if the hpsa SCSI driver works for you as well?
I have older adap
On 07/07/2017 02:08 PM, Christoph Hellwig wrote:
On Fri, Jul 07, 2017 at 11:42:38AM -0400, Laurence Oberman wrote:
What happens when hpsa_allow_any=1 with the Smart Array 64xx
It should probe.
But only if it has a HP vendor ID as far as I can tell. We'd
still need to add the compaq i
Revision 6
> * 10-MAR-94
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Looks right matching what James wanted as well.
Reviewed-by: Laurence Oberman
- Original Message -
> From: "Martin K. Petersen"
> To: "Michael Opdenacker"
> Cc: cor...@lwn.net, j...@linux.vnet.ibm.com, "martin petersen"
> ,
> linux-...@vger.kernel.org, linux-kernel@vger.kernel.org,
> linux-s...@vger.kernel.org
> Sent: Thursday, September 15, 2016 10:06:19 AM
>
Commit-ID: 11295055526308ee71d82dc97f0a9ca2dd61c3b9
Gitweb: https://git.kernel.org/tip/11295055526308ee71d82dc97f0a9ca2dd61c3b9
Author: Laurence Oberman
AuthorDate: Thu, 1 Nov 2018 09:30:18 -0400
Committer: Thomas Gleixner
CommitDate: Thu, 1 Nov 2018 14:33:35 +0100
watchdog/core: Add
57 matches
Mail list logo
