Re: [PATCH] iio: light: bh1750: Move static keyword to the front of declaration

Hello Jonathan, Thank you for feedback. [...] > > drivers/iio/light/bh1750.c:64:1: warning: > > ‘static’ is not at beginning of declaration [-Wold-style-declaration] [...] > This one has me confused. The warning seems to be false as static > is at the beginning of the declaration > > Sure

Re: [PATCH] PCI: hv: Make functions only used locally static in pci-hyperv.c

Hello Bjorn, Thank you for feedback. [...] Maybe just: PCI: hv: Make functions static since we already know it's in pci-hyperv.c, and it's obvious that you can only do this for functions that are only used locally. Makes sense. I will update the subject line in v3. [...] Rewrap commit l

RE: [PATCH v2] PCI: hv: Make functions only used locally static in pci-hyperv.c

Hello Haiyang, Thank you for feedback. [...] The second line should be aligned next to the "(" on the first line. Also the first line is now over 80 chars. Sorry about this. I will fix it in v3. Thank you for pointing this out. To address both the alignment and line length of hv_registe

[PATCH v3] PCI: hv: Make functions static

/pci/controller/pci-hyperv.c:1082:5: warning: no previous prototype for ‘hv_register_block_invalidate’ [-Wmissing-prototypes] Signed-off-by: Krzysztof Wilczynski --- Changes in v3: Commit message has been wrapped to fit 75 columns. Addressed formatting based on feedback from v2. Changes in

[PATCH v3] x86/PCI: Add missing log facility and move to use pr_ macros

x27;"%s...", __func__' to using 'bios32_service', this function's name, in a string Signed-off-by: Krzysztof Wilczynski --- Changes in v3: Remove name of the file from the subject. Address review feedback of v2, and resolve more checkpatch.pl script errors and

[PATCH] leds: Move static keyword to the front of declarations

beginning of declaration [-Wold-style-declaration] drivers/leds/leds-ti-lmu-common.c:14:1: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration] Signed-off-by: Krzysztof Wilczynski --- Related: https://lore.kernel.org/r/20190827233017.gk9...@google.com drivers/leds/leds

[PATCH] unicode: Move static keyword to the front of declarations

-declaration] fs/unicode/utf8-selftest.c:92:1: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration] Signed-off-by: Krzysztof Wilczynski --- Related: https://lore.kernel.org/r/20190827233017.gk9...@google.com fs/unicode/utf8-selftest.c | 4 ++-- 1 file changed, 2

Re: [PATCH] leds: Move static keyword to the front of declarations

Hello Dan, Thank you for feedback. [...] This file is missing in the subject. Maybe break it out into a separate patch since they do not have dependencies on each other. Will do. Sorry about that. I initially had these as separate patches, but after looking at who the maintainer is and tho

[PATCH v2 2/2] leds: ti-lmu-common: Move static keyword to the front of declaration

] Signed-off-by: Krzysztof Wilczynski --- Related: https://lore.kernel.org/r/20190827233017.gk9...@google.com drivers/leds/leds-ti-lmu-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/leds/leds-ti-lmu-common.c b/drivers/leds/leds-ti-lmu-common.c index e294a0b097e3

[PATCH v2 1/2] leds: lm3532: Move static keyword to the front of declarations

-style-declaration] drivers/leds/leds-lm3532.c:266:1: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration] drivers/leds/leds-lm3532.c:281:1: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration] Signed-off-by: Krzysztof Wilczynski --- Related

[PATCH] ceph: Move static keyword to the front of declarations

declaration [-Wold-style-declaration] fs/ceph/export.c:88:2: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration] fs/ceph/export.c:90:2: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration] Signed-off-by: Krzysztof Wilczynski --- Related: https

[PATCH] iwlwifi: mvm: Move static keyword to the front of declarations

beginning of declaration [-Wold-style-declaration] drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c:434:1: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration] Signed-off-by: Krzysztof Wilczynski --- Related: https://lore.kernel.org/r/20190827233017.gk9...@google.com

[PATCH] iio: light: bh1750: Move static keyword to the front of declaration

] Signed-off-by: Krzysztof Wilczynski --- Related: https://lore.kernel.org/r/20190827233017.gk9...@google.com drivers/iio/light/bh1750.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iio/light/bh1750.c b/drivers/iio/light/bh1750.c index 28347df78cff..460c0013f1a9

Re: [PATCH] iwlwifi: mvm: Move static keyword to the front of declarations

Hi Luca, [...] > Thanks for your patch! Though we already have this change in our > internal tree (submitted by YueHaibing) and it will reach the mainline > soon. Thank you for letting me know. I am glad it's fixed. :) Krzysztof

[PATCH] csky: Move static keyword to the front of declaration

-declaration] Signed-off-by: Krzysztof Wilczynski --- Related: https://lore.kernel.org/r/20190827233017.gk9...@google.com arch/csky/kernel/perf_event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/csky/kernel/perf_event.c b/arch/csky/kernel/perf_event.c index 4c1a1934d76a

Re: [PATCH] csky: Move static keyword to the front of declaration

Hello Guo, Thank you for the feedback! [...] > You may also modify others' [...] That work is on-going, and patches are being sent out to address other warnings of this nature to the respective maintainers. :) Krzysztof

[PATCH 0/3] PCI/ACPI: Rename _HPP to _HPX and move of ACPI-specific code from probe.c

as they build upon one-another. Related: https://lore.kernel.org/lkml/20190419220220.gi173...@google.com https://lore.kernel.org/lkml/20190307213834.5914-3-mr.nuke...@gmail.com https://lore.kernel.org/lkml/20190307213834.5914-2-mr.nuke...@gmail.com Krzysztof Wilczynski (3): PCI/ACPI: Rename

[PATCH 3/3] PCI/ACPI: Remove unnecessary struct hotplug_program_ops from pci-acpi.c

ct hotplug_program_ops as all of the _HPX Type 0, 1, 2 and 3 would be directly accessible. Signed-off-by: Krzysztof Wilczynski --- drivers/pci/pci-acpi.c | 96 -- drivers/pci/pci.h | 74 +--- drivers/pci/probe.c| 9 +--

[PATCH 2/3] PCI/ACPI: Move ACPI-specific Hot Plug programming functions to pci-acpi.c

, hpx_type2 and hpx_type3 to drivers/pci/pci.h as these are shared between drivers/pci/pci-acpi.c and drivers/pci/probe.c. Signed-off-by: Krzysztof Wilczynski --- drivers/pci/pci-acpi.c | 296 drivers/pci/pci.h | 79 ++ drivers/pci

[PATCH 1/3] PCI/ACPI: Rename ACPI Hot Plug structs for Type 0, 1 and 2 from _HPP to _HPX

types in _HPP, therefore structs hpp_type1 and hpp_type2 are renamed to reflect their relation to _HPX rather than _HPP. Any relevant variable names, structs and function names, etc., have been updated to reflect the name change of the A CPI Hot Plug structs. Signed-off-by: Krzysztof Wilcz

[PATCH] PCI: Move PCI Express ASPM function prototypes and definitions to pci.h

PCIE_LINK_STATE_L0S, PCIE_LINK_STATE_L1 and PCIE_LINK_STATE_CLKPM. There are no functional changes. Signed-off-by: Krzysztof Wilczynski --- drivers/acpi/pci_root.c | 1 - drivers/char/xillybus/xillybus_pcie.c | 1 - drivers/net/ethernet/intel/e1000e/e1000.h | 1 - drivers

Re: [PATCH] PCI: Move static keyword to the front of declarations in pci-bridge-emul.c

Hello Bjorn and Thomas, Thank you for the feedback. [...] Move the static keyword to the front of declarations of pci_regs_behavior and pcie_cap_regs_behavior, and resolve compiler warning that can be seen when building with warnings enabled (W=1). It would be useful to include the compil

Re: [PATCH] x86/PCI: Add missing SPDX license header.

Hello Bjorn, Thank you for the feedback. [...] +// SPDX-License-Identifier: GPL-2.0 /* * This file is subject to the terms and conditions of the GNU General Public * License. See the file "COPYING" in the main directory of this archive You can remove this license text at the same

Re: [PATCH] x86/PCI: Add missing log facility and move to use pr_ macros in pcbios.c

Hello Bjorn, Thank you for the feedback. [...] Make the log facility used to print warnings to be KERN_WARNING explicitly, rather than rely on the current (or default) value of the MESSAGE_LOGLEVEL_DEFAULT set in Kconfig. This will make all the warnings in the arch/x86/pci/pcbios.c to be pr

[PATCH v2] PCI: Move static keyword to the front of declarations in pci-bridge-emul.c

-off-by: Krzysztof Wilczynski --- Changes in v2: Update commit message to include compiler warning. drivers/pci/pci-bridge-emul.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/pci-bridge-emul.c b/drivers/pci/pci-bridge-emul.c index 06083b86d4f4..5fd90105510d

[PATCH v2] x86/PCI: Correct warnings about missing or incorrect SPDX license headers.

tation/process/license-rules.rst). Both changes will resolve the following checkpatch.pl script warning: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 Signed-off-by: Krzysztof Wilczynski --- Changes in v2: Update wording and mention checkpatch.pl script warnings. Add

[PATCH v2] x86/PCI: Add missing log facility and move to use pr_ macros in pcbios.c

warning: WARNING: printk() should include KERN_ facility level While adding the missing log facility move over to using pr_ macros over using printk(KERN_ ...) and DBG(). Signed-off-by: Krzysztof Wilczynski --- Changes in v2: Change wording and include checkpatch.pl script warning. Leverage

Re: [PATCH v2] x86/PCI: Add missing log facility and move to use pr_ macros in pcbios.c

Hello Joe, Thank you for feedback. [...] Move to pr_debug() over using DBG() from arch/x86/include/asm/pci_x86.h. You might also consider the checkpatch output for this patch. arch/x86/pci/pcbios.c:116: WARNING: line over 80 characters arch/x86/pci/pcbios.c:116: WARNING: Prefer using '"%s.

Re: [PATCH v2] x86/PCI: Add missing log facility and move to use pr_ macros in pcbios.c

Hello Joe, [...] The lines over 80 characters wide would be taken care of when moving to using the pr_ macros as the line length will now be shorter contrary to when the e.g., printk(KERNEL_INFO ...), etc., was used. Not really, those were the warnings checkpatch emits on your actual patch.

[PATCH v2] PCI: hv: Make functions only used locally static in pci-hyperv.c

hv_register_block_invalidate(struct pci_dev *pdev, void *context, ^ Signed-off-by: Krzysztof Wilczynski --- Changes in v2: Update commit message to include compiler warning. drivers/pci/controller/pci-hyperv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/pci

[PATCH] x86/PCI: Add missing log facility and move to use pr_ macros in pcbios.c

printk(KERN_ ...) with corresponding pr_ macros, while adding the missing log facility. Signed-off-by: Krzysztof Wilczynski --- arch/x86/pci/pcbios.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/arch/x86/pci/pcbios.c b/arch/x86/pci/pcbios.c index

[PATCH] PCI: mediatek: Remove surplus return from a void function

ned-off-by: Krzysztof Wilczynski --- drivers/pci/controller/pcie-mediatek.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/pci/controller/pcie-mediatek.c b/drivers/pci/controller/pcie-mediatek.c index 3eaa7081ab2a..626a7c352dfd 100644 --- a/drivers/pci/controller/pcie-mediatek.c +++

[PATCH] PCI: Remove the use of printk_ratelimit() in pci.c

it instead of pr_info inside the if-statement. Signed-off-by: Krzysztof Wilczynski --- drivers/pci/pci.c | 4 ++-- include/linux/pci.h | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index f20a3de57d21..e3d190d003c5 100644 --- a/d

[PATCH] PCI: hotplug: Remove surplus return from a void function

/hotplug/cpqphp_ctrl.c: interrupt_event_handler() - drivers/pci/hotplug/cpqphp_nvram.h: compaq_nvram_init() - drivers/pci/hotplug/rpadlpar_core.c: rpadlpar_io_init() - drivers/pci/hotplug/rpaphp_core.c: cleanup_slots() Signed-off-by: Krzysztof Wilczynski --- drivers/pci/hotplug

[PATCH] PCI: Move static keyword to the front of declarations in pci-bridge-emul.c

Move the static keyword to the front of declarations of pci_regs_behavior and pcie_cap_regs_behavior, and resolve compiler warning that can be seen when building with warnings enabled (W=1). Signed-off-by: Krzysztof Wilczynski --- drivers/pci/pci-bridge-emul.c | 4 ++-- 1 file changed, 2

[PATCH] PCI: hv: Make functions only used locally static in pci-hyperv.c

warnings enabled (W=1). Signed-off-by: Krzysztof Wilczynski --- drivers/pci/controller/pci-hyperv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c index f1f300218fab..c9642e429c2d 100644 --- a

[PATCH] net: qed: Move static keyword to the front of declaration

-declaration] Also, resolve checkpatch.pl script warning: WARNING: static const char * array should probably be static const char * const Signed-off-by: Krzysztof Wilczynski --- Related: https://lore.kernel.org/r/20190827233017.gk9...@google.com drivers/net/ethernet/qlogic/qed/qed_iwarp.c | 2

[PATCH] net: hns: Move static keyword to the front of declaration

-style-declaration] Signed-off-by: Krzysztof Wilczynski --- Related: https://lore.kernel.org/r/20190827233017.gk9...@google.com drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c

Re: [PATCH v3] PCI: hv: Make functions static

Hello Lorenzo, [...] > This patch should go via the net tree - the code it is fixing > is queued there, I will drop this patch from the PCI review > queue. [...] Thank you! Appreciated. Krzysztof

[PATCH] nds32: Move static keyword to the front of declaration

-declaration] Signed-off-by: Krzysztof Wilczynski --- Related: https://lore.kernel.org/r/20190827233017.gk9...@google.com arch/nds32/kernel/perf_event_cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/nds32/kernel/perf_event_cpu.c b/arch/nds32/kernel/perf_event_cpu.c

Re: [PATCH] iio: light: bh1750: Move static keyword to the front of declaration

Hello Jonathan, Thank you for the feedback. I really appreciate it. [...] > We can do that of course, but that's nothing to do with moving the static > keyword to the front of the declaration which is what the patch claims > to be doing. I see your point. I am going to send a v2 that hopefully

[PATCH] PCI: Move ATS declarations to linux/pci-ats.h

). No functional changes intended. Signed-off-by: Krzysztof Wilczynski --- Related: https://lore.kernel.org/r/20190902211100.gh7...@google.com https://lore.kernel.org/r/20190724233848.73327-9-skunberg.kel...@gmail.com include/linux/pci-ats.h | 76 +++-- inc

[PATCH] x86/PCI: Add missing SPDX license header.

Add the missing "SPDX-License-Identifier" license header to the arch/x86/pci/numachip.c. Use GPL-2.0 identifier derived using the comment mentioning license from the top of the file. Signed-off-by: Krzysztof Wilczynski --- arch/x86/pci/numachip.c | 1 + 1 file changed, 1 insertio

[PATCH] x86/PCI: Replace deprecated EXTRA_CFLAGS with ccflags-y.

Update arch/x86/pci/Makefile replacing the deprecated EXTRA_CFLAGS with the ccflags-y matching recommendation as per the section 3.7 "Compilation flags" of the "Linux Kernel Makefiles" (see: Documentation/kbuild/makefiles.txt). Signed-off-by: Krzysztof Wilczynski --- arch/

[PATCH] PCI: Fix misspelled words.

Fix misspelled words in include/linux/pci.h, drivers/pci/Kconfig, and in the documentation for Freescale i.MX6 and Marvell Armada 7K/8K PCIe interfaces. No functional change intended. Related commit 96291d565550 ("PCI: Fix typos and whitespace errors"). Signed-off-by: Krzysztof

[PATCH] ACPI/PCI: Remove surplus parentheses from a return statement

Remove unnecessary parentheses enclosing the value in a return statement in the drivers/acpi/pci_link.c. Signed-off-by: Krzysztof Wilczynski --- drivers/acpi/pci_link.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c

[PATCH] x86/PCI: Remove surplus return from a void function

Remove unnecessary empty return statement at the end of a void function in the arch/x86/kernel/quirks.c. Signed-off-by: Krzysztof Wilczynski --- arch/x86/kernel/quirks.c | 4 1 file changed, 4 deletions(-) diff --git a/arch/x86/kernel/quirks.c b/arch/x86/kernel/quirks.c index 8451f38ad399

Re: [PATCH v4 0/6] Fix some issues related to an interrupt type in pci_endpoint_test

Hello, > This series solves some issues about global "irq_type" that is used for > indicating the current type for users. > > In addition, avoid an unexpected warning that occur due to interrupts > remaining after displaying an error caused by devm_request_irq(). > > Patch 1 includes adding GET_

[tip: x86/cleanups] x86/PCI: Remove superfluous returns from void functions

The following commit has been merged into the x86/cleanups branch of tip: Commit-ID: f25896ebfe0cf818ebd1adb5e6a05dc40b820e45 Gitweb: https://git.kernel.org/tip/f25896ebfe0cf818ebd1adb5e6a05dc40b820e45 Author:Krzysztof Wilczynski AuthorDate:Tue, 20 Aug 2019 08:51:21 +02