[PATCH] Add iSCSI iBFT support (v0.4.6)

2008-01-30 Thread Konrad Rzeszutek
/initiator/index: 0 For full details of the IBFT structure please take a look at: ftp://ftp.software.ibm.com/systems/support/system_x_pdf/ibm_iscsi_boot_firmware_table_v1.02.pdf Signed-off-by: Konrad Rzeszutek <[EMAIL PROTECTED]> Cc: Mike Christie <[EMAIL PROTECTED]> Cc: Peter J

Re: [PATCH] Add iSCSI iBFT support (v0.4.5)

2008-01-30 Thread Konrad Rzeszutek
> That being said, I don't think there's any reason to expect the table to > show up on anything but i386 and x86_64, and maybe ia64. I've posted a new patch (http://lkml.org/lkml/2008/1/30/531) that includes that dependency in the Kconfig (i386, x86_64, ia64) -- To unsubscribe from this list

Re: REPOST: [PATCH] Add iSCSI iBFT support (v0.4.7)

2008-02-11 Thread Konrad Rzeszutek
> > + if (hdr->id == id_nic) { > > + pci_dev = pci_get_bus_and_slot((nic->pci_bdf & 0xff00) >> > > 8, + (nic->pci_bdf & 0xff)); > pci_get_bus_and_slot fails in the presence of PCI domains, which are > getting to be fairly common even

[PATH] Add iSCSI iBFT support (v0.4.8)

2008-02-12 Thread Konrad Rzeszutek
/initiator/index: 0 For full details of the IBFT structure please take a look at: ftp://ftp.software.ibm.com/systems/support/system_x_pdf/ibm_iscsi_boot_firmware_table_v1.02.pdf Signed-off-by: Konrad Rzeszutek <[EMAIL PROTECTED]> Cc: Mike Christie <[EMAIL PROTECTED]> Cc: Peter Jones

[PATCH] Add iSCSI iBFT support (v0.4.7)

2008-02-08 Thread Konrad Rzeszutek
/initiator/index: 0 For full details of the IBFT structure please take a look at: ftp://ftp.software.ibm.com/systems/support/system_x_pdf/ibm_iscsi_boot_firmware_table_v1.02.pdf Signed-off-by: Konrad Rzeszutek <[EMAIL PROTECTED]> Cc: Mike Christie <[EMAIL PROTECTED]> Cc: Peter Jones

Re: [PATCH] Add iSCSI iBFT support (v0.4.6)

2008-02-08 Thread Konrad Rzeszutek
On Friday 01 February 2008 19:18:09 James Bottomley wrote: > On Wed, 2008-01-30 at 17:37 -0400, Konrad Rzeszutek wrote: > > This patch (v0.4.6) adds > Some pieces of the patch are obviously wrong: find_ibft() shouldn't be > in ibft_init ... if ibft_phys was zero, it means the

REPOST: [PATCH] Add iSCSI iBFT support (v0.4.7)

2008-02-08 Thread Konrad Rzeszutek
/index: 0 For full details of the IBFT structure please take a look at: ftp://ftp.software.ibm.com/systems/support/system_x_pdf/ibm_iscsi_boot_firmware_table_v1.02.pdf Signed-off-by: Konrad Rzeszutek <[EMAIL PROTECTED]> Cc: Mike Christie <[EMAIL PROTECTED]> Cc: Peter Jones <[

Re: [PATCH] Add iSCSI IBFT support (v0.4.3)

2007-12-21 Thread Konrad Rzeszutek
> and you don't need to call kobject_del() right before kobject_put(). > Hm, that last one was always true, so that wasn't needed before... > > Do you want me to add this to my driver/ tree and fix up the kobject > issues there so it all builds properly, and it gets sent to Linu

[PATCH] Add iSCSI IBFT support (v0.4.3)

2007-12-22 Thread Konrad Rzeszutek
/ibm_iscsi_boot_firmware_table_v1.02.pdf Please note that this patch depends on the Greg KH patches tree kobject changes. Signed-off-by: Konrad Rzeszutek <[EMAIL PROTECTED]> diff --git a/Documentation/ABI/testing/sysfs-ibft b/Documentation/ABI/testing/sysfs-ibft new file mode 100644 index 000..4898740 --- /de

[REPOST PATCH] Add iSCSI IBFT support (v0.4)

2007-11-28 Thread Konrad Rzeszutek
Signed-off-by: Konrad Rzeszutek <[EMAIL PROTECTED]> Signed-off-by: Peter Jones <[EMAIL PROTECTED]> diff --git a/Documentation/ABI/testing/sysfs-ibft b/Documentation/ABI/testing/sysfs-ibft new file mode 100644 index 000..941ad9f --- /dev/null +++ b/Documentation/ABI/testing/sysfs-

Re: [PATCH] Add iSCSI IBFT Support (v0.3)

2007-12-04 Thread Konrad Rzeszutek
On Thu, Nov 29, 2007 at 11:36:21AM -0400, [EMAIL PROTECTED] wrote: > > > > > > /sys/firmware/ibft/ethernet0/pci-bdf > > > 5:1:0 > > > > shouldn't this somehow also have a symlink to the kernels ethX view of > > ethernet devices? > > (and if so.. how much of the info is duplicated..) > > That NIC

Re: [REPOST PATCH] Add iSCSI IBFT support (v0.4)

2007-12-05 Thread Konrad Rzeszutek
On Tue, Dec 04, 2007 at 09:12:11PM -0600, Doug Maxey wrote: > Overall, looks nice. Good work. Thank you. > > comments inline below... > .. snip .. > > +#include > > Is the current include from open-iscsi being duplicated? If not, why > not consolidate in one file? The include files that com

[PATCH] Add iSCSI IBFT support (v0.4.2)

2007-12-05 Thread Konrad Rzeszutek
On Tue, Dec 04, 2007 at 09:12:11PM -0600, Doug Maxey wrote: > Overall, looks nice. Good work. Thank you. > > comments inline below... > > On Tue, 04 Dec 2007 20:44:19 -0400, [EMAIL PROTECTED] wrote: > > On Wed, Nov 28, 2007 at 07:34:22PM -0400, Konrad Rzeszutek wrote: &

Re: [REPOST PATCH] Add iSCSI IBFT support (v0.4)

2007-12-05 Thread Konrad Rzeszutek
On Wed, Dec 05, 2007 at 02:26:40PM -0600, Doug Maxey wrote: > > On Wed, 05 Dec 2007 13:41:21 -0400, Konrad Rzeszutek wrote: > > > Is the current include from open-iscsi being duplicated? If not, why > > > not consolidate in one file? > > > > The include file

Re: [REPOST PATCH] Add iSCSI IBFT support (v0.4)

2007-12-05 Thread Konrad Rzeszutek
On Wed, Dec 05, 2007 at 03:02:56PM -0600, Doug Maxey wrote: > [added cc: to mikec] > > On Wed, 05 Dec 2007 16:40:46 -0400, Konrad Rzeszutek wrote: > > On Wed, Dec 05, 2007 at 02:26:40PM -0600, Doug Maxey wrote: > > > > > > On Wed, 05 Dec 2007 13:41:21 -0400, Kon

[PATCH] Add iSCSI IBFT Support (v0.3)

2007-11-26 Thread Konrad Rzeszutek
at: ftp://ftp.software.ibm.com/systems/support/system_x_pdf/ibm_iscsi_boot_firmware_table_v1.02.pdf Signed-off-by: Konrad Rzeszutek <[EMAIL PROTECTED]> Signed-off-by: Peter Jones <[EMAIL PROTECTED]> diff --git a/arch/x86/kernel/setup_32.c b/arch/x86/kernel/setup_32.c index e1e18c3..e3

Re: [PATCH] Add iSCSI IBFT Support (v0.3)

2007-11-26 Thread Konrad Rzeszutek
On Monday 26 November 2007 22:31:38 Greg KH wrote: > On Mon, Nov 26, 2007 at 06:56:42PM -0400, Konrad Rzeszutek wrote: > > +/* > > + * Routines for reading of the iBFT data in a human readable fashion. > > + */ > > +ssize_t ibft_attr_show_initiator

Re: [PATCH] Add iSCSI IBFT Support (v0.3)

2007-11-26 Thread Konrad Rzeszutek
.. snip.. > > +#else > > +static void __init reserve_ibft_region(void) { }; > > No ending ; above. Fixed. > ..snip.. > > +static void __init reserve_ibft_region(void) { }; > > Ditto. Fixed. .. snip.. > > +#include > > + > > No blank line here, please. Why that creeps back in the code I am not

Re: [PATCH] Add iSCSI IBFT Support (v0.3)

2007-11-26 Thread Konrad Rzeszutek
> > > > sysfs files have ONE VALUE PER FILE, not a whole bunch of different > > things in a single file. Please fix this. > > The subparameters _are_ actually part of a single value, that value being > associated with the initiator instance. > > Konrad is trying to implement a "work-alike" for wha

[PATCH] Add iSCSI iBFT support (v0.4.4)

2008-01-11 Thread Konrad Rzeszutek
/ibm_iscsi_boot_firmware_table_v1.02.pdf Please note that this patch depends on the Greg KH patches tree kobject changes. Signed-off-by: Konrad Rzeszutek <[EMAIL PROTECTED]> diff --git a/Documentation/ABI/testing/sysfs-ibft b/Documentation/ABI/testing/sysfs-ibft new file mode 100644 index 000..4898740 --- /de

[PATCH] Add iSCSI iBFT support (v0.4.5)

2008-01-25 Thread Konrad Rzeszutek
For full details of the IBFT structure please take a look at: ftp://ftp.software.ibm.com/systems/support/system_x_pdf/ibm_iscsi_boot_firmware_table_v1.02.pdf Signed-off-by: Konrad Rzeszutek <[EMAIL PROTECTED]> diff --git a/Documentation/ABI/testing/sysfs-ibft b/Documentation/ABI/testing

Re: [PATCH] Add iSCSI iBFT support (v0.4.5)

2008-01-28 Thread Konrad Rzeszutek
On Sunday 27 January 2008 01:01:23 you wrote: > > On Fri, 25 Jan 2008 18:06:29 -0400 Konrad Rzeszutek <[EMAIL PROTECTED]> > > wrote: Hey Andrew, > > > > Please add this patch along with Greg KH's kobject fixes. > > erm, OK. But I don't think I'

Re: [PATCH] Add iSCSI iBFT support (v0.4.5)

2008-01-28 Thread Konrad Rzeszutek
> iBFT is not platform-independent; it only makes sense on platforms with > ACPI (and even then, just barely; ACPI is a poor fit for it and it was > probably "integrated" with ACPI for political reasons.) The spec just mentions that iBFT table has to be "compatible with an ACPI table format" and

[PATCH] Add iSCSI IBFT support (v0.4.5) - fixes to the header files.

2008-01-28 Thread Konrad Rzeszutek
/initiator/index: 0 For full details of the IBFT structure please take a look at: ftp://ftp.software.ibm.com/systems/support/system_x_pdf/ibm_iscsi_boot_firmware_table_v1.02.pdf Please note that this patch depends on the Greg KH patches tree kobject changes. Signed-off-by: Konrad Rzeszutek <[EM

Re: [PATCH] Add iSCSI IBFT support (v0.4.5) - fixes to the header files.

2008-01-29 Thread Konrad Rzeszutek
On Tuesday 29 January 2008 14:15:15 Mike Christie wrote: > Konrad Rzeszutek wrote: > > +/* > > + * Helper functions to parse data properly. > > + */ > > +static ssize_t sprintf_ipaddr(char *buf, u8 *ip) > > +{ > > + if (ip[0] == 0 && ip[1] == 0

Re: [PATCH] Inhibit NMI watchdog when Alt-SysRq-T operation is underway.

2007-07-20 Thread Konrad Rzeszutek
thing is really needed? printk_address() is pretty > slow and touch_nmi_watchdog is _reasonably_ fast. It could be made heaps > faster by: > > From: Andrew Morton <[EMAIL PROTECTED]> > > Avoid dirtying remote cpu's memory if it already has the correct va

[PATCH] Inhibit NMI watchdog when Alt-SysRq-T operation is underway.

2007-07-09 Thread Konrad Rzeszutek
On large memory configuration with not so fast CPUs the NMI watchdog is triggered when memory addresses are being gathered and printed. The code paths for Alt-SysRq-t are sprinkled with touch_nmi_watchdog in various places but not in this routine (or in the loop that utilizes this function). The

[PATCH] Inhibit machine from asserting an NMI when doing Alt-SysRq-M operation.

2007-03-27 Thread Konrad Rzeszutek
This patch touches the NMI watchdog every MAX_ORDER_NR_PAGES to inhibit the machine from triggering an NMI while the CPUs are locked. This situation is happening on boxes with more than 64CPUs and 128GB of RAM when Alt-SysRq-m is performed. It has been succesfully tested for regression on uni, 2,

[PATCH] Add iSCSI iBFT support.

2007-09-26 Thread Konrad Rzeszutek
the iSCSI share/target. Currently the iSCSI information is hard-coded in the initrd. The full details of the structure are located at: ftp://ftp.software.ibm.com/systems/support/system_x_pdf/ibm_iscsi_boot_firmware_table_v1.02.pdf Signed-off-by: Konrad Rzeszutek <[EMAIL PROTECTED]> Signed-

Re: [PATCH] Add iSCSI iBFT support.

2007-09-26 Thread Konrad Rzeszutek
> > i.e., what is this binary blob (?) > > I don't see a binary blob in this patch (as stated in the first > sentence). I'd say that this patch adds methods for exporting > (or exposing) the ibft thru sysfs. I used the wrong choice of words. The correct one is, as you say, to add methods for exp

Re: [PATCH] Add iSCSI iBFT support.

2007-09-26 Thread Konrad Rzeszutek
On Wednesday 26 September 2007 17:10:57 Greg KH wrote: > On Wed, Sep 26, 2007 at 02:46:52PM -0400, Konrad Rzeszutek wrote: > > This patch adds a /sysfs/firmware/ibft/table binary blob which exports > > the iSCSI Boot Firmware Table (iBFT) structure. > > Please don't do t

Re: [PATCH] Add iSCSI iBFT support.

2007-09-26 Thread Konrad Rzeszutek
> > +config ISCSI_IBFT > > + tristate "iSCSI Boot Firmware Table Attributes" > > + depends on X86 > > why only on X86? PowerPC exports this data via the OpenFirmware so it already shows in the /sysfs entries. I was thinking to combine those sysfs entries under this code, but that is somethin

Re: [PATCH]: PVH: remove FEATURES_PVH macro

2012-11-26 Thread Konrad Rzeszutek Wilk
On Wed, Nov 14, 2012 at 06:19:33PM -0800, Mukesh Rathor wrote: > PVH: remove macro FEATURES_PVH and put PVH strings in the ELFNOTE line, > because there's a null char before FEATURES_PVH and in the FEATURES_PVH > strings since this is not C file ping? Jan had a comment about it to keep the #ifde

Re: [PATCH 2/5] Expand the steal time msr to also contain the consigned time.

2012-11-27 Thread Konrad Rzeszutek Wilk
On Mon, Nov 26, 2012 at 02:36:45PM -0600, Michael Wolf wrote: > Add a consigned field. This field will hold the time lost due to capping or > overcommit. > The rest of the time will still show up in the steal-time field. > > Signed-off-by: Michael Wolf > --- > arch/x86/include/asm/paravirt.h

Re: [PATCH 1/1] mm: Export a function to get vm committed memory

2012-11-27 Thread Konrad Rzeszutek Wilk
n to retrieve guest memory > > commitment. > > This function is also used in Xen self ballooning code. > > > > Signed-off-by: K. Y. Srinivasan > > Acked-by: David Rientjes I am bit late to this party - and back from vacation - so not sure if this is merged in or not.

Re: [PATCH v8 00/46] x86, mm: map ram from top-down with BRK and memblock.

2012-11-27 Thread Konrad Rzeszutek Wilk
On Fri, Nov 16, 2012 at 07:38:37PM -0800, Yinghai Lu wrote: > rebase patchset together tip/x86/mm2 on top of linus v3.7-rc4 > Pardon me for taking so long to respond. Right after you posted it I had a mini-conference and then vacation and I am just now unburrying myself from email avalanche. I w

Re: [PATCH 2/8] mm: frontswap: lazy initialization to allow tmem backends to build/run as modules

2012-11-27 Thread Konrad Rzeszutek Wilk
On Mon, Nov 19, 2012 at 02:25:16PM -0800, Andrew Morton wrote: > On Mon, 19 Nov 2012 08:53:46 +0800 > Bob Liu wrote: > > > On Sat, Nov 17, 2012 at 7:16 AM, Andrew Morton > > wrote: > > > On Wed, 14 Nov 2012 13:57:06 -0500 > > > Konrad Rzeszutek Wilk wr

Re: [PATCH v8 04/46] x86, mm: Move init_memory_mapping calling out of setup.c

2012-11-28 Thread Konrad Rzeszutek Wilk
On Fri, Nov 16, 2012 at 07:38:41PM -0800, Yinghai Lu wrote: > Now init_memory_mapping is called two times, later will be called for every > ram ranges. What is 'later'? Can you say in which of the patches it will be called for every RAM range? > > Could put all related init_mem calling together

Re: [PATCH v8 07/46] x86, mm: Find early page table buffer together

2012-11-28 Thread Konrad Rzeszutek Wilk
On Fri, Nov 16, 2012 at 07:38:44PM -0800, Yinghai Lu wrote: > We should not do that in every calling of init_memory_mapping. Right. > > At the same time need to move down early_memtest, and could remove > after_bootmem ->'remov

Re: [PATCH v8 03/46] x86, mm: Move down find_early_table_space()

2012-11-28 Thread Konrad Rzeszutek Wilk
On Fri, Nov 16, 2012 at 07:38:40PM -0800, Yinghai Lu wrote: > It will need to call split_mem_range(). .. which implies that it needs to call it now, but I could not find the call in your patch. Then realized you meant to do that in the further patches. To avoid this confusion I would recommend you

Re: [PATCH v8 06/46] x86, mm: Change find_early_table_space() paramters

2012-11-28 Thread Konrad Rzeszutek Wilk
s/paramters/parameters/ On Fri, Nov 16, 2012 at 07:38:43PM -0800, Yinghai Lu wrote: > call split_mem_range inside the function. So this looks to introduce an extra split_mem_range which does the same operations on 'mr' that is done in find_early_table_space. Could the find_early_table_space use

Re: [PATCH v8 08/46] x86, mm: Separate out calculate_table_space_size()

2012-11-28 Thread Konrad Rzeszutek Wilk
On Fri, Nov 16, 2012 at 07:38:45PM -0800, Yinghai Lu wrote: > It should take physical address range that will need to be mapped. > find_early_table_space should take range that pgt buff should be in. > > Separating page table size calculating and finding early page table to > reduce confusing. Yo

Re: [PATCH v8 12/46] x86, mm: use pfn_range_is_mapped() with CPA

2012-11-28 Thread Konrad Rzeszutek Wilk
On Fri, Nov 16, 2012 at 07:38:49PM -0800, Yinghai Lu wrote: > We are going to map ram only, so under max_low_pfn_mapped, > between 4g and max_pfn_mapped does not mean mapped at all. I think I know what you are saying but I am having a hard time parsing it. Is this what you mean? "We check to see

Re: [PATCH v8 13/46] x86, mm: use pfn_range_is_mapped() with gart

2012-11-28 Thread Konrad Rzeszutek Wilk
On Fri, Nov 16, 2012 at 07:38:50PM -0800, Yinghai Lu wrote: > We are going to map ram only, so under max_low_pfn_mapped, > between 4g and max_pfn_mapped does not mean mapped at all. Perhaps the re-write I mentioned in the earlier email could help here. > > Use pfn_range_is_mapped() directly. >

Re: [PATCH v8 14/46] x86, mm: use pfn_range_is_mapped() with reserve_initrd

2012-11-28 Thread Konrad Rzeszutek Wilk
On Fri, Nov 16, 2012 at 07:38:51PM -0800, Yinghai Lu wrote: > We are going to map ram only, so under max_low_pfn_mapped, > between 4g and max_pfn_mapped does not mean mapped at all. > > Use pfn_range_is_mapped() to find out if range is mapped for initrd. > > That could happen bootloader put initr

Re: [PATCH v8 15/46] x86, mm: Only direct map addresses that are marked as E820_RAM

2012-11-28 Thread Konrad Rzeszutek Wilk
On Fri, Nov 16, 2012 at 07:38:52PM -0800, Yinghai Lu wrote: > From: Jacob Shin > > Currently direct mappings are created for [ 0 to max_low_pfn< and [ 4GB to max_pfn< backed by actual DRAM. This is fine for holes under 4GB which are covered > by fixed and variable range MTRRs to be UC. However, w

Re: [PATCH v8 21/46] x86, mm: setup page table in top-down

2012-11-28 Thread Konrad Rzeszutek Wilk
On Fri, Nov 16, 2012 at 07:38:58PM -0800, Yinghai Lu wrote: > Get pgt_buf early from BRK, and use it to map PMD_SIZE from top at first. > Then use mapped pages to map more ranges below, and keep looping until > all pages get mapped. > > alloc_low_page will use page from BRK at first, after that bu

Re: [PATCH v8 22/46] x86, mm: Remove early_memremap workaround for page table accessing on 64bit

2012-11-28 Thread Konrad Rzeszutek Wilk
On Fri, Nov 16, 2012 at 07:38:59PM -0800, Yinghai Lu wrote: > We try to put page table high to make room for kdump, and at that time > those ranges are not mapped yet, and have to use ioremap to access it. ^^^ -> were -> had > > Now after patch that pre-map page tab

Re: [PATCH v8 23/46] x86, mm: Remove parameter in alloc_low_page for 64bit

2012-11-28 Thread Konrad Rzeszutek Wilk
On Fri, Nov 16, 2012 at 07:39:00PM -0800, Yinghai Lu wrote: > Now all page table buf are pre-mapped, and could use virtual address directly. ^-> we can > So don't need to remember physical address anymore. > > Remove that phys pointer in alloc_low_

Re: [PATCH v8 29/46] x86, mm: only call early_ioremap_page_table_range_init() once

2012-11-28 Thread Konrad Rzeszutek Wilk
On Fri, Nov 16, 2012 at 07:39:06PM -0800, Yinghai Lu wrote: > On 32bit, before patcheset that only set page table for ram, we only > call that one time. Um.. Which patchset? x86, mm: Only direct map addresses that are marked as E820_RAM? > > Now, we are calling that during every init_memory_map

Re: [PATCH v8 34/46] x86, mm: Add check before clear pte above max_low_pfn on 32bit

2012-11-28 Thread Konrad Rzeszutek Wilk
On Fri, Nov 16, 2012 at 07:39:11PM -0800, Yinghai Lu wrote: > During test patch that adjust page_size_mask to map small range ram with > big page size, found page table is setup wrongly for 32bit. And Which patch is that? x86, mm: Add global page_size_mask and probe one time only Can you include

Re: [PATCH v8 46/46] x86, mm: Let "memmap=" take more entries one time

2012-11-28 Thread Konrad Rzeszutek Wilk
On Fri, Nov 16, 2012 at 07:39:23PM -0800, Yinghai Lu wrote: > Current "memmap=" only can take one entry every time. > when we have more entries, we have to use memmap= for each of them. > > For pxe booting, we have command line length limitation, those extra > "memmap=" would waste too much space.

Re: [PATCH V1 1/2] Xen acpi memory hotplug driver

2012-11-28 Thread Konrad Rzeszutek Wilk
On Wed, Nov 21, 2012 at 11:45:04AM +, Liu, Jinsong wrote: > >From 630c65690c878255ce71e7c1172338ed08709273 Mon Sep 17 00:00:00 2001 > From: Liu Jinsong > Date: Tue, 20 Nov 2012 21:14:37 +0800 > Subject: [PATCH 1/2] Xen acpi memory hotplug driver > > Xen acpi memory hotplug consists of 2 logic

Re: [PATCH v8 00/46] x86, mm: map ram from top-down with BRK and memblock.

2012-11-28 Thread Konrad Rzeszutek Wilk
On Tue, Nov 27, 2012 at 04:17:55PM -0500, Konrad Rzeszutek Wilk wrote: > On Fri, Nov 16, 2012 at 07:38:37PM -0800, Yinghai Lu wrote: > > rebase patchset together tip/x86/mm2 on top of linus v3.7-rc4 > > > > Pardon me for taking so long to respond. Right after you pos

Re: [PATCH v8 00/46] x86, mm: map ram from top-down with BRK and memblock.

2012-11-28 Thread Konrad Rzeszutek Wilk
On Wed, Nov 28, 2012 at 11:47:51AM -0800, Yinghai Lu wrote: > On Wed, Nov 28, 2012 at 11:35 AM, Konrad Rzeszutek Wilk > wrote: > > > > Have done so. I really like how the top-down mechanism works. It is pretty > > neat! > > > > Yinghai, I had mostly just c

Re: [PATCH 00/19 v4] Improve IRQ remapping abstraction in x86 core code

2012-11-28 Thread Konrad Rzeszutek Wilk
On Tue, Nov 20, 2012 at 02:12:37PM +0100, Joerg Roedel wrote: > Hi, > > here is the fourth version of the patch-set to improve the abstraction > of interrupt remapping in the x86 core code. A more detailed description > can be found in the original post at: Are these patches available on some git

Re: [PATCH 00/19 v4] Improve IRQ remapping abstraction in x86 core code

2012-11-28 Thread Konrad Rzeszutek Wilk
://lkml.org/lkml/2012/8/7/317 > I looked at the patches and you can also add Reviewed-by: Konrad Rzeszutek Wilk If you have a git tree I would like to test them as well. Thx. > Changes from v3->v4: > > * Rebased to v3.7-rc6 > * Added Acked-bys > * Fixed

Re: linux-next: build warning after merge of the xen-two tree

2012-11-29 Thread Konrad Rzeszutek Wilk
On Thu, Nov 29, 2012 at 02:25:30PM +1100, Stephen Rothwell wrote: > Hi Konrad, > > After merging the xen-two tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: > > arch/x86/xen/enlighten.c: In function 'init_hvm_pv_info': > arch/x86/xen/enlighten.c:1617:16: warning: unu

Re: [PATCH 3/5] xen-blkfront: switch from llist to list

2013-03-19 Thread Konrad Rzeszutek Wilk
nk #3 FAILED at 105. Hunk #4 FAILED at 371. patch: **** malformed patch at line 172: ork) and idea why? Could you resent the patch as an attachment please? > > Signed-off-by: Roger Pau Monné > [Part of the description] > Signed-off-by: Konrad Rzeszutek Wilk > Cc: xen-de...@lis

Re: [PATCH 3/5] xen-blkfront: switch from llist to list

2013-03-19 Thread Konrad Rzeszutek Wilk
nné CC: sta...@vger.kernel.org [v1: Redid the git commit description] Signed-off-by: Konrad Rzeszutek Wilk diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 9620644..97324cd1 100644 --- a/drivers/block/xen-blkfront.c +++ b/drivers/block/xen-blkfront.c @@

Re: [PATCH 1/5] xen-blkback: don't store dev_bus_addr

2013-03-19 Thread Konrad Rzeszutek Wilk
the 'seg[i].buf' to be 'seg[i].offset' as it makes much more sense - as we use that value in bio_add_page which as the fourth argument expects the offset. We hadn't used the physical address as part of this at all. Signed-off-by: Roger P

Re: [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-03-19 Thread Konrad Rzeszutek Wilk
On Mon, Mar 18, 2013 at 06:06:38PM +0100, Roger Pau Monné wrote: > On 28/02/13 11:28, Roger Pau Monne wrote: > > Indirect descriptors introduce a new block operation > > (BLKIF_OP_INDIRECT) that passes grant references instead of segments > > in the request. This grant references are filled with ar

Re: [Xen-devel] [PATCH 1/5] xen-blkback: don't store dev_bus_addr

2013-03-19 Thread Konrad Rzeszutek Wilk
On Tue, Mar 19, 2013 at 02:55:56PM +, Jan Beulich wrote: > >>> On 19.03.13 at 15:32, Konrad Rzeszutek Wilk > >>> wrote: > > On Mon, Mar 18, 2013 at 05:49:32PM +0100, Roger Pau Monne wrote: > >> dev_bus_addr returned in the grant ref map operation is t

Re: [PATCH v2 3/4] introduce zero-filled page stat count

2013-03-19 Thread Konrad Rzeszutek Wilk
On Sun, Mar 17, 2013 at 8:58 AM, Ric Mason wrote: > Hi Konrad, > > On 03/16/2013 09:06 PM, Konrad Rzeszutek Wilk wrote: >> >> On Thu, Mar 14, 2013 at 06:08:16PM +0800, Wanpeng Li wrote: >>> >>> Introduce zero-filled page statistics to monitor the number

Re: [PATCH v2 1/4] introduce zero filled pages handler

2013-03-19 Thread Konrad Rzeszutek Wilk
On Sat, Mar 16, 2013 at 2:24 PM, Dan Magenheimer wrote: >> From: Konrad Rzeszutek Wilk [mailto:kon...@darnok.org] >> Subject: Re: [PATCH v2 1/4] introduce zero filled pages handler >> >> > + >> > + for (pos = 0; pos < PAGE_SIZE / sizeof(*page);

Re: [Xen-devel] [PATCH 1/5] xen-blkback: don't store dev_bus_addr

2013-03-19 Thread Konrad Rzeszutek Wilk
d the physical address as part of this at all. Signed-off-by: Roger Pau Monné Cc: Konrad Rzeszutek Wilk Cc: xen-de...@lists.xen.org [v1: s/buf/offset/] Signed-off-by: Konrad Rzeszutek Wilk diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/b

[PATCH] xen/acpi-processor: Don't dereference struct acpi_processor on all CPUs.

2013-03-19 Thread Konrad Rzeszutek Wilk
Call Trace: [] ? read_acpi_id+0x12b/0x12b [xen_acpi_processor] [] do_one_initcall+0x12a/0x180 [] load_module+0x1cd3/0x2870 [] ? ddebug_proc_open+0xc0/0xc0 [] sys_init_module+0xd7/0x120 [] system_call_fastpath+0x16/0x1b on some machines. Signed-off-by: Konrad Rzeszutek Wilk --- drivers/xen/xen-acpi-p

[PATCH] intel-pstate: Use #defines instead of hard-coded values.

2013-03-20 Thread Konrad Rzeszutek Wilk
They are defined in coreboot (MSR_PLATFORM) and the other one is already defined in msr-index.h. Lets use those. CC: rafael.j.wyso...@intel.com CC: dirk.j.brande...@intel.com Signed-off-by: Konrad Rzeszutek Wilk --- arch/x86/include/uapi/asm/msr-index.h | 1 + drivers/cpufreq/intel_pstate.c

[GIT PULL] (xen) stable/for-jens-3.9

2013-03-21 Thread Konrad Rzeszutek Wilk
Hey Jens, Please git pull the following branch: git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen.git stable/for-jens-3.9 which has a bunch of fixes. They vary from being able to deal with unknown requests, overflow in statistics, compile warnings, bug in the error path, removal of unne

Re: [PATCH] mm/x86: Patch out arch_flush_lazy_mmu_mode() when running on bare metal

2013-03-21 Thread Konrad Rzeszutek Wilk
On Wed, Mar 13, 2013 at 09:44:43AM -0400, Josh Boyer wrote: > On Wed, Mar 13, 2013 at 09:25:44AM -0400, Boris Ostrovsky wrote: > > On 03/01/2013 07:14 AM, Josh Boyer wrote: > > >On Thu, Feb 28, 2013 at 04:52:20PM -0800, H. Peter Anvin wrote: > > >>On 02/28/2013 04:42 PM, Josh Boyer wrote: > > >>>On

Re: [PATCH v2] Make frontswap+cleancache and its friend be modularized.

2013-02-04 Thread Konrad Rzeszutek Wilk
On Mon, Feb 04, 2013 at 06:21:12PM -0600, Ric Mason wrote: > On Mon, 2013-02-04 at 09:14 -0600, Seth Jennings wrote: > > On 02/03/2013 02:52 AM, Ric Mason wrote: > > > Hi Konrad, > > > On Fri, 2013-02-01 at 15:22 -0500, Konrad Rzeszutek Wilk wrote: > > > &

Re: linux-next: build failure after merge of the xen-two tree

2013-02-05 Thread Konrad Rzeszutek Wilk
On Mon, Feb 04, 2013 at 03:14:56PM +1100, Stephen Rothwell wrote: > Hi Konrad, > > After merging the xen-two tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > arch/x86/xen/mmu.c: In function 'xen_init_mmu_ops': > arch/x86/xen/mmu.c:2213:10: error: 'struct x86_init_ops'

Re: [PATCH] PVH: remove code to map iomem from guest

2013-02-06 Thread Konrad Rzeszutek Wilk
On Wed, Jan 30, 2013 at 02:55:29PM -0800, Mukesh Rathor wrote: > It was decided during xen patch review that xen map the iomem > transparently, so remove xen_set_clr_mmio_pvh_pte() and the sub > hypercall PHYSDEVOP_map_iomem. > G.. No Signed-off-by?? > --- > arch/x86/xen/mmu.c

Re: [PATCH] PVH linux: Use ballooning to allocate grant table pages

2013-02-06 Thread Konrad Rzeszutek Wilk
On Thu, Jan 31, 2013 at 06:30:15PM -0800, Mukesh Rathor wrote: > This patch fixes a fixme in Linux to use alloc_xenballooned_pages() to > allocate pfns for grant table pages instead of kmalloc. This also > simplifies add to physmap on the xen side a bit. Pulled this. > > Signed-off-by: Mukesh Rat

Re: [PATCH] xen-pciback: notify hypervisor about devices intended to be assigned to guests

2013-02-06 Thread Konrad Rzeszutek Wilk
On Wed, Feb 06, 2013 at 04:58:01PM +, Jan Beulich wrote: > For MSI-X capable devices the hypervisor wants to write protect the > MSI-X table and PBA, yet it can't assume that resources have been > assigned to their final values at device enumeration time. Thus have > pciback do that notificatio

[GIT PULL] (xen) stable/for-linus-3.8-rc6-tag

2013-02-06 Thread Konrad Rzeszutek Wilk
Hey Linus, Please git pull the following tag: git pull git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen.git stable/for-linus-3.8-rc6-tag Which has two fixes. One is a security fix wherein we would spam the kernel printk buffer if one of the guests was misbehaving. The other is much tame

Re: [PATCH] staging/zcache: Fix/improve zcache writeback code, tie to a config option

2013-02-12 Thread Konrad Rzeszutek Wilk
On Mon, Feb 11, 2013 at 01:43:58PM -0800, Dan Magenheimer wrote: > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > > So, how about this, please draw up a specific plan for how you are going > > to get this code out of drivers/staging/ I want to see the steps > > involved, who is going to

Re: [PATCH v5 4/8] staging: zcache: fix pers_pageframes|_max aren't exported in debugfs

2013-04-02 Thread Konrad Rzeszutek Wilk
patch add pers_pageframes|_max back. Duh! Thanks for spotting. Reviewed-by: Konrad Rzeszutek Wilk > > Signed-off-by: Wanpeng Li > --- > drivers/staging/zcache/debug.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/staging/zcache/de

Re: [PATCH v5 5/8] staging: zcache: fix zcache writeback in debugfs

2013-04-02 Thread Konrad Rzeszutek Wilk
that when I did the patches, but I wonder how I missed this. Ah, now I remember - I did a silly patch by adding in #define CONFIG_ZCACHE_WRITEBACK in the zcache-main.c code, but forgot to try it out here. Thank you for spotting and fixing it. Reviewed-by: Konrad Rzeszutek Wilk > Signed-o

Re: [PATCH v5 6/8] staging: zcache: fix static variables defined in debug.h but used in mutiple C files

2013-04-02 Thread Konrad Rzeszutek Wilk
On Mon, Apr 1, 2013 at 10:46 PM, Wanpeng Li wrote: > After commit 95bdaee214 ("zcache: Move debugfs code out of zcache-main.c > file") > be merged, most of knods in zcache debugfs just export zero since these > variables > are defined in debug.h but use in multiple C files zcache-main.c and debu

Re: [PATCH v5 7/8] staging: zcache: introduce zero-filled page stat count

2013-04-02 Thread Konrad Rzeszutek Wilk
> --- a/drivers/staging/zcache/zcache-main.c > +++ b/drivers/staging/zcache/zcache-main.c > @@ -176,6 +176,8 @@ ssize_t zcache_pers_ate_eph; > ssize_t zcache_pers_ate_eph_failed; > ssize_t zcache_evicted_eph_zpages; > ssize_t zcache_evicted_eph_pageframes; > +ssize_t zcache_zero_filled_pages; >

Re: [PATCH] xen: Don't call arch_trigger_all_cpu_backtrace in dom0(pvm)

2013-04-03 Thread Konrad Rzeszutek Wilk
On Wed, Apr 03, 2013 at 08:00:37PM +0800, Zhenzhong Duan wrote: > > On 2013-04-01 20:41, Konrad Rzeszutek Wilk wrote: > >On Mon, Apr 01, 2013 at 01:26:34PM +0800, Zhenzhong Duan wrote: > >>On 2013-03-29 21:46, Konrad Rzeszutek Wilk wrote: > >>>On Fri, Mar 29, 20

Re: [PATCH v2] drivers/block/xen-blkback: preq.dev is used without initialized

2013-04-03 Thread Konrad Rzeszutek Wilk
On Wed, Apr 03, 2013 at 03:34:16PM +0100, Jan Beulich wrote: > >>> On 03.04.13 at 15:56, William Dauchy wrote: > > On Wed, Apr 3, 2013 at 3:42 PM, Jan Beulich wrote: > >> ChangeLog-3.8.3 for example has > > > > oh sorry, you are right. I wasn't looking is the 3.8.x branch. > > The thing is, the

Re: [ 34/77] xen/blkback: Dont trust the handle from the frontend.

2013-04-03 Thread Konrad Rzeszutek Wilk
On Wed, Apr 03, 2013 at 09:01:06AM -0700, Greg Kroah-Hartman wrote: > On Wed, Apr 03, 2013 at 04:01:54PM +0200, William Dauchy wrote: > > On Tue, Mar 12, 2013 at 11:10 PM, Greg Kroah-Hartman > > wrote: > > >> > >> IOW I don't see why this got proposed for stable at all. > > >> > > > > >> > > So, y

Re: [PATCH v6 2/3] staging: zcache: introduce zero-filled page stat count

2013-04-03 Thread Konrad Rzeszutek Wilk
On Wed, Apr 3, 2013 at 6:16 AM, Wanpeng Li wrote: > Introduce zero-filled page statistics to monitor the number of > zero-filled pages. > > Acked-by: Dan Magenheimer > Signed-off-by: Wanpeng Li Reviewed-by: Konrad Rzeszutek Wilk > --- > drivers/staging/zcache

Re: [PATCH v6 1/3] staging: zcache: fix static variables defined in debug.h but used in mutiple C files

2013-04-03 Thread Konrad Rzeszutek Wilk
ple C files zcache-main.c and > debug.c, > in this case variables can't be treated as shared variables. > > Signed-off-by: Wanpeng Li Reviewed-by: Konrad Rzeszutek Wilk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [PATCH v3 21/22] x86, mm: Make init_mem_mapping be able to be called several times

2013-04-05 Thread Konrad Rzeszutek Wilk
Still only load_cr3 one time, otherwise we would break xen 64bit again. Nope. It should be fixed now. > > Signed-off-by: Yinghai Lu > Cc: Pekka Enberg > Cc: Jacob Shin > Cc: Konrad Rzeszutek Wilk > --- > arch/x86/include/asm/pgtable.h | 2 +- > arch/x86/ke

[PATCH 3/4] x86/xen/store_gdt: Remove the pvops variant of store_gdt.

2013-04-05 Thread Konrad Rzeszutek Wilk
platforms. Signed-off-by: Konrad Rzeszutek Wilk --- arch/x86/include/asm/paravirt.h | 4 arch/x86/include/asm/paravirt_types.h | 2 +- arch/x86/kernel/acpi/sleep.c | 2 +- arch/x86/kernel/doublefault_32.c | 2 +- arch/x86/kernel/paravirt.c| 1 - arch/x86/kvm/vmx.c

[PATCH 4/4] x86/wakeup/sleep: Use pvops functions for changing GDT entries.

2013-04-05 Thread Konrad Rzeszutek Wilk
The available 32-bit TSS (09h), which is redefined as the available 64-bit TSS." Without this, on Xen, where the GDT is available as R/O (to protect the hypervisor from the guest modifying it), we end up with a pagetable fault. Signed-off-by: Konrad Rzeszutek Wilk --- arch/x86/power/cpu.c | 9

[RFC PATCH] axe the store_gdt() pvops call. (v1)

2013-04-05 Thread Konrad Rzeszutek Wilk
arch/x86/kvm/vmx.c| 2 +- arch/x86/power/cpu.c | 13 +++-- arch/x86/xen/enlighten.c | 1 - 11 files changed, 11 insertions(+), 23 deletions(-) Konrad Rzeszutek Wilk (3): x86/gdt/64-bit: store/load GDT for ACPI S3 or hibernate/resu

[PATCH 1/4] x86/gdt/64-bit: store/load GDT for ACPI S3 or hibernate/resume path is not needed.

2013-04-05 Thread Konrad Rzeszutek Wilk
the same physical location as the the restored kernel. Note that the hibernation path assumes the GDT is correct during its 'restore_registers'. The assumption in the code is that the restored image is the same as saved - meaning we are not trying to restore an different kernel in the virtual add

[PATCH 2/4] x86/gdt/i386: store/load GDT for ACPI S3 or hibernation/resume path is not needed

2013-04-05 Thread Konrad Rzeszutek Wilk
ernel has already loaded the GDT which is at the same physical location as the the restored kernel. Note that the hibernation path assumes the GDT is correct during its 'restore_registers'. The assumption in the code is that the restored image is the same as saved - meaning we are not t

Re: [PATCHv3 1/6] debugfs: add get/set for atomic types

2013-01-29 Thread Konrad Rzeszutek Wilk
On Mon, Jan 28, 2013 at 03:49:22PM -0600, Seth Jennings wrote: > debugfs currently lack the ability to create attributes > that set/get atomic_t values. > > This patch adds support for this through a new > debugfs_create_atomic_t() function. > > Signed-off-by: Seth Jennings > Acked-by: Greg Kroa

Re: [PATCH 2/8] mm: frontswap: lazy initialization to allow tmem backends to build/run as modules

2013-01-30 Thread Konrad Rzeszutek Wilk
On Tue, Nov 27, 2012 at 04:26:17PM -0500, Konrad Rzeszutek Wilk wrote: > On Mon, Nov 19, 2012 at 02:25:16PM -0800, Andrew Morton wrote: > > On Mon, 19 Nov 2012 08:53:46 +0800 > > Bob Liu wrote: > > > > > On Sat, Nov 17, 2012 at 7:16 AM, Andrew Morton > > >

Re: [PATCH 1/8] mm: cleancache: lazy initialization to allow tmem backends to build/run as modules

2013-01-30 Thread Konrad Rzeszutek Wilk
On Fri, Nov 16, 2012 at 03:10:49PM -0800, Andrew Morton wrote: > On Wed, 14 Nov 2012 13:57:05 -0500 > Konrad Rzeszutek Wilk wrote: > > > From: Dan Magenheimer > > > > With the goal of allowing tmem backends (zcache, ramster, Xen tmem) to be > > built/loaded as

Re: [PATCHv2 1/9] staging: zsmalloc: add gfp flags to zs_create_pool

2013-01-30 Thread Konrad Rzeszutek Wilk
ap backends. > > How about this? > > From 157a3edf49feb93be0595574beb153b322ddf7d2 Mon Sep 17 00:00:00 2001 > From: Minchan Kim > Date: Mon, 28 Jan 2013 11:34:00 +0900 > Subject: [PATCH] frontswap: Get rid of swap_lock dependency > > Frontswap initializa

Re: [PATCH] staging: zsmalloc: remove unused pool name

2013-01-30 Thread Konrad Rzeszutek Wilk
On Wed, Jan 30, 2013 at 06:21:59PM +0100, Greg Kroah-Hartman wrote: > On Wed, Jan 30, 2013 at 09:41:55AM -0600, Seth Jennings wrote: > > On 01/30/2013 09:36 AM, Seth Jennings wrote:> zs_create_pool() > > currently takes a name argument which is > > > never used in any useful way. > > > > > > This p

Re: [PATCH] staging: zsmalloc: remove unused pool name

2013-01-31 Thread Konrad Rzeszutek Wilk
> > > {sigh} you just made me have to edit your patch by hand, you now owe me > > > a beer... > > > > > Should we codify that :-) > > > > > > diff --git a/Documentation/SubmittingPatches > > b/Documentation/SubmittingPatches > > index c379a2a..f879c60 100644 > > --- a/Documentation/SubmittingPa

Re: [PATCH] zsmalloc: Fix TLB coherency and build problem

2013-02-01 Thread Konrad Rzeszutek Wilk
loc: add page table mapping method > [2] https://github.com/spartacus06/zsmapbench > > Cc: sta...@vger.kernel.org > Cc: Dan Magenheimer > Cc: Russell King > Cc: Konrad Rzeszutek Wilk Acked-by: Konrad Rzeszutek Wilk > Cc: Nitin Gupta > Cc: Seth Jennings > Reported-by: Mat

[PATCH v2] Make frontswap+cleancache and its friend be modularized.

2013-02-01 Thread Konrad Rzeszutek Wilk
frontswap: lazy initialization to allow tmem backends to build/run as modules staging: zcache: enable ramster to be built/loaded as a module xen: tmem: enable Xen tmem shim to be built/loaded as a module Konrad Rzeszutek Wilk (10): frontswap: Make frontswap_init use a poi

  1   2   3   4   5   6   7   8   9   10   >