[RESEND PATCH v2] scsi: hpsa: fix memory leak in hpsa_init_one

Signed-off-by: Keita Suzuki --- drivers/scsi/hpsa.c | 52 +++-- 1 file changed, 27 insertions(+), 25 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 48d5da59262b..4911ca22efe4 100644 --- a/drivers/scsi/hpsa.c +++ b/driver

[RESEND PATCH] media: siano: fix memory leak of debugfs members in smsdvb_hotplug

graph()") Signed-off-by: Keita Suzuki --- drivers/media/common/siano/smsdvb-main.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/common/siano/smsdvb-main.c b/drivers/media/common/siano/smsdvb-main.c index 88f90dfd368b..ae17407e477a 100644 --- a/drivers/media/co

[PATCH] brcmsmac: fix potential memory leak in wlc_phy_attach_lcnphy

off-by: Keita Suzuki --- .../net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c| 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c in

[PATCH] brcmsmac: fix memory leak in wlc_phy_attach_lcnphy

off-by: Keita Suzuki --- .../net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c| 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c in

[PATCH] scsi: hpsa: fix memory leak in hpsa_init_one

When hpsa_scsi_add_host fails, h->lastlogicals is leaked since it lacks free in the error handler. Fix this by adding free when hpsa_scsi_add_host fails. Signed-off-by: Keita Suzuki --- drivers/scsi/hpsa.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/s

[PATCH v2] brcmsmac: fix memory leak in wlc_phy_attach_lcnphy

off-by: Keita Suzuki --- changelog(v2): change call from wlc_phy_detach_lcnphy() to kfree() .../net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c| 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c b/driv

[PATCH v2] scsi: hpsa: fix memory leak in hpsa_init_one

Signed-off-by: Keita Suzuki --- drivers/scsi/hpsa.c | 52 +++-- 1 file changed, 27 insertions(+), 25 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 48d5da59262b..4911ca22efe4 100644 --- a/drivers/scsi/hpsa.c +++ b/driver

Re: [PATCH] brcmsmac: fix memory leak in wlc_phy_attach_lcnphy

Thank you for your comment. I am relatively new to the Linux kernel community, so I am more than happy to receive comments. Please let me know if I'm violating any other rules. > > Signed-off-by: Keita Suzuki > > --- > ... changelog here describing difference between pre

[PATCH RFC] drm/nouveau: fix memory leak in nvkm_iccsense_oneinit

when exiting nvkm_iccsense_oneinit. Signed-off-by: Keita Suzuki --- drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense

Re: [RESEND PATCH v2] scsi: hpsa: fix memory leak in hpsa_init_one

Hi Martin, Thanks for the review. > I suggest you submit a fix for just the leak. And then, if the hpsa > maintainers agree, we can entertain a separate patch to improve the > naming. I'll revert the labels to numbered labels and resend the patch. Thanks, Keita 2020年10月27日(火) 6:49 Martin K. Pe

[PATCH v3] scsi: hpsa: fix memory leak in hpsa_init_one

When hpsa_scsi_add_host fails, h->lastlogicals is leaked since it lacks free in the error handler. Fix this by adding free when hpsa_scsi_add_host fails. Signed-off-by: Keita Suzuki --- v3: revert label name to numbered labels v2: rename labels drivers/scsi/hpsa.c | 4 +++- 1 file changed

[PATCH] i40e: Fix memory leak in i40e_probe

Struct i40e_veb is allocated in function i40e_setup_pf_switch, and stored to an array field veb inside struct i40e_pf. However when i40e_setup_misc_vector fails, this memory leaks. Fix this by calling exit and teardown functions. Signed-off-by: Keita Suzuki --- drivers/net/ethernet/intel/i40e

[PATCH] misc: rtsx: Fix memory leak in rtsx_pci_probe

When mfd_add_devices() fail, pcr->slots should also be freed. However, the current implementation does not free the member, leading to a memory leak. Fix this by adding a new goto label that frees pcr->slots. Signed-off-by: Keita Suzuki --- drivers/misc/cardreader/rtsx_pcr.c | 4 +++-

[PATCH] media: siano: fix memory leak of debugfs members in smsdvb_hotplug

graph()") Signed-off-by: Keita Suzuki --- drivers/media/common/siano/smsdvb-main.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/common/siano/smsdvb-main.c b/drivers/media/common/siano/smsdvb-main.c index 88f90dfd368b..ae17407e477a 100644 --- a/drivers/media/co

[PATCH] qedr: fix resource leak in qedr_create_qp

djust idr routines.") Signed-off-by: Keita Suzuki --- drivers/infiniband/hw/qedr/verbs.c | 48 -- 1 file changed, 25 insertions(+), 23 deletions(-) diff --git a/drivers/infiniband/hw/qedr/verbs.c b/drivers/infiniband/hw/qedr/verbs.c index b49bef94637e..19688773c

Re: [PATCH] qedr: fix resource leak in qedr_create_qp

Hi, Thank you for your comment. I will re-label the goto statements and post the patch as version 2. Thanks, Keita 2020年9月10日(木) 22:24 Markus Elfring : > > > Fix this by adding a new goto label that calls qedr_free_qp_resources. > > … > > +++ b/drivers/infiniband/hw/qedr/verbs.c > … > > @@ -2165

[PATCH v2] qedr: fix resource leak in qedr_create_qp

djust idr routines.") Signed-off-by: Keita Suzuki --- changelog(v2): Change numbered labels to descriptive labels drivers/infiniband/hw/qedr/verbs.c | 52 -- 1 file changed, 27 insertions(+), 25 deletions(-) diff --git a/drivers/infiniband/hw/qedr/verbs.c

[PATCH v3] qedr: fix resource leak in qedr_create_qp

djust idr routines.") Signed-off-by: Keita Suzuki --- changelog(v3): Fix linebreak of the fix tag changelog(v2): Change numbered labels to descriptive labels drivers/infiniband/hw/qedr/verbs.c | 52 -- 1 file changed, 27 insertions(+), 25 deletions(-) diff --git

Re: [PATCH] qedr: fix resource leak in qedr_create_qp

Hi, thank you for the comment. I will fix the line break and re-post the patch Thanks, Keita 2020年9月11日(金) 4:48 Markus Elfring : > > > I will re-label the goto statements and post the patch as version 2. > > Thanks for such a positive feedback. > > > Another suggestion: > > > > Fixes: 1212767e23b