[PATCH 1/2] ASoC: es8316: fix redundant codes of clock

2019-09-07 Thread Katsuhiro Suzuki
This patch removes redundant null checks for optional MCLK clock. And fix DT binding document for changing clock property to optional from required. Signed-off-by: Katsuhiro Suzuki --- .../bindings/sound/everest,es8316.txt | 3 ++ sound/soc/codecs/es8316.c | 31

[PATCH 2/2] ASoC: es8316: support fixed and variable both clock rates

2019-09-07 Thread Katsuhiro Suzuki
list does not allow 48kHz Signed-off-by: Katsuhiro Suzuki --- sound/soc/codecs/es8316.c | 35 --- 1 file changed, 20 insertions(+), 15 deletions(-) diff --git a/sound/soc/codecs/es8316.c b/sound/soc/codecs/es8316.c index 1424ecd6952c..36eef1fb3d18 100644 --- a/s

[PATCH] ASoC: rockchip: ignore 0Hz sysclk

2019-09-07 Thread Katsuhiro Suzuki
ned-off-by: Katsuhiro Suzuki --- sound/soc/rockchip/rockchip_i2s.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c index 88ebaf6e1880..af2d5a6124c8 100644 --- a/sound/soc/rockchip/rockchip_i2s.c +++ b/sound/soc/rockchip/rock

[PATCH] SoC: simple-card-utils: set 0Hz to sysclk when shutdown

2019-09-07 Thread Katsuhiro Suzuki
z (1/512) - Play 48kHz again, but it's NOT acceptable because constraints do not allow 48kHz So codecs treat 0Hz sysclk as signal of applying no constraints to avoid this problem. Signed-off-by: Katsuhiro Suzuki --- sound/soc/generic/simple-card-utils.c | 7 +++ 1 file changed, 7

[PATCH] arm64: dts: rockchip: add analog audio nodes on rk3399-rockpro64

2019-09-07 Thread Katsuhiro Suzuki
This patch adds audio codec (Everest ES8316) and I2S audio nodes for RK3399 RockPro64. Signed-off-by: Katsuhiro Suzuki --- .../boot/dts/rockchip/rk3399-rockpro64.dts| 28 +++ 1 file changed, 28 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts b

Re: [PATCH] SoC: simple-card-utils: set 0Hz to sysclk when shutdown

2019-09-08 Thread Katsuhiro Suzuki
aints of PCM rate by sysclk 32kHz (1/256), 21.33kHz (1/384), 16kHz (1/512) - Play 48kHz again, but it's NOT acceptable because constraints do not allow 48kHz So codecs treat 0Hz sysclk as signal of applying no constraints to avoid this problem. Signed-off-by: Katsuhiro

[PATCH 3/3] ASoC: es8316: add DT-bindings

2019-08-29 Thread Katsuhiro Suzuki
This patch adds missing DT-bindings document for Everest ES8316. Signed-off-by: Katsuhiro Suzuki --- .../bindings/sound/everest,es8316.txt | 20 +++ 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/everest,es8316.txt diff

[PATCH 2/3] ASoC: es8316: Add clock control of MCLK

2019-08-29 Thread Katsuhiro Suzuki
This patch introduce clock property for MCLK master freq control. Driver will set rate of MCLK master if set_sysclk is called and changing sysclk by board driver. Signed-off-by: Katsuhiro Suzuki --- sound/soc/codecs/es8316.c | 20 1 file changed, 20 insertions(+) diff

[PATCH 1/3] ASoC: es8316: judge PCM rate at later timing

2019-08-29 Thread Katsuhiro Suzuki
sclk timing. It seems that is too early to determine. So this patch does not use constraints list and check PCM rate limit more later timing at hw_params. Signed-off-by: Katsuhiro Suzuki --- sound/soc/codecs/es8316.c | 37 +++-- 1 file changed, 15 insertions(+

Re: [alsa-devel] [PATCH 2/3] ASoC: es8316: Add clock control of MCLK

2019-08-31 Thread Katsuhiro Suzuki
Hello Mark, On 2019/08/30 20:18, Mark Brown wrote: On Fri, Aug 30, 2019 at 02:32:04AM +0900, Katsuhiro Suzuki wrote: + es8316->mclk = devm_clk_get(component->dev, "mclk"); + if (PTR_ERR(es8316->mclk) == -EPROBE_DEFER) + return -EPROBE_DEFER; If w

[PATCH v2 2/3] ASoC: es8316: Add clock control of MCLK

2019-08-31 Thread Katsuhiro Suzuki
This patch introduce clock property for MCLK master freq control. Driver will set rate of MCLK master if set_sysclk is called and changing sysclk by board driver. Signed-off-by: Katsuhiro Suzuki --- Changes from v1: - Output logs if clock error is found - Disable and unprepare mclk when

[PATCH v2 3/3] ASoC: es8316: add DT-bindings

2019-08-31 Thread Katsuhiro Suzuki
This patch adds missing DT-bindings document for Everest ES8316. Signed-off-by: Katsuhiro Suzuki --- .../bindings/sound/everest,es8316.txt | 20 +++ 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/everest,es8316.txt diff

[PATCH v2 1/3] ASoC: es8316: judge PCM rate at later timing

2019-08-31 Thread Katsuhiro Suzuki
sclk timing. It seems that is too early to determine. So this patch does not use constraints list and check PCM rate limit more later timing at hw_params. Signed-off-by: Katsuhiro Suzuki --- sound/soc/codecs/es8316.c | 37 +++-- 1 file changed, 15 insertions(+

Re: [PATCH v2 1/3] ASoC: es8316: judge PCM rate at later timing

2019-09-02 Thread Katsuhiro Suzuki
Hello Mark, Thanks a lot for your comments. On 2019/09/02 21:02, Mark Brown wrote: On Sun, Sep 01, 2019 at 01:26:48AM +0900, Katsuhiro Suzuki wrote: This patch change the judge timing about playing/capturing PCM rate. Original code set constraints list of PCM rate limits at set_sysclk. This

Re: [PATCH v2 1/3] ASoC: es8316: judge PCM rate at later timing

2019-09-03 Thread Katsuhiro Suzuki
Hello Mark, On 2019/09/03 20:11, Mark Brown wrote: On Tue, Sep 03, 2019 at 04:19:10AM +0900, Katsuhiro Suzuki wrote: On 2019/09/02 21:02, Mark Brown wrote: The best way to handle this is to try to support both fixed and variable clock rates, some other drivers do this by setting constraints

[PATCH v3 2/4] ASoC: es8316: add clock control of MCLK

2019-09-03 Thread Katsuhiro Suzuki
This patch introduce clock property for MCLK master freq control. Driver will set rate of MCLK master if set_sysclk is called and changing sysclk by board driver. Signed-off-by: Katsuhiro Suzuki --- Changes from v1: - Output logs if clock error is found - Disable and unprepare mclk when

[PATCH v3 1/4] ASoC: es8316: judge PCM rate at later timing

2019-09-03 Thread Katsuhiro Suzuki
sclk timing. It seems that is too early to determine. So this patch does not use constraints list and check PCM rate limit more later timing at hw_params. Signed-off-by: Katsuhiro Suzuki --- sound/soc/codecs/es8316.c | 37 +++-- 1 file changed, 15 insertions(+

[PATCH v3 3/4] ASoC: es8316: support fixed clock rate

2019-09-03 Thread Katsuhiro Suzuki
This patch supports some type of machine drivers that use fixed clock rate. After applied this patch, sysclk == 0 means there is no constraint of sound rate and other values will set constraints which is derived by sysclk setting. Signed-off-by: Katsuhiro Suzuki --- Changes from v2: - Newly

[PATCH v3 4/4] ASoC: es8316: add DT-bindings

2019-09-03 Thread Katsuhiro Suzuki
This patch adds missing DT-bindings document for Everest ES8316. Signed-off-by: Katsuhiro Suzuki --- .../bindings/sound/everest,es8316.txt | 20 +++ 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/everest,es8316.txt diff

[PATCH] ASoC: es8316: limit headphone mixer volume

2019-08-24 Thread Katsuhiro Suzuki
This patch limits Headphone mixer volume to 4 from 7. Because output sound suddenly becomes very loudly with many noise if set volume over 4. Signed-off-by: Katsuhiro Suzuki --- sound/soc/codecs/es8316.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/es8316

Re: [PATCH] ASoC: es8316: limit headphone mixer volume

2019-08-26 Thread Katsuhiro Suzuki
Hello Daniel, On 2019/08/26 11:53, Daniel Drake wrote: On Mon, Aug 26, 2019 at 1:38 AM Hans de Goede wrote: On 24-08-19 23:04, Katsuhiro Suzuki wrote: This patch limits Headphone mixer volume to 4 from 7. Because output sound suddenly becomes very loudly with many noise if set volume over 4

Re: [PATCH] ASoC: es8316: limit headphone mixer volume

2019-08-26 Thread Katsuhiro Suzuki
er_gain_tlv), is correct. Best Regards, Katsuhiro Suzuki On 2019/08/26 17:41, Katsuhiro Suzuki wrote: Hello Daniel, On 2019/08/26 11:53, Daniel Drake wrote: On Mon, Aug 26, 2019 at 1:38 AM Hans de Goede wrote: On 24-08-19 23:04, Katsuhiro Suzuki wrote: This patch limits Headphone mixer vo

Re: [PATCH] ASoC: es8316: limit headphone mixer volume

2019-08-26 Thread Katsuhiro Suzuki
Hello Hans, Daniel, Thank you for reviewing and comment. On 2019/08/26 18:09, Hans de Goede wrote: Hi, On 26-08-19 04:53, Daniel Drake wrote: On Mon, Aug 26, 2019 at 1:38 AM Hans de Goede wrote: On 24-08-19 23:04, Katsuhiro Suzuki wrote: This patch limits Headphone mixer volume to 4 from

[PATCH v2 1/2] ASoC: es8316: fix headphone mixer volume table

2019-08-26 Thread Katsuhiro Suzuki
: Katsuhiro Suzuki --- sound/soc/codecs/es8316.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/es8316.c b/sound/soc/codecs/es8316.c index 8dfb5dbeebbf..f97d9c5210f0 100644 --- a/sound/soc/codecs/es8316.c +++ b/sound/soc/codecs/es8316.c @@ -53,7 +53,10

[PATCH v2 2/2] ASoC: es8316: fix inverted L/R of headphone mixer volume

2019-08-26 Thread Katsuhiro Suzuki
This patch fixes inverted Left-Right channel of headphone mixer volume by wrong shift_left, shift_right values. Signed-off-by: Katsuhiro Suzuki --- sound/soc/codecs/es8316.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/es8316.c b/sound/soc/codecs/es8316.c

Re: [PATCH v3 1/4] ASoC: es8316: judge PCM rate at later timing

2019-09-04 Thread Katsuhiro Suzuki
Hello Mark, On 2019/09/04 2:48, Mark Brown wrote: On Wed, Sep 04, 2019 at 01:53:19AM +0900, Katsuhiro Suzuki wrote: Root cause of this strange behavior is changing constraints list at set_sysclk timing. It seems that is too early to determine. So this patch does not use constraints list and

Re: [PATCH v3 2/4] ASoC: es8316: add clock control of MCLK

2019-09-04 Thread Katsuhiro Suzuki
Hello Andy, Thank you for reviewing. On 2019/09/04 23:37, Andy Shevchenko wrote: On Tue, Sep 3, 2019 at 7:54 PM Katsuhiro Suzuki wrote: This patch introduce clock property for MCLK master freq control. Driver will set rate of MCLK master if set_sysclk is called and changing sysclk by board

Re: [PATCH v3 1/4] ASoC: es8316: judge PCM rate at later timing

2019-09-04 Thread Katsuhiro Suzuki
On 2019/09/05 0:30, Mark Brown wrote: On Thu, Sep 05, 2019 at 12:06:23AM +0900, Katsuhiro Suzuki wrote: Would you tell me one more thing. I don't understand who sets MCLK to 0. Is it needed original machine driver instead of audio-graph-card? On my test environment (audio-graph

Re: [PATCH] arm64: dts: rockchip: add analog audio nodes on rk3399-rockpro64

2019-10-04 Thread Katsuhiro Suzuki
Past about 1 month, so I send a ping... On 2019/09/08 2:48, Katsuhiro Suzuki wrote: This patch adds audio codec (Everest ES8316) and I2S audio nodes for RK3399 RockPro64. Signed-off-by: Katsuhiro Suzuki --- .../boot/dts/rockchip/rk3399-rockpro64.dts| 28 +++ 1 file

[PATCH 2/2] arm64: dts: rockchip: fix cts, rts pin assign of UART3 for rk3399

2019-02-19 Thread Katsuhiro Suzuki
This patch fixes pin assign of cts and rts signal of UART3. Currently GPIO3_C2 and C3 pins are assigned but TRM says that GPIO3_C0 and C1 are correct. Refer: RK3399 TRM v1.4 - Table 19-1 UART Interface Description Signed-off-by: Katsuhiro Suzuki --- arch/arm64/boot/dts/rockchip/rk3399.dtsi

[PATCH 1/2] arm64: dts: rockchip: replace GPIO number into macro for rk3399

2019-02-19 Thread Katsuhiro Suzuki
This patch just replace some absolute GPIO numbers of I2C, I2S, UART, SPDIF, SPI and so on for rk3399 devicetree into RK_PXn macro for more readability. Signed-off-by: Katsuhiro Suzuki --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 236 +++ 1 file changed, 118 insertions

[PATCH] arm64: dts: rockchip: enable hdmi audio out for rk3399-rockpro64

2019-02-20 Thread Katsuhiro Suzuki
The rockpro64 has hdmi support. So this patch enables hdmi audio feature that is defined in rk3399 devicetree. Signed-off-by: Katsuhiro Suzuki --- arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399

Re: [PATCH v2] clk: fractional-divider: check parent rate only if flag is set

2019-02-20 Thread Katsuhiro Suzuki
Ping... On 2019/02/11 0:38, Katsuhiro Suzuki wrote: Custom approximation of fractional-divider may not need parent clock rate checking. For example Rockchip SoCs work fine using grand parent clock rate even if target rate is greater than parent. This patch checks parent clock rate only if

[PATCH v2] clk: fractional-divider: check parent rate only if flag is set

2019-02-10 Thread Katsuhiro Suzuki
time. If apply this commit, clk_fd_round_rate() calls custom approximate function of Rockchip even if target rate is higher than parent. Custom function changes both grand parent (i2s1_div) and parent (i2s_frac) settings at same time. Clock mux system can choose i2s1_frac and audio works fi

Re: [PATCH] clk: fractional-divider: check parent rate only for general approximation

2019-02-10 Thread Katsuhiro Suzuki
Hello Stephen, Thanks a lot for your review. I choose clk_hw_can_set_parent_rate() macro and fix typo and patch description. And I post v2 patch. Best Regards, Katsuhiro Suzuki On 2019/02/07 4:40, Stephen Boyd wrote: +Heiko because it mentions Rockchip Quoting Katsuhiro Suzuki (2019-01-30 15

[PATCH] arm64: dts: rockchip: add HDMI sound node for rk3328-rock64

2019-02-01 Thread Katsuhiro Suzuki
DMAC has only 1 channel. UART2 can work without DMA resources, so this patch removes dma allocation for UART2 and reuses it to I2S0. Signed-off-by: Katsuhiro Suzuki --- .../arm64/boot/dts/rockchip/rk3328-rock64.dts | 24 ++- arch/arm64/boot/dts/rockchip/rk3328.dtsi | 1 + 2

Re: [PATCH] arm64: dts: rockchip: add HDMI sound node for rk3328-rock64

2019-02-04 Thread Katsuhiro Suzuki
Hello Heiko, On 2019/02/03 18:06, Heiko Stuebner wrote: Am Samstag, 2. Februar 2019, 05:34:44 CET schrieb Katsuhiro Suzuki: This patch adds HDMI sound (I2S0) node and remove dma properties from UART2 node for rock64. The DMAC of rk3328 can use 8 channels at same time. Currently, total 7

[PATCH] arm64: dts: rockchip: add PCIe nodes on rk3399-rockpro64

2019-05-09 Thread Katsuhiro Suzuki
This patch adds PCIe, PCIe phy and pinctrl (for PERST#) nodes for RockPro64 board. Signed-off-by: Katsuhiro Suzuki --- .../boot/dts/rockchip/rk3399-rockpro64.dts | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts b/arch

[PATCH] arm64: dts: rockchip: fix cts, rts pin assign of UART3 for rk3399

2019-04-06 Thread Katsuhiro Suzuki
This patch fixes pin assign of cts and rts signal of UART3. Currently GPIO3_C2 and C3 pins are assigned but TRM says that GPIO3_C0 and C1 are correct. Refer: RK3399 TRM v1.4 - Table 19-1 UART Interface Description Signed-off-by: Katsuhiro Suzuki --- arch/arm64/boot/dts/rockchip/rk3399.dtsi

Re: [PATCH] ARM: dts: rockchip: add ethernet phy node for tinker board

2019-06-22 Thread Katsuhiro Suzuki
my Tinker Board worked correctly if use it. I have not bisect commit of root cause yet... Is it better to bisect and find problem instead of sending this patch? Best Regards, --- Katsuhiro Suzuki On 2019/06/22 17:33, Heiko Stuebner wrote: Hi, Am Freitag, 21. Juni 2019, 20:00:17 CEST schrieb Katsuh

Re: [PATCH] ARM: dts: rockchip: add ethernet phy node for tinker board

2019-06-23 Thread Katsuhiro Suzuki
Hello Heiko, Andrew, Thank you for comments. I found the commit that has regression: 74371272f97f net: stmmac: Convert to phylink and remove phylib logic So I'll report it to netdev and stmmac guys. Best Regards, --- Katsuhiro Suzuki On 2019/06/23 2:55, Andrew Lunn wrote: On Sat, J

stmmac regression on ASUS TinkerBoard

2019-06-23 Thread Katsuhiro Suzuki
his commit broke the device-trees such as TinkerBoard. The mdio subnode creating a mdio bus is changed to required or still optional? Best Regards, Katsuhiro Suzuki

Re: [PATCH net-next] net: stmmac: Fix the case when PHY handle is not present

2019-06-25 Thread Katsuhiro Suzuki
Hello Jose, This patch works fine with my Tinker Board. Thanks a lot! Tested-by: Katsuhiro Suzuki BTW, from network guys point of view, is it better to add a phy node into device trees that have no phy node such as the Tinker Board? Best Regards, Katsuhiro Suzuki On 2019/06/25 22:11

Re: [PATCH net-next] net: stmmac: Fix the case when PHY handle is not present

2019-06-25 Thread Katsuhiro Suzuki
Hello Andrew, On 2019/06/25 23:51, Andrew Lunn wrote: On Tue, Jun 25, 2019 at 11:40:00PM +0900, Katsuhiro Suzuki wrote: Hello Jose, This patch works fine with my Tinker Board. Thanks a lot! Tested-by: Katsuhiro Suzuki BTW, from network guys point of view, is it better to add a phy node

Re: [PATCH] arm64: dts: rockchip: Fix vcc_host1_5v GPIO polarity on rk3328-rock64

2019-03-08 Thread Katsuhiro Suzuki
&usb20_host_drv>; regulator-name = "vcc_host1_5v"; After this patch applied, USB and S/PDIF both work well. Tested-by: Katsuhiro Suzuki $ lsusb Bus 003 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub Bus 002 Device 001: ID 1d6b:0002 Linux Foundation

[PATCH] arm64: dts: rockchip: add rk3399 UART DMAs

2019-03-21 Thread Katsuhiro Suzuki
Add UART dma channels as specified by the rk3399 TRM. Refer: RK3399 TRM V1.4: Chapter 12 DMA Controller Signed-off-by: Katsuhiro Suzuki --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch

Re: [PATCH v3 2/2] arm64: dts: rockchip: add HDMI sound node for rk3328-rock64

2019-03-21 Thread Katsuhiro Suzuki
x27;t consider about Non-LPCM sound. I understand your concern. My patch should be keeping until this problem is solved. I'm going to find test environment and try KODI or mpv. Thank you for great information! Best Regards, Katsuhiro Suzuki Regards, Jonas On 2019-03-17 10:54, Katsuhir

Re: [PATCH 2/2] arm64: dts: rockchip: fix cts, rts pin assign of UART3 for rk3399

2019-03-21 Thread Katsuhiro Suzuki
ping again... Please let me know if there is problem in this patch. On 2019/03/04 23:00, Katsuhiro Suzuki wrote: ping... On 2019/02/19 23:08, Katsuhiro Suzuki wrote: This patch fixes pin assign of cts and rts signal of UART3. Currently GPIO3_C2 and C3 pins are assigned but TRM says that

Re: [PATCH] arm64: dts: rockchip: add rk3399 UART DMAs

2019-03-21 Thread Katsuhiro Suzuki
Hello Robin, On 2019/03/22 0:21, Robin Murphy wrote: On 21/03/2019 14:40, Katsuhiro Suzuki wrote: Add UART dma channels as specified by the rk3399 TRM. No UART4? That's arguably one of the more useful ones, since 1 and 3 often end up muxed to ethernet instead. Oops... I forgot t

[PATCH v2] arm64: dts: rockchip: add rk3399 UART DMAs

2019-03-21 Thread Katsuhiro Suzuki
Add UART dma channels as specified by the rk3399 TRM. Refer: RK3399 TRM V1.4: Chapter 12 DMA Controller Signed-off-by: Katsuhiro Suzuki --- Changes from v1: - Add dma property for UART4 --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff

Re: [PATCH] arm64: dts: rockchip: add HDMI sound node for rk3328-rock64

2019-02-17 Thread Katsuhiro Suzuki
Hello Heiko, On 2019/02/12 20:12, Heiko Stübner wrote: Hi, Am Montag, 4. Februar 2019, 13:59:37 CET schrieb Katsuhiro Suzuki: On 2019/02/03 18:06, Heiko Stuebner wrote: Am Samstag, 2. Februar 2019, 05:34:44 CET schrieb Katsuhiro Suzuki: This patch adds HDMI sound (I2S0) node and remove dma

[PATCH v3 2/2] arm64: dts: rockchip: add HDMI sound node for rk3328-rock64

2019-02-17 Thread Katsuhiro Suzuki
If I2S0 is simply activated by this patch, required DMAC channels will be 9. So last one (UART2) cannot allocate the DMA resources. Virt-dma mechanism for pl0330 DMAC driver is needed to fix this problem. Signed-off-by: Katsuhiro Suzuki --- .../arm64/boot/dts/rockchip/rk3328-rock6

[PATCH v3 1/2] arm64: dts: rockchip: add #sound-dai-cells to HDMI of rk3328

2019-02-17 Thread Katsuhiro Suzuki
This patch adds #sound-dai-cells to use HDMI node as audio codec from device tree of rk3328 boards. Signed-off-by: Katsuhiro Suzuki --- arch/arm64/boot/dts/rockchip/rk3328.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts

Re: [PATCH] arm64: dts: rockchip: decrease rising edge time of UART2

2019-03-03 Thread Katsuhiro Suzuki
Hello Tony, On 2019/03/04 0:13, Tony McKahan wrote: On Sun, Mar 3, 2019 at 9:04 AM Katsuhiro Suzuki wrote: Hello Heiko, Thank you for comments. On 2019/03/03 22:19, Heiko Stuebner wrote: Hi, Am Sonntag, 3. März 2019, 13:27:05 CET schrieb Katsuhiro Suzuki: This patch increases drive

Re: [PATCH] arm64: dts: rockchip: decrease rising edge time of UART2

2019-03-04 Thread Katsuhiro Suzuki
No problem! Thank you for discussion :) On 2019/03/04 4:12, Tony McKahan wrote: On Sun, Mar 3, 2019 at 1:45 PM Tony McKahan wrote: Hello Katsushiro, And apologies for the extra "s", typing too quickly I'm afraid. On Sun, Mar 3, 2019 at 12:31 PM Katsuhiro Suzuki wrot

Re: [PATCH] arm64: dts: rockchip: decrease rising edge time of UART2

2019-03-04 Thread Katsuhiro Suzuki
Hello Tony, Robin, On 2019/03/04 5:41, Tony McKahan wrote: On Sun, Mar 3, 2019 at 2:51 PM Robin Murphy wrote: On 2019-03-03 6:45 pm, Tony McKahan wrote: Hello Katsushiro, On Sun, Mar 3, 2019 at 12:31 PM Katsuhiro Suzuki wrote: Hello Tony, On 2019/03/04 0:13, Tony McKahan wrote: On Sun

Re: [PATCH v3 1/2] arm64: dts: rockchip: add #sound-dai-cells to HDMI of rk3328

2019-03-04 Thread Katsuhiro Suzuki
Hello Heiko, On 2019/03/03 22:55, Heiko Stuebner wrote: Am Sonntag, 17. Februar 2019, 18:34:06 CET schrieb Katsuhiro Suzuki: This patch adds #sound-dai-cells to use HDMI node as audio codec from device tree of rk3328 boards. Signed-off-by: Katsuhiro Suzuki applied for 5.2 . I'm ho

Re: [PATCH 2/2] arm64: dts: rockchip: fix cts, rts pin assign of UART3 for rk3399

2019-03-04 Thread Katsuhiro Suzuki
ping... On 2019/02/19 23:08, Katsuhiro Suzuki wrote: This patch fixes pin assign of cts and rts signal of UART3. Currently GPIO3_C2 and C3 pins are assigned but TRM says that GPIO3_C0 and C1 are correct. Refer: RK3399 TRM v1.4 - Table 19-1 UART Interface Description Signed-off-by

[PATCH] ASoC: uniphier: change status to orphan

2018-09-05 Thread Katsuhiro Suzuki
Since I'm leaving from Socionext, I'll unable to access specification documents of this hardware (these are not public). So change the state to orphan until someone will maintain this driver. Signed-off-by: Katsuhiro Suzuki --- MAINTAINERS | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH] arm64: dts: rockchip: fix vcc_host1_5v pin assign

2018-09-06 Thread Katsuhiro Suzuki
-off-by: Katsuhiro Suzuki --- arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts index 5272e887a434..5852061e497b 100644 --- a/arch

[PATCH] arm64: dts: rockchip: add i2s and spdif endpoint of rk3328

2018-09-06 Thread Katsuhiro Suzuki
This patch adds port and endpoint of i2s and spdif nodes for rk3328. Because to use modern sound card interface such as audio-graph-card. Signed-off-by: Katsuhiro Suzuki --- arch/arm64/boot/dts/rockchip/rk3328.dtsi | 24 1 file changed, 24 insertions(+) diff --git a

Re: [PATCH] arm64: dts: rockchip: add i2s and spdif endpoint of rk3328

2018-09-10 Thread Katsuhiro Suzuki
Hi Heiko, On 2018年09月10日 22:57, Heiko Stuebner wrote: Hi, Am Donnerstag, 6. September 2018, 18:39:56 CEST schrieb Katsuhiro Suzuki: This patch adds port and endpoint of i2s and spdif nodes for rk3328. Because to use modern sound card interface such as audio-graph-card. Signed-off-by

[PATCH] arm64: dts: rockchip: add i2s and spdif endpoints of rk3328

2018-09-10 Thread Katsuhiro Suzuki
This patch adds port and endpoint of i2s and spdif nodes for rk3328. Because to use modern sound card interface such as audio-graph-card. Signed-off-by: Katsuhiro Suzuki --- arch/arm64/boot/dts/rockchip/rk3328.dtsi | 24 1 file changed, 24 insertions(+) diff --git a

Re: [PATCH] arm64: dts: rockchip: add i2s and spdif endpoints of rk3328

2018-09-10 Thread Katsuhiro Suzuki
Ugh, sorry. I got mistake. This is 'v2' patch. On 2018年09月11日 01:10, Katsuhiro Suzuki wrote: This patch adds port and endpoint of i2s and spdif nodes for rk3328. Because to use modern sound card interface such as audio-graph-card. Signed-off-by: Katsuhiro Suzuki --- arch/arm6

[PATCH] ASoC: rockchip: add missing INTERLEAVED PCM attribute

2018-09-10 Thread Katsuhiro Suzuki
This patch adds SNDRV_PCM_INFO_INTERLEAVED into PCM hardware info. Signed-off-by: Katsuhiro Suzuki --- sound/soc/rockchip/rockchip_pcm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/rockchip/rockchip_pcm.c b/sound/soc/rockchip/rockchip_pcm.c index

[PATCH] ASoC: audio-graph-card: add hp and mic detect gpios same as simple-card

2018-06-08 Thread Katsuhiro Suzuki
This patch adds headphone and microphone jack detection gpios as same as simple-card driver. This feature move into simple-card-utils from simple-card to avoid the duplicating code. Signed-off-by: Katsuhiro Suzuki --- include/sound/simple_card_utils.h | 15 +++ sound/soc/generic/audio

Re: [PATCH] ASoC: audio-graph-card: add hp and mic detect gpios same as simple-card

2018-06-10 Thread Katsuhiro Suzuki
s same > > as simple-card driver. This feature move into simple-card-utils from > > simple-card to avoid the duplicating code. > > > > Signed-off-by: Katsuhiro Suzuki > > --- > > I think it can be 2 patches ? > 1. move function from simple-card to simple-card

Re: [alsa-devel] [PATCH] ASoC: audio-graph-card: add hp and mic detect gpios same as simple-card

2018-06-10 Thread Katsuhiro Suzuki
avoid the duplicating code. Signed-off-by: Katsuhiro Suzuki --- I think it can be 2 patches ? 1. move function from simple-card to simple-card-utils 2. use it from audio-graph-card OK, I'll split this patch. +static int asoc_graph_soc_card_probe(struct snd_soc_card

[PATCH v2 1/3] ASoC: simple-card-utils: move hp and mic detect gpios from simple-card

2018-06-10 Thread Katsuhiro Suzuki
This patch moves headphone and microphone jack detection gpios from simple-card driver. It is preparing for using this feature from other drivers. Signed-off-by: Katsuhiro Suzuki --- Changes from v1: - Move changes of audio-graph-card to other patch --- include/sound/simple_card_utils.h

[PATCH v2 3/3] ASoC: audio-graph-card: add hp and mic detect gpios same as simple-card

2018-06-10 Thread Katsuhiro Suzuki
This patch adds headphone and microphone jack detection gpios as same as simple-card driver. Signed-off-by: Katsuhiro Suzuki --- Changes from v1: - Move changes of audio-graph-card to other patch --- sound/soc/generic/audio-graph-card.c | 20 +++- 1 file changed, 19

[PATCH v2 2/3] ASoC: simple-card: move hp and mic detection to soc_card probe

2018-06-10 Thread Katsuhiro Suzuki
This patch moves headphone and microphone detection to probe() of snd_soc_card from init() of snd_soc_dai_link. This is because init() is called (and an input device /dev/input/eventX is created too) twice or above if simple card has two or more DAI links. Signed-off-by: Katsuhiro Suzuki

Re: [PATCH v2 2/3] ASoC: simple-card: move hp and mic detection to soc_card probe

2018-06-10 Thread Katsuhiro Suzuki
ause init() > > is called (and an input device /dev/input/eventX is created too) > > twice or above if simple card has two or more DAI links. > > > > Signed-off-by: Katsuhiro Suzuki > > or above ? > It seems if simple card has multiple DAI links, it creates multi

[PATCH v3 1/3] ASoC: simple-card-utils: move hp and mic detect gpios from simple-card

2018-06-11 Thread Katsuhiro Suzuki
This patch moves headphone and microphone jack detection gpios from simple-card driver. It is preparing for using this feature from other drivers. Signed-off-by: Katsuhiro Suzuki --- Changes from v2: - Nothing Changes from v1: - Move changes of audio-graph-card to other patch --- include

[PATCH v3 3/3] ASoC: audio-graph-card: add hp and mic detect gpios same as simple-card

2018-06-11 Thread Katsuhiro Suzuki
This patch adds headphone and microphone jack detection gpios as same as simple-card driver. Signed-off-by: Katsuhiro Suzuki --- Changes from v2: - Nothing Changes from v1: - Move changes of audio-graph-card to other patch --- sound/soc/generic/audio-graph-card.c | 20

[PATCH v3 2/3] ASoC: simple-card: move hp and mic detection to soc_card probe

2018-06-11 Thread Katsuhiro Suzuki
This patch moves headphone and microphone detection to probe() of snd_soc_card from init() of snd_soc_dai_link. This is because init() is called (and an input device /dev/input/eventX is created too) twice or above if simple card has two or more DAI links. Signed-off-by: Katsuhiro Suzuki

[PATCH] arm64: dts: uniphier: add syscon property for UniPhier sound system

2018-03-18 Thread Katsuhiro Suzuki
This patch adds syscon property for specifying soc-glue core into device-tree of LD11/LD20 SoC. Currently, soc-glue core is used for changing the state of S/PDIF signal output pin to signal output state or Hi-Z state. Signed-off-by: Katsuhiro Suzuki --- arch/arm/boot/dts/uniphier-pxs2.dtsi

Re: [PATCH] ASoC: uniphier: evea: add switch for changing source of line-in

2018-03-18 Thread Katsuhiro Suzuki
ernel@vger.kernel.org > Subject: Re: [PATCH] ASoC: uniphier: evea: add switch for changing source of line-in > > On Wed, Mar 14, 2018 at 09:39:00PM +0900, Katsuhiro Suzuki wrote: > > This patch adds mixer switch for changing audio source of line-in. > > We can choose one of LIN1,

[PATCH 0/2] add syscon property to binding document

2018-03-16 Thread Katsuhiro Suzuki
fixedly. This patch removes dependencies of bootloader from UniPhier audio system driver. Katsuhiro Suzuki (2): ASoC: uniphier: add syscon property to binding document ASoC: uniphier: add syscon property for UniPhier sound system .../devicetree/bindings/sound/uniphier,aio.txt | 8

[PATCH 2/2] ASoC: uniphier: add syscon property for UniPhier sound system

2018-03-16 Thread Katsuhiro Suzuki
available. Signed-off-by: Katsuhiro Suzuki --- sound/soc/uniphier/aio-core.c | 21 + sound/soc/uniphier/aio-cpu.c | 11 +++ sound/soc/uniphier/aio-reg.h | 3 +++ sound/soc/uniphier/aio.h | 2 ++ 4 files changed, 37 insertions(+) diff --git a/sound/soc/uniphier

[PATCH 1/2] ASoC: uniphier: add syscon property to binding document

2018-03-16 Thread Katsuhiro Suzuki
this property. Signed-off-by: Katsuhiro Suzuki --- Documentation/devicetree/bindings/sound/uniphier,aio.txt | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/uniphier,aio.txt b/Documentation/devicetree/bindings/sound/uniphier,aio.txt index 65d71cf

[PATCH] ASoC: uniphier: add digital output volume for UniPhier sound system

2018-05-07 Thread Katsuhiro Suzuki
This patch adds controllers for digital volume of PCM output. Volume effects simply linear, not dB scale as follows: Gained PCM = Original * 0x4000 / Volume The value range of volume is from 0x0001 to 0x. 0x works as mute. Initial value is 0x4000 (+0dB). Signed-off-by: Katsuhiro Suzuki

[PATCH] ASoC: uniphier: evea: use DAPM to change source of line-in

2018-05-08 Thread Katsuhiro Suzuki
This patch replaces mixer switch to DAPM one for changing audio source of line-in. Signed-off-by: Katsuhiro Suzuki --- sound/soc/uniphier/evea.c | 55 +++ 1 file changed, 33 insertions(+), 22 deletions(-) diff --git a/sound/soc/uniphier/evea.c b/sound/soc

[PATCH] dt-bindings: sound: convert ROHM BD28623 amplifier binding to yaml

2020-07-14 Thread Katsuhiro Suzuki
This patch converts ROHM BD28623UMV class D speaker amplifier binding to DT schema. Signed-off-by: Katsuhiro Suzuki --- .../bindings/sound/rohm,bd28623.txt | 29 - .../bindings/sound/rohm,bd28623.yaml | 65 +++ 2 files changed, 65 insertions(+), 29

[PATCH v3] arm64: dts: rockchip: add SPDIF node for rk3399-rockpro64

2020-10-05 Thread Katsuhiro Suzuki
9 has only 6 DMA channels. So users have to choose from the following: - Disable one of I2S (Ex. I2S0) and enable SPDIF tx - Keep enable I2S0/1/2 and disable SPDIF tx Signed-off-by: Katsuhiro Suzuki --- Changes in v3: - Refine commit description why adding disabled node Changes in v2:

Re: [PATCH v2] arm64: dts: rockchip: add SPDIF node for rk3399-rockpro64

2020-08-30 Thread Katsuhiro Suzuki
Hello Heiko, On 2020/08/31 4:08, Heiko Stuebner wrote: Hi, Am Montag, 10. August 2020, 11:16:19 CEST schrieb Katsuhiro Suzuki: This patch adds 'disabled' SPDIF sound node and related settings for rk3399-rockpro64. There are 2 reasons: - All RK3399 dma-bus channels have been al

Re: [PATCH v2] arm64: dts: rockchip: enable HDMI sound nodes for rk3328-rock64

2020-08-30 Thread Katsuhiro Suzuki
On 2020/08/31 4:16, Heiko Stuebner wrote: Hi, Am Sonntag, 2. August 2020, 17:42:31 CEST schrieb Katsuhiro Suzuki: This patch enables HDMI sound (I2S0) and Analog sound (I2S1) which are defined in rk3328.dtsi, and replace SPDIF nodes. We can use SPDIF pass-through with suitable ALSA settings

Re: [PATCH v3] arm64: dts: rockchip: add SPDIF node for rk3399-rockpro64

2020-11-08 Thread Katsuhiro Suzuki
i ES8316 HiFi-0] Subdevices: 1/1 Subdevice #0: subdevice #0 card 2: rockchiprk339_1 [rockchip,rk3399], device 0: ff87.spdif-dit-hifi dit-hifi-0 [ff87.spdif-dit-hifi dit-hifi-0] Subdevices: 1/1 Subdevice #0: subdevice #0 On 10/5/20 4:03 PM, Katsuhiro Suzuki wrote: This patch a

Re: [PATCH] dt-bindings: sound: convert Everest ES8316 binding to yaml

2020-07-24 Thread Katsuhiro Suzuki
Hello Rob, Thank you for review. On 2020/07/24 6:26, Rob Herring wrote: On Thu, Jul 23, 2020 at 03:07:28AM +0900, Katsuhiro Suzuki wrote: This patch converts Everest Semiconductor ES8316 low power audio CODEC binding to DT schema. Signed-off-by: Katsuhiro Suzuki --- .../bindings/sound

[PATCH v2] dt-bindings: sound: convert Everest ES8316 binding to yaml

2020-07-24 Thread Katsuhiro Suzuki
This patch converts Everest Semiconductor ES8316 low power audio CODEC binding to DT schema. Signed-off-by: Katsuhiro Suzuki --- Changes in v2: - Change maintainers from Mark to Daniel and me --- .../bindings/sound/everest,es8316.txt | 23 - .../bindings/sound/everest,es8316

[PATCH v2] dt-bindings: sound: convert ROHM BD28623 amplifier binding to yaml

2020-07-22 Thread Katsuhiro Suzuki
This patch converts ROHM BD28623UMV class D speaker amplifier binding to DT schema. Signed-off-by: Katsuhiro Suzuki Reviewed-by: Rob Herring --- Changes in v2: - add additionalProperties:false - add Rob's Reviewed-by --- .../bindings/sound/rohm,bd28623.txt

[PATCH] dt-bindings: sound: convert Everest ES8316 binding to yaml

2020-07-22 Thread Katsuhiro Suzuki
This patch converts Everest Semiconductor ES8316 low power audio CODEC binding to DT schema. Signed-off-by: Katsuhiro Suzuki --- .../bindings/sound/everest,es8316.txt | 23 - .../bindings/sound/everest,es8316.yaml| 49 +++ 2 files changed, 49 insertions

Re: [PATCH] dt-bindings: sound: convert ROHM BD28623 amplifier binding to yaml

2020-07-22 Thread Katsuhiro Suzuki
Hello Rob, Thanks a lot for your review! Best Regards, Katsuhiro Suzuki On 2020/07/21 11:12, Rob Herring wrote: On Tue, Jul 14, 2020 at 05:09:59PM +0900, Katsuhiro Suzuki wrote: This patch converts ROHM BD28623UMV class D speaker amplifier binding to DT schema. Signed-off-by: Katsuhiro

[PATCH] ARM: dts: rockchip: add ethernet phy node for tinker board

2019-06-21 Thread Katsuhiro Suzuki
This patch adds missing mdio and ethernet PHY nodes for rk3328 ASUS tinker board. Signed-off-by: Katsuhiro Suzuki --- arch/arm/boot/dts/rk3288-tinker.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/rk3288-tinker.dtsi b/arch/arm/boot/dts/rk3288

Re: [PATCH] arm64: dts: rockchip: fix IO domain voltage setting of APIO5

2019-04-15 Thread Katsuhiro Suzuki
ping... On 2019/03/27 21:03, Katsuhiro Suzuki wrote: This patch fixes IO domain voltage setting that is related to audio_gpio3d4a_ms (bit 1) of GRF_IO_VSEL. This is because RockPro64 schematics P.16 says that regulator supplies 3.0V power to APIO5_VDD. So audio_gpio3d4a_ms bit should be clear

Re: [PATCH] clk: fractional-divider: check parent rate only for general approximation

2019-01-30 Thread Katsuhiro Suzuki
Hello Stephen, Thank you for your comment. I'll add detail description and send it. Best Regards, Katsuhiro Suzuki On 2019/01/30 6:55, Stephen Boyd wrote: Quoting Katsuhiro Suzuki (2019-01-07 05:21:24) Custom approximation of fractional-divider may not need parent clock rate checking

[PATCH] clk: fractional-divider: check parent rate only for general approximation

2019-01-30 Thread Katsuhiro Suzuki
d parent (i2s1_div) and parent (i2s_frac) settings at same time. Clock mux system can choose i2s1_frac and audio works fine. Signed-off-by: Katsuhiro Suzuki --- drivers/clk/clk-fractional-divider.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/cl

[PATCH 1/2] ASoC: add DT bindings documentation for ROHM BD28623 codec

2018-02-20 Thread Katsuhiro Suzuki
This patch adds DT bindings documentation for ROHM BD28623MUV class D speaker amplifier. Signed-off-by: Katsuhiro Suzuki --- .../devicetree/bindings/sound/rohm,bd28623.txt | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH 0/2] ASoC: add support for ROHM BD28623 codec

2018-02-20 Thread Katsuhiro Suzuki
This patch adds support for ROHM BD28623MUV class D speaker amplifier codec driver. This driver only refers information of HW specification document that can be derivered at website of ROHM. http://www.rohm.com/web/global/products/-/product/BD28623MUV Katsuhiro Suzuki (2): ASoC: add DT

[PATCH 2/2] ASoC: support ROHM BD28623 codec

2018-02-20 Thread Katsuhiro Suzuki
This patch adds support of the ROHM BD28623MUV Class D speaker amplifier for Flat-panel TVs. This IC delivers an output power of 20W + 20W. Signed-off-by: Katsuhiro Suzuki --- sound/soc/codecs/Kconfig | 8 ++ sound/soc/codecs/Makefile | 2 + sound/soc/codecs/bd28623.c | 258

Re: [PATCH 1/2] ASoC: add DT bindings documentation for ROHM BD28623 codec

2018-02-21 Thread Katsuhiro Suzuki
tsu > ; Jassi Brar ; > linux-arm-ker...@lists.infradead.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH 1/2] ASoC: add DT bindings documentation for ROHM BD28623 > codec > > On Wed, Feb 21, 2018 at 01:33:10PM +0900, Katsuhiro Suzuki wrote: > > > +Opt

<    1   2   3   >