Re: Re: Re: Re: [PATCH 1/2] rbd: RBD_DEV_FLAG_THICK rbd_dev_flags bit

Hi Ilya, Thank you for reviewing. I merged two patches into one patch and pushed the new patch to GitHub. And I opened the PR. Could you check the PR? And I forgot to mention in previous email that I modified your patch to apply the latest kernel because I couldn't apply your patch directly by u

[PATCH 2/2] rbd: add 'thick' sysfs rbd device attribute

This patch adds the description of sysfs thick entry. Signed-off-by: Hitoshi Kamei Cc: Mitsuo Hayasaka --- Documentation/ABI/testing/sysfs-bus-rbd | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-bus-rbd b/Documentation/ABI/testing/sysfs-bus-rbd index f

[PATCH 1/2] rbd: RBD_DEV_FLAG_THICK rbd_dev_flags bit

This patch adds a user interface to prevent from issuing discard requests onto the specified rbd device. This is needed for thick-provisioned images. To avoid discarding allocated blocks on thick-provision image, users can specify this flag bit via sysfs (/sys/bus/rbd/devices//thick). When users w

[PATCH 0/2] rbd: thick-provision image support

This patch series adds the thick-provision image support to /drivers/block/rbd.c relating to https://github.com/ceph/ceph/pull/18317. The rbd will not issue the discard operation to thick-provision images, if applied. The rbd should not discard any allocated blocks of thick-provision image to ensu

RE: Re: Re: [PATCH 1/2] rbd: RBD_DEV_FLAG_THICK rbd_dev_flags bit

Hi Ilya, I think your patch fully completes our purpose and I confirmed that the kernel with the patch could work well by testing in my environment. I added the notrim option to rbd map command in accordance with your kernel rbd driver patch, and I pushed the patch to GitHub (https://github.com/h

RE: Re: [PATCH 1/2] rbd: RBD_DEV_FLAG_THICK rbd_dev_flags bit

Hi Yang, > I am not sure is this the best way for this case, what about adding an option > in "rbd map -o thick rbd/test"? I will add such option to the rbd map command to manipulate image settings. So, the end-user do not change the settings directly via sysfs file. > @@ -4011,6 +4012,

RE: [PATCH 2/2] rbd: add 'thick' sysfs rbd device attribute

> The normal storage term would be fully provisioned, not 'thick' The rbd command, which is user mode program, uses "thick-provision". If the kernel rbd driver uses "fully provisioned", then the rbd command should use "fully provisioned" too. What do you think, Jason? Regards, -- Hitoshi Kame

RE: Re: [PATCH 0/2] rbd: thick-provision image support

Hi Ilya, > I think it should be a map time option -- e.g. rbd map -o thick. > I don't see any reason for allowing tweaking this setting on a mapped image. I will add such option to rbd map command. The modified rbd command with the option writes "1" to sysfs file to disable discard operation at

RE: Re: [PATCH 0/2] rbd: thick-provision image support

Hi Jason, > However, given that's the intent of this change, why not name the > option along the lines of "discard_disbled"? Thank you for your comments. I would like to change the name of sysfs file to "discard_disabled". Also, I will add an option named discard_disabled to the rdb map command.