On 08/05/2018 02:59 AM, Gustavo A. R. Silva wrote:
> Return statements in functions returning bool should use true or false
> instead of an integer value.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva
Queued up for net-next, thanks.
> ---
> dri
On 01.02.21 06:57, Xie He wrote:
> When sending a packet, we will prepend it with an LAPB header.
> This modifies the shared parts of a cloned skb, so we should copy the
> skb rather than just clone it, before we prepend the header.
>
> In "Documentation/networking/driver.rst" (the 2nd point), it
On 23.12.20 15:15, Zheng Yongjun wrote:
> spinlock can be initialized automatically with DEFINE_SPINLOCK()
> rather than explicitly calling spin_lock_init().
>
> Signed-off-by: Zheng Yongjun
> ---
> drivers/s390/cio/css.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git
On 09.04.21 02:39, Sven Van Asbroeck wrote:
> From: Sven Van Asbroeck
>
> The ethernet frame length is calculated incorrectly. Depending on
> the value of RX_HEAD_PADDING, this may result in ethernet frames
> that are too short (cut off at the end), or too long (garbage added
> to the end).
>
>
On 14.04.21 15:19, Sven Van Asbroeck wrote:
> Hi Julian,
>
> On Wed, Apr 14, 2021 at 8:53 AM Julian Wiedmann wrote:
>>
>> On a cursory glance, using __netdev_alloc_skb_ip_align() here should
>> allow you to get rid of all the RX_HEAD_PADDING gymnastics.
>>
>&
On 02.12.20 14:45, Enrico Weigelt, metux IT consult wrote:
> Use netdev_info() instead of pr_info() for more consistent log output.
>
> Signed-off-by: Enrico Weigelt
> ---
> net/8021q/vlan.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/8021q/vlan.c b/net/8021
On 13.12.20 18:20, Vincent Stehlé wrote:
> The ndo_start_xmit() method must not attempt to free the skb to transmit
> when returning NETDEV_TX_BUSY. Fix the korina_send_packet() function
> accordingly.
>
> Fixes: ef11291bcd5f ("Add support the Korina (IDT RC32434) Ethernet MAC")
> Signed-off-by: V
It's only used inside drivers/base/dd.c
Signed-off-by: Julian Wiedmann
---
drivers/base/base.h | 1 -
drivers/base/dd.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/base/base.h b/drivers/base/base.h
index 91cfb8405abd..f5600a83124f 100644
--- a/drivers
On 22.08.19 17:04, Markus Elfring wrote:
> From: Markus Elfring
> Date: Thu, 22 Aug 2019 10:55:33 +0200
>
> The dev_kfree_skb() function performs also input parameter validation.
> Thus the test around the shown calls is not needed.
>
> This issue was detected by using the Coccinelle software.
>
On 06.10.19 20:45, jcfara...@gmail.com wrote:
> From: Julio Faracco
>
> For debug purpose of TX timeout events, a tx_timeout entry was added to
> monitor this special case: when dev_watchdog identifies a tx_timeout and
> throw an exception. We can both consider this event as an error, but
> drive
On 30.07.19 02:17, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warnings (Building: s390):
>
> drivers/s390/net/ctcm_fsms.c: In function ‘ctcmpc_chx_attnbusy’:
> drivers/s390/net/ctcm_fsms.c:1703:6: warning: this stateme
On 03/26/2017 03:27 PM, Philippe Reynes wrote:
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> As I don't have the hardware, I'd be very pleased if
> someone may test this patch.
>
> Signed-off-by: Philippe Reynes
> ---
Hello Ph
On 08.11.20 08:34, xiakaixu1...@gmail.com wrote:
> From: Kaixu Xia
>
> Fix the following coccinelle report:
>
> ./drivers/s390/net/qeth_l3_main.c:107:2-4: WARNING: possible condition with
> no effect (if == else)
>
> Both branches are the same, so remove them.
>
Indeed, missed that in commit
On 07/06/2017 02:25 PM, Heiko Carstens wrote:
> On Thu, Jul 06, 2017 at 03:57:19AM -0700, Joe Perches wrote:
>> On Thu, 2017-07-06 at 12:29 +0200, Heiko Carstens wrote:
>>> On Wed, Jul 05, 2017 at 01:02:21PM -0700, Joe Perches wrote:
Make the code like the rest of the kernel.
>> []
diff -
added new hash tables, but missed to initialize them.
>
> Fixes: 5f78e29ceebf ("qeth: optimize IP handling in rx_mode callback")
> Signed-off-by: Ursula Braun
> Reviewed-by: Julian Wiedmann
> Signed-off-by: Julian Wiedmann
> Signed-off-by: David S. Miller
> Sig
orresponding memory region, very short sockaddrs (zero or
> one byte long) result in operating on uninitialized memory while
> referencing .sa_family.
>
> Signed-off-by: Mateusz Jurczyk
Thanks Mateusz!
Fixes: 52a82e23b9f2
Acked-by: Julian Wiedmann
On 09/21/2017 02:20 PM, Allen Pais wrote:
> Use setup_timer function instead of initializing timer with the
> function and data fields.
>
> Signed-off-by: Allen Pais
Thanks Allen, queued up for our next upstream submission.
On 10/20/2017 09:47 AM, Elena Reshetova wrote:
> This series, for S390, replaces atomic_t reference
> counters with the new refcount_t type and API (see include/linux/refcount.h).
> By doing this we prevent intentional or accidental
> underflows or overflows that can led to use-after-free vulnerabi
On 11/24/2017 01:50 PM, Colin King wrote:
> From: Colin Ian King
>
> Use setup_timer function instead of initializing timer with the
> function and data fields.
>
> Signed-off-by: Colin Ian King
> ---
> drivers/s390/net/fsm.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff
19 matches
Mail list logo
