[PATCH] xen: add static initialization of steal_clock op to xen_time_ops

2016-07-26 Thread Juergen Gross
pv_time_ops might be overwritten with xen_time_ops after the steal_clock operation has been initialized already. To prevent calling a now uninitialized function pointer add the steal_clock static initialization to xen_time_ops. Signed-off-by: Juergen Gross --- arch/x86/xen/time.c | 1

[GIT PULL] Changes for 4.8

2016-07-26 Thread Juergen Gross
from Peter and multiple tests showed no regressions. As the series is touching multiple subsystems I couldn't find anyone willing to take the series via his tree (I tried Ingo, Thomas, Peter). Juergen Gross (6): xen: sync xen header virt, sched: add generic vcpu pinning support

[GIT PULL V2] Changes for 4.8

2016-07-26 Thread Juergen Gross
ler got an Ack from Peter and multiple tests showed no regressions. As the series is touching multiple subsystems I couldn't find anyone willing to take the series via his tree (I tried Ingo, Thomas, Peter). Juergen Gross (6): xen: sync xen header virt, sched: add generic vcpu

Re: [GIT PULL] Changes for 4.8

2016-07-26 Thread Juergen Gross
On 27/07/16 08:41, Ingo Molnar wrote: > > * Juergen Gross wrote: > >> Hi Linus, >> >> please consider pulling a patch series for 4.8 from: >> >> https://github.com/jgross1/linux.git tags/for-linus-4-8 >> >> Unfortunately 2 of the 6 patche

Re: [PATCH 2/3] arm/xen: add support for vm_assist hypercall

2016-07-04 Thread Juergen Gross
On 22/06/16 09:03, Juergen Gross wrote: > Add support for the Xen HYPERVISOR_vm_assist hypercall. > > Signed-off-by: Juergen Gross Stefano, could you please comment? Juergen > --- > arch/arm/include/asm/xen/hypercall.h | 1 + > arch/arm/xen/enlighten.c | 1

Re: Fwd: Fujitsu PrimePower 450 with SPARC64 V & Linux support

2016-10-28 Thread Juergen Gross
On 10/27/2016 08:50 PM, Allan Tsakuhhin wrote: > I am trying to build Linux system on Fujitsu PrimePower 450 running by > SPARC64 V CPUs. Does anyone have supportive materials (manuals, > overviews, specs) about Fujitsu PP450 and SPARC64 V CPUs. Every kind > of source material may be useful! > > Al

Re: [PATCH v2] xen/manage: correct return value check on xenbus_scanf()

2016-11-07 Thread Juergen Gross
On 08/11/16 08:44, Jan Beulich wrote: > A negative return value indicates an error; in fact the function at > present won't ever return zero. > > Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross > --- > v2: For consistency with other code don't consider ze

Re: [RFC PATCH] xen/x86: Increase xen_e820_map to E820_X_MAX possible entries

2016-11-15 Thread Juergen Gross
On 15/11/16 16:22, Alex Thorlton wrote: > On Tue, Nov 15, 2016 at 10:55:49AM +0100, Juergen Gross wrote: >> I'd go with the new error code. What about E2BIG or ENOSPC? >> >> I think the hypervisor should fill in the number of entries required >> in this case. &g

Re: [PATCH] xen-platform: use builtin_pci_driver

2016-11-17 Thread Juergen Gross
On 14/11/16 13:52, Geliang Tang wrote: > Use builtin_pci_driver() helper to simplify the code. > > Signed-off-by: Geliang Tang Applied to xen/tip.git for-linus-4.10 Juergen > --- > drivers/xen/platform-pci.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drive

[PATCH] virtio: remove config.c

2016-10-11 Thread Juergen Gross
Remove unused file config.c Signed-off-by: Juergen Gross --- drivers/virtio/config.c | 12 1 file changed, 12 deletions(-) delete mode 100644 drivers/virtio/config.c diff --git a/drivers/virtio/config.c b/drivers/virtio/config.c deleted file mode 100644 index f70bcd2..000

Re: [PATCH v3] xenbus: advertize control feature flags

2016-10-11 Thread Juergen Gross
nt > Cc: Boris Ostrovsky > Cc: David Vrabel > Cc: Juergen Gross Hmm, I'd prefer node[] allocated on the stack over dynamic allocation. What about something like the following? It will at least issue build warnings in case the size is too small, will use less memory and

[PATCH v2] xenbus: advertise control feature flags

2016-10-11 Thread Juergen Gross
The Xen docs specify several flags which a guest can set to advertise which values of the xenstore control/shutdown key it will recognize. This patch adds code to write all the relevant feature-flag keys. Based-on-patch-by: Paul Durrant Signed-off-by: Juergen Gross Reviewed-by: David Vrabel

[PATCH] acpi: don't register acpi_pad driver if running as xen dom0

2016-10-12 Thread Juergen Gross
When running as Xen dom0 a special processor_aggregator driver is needed. Don't register the standard driver in this case. Without that check an error message: "Error: Driver 'processor_aggregator' is already registered, aborting..." will be displayed. Sig

Re: [PATCH] xenbus: advertize control feature flags

2016-10-10 Thread Juergen Gross
nt > Cc: Boris Ostrovsky > Cc: David Vrabel > Cc: Juergen Gross > --- > drivers/xen/manage.c | 45 +++-- > 1 file changed, 35 insertions(+), 10 deletions(-) > > diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c > index e

Re: [PATCH] xenbus: advertize control feature flags

2016-10-10 Thread Juergen Gross
nt > Cc: Boris Ostrovsky > Cc: David Vrabel > Cc: Juergen Gross > --- > drivers/xen/manage.c | 45 +++-- > 1 file changed, 35 insertions(+), 10 deletions(-) > > diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c > index e

Re: [PATCH v2] xenbus: advertize control feature flags

2016-10-10 Thread Juergen Gross
nt > Cc: Boris Ostrovsky > Cc: David Vrabel > Cc: Juergen Gross > --- > > v2: > - Fix flag logic inversion > - Use kasprintf() > --- > drivers/xen/manage.c | 38 -- > 1 file changed, 28 insertions(+), 10 deletions(-) >

[PATCH] usb/gadget: use kasprintf() instead of open coding it

2016-10-10 Thread Juergen Gross
Signed-off-by: Juergen Gross --- drivers/usb/gadget/composite.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c index 32176f7..455efec 100644 --- a/drivers/usb/gadget/composite.c +++ b/drivers/usb

[PATCH v2] usb/gadget: use kasprintf() instead of open coding it

2016-10-10 Thread Juergen Gross
Use kasprintf() instead of open coding it. Signed-off-by: Juergen Gross --- drivers/usb/gadget/composite.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c index 32176f7..455efec 100644 --- a

Re: [PATCH] usb/gadget: use kasprintf() instead of open coding it

2016-10-10 Thread Juergen Gross
On 10/10/16 12:26, Felipe Balbi wrote: > > Hi, > > Juergen Gross writes: > >> Signed-off-by: Juergen Gross > > I can't apply anything without a commit log. Sorry. I always thought a subject line telling the complete story would be enough. I'll resend wi

Re: [RFC PATCH] xen/x86: Increase xen_e820_map to E820_X_MAX possible entries

2016-11-14 Thread Juergen Gross
On 15/11/16 01:11, Alex Thorlton wrote: > Hey everyone, > > We're having problems with large systems hitting a BUG in > xen_memory_setup, due to extra e820 entries created in the > XENMEM_machine_memory_map callback. The change in the patch gets things > working, but Boris and I wanted to get opi

Re: [PATCH] xen-platform: use builtin_pci_driver

2016-11-14 Thread Juergen Gross
On 14/11/16 13:52, Geliang Tang wrote: > Use builtin_pci_driver() helper to simplify the code. > > Signed-off-by: Geliang Tang Reviewed-by: Juergen Gross > --- > drivers/xen/platform-pci.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --gi

Re: [RFC PATCH] xen/x86: Increase xen_e820_map to E820_X_MAX possible entries

2016-11-14 Thread Juergen Gross
On 15/11/16 08:15, Jan Beulich wrote: On 15.11.16 at 07:33, wrote: >> On 15/11/16 01:11, Alex Thorlton wrote: >>> Hey everyone, >>> >>> We're having problems with large systems hitting a BUG in >>> xen_memory_setup, due to extra e820 entries created in the >>> XENMEM_machine_memory_map callba

Re: [RFC PATCH] xen/x86: Increase xen_e820_map to E820_X_MAX possible entries

2016-11-15 Thread Juergen Gross
On 15/11/16 09:01, Jan Beulich wrote: On 15.11.16 at 08:36, wrote: >> On 15/11/16 08:15, Jan Beulich wrote: >> On 15.11.16 at 07:33, wrote: On 15/11/16 01:11, Alex Thorlton wrote: > Hey everyone, > > We're having problems with large systems hitting a BUG in > xen_mem

Re: [RFC PATCH] xen/x86: Increase xen_e820_map to E820_X_MAX possible entries

2016-11-15 Thread Juergen Gross
On 15/11/16 10:45, Jan Beulich wrote: On 15.11.16 at 09:42, wrote: >> On 15/11/16 09:01, Jan Beulich wrote: >> On 15.11.16 at 08:36, wrote: On 15/11/16 08:15, Jan Beulich wrote: On 15.11.16 at 07:33, wrote: >> In case I'm right the Xen hypervisor should be prepared for

Re: [RFC PATCH] xen/x86: Increase xen_e820_map to E820_X_MAX possible entries

2016-11-15 Thread Juergen Gross
On 15/11/16 11:44, Jan Beulich wrote: On 15.11.16 at 10:55, wrote: >> On 15/11/16 10:45, Jan Beulich wrote: >> On 15.11.16 at 09:42, wrote: For a fully dynamical solution we'd need a way to get a partial E820 map from the hypervisor (e.g. first 128 entries) in order to be

Re: [PATCH v5 7/9] x86, xen: support vcpu preempted check

2016-10-20 Thread Juergen Gross
Corrected xen-devel mailing list address, added other Xen maintainers On 20/10/16 23:27, Pan Xinhui wrote: > From: Juergen Gross > > Support the vcpu_is_preempted() functionality under Xen. This will > enhance lock performance on overcommitted hosts (more runnable vcpus > than p

Re: [PATCH 3/8] xen/pvh: Import PVH-related Xen public interfaces

2016-10-21 Thread Juergen Gross
On 14/10/16 20:05, Boris Ostrovsky wrote: > Signed-off-by: Boris Ostrovsky Reviewed-by: Juergen Gross Juergen

Re: [PATCH 2/5] stop_machine: yield CPU during stop machine

2016-10-21 Thread Juergen Gross
On 21/10/16 14:05, Peter Zijlstra wrote: > On Fri, Oct 21, 2016 at 01:58:55PM +0200, Christian Borntraeger wrote: >> stop_machine can take a very long time if the hypervisor does >> overcommitment for guest CPUs. When waiting for "the one", lets >> give up our CPU by using the new cpu_relax_yield.

Re: [Xen PATCH] xen-netback: fix error handling output

2016-11-10 Thread Juergen Gross
On 08/11/16 14:34, Arnd Bergmann wrote: > The connect function prints an unintialized error code after an > earlier initialization was removed: > > drivers/net/xen-netback/xenbus.c: In function 'connect': > drivers/net/xen-netback/xenbus.c:938:3: error: 'err' may be used > uninitialized in this f

Re: [PATCH v4] xen/gntdev: Use VM_MIXEDMAP instead of VM_IO to avoid NUMA balancing

2016-11-28 Thread Juergen Gross
On 21/11/16 15:56, Boris Ostrovsky wrote: > Commit 9c17d96500f7 ("xen/gntdev: Grant maps should not be subject to > NUMA balancing") set VM_IO flag to prevent grant maps from being > subjected to NUMA balancing. > > It was discovered recently that this flag causes get_user_pages() to > always fail

[PATCH 07/12] xen: make use of xenbus_read_unsigned() in xen-netfront

2016-10-31 Thread Juergen Gross
Use xenbus_read_unsigned() instead of xenbus_scanf() when possible. This requires to change the type of some reads from int to unsigned, but these cases have been wrong before: negative values are not allowed for the modified cases. Cc: net...@vger.kernel.org Signed-off-by: Juergen Gross

[PATCH 00/12] xen: add common function for reading optional value

2016-10-31 Thread Juergen Gross
There are multiple instances of code reading an optional unsigned parameter from Xenstore via xenbus_scanf(). Instead of repeating the same code over and over add a service function doing the job and replace the call of xenbus_scanf() with the call of the new function where appropriate. Juergen

[PATCH 02/12] xen: make use of xenbus_read_unsigned() in xen-blkback

2016-10-31 Thread Juergen Gross
: Juergen Gross --- drivers/block/xen-blkback/xenbus.c | 36 ++-- 1 file changed, 14 insertions(+), 22 deletions(-) diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c index 3cc6d1d..415e79b 100644 --- a/drivers/block/xen-blkback

[PATCH 06/12] xen: make use of xenbus_read_unsigned() in xen-netback

2016-10-31 Thread Juergen Gross
...@vger.kernel.org Signed-off-by: Juergen Gross --- drivers/net/xen-netback/xenbus.c | 50 +++- 1 file changed, 14 insertions(+), 36 deletions(-) diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c index 8674e18..7356e00 100644 --- a

[PATCH 05/12] xen: make use of xenbus_read_unsigned() in xen-kbdfront

2016-10-31 Thread Juergen Gross
Signed-off-by: Juergen Gross --- drivers/input/misc/xen-kbdfront.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/input/misc/xen-kbdfront.c b/drivers/input/misc/xen-kbdfront.c index 227fbd2..3900875 100644 --- a/drivers/input/misc/xen-kbdfront.c +++ b

[PATCH 08/12] xen: make use of xenbus_read_unsigned() in xen-pcifront

2016-10-31 Thread Juergen Gross
: Juergen Gross --- drivers/pci/xen-pcifront.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c index d6ff5e8..8fc2e95 100644 --- a/drivers/pci/xen-pcifront.c +++ b/drivers/pci/xen-pcifront.c @@ -1038,10 +1038,8

[PATCH 04/12] xen: make use of xenbus_read_unsigned() in xen-tpmfront

2016-10-31 Thread Juergen Gross
...@linux.intel.com Cc: jguntho...@obsidianresearch.com Cc: tpmdd-de...@lists.sourceforge.net Signed-off-by: Juergen Gross --- drivers/char/tpm/xen-tpmfront.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/char/tpm/xen-tpmfront.c index

[PATCH 09/12] xen: make use of xenbus_read_unsigned() in xen-scsifront

2016-10-31 Thread Juergen Gross
Use xenbus_read_unsigned() instead of xenbus_scanf() when possible. Signed-off-by: Juergen Gross --- drivers/scsi/xen-scsifront.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c index 9dc8687..7e817c6 100644

[PATCH 10/12] xen: make use of xenbus_read_unsigned() in xen-fbfront

2016-10-31 Thread Juergen Gross
-off-by: Juergen Gross --- drivers/video/fbdev/xen-fbfront.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c index 0567d51..d0115a7 100644 --- a/drivers/video/fbdev/xen-fbfront.c +++ b/drivers

[PATCH 11/12] xen: make use of xenbus_read_unsigned() in xen-pciback

2016-10-31 Thread Juergen Gross
Use xenbus_read_unsigned() instead of xenbus_scanf() when possible. This requires to change the type of the read from int to unsigned, but this case has been wrong before: negative values are not allowed for the modified case. Signed-off-by: Juergen Gross --- drivers/xen/xen-pciback/xenbus.c

[PATCH 03/12] xen: make use of xenbus_read_unsigned() in xen-blkfront

2016-10-31 Thread Juergen Gross
-by: Juergen Gross --- drivers/block/xen-blkfront.c | 81 ++-- 1 file changed, 26 insertions(+), 55 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 9908597..2ee9646 100644 --- a/drivers/block/xen-blkfront.c +++ b

[PATCH 01/12] xen: introduce xenbus_read_unsigned()

2016-10-31 Thread Juergen Gross
There are multiple instances of code reading an optional unsigned parameter from Xenstore via xenbus_scanf(). Instead of repeating the same code over and over add a service function doing the job. Signed-off-by: Juergen Gross --- drivers/xen/xenbus/xenbus_xs.c | 15 +++ include/xen

[PATCH 12/12] xen: make use of xenbus_read_unsigned() in xenbus

2016-10-31 Thread Juergen Gross
Use xenbus_read_unsigned() instead of xenbus_scanf() when possible. This requires to change the type of the reads from int to unsigned, but these cases have been wrong before: negative values are not allowed for the modified cases. Signed-off-by: Juergen Gross --- drivers/xen/xenbus

Re: [PATCH 00/12] xen: add common function for reading optional value

2016-10-31 Thread Juergen Gross
On 31/10/16 18:08, David Miller wrote: > From: Juergen Gross > Date: Mon, 31 Oct 2016 17:48:18 +0100 > >> There are multiple instances of code reading an optional unsigned >> parameter from Xenstore via xenbus_scanf(). Instead of repeating the >> same code over and

Re: [PATCH] Xen: ARM: Zero reserved fields of xatp before making hypervisor call

2016-12-20 Thread Juergen Gross
On 20/12/16 06:02, Jiandi An wrote: > On 12/19/16 12:49, Stefano Stabellini wrote: >> On Mon, 19 Dec 2016, Juergen Gross wrote: >>> On 19/12/16 03:56, Jiandi An wrote: >>>> Ensure all reserved fields of xatp are zero before making hypervisor >>&

Re: [PATCH] xen/evtchn: use rb_entry()

2016-12-20 Thread Juergen Gross
On 20/12/16 15:02, Geliang Tang wrote: > To make the code clearer, use rb_entry() instead of container_of() to > deal with rbtree. > > Signed-off-by: Geliang Tang Reviewed-by: Juergen Gross > --- > drivers/xen/evtchn.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 d

[PATCH 0/3] xen: fix some minor bugs and cleanup of xenbus

2016-12-21 Thread Juergen Gross
Do some minor bug fixes and cleanup of xenbus driver. Juergen Gross (3): xen: xenbus driver must not accept invalid transaction ids xen: return xenstore command failures via response instead of rc xen: remove stale xs_input_avail() from header drivers/xen/xenbus/xenbus_comms.h| 1

[PATCH 2/3] xen: return xenstore command failures via response instead of rc

2016-12-21 Thread Juergen Gross
Xenstore is broken. While at it try to return the same error values xenstored would return for those cases. Signed-off-by: Juergen Gross --- drivers/xen/xenbus/xenbus_dev_frontend.c | 47 ++-- 1 file changed, 27 insertions(+), 20 deletions(-) diff --git a/drivers/xen

[PATCH 3/3] xen: remove stale xs_input_avail() from header

2016-12-21 Thread Juergen Gross
In drivers/xen/xenbus/xenbus_comms.h there is a stale declaration of xs_input_avail(). Remove it. Signed-off-by: Juergen Gross --- drivers/xen/xenbus/xenbus_comms.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/xen/xenbus/xenbus_comms.h b/drivers/xen/xenbus/xenbus_comms.h index

[PATCH 1/3] xen: xenbus driver must not accept invalid transaction ids

2016-12-21 Thread Juergen Gross
able to "hijack" a transaction from another user the xenbus driver has to verify a given transaction id against all known transaction ids of the user before forwarding it to Xenstore. Signed-off-by: Juergen Gross --- drivers/xen/xenbus/xenbus_dev_frontend.c | 2 +- 1 file changed, 1

Re: [PATCH] xen/evtchn: use rb_entry()

2016-12-22 Thread Juergen Gross
On 20/12/16 15:02, Geliang Tang wrote: > To make the code clearer, use rb_entry() instead of container_of() to > deal with rbtree. > > Signed-off-by: Geliang Tang Committed to xen/tip.git for-linus-4.10 Juergen > --- > drivers/xen/evtchn.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 delet

Re: [PATCH 1/3] xen: xenbus driver must not accept invalid transaction ids

2016-12-22 Thread Juergen Gross
On 22/12/16 16:38, Boris Ostrovsky wrote: > On 12/22/2016 02:19 AM, Juergen Gross wrote: >> When accessing Xenstore in a transaction the user is specifying a >> transaction id which he normally obtained from Xenstore when starting >> the transaction. Xenstore is validating a t

Re: [PATCH 2/3] xen: return xenstore command failures via response instead of rc

2016-12-22 Thread Juergen Gross
On 22/12/16 16:49, Boris Ostrovsky wrote: > On 12/22/2016 02:19 AM, Juergen Gross wrote: >> When the xenbus driver does some special handling for a Xenstore >> command any error condition related to the command should be returned >> via an error response instead of lett

Re: [PATCH V2] Xen: ARM: Zero reserved fields of xatp before making hypervisor call

2017-01-01 Thread Juergen Gross
On 28/12/16 01:47, Jiandi An wrote: > Ensure all reserved fields of xatp are zero before making > hypervisor call to XEN in xen_map_device_mmio(). > xenmem_add_to_physmap_one() in XEN fails the mapping request if > extra.res reserved field in xatp is not zero for XENMAPSPACE_dev_mmio > request. >

[GIT PULL] xen: features and fixes for 4.10 rc0

2016-12-12 Thread Juergen Gross
VM_IO to avoid NUMA balancing David Vrabel (2): MAINTAINERS: update XEN HYPERVISOR INTERFACE xenbus: fix deadlock on writes to /proc/xen/xenbus Geliang Tang (1): xen-platform: use builtin_pci_driver Juergen Gross (13): xen: introduce xenbus_read_unsigned() xen: make use

[PATCH v2] xen/scsifront: don't request a slot on the ring until request is ready

2016-12-01 Thread Juergen Gross
Instead of requesting a new slot on the ring to the backend early, do so only after all has been setup for the request to be sent. This makes error handling easier as we don't need to undo the request id allocation and ring slot allocation. Suggested-by: Jan Beulich Signed-off-by: Juergen

[PATCH v2] xen/scsifront: don't request a slot on the ring until request is ready

2016-12-01 Thread Juergen Gross
Instead of requesting a new slot on the ring to the backend early, do so only after all has been setup for the request to be sent. This makes error handling easier as we don't need to undo the request id allocation and ring slot allocation. Suggested-by: Jan Beulich Signed-off-by: Juergen

[PATCH v2] xen/scsifront: don't request a slot on the ring until request is ready

2016-12-01 Thread Juergen Gross
Instead of requesting a new slot on the ring to the backend early, do so only after all has been setup for the request to be sent. This makes error handling easier as we don't need to undo the request id allocation and ring slot allocation. Suggested-by: Jan Beulich Signed-off-by: Juergen

Re: [PATCH 1/1] xen: xenbus: set error code on failure

2016-12-04 Thread Juergen Gross
On 03/12/16 11:49, Pan Bian wrote: > In function xenstored_local_init(), the value of return variable err > should be negative on errors. But the value of err keeps 0 even if the > call to get_zeroed_page() returns a NULL pointer. This patch assigns > "-ENOMEM" to err on the error branch. > > Bu

Re: [PATCH 1/1] xen: set error code on failures

2016-12-04 Thread Juergen Gross
On 04/12/16 07:24, Pan Bian wrote: > From: Pan Bian > > The return variable rc is initialized with "-ENOMEM" outside the loop. > However, it is reset in the loop, and its value is not negative during > the second or after repeat of the loop. If kzalloc() fails then, it will > return 0. This pat

Re: [PATCH 1/1 v2] xen: set error code on failures

2016-12-05 Thread Juergen Gross
g, assigning "-ENOMEM" to rc when > kzalloc() or alloc_page() returns NULL, and removing the initialization > of rc outside of the loop. > > v1 is reviewed by: Juergen Gross Not being a real problem in this case I prefer spelling out explicit "Acked-by:" or "Re

Re: [PATCH 1/1 v2] xen: xenbus: set error code on failure

2016-12-05 Thread Juergen Gross
On 05/12/16 09:22, Pan Bian wrote: > Variable err is initialized with 0. As a result, the return value may > be 0 even if get_zeroed_page() fails to allocate memory. This patch fixes > the bug, initializing err with "-ENOMEM". > > v1 is reviewed by: Juergen Gross I did

Can't boot as Xen dom0 due to commit fe055896

2016-12-15 Thread Juergen Gross
Boris, with today's kernel the system isn't coming up when booted as Xen dom0: [ 33.575326] NMI watchdog: BUG: soft lockup - CPU#0 stuck for 23s! [swapper/0:1] [ 33.589795] Modules linked in: [ 33.596015] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.9.0-pv+ #687 [ 33.608844] Hardware name:

Re: Can't boot as Xen dom0 due to commit fe055896

2016-12-15 Thread Juergen Gross
On 15/12/16 17:46, Borislav Petkov wrote: > On Thu, Dec 15, 2016 at 05:12:04PM +0100, Juergen Gross wrote: >> with today's kernel the system isn't coming up when booted as Xen dom0: > > Remind me again pls, is dom0 even supposed to load microcode? Isn't the

Re: Can't boot as Xen dom0 due to commit fe055896

2016-12-15 Thread Juergen Gross
s to avoid being called on a Xen pv guest. And this is easy by using xen_domain(). Not trying to load ucode in _any_ guest is an optimization only. The attached patch works for me in dom0, bare metal and Xen HVM guest. Juergen >From 0b56d1f86679c5dc435ab6d96eb2f68b666271bb Mon Sep 17 00:00:00

Re: Can't boot as Xen dom0 due to commit fe055896

2016-12-16 Thread Juergen Gross
On 16/12/16 10:02, Borislav Petkov wrote: > On Fri, Dec 16, 2016 at 08:28:46AM +0100, Juergen Gross wrote: >> Not trying to load ucode in _any_ guest is an optimization only. > > Does the hunk below work too? Without testing, but I doubt it is working. As pv guests aren&#

Re: Can't boot as Xen dom0 due to commit fe055896

2016-12-16 Thread Juergen Gross
On 16/12/16 10:43, Borislav Petkov wrote: > On Fri, Dec 16, 2016 at 10:20:42AM +0100, Juergen Gross wrote: >> Without testing, but I doubt it is working. As pv guests aren't coming >> through check_loader_disabled_bsp() at all I can't see why your patch >> would

Re: Can't boot as Xen dom0 due to commit fe055896

2016-12-16 Thread Juergen Gross
On 16/12/16 11:45, Borislav Petkov wrote: > On Fri, Dec 16, 2016 at 11:00:29AM +0100, Juergen Gross wrote: >> Should work. I'm happy to test any patch. :-) > > I'm happy that you're happy to! :-) That makes me happy. :-D > Let's try this below. Okay. Re

i915 regression in kernel 4.10

2016-12-19 Thread Juergen Gross
00 (CET) Date: Fri, 16 Dec 2016 11:45:05 +0100 From: Borislav Petkov To: Juergen Gross Cc: Boris Ostrovsky , Linux Kernel Mailing List , xen-devel Subject: Re: Can't boot as Xen dom0 due to commit fe055896 Message-ID: <20161216104505.lk3s7fc7brrnm...@pd.tnic> References: <

Re: [PATCH] Xen: ARM: Zero reserved fields of xatp before making hypervisor call

2016-12-19 Thread Juergen Gross
On 19/12/16 03:56, Jiandi An wrote: > Ensure all reserved fields of xatp are zero before making hypervisor > call to XEN in xen_map_device_mmio(). xenmem_add_to_physmap_one() in > XEN fails the mapping request if extra.res reserved field in xatp is > not zero for XENMAPSPACE_dev_mmio request. > >

Re: i915 regression in kernel 4.10

2016-12-19 Thread Juergen Gross
On 19/12/16 13:29, Chris Wilson wrote: > On Mon, Dec 19, 2016 at 12:39:16PM +0100, Juergen Gross wrote: >> With recent 4.10 kernel the graphics isn't coming up under Xen. First >> failure message is: >> >> [ 46.656649] i915 :00:02.0: swiotlb buffer is full (s

[PATCH] xen/scsifront: don't advance ring request pointer in case of error

2016-11-29 Thread Juergen Gross
st id in case of an error. Signed-off-by: Juergen Gross --- In case accepted I'll take this patch through the Xen tree as it is based on another patch by lambert.quen...@gmail.com which is going through Xen, too. --- drivers/scsi/xen-scsifront.c | 5 +++-- 1 file changed, 3 insertions(+), 2

Re: [Xen-devel] [PATCH] xen/scsifront: don't advance ring request pointer in case of error

2016-11-29 Thread Juergen Gross
On 29/11/16 12:14, Jan Beulich wrote: On 29.11.16 at 11:50, wrote: >> --- a/drivers/scsi/xen-scsifront.c >> +++ b/drivers/scsi/xen-scsifront.c >> @@ -184,8 +184,6 @@ static struct vscsiif_request *scsifront_pre_req(struct >> vscsifrnt_info *info) >> >> ring_req = RING_GET_REQUEST(&(in

Re: [Xen-devel] [PATCH] xen/scsifront: don't advance ring request pointer in case of error

2016-11-29 Thread Juergen Gross
On 29/11/16 12:28, David Vrabel wrote: > On 29/11/16 11:19, Juergen Gross wrote: >> On 29/11/16 12:14, Jan Beulich wrote: >>>>>> On 29.11.16 at 11:50, wrote: >>>> --- a/drivers/scsi/xen-scsifront.c >>>> +++ b/drivers/scsi/xen-scsifront.c >

Re: [Xen-devel] [PATCH] xen/scsifront: don't advance ring request pointer in case of error

2016-11-29 Thread Juergen Gross
On 29/11/16 12:40, Jan Beulich wrote: On 29.11.16 at 12:19, wrote: >> On 29/11/16 12:14, Jan Beulich wrote: >> On 29.11.16 at 11:50, wrote: --- a/drivers/scsi/xen-scsifront.c +++ b/drivers/scsi/xen-scsifront.c @@ -184,8 +184,6 @@ static struct vscsiif_request *scsifr

Re: [PATCH 2/2] xen/x86: Increase xen_e820_map to E820_X_MAX possible entries

2016-11-29 Thread Juergen Gross
X to > ensure that there is enough room to store the entire e820 map returned > from this callback. > > Signed-off-by: Alex Thorlton > Suggested-by: Boris Ostrovsky Reviewed-by: Juergen Gross Juergen > Cc: Russ Anderson > Cc: David Vrabel > Cc: Ingo Molnar > Cc: Juerg

Re: [PATCH KERNEL] xen/events: use xen_vcpu_id mapping for EVTCHNOP_status

2016-11-29 Thread Juergen Gross
On 23/11/16 13:38, Vitaly Kuznetsov wrote: > EVTCHNOP_status hypercall returns Xen's idea of vcpu id so we need to > compare it against xen_vcpu_id mapping, not the Linux cpu id. > > Suggested-by: Radim Krcmar > Signed-off-by: Vitaly Kuznetsov Applied to xen/tip.git for-linus-4.10 Juergen

Re: [PATCH] xen-scsifront: Add a missing call to kfree

2016-11-20 Thread Juergen Gross
s will need some more work, I'll do a follow-on patch. Reviewed-by: Juergen Gross > > --- > drivers/scsi/xen-scsifront.c |1 + > 1 file changed, 1 insertion(+) > > --- a/drivers/scsi/xen-scsifront.c > +++ b/drivers/scsi/xen-scsifront.c > @@ -627,6 +627,7 @@ stati

Re: [PATCH 1/2] x86: Make E820_X_MAX unconditionally larger than E820MAX

2016-12-09 Thread Juergen Gross
On 05/12/16 18:49, Alex Thorlton wrote: > It's really not necessary to limit E820_X_MAX to 128 in the non-EFI > case. This commit drops E820_X_MAX's dependency on CONFIG_EFI, so that > E820_X_MAX is always at least slightly larger than E820MAX. > > The real motivation behind this is actually to p

Re: [PATCH 2/2] xen/x86: Increase xen_e820_map to E820_X_MAX possible entries

2016-12-09 Thread Juergen Gross
X to > ensure that there is enough room to store the entire e820 map returned > from this callback. > > Signed-off-by: Alex Thorlton > Suggested-by: Boris Ostrovsky > Reviewed-by: Juergen Gross Commited to xen/tip.git for-linus-4.10 Juergen

Re: [PATCH v2] xen/scsifront: don't request a slot on the ring until request is ready

2016-12-09 Thread Juergen Gross
On 02/12/16 07:15, Juergen Gross wrote: > Instead of requesting a new slot on the ring to the backend early, do > so only after all has been setup for the request to be sent. This > makes error handling easier as we don't need to undo the request id > allocation and rin

[PATCH 0/2] xen,input: xen-kbdfront pointing device resolution support

2017-03-21 Thread Juergen Gross
y Xen tools. Juergen Gross (2): xen,input: add xen-kbdfront module parameter for setting resolution xen,input: repair xen-kbdfront resolution setting via xenstore drivers/input/misc/xen-kbdfront.c | 42 ++- 1 file changed, 28 insertions(+), 14 dele

[PATCH 1/2] xen,input: add xen-kbdfront module parameter for setting resolution

2017-03-21 Thread Juergen Gross
Add a parameter for setting the resolution of xen-kbdfront in order to be able to cope with a (virtual) frame buffer of arbitrary resolution. Signed-off-by: Juergen Gross --- drivers/input/misc/xen-kbdfront.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 2/2] xen,input: repair xen-kbdfront resolution setting via xenstore

2017-03-21 Thread Juergen Gross
Setting the pointing device resolution via Xenstore isn't working reliably: in case XenbusStateInitWait has been missed the resolution settings won't be read. Correct this. Cc: sta...@vger.kernel.org Signed-off-by: Juergen Gross --- drivers/input/misc/xen-kbdfr

Re: [PATCH v6 4/7] xen/9pfs: connect to the backend

2017-03-22 Thread Juergen Gross
Eric Van Hensbergen > CC: Ron Minnich > CC: Latchesar Ionkov > CC: v9fs-develo...@lists.sourceforge.net Reviewed-by: Juergen Gross Juergen

Re: [PATCH v6 5/7] xen/9pfs: send requests to the backend

2017-03-22 Thread Juergen Gross
t_queue: the backend will send a notification > after consuming more requests. > > Signed-off-by: Stefano Stabellini > Reviewed-by: Boris Ostrovsky > CC: gr...@kaod.org > CC: jgr...@suse.com > CC: Eric Van Hensbergen > CC: Ron Minnich > CC: Latchesar Ionkov > CC: v9

Re: maybe revert commit c275a57f5ec3 "xen/balloon: Set balloon's initial state to number of existing RAM pages"

2017-03-23 Thread Juergen Gross
On 23/03/17 03:13, Boris Ostrovsky wrote: > > > On 03/22/2017 05:16 PM, Dan Streetman wrote: >> I have a question about a problem introduced by this commit: >> c275a57f5ec3056f732843b11659d892235faff7 >> "xen/balloon: Set balloon's initial state to number of existing RAM >> pages" >> >> It change

[PATCH] xen, fbfront: fix connecting to backend

2017-03-23 Thread Juergen Gross
: sta...@vger.kernel.org Signed-off-by: Juergen Gross --- drivers/video/fbdev/xen-fbfront.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c index d0115a7..3ee309c 100644 --- a/drivers/video/fbdev/xen-fbfront.c

[PATCH] xen, fbfront: add support for specifying size via xenstore

2017-03-23 Thread Juergen Gross
size. Signed-off-by: Juergen Gross --- drivers/video/fbdev/xen-fbfront.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c index 3ee309c..46f6396 100644 --- a/drivers/video/fbdev/xen-fbfront.c +++ b/drivers/video/

Re: [Xen-devel] [PATCH] xen, fbfront: fix connecting to backend

2017-03-23 Thread Juergen Gross
On 23/03/17 14:37, Jan Beulich wrote: On 23.03.17 at 13:52, wrote: >> Connecting to the backend isn't working reliably in xen-fbfront: in >> case XenbusStateInitWait of the backend has been missed the backend >> transition to XenbusStateConnected will trigger the connected state >> only witho

[GIT PULL] xen: fix for 4.11 rc4

2017-03-24 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-4.11b-rc4-tag xen: fix for 4.11 rc4 It contains a fix for PM under Xen. Thanks. Juergen drivers/xen/xen-acpi-processor.c | 36 +++- 1 file changed,

Re: [PATCH v3 4/7] xen/9pfs: connect to the backend

2017-03-14 Thread Juergen Gross
On 14/03/17 22:22, Stefano Stabellini wrote: > Hi Juergen, > > thank you for the review! > > On Tue, 14 Mar 2017, Juergen Gross wrote: >> On 14/03/17 00:50, Stefano Stabellini wrote: >>> Implement functions to handle the xenbus handshake. Upon connection, >>&

Re: [PATCH v3 03/21] x86/xen: add CONFIG_XEN_PV to Kconfig

2017-03-15 Thread Juergen Gross
On 14/03/17 18:35, Vitaly Kuznetsov wrote: > All code to support Xen PV will get under this new option. For the > beginning, check for it in the common code. > > Signed-off-by: Vitaly Kuznetsov > --- > Changes since v2: >select XEN_HAVE_PVMMU moved to config

Re: [PATCH v3 01/21] x86/xen: separate PV and HVM hypervisors

2017-03-15 Thread Juergen Gross
can be dropped. > > Signed-off-by: Vitaly Kuznetsov > --- > Changes since v2: >.pin_vcpu kept for x86_hyper_xen_hvm to support PVH Dom0 in future >[Juergen Gross] > --- Reviewed-by: Juergen Gross Juergen

Re: [PATCH v3 00/21] x86/xen: untangle PV and PVHVM guest support code

2017-03-15 Thread Juergen Gross
On 14/03/17 18:35, Vitaly Kuznetsov wrote: > Changes since v2: > - Rebase to 4.11.0-rc1+ > - XEN_HAVE_PVMMU moved to config XEN_PV [Juergen Gross] > - .pin_vcpu kept for x86_hyper_xen_hvm to support PVH Dom0 in future > [Juergen Gross] > - 'extern' qualifiers d

Re: [PATCH v3 4/7] xen/9pfs: connect to the backend

2017-03-15 Thread Juergen Gross
On 15/03/17 19:44, Stefano Stabellini wrote: > On Wed, 15 Mar 2017, Juergen Gross wrote: >> On 14/03/17 22:22, Stefano Stabellini wrote: >>> Hi Juergen, >>> >>> thank you for the review! >>> >>> On Tue, 14 Mar 2017, Juergen Gross w

Re: [PATCH v4 0/7] Xen transport for 9pfs frontend driver

2017-03-15 Thread Juergen Gross
On 15/03/17 20:23, Stefano Stabellini wrote: > Hi all, > > This patch series implements a new transport for 9pfs, aimed at Xen > systems. > > The transport is based on a traditional Xen frontend and backend drivers > pair. This patch series implements the frontend, which typically runs in > a reg

Re: [PATCH v4 4/7] xen/9pfs: connect to the backend

2017-03-15 Thread Juergen Gross
On 15/03/17 20:23, Stefano Stabellini wrote: > Implement functions to handle the xenbus handshake. Upon connection, > allocate the rings according to the protocol specification. > > Initialize a work_struct and a wait_queue. The work_struct will be used > to schedule work upon receiving an event c

Re: [PATCH v3 4/7] xen/9pfs: connect to the backend

2017-03-16 Thread Juergen Gross
On 16/03/17 19:03, Stefano Stabellini wrote: > On Thu, 16 Mar 2017, Juergen Gross wrote: >> On 15/03/17 19:44, Stefano Stabellini wrote: >>> On Wed, 15 Mar 2017, Juergen Gross wrote: >>>> On 14/03/17 22:22, Stefano Stabellini wrote: >>>>> Hi

[GIT PULL] xen: fix for 4.11 rc3

2017-03-16 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-4.11b-rc3-tag xen: fix for 4.11 rc3 It contains a minor fix for using the appropriate refcount_t instead of atomic_t. Thanks. Juergen drivers/xen/gntdev.c | 11 ++- 1 file

<    9   10   11   12   13   14   15   16   17   18   >