Re: [PATCH 3/3] xen blkback: add fault injection facility

2018-04-20 Thread Juergen Gross
On 20/04/18 12:47, Stanislav Kinsburskii wrote: > This patch adds wrapper helpers around generic Xen fault inject > facility. > The major reason is to keep all the module fault injection directories > in a dedicated subdirectory instead of Xen fault inject root. > > IOW, when using these helpers,

Re: [PATCH 2/3] xen netback: add fault injection facility

2018-04-20 Thread Juergen Gross
On 20/04/18 14:52, stask...@amazon.com wrote: > On 04/20/18 13:25, Juergen Gross wrote: >> On 20/04/18 12:47, Stanislav Kinsburskii wrote: >>> +    for (fi = 0; fi < XENVIF_FI_MAX; fi++) { >>> +    vfi->faults[fi] = xen_fi_dir_add(vfi->dir, >>>

Re: [PATCH] x86/xen: Remove use of VLAs

2018-04-16 Thread Juergen Gross
bound. > > [1] https://lkml.org/lkml/2018/3/7/621 > > Signed-off-by: Laura Abbott Reviewed-by: Juergen Gross Juergen

Re: [PATCH v2 1/5] ALSA: xen-front: Introduce Xen para-virtualized sound frontend driver

2018-04-16 Thread Juergen Gross
t; the state diagram and recovery flow from sound para-virtualized > protocol: xen/interface/io/sndif.h. > > Signed-off-by: Oleksandr Andrushchenko Only one minor nit (see below). With that addressed (or fixed when committing): Reviewed-by: Juergen Gross Juergen > --- > sou

Re: [PATCH v2 2/5] ALSA: xen-front: Read sound driver configuration from Xen store

2018-04-16 Thread Juergen Gross
On 16/04/18 08:24, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > Read configuration values from Xen store according > to xen/interface/io/sndif.h protocol: > - introduce configuration structures for different > components, e.g. sound card, device, stream > - read PCM

Re: [PATCH v2 3/5] ALSA: xen-front: Implement Xen event channel handling

2018-04-16 Thread Juergen Gross
On 16/04/18 08:24, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > Handle Xen event channels: > - create for all configured streams and publish > corresponding ring references and event channels in Xen store, > so backend can connect > - implement event channels int

Re: [PATCH v2 4/5] ALSA: xen-front: Implement handling of shared buffers

2018-04-16 Thread Juergen Gross
On 16/04/18 08:24, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > Implement shared buffer handling according to the > para-virtualized sound device protocol at xen/interface/io/sndif.h: > - manage buffer memory > - handle granted references > - handle page directories >

Re: [PATCH v2 5/5] ALSA: xen-front: Implement ALSA virtual sound driver

2018-04-16 Thread Juergen Gross
On 16/04/18 08:24, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > Implement essential initialization of the sound driver: > - introduce required data structures > - handle driver registration > - handle sound card registration > - register sound driver on backend conne

Re: [PATCH v7 1/7] xen/pvh: Split CONFIG_XEN_PVH into CONFIG_PVH and CONFIG_XEN_PVH

2018-04-16 Thread Juergen Gross
g option for PVH entry that can be enabled > independently from CONFIG_XEN. > > Signed-off-by: Maran Wilson Reviewed-by: Juergen Gross Juergen

Re: [PATCH v7 2/7] xen/pvh: Move PVH entry code out of Xen specific tree

2018-04-16 Thread Juergen Gross
low that, we are moving the PVH code out of Xen and > into files sitting at a higher level in the tree. > > This patch is not introducing any code or functional changes, just moving > files from one location to another. > > Signed-off-by: Maran Wilson > Reviewed-by: Konrad Rzes

Re: [PATCH v7 3/7] xen/pvh: Create a new file for Xen specific PVH code

2018-04-16 Thread Juergen Gross
Signed-off-by: Maran Wilson Reviewed-by: Juergen Gross Juergen

Re: [PATCH v7 6/7] xen/pvh: Add memory map pointer to hvm_start_info struct

2018-04-16 Thread Juergen Gross
w KVM guests to share the same entry point. > > Signed-off-by: Maran Wilson Reviewed-by: Juergen Gross Juergen

Re: [PATCH v7 7/7] KVM: x86: Allow Qemu/KVM to use PVH entry point

2018-04-16 Thread Juergen Gross
ing KVM > guests. > > Signed-off-by: Maran Wilson > Suggested-by: Konrad Rzeszutek Wilk > Suggested-by: Boris Ostrovsky > Tested-by: Boris Ostrovsky Reviewed-by: Juergen Gross You might want to send a follow-up patch to rename the functions in arch/x86/platform/pvh/* from xen_* to pvh_*. Juergen

Re: [PATCH] x86/xen: Remove use of VLAs

2018-04-17 Thread Juergen Gross
On 16/04/18 15:27, Boris Ostrovsky wrote: > On 04/13/2018 06:11 PM, Laura Abbott wrote: >> There's an ongoing effort to remove VLAs[1] from the kernel to eventually >> turn on -Wvla. The few VLAs in use have an upper bound based on a size >> of 64K. This doesn't produce an excessively large stack s

Re: [PATCH] xen: xenbus_dev_frontend: Really return response string

2018-04-17 Thread Juergen Gross
On 15/03/18 04:08, Simon Gaiser wrote: > xenbus_command_reply() did not actually copy the response string and > leaked stack content instead. > > Fixes: 9a6161fe73bd ("xen: return xenstore command failures via response > instead of rc") > Signed-off-by: Simon Gaiser

Re: [PATCH v2 2/5] ALSA: xen-front: Read sound driver configuration from Xen store

2018-04-17 Thread Juergen Gross
On 17/04/18 10:42, Oleksandr Andrushchenko wrote: > On 04/16/2018 03:55 PM, Juergen Gross wrote: >> On 16/04/18 08:24, Oleksandr Andrushchenko wrote: >>> +    goto fail; >>> +    } >>> + >>> +    if (!strncasecmp(str, XENSND_S

Re: [PATCH v2 3/5] ALSA: xen-front: Implement Xen event channel handling

2018-04-17 Thread Juergen Gross
On 17/04/18 10:58, Oleksandr Andrushchenko wrote: > On 04/16/2018 04:12 PM, Juergen Gross wrote: >> On 16/04/18 08:24, Oleksandr Andrushchenko wrote: >>> From: Oleksandr Andrushchenko >>> >>> Handle Xen event channels: >>>    - create for all configur

Re: [PATCH v2 4/5] ALSA: xen-front: Implement handling of shared buffers

2018-04-17 Thread Juergen Gross
On 17/04/18 11:22, Oleksandr Andrushchenko wrote: > On 04/16/2018 04:39 PM, Juergen Gross wrote: >> On 16/04/18 08:24, Oleksandr Andrushchenko wrote: >>> +static int alloc_int_buffers(struct xen_snd_front_shbuf *buf, >>> + int num_page

Re: [PATCH v2 5/5] ALSA: xen-front: Implement ALSA virtual sound driver

2018-04-17 Thread Juergen Gross
On 17/04/18 14:26, Oleksandr Andrushchenko wrote: > On 04/17/2018 02:32 PM, Oleksandr Andrushchenko wrote: >> On 04/16/2018 05:09 PM, Juergen Gross wrote: >>> On 16/04/18 08:24, Oleksandr Andrushchenko wrote: >>>> From: Oleksandr Andrushchenko >>>> >

Re: [PATCH] tracing/x86/xen: Remove zero data size trace events trace_xen_mmu_flush_tlb{_all}

2018-05-10 Thread Juergen Gross
el.org > Fixes: 95a7d76897c1e ("xen/mmu: Use Xen specific TLB flush instead of the > generic one.") > Signed-off-by: Steven Rostedt (VMware) Any reason not sending this patch to the Xen maintainers? I can take it through the Xen tree. :-) Reviewed-by: Juergen Gross Juergen

Re: [Xen-devel] [PATCH v2 1/3] xen/pvh: enable and set default MTRR type

2018-05-11 Thread Juergen Gross
On 09/05/18 17:11, Roger Pau Monné wrote: > On Wed, May 09, 2018 at 12:30:16PM +0100, Roger Pau Monné wrote: >> On Wed, May 09, 2018 at 11:56:40AM +0100, Andrew Cooper wrote: >>> On 09/05/18 11:21, Roger Pau Monne wrote: >>> I'm not sure that setting the default MTRR type is going to be a >>> cleve

Re: [PATCH v2 2/3] xen/store: do not store local values in xen_start_info

2018-05-11 Thread Juergen Gross
ed-off-by: Boris Ostrovsky > Signed-off-by: Roger Pau Monné Reviewed-by: Juergen Gross Juergen

Re: [PATCH v2 1/3] xen: xenbus_dev_frontend: Fix XS_TRANSACTION_END handling

2018-03-15 Thread Juergen Gross
saction twice corrupts the reference count. So fix this by also > considering a transaction closed if we have sent XS_TRANSACTION_END once > regardless of the return code. > > Cc: # 4.11 > Fixes: fd8aa9095a95 ("xen: optimize xenbus driver for multiple concurrent > xenstore accesses") > Signed-off-by: Simon Gaiser Reviewed-by: Juergen Gross Juergen

Re: [PATCH v2 3/3] xen: xenbus_dev_frontend: Verify body of XS_TRANSACTION_END

2018-03-15 Thread Juergen Gross
gt; > Signed-off-by: Simon Gaiser Reviewed-by: Juergen Gross Juergen

Re: [PATCH v2 2/3] xen: xenbus: Catch closing of non existent transactions

2018-03-15 Thread Juergen Gross
f-by: Simon Gaiser Reviewed-by: Juergen Gross Juergen

Re: [PATCH] xen: xenbus: Fix a possible data race in xs_request_enter

2018-05-08 Thread Juergen Gross
On 08/05/18 05:34, Jia-Ju Bai wrote: > The read operation to "req->type" is protected by > the lock on line 128, but the write operation to > this data on line 118 is not protected by the lock. > Thus, there may exist a data race for "req->type". > > To fix this data race, the write operation to "

Re: [PATCH] Input: xen-kbdfront - allow better run-time configuration

2018-04-19 Thread Juergen Gross
On 18/04/18 17:04, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > It is now only possible to control if multi-touch virtual device > is created or not (via the corresponding XenStore entries), > but keyboard and pointer devices are always created. Why don't you want to go tha

Re: [PATCH v2] xen/scsifront: don't request a slot on the ring until request is ready

2016-12-05 Thread Juergen Gross
On 05/12/16 16:32, Boris Ostrovsky wrote: > On 12/02/2016 01:15 AM, Juergen Gross wrote: >> >> -static struct vscsiif_request *scsifront_pre_req(struct vscsifrnt_info >> *info) >> +static int scsifront_do_request(struct vscsifrnt_info *info, >> +

Re: [PATCH] xen-scsifront: Add a missing call to kfree

2016-12-05 Thread Juergen Gross
On 05/12/16 21:53, Dan Carpenter wrote: > On Mon, Nov 21, 2016 at 07:01:36AM +0100, Juergen Gross wrote: >> On 19/11/16 19:22, Quentin Lambert wrote: >>> Most error branches following the call to kmalloc contain >>> a call to kfree. This patch add these calls

Re: [PATCH] xen/pci: Bubble up error and fix description.

2016-12-06 Thread Juergen Gross
On 06/12/16 15:28, Konrad Rzeszutek Wilk wrote: > The function is never called under PV guests, and only shows up > when MSI (or MSI-X) cannot be allocated. Convert the message > to include the error value. > > Signed-off-by: Konrad Rzeszutek Wilk Reviewed-by: Juergen Gross &g

Re: [RFC PATCH v3] xen/x86: Increase xen_e820_map to E820_X_MAX possible entries

2016-12-07 Thread Juergen Gross
On 05/12/16 18:49, Alex Thorlton wrote: > This is the third pass at my patchset to fix up our problems with > XENMEM_machine_memory_map on large systems. The only changes on this > pass were to flesh out the comment above the E820_X_MAX definition, and > to add Juergen's Reviewed-by to the second

Re: [PATCH 1/1 v2] xen: set error code on failures

2016-12-07 Thread Juergen Gross
g, assigning "-ENOMEM" to rc when > kzalloc() or alloc_page() returns NULL, and removing the initialization > of rc outside of the loop. > > v1 is reviewed by: Juergen Gross > > Signed-off-by: Pan Bian Commited to xen/tip.git for-linus-4.10 Juergen

Re: [PATCH 1/1 v2] xen: xenbus: set error code on failure

2016-12-07 Thread Juergen Gross
On 05/12/16 09:22, Pan Bian wrote: > Variable err is initialized with 0. As a result, the return value may > be 0 even if get_zeroed_page() fails to allocate memory. This patch fixes > the bug, initializing err with "-ENOMEM". > > v1 is reviewed by: Juergen Gross >

Re: [PATCH] xen/pci: Bubble up error and fix description.

2016-12-07 Thread Juergen Gross
On 06/12/16 15:28, Konrad Rzeszutek Wilk wrote: > The function is never called under PV guests, and only shows up > when MSI (or MSI-X) cannot be allocated. Convert the message > to include the error value. > > Signed-off-by: Konrad Rzeszutek Wilk Commited to xen/tip.git for-linus-4.10 Juergen

Re: [PATCH] xen-scsifront: Add a missing call to kfree

2016-11-21 Thread Juergen Gross
On 22/11/16 04:40, Martin K. Petersen wrote: >>>>>> "Juergen" == Juergen Gross writes: > > Juergen, > > Juergen> On 19/11/16 19:22, Quentin Lambert wrote: >>> Most error branches following the call to kmalloc contain a call to >>

Re: [PATCH v4] xen/gntdev: Use VM_MIXEDMAP instead of VM_IO to avoid NUMA balancing

2016-11-21 Thread Juergen Gross
On 22/11/16 04:59, Hugh Dickins wrote: > On Mon, 21 Nov 2016, Boris Ostrovsky wrote: > >> Commit 9c17d96500f7 ("xen/gntdev: Grant maps should not be subject to >> NUMA balancing") set VM_IO flag to prevent grant maps from being >> subjected to NUMA balancing. >> >> It was discovered recently that

Re: [PATCH] xen-scsifront: Add a missing call to kfree

2016-11-24 Thread Juergen Gross
On 19/11/16 19:22, Quentin Lambert wrote: > Most error branches following the call to kmalloc contain > a call to kfree. This patch add these calls where they are > missing. > > This issue was found with Hector. > > Signed-off-by: Quentin Lambert Applied to xen/tip.git for-linus-4.10 Juergen

[GIT PULL] xen: features and fixes for 4.10 rc2

2017-01-05 Thread Juergen Gross
call Juergen Gross (3): xen: xenbus driver must not accept invalid transaction ids xen: return xenstore command failures via response instead of rc xen: remove stale xs_input_avail() from header Ross Lagerwall (1): xen/setup: Don't relocate p2m over existing one Shyam

[PATCH 1/3] xen: clean up xenbus internal headers

2017-01-06 Thread Juergen Gross
include/xen/xenbus.h and the symbols used internal only to a new header drivers/xen/xenbus/xenbus.h Signed-off-by: Juergen Gross --- drivers/xen/xenbus/{xenbus_probe.h => xenbus.h} | 64 ++--- drivers/xen/xenbus/xenbus_client.c | 2 +- drivers/xen/xen

[PATCH 3/3] xen: optimize xenbus driver for multiple concurrent xenstore accesses

2017-01-06 Thread Juergen Gross
d-off-by: Juergen Gross --- I'm aware that the changes are quite large. I thought about sending a version split into multiple patches, but a lot of lines would have been touched by more than one patch. I still have the multiple patch variant lying around - this patch is split into 11 smaller o

[PATCH 2/3] xen: modify xenstore watch event interface

2017-01-06 Thread Juergen Gross
xenbus_watch *, const char *path, const char *token); is the natural thing to do. Apply this change and adapt all users. Cc: konrad.w...@oracle.com Cc: roger@citrix.com Cc: wei.l...@citrix.com Cc: paul.durr...@citrix.com Cc: net...@vger.kernel.org Signed-off-by: Juergen

[PATCH 0/3] xen: optimize xenbus performance

2017-01-06 Thread Juergen Gross
Xenstore being capable to handle multiple parallel accesses. Clean up the external interface(s) of xenbus and optimize its performance by allowing multiple concurrent accesses to Xenstore. Juergen Gross (3): xen: clean up xenbus internal headers xen: modify xenstore watch event interface xen

Re: [PATCH v2 3/3] xen: optimize xenbus driver for multiple concurrent xenstore accesses

2017-01-18 Thread Juergen Gross
On 18/01/17 21:14, Boris Ostrovsky wrote: > On 01/16/2017 09:15 AM, Juergen Gross wrote: >> + >> +static uint32_t xs_request_enter(struct xb_req_data *req) >> +{ >> +uint32_t rq_id; >> + >> +req->type = req->msg.type; >&g

[GIT PULL] xen: fix for 4.10 rc4

2017-01-18 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-4.10-rc4-tag It contains a fix for Xen running in nested virtualization environment. Thanks. Juergen drivers/xen/platform-pci.c | 71 ++

Re: [Intel-gfx] GPU hang with kernel 4.10rc3

2017-01-13 Thread Juergen Gross
On 12/01/17 10:21, Chris Wilson wrote: > On Thu, Jan 12, 2017 at 07:03:25AM +0100, Juergen Gross wrote: >> On 11/01/17 18:08, Chris Wilson wrote: >>> On Wed, Jan 11, 2017 at 05:33:34PM +0100, Juergen Gross wrote: >>>> With kernel 4.10rc3 running

Re: [PATCH v2] partially revert "xen: Remove event channel notification through Xen PCI platform device"

2017-01-15 Thread Juergen Gross
On 13/01/17 19:44, Boris Ostrovsky wrote: > On 01/13/2017 01:26 PM, Stefano Stabellini wrote: >> On Fri, 13 Jan 2017, Boris Ostrovsky wrote: >>> On 01/12/2017 04:39 PM, Stefano Stabellini wrote: The following commit: commit 72a9b186292d98494f26cfd24a1621796209 Author: KarimA

Re: [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM

2017-01-15 Thread Juergen Gross
uld be more than the actual slots, if there are > unconsumed responses. > > The fix is to calculate the count of newly created slots as the > difference between new req_prod and old req_prod. > > Signed-off-by: Vineeth Remanan Pillai Reviewed-by: Juergen Gross Thanks, Juergen

[PATCH v2 3/3] xen: optimize xenbus driver for multiple concurrent xenstore accesses

2017-01-16 Thread Juergen Gross
d-off-by: Juergen Gross --- V2: address comments of Boris Ostrovsky: - guard xs_request_id by lock - move state struct definitions to the place where they are being used - rate limit some warnings - use barrier() instead of cpu_relax() - add/remove some comments -

[PATCH v2 1/3] xen: clean up xenbus internal headers

2017-01-16 Thread Juergen Gross
symbols to include/xen/xenbus.h and the symbols used internally only to a new header drivers/xen/xenbus/xenbus.h replacing xenbus_comms.h and xenbus_probe.h Signed-off-by: Juergen Gross --- v2: update commit message, re-add lost copyright --- drivers/xen/xenbus/{xenbus_probe.h => xenbus.h} |

[PATCH v2 0/3] xen: optimize xenbus performance

2017-01-16 Thread Juergen Gross
: - guard xs_request_id by lock - move state struct definitions to the place where they are being used - rate limit some warnings - use barrier() instead of cpu_relax() - add/remove some comments - minor changes like naming of variables Juergen Gross (3): xen: clean up

[PATCH v2 2/3] xen: modify xenstore watch event interface

2017-01-16 Thread Juergen Gross
xenbus_watch *, const char *path, const char *token); is the natural thing to do. Apply this change and adapt all users. Cc: konrad.w...@oracle.com Cc: roger@citrix.com Cc: wei.l...@citrix.com Cc: paul.durr...@citrix.com Cc: net...@vger.kernel.org Signed-off-by: Juergen

Re: [PATCH 4/5] xen, x86/headers: Add dependency to

2017-02-01 Thread Juergen Gross
in functionality. > > Reported-by: kbuild test robot > Cc: Konrad Rzeszutek Wilk > Cc: > Cc: Juergen Gross Hmm, how did you send this? In spite of the Cc: list in the patch only few of those listed here are included in the Cc: header of the mail. > Cc: Linus Torvalds > C

[PATCH] drm/i915: fix i915 running as dom0 under Xen

2017-02-02 Thread Juergen Gross
c549f5f648 ("swiotlb: Export swiotlb_max_segment to users") to i915_gem_object_get_pages_internal(). So limit the maximum page order to be used according to the maximum swiotlb segment size instead to the complete swiotlb size. Signed-off-by: Juergen Gross --- Please consider for 4.10 as

[PATCH] xen,input: try to read screen resolution for xen-kbdfront

2017-01-24 Thread Juergen Gross
Instead of using the default resolution of 800*600 for the pointing device of xen-kbdfront try to read the resolution of the (virtual) framebuffer device. Use the default as fallback only. Cc: sta...@vger.kernel.org Signed-off-by: Juergen Gross --- drivers/input/misc/xen-kbdfront.c | 15

Re: [PATCH v3 3/3] xen: optimize xenbus driver for multiple concurrent xenstore accesses

2017-01-24 Thread Juergen Gross
On 24/01/17 14:47, Boris Ostrovsky wrote: > On 01/23/2017 01:59 PM, Boris Ostrovsky wrote: >> On 01/23/2017 05:09 AM, Juergen Gross wrote: >>> Handling of multiple concurrent Xenstore accesses through xenbus driver >>> either from the kernel or user land is rather lame t

Re: [PATCH 1/3] xen: clean up xenbus internal headers

2017-01-08 Thread Juergen Gross
On 06/01/17 21:52, Boris Ostrovsky wrote: > On 01/06/2017 10:05 AM, Juergen Gross wrote: >> The xenbus driver has an awful mixture of internal and global visible >> headers: some of the internal used only stuff is defined in the >> global header include/xen/xenbus.h while

Re: [PATCH 2/3] xen: modify xenstore watch event interface

2017-01-08 Thread Juergen Gross
On 06/01/17 22:57, Boris Ostrovsky wrote: > On 01/06/2017 10:05 AM, Juergen Gross wrote: >> Today a Xenstore watch event is delivered via a callback function >> declared as: >> >> void (*callback)(struct xenbus_watch *, >> const char **vec, unsi

Re: [PATCH 3/3] xen: optimize xenbus driver for multiple concurrent xenstore accesses

2017-01-09 Thread Juergen Gross
On 09/01/17 22:17, Boris Ostrovsky wrote: > On 01/06/2017 10:05 AM, Juergen Gross wrote: >> Handling of multiple concurrent Xenstore accesses through xenbus driver >> either from the kernel or user land is rather lame today: xenbus is >> capable to have one access active only

[PATCH 2/2] xen/netback: set default upper limit of tx/rx queues to 8

2017-01-10 Thread Juergen Gross
module parameter if required. Signed-off-by: Juergen Gross --- drivers/net/xen-netback/netback.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 47b4810..f9bcf4a 100644 --- a/drivers/net/xen

[PATCH 0/2] xen/net: limit number of tx/rx queues

2017-01-10 Thread Juergen Gross
the related guest. On large systems this can lead to ridiculous large number of queues exhausting the required number of grant pages rather quick. To avoid this limit the default maximum on both sides to 8. Both frontend and backend maximum can be individually tuned via module parameters. Juergen

[PATCH 1/2] xen/netfront: set default upper limit of tx/rx queues to 8

2017-01-10 Thread Juergen Gross
parameter if required. Signed-off-by: Juergen Gross --- drivers/net/xen-netfront.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index a479cd9..490c865 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net

Re: [PATCH 1/2] xen/netfront: set default upper limit of tx/rx queues to 8

2017-01-10 Thread Juergen Gross
On 10/01/17 15:53, Boris Ostrovsky wrote: > On 01/10/2017 08:32 AM, Juergen Gross wrote: >> The default for the number of tx/rx queues of one interface is the >> number of vcpus of the system today. As each queue pair reserves 512 >> grant pages this default consumes a ridicu

Re: [PATCH 3/3] xen: optimize xenbus driver for multiple concurrent xenstore accesses

2017-01-10 Thread Juergen Gross
On 10/01/17 17:36, Boris Ostrovsky wrote: > +static int process_msg(void) +{ + static struct xs_thread_state_read state; + struct xb_req_data *req; + int err; + unsigned int len; + + if (!state.in_msg) { + state.in_msg = true; +

Re: Re: [Intel-gfx] GPU hang with kernel 4.10rc3

2017-01-23 Thread Juergen Gross
On 13/01/17 15:41, Juergen Gross wrote: > On 12/01/17 10:21, Chris Wilson wrote: >> On Thu, Jan 12, 2017 at 07:03:25AM +0100, Juergen Gross wrote: >>> On 11/01/17 18:08, Chris Wilson wrote: >>>> On Wed, Jan 11, 2017 at 05:33:34PM +0100, Juergen Gross wrote: >>&g

[PATCH v3 0/3] xen: optimize xenbus performance

2017-01-23 Thread Juergen Gross
like naming of variables Juergen Gross (3): xen: clean up xenbus internal headers xen: modify xenstore watch event interface xen: optimize xenbus driver for multiple concurrent xenstore accesses drivers/block/xen-blkback/xenbus.c | 6 +- drivers/net/xen-netback/xenbus.c

[PATCH v3 2/3] xen: modify xenstore watch event interface

2017-01-23 Thread Juergen Gross
xenbus_watch *, const char *path, const char *token); is the natural thing to do. Apply this change and adapt all users. Cc: konrad.w...@oracle.com Cc: roger@citrix.com Cc: wei.l...@citrix.com Cc: paul.durr...@citrix.com Cc: net...@vger.kernel.org Signed-off-by: Juergen

[PATCH v3 3/3] xen: optimize xenbus driver for multiple concurrent xenstore accesses

2017-01-23 Thread Juergen Gross
d-off-by: Juergen Gross --- V3: - simplify xs_request_enter() as requested by Boris Ostrovsky V2: address comments of Boris Ostrovsky: - guard xs_request_id by lock - move state struct definitions to the place where they are being used - rate limit some warnings - use ba

[PATCH v3 1/3] xen: clean up xenbus internal headers

2017-01-23 Thread Juergen Gross
symbols to include/xen/xenbus.h and the symbols used internally only to a new header drivers/xen/xenbus/xenbus.h replacing xenbus_comms.h and xenbus_probe.h Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky --- v2: update commit message, re-add lost copyright --- drivers/xen/xenbus

Re: [PATCH] xen,input: try to read screen resolution for xen-kbdfront

2017-01-26 Thread Juergen Gross
On 24/01/17 19:47, Dmitry Torokhov wrote: > On Tue, Jan 24, 2017 at 01:09:55PM +0100, Juergen Gross wrote: >> Instead of using the default resolution of 800*600 for the pointing >> device of xen-kbdfront try to read the resolution of the (virtual) >> framebuffer device. Use th

[PATCH v2] xen,input: try to read screen resolution for xen-kbdfront

2017-01-26 Thread Juergen Gross
Instead of using the default resolution of 800*600 for the pointing device of xen-kbdfront try to read the resolution of the (virtual) framebuffer device. Use the default as fallback only. Signed-off-by: Juergen Gross --- V2: get framebuffer resolution only if CONFIG_FB (Dmitry Torokhov

Re: [Xen-devel] [PATCH v2] xen, input: try to read screen resolution for xen-kbdfront

2017-01-27 Thread Juergen Gross
On 27/01/17 08:21, Oleksandr Andrushchenko wrote: > On 01/27/2017 09:12 AM, Juergen Gross wrote: >> Instead of using the default resolution of 800*600 for the pointing >> device of xen-kbdfront try to read the resolution of the (virtual) >> framebuffer device. Use the def

Re: [Xen-devel] [PATCH v2] xen, input: try to read screen resolution for xen-kbdfront

2017-01-27 Thread Juergen Gross
On 27/01/17 08:53, Oleksandr Andrushchenko wrote: > On 01/27/2017 09:46 AM, Juergen Gross wrote: >> On 27/01/17 08:21, Oleksandr Andrushchenko wrote: >>> On 01/27/2017 09:12 AM, Juergen Gross wrote: >>>> Instead of using the default resolution of 800*600 for t

Re: [Xen-devel] [PATCH v2] xen, input: try to read screen resolution for xen-kbdfront

2017-01-27 Thread Juergen Gross
On 27/01/17 09:26, Oleksandr Andrushchenko wrote: > On 01/27/2017 10:14 AM, Juergen Gross wrote: >> On 27/01/17 08:53, Oleksandr Andrushchenko wrote: >>> On 01/27/2017 09:46 AM, Juergen Gross wrote: >>>> On 27/01/17 08:21, Oleksandr Andrushchenko wrote: >>>&

Re: [PATCH] x86/xen: Fix APIC id mismatch warning on Intel

2017-01-27 Thread Juergen Gross
pu).apicid by calling hard_smp_processor_id()->xen_apic_read() > as opposed to using apicid from cpuid as is done on Intel machines. > > Signed-off-by: Mohit Gambhir Reviewed-by: Juergen Gross Thanks, Juergen

Re: [PATCH v1 3/3] MAINTAINERS: xen, kvm: track pvclock-abi.h changes

2017-01-27 Thread Juergen Gross
n PVCLOCK (if not now maybe in future). For both variants: Acked-by: Juergen Gross Juergen > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 26edd83..c4315d1 100644 > --- a/MAINTAINERS > +++ b/MAINTAINER

Re: [PATCH v2 9/9] xen/pvh: Use Xen's emergency_restart op for PVH guests

2017-01-27 Thread Juergen Gross
On 26/01/17 20:41, Boris Ostrovsky wrote: > Using native_machine_emergency_restart (called during reboot) will > lead PVH guests to machine_real_restart() where we try to use > real_mode_header which is not initialized. > > Signed-off-by: Boris Ostrovsky Reviewed-by: Juergen Gross Juergen

Re: [PATCH v2 8/9] xen/pvh: Enable CPU hotplug

2017-01-27 Thread Juergen Gross
On 26/01/17 20:41, Boris Ostrovsky wrote: > PVH guests don't (yet) receive ACPI hotplug interrupts and therefore > need to monitor xenstore for CPU hotplug event. > > Signed-off-by: Boris Ostrovsky Reviewed-by: Juergen Gross Juergen

Re: [PATCH v2 6/9] xen/pvh: Initialize grant table for PVH guests

2017-01-27 Thread Juergen Gross
On 26/01/17 20:41, Boris Ostrovsky wrote: > Like PV guests, PVH does not have PCI devices and therefore cannot > use MMIO space to store grants. Instead it balloons out memory and > keeps grants there. > > Signed-off-by: Boris Ostrovsky Reviewed-by: Juergen Gross Juergen

Re: [Xen-devel] [PATCH v2] xen, input: try to read screen resolution for xen-kbdfront

2017-01-30 Thread Juergen Gross
On 27/01/17 17:10, Dmitry Torokhov wrote: > On January 27, 2017 12:31:19 AM PST, Juergen Gross wrote: >> On 27/01/17 09:26, Oleksandr Andrushchenko wrote: >>> On 01/27/2017 10:14 AM, Juergen Gross wrote: >>>> On 27/01/17 08:53, Oleksandr Andrushchenko wrote: >>

[PATCH v3] xen,input: try to read screen resolution for xen-kbdfront

2017-01-30 Thread Juergen Gross
Instead of using the default resolution of 800*600 for the pointing device of xen-kbdfront try to read the resolution of the (virtual) framebuffer device. Use the default as fallback only. Signed-off-by: Juergen Gross --- V3: add case of late framebuffer registration (Oleksandr Andrushchenko) V2

Re: [PATCH 1/3] xen-scsiback: Delete an unnecessary check before the function call "kfree"

2016-07-17 Thread Juergen Gross
using the Coccinelle software. > > Signed-off-by: Markus Elfring Reviewed-by: Juergen Gross Juergen

Re: [PATCH 3/3] xen-scsiback: Pass a failure indication as a constant

2016-07-17 Thread Juergen Gross
On 16/07/16 22:24, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 16 Jul 2016 21:55:01 +0200 > > Pass the constant "FAILED" in a function call directly instead of > using an intialisation for a local variable. > > Signed-off-by: Markus Elfri

Re: [PATCH 2/3] xen-scsiback: One function call less in scsiback_device_action() after error detection

2016-07-17 Thread Juergen Gross
On 16/07/16 22:23, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 16 Jul 2016 21:42:42 +0200 > > The kfree() function was called in one case by the > scsiback_device_action() function during error handling > even if the passed variable "tmr" contained a null pointer. > > Adjust jum

[PATCH 2/3] arm/xen: add support for vm_assist hypercall

2016-06-22 Thread Juergen Gross
Add support for the Xen HYPERVISOR_vm_assist hypercall. Signed-off-by: Juergen Gross --- arch/arm/include/asm/xen/hypercall.h | 1 + arch/arm/xen/enlighten.c | 1 + arch/arm/xen/hypercall.S | 1 + arch/arm64/xen/hypercall.S | 1 + 4 files changed, 4 insertions

[PATCH 1/3] xen: update xen headers

2016-06-22 Thread Juergen Gross
Update some Xen headers to be able to use new functionality. Signed-off-by: Juergen Gross --- include/xen/interface/vcpu.h | 24 +++- include/xen/interface/xen.h | 17 - 2 files changed, 31 insertions(+), 10 deletions(-) diff --git a/include/xen/interface

[PATCH 0/3] xen: add full support for CONFIG_PARAVIRT_TIME_ACCOUNTING

2016-06-22 Thread Juergen Gross
tested on arm64. Juergen Gross (3): xen: update xen headers arm/xen: add support for vm_assist hypercall xen: support runqueue steal time on xen arch/arm/include/asm/xen/hypercall.h | 1 + arch/arm/xen/enlighten.c | 1 + arch/arm/xen/hypercall.S | 1 + arch

[PATCH 3/3] xen: support runqueue steal time on xen

2016-06-22 Thread Juergen Gross
: Juergen Gross --- drivers/xen/time.c | 42 +- 1 file changed, 25 insertions(+), 17 deletions(-) diff --git a/drivers/xen/time.c b/drivers/xen/time.c index 2257b66..65afbe9 100644 --- a/drivers/xen/time.c +++ b/drivers/xen/time.c @@ -19,6 +19,9

[PATCH] xen: fix upper bound of pmd loop in xen_cleanhighmap()

2016-06-22 Thread Juergen Gross
xen_cleanhighmap() is operating on level2_kernel_pgt only. The upper bound of the loop setting non-kernel-image entries to zero should not exceed the size of level2_kernel_pgt. Reported-by: Linus Torvalds Signed-off-by: Juergen Gross --- arch/x86/xen/mmu.c | 2 +- 1 file changed, 1 insertion

Re: [PATCH 3/3] xen: support runqueue steal time on xen

2016-07-05 Thread Juergen Gross
On 05/07/16 17:23, Stefano Stabellini wrote: > On Wed, 22 Jun 2016, Juergen Gross wrote: >> Up to now reading the stolen time of a remote cpu was not possible in a >> performant way under Xen. This made support of runqueue steal time via >> paravirt_steal_rq_enabled impos

[PATCH v2 0/3] xen: add full support for CONFIG_PARAVIRT_TIME_ACCOUNTING

2016-07-05 Thread Juergen Gross
tested on arm64. Changes in V2: - patch 3: removed static variable as requested by Stefano Stabellini Juergen Gross (3): xen: update xen headers arm/xen: add support for vm_assist hypercall xen: support runqueue steal time on xen arch/arm/include/asm/xen/hypercall.h | 1 + arch/arm/xen/e

[PATCH v2 3/3] xen: support runqueue steal time on xen

2016-07-05 Thread Juergen Gross
: Juergen Gross --- V2: removed static variable as requested by Stefano Stabellini --- drivers/xen/time.c | 40 +++- 1 file changed, 23 insertions(+), 17 deletions(-) diff --git a/drivers/xen/time.c b/drivers/xen/time.c index 2257b66..a7fe35b 100644 --- a/drivers

[PATCH v2 1/3] xen: update xen headers

2016-07-05 Thread Juergen Gross
Update some Xen headers to be able to use new functionality. Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky Reviewed-by: Stefano Stabellini --- include/xen/interface/vcpu.h | 24 +++- include/xen/interface/xen.h | 17 - 2 files changed, 31

[PATCH v2 2/3] arm/xen: add support for vm_assist hypercall

2016-07-05 Thread Juergen Gross
Add support for the Xen HYPERVISOR_vm_assist hypercall. Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky Reviewed-by: Julien Grall Reviewed-by: Stefano Stabellini --- arch/arm/include/asm/xen/hypercall.h | 1 + arch/arm/xen/enlighten.c | 1 + arch/arm/xen/hypercall.S

Re: [PATCH v2 0/4] implement vcpu preempted check

2016-07-06 Thread Juergen Gross
On 06/07/16 08:52, Peter Zijlstra wrote: > On Tue, Jun 28, 2016 at 10:43:07AM -0400, Pan Xinhui wrote: >> change fomr v1: >> a simplier definition of default vcpu_is_preempted >> skip mahcine type check on ppc, and add config. remove dedicated macro. >> add one patch to drop overload

Re: [PATCH v2 0/4] implement vcpu preempted check

2016-07-06 Thread Juergen Gross
On 06/07/16 10:19, Peter Zijlstra wrote: > On Wed, Jul 06, 2016 at 09:47:18AM +0200, Juergen Gross wrote: >> On 06/07/16 08:52, Peter Zijlstra wrote: > >>> Paolo, could you help out with an (x86) KVM interface for this? >> >> Xen support of this interface should

Re: [PATCH] xenbus: prefer list_for_each()

2016-07-07 Thread Juergen Gross
On 07/07/16 09:33, Jan Beulich wrote: > ... over list_for_each_safe() when list modification if accompanied by > breaking out of the loop. > > Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross > --- > drivers/xen/xenbus/xenbus_dev_frontend.c |4 ++-- > 1 file

Re: [PATCH v5 2/6] virt, sched: add generic vcpu pinning support

2016-06-15 Thread Juergen Gross
On 06/04/16 16:17, Juergen Gross wrote: Add generic virtualization support for pinning the current vcpu to a specified physical cpu. As this operation isn't performance critical (a very limited set of operations like BIOS calls and SMIs is expected to need this) just add a hypervisor spe

Re: [PATCH v5 5/6] dcdbas: make use of smp_call_on_cpu()

2016-06-15 Thread Juergen Gross
On 06/04/16 16:17, Juergen Gross wrote: Use smp_call_on_cpu() to raise SMI on cpu 0. Make call secure by adding get_online_cpus() to avoid e.g. suspend resume cycles in between. Signed-off-by: Juergen Gross Could please some maintainer comment on this patch? Juergen --- V4: add call to

Re: [PATCH 6/8] x86: xen: audit and remove any unnecessary uses of module.h

2016-07-13 Thread Juergen Gross
scure what > headers we are effectively using. > > Since module.h was the source for init.h (for __init) and for > export.h (for EXPORT_SYMBOL) we consider each obj-y/bool instance > for the presence of either and replace as needed. > > Cc: Boris Ostrovsky > Cc: David Vrabel >

Re: [PATCH] xen/x86: Define stubs for xen_smp_intr_init/xen_smp_intr_free

2016-07-25 Thread Juergen Gross
On 25/07/16 23:14, Boris Ostrovsky wrote: > xen_smp_intr_init() and xen_smp_intr_free() are now called from > enlighten.c and therefore not guaranteed to have CONFIG_SMP. > > Instead of adding multiple ifdefs there provide stubs in smp.h > > Signed-off-by: Boris Ostrovsky Re

<    8   9   10   11   12   13   14   15   16   17   >