Re: [PATCH v3] xen: Fix x86 sched_clock() interface for xen

2019-01-16 Thread Juergen Gross
On 16/01/2019 16:07, Boris Ostrovsky wrote: > On 1/16/19 9:33 AM, Juergen Gross wrote: >> On 16/01/2019 14:17, Boris Ostrovsky wrote: >>> On Wed, Jan 16, 2019 at 08:50:13AM +0100, Juergen Gross wrote: >>> >>>> @@ -1650,13 +1

Re: [PATCH v15 5/6] x86/boot: Parse SRAT address from RSDP and store immovable memory

2019-01-17 Thread Juergen Gross
On 17/01/2019 09:22, Kairui Song wrote: > On Thu, Jan 17, 2019 at 3:58 PM Chao Fan wrote: >> >> On Wed, Jan 16, 2019 at 03:28:52PM +0800, Kairui Song wrote: >>> On Mon, Jan 7, 2019 at 11:24 AM Chao Fan wrote: + +/* Determine RSDP, based on acpi_os_get_root_pointer(). */ +stati

Re: [PATCH] MAINTAINERS: unify reference to xen-devel list

2019-01-14 Thread Juergen Gross
-de...@lists.xen.org instead, but that is just the same > mailing list as the mailing list above. > > Signed-off-by: Lukas Bulwahn Reviewed-by: Juergen Gross Juergen

Re: [PATCH v2] xen: Fix x86 sched_clock() interface for xen

2019-01-14 Thread Juergen Gross
On 11/01/2019 21:35, Boris Ostrovsky wrote: > On 1/11/19 7:08 AM, Juergen Gross wrote: >> @@ -421,6 +424,11 @@ void xen_restore_time_memory_area(void) >> if (ret != 0) >> pr_notice("Cannot restore secondary vcpu_time_info (err %d)", >>

[PATCH v3] xen: Fix x86 sched_clock() interface for xen

2019-01-14 Thread Juergen Gross
ity to 16777216 Fix that by setting xen_sched_clock_offset at resume time to ensure a monotonic clock value. Fixes: f94c8d11699759 ("sched/clock, x86/tsc: Rework the x86 'unstable' sched_clock() interface") Cc: # 4.11 Reported-by: Hans van Kranenburg Signed-off-by: Juer

Re: [PATCH] x86/mm/mem_encrypt_identity : fix error useage to sizeof

2019-01-15 Thread Juergen Gross
On 15/01/2019 11:13, Thomas Gleixner wrote: > On Mon, 7 Jan 2019, peng.h...@zte.com.cn wrote: > Fix error usage to sizeof. It should not use sizeof to pointer. >>> >>> because? >>> >>> The commit message needs to explain what the potential issue could be >>> and why it doesn't matter in

Re: [PATCH] x86/mm/mem_encrypt_identity : fix error useage to sizeof

2019-01-15 Thread Juergen Gross
On 15/01/2019 11:25, Thomas Gleixner wrote: > On Tue, 15 Jan 2019, Juergen Gross wrote: >> On 15/01/2019 11:13, Thomas Gleixner wrote: >>> On Mon, 7 Jan 2019, peng.h...@zte.com.cn wrote: >>> >>>>>> Fix error usage to sizeof. It should not us

Re: [PATCH v3] xen: Fix x86 sched_clock() interface for xen

2019-01-15 Thread Juergen Gross
On 15/01/2019 11:43, Thomas Gleixner wrote: > On Mon, 14 Jan 2019, Juergen Gross wrote: > >> Commit f94c8d11699759 ("sched/clock, x86/tsc: Rework the x86 'unstable' >> sched_clock() interface") broke Xen guest time handling across >> migration: >&g

[GIT PULL] xen: fixes for 5.0-rc3

2019-01-18 Thread Juergen Gross
| 2 +- drivers/xen/pvcalls-back.c | 9 ++-- drivers/xen/pvcalls-front.c | 104 --- 5 files changed, 90 insertions(+), 42 deletions(-) Juergen Gross (1): xen: Fix x86 sched_clock() interface for xen Stefano Stabellini (5): pvcalls-front

Re: [Xen-devel] xen/mem-reservation API and out-of-tree kernel modules

2019-02-01 Thread Juergen Gross
On 01/02/2019 09:39, Oleksandr Andrushchenko wrote: > On 1/31/19 11:44 PM, Stefano Stabellini wrote: >> On Thu, 31 Jan 2019, Oleksandr Andrushchenko wrote: >>> Hello, >>> >>> I am working on porting an out-of-tree kernel driver to the kernel >>> 5.0 and that driver uses functionality provided by >>

Re: RIP: e030:move_page_tables+0xaa3/0xb80

2019-02-04 Thread Juergen Gross
On 02/02/2019 05:37, Christian Kujau wrote: > Hi, > > I'm running an Ubuntu "mainline" kernel[0] as a Xen 4.11.1 DomU (PV) and > ever since upgrading to Linux 5.0-rcX I get these WARNING messages shown > below. Going back in my logs[1] I can see that I got a similar messages > for v4.20 too, bu

Re: [PATCH 1/2] x86: respect memory size limiting via mem= parameter

2019-01-23 Thread Juergen Gross
On 23/01/2019 15:35, William Kucharski wrote: > > >> On Jan 22, 2019, at 1:06 AM, Juergen Gross wrote: >> >> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c >> index b9a667d36c55..7fc2a87110a3 100644 >> --- a/mm/memory_hotplug.c >> +++ b/mm/me

Re: [RFC PATCH 5/6] x86/mm/tlb: Flush remote and local TLBs concurrently

2019-05-25 Thread Juergen Gross
hen Hemminger > Cc: Sasha Levin > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: x...@kernel.org > Cc: Juergen Gross > Cc: Paolo Bonzini > Cc: Dave Hansen > Cc: Andy Lutomirski > Cc: Peter Zijlstra > Cc: Boris Ostrovsky > Cc:

Re: [PATCH -next] xen/pvcalls: Remove set but not used variable

2019-05-26 Thread Juergen Gross
drivers/xen/pvcalls-front.c: In function pvcalls_front_recvmsg: > drivers/xen/pvcalls-front.c:638:25: warning: variable bedata set but not used > [-Wunused-but-set-variable] > > They are never used since introduction. > > Signed-off-by: YueHaibing Reviewed-by: Juergen Gross Juergen

Re: [PATCH v7 11/12] x86/paravirt: Adapt assembly for PIE support

2019-05-26 Thread Juergen Gross
l allow to extend the > KASLR randomization range below 0x8000. > > Signed-off-by: Thomas Garnier Acked-by: Juergen Gross Juergen

Re: [PATCH v2 3/5] locking/qspinlock: Introduce CNA into the slow path of qspinlock

2019-04-03 Thread Juergen Gross
On 03/04/2019 18:01, Peter Zijlstra wrote: > On Wed, Apr 03, 2019 at 11:39:09AM -0400, Alex Kogan wrote: > The patch that I am looking for is to have a separate numa_queued_spinlock_slowpath() that coexists with native_queued_spinlock_slowpath() and paravirt_queued_spinlock_slo

Re: [patch V2 25/29] x86/irq/32: Invoke irq_ctx_init() from init_IRQ()

2019-04-05 Thread Juergen Gross
ive or XEN init > implementation. > > Signed-off-by: Thomas Gleixner > Cc: Juergen Gross Reviewed-by: Juergen Gross Juergen

Re: [PATCH v2 5/9] x86/xen: Mark xen_vcpu_stolen as __visible

2019-03-30 Thread Juergen Gross
On 30/03/2019 01:47, Andi Kleen wrote: > From: Andi Kleen > > This function is referenced from assembler, so needs to be marked > __visible for LTO. > > Cc: jgr...@suse.com > Cc: boris.ostrov...@oracle.com > Signed-off-by: Andi Kleen Acked-by: Juergen Gross Juergen

Re: [PATCH 01/22] x86/paravirt: Fix callee-saved function ELF sizes

2019-07-14 Thread Juergen Gross
: __raw_callee_save_xen_make_pgd() is missing an ELF size annotation Signed-off-by: Josh Poimboeuf Reviewed-by: Juergen Gross Juergen

[PATCH 1/2] x86/xen: remove 32-bit Xen PV guest support

2019-07-15 Thread Juergen Gross
Xen is requiring 64-bit machines today. There is no need to carry the burden of 32-bit PV guest support in the kernel any longer, as new guests can be either HVM or PVH, or they can use a 64 bit kernel. Remove the 32-bit Xen PV support from the kernel. Signed-off-by: Juergen Gross --- arch/x86

[PATCH 0/2] Remove 32-bit Xen PV guest support

2019-07-15 Thread Juergen Gross
PV guest support alive in the Linux kernel. Additionally Meltdown mitigation is not available in the kernel running as 32-bit PV guest, so dropping this mode makes sense from security point of view, too. Juergen Gross (2): x86/xen: remove 32-bit Xen PV guest support x86/paravirt: remove 32-bit

[PATCH 2/2] x86/paravirt: remove 32-bit support from PARAVIRT_XXL

2019-07-15 Thread Juergen Gross
The last 32-bit user of stuff under CONFIG_PARAVIRT_XXL is gone. Remove 32-bit specific parts. Signed-off-by: Juergen Gross --- arch/x86/entry/vdso/vdso32/vclock_gettime.c | 1 + arch/x86/include/asm/paravirt.h | 105 arch/x86/include/asm

Re: [PATCH 0/2] Remove 32-bit Xen PV guest support

2019-07-15 Thread Juergen Gross
On 15.07.19 14:32, Peter Zijlstra wrote: On Mon, Jul 15, 2019 at 01:37:37PM +0200, Juergen Gross wrote: The long term plan has been to replace Xen PV guests by PVH. The first victim of that plan are now 32-bit PV guests, as those are used only rather seldom these days. Xen on x86 requires 64

Re: [PATCH] x86/paravirt: Drop {read,write}_cr8() hooks

2019-07-15 Thread Juergen Gross
On 15.07.19 15:00, Andrew Cooper wrote: There is a lot of infrastructure for functionality which is used exclusively in __{save,restore}_processor_state() on the suspend/resume path. cr8 is an alias of APIC_TASKPRI, and APIC_TASKPRI is saved/restored independently by lapic_{suspend,resume}().

Re: [PATCH v3 4/9] x86/mm/tlb: Flush remote and local TLBs concurrently

2019-07-26 Thread Juergen Gross
Zhang Cc: Stephen Hemminger Cc: Sasha Levin Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: x...@kernel.org Cc: Juergen Gross Cc: Paolo Bonzini Cc: Dave Hansen Cc: Andy Lutomirski Cc: Peter Zijlstra Cc: Boris Ostrovsky Cc: linux-hyp...@vger.kernel.org Cc: linux-kernel@vger.

[GIT PULL] xen: fixes for 5.3-rc3

2019-08-02 Thread Juergen Gross
+++ 7 files changed, 56 insertions(+), 57 deletions(-) Arnd Bergmann (1): xen: avoid link error on ARM Juergen Gross (3): xen/swiotlb: fix condition for calling xen_destroy_contiguous_region() xen/swiotlb: simplify range_straddles_page_boundary() xen/swiotlb: remember

Re: [PATCH v2 20/34] xen: convert put_page() to put_user_page*()

2019-08-04 Thread Juergen Gross
fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder versions"). This also handles pages[i] == NULL cases, thanks to an approach that is actually written by Juergen Gross. Signed-off-by: Juergen Gross Signed-off-by: John Hubbard Cc: Boris Ostrovsky Cc: xen-de...@lists.xenproject.o

Re: [PATCH] [v3] xen: avoid link error on ARM

2019-07-30 Thread Juergen Gross
hen Xen is enabled, as suggested by Juergen Gross and Boris Ostrovsky. Signed-off-by: Arnd Bergmann Pushed to xen/tip.git for-linus-5.3a Juergen

Re: [PATCH] xen/gntdev.c: Replace vm_map_pages() with vm_map_pages_zero()

2019-07-30 Thread Juergen Gross
On 30.07.19 20:34, Souptick Joarder wrote: 'commit df9bde015a72 ("xen/gntdev.c: convert to use vm_map_pages()")' breaks gntdev driver. If vma->vm_pgoff > 0, vm_map_pages() will: - use map->pages starting at vma->vm_pgoff instead of 0 - verify map->count against vma_pages()+vma->vm_pgoff inste

Re: [patch 11/12] hrtimer: Prepare support for PREEMPT_RT

2019-07-31 Thread Juergen Gross
On 29.07.19 19:30, Paolo Bonzini wrote: On 29/07/19 17:08, Steven Rostedt wrote: On Sun, 28 Jul 2019 11:06:50 +0200 Juergen Gross wrote: In case we'd want to change that I'd rather not special case timers, but apply a more general solution to the quite large amount of similar cases

Re: [PATCH 1/6] x86/xen: Mark xen_hvm_need_lapic() and xen_hvm_need_lapic() as __init

2019-06-24 Thread Juergen Gross
On 23.06.19 15:01, Zhenzhong Duan wrote: .. as they are only called at early bootup stage. In fact, other functions in x86_hyper_xen_hvm.init.* are all marked as __init. Unexport xen_hvm_need_lapic as it's never used outside. Signed-off-by: Zhenzhong Duan Reviewed-by: Juergen

Re: [PATCH 3/6] x86: Add nopv parameter to disable PV extensions

2019-06-24 Thread Juergen Gross
On 23.06.19 15:01, Zhenzhong Duan wrote: In virtualization environment, PV extensions (drivers, interrupts, timers, etc) are enabled in the majority of use cases which is the best option. However, in some cases (kexec not fully working, benchmarking) we want to disable PV extensions. As such int

Re: [PATCH 3/6] x86: Add nopv parameter to disable PV extensions

2019-06-24 Thread Juergen Gross
On 23.06.19 15:01, Zhenzhong Duan wrote: In virtualization environment, PV extensions (drivers, interrupts, timers, etc) are enabled in the majority of use cases which is the best option. However, in some cases (kexec not fully working, benchmarking) we want to disable PV extensions. As such int

Re: [PATCH] mm: fix regression with deferred struct page init

2019-06-25 Thread Juergen Gross
Gentle ping. I'd really like to have that in 5.2 in order to avoid the regression introduced with 5.2-rc1. Juergen On 20.06.19 18:08, Juergen Gross wrote: Commit 0e56acae4b4dd4a9 ("mm: initialize MAX_ORDER_NR_PAGES at a time instead of doing larger sections") is causing a reg

Re: [PATCH v2 5/7] x86/xen: nopv parameter support for HVM guest

2019-06-25 Thread Juergen Gross
the detection of PVH in xen_platform_hvm(), xen_pvh_domain() could be used for that purpose. Signed-off-by: Zhenzhong Duan Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: xen-de...@lists.xenproject.org --- arch/x86/xen

Re: [PATCH v2 5/7] x86/xen: nopv parameter support for HVM guest

2019-06-26 Thread Juergen Gross
On 26.06.19 10:56, Zhenzhong Duan wrote: On 2019/6/25 20:31, Juergen Gross wrote: On 24.06.19 14:02, Zhenzhong Duan wrote: PVH guest needs PV extentions to work, so nopv parameter is ignored for PVH but not for HVM guest. In order for nopv parameter to take effect for HVM guest, we need to

Re: [PATCH v2 4/7] Revert "xen: Introduce 'xen_nopv' to disable PV extensions for HVM guests."

2019-06-26 Thread Juergen Gross
On 24.06.19 14:02, Zhenzhong Duan wrote: This reverts commit 8d693b911bb9c57009c24cb1772d205b84c7985c. Instead we use an unified parameter 'nopv' for all the hypervisor platforms. Signed-off-by: Zhenzhong Duan Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: Thoma

Re: [PATCH v2 3/7] x86: Add nopv parameter to disable PV extensions

2019-06-26 Thread Juergen Gross
only if nopv is false or ignore_nopv is true. There is already 'xen_nopv' parameter for XEN platform but not for others. 'xen_nopv' can then be removed with this change. Suggested-by: Juergen Gross Signed-off-by: Zhenzhong Duan Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Pe

Re: [Xen-devel] [PATCH] mm: fix regression with deferred struct page init

2019-06-27 Thread Juergen Gross
On 25.06.19 10:25, Juergen Gross wrote: Gentle ping. I'd really like to have that in 5.2 in order to avoid the regression introduced with 5.2-rc1. Adding some maintainers directly... Juergen Juergen On 20.06.19 18:08, Juergen Gross wrote: Commit 0e56acae4b4dd4a9 ("mm:

Re: [PATCH v2 4/9] x86/mm/tlb: Flush remote and local TLBs concurrently

2019-07-03 Thread Juergen Gross
Zhang Cc: Stephen Hemminger Cc: Sasha Levin Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: x...@kernel.org Cc: Juergen Gross Cc: Paolo Bonzini Cc: Dave Hansen Cc: Andy Lutomirski Cc: Peter Zijlstra Cc: Boris Ostrovsky Cc: linux-hyp...@vger.kernel.org Cc: linux-kernel@vger.

Re: [PATCH 1/3] x86/paravirt: Make read_cr2() CALLEE_SAVE

2019-07-03 Thread Juergen Gross
igned-off-by: Peter Zijlstra (Intel) Reviewed-by: Juergen Gross Juergen

Re: [RFC PATCH 00/16] xenhost support

2019-06-07 Thread Juergen Gross
On 09.05.19 19:25, Ankur Arora wrote: Hi all, This is an RFC for xenhost support, outlined here by Juergen here: https://lkml.org/lkml/2019/4/8/67. First: thanks for all the effort you've put into this series! The high level idea is to provide an abstraction of the Xen communication interfac

Re: [RFC PATCH 01/16] x86/xen: add xenhost_t interface

2019-06-07 Thread Juergen Gross
On 09.05.19 19:25, Ankur Arora wrote: Add xenhost_t which will serve as an abstraction over Xen interfaces. It co-exists with the PV/HVM/PVH abstractions (x86_init, hypervisor_x86, pv_ops etc) and is meant to capture mechanisms for communication with Xen so we could have different types of underl

Re: [RFC PATCH 06/16] x86/xen: add shared_info support to xenhost_t

2019-06-07 Thread Juergen Gross
On 09.05.19 19:25, Ankur Arora wrote: HYPERVISOR_shared_info is used for irq/evtchn communication between the guest and the host. Abstract out the setup/reset in xenhost_t such that nested configurations can use both xenhosts simultaneously. I have mixed feelings about this patch. Most of the s

Re: [RFC PATCH 00/16] xenhost support

2019-06-07 Thread Juergen Gross
On 07.06.19 17:22, Joao Martins wrote: On 6/7/19 3:51 PM, Juergen Gross wrote: On 09.05.19 19:25, Ankur Arora wrote: Hi all, This is an RFC for xenhost support, outlined here by Juergen here: https://lkml.org/lkml/2019/4/8/67. First: thanks for all the effort you've put into this s

[GIT PULL] xen: fix for 5.2-rc4

2019-06-08 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.2b-rc4-tag xen: fix for 5.2-rc4 It contains just one fix for the Xen block frontend driver avoiding allocations with order > 0. Thanks. Juergen drivers/block/xen-blkfront.c | 38

Re: [PATCH] mm: fix regression with deferred struct page init

2019-06-28 Thread Juergen Gross
On 28.06.19 17:17, Michal Hocko wrote: On Thu 20-06-19 18:08:21, Juergen Gross wrote: Commit 0e56acae4b4dd4a9 ("mm: initialize MAX_ORDER_NR_PAGES at a time instead of doing larger sections") is causing a regression on some systems when the kernel is booted as Xen dom0. The system

Re: [Xen-devel] [PATCH 1/2] xen/gntdev: replace global limit of mapped pages by limit per call

2019-07-18 Thread Juergen Gross
On 18.07.19 19:36, Andrew Cooper wrote: On 18/07/2019 07:52, Juergen Gross wrote: Today there is a global limit of pages mapped via /dev/xen/gntdev set to 1 million pages per default. The Xen default limit even for dom0 is 1024 pages * 16 entries per page, which is far lower than this limit

[GIT PULL] xen: fixes and features for 5.3-rc1

2019-07-18 Thread Juergen Gross
| 18 - 25 files changed, 112 insertions(+), 1120 deletions(-) Juergen Gross (3): xen/events: fix binding user event channels to cpus xen: remove tmem driver xen: let alloc_xenballooned_pages() fail if not enough memory free Zhenzhong Duan (7): Revert &quo

Re: [PATCH RESEND] Revert "x86/paravirt: Set up the virt_spin_lock_key after static keys get initialized"

2019-07-10 Thread Juergen Gross
On 26.06.19 10:57, Zhenzhong Duan wrote: This reverts commit ca5d376e17072c1b60c3fee66f3be58ef018952d. Commit 8990cac6e5ea ("x86/jump_label: Initialize static branching early") adds jump_label_init() call in setup_arch() to make static keys initialized early, so we could use the original simpler

Re: [PATCH] xen: mark expected switch fall-through

2019-02-12 Thread Juergen Gross
On 13/02/2019 00:50, Boris Ostrovsky wrote: > On Tue, Feb 12, 2019 at 02:37:20PM -0600, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch >> cases where we are expecting to fall through. >> >> This patch fixes the following warning: >> >> drivers/xen/xen-p

Re: [RFC][PATCH] tracing/x86: Save CR2 before tracing irqsoff on error_entry

2019-03-21 Thread Juergen Gross
On 21/03/2019 19:18, Linus Torvalds wrote: > On Thu, Mar 21, 2019 at 11:05 AM Andy Lutomirski wrote: >> >> In the long run, I think the right solution is to rewrite even more of >> this mess in C. We really ought to be able to put the IRQ flag >> tracing and the context tracking into C code. > >

Re: [Xen-devel][PATCH 2/2] xen/gntdev: Check and release imported dma-bufs on close

2019-02-17 Thread Juergen Gross
On 14/02/2019 15:23, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > Check if there are any imported dma-bufs left not released by > user-space when grant device's release callback is called and > free those if this is the case. This can happen if user-space > leaks the buffers

Re: [Xen-devel][PATCH 1/2] xen/gntdev: Do not destroy context while dma-bufs are in use

2019-02-17 Thread Juergen Gross
On 14/02/2019 15:23, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > If there are exported DMA buffers which are still in use and > grant device is closed by either normal user-space close or by > a signal this leads to the grant device context to be destroyed, > thus making it

Re: [BUG linux-4.9.x] xen hotplug cpu leads to 100% steal usage

2019-03-04 Thread Juergen Gross
On 01/03/2019 03:35, Dongli Zhang wrote: > This issue is only for stable 4.9.x (e.g., 4.9.160), while the root cause is > still in the lasted mainline kernel. > > This is obviated by new feature patch set ended with b672592f0221 > ("sched/cputime: Remove generic asm headers"). > > After xen guest

Re: [PATCH] xen: avoid link error on ARM

2019-03-04 Thread Juergen Gross
On 04/03/2019 21:47, Arnd Bergmann wrote: > Building the privcmd code as a loadable module on ARM, we get > a link error due to the private cache management functions: > > ERROR: "__sync_icache_dcache" [drivers/xen/xen-privcmd.ko] undefined! > > Move the code into a new file that is built along w

Re: [PATCH] xen: avoid link error on ARM

2019-03-05 Thread Juergen Gross
On 05/03/2019 09:34, Arnd Bergmann wrote: > On Tue, Mar 5, 2019 at 7:39 AM Juergen Gross wrote: > >> >> Can we avoid that ifdef in the Makefile? >> >> I'd rather have an architecture independant builtin driver added which >> is always included for CONFI

Re: [PATCH] [RESEND] [v3] xen: remove pre-xen3 fallback handlers

2019-03-05 Thread Juergen Gross
On 04/03/2019 21:52, Arnd Bergmann wrote: > The legacy hypercall handlers were originally added with > a comment explaining that "copying the argument structures in > HYPERVISOR_event_channel_op() and HYPERVISOR_physdev_op() into the local > variable is sufficiently safe" and only made sure to not

Re: [PATCH] [v2] xen: avoid link error on ARM

2019-03-05 Thread Juergen Gross
ew file that is always built in when Xen > is enabled, as suggested by Juergen Gross. Additional code will > be moved into this file later. > > Signed-off-by: Arnd Bergmann > --- > v2: rename mm.o to xen-builtin.o, make it unconditional > --- > drivers/xen/Ma

Re: [PATCH] [v2] xen: avoid link error on ARM

2019-03-05 Thread Juergen Gross
On 05/03/2019 14:43, Boris Ostrovsky wrote: > On 3/5/19 8:30 AM, Arnd Bergmann wrote: >> >> diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c >> index b24ddac1604b..290b6aca7e1d 100644 >> --- a/drivers/xen/privcmd.c >> +++ b/drivers/xen/privcmd.c >> @@ -723,26 +723,6 @@ static long privc

Re: [PATCH] [v2] xen: avoid link error on ARM

2019-03-05 Thread Juergen Gross
On 05/03/2019 17:49, Arnd Bergmann wrote: > On Tue, Mar 5, 2019 at 3:57 PM Juergen Gross wrote: >> On 05/03/2019 14:43, Boris Ostrovsky wrote: >>> On 3/5/19 8:30 AM, Arnd Bergmann wrote: > >>>> @@ -809,15 +789,7 @@ static long privcmd_ioctl_mmap_resource(str

[PATCH] xen: fix dom0 boot on huge systems

2019-03-07 Thread Juergen Gross
en before being linked to the actual address space instead of set_pte() a plain write to memory can be used in xen_relocate_p2m(). Fixes: f7c90c2aa40048 ("x86/xen: don't write ptes directly in 32-bit PV guests") Signed-off-by: Juergen Gross --- arch/x86/xen/mmu_pv.c | 13 ++

Re: [PATCH 05/20] x86/uaccess/xen: Suppress SMAP warnings

2019-03-07 Thread Juergen Gross
ture patches? With the commit message adjusted: Reviewed-by: Juergen Gross Juergen

Re: [PATCH 05/20] x86/uaccess/xen: Suppress SMAP warnings

2019-03-07 Thread Juergen Gross
On 07/03/2019 13:32, Peter Zijlstra wrote: > On Thu, Mar 07, 2019 at 01:22:52PM +0100, Juergen Gross wrote: >> On 07/03/2019 12:45, Peter Zijlstra wrote: >>> drivers/xen/privcmd.o: warning: objtool: privcmd_ioctl()+0x1414: call to >>> hypercall_page() with UACCESS enab

[PATCH] doc: add boot protocol 2.13 description to Documentation/x86/boot.txt

2019-03-08 Thread Juergen Gross
Documentation/x86/boot.txt is missing protocol 2.13 description. Signed-off-by: Juergen Gross --- Documentation/x86/boot.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/x86/boot.txt b/Documentation/x86/boot.txt index f4c2a97bfdbd..223e484a1304 100644 --- a

[PATCH] xen: Fix x86 sched_clock() interface for xen

2019-01-10 Thread Juergen Gross
ity to 16777216 Fix that by setting xen_sched_clock_offset at resume time to ensure a monotonic clock value. Fixes: f94c8d11699759 ("sched/clock, x86/tsc: Rework the x86 'unstable' sched_clock() interface") Cc: # 4.11 Reported-by: Hans van Kranenburg Signed-off-by: Juergen

Re: [PATCH] xen: Fix x86 sched_clock() interface for xen

2019-01-10 Thread Juergen Gross
On 10/01/2019 16:34, Boris Ostrovsky wrote: > On 1/10/19 5:07 AM, Juergen Gross wrote: >> >> +void xen_clocksource_suspend(void) >> +{ >> +xen_clock_value_saved = xen_clocksource_read() - xen_sched_clock_offset; > > > xen_clock_value_saved =

Re: [PATCH] xen: Fix x86 sched_clock() interface for xen

2019-01-10 Thread Juergen Gross
On 11/01/2019 00:10, Boris Ostrovsky wrote: > On 1/10/19 12:17 PM, Boris Ostrovsky wrote: >> On 1/10/19 11:14 AM, Juergen Gross wrote: >>> On 10/01/2019 16:34, Boris Ostrovsky wrote: >>>> On 1/10/19 5:07 AM, Juergen Gross wrote: >>>>&g

Re: [PATCH] xen: Fix x86 sched_clock() interface for xen

2019-01-10 Thread Juergen Gross
On 11/01/2019 08:15, Juergen Gross wrote: > On 11/01/2019 00:10, Boris Ostrovsky wrote: >> On 1/10/19 12:17 PM, Boris Ostrovsky wrote: >>> On 1/10/19 11:14 AM, Juergen Gross wrote: >>>> On 10/01/2019 16:34, Boris Ostrovsky wrote: >>>>> On 1/10/19 5:07 A

[PATCH v2] xen: Fix x86 sched_clock() interface for xen

2019-01-11 Thread Juergen Gross
ity to 16777216 Fix that by setting xen_sched_clock_offset at resume time to ensure a monotonic clock value. Fixes: f94c8d11699759 ("sched/clock, x86/tsc: Rework the x86 'unstable' sched_clock() interface") Cc: # 4.11 Reported-by: Hans van Kranenburg Signed-off-by: Juer

Re: [Xen-devel] [PATCH v2] xen: Fix x86 sched_clock() interface for xen

2019-01-11 Thread Juergen Gross
On 11/01/2019 14:12, Hans van Kranenburg wrote: > Hi, > > On 1/11/19 1:08 PM, Juergen Gross wrote: >> Commit f94c8d11699759 ("sched/clock, x86/tsc: Rework the x86 'unstable' >> sched_clock() interface") broke Xen guest time handling across >> migr

Re: [PATCH 3/6] xenbus: dispatch per-domU watch event to per-domU xenwatch thread

2018-09-14 Thread Juergen Gross
On 14/09/18 09:34, Dongli Zhang wrote: > This is the 3rd patch of a (6-patch) patch set. > > This patch dispatches the watch event to per-domU xenwatch thread when the > event meets all of below conditions: > > 1. The watch is registered to use xenwatch multithreading feature and the >get_dom

[PATCH] x86/paravirt: fix compile warning

2018-09-04 Thread Juergen Gross
Fix a compile warning "SAVE_FLAGS redefined" introduced recently by tip.git commit: 6da63eb241a05b0e676d6 ("x86/paravirt: Move the pv_irq_ops under the PARAVIRT_XXL umbrella"). Signed-off-by: Juergen Gross --- arch/x86/include/asm/paravirt.h | 2 +- 1 file changed, 1 inse

Re: cmpxchg.h:245:2: error: ‘asm’ operand has impossible constraints

2018-09-06 Thread Juergen Gross
suspect the "=a" contraint of the outputs and "a" of the inputs are the culprit. You could save me from having to search through all the debian repos for a gcc showing that issue... Juergen >From 252450d28ffc8fbfd5b332d0b97990ae12a207d9 Mon Sep 17 00:00:00 2001 From: Juergen Gr

Re: cmpxchg.h:245:2: error: ‘asm’ operand has impossible constraints

2018-09-06 Thread Juergen Gross
On 06/09/18 15:54, Juergen Gross wrote: > Hey Meelis, > > On Mon, 27 Aug 2018, Meelis Roos wrote: > >> While trying to compile v4.18-13105-gaba16dc5cf93 with gcc 5.3.1 on a >> 32-bit x86 configured for AMD K6 >> CC mm/slub.o >> In file included from

Re: [tip:x86/hyperv] x86/hyperv: Enable PV qspinlock for Hyper-V

2018-10-02 Thread Juergen Gross
Sorry for noticing this only now, but I have been fighting with Xen PV qspinlocks last weekend: On 02/10/2018 13:28, tip-bot for Yi Sun wrote: > Commit-ID: aaa7fc34c003bd8133a49f7634480cef6288ad55 > Gitweb: > https://git.kernel.org/tip/aaa7fc34c003bd8133a49f7634480cef6288ad55 > Author: Y

Re: [tip:x86/paravirt] x86/paravirt: Move the pv_irq_ops under the PARAVIRT_XXL umbrella

2018-09-07 Thread Juergen Gross
On 07/09/18 16:49, Borislav Petkov wrote: > Hi Jürgen, > > On Mon, Sep 03, 2018 at 08:01:40AM -0700, tip-bot for Juergen Gross wrote: >> Commit-ID: 6da63eb241a05b0e676d68975e793c0521387141 >> Gitweb: >> https://git.kernel.org/tip/6da63eb241a05b0e676d689

Re: [PATCH] xen: remove unnecessary condition check before kfree

2018-09-10 Thread Juergen Gross
On 08/09/18 16:18, zhong jiang wrote: > kfree has taken null pointer into account. So just remove the > condition check before kfree. > > Signed-off-by: zhong jiang > --- > drivers/xen/xen-acpi-processor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/xen/xen-

Re: Access to non-RAM pages

2018-09-01 Thread Juergen Gross
On 31/08/18 23:18, Jiri Kosina wrote: > On Wed, 29 Aug 2018, Juergen Gross wrote: > >> While being very unlikely I still believe this is possible. Any >> thoughts? > > So in theory we should somehow test whether the next page is some form of > mmio/gart/... mapping,

Re: Access to non-RAM pages

2018-09-02 Thread Juergen Gross
On 03/09/18 04:10, Linus Torvalds wrote: > So _practically_ this is just a Xen bug, nothing more. > > But since in _theory_ you could have MMIO abut regular RAM directly, > it's worth maybe making sure it's purely theory. And that was exactly the reason I brought it up. :-) Juergen

[PATCH] xen/netfront: raise max number of slots in xennet_get_responses()

2018-06-11 Thread Juergen Gross
nel-xen based guest system). Signed-off-by: Juergen Gross --- drivers/net/xen-netfront.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index 679da1abd73c..ba411005d829 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/ne

Re: [PATCH 1/2] xen: xenbus_dev_frontend: Fix XS_TRANSACTION_END handling

2018-03-02 Thread Juergen Gross
On 20/02/18 05:56, Simon Gaiser wrote: > Juergen Gross: >> On 07/02/18 23:22, Simon Gaiser wrote: >>> Commit fd8aa9095a95 ("xen: optimize xenbus driver for multiple >>> concurrent xenstore accesses") made a subtle change to the semantic of &

Re: [Xen-devel] [PATCH] xen: use hvc console for dom0

2018-03-02 Thread Juergen Gross
On 27/02/18 21:09, Julien Grall wrote: > Hi, > > On 27/02/2018 20:03, Stefano Stabellini wrote: >> On Tue, 27 Feb 2018, Julien Grall wrote: >>> Hi, >>> >>> On 26/02/18 12:32, Juergen Gross wrote: >>>> On 26/02/18 13:06, Andrii Anisov wrote: &g

Re: [PATCH 1/2] xen: xenbus_dev_frontend: Fix XS_TRANSACTION_END handling

2018-03-02 Thread Juergen Gross
On 02/03/18 15:58, Simon Gaiser wrote: > Juergen Gross: >> On 20/02/18 05:56, Simon Gaiser wrote: >>> Juergen Gross: >>>> On 07/02/18 23:22, Simon Gaiser wrote: >>>>> Commit fd8aa9095a95 ("xen: optimize xenbus driver for multiple >>>&g

[GIT PULL] xen: fixes for v4.16-rc4

2018-03-02 Thread Juergen Gross
son Andryuk (1): xen-netfront: Fix hang on device removal Juergen Gross (2): x86/xen: add tty0 and hvc0 as preferred consoles for dom0 Roger Pau Monne (1): xen/pirq: fix error path cleanup when binding MSIs Stefano Stabellini (1): pvcalls-front: 64-bit align flags

Re: [PATCH v2] Input: xen-kbdfront - allow better run-time configuration

2018-04-23 Thread Juergen Gross
On 23/04/18 10:02, Oleksandr Andrushchenko wrote: > Juergen, Jason, Dmitry > any comment on this? Oleksandr, please give us some time. I can't speak for others, but I am not sitting here idling and hoping that some work (e.g. patches to review) might appear. I have a lot of other stuff to do and

Re: [Xen-devel] [RFC 0/2] To introduce xenwatch multithreading (xen mtwatch)

2018-04-23 Thread Juergen Gross
On 24/04/18 01:55, Dongli Zhang wrote: > Hi Wei, > > On 04/23/2018 10:09 PM, Wei Liu wrote: >> On Sat, Apr 07, 2018 at 07:25:53PM +0800, Dongli Zhang wrote: >>> About per-domU xenwatch thread create/destroy, a new type of xenstore node >>> is >>> introduced: '/local/domain/0/mtwatch/'. >>> >>> Su

Re: [Xen-devel] [RFC 0/2] To introduce xenwatch multithreading (xen mtwatch)

2018-04-23 Thread Juergen Gross
On 24/04/18 07:52, Dongli Zhang wrote: > Hi Juergen, > > On 04/24/2018 01:22 PM, Juergen Gross wrote: >> On 24/04/18 01:55, Dongli Zhang wrote: >>> Hi Wei, >>> >>> On 04/23/2018 10:09 PM, Wei Liu wrote: >>>> On Sat, Apr 07, 2018 at 07:2

Re: [Xen-devel] [RFC 0/2] To introduce xenwatch multithreading (xen mtwatch)

2018-04-23 Thread Juergen Gross
On 24/04/18 08:10, Dongli Zhang wrote: > > > On 04/24/2018 02:03 PM, Juergen Gross wrote: >> On 24/04/18 07:52, Dongli Zhang wrote: >>> Hi Juergen, >>> >>> On 04/24/2018 01:22 PM, Juergen Gross wrote: >>>> On 24/04/18 01:55, Dongli Zhang w

Re: [Xen-devel] [PATCH 0/1] drm/xen-zcopy: Add Xen zero-copy helper DRM driver

2018-04-24 Thread Juergen Gross
On 24/04/18 07:43, Oleksandr Andrushchenko wrote: > On 04/24/2018 01:41 AM, Boris Ostrovsky wrote: >> On 04/23/2018 08:10 AM, Oleksandr Andrushchenko wrote: >>> On 04/23/2018 02:52 PM, Wei Liu wrote: On Fri, Apr 20, 2018 at 02:25:20PM +0300, Oleksandr Andrushchenko wrote: >>>   th

Re: [Xen-devel] [PATCH 0/1] drm/xen-zcopy: Add Xen zero-copy helper DRM driver

2018-04-24 Thread Juergen Gross
On 24/04/18 10:07, Oleksandr Andrushchenko wrote: > On 04/24/2018 10:51 AM, Juergen Gross wrote: >> On 24/04/18 07:43, Oleksandr Andrushchenko wrote: >>> On 04/24/2018 01:41 AM, Boris Ostrovsky wrote: >>>> On 04/23/2018 08:10 AM, Oleksandr Andrushchenko wrote: >>

Re: [Xen-devel] [PATCH 0/1] drm/xen-zcopy: Add Xen zero-copy helper DRM driver

2018-04-24 Thread Juergen Gross
On 24/04/18 11:03, Oleksandr Andrushchenko wrote: > On 04/24/2018 11:40 AM, Juergen Gross wrote: >> On 24/04/18 10:07, Oleksandr Andrushchenko wrote: >>> On 04/24/2018 10:51 AM, Juergen Gross wrote: >>>> On 24/04/18 07:43, Oleksandr Andrushchenko wrote: >&

Re: [Xen-devel] [PATCH 0/1] drm/xen-zcopy: Add Xen zero-copy helper DRM driver

2018-04-24 Thread Juergen Gross
On 24/04/18 12:14, Oleksandr Andrushchenko wrote: > On 04/24/2018 01:01 PM, Wei Liu wrote: >> On Tue, Apr 24, 2018 at 11:08:41AM +0200, Juergen Gross wrote: >>> On 24/04/18 11:03, Oleksandr Andrushchenko wrote: >>>> On 04/24/2018 11:40 AM, Juergen Gross wrote: >

Re: [PATCH] x86/vsyscall/64: Use proper accessor to update p4d entry

2018-03-19 Thread Juergen Gross
On 19/03/18 15:31, Boris Ostrovsky wrote: > Writing to it directly does not work for Xen PV guests. > > Signed-off-by: Boris Ostrovsky Reviewed-by: Juergen Gross Juergen

[GIT PULL] xen: one cleanup for 4.17-rc4

2018-05-04 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-4.17-rc4-tag xen: one cleanup for 4.17-rc4 It contains one cleanup to remove VLAs from the kernel. Thanks. Juergen arch/x86/xen/enlighten_pv.c | 86 --

Re: [PATCH] Input: xen-kbdfront - allow better run-time configuration

2018-04-19 Thread Juergen Gross
On 19/04/18 13:44, Oleksandr Andrushchenko wrote: > On 04/19/2018 02:25 PM, Juergen Gross wrote: >> On 18/04/18 17:04, Oleksandr Andrushchenko wrote: >>> From: Oleksandr Andrushchenko >>> >>> It is now only possible to control if multi-touch virtual d

Re: [Xen-devel] [PATCH] Input: xen-kbdfront - allow better run-time configuration

2018-04-19 Thread Juergen Gross
On 19/04/18 15:12, Oleksandr Andrushchenko wrote: > On 04/19/2018 04:10 PM, Jason Andryuk wrote: >> On Thu, Apr 19, 2018 at 9:01 AM, Oleksandr Andrushchenko >> wrote: >>> Ok, so I'll send v2 with the following changes: >>> >>> diff --git a/drivers/input/misc/xen-kbdfront.c >>> b/drivers/input/misc

[GIT PULL] xen: fixes and one header update for 4.17-rc2

2018-04-20 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-4.17-rc2-tag xen: fixes and one header update for 4.17-rc2 It contains some fixes of kmalloc() flags, one fix of the xenbus driver and an update of the pv sound driver interface neede

Re: [PATCH 1/3] xen: add generic fault injection facility

2018-04-20 Thread Juergen Gross
fault injection directory. > > - xen_fi_dir_add(dir, name) - adds fault injection control directory "name" > to directory "dir" > > - xen_should_fail(fi) - check whether fi hav to fail. > > Signed-off-by: Stanislav Kinsburskii > CC: Boris Ostrovsky

Re: [PATCH 2/3] xen netback: add fault injection facility

2018-04-20 Thread Juergen Gross
> CC: Wei Liu > CC: Paul Durrant > CC: "David S. Miller" > CC: Matteo Croce > CC: Stefan Hajnoczi > CC: Daniel Borkmann > CC: Gerard Garcia > CC: David Ahern > CC: Juergen Gross > CC: Amir Levy > CC: Jakub Kicinski > CC: linux-kernel@vger.ke

<    7   8   9   10   11   12   13   14   15   16   >