Re: [PATCH 2/3] xen-scsiback: One function call less in scsiback_device_action() after error detection

2016-07-19 Thread Juergen Gross
On 19/07/16 16:56, SF Markus Elfring wrote: >>> @@ -606,7 +606,7 @@ static void scsiback_device_action(struct vscsibk_pend >>> *pending_req, >>> tmr = kzalloc(sizeof(struct scsiback_tmr), GFP_KERNEL); >>> if (!tmr) { >>> target_put_sess_cmd(se_cmd); >>> - goto err; >>

Re: [PATCH 2/3] xen-scsiback: One function call less in scsiback_device_action() after error detection

2016-07-19 Thread Juergen Gross
On 20/07/16 07:10, SF Markus Elfring wrote: > @@ -606,7 +606,7 @@ static void scsiback_device_action(struct > vscsibk_pend *pending_req, > tmr = kzalloc(sizeof(struct scsiback_tmr), GFP_KERNEL); > if (!tmr) { > target_put_sess_cmd(se_cmd); > - goto err

Re: [PATCH v2 1/3] xen-scsiback: Delete an unnecessary check before the function call "kfree"

2016-07-20 Thread Juergen Gross
using the Coccinelle software. > > Signed-off-by: Markus Elfring Even if already given, here it is again: Reviewed-by: Juergen Gross Juergen

Re: [PATCH v2 3/3] xen-scsiback: Pass a failure indication as a constant

2016-07-20 Thread Juergen Gross
en if already given, here it is again: Reviewed-by: Juergen Gross Juergen

Re: [PATCH v2 2/3] xen-scsiback: Rename jump labels in scsiback_device_action()

2016-07-20 Thread Juergen Gross
gned-off-by: Markus Elfring Reviewed-by: Juergen Gross Juergen

[PATCH] xen: switch to threaded irq in netback

2016-09-20 Thread Juergen Gross
Instead of open coding it use the threaded irq mechanism in xen-netback. Signed-off-by: Juergen Gross --- drivers/net/xen-netback/common.h| 4 +--- drivers/net/xen-netback/interface.c | 38 ++--- drivers/net/xen-netback/netback.c | 18 -- 3

[PATCH v3 1/3] xen/pciback: simplify pcistub device handling

2016-09-22 Thread Juergen Gross
The Xen pciback driver maintains a list of all its seized devices. There are two functions searching the list for a specific device with basically the same semantics just returning different structures in case of a match. Split out the search function. Signed-off-by: Juergen Gross --- drivers

[PATCH v3 2/3] xen/pciback: avoid multiple entries in slot list

2016-09-22 Thread Juergen Gross
entry which already exists. As this will be needed later split out the list handling into a separate function. Signed-off-by: Juergen Gross --- drivers/xen/xen-pciback/pci_stub.c | 39 ++ 1 file changed, 31 insertions(+), 8 deletions(-) diff --git a/drivers/xen

[PATCH v3 3/3] xen/pciback: support driver_override

2016-09-22 Thread Juergen Gross
drivers_probe So e.g. libvirt doesn't need special handling for pciback. Signed-off-by: Juergen Gross --- V3: Move override check up in order not to miss the PCI_HEADER_TYPE check. Add an assigned device to the slot list. V2: Removed now unused label -

[PATCH v3 0/3] xen/pciback: support driver_override

2016-09-22 Thread Juergen Gross
ck. Changes in V2: - Removed now unused label. *** BLURB HERE *** Juergen Gross (3): xen/pciback: simplify pcistub device handling xen/pciback: avoid multiple entries in slot list xen/pciback: support driver_override drivers/xen/xen-pciback/pci_stub.c | 125 +--

[PATCH resend] xen-netback: switch to threaded irq for control ring

2016-09-22 Thread Juergen Gross
Instead of open coding it use the threaded irq mechanism in xen-netback. Signed-off-by: Juergen Gross --- resend due to missing netdev list in first attempt --- drivers/net/xen-netback/common.h| 4 +--- drivers/net/xen-netback/interface.c | 38 ++--- drivers

[PATCH resend 2] xen-netback: switch to threaded irq for control ring

2016-09-22 Thread Juergen Gross
Instead of open coding it use the threaded irq mechanism in xen-netback. Signed-off-by: Juergen Gross --- resend due to missing netdev list in first attempt and wrong address in second. --- drivers/net/xen-netback/common.h| 4 +--- drivers/net/xen-netback/interface.c | 38

Re: [Xen-devel] [PATCH resend] xen-netback: switch to threaded irq for control ring

2016-09-22 Thread Juergen Gross
On 22/09/16 11:09, Paul Durrant wrote: >> -Original Message- >> From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of >> Juergen Gross >> Sent: 22 September 2016 10:03 >> To: xen-de...@lists.xenproject.org; net...@vger.kernel.orga; linux- &

Re: [Xen-devel] [PATCH resend] xen-netback: switch to threaded irq for control ring

2016-09-22 Thread Juergen Gross
On 22/09/16 12:31, Paul Durrant wrote: >> -Original Message- >> From: Juergen Gross [mailto:jgr...@suse.com] >> Sent: 22 September 2016 11:17 >> To: Paul Durrant ; xen-de...@lists.xenproject.org; >> net...@vger.kernel.orga ; linux- >> ker...@vger.kerne

Re: [PATCH v5 0/6] Support calling functions on dedicated physical cpu

2016-06-20 Thread Juergen Gross
On 06/04/16 16:17, Juergen Gross wrote: > Some hardware (e.g. Dell Studio laptops) require special functions to > be called on physical cpu 0 in order to avoid occasional hangs. When > running as dom0 under Xen this could be achieved only via special boot > parameters (vcpu pinning)

Re: [PATCH] xen/PMU: Log VPMU initialization error at lower level

2016-06-21 Thread Juergen Gross
On 21/06/16 16:17, Boris Ostrovsky wrote: > This will match how PMU errors are reported at check_hw_exists()'s > msr_fail label, which is reached when VPMU initialzation fails. > > Signed-off-by: Boris Ostrovsky Acked-by: Juergen Gross > --- > arch/x86/xen/pmu.c | 2

Re: [PATCH] xen/pciback: Fix conf_space read/write overlap check.

2016-06-21 Thread Juergen Gross
+ David and Juergen (maintainers) and kernel list. > > Reviewed-by: Boris Ostrovsky Acked-by: Juergen Gross > > >> --- >> drivers/xen/xen-pciback/conf_space.c | 6 ++ >> 1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/xen/xen-

Re: [PATCH v3 2/3] xen/pciback: avoid multiple entries in slot list

2016-09-22 Thread Juergen Gross
On 22/09/16 23:02, Boris Ostrovsky wrote: > On 09/22/2016 04:45 AM, Juergen Gross wrote: >> The Xen pciback driver has a list of all pci devices it is ready to >> seize. There is no check whether a to be added entry already exists. >> While this might be no problem in the

Re: [PATCH v3 3/3] xen/pciback: support driver_override

2016-09-22 Thread Juergen Gross
On 22/09/16 23:10, Boris Ostrovsky wrote: > On 09/22/2016 04:45 AM, Juergen Gross wrote: >> Support the driver_override scheme introduced with commit 782a985d7af2 >> ("PCI: Introduce new device binding path using pci_dev.driver_override") >> >> As pcistub_prob

Re: [GIT PULL V2] Changes for 4.8

2016-07-27 Thread Juergen Gross
On 27/07/16 19:03, Linus Torvalds wrote: > On Tue, Jul 26, 2016 at 8:59 PM, Juergen Gross wrote: >> >> Support calling functions on dedicated physical cpu >> >> Some hardware (e.g. Dell Studio laptops) require special functions to >> be called on physical cpu 0 i

[PATCH] x86/events: modify error message in virtualized environment

2016-08-01 Thread Juergen Gross
be either of level err or info depending on the environment (native or virtualized). As the level is taken from the format string and not the printed string, specifying it via %s and a conditional argument didn't work the way intended. Signed-off-by: Juergen Gross --- arch/x86/eve

[PATCH] xen: rename xen_pmu_init() in sys-hypervisor.c

2016-08-01 Thread Juergen Gross
There are two functions with name xen_pmu_init() in the kernel. Rename the one in drivers/xen/sys-hypervisor.c to avoid shadowing the one in arch/x86/xen/pmu.c Signed-off-by: Juergen Gross --- drivers/xen/sys-hypervisor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH] xen: Make VPMU init message look less scary

2016-08-01 Thread Juergen Gross
ry in case the hypervisor returns EOPNOTSUPP when trying to activate VPMU. Signed-off-by: Juergen Gross --- arch/x86/xen/pmu.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/x86/xen/pmu.c b/arch/x86/xen/pmu.c index 32bdc2c..e9d66fa 100644 --- a/arch/x86/xen/pmu.c

Re: [PATCH] xen: rename xen_pmu_init() in sys-hypervisor.c

2016-08-01 Thread Juergen Gross
On 01/08/16 16:10, Boris Ostrovsky wrote: > On 08/01/2016 07:40 AM, Juergen Gross wrote: >> There are two functions with name xen_pmu_init() in the kernel. Rename >> the one in drivers/xen/sys-hypervisor.c to avoid shadowing the one in >> arch/x86/xen/pmu.c >> >

Re: [Xen-devel] [PATCH] xen: Make VPMU init message look less scary

2016-08-01 Thread Juergen Gross
On 01/08/16 16:11, Konrad Rzeszutek Wilk wrote: > On Mon, Aug 01, 2016 at 01:41:20PM +0200, Juergen Gross wrote: >> The default for the Xen hypervisor is to not enable VPMU in order to >> avoid security issues. In this case the Linux kernel will issue the >> message "Cou

Re: [PATCH] xen: rename xen_pmu_init() in sys-hypervisor.c

2016-08-01 Thread Juergen Gross
On 01/08/16 17:46, Boris Ostrovsky wrote: > On 08/01/2016 11:44 AM, Juergen Gross wrote: >> On 01/08/16 16:10, Boris Ostrovsky wrote: >>> On 08/01/2016 07:40 AM, Juergen Gross wrote: >>>> There are two functions with name xen_pmu_init() in the kernel. Rename &

Re: [PATCH v2] xen/pciback: support driver_override

2016-09-08 Thread Juergen Gross
On 08/09/16 16:10, Boris Ostrovsky wrote: > On 09/02/2016 08:30 AM, Juergen Gross wrote: >> Support the driver_override scheme introduced with commit 782a985d7af2 >> ("PCI: Introduce new device binding path using pci_dev.driver_override") >> >> As pcistub_prob

[PATCH] xen/pciback: support driver_override

2016-09-02 Thread Juergen Gross
check for driver_override set to "pciback" itself. Signed-off-by: Juergen Gross --- drivers/xen/xen-pciback/pci_stub.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/xen/xen-pciback/pci_stub.c b/drivers/xen/xen-pciback/pci_stub.c index 258b7c3..

[PATCH v2] xen/pciback: support driver_override

2016-09-02 Thread Juergen Gross
check for driver_override set to "pciback" itself. Signed-off-by: Juergen Gross --- V2: removed now unused label --- drivers/xen/xen-pciback/pci_stub.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/xen/xen-pciback/pci_stub.c b/drivers/xen/xe

Re: [PATCH v2 1/2] xen/x86: Move irq allocation from Xen smp_op.cpu_up()

2016-08-04 Thread Juergen Gross
pu up/down") because of Xen allocating > irqs in both of its cpu_up ops. > > We can move those allocations into CPU notifiers so that original > patch can be reinstated. > > Signed-off-by: Boris Ostrovsky Reviewed-by: Juergen Gross Juergen

Re: [PATCH v2 2/2] hotplug: Prevent alloc/free of irq descriptors during cpu up/down (again)

2016-08-04 Thread Juergen Gross
On 03/08/16 19:22, Boris Ostrovsky wrote: > Now that Xen no longer allocates irqs in _cpu_up() we can restore > commit a89941816726 ("hotplug: Prevent alloc/free of irq descriptors > during cpu up/down") > > Signed-off-by: Boris Ostrovsky > Acked-by: Thomas Gleixner

Re: Re: [GIT PULL] Changes for 4.8

2016-08-25 Thread Juergen Gross
On 27/07/16 08:41, Ingo Molnar wrote: > > * Juergen Gross wrote: > >> Hi Linus, >> >> please consider pulling a patch series for 4.8 from: >> >> https://github.com/jgross1/linux.git tags/for-linus-4-8 >> >> Unfortunately 2 of the 6 patche

Re: [PATCH] xen/grant-table: Use kmalloc_array() in arch_gnttab_valloc()

2016-08-25 Thread Juergen Gross
convention. > > Signed-off-by: Markus Elfring Reviewed-by: Juergen Gross Juergen

[PATCH v2 0/2] x86: paravirt related cleanup

2017-08-16 Thread Juergen Gross
patch() (Peter Zijlstra) [1]: https://lkml.org/lkml/2017/5/15/502 Juergen Gross (2): paravirt,xen: remove xen_patch() x86/lguest: remove lguest support MAINTAINERS | 11 - arch/x86/Kbuild |3 - arch/x86/Kconfig |

[PATCH v2 1/2] paravirt,xen: remove xen_patch()

2017-08-16 Thread Juergen Gross
ned-off-by: Juergen Gross --- arch/x86/xen/enlighten_pv.c | 59 + arch/x86/xen/xen-asm.S | 24 -- arch/x86/xen/xen-asm.h | 12 - arch/x86/xen/xen-asm_32.S | 27 - arch/x86/xen/xen-asm_6

[PATCH v2] i40e/i40evf: use cpumask_copy() for assigning cpumask

2017-08-16 Thread Juergen Gross
/0x70 Fixes: 96db776a3682 ("i40e/i40evf: fix interrupt affinity bug") Cc: # 4.10+ Signed-off-by: Juergen Gross --- V2: enhance commit message, merge patches --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +- 2 files

[PATCH] xen: fix build failure related to removing adjust_exception_frame

2017-08-17 Thread Juergen Gross
A kernel configured with XEN_PV but without KVM_GUEST will fail to build since the patch removing the adjust_exception_frame paravirt op. Fix this failure. Reported-by: Sander Eikelenboom Signed-off-by: Juergen Gross --- arch/x86/xen/xen-asm_64.S | 1 - 1 file changed, 1 deletion(-) diff

Re: [PATCH RFC] x86: enable RCU based table free when PARAVIRT

2017-08-18 Thread Juergen Gross
ely. :-) > Context Switches 187514 (175324) Context Switches 187358 (175060) > Sleeps 112633 (24535.5) Sleeps 111743 (23297.6) > > Suggested-by: Peter Zijlstra > Signed-off-by: Vitaly Kuznetsov Acked-by: Juergen Gross Thanks, Juergen

[PATCH v2 0/2] xen: add xen sysfs node

2017-05-26 Thread Juergen Gross
. Juergen Gross (2): doc,xen: document hypervisor sysfs nodes for xen xen: add sysfs node for guest type Documentation/ABI/stable/sysfs-hypervisor-xen | 107 + .../{sysfs-hypervisor-pmu => sysfs-hypervisor-xen} | 15 ++- MAINTAIN

[PATCH v2 2/2] xen: add sysfs node for guest type

2017-05-26 Thread Juergen Gross
behavior of some instructions), add a sysfs node /sys/hypervisor/guest_type to explicitly deliver this information as it is known to the kernel. Signed-off-by: Juergen Gross --- V2: - remove PVHVM guest type (Andrew Cooper) - move description to Documentation/ABI/testing/sysfs-hypervisor-xen

[PATCH v2 1/2] doc,xen: document hypervisor sysfs nodes for xen

2017-05-26 Thread Juergen Gross
file. Signed-off-by: Juergen Gross --- V2: - rename file to Documentation/ABI/stable/sysfs-hypervisor-xen in order to reflect Xen dependency - leave pmu entries in old file under testing (Boris Ostrovsky) --- Documentation/ABI/stable/sysfs-hypervisor-xen | 107

[PATCH] xen: don't print error message in case of missing Xenstore entry

2017-05-29 Thread Juergen Gross
When registering for the Xenstore watch of the node control/sysrq the handler will be called at once. Don't issue an error message if the Xenstore node isn't there, as it will be created only when an event is being triggered. Signed-off-by: Juergen Gross --- drivers/xen/manage.c | 7

Re: [PATCH] xen: don't print error message in case of missing Xenstore entry

2017-05-30 Thread Juergen Gross
On 30/05/17 15:25, Boris Ostrovsky wrote: > On 05/29/2017 05:13 AM, Juergen Gross wrote: >> When registering for the Xenstore watch of the node control/sysrq the >> handler will be called at once. Don't issue an error message if the >> Xenstore node isn't there, as

Re: [PATCH] xen: don't print error message in case of missing Xenstore entry

2017-05-30 Thread Juergen Gross
On 30/05/17 19:08, Boris Ostrovsky wrote: > On 05/30/2017 11:03 AM, Juergen Gross wrote: >> On 30/05/17 15:25, Boris Ostrovsky wrote: >>> On 05/29/2017 05:13 AM, Juergen Gross wrote: >>>> When registering for the Xenstore watch of the node control/sysrq the >&

[PATCH v2] xen: don't print error message in case of missing Xenstore entry

2017-05-30 Thread Juergen Gross
When registering for the Xenstore watch of the node control/sysrq the handler will be called at once. Don't issue an error message if the Xenstore node isn't there, as it will be created only when an event is being triggered. Signed-off-by: Juergen Gross --- drivers/xen/man

Re: [PATCH v2] xen: support priv-mapping in an HVM tools domain

2017-11-01 Thread Juergen Gross
through to the approprate > xlate_mmu function if the feature is present. > > This patch also moves xen_remap_domain_gfn_range() into the PV-only MMU > code and #ifdefs the (only) calling code in privcmd accordingly. > > Signed-off-by: Paul Durrant > --- > Cc: Boris Ostro

Re: [PATCH v2] xen: support priv-mapping in an HVM tools domain

2017-11-01 Thread Juergen Gross
On 01/11/17 14:45, Paul Durrant wrote: >> -Original Message- >> From: Juergen Gross [mailto:jgr...@suse.com] >> Sent: 01 November 2017 13:40 >> To: Paul Durrant ; x...@kernel.org; xen- >> de...@lists.xenproject.org; linux-kernel@vger.kernel.org >> C

Re: [PATCH] x86/paravirt: Add kernel parameter to choose paravirt lock type

2017-11-01 Thread Juergen Gross
On 01/11/17 16:32, Waiman Long wrote: > Currently, there are 3 different lock types that can be chosen for > the x86 architecture: > > - qspinlock > - pvqspinlock > - unfair lock > > One of the above lock types will be chosen at boot time depending on > a number of different factors. > > Idea

[PATCH v2 4/5] xen: update arch/x86/include/asm/xen/cpuid.h

2017-11-02 Thread Juergen Gross
Update arch/x86/include/asm/xen/cpuid.h from the Xen tree to get newest definitions. Signed-off-by: Juergen Gross --- arch/x86/include/asm/xen/cpuid.h | 42 ++-- 1 file changed, 32 insertions(+), 10 deletions(-) diff --git a/arch/x86/include/asm/xen/cpuid.h

[PATCH v2 0/5] xen: grant table interface v2 support

2017-11-02 Thread Juergen Gross
for version select Juergen Gross (5): xen: re-introduce support for grant v2 interface xen: limit grant v2 interface to the v1 functionality xen: add grant interface version dependent constants to gnttab_ops xen: update arch/x86/include/asm/xen/cpuid.h xen: select grant interface vers

[PATCH v2 1/5] xen: re-introduce support for grant v2 interface

2017-11-02 Thread Juergen Gross
s machines with more than 16TB of memory are expected to be more common in the near future support of grant v2 is mandatory in order to be able to run a Xen pv domain at any memory location. So re-add grant v2 support basically by reverting above commit. Signed-off-by: Juergen Gross --- arch/arm

[PATCH v2 2/5] xen: limit grant v2 interface to the v1 functionality

2017-11-02 Thread Juergen Gross
-off-by: Juergen Gross --- V2: - remove update_trans_entry() from gnttab_ops (Boris Ostrovsky) --- drivers/xen/grant-table.c | 150 -- include/xen/grant_table.h | 25 2 files changed, 175 deletions(-) diff --git a/drivers/xen/grant-table.c b

[PATCH v2 3/5] xen: add grant interface version dependent constants to gnttab_ops

2017-11-02 Thread Juergen Gross
Instead of having multiple variables with constants like grant_table_version or grefs_per_grant_frame add those to struct gnttab_ops and access them just via the gnttab_interface pointer. Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky --- drivers/xen/grant-table.c | 73

[PATCH v2 5/5] xen: select grant interface version

2017-11-02 Thread Juergen Gross
to specify the grant interface version via a boot parameter. Signed-off-by: Juergen Gross --- V2: - use cpuid on pv and max_possible_pfn on hvm for version select --- drivers/xen/grant-table.c | 35 +-- 1 file changed, 33 insertions(+), 2 deletions(-) diff --git a

Re: [PATCH v2 15/20] x86/xen/64: Clean up SP code in cpu_initialize_context()

2017-11-02 Thread Juergen Gross
On 02/11/17 08:59, Andy Lutomirski wrote: > I'm removing thread_struct::sp0, and Xen's usage of it is slightly > dubious and unnecessary. Use appropriate helpers instead. > > While we're at at, reorder the code slightly to make it more obvious > what's goi

Re: [PATCH-tip v2 2/2] x86/xen: Deprecate xen_nopvspin

2017-11-02 Thread Juergen Gross
On 02/11/17 14:25, Waiman Long wrote: > On 11/01/2017 06:01 PM, Boris Ostrovsky wrote: >> On 11/01/2017 04:58 PM, Waiman Long wrote: >>> +/* TODO: To be removed in a future kernel version */ >>> static __init int xen_parse_nopvspin(char *arg) >>> { >>> - xen_pvspin = false; >>> + pr_warn("xen

Re: [PATCH 01/13] x86/paravirt: remove wbinvd() paravirt interface

2017-10-24 Thread Juergen Gross
On 04/10/17 17:58, Josh Poimboeuf wrote: > Since lguest was removed, only the native version of wbinvd() is used. > The paravirt interface is no longer needed. > > Signed-off-by: Josh Poimboeuf Reviewed-by: Juergen Gross Juergen

Re: [PATCH] xen: fix booting ballooned down hvm guest

2017-10-24 Thread Juergen Gross
On 24/10/17 16:33, Boris Ostrovsky wrote: > On 10/24/2017 04:10 AM, Juergen Gross wrote: >> Commit 96edd61dcf44362d3ef0bed1a5361e0ac7886a63 ("xen/balloon: don't >> online new memory initially") introduced a regression when booting a >> HVM domain with

Re: [PATCH] xen: fix booting ballooned down hvm guest

2017-10-24 Thread Juergen Gross
On 24/10/17 16:56, Boris Ostrovsky wrote: > On 10/24/2017 10:41 AM, Juergen Gross wrote: >> On 24/10/17 16:33, Boris Ostrovsky wrote: >>> On 10/24/2017 04:10 AM, Juergen Gross wrote: >>>> Commit 96edd61dcf44362d3ef0bed1a5361e0ac7886a63 ("xen/balloon: don

Re: [PATCH] xen: fix booting ballooned down hvm guest

2017-10-24 Thread Juergen Gross
On 24/10/17 16:59, HW42 wrote: > Juergen Gross: >> On 24/10/17 16:56, Boris Ostrovsky wrote: >>> On 10/24/2017 10:41 AM, Juergen Gross wrote: >>>> On 24/10/17 16:33, Boris Ostrovsky wrote: >>>>> On 10/24/2017 04:10 AM, Juergen Gross wrote: >>&

Re: [PATCH] paravirt/locks: avoid modifying static key before jump_label_init()

2017-10-24 Thread Juergen Gross
On 25/10/17 06:26, Dou Liyang wrote: > Hi Juergen, > > At 10/23/2017 09:49 PM, Juergen Gross wrote: >> Don't try to set the static virt_spin_lock_key to a value before >> jump_label_init() has been called, as this will result in a WARN(). >> >> Solve the

Re: [PATCH] paravirt/locks: avoid modifying static key before jump_label_init()

2017-10-25 Thread Juergen Gross
On 25/10/17 09:35, Dou Liyang wrote: > Hi Juergen, > > [...] >>> I like your original method. >>> So, I try to fix it by moving the native_pv_lock_init() from >>>  native_smp_prepare_boot_cpu() to native_smp_prepare_cpus(). >> >> Hmm, this might work, but the Xen case has to be modified (same for

Re: [PATCH 02/13] x86/paravirt: Fix output constraint macro names

2017-10-25 Thread Juergen Gross
On 04/10/17 17:58, Josh Poimboeuf wrote: > Some of the paravirt '*_CLOBBERS' macros refer to output constraints > instead of clobbers, which makes the code extra confusing. Rename the > output constraint related macros to '*_OUTPUTS'. > > Signed-off-by: Josh Poimboeuf I'm fine with the changes,

Re: [PATCH 03/13] x86/paravirt: Convert native patch assembly code strings to macros

2017-10-25 Thread Juergen Gross
'%' characters instead of one when specifying > a register name. > > Signed-off-by: Josh Poimboeuf Reviewed-by: Juergen Gross Mind adding another patch to merge the now nearly identical paravirt_patch_32.c and paravirt_patch_64.c either into paravirt.c or paravirt_patch.c? This

Re: [PATCH 04/13] x86/paravirt: Convert DEF_NATIVE macro to GCC extended asm syntax

2017-10-25 Thread Juergen Gross
extended asm syntax so the NATIVE_* macros can be shared more > broadly. > > Signed-off-by: Josh Poimboeuf Reviewed-by: Juergen Gross Juergen

Re: [PATCH 05/13] x86/paravirt: Move paravirt asm macros to paravirt-asm.h

2017-10-25 Thread Juergen Gross
On 04/10/17 17:58, Josh Poimboeuf wrote: > The paravirt.h file is quite big and the asm interfaces for paravirt > don't need to be in the same file as the C interfaces. Move the asm > interfaces to a dedicated header file. > > Signed-off-by: Josh Poimboeuf Reviewed-by: Juergen Gross Juergen

Re: [PATCH 06/13] x86/paravirt: Clean up paravirt-asm.h

2017-10-25 Thread Juergen Gross
On 04/10/17 17:58, Josh Poimboeuf wrote: > Some cleanup to make the code easier to read and understand: > > - Use the common "PV_" prefix > - Simplify the PV_SITE macro interface > - Improve whitespace > > Signed-off-by: Josh Poimboeuf Reviewed-by: Juergen Gross Juergen

Re: [PATCH 07/13] x86/paravirt: Simplify ____PVOP_CALL()

2017-10-25 Thread Juergen Gross
On 04/10/17 17:58, Josh Poimboeuf wrote: > Remove the inline asm duplication in PVOP_CALL(). > > Also add 'IS_ENABLED(CONFIG_X86_32)' to the return variable logic, > making the code clearer and rendering the comment unnecessary. > > Signed-off-by: Josh Poimboeuf

Re: [PATCH 08/13] x86/paravirt: Clean up paravirt_types.h

2017-10-25 Thread Juergen Gross
On 04/10/17 17:58, Josh Poimboeuf wrote: > Make paravirt_types.h more understandable: > > - Use more consistent and logical naming > - Simplify interfaces > - Put related macros together > - Improve whitespace > > Signed-off-by: Josh Poimboeuf Reviewed-by: Juergen Gross Juergen

Re: [PATCH 09/13] x86/asm: Convert ALTERNATIVE*() assembler macros to preprocessor macros

2017-10-25 Thread Juergen Gross
On 04/10/17 17:58, Josh Poimboeuf wrote: > The ALTERNATIVE() and ALTERNATIVE_2() macros are GNU assembler macros, > which makes them quite inflexible for future changes. Convert them to > preprocessor macros. > > Signed-off-by: Josh Poimboeuf Reviewed-by: Juergen Gross Juergen

Re: [PATCH 10/13] x86/alternative: Support indirect call replacement

2017-10-25 Thread Juergen Gross
On 04/10/17 17:58, Josh Poimboeuf wrote: > Add alternative patching support for replacing an instruction with an > indirect call. This will be needed for the paravirt alternatives. > > Signed-off-by: Josh Poimboeuf > --- > arch/x86/kernel/alternative.c | 22 +++--- > 1 file chan

[PATCH] xen/gntdev: avoid out of bounds access in case of partial gntdev_mmap()

2017-10-25 Thread Juergen Gross
little bit earlier. Cc: Reported-by: Arthur Borsboom Signed-off-by: Juergen Gross --- drivers/xen/gntdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index 82360594fa8e..57efbd3b053b 100644 --- a/drivers/xen/gntdev.c +++ b

Re: [PATCH 09/18] x86/asm/64: De-Xen-ify our NMI code

2017-10-26 Thread Juergen Gross
On 26/10/17 10:26, Andy Lutomirski wrote: > Xen PV is fundamentally incompatible with our fancy NMI code: it > doesn't use IST at all, and Xen entries clobber two stack slots > below the hardware frame. > > Drop Xen PV support from our NMI code entirely. > > Cc:

Re: [PATCH 13/18] x86/xen/64: Clean up SP code in cpu_initialize_context()

2017-10-26 Thread Juergen Gross
On 26/10/17 10:26, Andy Lutomirski wrote: > I'm removing thread_struct::sp0, and Xen's usage of it is slightly > dubious and unnecessary. Use appropriate helpers instead. > > While we're at at, reorder the code slightly to make it more obvious > what's goi

[PATCH v2] xen: fix booting ballooned down hvm guest

2017-10-26 Thread Juergen Gross
online new memory initially") Reported-by: Simon Gaiser Suggested-by: Boris Ostrovsky Signed-off-by: Juergen Gross --- drivers/xen/xen-balloon.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/xen/xen-balloon.c b/drivers/xen/xe

[PATCH] maintainers: drop Chris Wright from pvops

2017-10-26 Thread Juergen Gross
Mails to chr...@sous-sol.org are not deliverable since several months. Drop him as PARAVIRT_OPS maintainer. Signed-off-by: Juergen Gross --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index d85c08956875..af0cb69f6a3e 100644 --- a/MAINTAINERS +++ b

Re: [PATCH] x86: Remove unnecessary return from void function

2017-10-26 Thread Juergen Gross
On 23/06/17 18:23, Anton Vasilyev wrote: > The patch removes unnecessary return from void function. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Anton Vasilyev Reviewed-by: Juergen Gross Juergen

Re: [PATCH RFC v3 1/6] x86/paravirt: Add pv_idle_ops to paravirt ops

2017-11-13 Thread Juergen Gross
> to poll for a while and do not enter real idle path if we can get the > schedule event during polling. > > Poll may cause the CPU waste so we adopt a smart polling mechanism to > reduce the useless poll. > > Signed-off-by: Yang Zhang > Signed-off-by: Quan Xu > Cc:

Re: [PATCH RFC v3 1/6] x86/paravirt: Add pv_idle_ops to paravirt ops

2017-11-13 Thread Juergen Gross
On 14/11/17 08:02, Quan Xu wrote: > > > On 2017/11/13 18:53, Juergen Gross wrote: >> On 13/11/17 11:06, Quan Xu wrote: >>> From: Quan Xu >>> >>> So far, pv_idle_ops.poll is the only ops for pv_idle. .poll is called >>> in idle path which

Re: [PATCH RFC v3 1/6] x86/paravirt: Add pv_idle_ops to paravirt ops

2017-11-14 Thread Juergen Gross
On 14/11/17 10:38, Quan Xu wrote: > > > On 2017/11/14 15:30, Juergen Gross wrote: >> On 14/11/17 08:02, Quan Xu wrote: >>> >>> On 2017/11/13 18:53, Juergen Gross wrote: >>>> On 13/11/17 11:06, Quan Xu wrote: >>>>> From: Quan Xu >

Re: [PATCH RFC v3 1/6] x86/paravirt: Add pv_idle_ops to paravirt ops

2017-11-14 Thread Juergen Gross
On 14/11/17 12:43, Quan Xu wrote: > > > On 2017/11/14 18:27, Juergen Gross wrote: >> On 14/11/17 10:38, Quan Xu wrote: >>> >>> On 2017/11/14 15:30, Juergen Gross wrote: >>>> On 14/11/17 08:02, Quan Xu wrote: >>>>> On 2017/11/13 18:53,

Re: [PATCH] xen/time: Return -ENODEV from xen_get_wallclock()

2017-11-03 Thread Juergen Gross
On 02/11/17 23:18, Boris Ostrovsky wrote: > For any other error sync_cmos_clock() will reschedule itself > every second or so, for no good reason. > > Suggested-by: Paolo Bonzini > Signed-off-by: Boris Ostrovsky Reviewed-by: Juergen Gross Juergen

Re: [PATCH] xen: xenbus_probe_frontend: mark expected switch fall-throughs

2017-11-03 Thread Juergen Gross
On 02/11/17 19:41, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 146562 > Addresses-Coverity-ID: 146563 > Signed-off-by: Gustavo A. R. Silva Reviewed

Re: [PATCH] xen/pvcalls-front: mark expected switch fall-through

2017-11-03 Thread Juergen Gross
GCC is expecting to find. > > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Juergen Gross Juergen

Re: [PATCH] xen/pvcalls: fix unsigned less than zero error check

2017-11-03 Thread Juergen Gross
. > > Detected by CoverityScan, CID#1460358 ("Unsigned compared against 0") > > Fixes: 219681909913 ("xen/pvcalls: connect to the backend") > Signed-off-by: Colin Ian King Reviewed-by: Juergen Gross Juergen

Re: [PATCH] xen/pvcalls: remove redundant check for irq >= 0

2017-11-03 Thread Juergen Gross
quot;) > > Fixes: cb1c7d9bbc87 ("xen/pvcalls: implement connect command") > Signed-off-by: Colin Ian King Reviewed-by: Juergen Gross Juergen

Re: [Xen-devel] [PATCH v3 1/1] xen/time: do not decrease steal time after live migration on xen

2017-10-27 Thread Juergen Gross
On 27/10/17 09:16, Dongli Zhang wrote: > Hi Boris, > > On 10/25/2017 11:12 PM, Boris Ostrovsky wrote: >> On 10/25/2017 02:45 AM, Dongli Zhang wrote: >>> After guest live migration on xen, steal time in /proc/stat >>> (cpustat[CPUTIME_STEAL]) might decrease because steal returned by >>> xen_steal_l

[GIT PULL] xen: fixes for 4.14-rc7

2017-10-27 Thread Juergen Gross
/xen/p2m.c| 2 +- drivers/xen/gntdev.c | 2 +- drivers/xen/xen-balloon.c | 19 +-- 4 files changed, 15 insertions(+), 9 deletions(-) Juergen Gross (3): xen/gntdev: avoid out of bounds access in case of partial gntdev_mmap() xen: fix booting ballooned down hvm

Re: [Xen-devel] [PATCH v3 1/1] xen/time: do not decrease steal time after live migration on xen

2017-10-27 Thread Juergen Gross
On 27/10/17 09:40, Dongli Zhang wrote: > Hi Juergen, > > On 10/27/2017 03:31 PM, Juergen Gross wrote: >> On 27/10/17 09:16, Dongli Zhang wrote: >>> Hi Boris, >>> >>> On 10/25/2017 11:12 PM, Boris Ostrovsky wrote: >>>> On 10/25/2017 02:45 AM, D

Re: [PATCH] paravirt/locks: avoid modifying static key before jump_label_init()

2017-10-27 Thread Juergen Gross
On 27/10/17 10:43, Ingo Molnar wrote: > > * Juergen Gross wrote: > >> Don't try to set the static virt_spin_lock_key to a value before >> jump_label_init() has been called, as this will result in a WARN(). >> >> Solve the problem by introduci

Re: [PATCH][tip] x86/paravirt: Make the virt_spin_lock_key setup after jump_label_init()

2017-10-27 Thread Juergen Gross
>> call of virt_spin_lock()") >>> >>> set the static virt_spin_lock_key to a value before jump_label_init() >>> has been called, which will result in a WARN(). >>> >>> Move the native_pv_lock_init() into xx_smp_prepare_cpus(). Make the >>> setup

Re: [PATCH][tip] x86/paravirt: Make the virt_spin_lock_key setup after jump_label_init()

2017-10-27 Thread Juergen Gross
sult in a WARN(). > > Move the native_pv_lock_init() into xx_smp_prepare_cpus(). Make the > setup later to avoid the WARN(). > > Reported-by: Juergen Gross > Suggested-by: Juergen Gross > Signed-off-by: Dou Liyang > --- > arch/x86/kernel/smpboot.c | 3 ++- > arch

[PATCH v2] xen: support 52 bit physical addresses in pv guests

2017-10-27 Thread Juergen Gross
reading/writing a MFN from/to a pte don't use the kernel's PTE_PFN_MASK but a new XEN_PTE_MFN_MASK allowing full 40 bit wide MFNs. Signed-off-by: Juergen Gross --- V2: - use __sme_clr() to clear any SME bit from MFN (Boris Ostrovsky) --- arch/x86/include/asm/xen/page.h | 11 ++-

Re: [PATCH][tip] x86/paravirt: Make the virt_spin_lock_key setup after jump_label_init()

2017-10-29 Thread Juergen Gross
On 28/10/17 12:55, Borislav Petkov wrote: > On Fri, Oct 27, 2017 at 07:25:04PM +0200, Juergen Gross wrote: >>>> This is assuming CPU 0 is the boot cpu. I think you want >>>> boot_cpu_data.cpu_index here or whatever is used on xen to identify the >>>> BSP

Re: [PATCH v4 1/1] xen/time: do not decrease steal time after live migration on xen

2017-10-29 Thread Juergen Gross
On 30/10/17 06:26, Dongli Zhang wrote: > After guest live migration on xen, steal time in /proc/stat > (cpustat[CPUTIME_STEAL]) might decrease because steal returned by > xen_steal_lock() might be less than this_rq()->prev_steal_time which is > derived from previous return value of xen_steal_clock(

Re: [locking/paravirt] static_key_disable_cpuslocked(): static key 'virt_spin_lock_key+0x0/0x20' used before call to jump_label_init()

2017-10-30 Thread Juergen Gross
e8 df 2a 7b 00 5b > 41 5c 5d c3 48 89 fa 48 c7 c6 40 93 a3 81 48 c7 c7 00 8b cb 81 e8 95 b5 > f3 ff <0f> ff eb a8 0f ff eb b3 48 89 df e8 14 fc ff ff eb c7 66 90 e8 > [    0.00] ---[ end trace c12d07f00399ce78 ]--- > [    0.00] Built 2 zonelists, mobility grouping on.  Tot

Re: [RFC PATCH] Use vAPIC when doing IPI for PVHVM guests.

2015-10-07 Thread Juergen Gross
On 10/07/2015 10:21 PM, Konrad Rzeszutek Wilk wrote: Hey, I was running some tools in which we would heavily do rescheduling of events - and realized to my surprise that the event channels (and the hypercall) would slow things down. If I used the vAPIC with its IPI support (so no VMEXIT) I got m

Re: [PATCH] x86/paravirt: remove unused operation

2015-08-28 Thread Juergen Gross
Ping? On 08/06/2015 01:55 PM, Juergen Gross wrote: Remove the paravirt operation "get_tsc_khz" as it is used nowhere. Signed-off-by: Juergen Gross --- arch/x86/include/asm/paravirt_types.h | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/include/asm/paravirt_types.h

[PATCH resend] xen: avoid early crash of memory limited dom0

2015-08-28 Thread Juergen Gross
dom0 plus the identity mapped holes required for PCI space, BIOS etc. Reported-by: Boris Ostrovsky Signed-off-by: Juergen Gross --- arch/x86/xen/setup.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c index a1a77ea..ead0d36 10

[PATCH resend] xen: avoid another early crash of memory limited dom0

2015-08-28 Thread Juergen Gross
820 map as well. Reported-by: Boris Ostrovsky Signed-off-by: Juergen Gross --- arch/x86/xen/setup.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c index ead0d36..7a5d566 100644 --- a/arch/x86/xen/setup.c +++

  1   2   3   4   5   6   7   8   9   10   >