Re: [PATCH v2 01/11] crypto: Documentation - crypto API high level spec

2014-11-05 Thread Joy M. Latten
Hi Stephan, Great docs! I think they will be very useful! Thanks! I only have 2 comments below. regards, Joy On Sun, 2014-11-02 at 21:35 +0100, Stephan Mueller wrote: > The design of the kernel crypto API as well as hints to program with > the kernel crypto API are given. > > The documentation

Re: [PATCH v2 02/11] crypto: Documentation - userspace interface spec

2014-11-05 Thread Joy M. Latten
Hi Stephan, On Sun, 2014-11-02 at 21:36 +0100, Stephan Mueller wrote: > The userspace interface of the kernel crypto API is documented with > * a general explanation > * a discussion of the memory in-place operation > * the description of the message digest API > * the description of the symme

Re: [PATCH v2 03/11] crypto: Documentation - RNG API documentation

2014-11-05 Thread Joy M. Latten
Hi Stephan, Just one quick comment below... regards, Joy On Sun, 2014-11-02 at 21:36 +0100, Stephan Mueller wrote: > The API function calls exported by the kernel crypto API for RNGs to > be used by consumers are documented. > > Signed-off-by: Stephan Mueller > CC: Marek Vasut > --- > includ

Re: [PATCH v2 05/11] crypto: Documentation - SHASH API documentation

2014-11-06 Thread Joy M. Latten
Hi Stephan, On Sun, 2014-11-02 at 21:38 +0100, Stephan Mueller wrote: > The API function calls exported by the kernel crypto API for SHASHes > to be used by consumers are documented. > > Signed-off-by: Stephan Mueller > CC: Marek Vasut > --- > include/crypto/hash.h | 197 > +++

Re: [tpmdd-devel] [PATCH 1/3] vTPM: fixed the limit checking

2015-05-12 Thread Joy M. Latten
Hi Stefan, On Mon, 2015-05-11 at 09:02 -0400, Stefan Berger wrote: > On 05/05/2015 08:51 PM, Hon Ching(Vicky) Lo wrote: > > Do not skip the last entry of the event log. > > > > Signed-off-by: Hon Ching(Vicky) Lo > > Signed-off-by: Joy Latten > > > > Changelog: > > - remove redundant code > > --

Re: [PATCH 3/3] vTPM: support little endian guests

2015-05-11 Thread Joy M. Latten
Hi Ashley, On Fri, 2015-05-08 at 17:31 -0500, Ashley Lai wrote: > > The event log in ppc64 arch is always in big endian format. PowerPC > > supports both little endian and big endian guests. This patch converts > > the event log entries to guest format. > > I'm a little confused here. If this pat