[PATCH RFC 1/3] spmi: Linux driver framework for SPMI

2013-08-16 Thread Josh Cartwright
to 16 logical slaves. The framework supports message APIs, multiple busses (1 controller per bus) and multiple clients/slave devices per controller. Signed-off-by: Kenneth Heitke Signed-off-by: Michael Bohan Signed-off-by: Josh Cartwright --- drivers/Kconfig | 2 + drivers

Re: [PATCH RFC 1/3] spmi: Linux driver framework for SPMI

2013-08-16 Thread Josh Cartwright
On Fri, Aug 16, 2013 at 11:49:21AM -0700, Greg Kroah-Hartman wrote: > On Fri, Aug 09, 2013 at 01:37:09PM -0700, Josh Cartwright wrote: > > +++ b/drivers/spmi/spmi.c > > @@ -0,0 +1,449 @@ [..] > > +static void spmi_ctrl_release(struct device *dev) > > +{ > >

Re: [PATCH RFC 1/3] spmi: Linux driver framework for SPMI

2013-08-16 Thread Josh Cartwright
Hey Greg- Thanks for the comments. On Fri, Aug 16, 2013 at 11:46:14AM -0700, Greg Kroah-Hartman wrote: > On Fri, Aug 09, 2013 at 01:37:09PM -0700, Josh Cartwright wrote: > > --- /dev/null > > +++ b/drivers/of/of_spmi.c > > @@ -0,0 +1,74 @@ > > +/* Copyright (c) 201

Re: [PATCH RFC 3/3] spmi: document the PMIC arbiter SPMI bindings

2013-08-16 Thread Josh Cartwright
Hey Kumar- Thanks for the review. On Fri, Aug 16, 2013 at 01:53:27PM -0500, Kumar Gala wrote: > On Aug 9, 2013, at 3:37 PM, Josh Cartwright wrote: > > > Signed-off-by: Josh Cartwright > > --- > > .../devicetree/bindings/spmi/spmi-pmic-arb.txt | 26 > > +++

Re: [PATCH RFC 1/3] spmi: Linux driver framework for SPMI

2013-08-16 Thread Josh Cartwright
On Fri, Aug 16, 2013 at 12:58:49PM -0700, Greg Kroah-Hartman wrote: > On Fri, Aug 16, 2013 at 02:47:15PM -0500, Josh Cartwright wrote: > > > > +#ifdef CONFIG_DEBUG_FS > > > > > > Why? If debugfs isn't enabled, the functions should just compile away > >

Re: [PATCH RFC 1/3] spmi: Linux driver framework for SPMI

2013-08-16 Thread Josh Cartwright
On Fri, Aug 16, 2013 at 02:47:14PM -0500, Josh Cartwright wrote: > > > > Why? If debugfs isn't enabled, the functions should just compile away > > with the debugfs_() calls, so no need to do this type of thing here, > > right? > > Not sure I follow you,

[PATCH RFC v2 1/5] of: Add empty for_each_available_child_of_node() macro definition

2013-08-22 Thread Josh Cartwright
From: Sylwester Nawrocki Add this empty macro definition so users can be compiled without excluding this macro call with preprocessor directives when CONFIG_OF is disabled. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- This patch was first introduced in December @ http://t

[PATCH RFC v2 3/5] spmi: add generic SPMI controller binding documentation

2013-08-22 Thread Josh Cartwright
Signed-off-by: Josh Cartwright --- I'm introducing this as an RFC, because there are set of assumptions made in this binding spec, that currently hold true for the supported controller/addressing scheme for the Snapdragon 800 series, but don't necessarily hold true for SPMI in general

[PATCH RFC v2 4/5] spmi: Add MSM PMIC Arbiter SPMI controller

2013-08-22 Thread Josh Cartwright
es on the SPMI bus. The status register is read to determine when the command sequence has completed and whether or not it completed successfully. Signed-off-by: Kenneth Heitke Signed-off-by: Josh Cartwright --- drivers/spmi/Kconfig | 15 ++ drivers/spmi/Makefile| 2 + drivers

[PATCH RFC v2 5/5] spmi: document the PMIC arbiter SPMI bindings

2013-08-22 Thread Josh Cartwright
Signed-off-by: Josh Cartwright --- .../bindings/spmi/qcom,spmi-pmic-arb.txt | 36 ++ 1 file changed, 36 insertions(+) create mode 100644 Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt diff --git a/Documentation/devicetree/bindings/spmi/qcom,spmi

[PATCH RFC v2 0/3] Add support for the System Power Management Interface (SPMI)

2013-08-22 Thread Josh Cartwright
- Add generic SPMI device tree bindings [1]: http://www.mipi.org/specifications/system-power-management-interface [2]: http://thread.gmane.org/gmane.linux.ports.arm.msm/4886 Josh Cartwright (2): spmi: add generic SPMI controller binding documentation spmi: document the PMIC arbiter SPMI bindi

[PATCH RFC v2 2/5] spmi: Linux driver framework for SPMI

2013-08-22 Thread Josh Cartwright
to 16 logical slaves. The framework supports message APIs, multiple busses (1 controller per bus) and multiple clients/slave devices per controller. Signed-off-by: Kenneth Heitke Signed-off-by: Michael Bohan Signed-off-by: Josh Cartwright --- drivers/Kconfig | 2 + drivers

Re: [PATCH RFC v2 2/5] spmi: Linux driver framework for SPMI

2013-08-23 Thread Josh Cartwright
On Thu, Aug 22, 2013 at 04:10:54PM -0700, Greg Kroah-Hartman wrote: > On Fri, Aug 09, 2013 at 01:37:09PM -0700, Josh Cartwright wrote: > > +static char dbgfs_help[] = > > + "SPMI Debug-FS support\n" > > + "\n" > > + "Hi

Re: [PATCH] clk: Add axi-clkgen driver

2013-01-22 Thread Josh Cartwright
On Wed, Jan 09, 2013 at 07:12:00PM +0100, Lars-Peter Clausen wrote: > This driver adds support for the AXI clkgen pcore to the common clock > framework. > The AXI clkgen pcore is a AXI front-end to the MMCM_ADV frequency synthesizer > commonly found in Xilinx FPGAs. > > The AXI clkgen pcore is us

Re: [PATCH V3 1/2] clocksource: add common of_clksrc_init() function

2012-11-20 Thread Josh Cartwright
On Tue, Nov 20, 2012 at 12:20:05PM -0700, Stephen Warren wrote: > From: Stephen Warren > > It is desirable to move all clocksource drivers to drivers/clocksource, > yet each requires its own initialization function. We'd rather not > pollute with a header for each function. Instead, create a > s

Re: [PATCH 1/7] clk: add common of_clk_init() function

2013-01-10 Thread Josh Cartwright
s Petazzoni and > drivers/clocksource by Stephen Warren. > > Signed-off-by: Prashant Gaikwad > --- Prashant- Sorry for the late response, but I finally got a chance to give this patchset a spin on Zynq. For patches 1 and 6: Reviewed-by: Josh Cartwright Tested-by: Josh Cartwright

Re: [PATCH] arm: mach-zynq/timer.c: fix memory leakage

2013-01-14 Thread Josh Cartwright
On Mon, Jan 14, 2013 at 10:18:46PM +0100, Cong Ding wrote: > the variable ttccs allocated isn't freed when error occurs, so we call kfree > before return. > > Signed-off-by: Cong Ding > --- > arch/arm/mach-zynq/timer.c | 25 - > 1 file changed, 16 insertions(+), 9 delet

Re: [PATCH v6 1/3] fork: Add generic vmalloced stack support

2016-08-24 Thread Josh Cartwright
Hey Andy- Small non-critical/potential future optimization comment below: On Thu, Aug 11, 2016 at 02:35:21AM -0700, Andy Lutomirski wrote: > If CONFIG_VMAP_STACK is selected, kernel stacks are allocated with > vmalloc_node. > > grsecurity has had a similar feature (called > GRKERNSEC_KSTACKOVERF

Re: [PATCH 3/5] mtd: brcmnand: Optional DT flag to reset IPROC NAND controller

2015-10-12 Thread Josh Cartwright
On Wed, Oct 07, 2015 at 03:33:50AM +, Anup Patel wrote: > From: Florian Fainelli [mailto:f.faine...@gmail.com] > > On 06/10/15 15:25, Scott Branden wrote: [..] > > Then instead of adding a "reset flag" to Device Tree, another approach > > could be > > to put the desired or currently configured

Re: [PATCHv2] fpga: zynq-fpga: Change fw format to handle bin instead of bit.

2015-10-21 Thread Josh Cartwright
On Tue, Oct 20, 2015 at 10:19:56AM -0700, Moritz Fischer wrote: > This gets rid of the code to strip away the header and byteswap, > as well as the check for the sync word. > > Signed-off-by: Moritz Fischer Simpler is better. Reviewed-by: Josh Cartwright Josh -- To unsubscri

Re: [PATCH v4] PCI: Xilinx-NWL-PCIe: Added support for Xilinx NWL PCIe Host Controller

2015-10-18 Thread Josh Cartwright
Hello, I've got a few comments below. On Sat, Oct 17, 2015 at 12:52:18PM +0530, Bharat Kumar Gogada wrote: > Adding PCIe Root Port driver for Xilinx PCIe NWL bridge IP. > > Signed-off-by: Bharat Kumar Gogada > Signed-off-by: Ravi Kiran Gummaluri > --- > Added MSI domain implementation for hand

Re: [PATCHv2 1/3] ARM: dt: fpga: Added binding docs for Xilinx Zynq FPGA manager.

2015-10-18 Thread Josh Cartwright
ain "xlnx,zynq-devcfg-1.0" > +- reg: base address and size for memory mapped io > +- interrupts:interrupt for the FPGA manager device > +- clocks:phandle for clocks required operation Technically a "clock specifier", but

Re: [PATCHv2 2/3] ARM: zynq: dt: Updated devicetree for Zynq 7000 platform.

2015-10-18 Thread Josh Cartwright
On Fri, Oct 16, 2015 at 03:42:29PM -0700, Moritz Fischer wrote: > Added addtional nodes required for FPGA Manager operation > of the Xilinx Zynq Devc configuration interface. > > Reviewed-by: Sören Brinkmann > Signed-off-by: Moritz Fischer > --- > > v2: No changes > > --- > arch/arm/boot/dts/

Re: [PATCHv2 3/3] fpga manager: Adding FPGA Manager support for Xilinx Zynq 7000

2015-10-18 Thread Josh Cartwright
Hey Moritz- On Fri, Oct 16, 2015 at 03:42:30PM -0700, Moritz Fischer wrote: > This commit adds FPGA Manager support for the Xilinx Zynq chip. > The code borrows some from the xdevcfg driver in Xilinx' > vendor tree. > > Signed-off-by: Moritz Fischer > --- > > v2: > - Replaced locking error fla

Re: [PATCHv2 0/3] Adding FPGA Manager support for Xilinx Zynq

2015-10-18 Thread Josh Cartwright
On Fri, Oct 16, 2015 at 03:42:27PM -0700, Moritz Fischer wrote: > Hi all, > > I've tried to address most of the feedback that was brought up, > the one thing I haven't looked at was the firmware format part, > since that was still in discussion. > So I'm still open to suggestions on how to handle

Re: [PATCHv2 2/3] ARM: zynq: dt: Updated devicetree for Zynq 7000 platform.

2015-10-19 Thread Josh Cartwright
On Mon, Oct 19, 2015 at 04:09:09PM +0200, Michal Simek wrote: > On 10/18/2015 07:53 PM, Josh Cartwright wrote: > > On Fri, Oct 16, 2015 at 03:42:29PM -0700, Moritz Fischer wrote: [..] > >> @@ -294,6 +294,11 @@ > >>devcfg: devcfg@f8007000 { > >>

Re: [RFC] fpga: socfpga: Fix check of return value of devm_request_irq

2015-10-25 Thread Josh Cartwright
proper resend would likely be the easiest way for him to pick it up. Feel free to add by Reviewed-by as well: Reviewed-by: Josh Cartwright Thanks, Josh > > --- > > drivers/fpga/socfpga.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --g

[PATCH -rt] Revert "net: use synchronize_rcu_expedited()"

2015-10-26 Thread Josh Cartwright
op_machine() mechanism). Without be3fc413da9e reverted, we can observe a latency spike up to 30us with cyclictest by rapidly unplugging/reestablishing an ethernet link. Cc: Eric Dumazet Cc: Paul E. McKenney Cc: David S. Miller Signed-off-by: Josh Cartwright --- net/core/dev.c | 5 + 1 file

Re: [PATCH v2 1/3] leds: add device activity LED triggers

2015-10-01 Thread Josh Cartwright
Hello Maciek- Some architectural questions below: On Thu, Oct 01, 2015 at 04:04:31PM +0200, Maciek Borzecki wrote: > The patch adds LED triggers for indicating an activity on a selected > device. The drivers that intend to use triggers need to register > respective devices using ledtrig_dev_add()

Re: [PATCH v2 1/3] leds: add device activity LED triggers

2015-10-02 Thread Josh Cartwright
On Fri, Oct 02, 2015 at 09:45:37AM +0200, Maciek Borzecki wrote: > On 10/01 09:47, Josh Cartwright wrote: > > On Thu, Oct 01, 2015 at 04:04:31PM +0200, Maciek Borzecki wrote: > > > The patch adds LED triggers for indicating an activity on a selected > > > device. The

Re: [PATCH v2] ARM: zynq: use restart_handler mechanism for slcr reset

2015-03-19 Thread Josh Cartwright
On Thu, Mar 19, 2015 at 11:44:23AM +0100, Michal Simek wrote: > On 02/27/2015 04:09 PM, Josh Cartwright wrote: [..] > > +++ b/arch/arm/mach-zynq/slcr.c > > @@ -15,6 +15,7 @@ > > */ > > > > #include > > +#include > > #include > >

[PATCH v3 1/2] ARM: zynq: use restart_handler mechanism for slcr reset

2015-03-19 Thread Josh Cartwright
By making use of the restart_handler chain mechanism, the SLCR-based reset mechanism can be prioritized amongst other mechanisms available on a particular board. Choose a default high-ish priority of 192 for this restart mechanism. Signed-off-by: Josh Cartwright --- v2 -> v3: Don't

[PATCH 2/2] ARM: zynq: drop use of slcr_unlock in zynq_slcr_system_restart

2015-03-19 Thread Josh Cartwright
The SLCR is unconditionally unlocked early on boot in zynq_slcr_init() and not unlocked. As such, it is not necessary to explicitly unlock in the restart codepath. Signed-off-by: Josh Cartwright --- arch/arm/mach-zynq/slcr.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/arch/arm

Re: [PATCH v2] ARM: zynq: use restart_handler mechanism for slcr reset

2015-03-19 Thread Josh Cartwright
On Thu, Mar 19, 2015 at 02:19:01PM +0100, Michal Simek wrote: > On 03/19/2015 01:44 PM, Josh Cartwright wrote: > > On Thu, Mar 19, 2015 at 11:44:23AM +0100, Michal Simek wrote: > >> On 02/27/2015 04:09 PM, Josh Cartwright wrote: > > [..] > >>> +++ b/arch/arm/m

Re: [PATCH 2/2] ARM: zynq: drop use of slcr_unlock in zynq_slcr_system_restart

2015-03-19 Thread Josh Cartwright
Ugh. On Thu, Mar 19, 2015 at 08:33:53AM -0500, Josh Cartwright wrote: > The SLCR is unconditionally unlocked early on boot in zynq_slcr_init() > and not unlocked. As such, it is not necessary to explicitly unlock in ^ever re-locked. Can you fix this up when you apply? Thanks,

Re: [PATCH v3 1/2] ARM: zynq: use restart_handler mechanism for slcr reset

2015-03-19 Thread Josh Cartwright
On Thu, Mar 19, 2015 at 03:01:13PM +0100, Michal Simek wrote: > On 03/19/2015 02:33 PM, Josh Cartwright wrote: [..] > > /** > > - * zynq_slcr_system_reset - Reset the entire system. > > + * zynq_slcr_system_restart - Restart the entire system. > > */ > >

[PATCH v4] ARM: zynq: use restart_handler mechanism for slcr reset

2015-03-19 Thread Josh Cartwright
By making use of the restart_handler chain mechanism, the SLCR-based reset mechanism can be prioritized amongst other mechanisms available on a particular board. Choose a default high-ish priority of 192 for this restart mechanism. Signed-off-by: Josh Cartwright --- v3 -> v4: Document rest

Re: [PATCH 1/2] cpufreq: mediatek: Add MT8173 cpufreq driver

2015-04-22 Thread Josh Cartwright
On Wed, Apr 22, 2015 at 11:11:34AM +0800, Pi-Cheng Chen wrote: [..] > >> +config ARM_MT8173_CPUFREQ > >> + bool "Mediatek MT8173 CPUFreq support" > >> + depends on ARCH_MEDIATEK && REGULATOR > > > > I think you want to 'select REGULATOR' here; because REGULATOR isn't > > a user-visible opti

Re: Adding subpage support to NAND driver -- backwards compatibility concerns

2015-04-23 Thread Josh Cartwright
+Richard, who, when not being trolled on IRC, has been working on UBI(FS) stuff. On Thu, Apr 23, 2015 at 12:48:53PM +1000, Iwo Mergler wrote: > On Thu, 23 Apr 2015 03:29:44 +1000 > Ben Shelton wrote: > > We'd like to upstream our patch, but my concern is that UBIFS behaves > > differently when it

Re: [PATCH v6 1/2] Devicetree: Add pl353 smc controller devicetree binding information

2015-04-23 Thread Josh Cartwright
Hey Punnaiah- A few nitpicks here, in case you'll be spinning up a new version of your patchset. On Mon, Apr 13, 2015 at 09:41:51PM +0530, Punnaiah Choudary Kalluri wrote: > Add pl353 static memory controller devicetree binding information. > > Signed-off-by: Punnaiah Choudary Kalluri [..] > @@

Re: [PATCH 1/3] mtd: nand: Add on-die ECC support

2015-04-28 Thread Josh Cartwright
On Tue, Apr 28, 2015 at 09:14:26AM +0530, punnaiah choudary kalluri wrote: > On Tue, Apr 28, 2015 at 8:52 AM, Brian Norris > wrote: > > On Tue, Apr 28, 2015 at 08:18:12AM +0530, punnaiah choudary kalluri wrote: > >> On Tue, Apr 28, 2015 at 4:53 AM, Brian Norris > >> wrote: [..] > >> Agree that

Re: [PATCH 1/2] cpufreq: mediatek: Add MT8173 cpufreq driver

2015-04-20 Thread Josh Cartwright
On Mon, Apr 20, 2015 at 05:27:26PM +0800, pi-cheng.chen wrote: > This patch implements MT8173 specific cpufreq driver with OPP table defined > in the driver code. > > Signed-off-by: pi-cheng.chen > --- > drivers/cpufreq/Kconfig.arm | 6 + > drivers/cpufreq/Makefile | 1 + > driv

Re: [PATCHv4 2/2] mailbox: Adding driver for Xilinx LogiCORE IP mailbox.

2015-06-16 Thread Josh Cartwright
Hey Moritz- A few comments below: On Mon, Jun 01, 2015 at 09:18:27AM -0700, Moritz Fischer wrote: [..] > +++ b/drivers/mailbox/mailbox-xilinx.c > @@ -0,0 +1,352 @@ > +/* > + * Copyright (c) 2015, National Instruments Corp. All rights reserved. > + * > + * Driver for the Xilinx LogiCORE mailbox IP

Re: [PATCHv4 1/2] dts: Adding docs for Xilinx LogiCORE IP mailbox driver.

2015-06-16 Thread Josh Cartwright
On Mon, Jun 01, 2015 at 09:18:26AM -0700, Moritz Fischer wrote: > Changes from v3: > - Changed reg size to 0x100 > > Changes from v2: > - Addressed Michal's stylistic comments > - Fixed typo in compatible string > > Changes from v1: > - Added common clock framework support > > Changes from v0: >

Re: [PATCHv5 2/2] mailbox: Adding driver for Xilinx LogiCORE IP mailbox.

2015-06-23 Thread Josh Cartwright
Hey Moritz- Just a couple more nits, nothing big. Looks pretty clean! On Tue, Jun 23, 2015 at 11:00:02AM -0700, Moritz Fischer wrote: > The Xilinx LogiCORE IP mailbox is a FPGA core that allows for > interprocessor communication via AXI4 memory mapped / AXI4 stream > interfaces. > > It is singl

[PATCH 2/3] PM: define new ASSIGN_*_PM_OPS macros based on assign_if

2014-02-24 Thread Josh Cartwright
(foo_suspend, foo_resume) }; Unlike their SET_*_PM_OPS() counter parts, it is unnecessary to wrap the function callbacks in #ifdeffery in order to prevent 'defined but not used' warnings when the corresponding CONFIG_PM* options are unset. Signed-off-by: Josh Cartwright --- include/linux

[PATCH 3/3] usb: phy: msm: use ASSIGN_*_PM_OPS variants

2014-02-24 Thread Josh Cartwright
Use ASSIGN_SYSTEM_SLEEP_PM_OPS and ASSIGN_RUNTIME_PM_OPS in the initializer for msm_otg_dev_pm_ops. Doing so allows us to eliminate preprocessor conditionals around the specified callbacks. Signed-off-by: Josh Cartwright --- drivers/usb/phy/phy-msm-usb.c | 13 +++-- 1 file changed, 3

[PATCH 1/3] typecheck: introduce assign_if() and assign_if_enabled()

2014-02-24 Thread Josh Cartwright
. static void foo_callback(void) { } static struct foo_object foo_obj = { .callback = assign_if_enabled(CONFIG_FOO, foo_callback), }; Cc: Andrew Morton Signed-off-by: Josh Cartwright --- include/linux/typecheck.h | 18 ++ 1 file

[PATCH 0/3] introduce assign_if() macros in attempt to reduce ifdeffery

2014-02-24 Thread Josh Cartwright
Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. Josh Cartwright (3): typecheck: introduce assign_if() and assign_if_enabled() PM: define new ASS

Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-02-24 Thread Josh Cartwright
On Mon, Feb 24, 2014 at 12:33:10PM +0200, Ivan T. Ivanov wrote: > On Fri, 2014-02-21 at 09:35 -0600, Kumar Gala wrote: > > On Feb 20, 2014, at 6:38 PM, Bjorn Andersson > > wrote: > > > > > This bus driver supports the QUP i2c hardware controller in the Qualcomm > > > SOCs. > > > The Qualcomm U

Re: linux-next: Tree for Feb 17 (pinctrl-msm)

2014-02-24 Thread Josh Cartwright
state'. Josh --8<-- Subject: [PATCH] pinctrl: msm: make PINCTRL_MSM bool instead of tristate Modular builds of pinctrl-msm break due to handle_bad_irq being unexported for module use. For now, make PINCTRL_MSM 'bool'. Signed-off-by: Josh Cartwright --- drivers/pinctrl/

Re: [PATCH 05/11] ARM: Introduce CPU_METHOD_OF_DECLARE() for cpu hotplug/smp

2013-11-06 Thread Josh Cartwright
Hey Stephen- Nit/suggestion below: On Fri, Nov 01, 2013 at 03:08:53PM -0700, Stephen Boyd wrote: [..] > diff --git a/arch/arm/include/asm/smp.h b/arch/arm/include/asm/smp.h > index a8cae71c..c27ec55 100644 > --- a/arch/arm/include/asm/smp.h > +++ b/arch/arm/include/asm/smp.h > @@ -112,6 +112,15 @

[PATCH v3 6/6] mfd: devicetree: bindings: add pm8xxx RTC description

2014-03-12 Thread Josh Cartwright
dings describing what the the PM8xxx devices are and how they are expected to be used. Signed-off-by: Josh Cartwright --- Andrew- Here's a new 6/6. Like mentioned earlier, this is based on the current MFD document that's in Lee's tree pending for 3.15. It may be best to get yours and Ro

Re: [PATCHv4 4/7] hwspinlock/core: add common OF helpers

2014-03-13 Thread Josh Cartwright
On Tue, Mar 04, 2014 at 11:38:23AM -0600, Suman Anna wrote: > Hi Ohad, > > On 03/02/2014 02:19 PM, Bjorn Andersson wrote: > >On Sat, Mar 1, 2014 at 9:14 PM, Ohad Ben-Cohen wrote: > >>On Mon, Feb 10, 2014 at 9:14 PM, Suman Anna wrote: > >>>On 02/07/2014 04:49 PM, Bjorn Andersson wrote: > >>>Ohad,

Re: [PATCHv4 4/7] hwspinlock/core: add common OF helpers

2014-03-14 Thread Josh Cartwright
On Fri, Mar 14, 2014 at 03:12:26PM +0200, Ohad Ben-Cohen wrote: > On Sun, Mar 2, 2014 at 10:19 PM, Bjorn Andersson wrote: > > When introducing the ability to reference a hwspin lock via a phandle > > in device tree it makes a big difference to be able to differ between > > the case of "initializat

Re: [PATCH v5 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-03-14 Thread Josh Cartwright
On Thu, Mar 13, 2014 at 07:07:43PM -0700, Bjorn Andersson wrote: > This bus driver supports the QUP i2c hardware controller in the Qualcomm SOCs. > The Qualcomm Universal Peripheral Engine (QUP) is a general purpose data path > engine with input/output FIFOs and an embedded i2c mini-core. The drive

Re: [PATCH 1/2] i2c: Add driver for Cadence I2C controller

2014-03-04 Thread Josh Cartwright
On Fri, Feb 28, 2014 at 07:06:29PM -0800, S?ren Brinkmann wrote: > On Fri, 2014-02-28 at 04:00PM -0800, Soren Brinkmann wrote: > > Add a driver for the Cadence I2C controller. This controller is for > > example found in Xilinx Zynq. > > > > Signed-off-by: Soren Brinkmann > > --- > > .../devicetr

[PATCH 2/6] rtc: pm8xxx: use regmap API for register accesses

2014-03-05 Thread Josh Cartwright
Now that the parent mfd driver has been made to work again, and has been reworked to create a regmap instance intended for it's children to use, rework the pm8xxx driver to use the regmap API for it's register accesses. Signed-off-by: Josh Cartwright --- drivers/rtc/rtc-pm8x

[PATCH 1/6] rtc: pm8xxx: fixup checkpatch/style issues

2014-03-05 Thread Josh Cartwright
Before performing additional cleanups to this driver, do the easy cleanups first. Signed-off-by: Josh Cartwright --- drivers/rtc/rtc-pm8xxx.c | 88 +--- 1 file changed, 45 insertions(+), 43 deletions(-) diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers

[PATCH 3/6] rtc: pm8xxx: use devm_request_any_context_irq

2014-03-05 Thread Josh Cartwright
Make use of the devm_* variant of request_any_context_irq to allow for elimination of remove(). Signed-off-by: Josh Cartwright --- drivers/rtc/rtc-pm8xxx.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c

[PATCH 6/6] documentation: bindings: document PMIC8921/8058 RTC

2014-03-05 Thread Josh Cartwright
This RTC is found on the Qualcomm 8921 and 8058 PMICs. Signed-off-by: Josh Cartwright --- .../devicetree/bindings/rtc/qcom,pm8xxx-rtc.txt| 29 ++ 1 file changed, 29 insertions(+) create mode 100644 Documentation/devicetree/bindings/rtc/qcom,pm8xxx-rtc.txt diff --git a

[PATCH 5/6] rtc: pm8xxx: move device_init_wakeup() before rtc_register

2014-03-05 Thread Josh Cartwright
Setup wakeup capability before rtc_register to ensure the rtc class core properly sets up our 'wakealarm' sysfs attribute. Signed-off-by: Josh Cartwright --- drivers/rtc/rtc-pm8xxx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-pm8xxx.c b/d

[PATCH 4/6] rtc: pm8xxx: add support for devicetree

2014-03-05 Thread Josh Cartwright
-by: Josh Cartwright --- drivers/rtc/rtc-pm8xxx.c | 54 +++--- include/linux/mfd/pm8xxx/rtc.h | 25 --- 2 files changed, 30 insertions(+), 49 deletions(-) delete mode 100644 include/linux/mfd/pm8xxx/rtc.h diff --git a/drivers/rtc/rtc

[PATCH] pinctrl: msm: drop wake_irqs bitmap

2014-03-05 Thread Josh Cartwright
ing a 'wake_count' per irq_desc, and only calling into the controlling irq_chip when wake_count transitions 0 <-> 1. Drop this bitmap, and unconditionally call irq_set_irq_wake() on the summary interrupt. Signed-off-by: Josh Cartwright --- drivers/pinctrl/pinctrl-msm.c | 14 +

[PATCH] mfd: pm8921: fixup probe() error path when irq invalid

2014-03-05 Thread Josh Cartwright
platform_get_irq() returns a negative error code when an IRQ is invalid or unspecified. Make 'irq' signed to properly handle this. Cc: Stephen Boyd Signed-off-by: Josh Cartwright --- drivers/mfd/pm8921-core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/d

Re: [PATCH v10 1/3] mmc: sdhci-msm: Qualcomm SDHCI binding documentation

2014-03-05 Thread Josh Cartwright
Hey Rob- On Wed, Mar 05, 2014 at 12:56:22AM -0600, Rob Herring wrote: > On Tue, Mar 4, 2014 at 1:27 PM, Georgi Djakov wrote: > > +- reg-names: Should contain the following: > > + "hc_mem" - Host controller register map > > + "core_mem" - SD Core register map > > reg-names should not

Re: [PATCH 1/6] rtc: pm8xxx: fixup checkpatch/style issues

2014-03-05 Thread Josh Cartwright
On Wed, Mar 05, 2014 at 01:02:29PM -0800, Stephen Boyd wrote: > On 03/05/14 11:29, Josh Cartwright wrote: > > Before performing additional cleanups to this driver, do the easy > > cleanups first. > > > > Signed-off-by: Josh Cartwright > > Reviewed-by: Step

Re: [PATCH 6/6] documentation: bindings: document PMIC8921/8058 RTC

2014-03-05 Thread Josh Cartwright
On Wed, Mar 05, 2014 at 12:58:55PM -0800, Stephen Boyd wrote: > On 03/05/14 11:29, Josh Cartwright wrote: > > diff --git a/Documentation/devicetree/bindings/rtc/qcom,pm8xxx-rtc.txt > > b/Documentation/devicetree/bindings/rtc/qcom,pm8xxx-rtc.txt > > new file mode 100644 >

Re: [PATCH v12] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2014-03-06 Thread Josh Cartwright
On Tue, Feb 25, 2014 at 05:01:01PM -0600, Alan Tull wrote: > From: Jamie Iles > > The Synopsys DesignWare block is used in some ARM devices (picoxcell) > and can be configured to provide multiple banks of GPIO pins. > > Signed-off-by: Jamie Iles > Signed-off-by: Alan Tull > Reviewed-by: Sebast

[PATCH -next] slub: Replace __this_cpu_inc usage w/ SLUB_STATS

2014-03-06 Thread Josh Cartwright
On Thu, Mar 06, 2014 at 09:53:16AM -0600, Josh Cartwright wrote: > Booting on my Samsung Series 9 laptop gives me loads and loads of BUGs > triggered by __this_cpu_add(), making making the system completely > unusable: > > [5.808326] BUG: using __this_cpu_add() in preemptible

Re: [PATCH v3 1/9] Input: pmic8xxx-pwrkey - Migrate to regmap APIs

2014-02-26 Thread Josh Cartwright
On Wed, Feb 26, 2014 at 11:05:54AM -0800, Stephen Boyd wrote: > Use the regmap APIs for this driver instead of custom pm8xxx > APIs. This breaks this driver's dependency on the pm8xxx APIs and > allows us to easily port it to other bus protocols in the future. > > Signed-off-by: Stephen Boyd > --

Re: [PATCH v3 2/9] Input: pmic8xxx-keypad - Migrate to devm_* APIs

2014-02-26 Thread Josh Cartwright
On Wed, Feb 26, 2014 at 11:05:55AM -0800, Stephen Boyd wrote: > Simplify the error paths and reduce the lines of code in this > driver by using the devm_* APIs. > > Signed-off-by: Stephen Boyd > --- > drivers/input/keyboard/pmic8xxx-keypad.c | 62 > +--- > 1 file cha

Re: [PATCH v3 1/9] Input: pmic8xxx-pwrkey - Migrate to regmap APIs

2014-02-26 Thread Josh Cartwright
On Wed, Feb 26, 2014 at 04:05:40PM -0800, Stephen Boyd wrote: > On 02/26/14 15:59, Josh Cartwright wrote: > > On Wed, Feb 26, 2014 at 11:05:54AM -0800, Stephen Boyd wrote: > >> Use the regmap APIs for this driver instead of custom pm8xxx > >> APIs. This breaks this

Re: [PATCH v3 1/9] Input: pmic8xxx-pwrkey - Migrate to regmap APIs

2014-02-26 Thread Josh Cartwright
On Wed, Feb 26, 2014 at 04:20:03PM -0800, Stephen Boyd wrote: > On 02/26/14 16:13, Josh Cartwright wrote: > > On Wed, Feb 26, 2014 at 04:05:40PM -0800, Stephen Boyd wrote: > >> On 02/26/14 15:59, Josh Cartwright wrote: > > However, I think it needs to be made clear that y

Re: [PATCH v3 1/9] Input: pmic8xxx-pwrkey - Migrate to regmap APIs

2014-02-26 Thread Josh Cartwright
On Wed, Feb 26, 2014 at 04:43:03PM -0800, Stephen Boyd wrote: > On 02/26/14 16:30, Josh Cartwright wrote: > > On Wed, Feb 26, 2014 at 04:20:03PM -0800, Stephen Boyd wrote: > >> On 02/26/14 16:13, Josh Cartwright wrote: > >>> On Wed, Feb 26, 2014 at 04:05:40PM -0800,

Re: [PATCH 1/3] ARM: config: Add qcom_defconfig

2014-02-27 Thread Josh Cartwright
On Wed, Feb 26, 2014 at 06:16:32PM -0800, Stephen Boyd wrote: > Add a defconfig for mach-qcom platforms. Although these platforms > are part of the multi-platform kernel, it's useful to have a > stripped down version of the defconfig that just selects the > Qualcomm based platforms and drivers. Ho

Re: [PATCH 1/3] typecheck: introduce assign_if() and assign_if_enabled()

2014-02-27 Thread Josh Cartwright
On Thu, Feb 27, 2014 at 11:00:32AM -0800, Greg Kroah-Hartman wrote: > On Mon, Feb 24, 2014 at 11:08:25AM -0600, Josh Cartwright wrote: > > +/* > > + * Intended for use in static object initializers, > > + * assign_if(const_expr, function) evaluates to 'function' if

Re: [PATCH v4 4/9] Input: pmic8xxx-keypad - Migrate to DT

2014-02-27 Thread Josh Cartwright
Looks good, with the exception of one thing... On Thu, Feb 27, 2014 at 05:55:15PM -0800, Stephen Boyd wrote: > The driver is only supported on DT enabled platforms. Convert the > driver to DT so that it can probe properly. > > Signed-off-by: Stephen Boyd > --- > drivers/input/keyboard/pmic8xxx-

Re: [PATCH v4 5/9] Input: pmic8xxx-pwrkey - Migrate to DT

2014-02-27 Thread Josh Cartwright
On Thu, Feb 27, 2014 at 05:55:16PM -0800, Stephen Boyd wrote: > The driver is only supported on DT enabled platforms. Convert the > driver to DT so that it can probe properly. > > Signed-off-by: Stephen Boyd > --- > --- a/drivers/input/misc/pmic8xxx-pwrkey.c > +++ b/drivers/input/misc/pmic8xxx-pw

Re: [PATCH v4 7/9] devicetree: bindings: Document PM8921/8058 keypads

2014-02-28 Thread Josh Cartwright
On Thu, Feb 27, 2014 at 05:55:18PM -0800, Stephen Boyd wrote: > Document the keypad device found on PM8921 and PM8058 PMICs. [..] > +++ b/Documentation/devicetree/bindings/input/qcom,pm8xxx-keypad.txt > @@ -0,0 +1,72 @@ > +Qualcomm PM8xxx PMIC Keypad > + > +PROPERTIES > + > +- compatible: > + U

Re: [PATCH v4 7/9] devicetree: bindings: Document PM8921/8058 keypads

2014-02-28 Thread Josh Cartwright
On Fri, Feb 28, 2014 at 10:37:08AM -0800, Stephen Boyd wrote: > On 02/28, Josh Cartwright wrote: > > On Thu, Feb 27, 2014 at 05:55:18PM -0800, Stephen Boyd wrote: > > > + > > > +EXAMPLE > > > + > > > + keypad { > > > + compatible =

Re: [PATCH v9 3/3] mmc: sdhci-msm: Add platform_execute_tunning implementation

2014-02-28 Thread Josh Cartwright
Nit below. On Fri, Feb 28, 2014 at 01:24:35PM +0200, Georgi Djakov wrote: > This patch adds implementation for platform specific tuning in order to > support > HS200 bus speed mode on Qualcomm SDHCI controller. > > Signed-off-by: Asutosh Das > Signed-off-by: Venkat Gopalakrishnan > Signed-off-

Re: [PATCH v9 3/3] mmc: sdhci-msm: Add platform_execute_tunning implementation

2014-02-28 Thread Josh Cartwright
On Fri, Feb 28, 2014 at 01:24:35PM +0200, Georgi Djakov wrote: > This patch adds implementation for platform specific tuning in order to > support > HS200 bus speed mode on Qualcomm SDHCI controller. > > Signed-off-by: Asutosh Das > Signed-off-by: Venkat Gopalakrishnan > Signed-off-by: Georgi D

[PATCH 2/2] spmi: pm: drop bus-level PM suspend/resume routines

2014-03-03 Thread Josh Cartwright
MI device drivers. Cc: Felipe Balbi Signed-off-by: Josh Cartwright --- drivers/spmi/spmi.c | 35 --- 1 file changed, 35 deletions(-) diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c index 6122c8f..3b57807 100644 --- a/drivers/spmi/spmi.c +++ b/drive

[PATCH 1/2] spmi: pmic_arb: make selectable on ARCH_QCOM

2014-03-03 Thread Josh Cartwright
With the split of Qualcomm MSM support into legacy and multiplatform, the SPMI PMIC arb driver is only relevant on the multiplatform supported SoCs. Switch the Kconfig depends to ARCH_QCOM. Cc: Kumar Gala Signed-off-by: Josh Cartwright --- drivers/spmi/Kconfig | 4 ++-- 1 file changed, 2

Re: [PATCH] SPI: Add driver for Cadence SPI controller

2014-03-17 Thread Josh Cartwright
On Mon, Mar 17, 2014 at 05:30:17PM +, Mark Brown wrote: > On Mon, Mar 17, 2014 at 05:35:36PM +0530, Harini Katakam wrote: [..] > > +static int __maybe_unused cdns_spi_suspend(struct device *dev) > > +{ > > This needs to call spi_master_suspend() as well (and similarly on > resume). I'm not th

Re: [PATCH 1/1] regulator: Add new driver for ST's PWM controlled voltage regulators

2014-03-20 Thread Josh Cartwright
Hey Lee- A few minor things below. On Thu, Mar 20, 2014 at 02:10:54PM +, Lee Jones wrote: > On some STMicroelectronics hardware reside regulators consisting > partly of a PWM input connected to the feedback loop. As the PWM > duty-cycle is varied the output voltage adapts. This driver > allow

Re: [PATCH 1/1] regulator: Add new driver for ST's PWM controlled voltage regulators

2014-03-20 Thread Josh Cartwright
On Thu, Mar 20, 2014 at 03:48:27PM +, Lee Jones wrote: [..] > > > + dutycycle = (ST_PWM_REG_PERIOD / 100) * > > > + drvdata->duty_cycle_table[sel].dutycycle; > > > > Considering (ST_PWM_REG_PERIOD / 100) is constant, could you get away > > with dropping this calculation by just putting

Re: [RFC 1/6] mailbox: add core framework

2014-02-10 Thread Josh Cartwright
On Mon, Feb 10, 2014 at 11:52:05AM -0600, Rob Herring wrote: > On Mon, Feb 10, 2014 at 8:11 AM, Arnd Bergmann wrote: > > On Friday 07 February 2014 16:50:14 Courtney Cavin wrote: [..] > >> +int mbox_channel_notify(struct mbox_channel *chan, > >> + const void *data, unsigned int len) >

Re: [PATCH] of: Turn of_match_node into a static inline when CONFIG_OF isn't set

2014-02-11 Thread Josh Cartwright
Hey Laurent- On Tue, Feb 11, 2014 at 01:36:51PM +0100, Laurent Pinchart wrote: > when CONFIG_OF is disabled of_match_node is defined as a macro that > evaluates to NULL. This breaks compilation of drivers that dereference > the function's return value directly. Fix it by turning the macro into a >

[PATCH 8/8] cpufreq: ppc: make use of of_find_matching_node_and_match

2014-02-11 Thread Josh Cartwright
Instead of the of_find_matching_node()/of_match_node() pair, which requires two iterations through the match table, make use of of_find_matching_node_and_match(), which only iterates through the table once. Signed-off-by: Josh Cartwright --- drivers/cpufreq/ppc-corenet-cpufreq.c | 3 +-- 1

[PATCH 5/8] ARM: prima2: make use of of_find_matching_node_and_match

2014-02-11 Thread Josh Cartwright
Instead of the of_find_matching_node()/of_match_node() pair, which requires two iterations through the match table, make use of of_find_matching_node_and_match(), which only iterates through the table once. While we're here, mark the prima2_l2x0 table const. Signed-off-by: Josh Cartw

[PATCH 1/8] bus: arm-cci: make use of of_find_matching_node_and_match

2014-02-11 Thread Josh Cartwright
:49: error: request for member ‘data’ in something not a structure or union Signed-off-by: Josh Cartwright --- drivers/bus/arm-cci.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c index 962fd35..e249cdb2 100644 --- a/drivers/

[PATCH 2/8] bus: mvebu-mbus: make use of of_find_matching_node_and_match

2014-02-11 Thread Josh Cartwright
Instead of the of_find_matching_node()/of_match_node() pair, which requires two iterations through the match table, make use of of_find_matching_node_and_match(), which only iterates through the table once. Signed-off-by: Josh Cartwright --- drivers/bus/mvebu-mbus.c | 3 +-- 1 file changed, 1

[PATCH 0/8] of_find_matching_node/of_match_node -> of_find_matching_node_and_match

2014-02-11 Thread Josh Cartwright
: 50c8af4cf9 (of: introduce for_each_matching_node_and_match()) Josh Cartwright (8): bus: arm-cci: make use of of_find_matching_node_and_match bus: mvebu-mbus: make use of of_find_matching_node_and_match ARM: at91: make use of of_find_matching_node_and_match ARM: mvebu: make use of

[PATCH 3/8] ARM: at91: make use of of_find_matching_node_and_match

2014-02-11 Thread Josh Cartwright
Instead of the of_find_matching_node()/of_match_node() pair, which requires two iterations through the match table, make use of of_find_matching_node_and_match(), which only iterates through the table once. While we're here, mark the rtsc id table const. Signed-off-by: Josh Cartw

[PATCH 6/8] ARM: l2x0: make use of of_find_matching_node_and_match

2014-02-11 Thread Josh Cartwright
Instead of the of_find_matching_node()/of_match_node() pair, which requires two iterations through the match table, make use of of_find_matching_node_and_match(), which only iterates through the table once. Signed-off-by: Josh Cartwright --- arch/arm/mm/cache-l2x0.c | 5 +++-- 1 file changed

[PATCH 4/8] ARM: mvebu: make use of of_find_matching_node_and_match

2014-02-11 Thread Josh Cartwright
Instead of the of_find_matching_node()/of_match_node() pair, which requires two iterations through the match table, make use of of_find_matching_node_and_match(), which only iterates through the table once. While we're here, mark the of_system_controller table const. Signed-off-by:

[PATCH 7/8] C6X: make use of of_find_matching_node_and_match

2014-02-11 Thread Josh Cartwright
Instead of the of_find_matching_node()/of_match_node() pair, which requires two iterations through the match table, make use of of_find_matching_node_and_match(), which only iterates through the table once. Signed-off-by: Josh Cartwright --- arch/c6x/platforms/plldata.c | 7 +++ 1 file

Re: [PATCH] of: Turn of_match_node into a static inline when CONFIG_OF isn't set

2014-02-11 Thread Josh Cartwright
On Tue, Feb 11, 2014 at 03:55:35PM +0100, Laurent Pinchart wrote: > Hi Josh, > > On Tuesday 11 February 2014 08:41:08 Josh Cartwright wrote: > > On Tue, Feb 11, 2014 at 01:36:51PM +0100, Laurent Pinchart wrote: > > > when CONFIG_OF is disabled of_match_node is

<    1   2   3   4   5   >