[PATCH 1/2 v8] ASoC: dwc: Add PIO PCM extension

2016-05-30 Thread Jose Abreu
the reason why this extension was added. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Mark Brown Cc: Liam Girdwood Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Rob Herring Cc: Alexey Brodkin Cc: linux-snps-...@lists.infradead.org Cc: alsa-de...@alsa-project.org Cc: linux-kernel

[PATCH 0/2 v8] Add I2S audio support for ARC AXS10x boards

2016-05-30 Thread Jose Abreu
os Palminha Cc: Mark Brown Cc: Liam Girdwood Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Rob Herring Cc: Alexey Brodkin Cc: linux-snps-...@lists.infradead.org Cc: alsa-de...@alsa-project.org Cc: linux-kernel@vger.kernel.org Jose Abreu (2): ASoC: dwc: Add PIO PCM extension ASoC: dwc:

[PATCH 2/2 v8] ASoC: dwc: Add irq parameter to DOCUMENTATION

2016-05-30 Thread Jose Abreu
A parameter description for the interruptions of the I2S controller was added. Signed-off-by: Jose Abreu Acked-by: Rob Herring Cc: Carlos Palminha Cc: Mark Brown Cc: Liam Girdwood Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Rob Herring Cc: Alexey Brodkin Cc: linux-snps

[RFC] [media] Add Synopsys Designware HDMI RX PHY e405 driver

2016-11-09 Thread Jose Abreu
would really apreciate some feedback. Looking forward to your comments! Best regards, Jose Miguel Abreu Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Mauro Carvalho Chehab Cc: linux-kernel@vger.kernel.org Cc: linux-me...@vger.kernel.org --- drivers/media/platform/Kconfig | 1

Re: [RFC] [media] Add Synopsys Designware HDMI RX PHY e405 driver

2016-11-14 Thread Jose Abreu
Hi Hans, On 11-11-2016 14:52, Hans Verkuil wrote: > Hi Jose, > > On 11/09/2016 06:43 PM, Jose Abreu wrote: >> Hi All, >> >> This is a RFC patch for Synopsys Designware HDMI RX PHY e405. >> This phy receives and decodes HDMI video that is delivered to >>

[RFC v2] drm: Parse HDMI 2.0 YCbCr 4:2:0 VDB and VCB

2017-01-02 Thread Jose Abreu
#x27;able. The reason this is still a RFC is because there is no reference in kernel for this new sampling mode (specially in AVI infoframe part), so, I was hoping to hear some feedback first. Tested in a HDMI 2.0 compliance scenario. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Daniel V

Re: [PATCH v2 2/3] dmaeninge: xilinx_dma: Fix bug in multiple frame stores scenario in vdma

2017-01-02 Thread Jose Abreu
Hi Kedar, On 02-01-2017 11:46, Appana Durga Kedareswara Rao wrote: > Hi Jose Miguel Abreu, > > Thanks for the review > Sorry for the delay in the reply please see comments inline... > >> [snip] >> What if we reach here and j < num_frms? It can happen because if >> the pending l

Re: dmaengine: dw-dmac: Custom cyclic API (Why?)

2017-01-02 Thread Jose Abreu
Hi, On 02-01-2017 11:30, Andy Shevchenko wrote: > On Mon, 2017-01-02 at 15:48 +0530, Vinod Koul wrote: >> On Mon, Jan 02, 2017 at 10:38:00AM +0200, Andy Shevchenko wrote: >>> On Fri, 2016-12-30 at 12:05 +, Jose Abreu wrote: >>>> ++dw-dmac Maintainers >>

Re: [PATCH v2 2/3] dmaeninge: xilinx_dma: Fix bug in multiple frame stores scenario in vdma

2017-01-03 Thread Jose Abreu
Hi Kedar, On 02-01-2017 16:00, Appana Durga Kedareswara Rao wrote: > Hi Jose Miguel Abreu, > > Thanks for the review... > > [snip]... >> I just noticed there is a write to XILINX_DMA_REG_FRMSTORE which, by the >> description in the VDMA databook, allows to modify the total number of >> fram

Re: [PATCH v3 2/3] dmaeninge: xilinx_dma: Fix bug in multiple frame stores scenario in vdma

2017-01-04 Thread Jose Abreu
s, if you address them you can add "Reviewed-by: Jose Abreu " in next version. > --- > Changes for v3: > ---> Added Checks for frame store configuration. If frame store > Configuration is not present at the h/w level and user > Submits less frames adde

Re: [RFC] drm: Parse HDMI 2.0 YCbCr 4:2:0 VDB and VCB

2017-01-04 Thread Jose Abreu
Hi Daniel, On 04-01-2017 08:34, Daniel Vetter wrote: > On Fri, Dec 30, 2016 at 04:53:16PM +0000, Jose Abreu wrote: >> HDMI 2.0 introduces a new sampling mode called YCbCr 4:2:0. >> According to the spec the EDID may contain two blocks that >> signal this sampling mode:

Re: [RFC] drm: Parse HDMI 2.0 YCbCr 4:2:0 VDB and VCB

2017-01-04 Thread Jose Abreu
Hi Ville, On 04-01-2017 13:22, Ville Syrjälä wrote: > On Fri, Dec 30, 2016 at 04:53:16PM +0000, Jose Abreu wrote: >> HDMI 2.0 introduces a new sampling mode called YCbCr 4:2:0. >> According to the spec the EDID may contain two blocks that >> signal this sampling mode: >&g

[PATCH] ASoC: dwc: Fix PIO mode initialization

2016-12-13 Thread Jose Abreu
if the interrupt line is declared. This reflects better what is documented in the DT bindings (see Documentation/devicetree/bindings/sound/ designware-i2s.txt). Also, initialize use_pio variable which was never being set causing PIO mode to never work. Signed-off-by: Jose Abreu Cc: Carlos

Re: [PATCH v2 2/3] dmaeninge: xilinx_dma: Fix bug in multiple frame stores scenario in vdma

2016-12-23 Thread Jose Abreu
gt; Fixed race conditions in the driver as suggested by Jose Abreu > ---> Fixed unnecessray if else checks in the vdma_start_transfer > as suggested by Laurent Pinchart. > > drivers/dma/xilinx/xilinx_dma.c | 54 > +++-- > 1 file changed, 31 ins

[PATCH 2/2] ASoC: dwc: Enable 24 bit sample size in PIO mode

2016-12-27 Thread Jose Abreu
Sample size of 24 bits use in reality 32 bits for storage. We can safelly enable this sample size and treat the data as 32 bits. Tested in a x86_64 platform and in ARC AXS101 SDP platform. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Liam Girdwood Cc: Mark Brown Cc: Jaroslav Kysela Cc

[PATCH 1/2] ASoC: dwc: Add record capability in PIO mode

2016-12-27 Thread Jose Abreu
platform and in ARC AXS101 SDP platform. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Liam Girdwood Cc: Mark Brown Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: alsa-de...@alsa-project.org Cc: linux-kernel@vger.kernel.org --- sound/soc/dwc/designware_i2s.c | 9 +++- sound/soc/dwc/designware_pcm.c

dmaengine: dw-dmac: Custom cyclic API (Why?)

2016-12-30 Thread Jose Abreu
Hi All, I am going to work with dw-dmac AHB controller and I wanted to use SND_DMAENGINE_PCM. In order to use this, a standard DMA driver with cyclic support is needed. I found out that dw-dmac is capable of cyclic transfers but instead of using the DMA engine standard cyclic API it uses a custom

Re: dmaengine: dw-dmac: Custom cyclic API (Why?)

2016-12-30 Thread Jose Abreu
++dw-dmac Maintainers On 30-12-2016 11:32, Jose Abreu wrote: > Hi All, > > > I am going to work with dw-dmac AHB controller and I wanted to > use SND_DMAENGINE_PCM. In order to use this, a standard DMA > driver with cyclic support is needed. I found out that dw-dmac is &

[RFC] drm: Parse HDMI 2.0 YCbCr 4:2:0 VDB and VCB

2016-12-30 Thread Jose Abreu
#x27;able. The reason this is still a RFC is because there is no reference in kernel for this new sampling mode (specially in AVI infoframe part), so, I was hoping to hear some feedback first. Tested in a HDMI 2.0 compliance scenario. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Daniel V

[PATCH] dmaengine: xilinx_dma: Add support for multiple buffers

2016-12-15 Thread Jose Abreu
gment in a timelly manner then VDMA will write to position 0 of system mem in the following VSYNC. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Vinod Koul Cc: Dan Williams Cc: Kedareswara rao Appana Cc: Laurent Pinchart Cc: dmaeng...@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.o

Re: [PATCH] dmaengine: xilinx_dma: Add support for multiple buffers

2016-12-15 Thread Jose Abreu
Hi Kedar, On 15-12-2016 15:19, Appana Durga Kedareswara Rao wrote: > Hi Jose Abreu, > > Thanks for the patch... > >> Xilinx VDMA supports multiple framebuffers. This patch adds correct handling >> for >> the scenario where multiple framebuffers are available

Re: [PATCH 1/3] dmaengine: xilinx_dma: Check for channel idle state before submitting dma descriptor

2016-12-15 Thread Jose Abreu
;has_sg; > chan->desc_pendingcount = 0x0; > chan->ext_addr = xdev->ext_addr; > + chan->idle = true; > > spin_lock_init(&chan->lock); > INIT_LIST_HEAD(&chan->pending_list); I think there is missing a set to true in idle when a channel reset is performed. Otherwise: Reviewed-by: Jose Abreu Best regards, Jose Miguel Abreu

Re: [PATCH 2/3] dmaeninge: xilinx_dma: Fix bug in multiple frame stores scenario in vdma

2016-12-15 Thread Jose Abreu
Hi Kedar, On 15-12-2016 15:11, Kedareswara rao Appana wrote: > When VDMA is configured for more than one frame in the h/w > for example h/w is configured for n number of frames and user > Submits n number of frames and triggered the DMA using issue_pending API. > In the current driver flow we are

Re: [PATCH 2/3] dmaeninge: xilinx_dma: Fix bug in multiple frame stores scenario in vdma

2016-12-16 Thread Jose Abreu
Hi Kedar, On 15-12-2016 19:09, Appana Durga Kedareswara Rao wrote: > Hi Jose Miguel Abreu, > > Thanks for the review > >>> - last = segment; >>> + for (j = 0; j < chan->num_frms; ) { >>> + list_for_each_entry(segment, &desc->segments, node)

[PATCH] clk/axs10x: Clear init field in driver probe

2016-12-12 Thread Jose Abreu
Init field must be cleared in driver probe as this structure is not dinamically allocated. If not, wrong flags can be passed to core. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Stephen Boyd Cc: Michael Turquette Cc: linux-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org

Re: [PATCH v4 1/6] drm: bridge: dw-hdmi: Extract PHY interrupt setup to a function

2017-03-22 Thread Jose Abreu
-by: Laurent Pinchart > Signed-off-by: Neil Armstrong Reviewed-by: Jose Abreu Maybe if you submit a next version we could get rid of "dw_hdmi_fb_registered" totally and move the remaining setup code to a new "dw_hdmi_setup_i2c" function. Best regards, Jose Miguel Abreu > -

Re: [PATCH v4 2/6] media: uapi: Add RGB and YUV bus formats for Synopsys HDMI TX Controller

2017-03-22 Thread Jose Abreu
> > Reviewed-by: Archit Taneja > Signed-off-by: Neil Armstrong Reviewed-by: Jose Abreu Best regards, Jose Miguel Abreu > --- > include/uapi/linux/media-bus-format.h | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/include/uapi/lin

Re: [PATCH v4 4/6] drm: bridge: dw-hdmi: Switch to V4L bus format and encodings

2017-03-22 Thread Jose Abreu
test this on your platform which has non RGB in input and the CSC worked correctly, right? Reviewed-by: Jose Abreu Best regards, Jose Miguel Abreu > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 326 > +- > include/drm/bridge/dw_hdmi.h |

Re: [PATCH] drm: bridge: dw-hdmi: add HDMI vendor specific infoframe config

2017-03-20 Thread Jose Abreu
Hi Nickey, On 20-03-2017 06:10, Nickey Yang wrote: > Vendor specific infoframe is mandatory for 4K2K resolution. > Without this, the HDMI protocol compliance fails. > > Signed-off-by: Nickey Yang > --- > drivers/gpu/drm/bridge/dw-hdmi.c | 50 > > driver

Re: [PATCH v2] drm/bridge: dw_hdmi: support i2c extended read mode

2017-03-20 Thread Jose Abreu
ort "I2C Master Interface > Extended Read Mode" to read data addressed by non-zero segment > pointer, this means that if EDID has more than 1 extension blocks" > > With this patch,dw-hdmi can read EDID data with 1/2/4 blocks. > > Signed-off-by: Nickey Yang

Re: [PATCH v2] drm: bridge: dw-hdmi: add HDMI vendor specific infoframe config

2017-03-20 Thread Jose Abreu
Hi Nickey, On 20-03-2017 11:39, Nickey Yang wrote: > Vendor specific infoframe is mandatory for 4K2K resolution. > Without this, the HDMI protocol compliance fails. > > Signed-off-by: Nickey Yang Reviewed-by: Jose Abreu Best regards, Jose Miguel Abreu > --- > drivers

Re: [PATCH 1/2] arc: axs10x: Add DT bindings for I2S audio playback

2017-03-20 Thread Jose Abreu
Hi Vineet, Alexey, Rob, On 02-03-2017 18:57, Alexey Brodkin wrote: > Hi Jose, > > On Wed, 2017-02-22 at 18:19 +0000, Jose Abreu wrote: >> This patch adds the necessary DT bindings to get HDMI audio >> output in ARC AXS10x SDP. The bindings for I2S controller were >> ad

[PATCH 3/3] [media] cobalt: Use v4l2_calc_timeperframe helper

2017-03-21 Thread Jose Abreu
Currently, cobalt driver always returns 60fps in g_parm. This patch uses the new v4l2_calc_timeperframe helper to calculate the time per frame value. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Mauro Carvalho Chehab Cc: Hans Verkuil Cc: linux-me...@vger.kernel.org Cc: linux-kernel

[PATCH 0/3] Handling of reduced FPS in V4L2

2017-03-21 Thread Jose Abreu
se Miguel Abreu Cc: Carlos Palminha Cc: Mauro Carvalho Chehab Cc: Hans Verkuil Cc: linux-me...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Jose Abreu (3): [media] videodev2.h: Add new DV flag CAN_DETECT_REDUCED_FPS [media] v4l2-dv-timings: Introduce v4l2_calc_timeperframe helper [m

[PATCH 1/3] [media] videodev2.h: Add new DV flag CAN_DETECT_REDUCED_FPS

2017-03-21 Thread Jose Abreu
Add a new flag to UAPI for DV timings which, whenever set, indicates that hardware can detect the difference between regular FPS and 1000/1001 FPS. This is specific to HDMI receivers. Also, it is only valid when V4L2_DV_FL_CAN_REDUCE_FPS is set. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc

[PATCH 2/3] [media] v4l2-dv-timings: Introduce v4l2_calc_timeperframe helper

2017-03-21 Thread Jose Abreu
/vertical values. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Mauro Carvalho Chehab Cc: Hans Verkuil Cc: linux-me...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/media/v4l2-core/v4l2-dv-timings.c | 39 +++ include/media/v4l2-dv-timings.h

Re: [PATCH 0/3] Handling of reduced FPS in V4L2

2017-03-24 Thread Jose Abreu
Hi Hans, On 21-03-2017 11:49, Jose Abreu wrote: > Hi all, > > This is a follow up patch from this discussion [1]. It should be > seen more as a starting point to introduce better handling of > time per frame in v4l2. Quoting Hans Verkuil from [1]: >

Re: [PATCH 0/3] Handling of reduced FPS in V4L2

2017-03-24 Thread Jose Abreu
Hi Hans, >> Can you please review this series, when possible? And if you >> could test it on cobalt it would be great :) > Hopefully next week. Thanks :) > Did you have some real-world numbers w.r.t. measured > pixelclock frequencies and 60 vs 59.94 Hz and 24 vs 23.976 Hz? I did make some mea

Re: [PATCH 0/3] Handling of reduced FPS in V4L2

2017-03-24 Thread Jose Abreu
Hi Hans, On 24-03-2017 12:12, Hans Verkuil wrote: > On 03/24/17 12:52, Jose Abreu wrote: >> Hi Hans, >> >> >>>> Can you please review this series, when possible? And if you >>>> could test it on cobalt it would be great :) >>> Hopefully

[PATCH 1/8] [media] cec: Add cec_get_drvdata()

2017-03-24 Thread Jose Abreu
Add a helper function to get driver private data from CEC adapter. This helps the readability a little bit and allows to change the 'priv' field name to something else without needing to touch all drivers. Signed-off-by: Jose Abreu Cc: Hans Verkuil --- include/media/cec.h | 5 +++

[PATCH 2/8] [media] staging: st-cec: Use cec_get_drvdata()

2017-03-24 Thread Jose Abreu
Use helper function to get driver private data from CEC adapter. Signed-off-by: Jose Abreu Cc: Benjamin Gaignard --- drivers/staging/media/st-cec/stih-cec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/st-cec/stih-cec.c b/drivers/staging

[PATCH 0/8] Add cec_get_drvdata()

2017-03-24 Thread Jose Abreu
Hi, This series introduces a new helper function called cec_get_drvdata() which returns the adapter private data and can be used by drivers that use CEC. Best regards, Jose Miguel Abreu Jose Abreu (8): [media] cec: Add cec_get_drvdata() [media] staging: st-cec: Use cec_get_drvdata

[PATCH 7/8] [media] usb: pulse8-cec: Use cec_get_drvdata()

2017-03-24 Thread Jose Abreu
Use helper function to get driver private data from CEC adapter. Signed-off-by: Jose Abreu Cc: Hans Verkuil --- drivers/media/usb/pulse8-cec/pulse8-cec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/usb/pulse8-cec/pulse8-cec.c b/drivers/media/usb

[PATCH 3/8] [media] staging: s5p-cec: Use cec_get_drvdata()

2017-03-24 Thread Jose Abreu
Use helper function to get driver private data from CEC adapter. Signed-off-by: Jose Abreu Cc: Kamil Debski --- drivers/staging/media/s5p-cec/s5p_cec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/s5p-cec/s5p_cec.c b/drivers/staging/media/s5p

[PATCH 5/8] [media] i2c: adv7604: Use cec_get_drvdata()

2017-03-24 Thread Jose Abreu
Use helper function to get driver private data from CEC adapter. Signed-off-by: Jose Abreu Cc: Hans Verkuil --- drivers/media/i2c/adv7604.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c index d8bf435..f1fa9ce

[PATCH 4/8] [media] i2c: adv7511: Use cec_get_drvdata()

2017-03-24 Thread Jose Abreu
Use helper function to get driver private data from CEC adapter. Signed-off-by: Jose Abreu Cc: Hans Verkuil --- drivers/media/i2c/adv7511.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/adv7511.c b/drivers/media/i2c/adv7511.c index 8c9e289..ccc4786

[PATCH 8/8] [media] platform: vivid: Use cec_get_drvdata()

2017-03-24 Thread Jose Abreu
Use helper function to get driver private data from CEC adapter. Signed-off-by: Jose Abreu Cc: Hans Verkuil --- drivers/media/platform/vivid/vivid-cec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/vivid/vivid-cec.c b/drivers/media/platform

[PATCH 6/8] [media] i2c: adv7842: Use cec_get_drvdata()

2017-03-24 Thread Jose Abreu
Use helper function to get driver private data from CEC adapter. Signed-off-by: Jose Abreu Cc: Hans Verkuil --- drivers/media/i2c/adv7842.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/adv7842.c b/drivers/media/i2c/adv7842.c index 2d61f0c..303effd

Re: [PATCH 0/3] Handling of reduced FPS in V4L2

2017-03-27 Thread Jose Abreu
Hi Hans, On 24-03-2017 12:28, Hans Verkuil wrote: > On 03/24/17 13:21, Jose Abreu wrote: >> Hi Hans, >> >> >> On 24-03-2017 12:12, Hans Verkuil wrote: >>> On 03/24/17 12:52, Jose Abreu wrote: >>>> Hi Hans, >>>> >>>> >>

[PATCH] [media] v4l2-dv-timings: Introduce v4l2_calc_fps()

2017-03-07 Thread Jose Abreu
n the pixel clock value. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Mauro Carvalho Chehab Cc: Hans Verkuil Cc: Charles-Antoine Couret Cc: linux-me...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/media/v4l2-core/v4l2-dv-timings.c | 29 + include/

Re: [PATCH v3 1/6] drm: bridge: dw-hdmi: Extract PHY interrupt setup to a function

2017-03-07 Thread Jose Abreu
Hi Neil, On 07-03-2017 16:42, Neil Armstrong wrote: > From: Laurent Pinchart > > In preparation for adding PHY operations to handle RX SENSE and HPD, > group all the PHY interrupt setup code in a single location and extract > it to a separate function. > > Signed-off-by: Laurent Pinchart > Sign

Re: [PATCH v3 6/6] drm: bridge: dw-hdmi: Move HPD handling to PHY operations

2017-03-07 Thread Jose Abreu
gned-off-by: Neil Armstrong Looks nice! Reviewed-by: Jose Abreu Best regards, Jose Miguel Abreu > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 135 > ++ > include/drm/bridge/dw_hdmi.h | 5 ++ > 2 files changed, 86 insertions(+), 54 deleti

Re: [PATCH v3 4/6] drm: bridge: dw-hdmi: Switch to V4L bus format and encodings

2017-03-07 Thread Jose Abreu
Hi Neil, On 07-03-2017 16:42, Neil Armstrong wrote: > Some display pipelines can only provide non-RBG input pixels to the HDMI TX > Controller, this patch takes the pixel format from the plat_data if provided. > > Signed-off-by: Neil Armstrong > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c |

Re: [PATCH RESEND] drm: dw_hdmi: Don't rely on the status of the bridge for updating HPD

2017-03-09 Thread Jose Abreu
Hi Romain, On 08-03-2017 08:15, Romain Perier wrote: > Currently, the irq handler that monitores changes for HPD anx RX_SENSE > relies on the status of the bridge for updating the status of the HPD. > The update is done only when the bridge is enabled. > > However, on Rockchip platforms we have f

Re: [PATCH v3 4/6] drm: bridge: dw-hdmi: Switch to V4L bus format and encodings

2017-03-09 Thread Jose Abreu
Hi Neil, On 08-03-2017 12:12, Neil Armstrong wrote: > > Hi Jose, > > It seems here that we only have the RGB444<->YUV444 8bit tables, from the > Amlogic > source I have the following for 10bit, 12bit and 16bit for itu601 : > > static const u16 csc_coeff_rgb_out_eitu601_10b[3][4] = { > { 0x

Re: [PATCH] [media] v4l2-dv-timings: Introduce v4l2_calc_fps()

2017-03-09 Thread Jose Abreu
Hi Hans, Thanks for the review! On 09-03-2017 12:29, Hans Verkuil wrote: > On 07/03/17 17:48, Jose Abreu wrote: >> HDMI Receivers receive video modes which, according to >> CEA specification, can have different frames per second >> (fps) values. >> >> This patc

Re: [PATCH v3 4/6] drm: bridge: dw-hdmi: Switch to V4L bus format and encodings

2017-03-13 Thread Jose Abreu
Hi Neil, On 09-03-2017 14:27, Jose Abreu wrote: > Hi Neil, > > > On 08-03-2017 12:12, Neil Armstrong wrote: >> Hi Jose, >> >> It seems here that we only have the RGB444<->YUV444 8bit tables, from the >> Amlogic >> source I have the following for

Re: [PATCH] drm: dw_hdmi: Gate audio sampler clock from the enablement functions

2017-03-13 Thread Jose Abreu
Hi, On 13-03-2017 09:36, Russell King - ARM Linux wrote: > On Mon, Mar 13, 2017 at 10:27:08AM +0100, Neil Armstrong wrote: >> On 03/10/2017 10:35 AM, Romain Perier wrote: >>> Currently, the audio sampler clock is enabled from dw_hdmi_setup() at >>> step E. and is kept enabled for later use. This

Re: [PATCH] drm: dw_hdmi: Gate audio sampler clock from the enablement functions

2017-03-13 Thread Jose Abreu
Hi Russell, On 13-03-2017 13:10, Russell King - ARM Linux wrote: > On Mon, Mar 13, 2017 at 12:55:58PM +0000, Jose Abreu wrote: >> Hi, >> >> >> On 13-03-2017 09:36, Russell King - ARM Linux wrote: >>> On Mon, Mar 13, 2017 at 10:27:08AM +0100, Neil Armstron

Re: [PATCH] [media] v4l2-dv-timings: Introduce v4l2_calc_fps()

2017-03-13 Thread Jose Abreu
Hi Hans, On 09-03-2017 15:40, Hans Verkuil wrote: > On 09/03/17 16:15, Jose Abreu wrote: >> Hi Hans, >> >> >> Thanks for the review! >> >> >> On 09-03-2017 12:29, Hans Verkuil wrote: >>> On 07/03/17 17:48, Jose Abreu wrote: >>>&g

Re: [PATCH] [media] v4l2-dv-timings: Introduce v4l2_calc_fps()

2017-03-14 Thread Jose Abreu
Hi Hans, On 14-03-2017 07:24, Hans Verkuil wrote: >> Right, I was forgetting about this ... >> >> So: >> 1) Most of HDMI receivers do not have the expected precision in >> measuring pixel clock value; > s/Most/Some/ > > Newer HDMI receivers tend to have better precision. > > However, the 1000/100

Re: [PATCH v2 2/2] drm: bridge: Move HPD handling to PHY operations

2017-03-03 Thread Jose Abreu
Hi Neil, On 03-03-2017 09:07, Neil Armstrong wrote: > > The problem is that the HPD/RxSense is tied to this phy_mask and glued into > the > dw-hdmi driver. > > The *real* solution would be to completely separate the HPD/RxSense irq > handling to > a separate driver as a shared irq... > > If Jos

Re: [PATCH v2 1/2] drm: bridge: dw-hdmi: Take input format from plat_data

2017-03-03 Thread Jose Abreu
Hi Neil, On 03-03-2017 11:31, Neil Armstrong wrote: > > Sure, but I was struggling about finding an equivalence. > > How should I replace these ? > > DW_HDMI_ENC_FMT_RGB > DW_HDMI_ENC_FMT_YCBCR444 > DW_HDMI_ENC_FMT_YCBCR422_16BITS > DW_HDMI_ENC_FMT_YCBCR422_8BITS > DW_HDMI_ENC_FMT_XVYCC444 > > I

Re: [PATCH v2 1/2] drm: bridge: dw-hdmi: Take input format from plat_data

2017-03-03 Thread Jose Abreu
Hi Neil, On 03-03-2017 16:42, Neil Armstrong wrote: > > Sure, I was meaning the *input* format the controller receives from the > pixel encoder, I'm quite sure the format is strict. > Hmm, not quite following you here. As far as the controller goes it supports the formats I mentioned: -8

Re: [PATCH] drm/arcpgu: use .mode_fixup instead of .atomic_check

2017-03-03 Thread Jose Abreu
Hi Alexey, On 03-03-2017 13:27, Alexey Brodkin wrote: > > So if I understood you correct here what I really need is just to get rid of > existing check, > right? I.e. the following is to be in v2 respin: > --->8--- > diff --git a/drivers/gp

Re: [PATCH] drm/arcpgu: use .mode_fixup instead of .atomic_check

2017-03-06 Thread Jose Abreu
Hi Alexey, On 03-03-2017 19:24, Alexey Brodkin wrote: > > Correct. Otherwise we'll get some modes and devices that > don't work. > > Remember our saga with 74.25 vs 74.40 MHz? > > With our PLLs on AXS and HSDK boards we may generate 74.25 MHz clock > which satisfy some monitors especially those w

Re: [PATCH v2 1/2] drm: bridge: dw-hdmi: Take input format from plat_data

2017-03-06 Thread Jose Abreu
Hi Neil, On 06-03-2017 10:41, Neil Armstrong wrote: > On 03/03/2017 06:22 PM, Jose Abreu wrote: >> Hi Neil, >> >> >> On 03-03-2017 16:42, Neil Armstrong wrote: >>> Sure, I was meaning the *input* format the controller receives from the >>> pixel

Re: DRM DMA Engine

2016-06-16 Thread Jose Abreu
Hi Daniel, Sorry to bother you again. I promise this is the last time :) On 15-06-2016 11:15, Daniel Vetter wrote: > On Wed, Jun 15, 2016 at 11:48 AM, Jose Abreu wrote: >> On 15-06-2016 09:52, Daniel Vetter wrote: >>> On Tue, Jun 14, 2016 at 1:19 PM, Jose Abreu wrote: &

Re: [PATCH] drm: bridge: dw-hdmi: support i2c extended read mode

2017-02-22 Thread Jose Abreu
Hi Nickey, On 22-02-2017 07:45, Nickey Yang wrote: > "I2C Master Interface Extended Read Mode" implements a segment > pointer-based read operation using the Special Register configuration. > > This patch fix > https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.kernel.org_patch_709810

[PATCH 2/2] arc: axs10x: Fix ARC PGU default clock frequency

2017-02-22 Thread Jose Abreu
Default clock frequency for ARC PGU does not match any existing HDMI mode, instead the default value matches a DVI mode. Change the clock frequency to 74.25MHz so that it matches HDMI mode 1280x720@60Hz Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Alexey Brodkin Cc: Rob Herring Cc

[PATCH 1/2] arc: axs10x: Add DT bindings for I2S audio playback

2017-02-22 Thread Jose Abreu
This patch adds the necessary DT bindings to get HDMI audio output in ARC AXS10x SDP. The bindings for I2S controller were added as well as the bindings for simple audio card. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Alexey Brodkin Cc: Rob Herring Cc: Vineet Gupta Cc: devicet

Re: [RFC] drm: Parse HDMI 2.0 YCbCr 4:2:0 VDB and VCB

2017-01-11 Thread Jose Abreu
Hi Ville, On 10-01-2017 17:21, Ville Syrjälä wrote: [snip] >> But we already have color_formats field in drm_display_info >> struct, right? Shouldn't we instead create for example a helper >> which returns the best output colorspace? According to what you >> said it would be something like: >>

[PATCH] drm: edid: HDMI 2.0 HF-VSDB block parsing

2016-08-10 Thread Jose Abreu
Adds parsing for HDMI 2.0 'HDMI Forum Vendor Specific Data Block'. This block is present in some HDMI 2.0 EDID's and gives information about scrambling support, SCDC, 3D Views, and others. Parsed parameters are stored in drm_connector structure. Signed-off-by: Jose Abreu Cc: Carl

[PATCH 0/3 v3] drm: bridge/dw-hdmi: Fixes for dw-hdmi and DWC support

2016-08-04 Thread Jose Abreu
dri-de...@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org Jose Abreu (3): drm: bridge/dw-hdmi: Add support for DWC Phy drm: bridge/dw-hdmi: Enable ISCR1, ISCR2 and ACP packets drm: bridge/dw-hdmi: Move edid reading to .detect() callback drivers/gpu/drm/bridge/dw-hdmi.c

[PATCH 1/3 v3] drm: bridge/dw-hdmi: Add support for DWC Phy

2016-08-04 Thread Jose Abreu
validated. This is specific to Synopsys Phy. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Archit Taneja Cc: David Airlie Cc: Russell King Cc: Fabio Estevam Cc: Daniel Vetter Cc: Takashi Iwai Cc: Vladimir Zapolskiy Cc: Thierry Reding Cc: dri-de...@lists.freedesktop.org Cc: linux-kernel

[PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to .detect() callback

2016-08-04 Thread Jose Abreu
When running HDMI compliance tests we noticed that sometimes the edid changes but the get_modes() function is not called so the edid is not updated. Moving the edid reading to the detect() callback ensures that the edid is correctly updated after an hotplug. Signed-off-by: Jose Abreu Cc: Carlos

[PATCH 2/3 v3] drm: bridge/dw-hdmi: Enable ISCR1, ISCR2 and ACP packets

2016-08-04 Thread Jose Abreu
Currently ISCR and ACP packets are not being sent causing HDMI compliance tests like CTS 7-19 HDMI 1.4b to fail. With this pacth the mentioned packets are activated when needed. Verified using HDMI compliance equipment. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Archit Taneja Cc

Re: [PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to .detect() callback

2016-08-04 Thread Jose Abreu
Hi Russell, On 04-08-2016 11:47, Russell King - ARM Linux wrote: > On Thu, Aug 04, 2016 at 11:44:51AM +0100, Jose Abreu wrote: >> When running HDMI compliance tests we noticed that sometimes >> the edid changes but the get_modes() function is not called >> so the edid is no

[PATCH RESEND] drm: bridge/dw-hdmi: Fix colorspace and scan information registers values

2016-08-29 Thread Jose Abreu
Colorspace and scan information values were being written in wrong offsets. This patch corrects this and writes the values at the offsets specified in the databook. Signed-off-by: Jose Abreu Acked-by: Russel King Cc: Carlos Palminha Cc: Archit Taneja Cc: David Airlie Cc: Russell King Cc

Re: [PATCH RESEND] drm: bridge/dw-hdmi: Fix colorspace and scan information registers values

2016-08-29 Thread Jose Abreu
On 29-08-2016 10:21, Russell King - ARM Linux wrote: > On Mon, Aug 29, 2016 at 10:17:04AM +0100, Jose Abreu wrote: >> Colorspace and scan information values were being written in wrong >> offsets. This patch corrects this and writes the values at the >> offsets spec

[PATCH] drm: bridge/dw-hdmi: Fix colorspace and scan information registers values

2016-08-18 Thread Jose Abreu
Colorspace and scan information values were being written in wrong offsets. This patch corrects this and writes the values at the offsets specified in the databook. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: David Airlie Cc: Russell King Cc: Daniel Vetter Cc: dri-de

[PATCH] drm: bridge/dw-hdmi: Add support for DWC Phy

2016-06-13 Thread Jose Abreu
This patch adds support for the Synopsys HDMI TX Phy in bridge dw-hdmi. The init flow is the same as the Rockchip Phy so we only need to add one define and one if statement. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: David Airlie Cc: dri-de...@lists.freedesktop.org Cc: linux-kernel

[PATCH v2] drm: bridge/dw-hdmi: Add support for DWC Phy

2016-06-28 Thread Jose Abreu
know if this is specific to Synopsys Phy we only set this if Phy type is DWC_HDMI. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: David Airlie Cc: Russell King Cc: Fabio Estevam Cc: Daniel Vetter Cc: Takashi Iwai Cc: Vladimir Zapolskiy Cc: Thierry Reding Cc: dri-de...@lists.freedeskto

[PATCH 0/3 v2] Add I2S/ADV7511 audio support for ARC AXS10x boards

2016-03-28 Thread Jose Abreu
to separate patch (as suggested by Alexey Brodkin) * Removed defconfigs entries (as suggested by Alexey Brodkin) Jose Abreu (3): drm/i2c/adv7511: Add audio support ASoC: dwc: Add I2S HDMI audio support arc: axs10x: Add support for Designware I2S on DT arch/arc/boot/dts/axs10x_mb.dtsi|

[PATCH 2/3 v2] ASoC: dwc: Add I2S HDMI audio support

2016-03-28 Thread Jose Abreu
HDMI audio support was added to the AXS board using an I2S cpu driver and a custom platform driver. The platform driver supports two channels @ 16 bits with rates 32k, 44.1k and 48k. ALSA Simple audio card is used to glue the cpu, platform and codec driver (adv7511). Signed-off-by: Jose Abreu

[PATCH 1/3 v2] drm/i2c/adv7511: Add audio support

2016-03-28 Thread Jose Abreu
ode is automatically started at boot and the audio (when enabled) registers as a codec into ALSA. SPDIF DAI format was also added to ASoC as it is required by adv7511 audio. Signed-off-by: Jose Abreu --- No changes v1 -> v2. drivers/gpu/drm/i2c/Kconfig | 11 + drivers/gpu/drm/i2c

[PATCH 3/3 v2] arc: axs10x: Add support for Designware I2S on DT

2016-03-28 Thread Jose Abreu
Synopsys Designware ARC SDP boards support HDMI audio output using the ADV7511 HDMI transmitter. This patchs enables audio output using Designware I2S driver, ALSA SoC simple audio card and ADV7511 codec. Signed-off-by: Jose Abreu --- Changes v1 -> v2: * This change was introduced in

Re: [PATCH 2/3 v2] ASoC: dwc: Add I2S HDMI audio support

2016-03-28 Thread Jose Abreu
Hi Alexey, On 28-03-2016 16:35, Alexey Brodkin wrote: > Hi Jose, > > On Mon, 2016-03-28 at 15:36 +0100, Jose Abreu wrote: >> HDMI audio support was added to the AXS board using an >> I2S cpu driver and a custom platform driver. >> >> The platform driver sup

Re: [PATCH 1/3 v2] drm/i2c/adv7511: Add audio support

2016-03-29 Thread Jose Abreu
Hi Archit, On 29-03-2016 09:05, Archit Taneja wrote: > Hi, > > On 03/28/2016 08:06 PM, Jose Abreu wrote: >> This patch adds audio support for the ADV7511 HDMI transmitter >> using ALSA SoC. >> >> The code was ported from Analog Devices linux tree from >

RE: [EXT] [PATCH v2 1/5] scsi: ufs: Allow UFS 3.0 as a valid version

2020-06-12 Thread Jose Abreu
From: Alim Akhtar Date: Jun/10/2020, 04:39:48 (UTC+00:00) > Are you still on this? Yes, apologies but I was caught on some other things. I'll try to re-submit once possible. --- Thanks, Jose Miguel Abreu

RE: linux-next: Tree for Oct 15 (drivers/net/pcs/pcs-xpcs.o)

2020-10-15 Thread Jose Abreu
From: Randy Dunlap Date: Oct/15/2020, 15:45:57 (UTC+00:00) > On 10/15/20 12:28 AM, Stephen Rothwell wrote: > > Hi all, > > > > Since the merge window is open, please do not add any v5.11 material to > > your linux-next included branches until after v5.10-rc1 has been released. > > > > News: the

RE: [PATCH net-next v6 0/5] net: stmmac: enable EHL SGMII

2019-06-04 Thread Jose Abreu
t; 5. Hash Filter MC 0 > 6. Perfect Filter UC0 > 7. MC Filter0 > 8. UC Filter0 > 9. Flow Control 0 Thanks for testing and addressing all review comments! Acked-by: Jose Abreu Thanks, Jose Miguel Abreu

RE: [PATCH net-next v6 2/5] net: stmmac: introducing support for DWC xPCS logics

2019-06-05 Thread Jose Abreu
From: Florian Fainelli > +Russell, > > On 6/4/2019 11:58 AM, Voon Weifeng wrote: > > From: Ong Boon Leong > > > > xPCS is DWC Ethernet Physical Coding Sublayer that may be integrated > > into a GbE controller that uses DWC EQoS MAC controller. An example of > > HW configuration is shown below:

[RFC net-next 2/2] net: stmmac: Convert to phylink

2019-06-05 Thread Jose Abreu
Convert stmmac driver to phylink. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/Kconfig| 3 +- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 4 +- .../net/ethernet/stmicro

[RFC net-next 1/2] net: stmmac: Prepare to convert to phylink

2019-06-05 Thread Jose Abreu
In preparation for the convertion, split the adjust_link function into mac_config and add the mac_link_up and mac_link_down functions. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac

[RFC net-next 0/2] net: stmmac: Convert to phylink

2019-06-05 Thread Jose Abreu
For review and testing only. This converts stmmac to use phylink. Besides the code redution this will allow to gain more flexibility. Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Jose Abreu (2): net: stmmac: Prepare to convert to phylink net: stmmac

RE: [v4, PATCH] net: stmmac: add support for hash table size 128/256 in dwmac4

2019-05-29 Thread Jose Abreu
From: Biao Huang Date: Wed, May 29, 2019 at 02:38:44 > } else if (!netdev_mc_empty(dev)) { > - u32 mc_filter[2]; > + u32 mc_filter[8]; > struct netdev_hw_addr *ha; The reverse christmas tree also applies here. I also see some coding-style errors, like

RE: [PATCH net-next v3 0/5] net: stmmac: enable EHL SGMII

2019-05-29 Thread Jose Abreu
From: Voon Weifeng Date: Wed, May 29, 2019 at 11:18:33 > This patch-set is to enable Ethernet controller > (DW Ethernet QoS and DW Ethernet PCS) with SGMII interface in Elkhart Lake. > The DW Ethernet PCS is the Physical Coding Sublayer that is between Ethernet > MAC and PHY and uses MDIO Clause-

[PATCH net-next 2/2] net: stmmac: selftests: Use kfree_skb() instead of kfree()

2019-05-29 Thread Jose Abreu
kfree_skb() shall be used instead of kfree(). Fix it. Fixes: 091810dbded9 ("net: stmmac: Introduce selftests support") Reported-by: kbuild test robot Reported-by: Dan Carpenter Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexan

[PATCH net-next 0/2] net: stmmac: selftests: Two fixes

2019-05-29 Thread Jose Abreu
Two fixes reported by kbuild. Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Jose Abreu (2): net: stmmac: selftests: Fix sparse warning net: stmmac: selftests: Use kfree_skb() instead of kfree() drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c | 4

<    1   2   3   4   5   6   7   8   9   >