Re: DRM DMA Engine

2016-06-20 Thread Jose Abreu
Hi Ilia, Thanks for your answer. On 16-06-2016 13:39, Ilia Mirkin wrote: > On Thu, Jun 16, 2016 at 8:09 AM, Jose Abreu wrote: >> Hi Daniel, >> >> Sorry to bother you again. I promise this is the last time :) >> >> On 15-06-2016 11:15, Daniel Vetter wrote: >

Re: [PATCH 1/3] drm: bridge: add DesignWare HDMI I2S audio support

2016-07-28 Thread Jose Abreu
Hi, On 24-06-2016 03:40, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > Current dw-hdmi is supporting sound via AHB bus, but it has > I2S audio feature too. This patch adds I2S audio support to dw-hdmi. > This HDMI I2S is supported by using ALSA SoC common HDMI encoder > driver. > > Sign

Re: [PATCH 1/3] drm: bridge: add DesignWare HDMI I2S audio support

2016-08-01 Thread Jose Abreu
Thank you for your test. I'm happy if it could have it. > > Mark, Thierry, Daniel > I wonder who can be maintainer for this patch ?? > > Best regards > --- > Kuninori Morimoto Tested-by: Jose Abreu Best regards, Jose Miguel Abreu

Re: [PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to .detect() callback

2016-08-04 Thread Jose Abreu
Hi Russell, On 04-08-2016 15:31, Russell King - ARM Linux wrote: > On Thu, Aug 04, 2016 at 02:58:00PM +0100, Jose Abreu wrote: >> Hi Russell, >> >> I am not sure if this is a bug in DRM or a bad implementation of >> dw-hdmi. I've seen at least two more drivers th

Re: [PATCH 2/3 v3] drm: bridge/dw-hdmi: Enable ISCR1, ISCR2 and ACP packets

2016-08-04 Thread Jose Abreu
Hi Russell, On 04-08-2016 16:32, Russell King - ARM Linux wrote: > On Thu, Aug 04, 2016 at 11:44:50AM +0100, Jose Abreu wrote: >> Currently ISCR and ACP packets are not being sent causing >> HDMI compliance tests like CTS 7-19 HDMI 1.4b to fail. > Hmm. Reading the HDMI sp

Re: [PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to .detect() callback

2016-08-04 Thread Jose Abreu
Hi Russell, On 04-08-2016 16:04, Russell King - ARM Linux wrote: > On Thu, Aug 04, 2016 at 03:57:21PM +0100, Jose Abreu wrote: >> Hmm, I am not debugging it right now but I remember that >> drm_fb_helper_probe_connector_modes() was not being called at the >> time I set

Re: [PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to .detect() callback

2016-08-08 Thread Jose Abreu
Hi, On 05-08-2016 09:13, Chris Wilson wrote: > On Fri, Aug 05, 2016 at 10:06:08AM +0200, Daniel Vetter wrote: >> On Fri, Aug 05, 2016 at 12:01:25AM +0100, Russell King - ARM Linux wrote: >>> On Thu, Aug 04, 2016 at 06:13:18PM +0100, Jose Abreu wrote: >>>> Hi Russe

Re: [PATCH v3 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX

2017-06-20 Thread Jose Abreu
Hi Sylwester, On 19-06-2017 22:18, Sylwester Nawrocki wrote: > On 06/19/2017 11:01 AM, Jose Abreu wrote: >> Using fixed-clock was already in my todo list. Regarding phy I >> need to pass pdata so that the callbacks between controller and >> phy are established. I also need

Re: [PATCH v3 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

2017-06-20 Thread Jose Abreu
HI Sylwester, On 19-06-2017 23:10, Sylwester Nawrocki wrote: > On 06/19/2017 11:33 AM, Jose Abreu wrote: >> On 18-06-2017 19:04, Sylwester Nawrocki wrote: >>> On 06/16/2017 06:38 PM, Jose Abreu wrote: >>>> This is an initial submission for the Synopsys Designware

[PATCH v4 3/4] MAINTAINERS: Add entry for Synopsys Designware HDMI drivers

2017-06-20 Thread Jose Abreu
Add a entry for Synopsys Designware HDMI Receivers drivers and phys. Signed-off-by: Jose Abreu Cc: Carlos Palminha --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c4be6d4..7ebc6dd 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11354,6

[PATCH v4 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX

2017-06-20 Thread Jose Abreu
Document the bindings for the Synopsys Designware HDMI RX. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Rob Herring Cc: Mark Rutland Cc: Mauro Carvalho Chehab Cc: Hans Verkuil Cc: Sylwester Nawrocki Changes from v3: - Document the new DT bindings suggested by Sylwester

[PATCH v4 0/4] Synopsys Designware HDMI Video Capture Controller + PHY

2017-06-20 Thread Jose Abreu
tform. Jose Abreu (4): [media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver [media] platform: Add Synopsys Designware HDMI RX Controller Driver MAINTAINERS: Add entry for Synopsys Designware HDMI drivers dt-bindings: media: Document Synopsys Designware HDMI RX Cc: Carlos Palminh

[PATCH v4 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

2017-06-20 Thread Jose Abreu
some sources might not be very stable at sending the video (i.e. we must react accordingly). Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Mauro Carvalho Chehab Cc: Hans Verkuil Cc: Sylwester Nawrocki Changes from v3: - Use v4l2 async API (Sylwester) - D

[PATCH v4 1/4] [media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver

2017-06-20 Thread Jose Abreu
. configuration functions) and the controller must provide read/write callbacks, as well as other specific functions. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Mauro Carvalho Chehab Cc: Hans Verkuil Cc: Sylwester Nawrocki Changes from v3: - Use v4l2 async API (Sylwester) - Use

Re: [PATCH v5 05/10] drm: arcpgu: Use crtc->mode_valid() callback

2017-06-21 Thread Jose Abreu
Hi Daniel, Alexey, On 25-05-2017 15:19, Jose Abreu wrote: > Now that we have a callback to check if crtc supports a given mode > we can use it in arcpgu so that we restrict the number of probbed > modes to the ones we can actually display. > > This is specially useful because

[PATCH net-next 0/2] net: stmmac: Support DWMAC5 and TSN

2017-10-25 Thread Jose Abreu
Hi, This adds support for a new IP version (5) of dwmac and for TSN features as defined by IEEE802.1Qbv-2015 and IEEE802.1Qbu. Please review. Best regards, Jose Miguel Abreu Jose Abreu (2): net: stmmac: Add support for DWMAC5 with TSN features bindings: net: stmmac: Add documentation for

[PATCH net-next 1/2] net: stmmac: Add support for DWMAC5 with TSN features

2017-10-25 Thread Jose Abreu
transmission in this time window/slot. FPE: The IEEE802.1Qbu defines a mechanism which breaks interfering frames into smaller fragments shuch that we have a more efficient use of network bandwidth. This needs EST enabled. Signed-off-by: Jose Abreu Cc: David S. Miller Cc: Joao Pinto Cc: Giuseppe

[PATCH net-next 2/2] bindings: net: stmmac: Add documentation for TSN parameters

2017-10-25 Thread Jose Abreu
This adds the documentation for TSN feature EST and FP. Signed-off-by: Jose Abreu Cc: David S. Miller Cc: Joao Pinto Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Rob Herring --- Documentation/devicetree/bindings/net/stmmac.txt | 20 1 file changed, 20 insertions

Re: [PATCH net-next 2/2] bindings: net: stmmac: Add documentation for TSN parameters

2017-10-26 Thread Jose Abreu
Hi Florian, On 25-10-2017 20:34, Florian Fainelli wrote: > On 10/25/2017 07:04 AM, Jose Abreu wrote: >> This adds the documentation for TSN feature EST and FP. >> >> Signed-off-by: Jose Abreu >> Cc: David S. Miller >> Cc: Joao Pinto >> Cc: Giuseppe Ca

[PATCH net] net: stmmac: dwc-qos-eth: Fix typo in DT bindings parsing

2017-10-26 Thread Jose Abreu
According to DT bindings documentation we are expecting a property called "snps,read-requests" but we are parsing instead a property called "read,read-requests". This is clearly a typo. Fix it. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cava

[PATCH net] net: stmmac: First Queue must always be in DCB mode

2017-10-26 Thread Jose Abreu
According to DWMAC databook the first queue operating mode must always be in DCB. As MTL_QUEUE_DCB = 1, we need to always set the first queue operating mode to DCB otherwise driver will think that queue is in AVB mode (because MTL_QUEUE_AVB = 0). Signed-off-by: Jose Abreu Cc: Joao Pinto Cc

Re: [PATCH net-next 2/2] bindings: net: stmmac: Add documentation for TSN parameters

2017-10-26 Thread Jose Abreu
Hi Andrew, On 26-10-2017 10:03, Andrew Lunn wrote: >> These parameters may also need to change in runtime depending on >> the scheduled traffic. Unfortunately, net subsystem does not yet >> support TSN so this will have to wait and for now we will use >> fixed parameters. > Hi Jose > > what you sh

Re: [PATCH net-next 2/2] bindings: net: stmmac: Add documentation for TSN parameters

2017-10-26 Thread Jose Abreu
Hi Andrew, On 26-10-2017 10:03, Andrew Lunn wrote: >> These parameters may also need to change in runtime depending on >> the scheduled traffic. Unfortunately, net subsystem does not yet >> support TSN so this will have to wait and for now we will use >> fixed parameters. > Hi Jose > > what you sh

Re: [PATCH net] net: stmmac: First Queue must always be in DCB mode

2017-10-26 Thread Jose Abreu
Hi Bhadram, On 26-10-2017 11:51, Bhadram Varka wrote: > Hi Jose, > >> -Original Message- >> From: netdev-ow...@vger.kernel.org [mailto:netdev- >> ow...@vger.kernel.org] On Behalf Of Jose Abreu >> Sent: Thursday, October 26, 2017 2:37 PM >> To:

Re: [PATCH net] net: stmmac: First Queue must always be in DCB mode

2017-10-27 Thread Jose Abreu
On 26-10-2017 15:44, Bhadram Varka wrote: > Hi Jose, > >> -Original Message----- >> From: Jose Abreu [mailto:jose.ab...@synopsys.com] >> Sent: Thursday, October 26, 2017 5:19 PM >> To: Bhadram Varka ; net...@vger.kernel.org; >> linux-kernel@vger.kernel.org

Re: [PATCH net-next 0/2] net: stmmac: Support DWMAC5 and TSN

2017-10-27 Thread Jose Abreu
Hi Jesus, On 26-10-2017 17:28, Jesus Sanchez-Palencia wrote: > Hi Jose, > > > On 10/25/2017 07:02 AM, Jose Abreu wrote: >> Hi, >> >> This adds support for a new IP version (5) of dwmac and for >> TSN features as defined by IEEE802.1Qbv-2015 and IEEE802.1Qbu

Re: [PATCH net-next 2/2] bindings: net: stmmac: Add documentation for TSN parameters

2017-10-27 Thread Jose Abreu
Hi Jesus, On 26-10-2017 17:23, Jesus Sanchez-Palencia wrote: > Hi Jose, > > > On 10/26/2017 03:08 AM, Jose Abreu wrote: >> Hi Andrew, >> >> On 26-10-2017 10:03, Andrew Lunn wrote: >>>> These parameters may also need to change in runtime depending on >

Re: [PATCH net-next 2/2] bindings: net: stmmac: Add documentation for TSN parameters

2017-10-27 Thread Jose Abreu
Hi Andrew, On 26-10-2017 22:56, Andrew Lunn wrote: >> About my patches, what I think would be better now would be to >> drop the configuration by DT and integrate the remaining >> configuration, letting the EST parameters be populated by SoC >> specific wrappers. > Hi Jose > > The problem with SoC

Re: [PATCH net-next 2/2] bindings: net: stmmac: Add documentation for TSN parameters

2017-10-27 Thread Jose Abreu
Hi Peppe, On 27-10-2017 13:29, Giuseppe CAVALLARO wrote: > Hello > > On 10/27/2017 11:05 AM, Jose Abreu wrote: >> I think we should take advantage of the fact that this is working >> and ready to be merged. Its just HW configuration but maybe it >> can serve as momentu

[PATCH v2 net-next] net: stmmac: Add support for DWMAC5 with TSN features

2017-10-27 Thread Jose Abreu
transmission in this time window/slot. FPE: The IEEE802.1Qbu defines a mechanism which breaks interfering frames into smaller fragments shuch that we have a more efficient use of network bandwidth. This needs EST enabled. Signed-off-by: Jose Abreu Cc: David S. Miller Cc: Joao Pinto Cc: Giuseppe

Re: [PATCH] Revert "net: stmmac: Do not keep rearming the coalesce timer in stmmac_xmit"

2018-08-28 Thread Jose Abreu
Hi Jerome, On 24-08-2018 10:04, Jerome Brunet wrote: > This reverts commit 4ae0169fd1b3c792b66be58995b7e6b629919ecf. > > This change in the handling of the coalesce timer is causing regression on > (at least) amlogic platforms. > > Network will break down very quickly (a few seconds) after startin

[PATCH v3 2/6] drm: Add drm_{crtc/encoder/connector}_mode_valid()

2017-05-11 Thread Jose Abreu
Add a new helper to call crtc->mode_valid, connector->mode_valid and encoder->mode_valid callbacks. Suggested-by: Ville Syrjälä Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Alexey Brodkin Cc: Ville Syrjälä Cc: Daniel Vetter Cc: Dave Airlie Cc: Andrzej Hajda Cc: Arch

[PATCH v3 1/6] drm: Add crtc/encoder/bridge->mode_valid() callbacks

2017-05-11 Thread Jose Abreu
also change the documentation so that the new and old callbacks are correctly documented. Only the callbacks were implemented to simplify review process, following patches will make use of them. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Alexey Brodkin Cc: Ville Syrjälä Cc: Daniel

[PATCH v3 0/6] Introduce new mode validation callbacks

2017-05-11 Thread Jose Abreu
g/patch/9702233/ Jose Abreu (6): drm: Add crtc/encoder/bridge->mode_valid() callbacks drm: Add drm_{crtc/encoder/connector}_mode_valid() drm: Introduce drm_bridge_mode_valid() drm: Use new mode_valid() helpers in connector probe helper drm: Use mode_valid() in atomic modeset

[PATCH v3 6/6] drm: arc: Use crtc->mode_valid() callback

2017-05-11 Thread Jose Abreu
this clock does not support all the needed ranges. Also, remove the atomic_check() callback as mode_valid() callback will be called before. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Alexey Brodkin Cc: Ville Syrjälä Cc: Daniel Vetter Cc: Dave Airlie Cc: Andrzej Hajda Cc: Archit

[PATCH v3 4/6] drm: Use new mode_valid() helpers in connector probe helper

2017-05-11 Thread Jose Abreu
ode loops through all the connector's encodersXbridgesXcrtcs and calls the callback. If at least a valid encoderXbridgeXcrtc combination is found which accepts the mode then the function returns MODE_OK. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Alexey Brodkin Cc: Ville Syrjä

[PATCH v3 3/6] drm: Introduce drm_bridge_mode_valid()

2017-05-11 Thread Jose Abreu
Introduce a new helper function which calls mode_valid() callback for all bridges in an encoder chain. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Alexey Brodkin Cc: Ville Syrjälä Cc: Daniel Vetter Cc: Dave Airlie Cc: Andrzej Hajda Cc: Archit Taneja --- drivers/gpu/drm/drm_bridge.c

[PATCH v3 5/6] drm: Use mode_valid() in atomic modeset

2017-05-11 Thread Jose Abreu
omponents. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Alexey Brodkin Cc: Ville Syrjälä Cc: Daniel Vetter Cc: Dave Airlie Cc: Andrzej Hajda Cc: Archit Taneja --- Changes v1->v2: - Removed call to connector->mode_valid (Ville, Daniel) - Change function name (Ville

Re: [PATCH v2 5/8] drm: Use new mode_valid() helpers in connector probe helper

2017-05-12 Thread Jose Abreu
Hi Laurent, On 12-05-2017 10:35, Laurent Pinchart wrote: > Hi Jose, > > Thank you for the patch. > > On Tuesday 09 May 2017 18:00:12 Jose Abreu wrote: >> This changes the connector probe helper function to use the new >> encoder->mode_valid() and crtc->

Re: [PATCH v2 8/8] drm: arc: Use crtc->mode_valid() callback

2017-05-14 Thread Jose Abreu
Hi Laurent, Sorry for the late reply. On 12-05-2017 10:57, Laurent Pinchart wrote: > Hi Jose, > > Thank you for the patch. > > On Tuesday 09 May 2017 18:00:15 Jose Abreu wrote: >> Now that we have a callback to check if crtc supports a given mode >> we can use it in

Re: [PATCH net-next] net: stmmac: remove superfluous wmb() memory barriers

2018-03-09 Thread Jose Abreu
Hi Niklas, On 08-03-2018 10:30, Niklas Cassel wrote: > These wmb() memory barriers are performed after the last descriptor write, > and they are followed by enable_dma_transmission()/set_tx_tail_ptr(), > i.e. a writel() to MMIO register space. > Since writel() itself performs the equivalent of a w

Re: [PATCH] ARC: io.h: Implement reads{x}()/writes{x}()

2018-11-29 Thread Jose Abreu
On 29-11-2018 13:03, David Laight wrote: > From: Jose Abreu [mailto:jose.ab...@synopsys.com] >> On 29-11-2018 12:47, David Laight wrote: >>> From: Jose Abreu >>>> Sent: 29 November 2018 12:42 >>>> >>>> Some ARC CPU's do not support unalig

[PATCH v2] ARC: io.h: Implement reads{x}()/writes{x}()

2018-11-29 Thread Jose Abreu
e {get/put}_unaligned() helper instead of plain dereference of pointer in order to fix this. Changes from v1: - Check if buffer is already aligned (David) - Remove 64 bit mention (Alexey) Signed-off-by: Jose Abreu Tested-by: Vitor Soares Cc: Vineet Gupta Cc: Alexey Brodkin Cc: Joao Pinto Cc: Vitor

Re: [PATCH v2] ARC: io.h: Implement reads{x}()/writes{x}()

2018-11-29 Thread Jose Abreu
On 29-11-2018 14:38, David Laight wrote: > From: Jose Abreu >> Sent: 29 November 2018 14:29 >> >> Some ARC CPU's do not support unaligned loads/stores. Currently, generic >> implementation of reads{b/w/l}()/writes{b/w/l}() is being used with ARC. >> This can

Re: [PATCH v2] ARC: io.h: Implement reads{x}()/writes{x}()

2018-11-29 Thread Jose Abreu
On 29-11-2018 14:42, Jose Abreu wrote: > On 29-11-2018 14:38, David Laight wrote: >> From: Jose Abreu >>> Sent: 29 November 2018 14:29 >>> >>> Some ARC CPU's do not support unaligned loads/stores. Currently, generic >>> implementation of rea

Re: [BUG] net: stmmac: dwmac-sun8i broken in linux-next

2018-05-17 Thread Jose Abreu
Hi Corentin, On 16-05-2018 19:32, Corentin Labbe wrote: > Hello > > The dwmac-sun8i driver is broken in next-20180515, symptom are no RX and TX > errors as shown by ifconfig: > eth0: flags=4163 mtu 1500 > inet 192.168.1.204 netmask 255.255.255.0 broadcast 192.168.1.255 > ether

Re: [PATCH] net: stmmac: Avoid VLA usage

2018-05-02 Thread Jose Abreu
;r=WHDsc6kcWAl4i96Vm5hJ_19IJiuxx_p_Rzo2g-uHDKw&m=TBD6a7UY2VbpPmV9LOW_eHAyg8uPq1ZPDhq93VROTVE&s=4fvOST1HhWmZ4lThQe-dHCJYEXNOwey00BCXOWm8tKo&e= > > Signed-off-by: Kees Cook > I rather prefer the variables declaration in reverse-tree order, but thats just a minor pick. Reviewed-by: Jose Abreu Thanks

Re: [PATCH] net: stmmac: Avoid VLA usage

2018-05-02 Thread Jose Abreu
On 02-05-2018 13:36, Kees Cook wrote: > On Wed, May 2, 2018 at 1:54 AM, Jose Abreu wrote: >> Hi Kees, >> >> On 01-05-2018 22:01, Kees Cook wrote: >>> In the quest to remove all stack VLAs from the kernel[1], this switches >>> the "status" stack

Re: [PATCH net-next v2 2/2] drivers: net: Remove device_node checks with of_mdiobus_register()

2018-05-16 Thread Jose Abreu
> drivers/net/ethernet/freescale/fec_main.c | 8 ++-- > drivers/net/ethernet/marvell/mvmdio.c | 5 + > drivers/net/ethernet/renesas/sh_eth.c | 11 +++ > drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 5 + For stmmac: Reviewed-by

Re: [PATCH] net: dwc-xlgmac: fix xlgmac_xmit()'s return type

2018-04-26 Thread Jose Abreu
On 24-04-2018 14:17, Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too. > > Signed-off-by: Luc

[PATCH net 0/2] Use C45 Helpers when possible

2019-03-01 Thread Jose Abreu
For -net. Please review! Cc: Andrew Lunn Cc: Florian Fainelli Cc: "David S. Miller" Cc: Joao Pinto Jose Abreu (2): net: phy: Use C45 Helpers in phy_read_status() net: phy: Use C45 Helpers in PHY_FORCING state drivers/net/phy/phy.c | 2 +- include/linux/phy.h | 15

[PATCH net 1/2] net: phy: Use C45 Helpers in phy_read_status()

2019-03-01 Thread Jose Abreu
Currently phy_read_status() considers that either the PHY driver has the read_status() callback or uses the generic callback. For C45 PHYs we need to use the gen10g_read_status() callback. Signed-off-by: Jose Abreu Cc: Andrew Lunn Cc: Florian Fainelli Cc: "David S. Miller" Cc:

[PATCH net 2/2] net: phy: Use C45 Helpers in PHY_FORCING state

2019-03-01 Thread Jose Abreu
When using a C45 PHY that is in PHY_FORCING state we are currently not taking into account that this kind of PHY has different update_link functions. Use the C45 Helpers instead or the driver built-in read_status() helper, if possible. Signed-off-by: Jose Abreu Cc: Andrew Lunn Cc: Florian

RE: [PATCH 0/7] net: stmmac: enable EHL SGMII

2019-04-24 Thread Jose Abreu
From: Weifeng Voon Date: Wed, Apr 24, 2019 at 18:17:14 > From: "Voon, Weifeng" > > This patch-set is to enable Ethernet controller (DW Ethernet QoS > and DW Ethernet PCS) with SGMII interface in Elkhart Lake. The > DW Ethernet PCS is the Physical Coding Sublayer that is between > Ethernet MAC a

RE: [PATCH] reset: axs10x: Implement assert and deassert callbacks

2019-04-08 Thread Jose Abreu
From: Vitor Soares Date: Mon, Apr 08, 2019 at 11:31:23 > static const struct reset_control_ops axs10x_reset_ops = { > - .reset = axs10x_reset_reset, Eugeniy, Alexey, I think the implementation of this callback is wrong: you should readl_poll_timeout_atomic() until the reset bit is not cle

Re: [PATCH 1/2 v6] ASoC: dwc: Add custom PCM driver

2016-04-29 Thread Jose Abreu
, Jose Abreu wrote: > HDMI audio support was added to the AXS board using an > I2S cpu driver and a custom platform driver. > > The platform driver supports two channels @ 16 bits with > rates 32k, 44.1k and 48k. > > Although the mainline I2S driver uses ALSA DMA engine, > this

[RESEND PATCH 0/2 v6] Add AXS10X I2S PLL clock driver

2016-05-02 Thread Jose Abreu
rquette Cc: Stephen Boyd Cc: Alexey Brodkin Cc: Vineet Gupta Cc: linux-snps-...@lists.infradead.org Cc: devicet...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: linux-...@vger.kernel.org Jose Abreu (2): clk/axs10x: Add I2S PLL clock driver arc: axs10x: Add DT bindings for I2S PLL Clock

[RESEND PATCH 1/2 v6] clk/axs10x: Add I2S PLL clock driver

2016-05-02 Thread Jose Abreu
rate. Signed-off-by: Jose Abreu --- Changes v5 -> v6: * Use parent clock to determine PLL input rate instead of using hardcoded values * Documentation update (added 'clocks' field) Changes v4 -> v5: * Documentation update (as suggested by Alexey Brodkin) * Changed compatible

[RESEND PATCH 2/2 v6] arc: axs10x: Add DT bindings for I2S PLL Clock

2016-05-02 Thread Jose Abreu
Add device tree bindings for AXS10X I2S PLL Clock driver. Signed-off-by: Jose Abreu Acked-by: Alexey Brodkin Acked-by: Vineet Gupta --- Changes v5 -> v6: * Added 'clocks' field This patch was only introduced in v5. Cc: Carlos Palminha Cc: Rob Herring Cc: Pawel Moll Cc: Mar

Re: [RESEND PATCH 2/2 v6] arc: axs10x: Add DT bindings for I2S PLL Clock

2016-05-09 Thread Jose Abreu
Hi Vineet, On 02-05-2016 10:39, Jose Abreu wrote: > Add device tree bindings for AXS10X I2S PLL Clock driver. > > Signed-off-by: Jose Abreu > Acked-by: Alexey Brodkin > Acked-by: Vineet Gupta > --- > > Changes v5 -> v6: > * Added 'clocks' field > >

[PATCH 3/4 v7] ASoC: dwc: Add PIO PCM extension

2016-05-23 Thread Jose Abreu
the reason why this extension was added. The selection between the use of DMA engine or PIO mode is detected by declaring or not the interrupt parameters in the DT and using Kconfig. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Mark Brown Cc: Liam Girdwood Cc: Jaroslav Kysela Cc: Takashi

[PATCH 0/4 v7] Add I2S audio support for ARC AXS10x boards

2016-05-23 Thread Jose Abreu
ad.org Cc: alsa-de...@alsa-project.org Cc: devicet...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Jose Abreu (4): ASoC: dwc: Add helper functions to disable/enable irqs ASoC: dwc: Do not use devm_clk_get() if using platform data ASoC: dwc: Add PIO PCM extension ASoC: dwc: Ad

[PATCH 4/4 v7] ASoC: dwc: Add irq parameter to DOCUMENTATION

2016-05-23 Thread Jose Abreu
A parameter description for the interruptions of the I2S controller was added. This interrupt parameter should only be set when I2S does not have DMA support. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Mark Brown Cc: Liam Girdwood Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Rob Herring

[PATCH 1/4 v7] ASoC: dwc: Add helper functions to disable/enable irqs

2016-05-23 Thread Jose Abreu
Helper functions to disable and enable the I2S interrupts were added. Only the interrupts of the used channels are enabled. Also, there is no need to enable irqs at dw_i2s_config(), they are already enabled at startup. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Mark Brown Cc: Liam

[PATCH 2/4 v7] ASoC: dwc: Do not use devm_clk_get() if using platform data

2016-05-23 Thread Jose Abreu
When using platform data the devm_clk_get() function is called causing a probe failure if the clock is not declared. As we can pass the clock handler by platform data call only devm_clk_get() when platform data is not used. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Mark Brown Cc: Liam

Re: [PATCH 3/4 v7] ASoC: dwc: Add PIO PCM extension

2016-05-24 Thread Jose Abreu
Hi Mark, Thanks for your comments. On 24-05-2016 17:41, Mark Brown wrote: > On Mon, May 23, 2016 at 11:02:24AM +0100, Jose Abreu wrote: > >> +config SND_DESIGNWARE_PCM >> +bool "PCM PIO extension for I2S driver" > Why can't this be built as a module?

Re: [PATCH 3/4 v7] ASoC: dwc: Add PIO PCM extension

2016-05-25 Thread Jose Abreu
Hi Mark, On 24-05-2016 18:51, Mark Brown wrote: > On Tue, May 24, 2016 at 06:07:14PM +0100, Jose Abreu wrote: >> On 24-05-2016 17:41, Mark Brown wrote: > Please fix your mail client to word wrap within paragraphs at something > substantially less than 80 columns. Doing this make

Re: [PATCH 3/4 v7] ASoC: dwc: Add PIO PCM extension

2016-05-25 Thread Jose Abreu
Hi Mark, On 25-05-2016 11:18, Mark Brown wrote: > On Wed, May 25, 2016 at 11:11:47AM +0100, Jose Abreu wrote: > >> I think I will take the second option. Something like this: >> " >> ret = snd_dmaengine_pcm_register(...) >> if (ret == -EPROBE_DEFER)

DRM DMA Engine

2016-05-25 Thread Jose Abreu
Hi all, Currently I am trying to develop a DRM driver that will use Xilinx VDMA to transfer video data to a HDMI TX Phy and I am facing a difficulty regarding the understanding of the DRM DMA Engine. I looked at several sources and at the DRM core source but the flow of creating and interfacing wi

[PATCH 2/2 v6] ASoC: dwc: Update DOCUMENTATION for I2S Driver

2016-04-27 Thread Jose Abreu
This patch updates documentation for the Designware I2S driver. Signed-off-by: Jose Abreu Acked-by: Rob Herring Cc: Rob Herring Cc: Carlos Palminha Cc: Alexey Brodkin Cc: devicet...@vger.kernel.org Cc: linux-snps-...@lists.infradead.org Cc: alsa-de...@alsa-project.org Cc: linux-kernel

[PATCH 1/2 v6] ASoC: dwc: Add custom PCM driver

2016-04-27 Thread Jose Abreu
necessary to add this custom platform driver so that HDMI audio works in AXS boards. The selection between the use of DMA engine or PIO mode is detected by declaring or not the DMA parameters in the device tree. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Mark Brown Cc: Liam Girdwood Cc

[PATCH 0/2 v6] Add I2S audio support for ARC AXS10x boards

2016-04-27 Thread Jose Abreu
c: Takashi Iwai Cc: Rob Herring Cc: Alexey Brodkin Cc: linux-snps-...@lists.infradead.org Cc: alsa-de...@alsa-project.org Cc: devicet...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Jose Abreu (2): ASoC: dwc: Add custom PCM driver ASoC: dwc: Update DOCUMENTATION for I2S Driver .../devi

Re: [PATCH 2/2 v6] ASoC: dwc: Update DOCUMENTATION for I2S Driver

2016-04-27 Thread Jose Abreu
Hi Mark, Sorry. Follows bellow. On 27-04-2016 11:05, Jose Abreu wrote: > This patch updates documentation for the Designware I2S > driver. > > Signed-off-by: Jose Abreu > Acked-by: Rob Herring > Cc: Rob Herring > Cc: Carlos Palminha > Cc: Alexey Brodkin > Cc: devi

Re: [RESEND PATCH v4] clk/axs10x: Add I2S PLL clock driver

2016-04-20 Thread Jose Abreu
Hi Stephen, On 20-04-2016 02:54, Stephen Boyd wrote: > On 04/19, Jose Abreu wrote: >> @Stephen: can you give some input so that I can submit a v6? >> > I don't prefer putting the second register in the same DT node, > but that's really up to the DT reviewers

Re: [RESEND PATCH v4] clk/axs10x: Add I2S PLL clock driver

2016-04-21 Thread Jose Abreu
Hi Alexey, On 20-04-2016 17:12, Alexey Brodkin wrote: > Hi Jose, Stephen, > > On Wed, 2016-04-20 at 10:47 +0100, Jose Abreu wrote: >> Hi Stephen, >> >> >> On 20-04-2016 02:54, Stephen Boyd wrote: >>> On 04/19, Jose Abreu wrote: >>>> @Step

Re: [RESEND PATCH v4] clk/axs10x: Add I2S PLL clock driver

2016-04-21 Thread Jose Abreu
Hi Alexey, On 21-04-2016 13:18, Alexey Brodkin wrote: > Hi Jose, > > On Thu, 2016-04-21 at 10:51 +0100, Jose Abreu wrote: >> Hi Alexey, > >>>>> Otherwise, I still prefer two DTS files for the two different FPGA >>>>> versions. At the least, pl

[PATCH 0/2 v6] Add AXS10X I2S PLL clock driver

2016-04-21 Thread Jose Abreu
sted by Vineet Gupta) Changes v2 -> v3: * Implemented recalc_rate Changes v1 -> v2: * Renamed folder to axs10x (as suggested by Alexey Brodkin) * Added more supported rates Jose Abreu (2): clk/axs10x: Add I2S PLL clock driver arc: axs10x: Add DT bindings for I2S PLL Clock .../binding

[PATCH 1/2 v6] clk/axs10x: Add I2S PLL clock driver

2016-04-21 Thread Jose Abreu
rate. Signed-off-by: Jose Abreu --- Changes v5 -> v6: * Use parent clock to determine PLL input rate instead of using hardcoded values * Documentation update (added 'clocks' field) Changes v4 -> v5: * Documentation update (as suggested by Alexey Brodkin) * Changed compatible

[PATCH 2/2 v6] arc: axs10x: Add DT bindings for I2S PLL Clock

2016-04-21 Thread Jose Abreu
Add device tree bindings for AXS10X I2S PLL Clock driver. Signed-off-by: Jose Abreu --- Changes v5 -> v6: * Added 'clocks' field This patch was only introduced in v5. arch/arc/boot/dts/axs10x_mb.dtsi | 13 + 1 file changed, 13 insertions(+) diff --git a/arch

Re: [PATCH 1/2 v6] clk/axs10x: Add I2S PLL clock driver

2016-04-21 Thread Jose Abreu
Adding device tree mailing list and Rob Herring. On 21-04-2016 18:19, Jose Abreu wrote: > The ARC SDP I2S clock can be programmed using a > specific PLL. > > This patch has the goal of adding a clock driver > that programs this PLL. > > At this moment the rate values are h

Re: [PATCH 2/2 v6] arc: axs10x: Add DT bindings for I2S PLL Clock

2016-04-21 Thread Jose Abreu
Adding device tree mailing list and Rob Herring. On 21-04-2016 18:19, Jose Abreu wrote: > Add device tree bindings for AXS10X I2S PLL Clock driver. > > Signed-off-by: Jose Abreu > --- > > Changes v5 -> v6: > * Added 'clocks' field > > This patch was only

[PATCH 0/5 v4] Add I2S/ADV7511 audio support for ARC AXS10x boards

2016-04-07 Thread Jose Abreu
gested by Alexey Brodkin) * Removed defconfigs entries (as suggested by Alexey Brodkin) NOTE: Although the mainline I2S driver uses ALSA DMA engine, this controller can be built without DMA support so it was necessary to add this custom platform driver so that HDMI audio works in AXS boards. Jose

[PATCH 3/5 v4] ASoC: dwc: Use fifo depth to program FCR

2016-04-07 Thread Jose Abreu
This patch makes Designware I2S driver use the fifo depth value to program the fifo configuration register instead of using hardcoded values. Signed-off-by: Jose Abreu --- This patch was only introduced in v4. sound/soc/dwc/designware_i2s.c | 9 +++-- 1 file changed, 7 insertions(+), 2

[PATCH 4/5 v4] ASoC: dwc: Add custom PCM driver

2016-04-07 Thread Jose Abreu
necessary to add this custom platform driver so that HDMI audio works in AXS boards. The selection between the use of DMA engine or custom PCM can be made using a device tree boolean parameter which was introduced in this patch ('snps,use-dmaengine'). Signed-off-by: Jose Abreu ---

[PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for I2S Driver

2016-04-07 Thread Jose Abreu
This patch updates documentation for the Designware I2S driver. Signed-off-by: Jose Abreu --- This patch was only introduced in v4. Documentation/devicetree/bindings/sound/designware-i2s.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/sound

[PATCH 2/5 v4] drm/i2c/adv7511: Add audio support

2016-04-07 Thread Jose Abreu
alogdevicesinc/linux/ The audio can be disabled using menu-config and/or device tree so it is possible to use only video mode. The audio (when enabled) registers as a codec into ALSA. SPDIF DAI format was also added to ASoC as it is required by adv7511 audio. Signed-off-by: Jose Abreu ---

[PATCH 1/5 v4] drm/i2c/adv7511: Rename and move to separate folder

2016-04-07 Thread Jose Abreu
adding of audio support. Signed-off-by: Jose Abreu --- No changes v3 -> v4. This patch was only introduced in v3. drivers/gpu/drm/i2c/Kconfig| 6 +--- drivers/gpu/drm/i2c/Makefile | 2 +- drivers/gpu/drm/i2c/adv7511/Kconfig|

Re: [PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for I2S Driver

2016-04-08 Thread Jose Abreu
Hi Mark, On 07-04-2016 18:53, Mark Brown wrote: > On Thu, Apr 07, 2016 at 05:53:59PM +0100, Jose Abreu wrote: > >> + Optional properties: >> + - snps,use-dmaengine: If set the driver will use ALSA DMA engine. If set >> + it is required to use the properties 'dma

Re: [alsa-devel] [PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for I2S Driver

2016-04-08 Thread Jose Abreu
Hi Lars, On 08-04-2016 16:52, Lars-Peter Clausen wrote: > On 04/08/2016 12:06 PM, Jose Abreu wrote: >> Hi Mark, >> >> >> On 07-04-2016 18:53, Mark Brown wrote: >>> On Thu, Apr 07, 2016 at 05:53:59PM +0100, Jose Abreu wrote: >>> >>>> + Opt

Re: [alsa-devel] [PATCH 2/5 v4] drm/i2c/adv7511: Add audio support

2016-04-08 Thread Jose Abreu
Hi Lars, On 08-04-2016 16:46, Lars-Peter Clausen wrote: > On 04/07/2016 06:53 PM, Jose Abreu wrote: >> This patch adds audio support for the ADV7511 HDMI transmitter >> using ALSA SoC. >> >> The code was ported from Analog Devices linux tree from >> commit 177

Re: [alsa-devel] [PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for I2S Driver

2016-04-11 Thread Jose Abreu
Hi Lars, On 09-04-2016 15:55, Lars-Peter Clausen wrote: > On 04/08/2016 06:08 PM, Jose Abreu wrote: >> Hi Lars, >> >> >> On 08-04-2016 16:52, Lars-Peter Clausen wrote: >>> On 04/08/2016 12:06 PM, Jose Abreu wrote: >>>> Hi Mark, >>>> &

Re: [alsa-devel] [PATCH 2/5 v4] drm/i2c/adv7511: Add audio support

2016-04-11 Thread Jose Abreu
Hi Lars, On 09-04-2016 16:02, Lars-Peter Clausen wrote: > On 04/08/2016 06:12 PM, Jose Abreu wrote: > [...] >>> [...] >>>> +- adi,enable-audio: If set the ADV7511 driver will register a codec >>>> interface >>>> + into ALSA SoC. >>>

[RESEND PATCH v4] clk/axs10x: Add I2S PLL clock driver

2016-04-11 Thread Jose Abreu
rate. Signed-off-by: Jose Abreu --- Changes v3 -> v4: * Added binding document (as suggested by Stephen Boyd) * Minor code style fixes (as suggested by Stephen Boyd) * Use ioremap (as suggested by Stephen Boyd) * Implement round_rate (as suggested by Stephen Boyd) * Change to platform driver

Re: [alsa-devel] [PATCH 2/5 v4] drm/i2c/adv7511: Add audio support

2016-04-11 Thread Jose Abreu
Hi Lars, On 11-04-2016 10:33, Lars-Peter Clausen wrote: > On 04/11/2016 11:27 AM, Jose Abreu wrote: >> Hi Lars, >> >> >> On 09-04-2016 16:02, Lars-Peter Clausen wrote: >>> On 04/08/2016 06:12 PM, Jose Abreu wrote: >>> [...] >>>>> [...

Re: [PATCH 1/3 v2] drm/i2c/adv7511: Add audio support

2016-04-05 Thread Jose Abreu
Hi Laurent, On 04-04-2016 22:41, Laurent Pinchart wrote: > Hi Jose, > > On Monday 04 Apr 2016 10:05:39 Jose Abreu wrote: >> On 01-04-2016 18:10, Laurent Pinchart wrote: >>> On Monday 28 Mar 2016 15:36:09 Jose Abreu wrote: >>>> This patch adds audio supp

[PATCH 2/3 v3] drm/i2c/adv7511: Add audio support

2016-04-05 Thread Jose Abreu
alogdevicesinc/linux/ The audio can be disabled using menu-config so it is possible to use only video mode. The audio (when enabled) registers as a codec into ALSA. SPDIF DAI format was also added to ASoC as it is required by adv7511 audio. Signed-off-by: Jose Abreu --- .../bindings/display/br

[PATCH 0/3 v3] Add I2S/ADV7511 audio support for ARC AXS10x boards

2016-04-05 Thread Jose Abreu
ine * Dropped IRQ handler for I2S Changes v1 -> v2: * DT bindings moved to separate patch (as suggested by Alexey Brodkin) * Removed defconfigs entries (as suggested by Alexey Brodkin) Jose Abreu (3): drm/i2c/adv7511: Rename and move to separate folder drm/i2c/adv7511: Add audio support ASo

[PATCH 3/3 v3] ASoC: dwc: Unmask I2S interrupts only for enabled channels

2016-04-05 Thread Jose Abreu
There is no need to unmask all interrupts at I2S start. This can cause performance issues in slower platforms. Unmask only the interrupts for the used channels. Signed-off-by: Jose Abreu --- Changes v2 -> v3: * Dropped custom platform driver, using now ALSA DMA engine * Dropped IRQ handler

[PATCH 1/3 v3] drm/i2c/adv7511: Rename and move to separate folder

2016-04-05 Thread Jose Abreu
adding of audio support. Signed-off-by: Jose Abreu --- This patch was only introduced in v3. drivers/gpu/drm/i2c/Kconfig| 6 +--- drivers/gpu/drm/i2c/Makefile | 2 +- drivers/gpu/drm/i2c/adv7511/Kconfig| 6 drivers/gpu/drm/i2c

Re: [RESEND PATCH v4] clk/axs10x: Add I2S PLL clock driver

2016-04-18 Thread Jose Abreu
Hi Stephen, On 16-04-2016 00:46, Stephen Boyd wrote: > On 04/11, Jose Abreu wrote: >> new file mode 100644 >> index 000..3ba4e2f >> --- /dev/null >> +++ b/drivers/clk/axs10x/i2s_pll_clock.c >> @@ -0,0 +1,217 @@ >> + >> +static int i

  1   2   3   4   5   6   7   8   9   >