Hi Andy,
Thank you for your feedback.
> > -#define at24_loop_until_timeout(tout, op_time) \
> > - for (tout = jiffies + msecs_to_jiffies(at24_write_timeout), \
> > -op_time = 0; \
> > -op_time
Hi Andy,
> >> > -#define at24_loop_until_timeout(tout, op_time) \
> >> > - for (tout = jiffies + msecs_to_jiffies(at24_write_timeout), \
> >> > -op_time = 0; \
> >> > -op_time ? time_before(op_t
Hello Rob,
> > +* Rohm BU21029 Touch Screen Controller
> > +
> > +Required properties:
> > + - compatible : must be "rohm,bu21029"
> > + - reg : i2c device address of the chip
>
> What the valid value(s)?
The chip itself can be wired to 0x40 or 0x41. The driver c
Hello Dmitry,
> > +++ b/drivers/input/touchscreen/bu21029_ts.c
> > @@ -0,0 +1,456 @@
>
> Please add SPDX tag for the driver.
We will do.
> Please use GPIOD API (and include linux/gpio/consumer.h instead of
> of_gpio.h).
We will do the change.
> > +/* HW_ID1 Register (PAGE=0, ADDR=0x0E, Reset
Hello Marc,
> > The existing SocketCAN implementation provides alloc_candev() to
> > allocate a CAN device using a single Tx and Rx queue. This can lead to
> > priority inversion in case the single Tx queue is already full with low
> > priority messages and a high priority message needs to be sent
Hello Marc,
> >> Do you have a driver or a patch to make a driver mq aware?
> >
> > Yes, we have CAN hardware with multiple queues and we also have a
> > SocketCAN driver for it.
> >
> > IMHO the driver will be of very little use for the Linux community
> > because the HW is proprietary.
>
> That
Hi kbuild test robot,
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on v4.17-rc4]
> [also build test WARNING on next-20180615]
> [cannot apply to input/next]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improve the syst
Hi,
> [PATCH v5] Input: add bu21029 touch driver
>
> Add Rohm BU21029 resistive touch panel controller support with I2C
> interface.
Is the patch ready to be pushed upstream? Is there anything I still need to do?
Regards,
Mark
Mark Jonas
Building Technologies, Panel Software Fire (BT-FIR/ENG1
Hello Dmitry,
> > [PATCH v5] Input: add bu21029 touch driver
> >
> > Add Rohm BU21029 resistive touch panel controller support with I2C
> > interface.
>
> Is the patch ready to be pushed upstream? Is there anything I still need to
> do?
I would like to kindly remind you of the BU21029 touch scr
Hello Dmitry,
> Sorry for the delay. Could you please tell me if the patch below (shoudl
> apply on top of your v5 version) works?
The patch applies cleanly and we will give the code a thorough test.
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/bu21029.txt
> b/Documentation
Hi Dmitry,
> > > > [PATCH v5] Input: add bu21029 touch driver
> > > >
> > > > Add Rohm BU21029 resistive touch panel controller support with I2C
> > > > interface.
> > >
> > > Is the patch ready to be pushed upstream? Is there anything I still need
> > > to do?
> >
> > I would like to kindly remi
Hi,
Correction:
> Only for 4.14 an #include was missing. I
> Guess the API changed here a little in the meantime.
The missing include is #include .
Greetings,
Mark
Building Technologies, Panel Software Fire (BT-FIR/ENG1)
Bosch Sicherheitssysteme GmbH | Postfach 11 11 | 85626 Grasbrunn | GERMA
Hello Dmitry,
> > > > +static void bu21029_stop_chip(struct input_dev *dev)
> > > > +{
> > > > + struct bu21029_ts_data *bu21029 = input_get_drvdata(dev);
> > > > +
> > > > + disable_irq(bu21029->client->irq);
> > > > + del_timer_sync(&bu21029->timer);
> > > > +
> > > > + /
Hi Oliver,
> > The driver suite consists of three separate drivers. The following
> > diagram illustrates the dependencies in layers.
> >
> > /dev/companion SocketCANUser Space
> > ---
> > +
Hello Andy,
> > Add Rohm BU21029 resistive touch panel controller support with I2C
> > interface.
>
> > +#include
>
> This becomes redundant (see below).
Removed.
> > +#define STOP_DELAY_US 50L
> > +#define START_DELAY_MS 2L
> > +#define BUF_LEN8L
>
> No need to use L for such small
Hello,
> Betreff: [PATCH v2] Input: add bu21029 touch driver
>
> From: Zhu Yi
>
> Add Rohm BU21029 resistive touch panel controller support with I2C
> interface.
>
> Signed-off-by: Zhu Yi
> Signed-off-by: Mark Jonas
> Reviewed-by: Heiko Schocher
> ---
> Changes in v2:
> - make ABS_PRESSURE
Hello Marc,
> > The driver consists of two layers because the HW is accessed via SPI.
>
> Normal SPI?
Yes, normal SPI (CLK, MOSI, MISO, SEL) plus two GPIOs for flow control.
The CAN peripheral (SPI slave) asserts the additional signals to
request a transfer and to signal that it is busy.
> > I
Hi Adam,
> > From: Hubert Streidl
> >
> > By default the PMIC DA9063 2-wire interface is SMBus compliant. This
> > means the PMIC will automatically reset the interface when the clock
> > signal ceases for more than the SMBus timeout of 35 ms.
> >
> > If the I2C driver / device is not capable of
Hi Adam,
> > + if (i2c_check_functionality(i2c->adapter, I2C_FUNC_I2C)) {
> > + dev_info(da9063->dev, "I2C mode");
> > + busmode = 0;
> > + } else {
> > + dev_info(da9063->dev, "SMBus mode");
> > + busmode = 1;
>
> I think this should be 'DA9063_TWOWIRE
Hi Lee,
> Code looks good to me now, thanks.
>
> However, this doesn't look like it would pass checkpatch.
>
> Have you tried to build with W=1 and checkpatch?
Yes, we used checkpatch.pl.
$ ./scripts/checkpatch.pl 0001-mfd-da9063-Support-SMBus-and-I2C-mode.v5
total: 0 errors, 0 warning
Hi,
> > From: Hubert Streidl
> >
> > By default the PMIC DA9063 2-wire interface is SMBus compliant. This
> > means the PMIC will automatically reset the interface when the clock
> > signal ceases for more than the SMBus timeout of 35 ms.
> >
> > If the I2C driver / device is not capable of creat
Hi,
> > From: Hubert Streidl
> >
> > By default the PMIC DA9063 2-wire interface is SMBus compliant. This
> > means the PMIC will automatically reset the interface when the clock
> > signal ceases for more than the SMBus timeout of 35 ms.
> >
> > If the I2C driver / device is not capable of creat
Hi Thomas and Daniel,
Thank you very much for your feedback. We appreciate it.
> >>> diff --git a/drivers/gpu/drm/imx/imx-drm-core.c
> >>> b/drivers/gpu/drm/imx/imx-drm-core.c
> >>> index 9bf5ad6d18a2..2665040e11c7 100644
> >>> --- a/drivers/gpu/drm/imx/imx-drm-core.c
> >>> +++ b/drivers/gpu/drm/
Hi Daniel,
> > Thank you very much for your feedback. We appreciate it.
> >
> > > >>> diff --git a/drivers/gpu/drm/imx/imx-drm-core.c
> > > >>> b/drivers/gpu/drm/imx/imx-drm-core.c
> > > >>> index 9bf5ad6d18a2..2665040e11c7 100644
> > > >>> --- a/drivers/gpu/drm/imx/imx-drm-core.c
> > > >>> +++ b/
An: Support Opensource ; Lee Jones
> ; Rob Herring
> Cc: devicet...@vger.kernel.org; linux-kernel@vger.kernel.org;
> adam.thomson.opensou...@diasemi.com; stwiss.opensou...@diasemi.com;
> marek.va...@gmail.com; RUAN Tingquan (BT-FIR/ENG1-Zhu)
> ; Streidl Hubert (BT-FIR/ENG1-Grb)
>
25 matches
Mail list logo
