Hi,
I ask for feedback and to submit (if possible) a new ARM SoC platform
port. This is now near complete (I think) (tested on UC-7112-LX Plus)
and applies to 2.6.34.14.
The patch contains the following drivers and platform specific implementations:
* ARCH_MOXART (FA526 processor)
* 100Hz interr
Thank you for the feedback.
Some of the changes are sure to be a challenge for me, but I want to
move this forward, and having a list helps.
3.2.40 is as far as it'll go right now, nothing prints to UART
starting with 3.3.8 (last tested, it's somewhere around there).
I have been advised to enabl
Arnd suggested removing one (or many) of the options:
CPU_ABRT_EV4T
CPU_CACHE_V4WT
CPU_COPY_V4WB
CPU_TLB_V4WBI
However boot is still broken after removing all including CPU_32v4T.
Selecting CPU_SA1100 instead, it boots normally and init works.
The idea is, If you can help figure out what exactl
Add dmaengine driver for MOXA ART SoCs based on virt_dma.
Signed-off-by: Jonas Jensen
---
Notes:
Applies to next-20130703
The MMC driver I plan to submit next can use this
(falls back to PIO if unavailable).
Nothing else uses DMA on UC-7112-LX.
drivers/dma/Kconfig
Add SDHCI driver for MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
Applies to next-20130703
I know this is a large chunk and there are many pitfalls with
the controller. I give you my word it does work / seem to be stable,
with or without DMA. Any feedback is
On 10 July 2013 11:30, Russell King - ARM Linux wrote:
> Do you actually make any use what so ever of the vchan support?
Only because it was inspired by the edma driver:
static inline struct moxart_dma_chan *to_moxart_dma_chan(struct dma_chan *c)
{
return container_of(c, struct moxart_dm
Add dmaengine driver for MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
Applies to next-20130703
Changes since v1:
1. remove use of vchan support
drivers/dma/Kconfig | 9 +
drivers/dma/Makefile | 1 +
drivers/dma/moxart-dma.c | 477
Add GPIO driver for MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
Applies to next-20130703
drivers/gpio/Kconfig | 7 ++
drivers/gpio/Makefile | 1 +
drivers/gpio/gpio-moxart.c | 168 +
3 files changed, 176 insertions
Add RTC driver for MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
Applies to next-20130703
drivers/rtc/Kconfig | 9 ++
drivers/rtc/Makefile | 1 +
drivers/rtc/rtc-moxart.c | 335 +++
3 files changed, 345 insertions(+)
create
Add watchdog driver for MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
Applies to next-20130711
drivers/watchdog/Kconfig | 10 +++
drivers/watchdog/Makefile | 1 +
drivers/watchdog/moxart_wdt.c | 190 ++
3 files changed, 201
Add RTC driver for MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
Thanks for the review Mark, what you said should be
fixed in v2.
Applies to next-20130711
Changes since v1:
1. remove defines GPIO_EM1240_HIGH and GPIO_EM1240_LOW
2. rename struct
driver or client application.
Signed-off-by: Jonas Jensen
---
Notes:
Changes since v8:
1. reorder probe path, of_dma_controller_register() now happens after
devm_request_irq()
2. call of_dma_controller_free() on removal
3. set flag on error, return DMA_ERROR in
Hi Mark,
Thanks for the replies. Please have a look at v9.
On 7 August 2013 17:13, Mark Rutland wrote:
>> +
>> + ret = devm_request_irq(dev, irq, moxart_dma_interrupt, 0,
>> + "moxart-dma-engine", mdc);
>> + if (ret) {
>> + dev_err(dev, "dev
driver or client application.
Signed-off-by: Jonas Jensen
---
Notes:
Changes since v9:
1. reorder probe path, also move dma_async_device_register() to happen
after devm_request_irq()
Applies to next-20130927
.../devicetree/bindings/dma/moxa,moxart-dma.txt| 19
driver or client application.
Signed-off-by: Jonas Jensen
---
Notes:
Changes since v10:
device tree bindings document:
1. reformat interrupt description text
Applies to next-20130927
.../devicetree/bindings/dma/moxa,moxart-dma.txt| 20 +
drivers/dma/Kconfig
On 7 October 2013 17:12, Mark Rutland wrote:
> Sorry I didn't notice this previously, but "moxa" isn't in
> Documentation/devicetree/bindings/vendor-prefixes.txt (despite several
> bindings using it). Could you cook up a separate patch to add an entry
> for Moxa, please?
Yes, I'll submit a separa
Add moxa vendor prefix.
Signed-off-by: Jonas Jensen
---
Notes:
Submitting this per Mark Rutland's request.
Applies to next-20130927
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/v
On 8 October 2013 15:03, Mark Rutland wrote:
> Should this not be Moxa _Technologies_ Co., Ltd? (judging by a quick
> search).
Yes, looks like this is the correct name.
"Moxa Technologies Co., Ltd." -
http://tess2.uspto.gov/bin/showfield?f=doc&state=4810:64v1l4.4.2
I'll send a new version.
Re
Add moxa vendor prefix.
Signed-off-by: Jonas Jensen
---
Notes:
Changes since v1:
1. use the correct vendor name "Moxa Technologies Co., Ltd."
Applies to next-20130927
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
1 file changed, 1 insertion(+)
This patch adds MOXA ART SoCs clock driver support.
Signed-off-by: Jonas Jensen
---
Notes:
Since last version, Adam Jaremko has been helping providing info on
the clock registers and the SoC in general. He's been looking at
bootloader sources in particular, which seem to do the
Hi,
Thanks for the replies.
What isn't commented below should already be fixed. I'll resubmit the
entire set when it looks like there's nothing left to amend.
On 13 June 2013 00:42, Olof Johansson wrote:
> You should provide a commit message, ideally with a short introduction of the
> platform.
Hi,
Thanks for the replies.
What isn't commented below should already be fixed.
On 13 June 2013 00:49, Olof Johansson wrote:
> Hi,
>
> You should add a bindings description for the MOXA SoC platforms, similar to
> how others do it, under Documentation/devicetree/bindings/arm/.
The following is
y.
Leftovers removed. I only added them because I spent some time
figuring out the call chain around putc.
>> +++ b/arch/arm/include/debug/moxart.S
>> @@ -0,0 +1,14 @@
>> +/* Copyright (C) 2013 Jonas Jensen
>> + * This program is free software; you can redistribute it and/o
Add generic SoC include and UC-7112-LX platform device tree files.
Add device tree bindings documentation.
Signed-off-by: Jonas Jensen
---
Documentation/devicetree/bindings/arm/moxart.txt |8 +++
.../arm/moxart/moxart-interrupt-controller.txt | 29 +
.../bindings/arm/moxart
Add MOXA ART kernel low-level debugging port support.
Signed-off-by: Jonas Jensen
---
arch/arm/Kconfig.debug |8
arch/arm/include/debug/moxart.S | 16
2 files changed, 24 insertions(+), 0 deletions(-)
create mode 100644 arch/arm/include/debug/moxart.S
Add MOXA ART SoC support.
The MOXA ART SoC is based on a Faraday FA526 ARMv4 32-bit 192 MHz CPU with MMU
and 16KB/8KB D/I-cache (UC-7112-LX).
Used on models UC-7101, UC-7112/UC-7110, IA240/IA241, IA3341.
Signed-off-by: Jonas Jensen
---
arch/arm/Kconfig |2 +
arch
processor specific idle function.
Note: moxart boots and prints to UART without this patch, but input is broken.
Signed-off-by: Jonas Jensen
---
arch/arm/mm/proc-fa526.S |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mm/proc-fa526.S b/arch/arm/mm/proc-fa526.S
On 17 June 2013 16:30, Russell King - ARM Linux wrote:
> It replaces the WFI and return with a pure nop, so we will fall through
> to cpu_fa526_dcache_clean_area(). Do we really want to clean a random
> D cache entry depending on what r0 happened to hold at this point? I
> think not...
I'm sorr
specific idle function.
Applies to arm-soc/for-next.
Changes since v1:
1. remove WFI but make sure cpu_fa526_do_idle do not fall through
to cpu_fa526_dcache_clean_area
Note: moxart boots and prints to UART without this patch, but input is broken.
Signed-off-by: Jonas Jensen
---
arch/arm/mm
I may have submitted this one too early. There are now a few things I
want to address:
* rename moxart_uc7112lx_defconfig moxart_defconfig
* remove MACH_UC7112LX "default y" from arch/arm/mach-moxart/Kconfig
Also, the omitted arch/arm/mach-moxart/idle.c hinges on a patch now
submitted to Russell'
This patch adds an clocksource driver for the main timer found
on MOXA ART SoCs.
Applies to 3.10-rc1 and arm-soc/for-next (2013-06-15)
Signed-off-by: Jonas Jensen
---
drivers/clocksource/Makefile |1 +
drivers/clocksource/moxart_timer.c | 129
2
This patch adds an irqchip driver for the main interrupt controller found
on MOXA ART SoCs.
Applies to 3.10-rc1 and arm-soc/for-next (2013-06-15)
Signed-off-by: Jonas Jensen
---
drivers/irqchip/Makefile |1 +
drivers/irqchip/irq-moxart.c | 163
On 30 May 2013 13:46, Po-Yu Chuang wrote:
> This bug was introduced in commit e651eab0.
> Some v4/v5 platforms failed to boot due to this.
Thanks!
Confirming that this fixes boot on MOXA ART (FA526).
Best regards,
Jonas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
This patch adds an irqchip driver for the main interrupt controller found
on MOXA ART SoCs.
v2:
* use irq_chip_generic
* remove macro duplicates
Applies to next-20130619
Signed-off-by: Jonas Jensen
---
drivers/irqchip/Makefile |1 +
drivers/irqchip/irq-moxart.c | 109
Signed-off-by: Jonas Jensen
---
arch/arm/boot/dts/Makefile|1 +
arch/arm/boot/dts/moxart-uc7112lx.dts | 89 +
arch/arm/boot/dts/moxart.dtsi | 84 +++
3 files changed, 174 insertions(+), 0 deletions
Signed-off-by: Jonas Jensen
---
arch/arm/Kconfig.debug | 10 ++
arch/arm/include/debug/moxart.S | 14 ++
2 files changed, 24 insertions(+), 0 deletions(-)
create mode 100644 arch/arm/include/debug/moxart.S
diff --git a/arch/arm/Kconfig.debug b/arch/arm
Signed-off-by: Jonas Jensen
---
arch/arm/Kconfig |2 +
arch/arm/Makefile |1 +
arch/arm/configs/moxart_uc7112lx_defconfig | 112
arch/arm/mach-moxart/Kconfig | 28 +++
arch/arm/mach
3-May/168438.html
Full source (including drivers) here:
https://code.google.com/p/linux-3-10-rc1-moxart/source/list
Jonas Jensen (3):
ARM: mach-moxart: add MOXA ART SoC files
ARM: mach-moxart: add MOXA ART device tree files
ARM: mach-moxart: add MOXA ART UART debug files
arch/arm/Kc
This patch adds an irqchip driver for the main interrupt controller found
on MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
Applies to next-20130619
Changes since v3:
1. pack global variables in struct
2. make handle_irq function static
3. call
This patch adds an clocksource driver for the main timer(s)
found on MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
Applies to next-20130703
Changes since v4:
1. add general cache for TIMER_CR register
drivers/clocksource/Makefile | 1 +
drivers
This patch adds an irqchip driver for the main interrupt controller found
on MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
Applies to next-20130703
Changes since v4:
1. shorten DT compatible value to "moxart-ic"
2. use alphabetic ordering in Makefile
This patch adds MOXA ART SoCs clock driver support.
Signed-off-by: Jonas Jensen
---
Notes:
of_clk_init(NULL) is now called from moxart machine descriptor
.init_time hook. clocksource now depend on this to be loaded first.
Applies to next-20130703
Changes since v1
Add MOXA ART SoC support.
The MOXA ART SoC is based on a Faraday FA526 ARMv4 32-bit 192 MHz CPU
with MMU and 16KB/8KB D/I-cache (UC-7112-LX).
Signed-off-by: Jonas Jensen
---
Notes:
Applies to next-20130703
Changes since v2:
1. add CLKSRC_MMIO and GENERIC_CLOCKEVENTS to
Add generic SoC include and UC-7112-LX platform device tree files
and documentation.
Signed-off-by: Jonas Jensen
---
Notes:
Applies to next-20130703
Changes since v2:
1. add and update documentation, new drivers: mmc, mac, rtc,
watchdog, gpio, core-clock, apb-clock
Add MOXA ART kernel low-level debugging port support.
Signed-off-by: Jonas Jensen
---
Notes:
Applies to next-20130703
Changes since v2:
1. use alphabetic ordering in Kconfig
arch/arm/Kconfig.debug | 8
arch/arm/include/debug/moxart.S | 20
+0x9c/0x3cc)
[2.58] [] (do_signal+0x9c/0x3cc) from []
(do_work_pending+0xc4/0xe0)
[2.58] [] (do_work_pending+0xc4/0xe0) from []
(work_pending+0xc/0x20)
Signed-off-by: Jonas Jensen
---
arch/arm/Kconfig | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm/Kconfig b/arch
This patch adds an clocksource driver for the main timer(s)
found on MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
Applies to next-20130703
Changes since v5:
1. remove global timereg_cache variable
2. use local cache for TIMER_CR register
drivers/clocksource
On 4 July 2013 23:42, Thomas Gleixner wrote:
> You just modify bits on the "cache" variable. though you are not
> caching it. As it seems to work it looks like this register simply can
> be written with constants.
I agree, the global "cache" variable wasn't very good. The only good thing, that
it
This patch adds an clocksource driver for the main timer(s)
found on MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
Applies to next-20130703
Changes since v6:
1. remove TIMER_CR read back
2. set TIMER_CR from constants
drivers/clocksource/Makefile | 1
Thanks for the replies Thomas.
On 5 July 2013 12:21, Thomas Gleixner wrote:
> Because you need to preserve the CR2 enable bit so your clocksource
> does not get switched off.
Yes, that was my main concern. The possibility of more flags being added.
I was experimenting with TIMEREG_CR_COUNT_UP bu
This patch adds an clocksource driver for the main timer(s)
found on MOXA ART SoCs.
Changes since v2:
1. use clocksource/clockevents infrastructures
2. clock frequency read from system clock
Applies to next-20130619
Signed-off-by: Jonas Jensen
---
drivers/clocksource/Makefile |1
Hi,
I have attempted to rectify with changes from all the feedback I have received.
On 26 June 2013 16:53, Jonas Jensen wrote:
> This patch adds an clocksource driver for the main timer(s)
> found on MOXA ART SoCs.
>
> Changes since v2:
Unfortunately the commit message is incorrec
This patch adds an clocksource driver for the main timer(s)
found on MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
Applies to next-20130619
Changes since v2:
1. remove unused defines: MAX_TIMER, USED_TIMER, APB_CLK
2. split register defines so each timer has a
This patch adds an irqchip driver for the main interrupt controller found
on MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
Applies to next-20130619
Changes since v2:
1. bail if irq_alloc_domain_generic_chips fails
2. remove separate function "moxart_all
This patch adds MOXA ART SoCs clock driver support.
Signed-off-by: Jonas Jensen
---
Notes:
Applies to next-20130619
drivers/clk/Makefile | 1 +
drivers/clk/clk-moxart.c | 141 +++
2 files changed, 142 insertions(+)
create mode 100644
This patch adds an clocksource driver for the main timer(s)
found on MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
This should hopefully address most of the issues pointed out by Thomas.
Preventing the counter from passing match, TIMER1 is now stopped before
count is
Add GPIO driver for MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
Changes since v1:
1. don't use hardcoded GPIO numbers, use of_get_named_gpio
2. check gpiochip_add return value
3. set gpio_chip .dev member to platform device
Applies to next-201
Add RTC driver for MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
Thanks for the replies. This should fix the remaining issues mentioned by
Mark and Arnd.
Changes since v2:
1. don't use hardcoded GPIO numbers, use of_get_named_gpio
2. make two functions s
Add watchdog driver for MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
Thanks for the review Guenter.
Changes since v1:
1. remove moxart_wdt_ping
2. remove unnecessary max timeout check in moxart_wdt_set_timeout
3. remove arm_pm_restart and
On 16 July 2013 15:13, Mark Brown wrote:
> Since you're now using OF you should also be including a binding
> document.
The binding document already exist in set of patches adding MOXA ART
SoC support ( I intend to mail out v4 once I know how to proceed ):
"[PATCH v3 2/4] ARM: mach-moxart: add M
This patch adds an clocksource driver for the main timer(s)
found on MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
Changes since v7:
1. use BIT macro
2. set moxart_clockevent.irq
Applies to next-20130716
drivers/clocksource/Makefile | 1 +
drivers
counter, used as clocksource
Timers are preconfigured by bootloader to count down and interrupt
on match or zero. Count increments every APB clock cycle and is
automatically reloaded when it reaches zero.
Signed-off-by: Jonas Jensen
---
Notes:
Changes since v8:
1. add devicetree
On 16 July 2013 17:01, Daniel Lezcano wrote:
> 1. could you elaborate the patch log: as it is a new driver, a nice
> description of the timer hardware would be valuable for people willing
> to understand the code (eg. some specificities of the driver).
A short description is now added to the comm
Just as a reminder, I intend to update this set with some minor changes:
1. remove devicetree bindings for drivers, I will mail those out separately
2. a devicetree node for DMA was added
3. GPIO numbers are now in DT aswell
Best regards,
Jonas
--
To unsubscribe from this list: send the line "uns
Add RTC driver for MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
Changes since v3:
1. add devicetree bindings document
Applies to next-20130716
.../devicetree/bindings/rtc/moxa,moxart-rtc.txt| 17 ++
drivers/rtc/Kconfig| 9
Add watchdog driver for MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
Changes since v2:
1. add devicetree bindings document
Applies to next-20130716
.../bindings/watchdog/moxa,moxart-watchdog.txt | 15 ++
drivers/watchdog/Kconfig
Add GPIO driver for MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
Changes since v2:
1. add devicetree bindings document
Applies to next-20130716
.../devicetree/bindings/gpio/moxa,moxart-gpio.txt | 23 +++
drivers/gpio/Kconfig | 7
Add dmaengine driver for MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
Changes since v2:
1. add devicetree bindings document
2. remove DMA_VIRTUAL_CHANNELS and "default n" from Kconfig
Applies to next-20130716
.../devicetree/bindings/dma/moxa,moxa
Add SDHCI driver for MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
Changes since v1:
1. remove IRQF_DISABLED
2. use devm_request_irq, remove free_irq
3. remove unnecessary dev_set_drvdata in moxart_remove
4. add devicetree bindings document
5. use BIT macro
This patch adds MOXA ART SoCs clock driver support.
Signed-off-by: Jonas Jensen
---
Notes:
Changes since v2:
1. add devicetree bindings document
Applies to next-20130716
.../bindings/clock/moxa,moxart-core-clock.txt | 19 +
drivers/clk/Makefile
Add binding document for MOXA ART SoCs interrupt controller.
Signed-off-by: Jonas Jensen
---
Notes:
The MOXA ART irqchip driver was added without accompanying devicetree
document.
( in next-20130716 drivers/irqchip/irq-moxart.c )
Applies to next-20130716
.../interrupt
network device drivers.
+#
+
+obj-$(CONFIG_ARM_MOXART_ETHER) += moxart_ether.o
+
diff --git a/drivers/net/ethernet/moxa/moxart_ether.c
b/drivers/net/ethernet/moxa/moxart_ether.c
new file mode 100644
index 000..172f718
--- /dev/null
+++ b/drivers/net/ethernet/moxa/moxart_ether.c
@@ -0,0 +1,544 @@
Hi Mark, thanks for taking a look at this.
On 18 July 2013 11:50, Mark Rutland wrote:
> This confuses me. moxart_of_clk_init gets called because there was a
> "moxa,moxart-core-clock", node in the dt, but the driver only seems to
> use the information to figure out the configuration of another cl
This patch adds MOXA ART SoCs clock driver support.
Signed-off-by: Jonas Jensen
---
Notes:
Changes since v5:
1. corrected of_iomap return value check
2. don't panic, print the error and return
Applies to next-20130729
.../bindings/clock/moxa,moxart-core-cloc
Add watchdog driver for MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
Changes since v4:
1. #include because IS_ERR comes from there
2. #include because UINT_MAX comes from there
3. #include because module_param() comes from there
device tree bindings
Add SDHCI driver for MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
Changes since v2:
1. #include because BIT() comes from there
2. reinsert dev_set_drvdata() in moxart_remove
3. remove MODULE_VERSION()
device tree bindings document:
4. describe
Add watchdog driver for MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
Changes since v5:
1. replace "moxart_wdt->dev.timeout" with "wdt_dev->timeout"
Applies to next-20130729
.../bindings/watchdog/moxa,moxart-watchdog.txt | 15 ++
Add watchdog driver for MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
Changes since v6:
1. use local struct device *dev pointer, replace "&pdev->dev" with "dev"
Applies to next-20130729
.../bindings/watchdog/moxa,moxart-watchdog.txt
Add GPIO driver for MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
Changes since v3:
1. use local struct device *dev pointer, replace "&pdev->dev" with "dev"
device tree bindings document:
2. describe compatible variable &quo
Add dmaengine driver for MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
Changes since v3:
1. use BIT() macro in header file
2. use hardcoded masks in header file
3. include linux/bitops.h
device tree bindings document:
4. describe compatible variable
ernet/moxa/Makefile
@@ -0,0 +1,5 @@
+#
+# Makefile for the MOXART network device drivers.
+#
+
+obj-$(CONFIG_ARM_MOXART_ETHER) += moxart_ether.o
diff --git a/drivers/net/ethernet/moxa/moxart_ether.c
b/drivers/net/ethernet/moxa/moxart_ether.c
new file mode 100644
index 000..af73c9c
--- /dev/null
++
ETHER) += moxart_ether.o
diff --git a/drivers/net/ethernet/moxa/moxart_ether.c
b/drivers/net/ethernet/moxa/moxart_ether.c
new file mode 100644
index 000..8856f4e
--- /dev/null
+++ b/drivers/net/ethernet/moxa/moxart_ether.c
@@ -0,0 +1,577 @@
+/* MOXA ART Ethernet (RTL8201CP) driver.
+ *
+ * Copyrig
Add dmaengine driver for MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
Changes since v4:
1. use DT probing / remove EXPORT_SYMBOL(moxart_filter_fn)
2. remove struct moxart_dma_reg_cfg
3. refactor and use hex literals
4. moxart_dma_filter_fn(): compare device
Hi Arnd,
Thanks for the replies. I think what you mention should now be fixed.
Except one thing where I still have questions:
On 29 July 2013 18:35, Arnd Bergmann wrote:
> You must not override the "dest_req_no" and "dest_req_no" in
> moxart_slave_config
> since they are already set by the ->x
Add dmaengine driver for MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
Preemptively submitting a new version that has the previously
mentioned two cell xlate.
Changes since v5:
1. add line request number and use two cell xlate
device tree bindings
This patch adds a watchdog driver for the main hardware watchdog timer
found on MOXA ART SoCs.
The MOXA ART SoC provides one writable timer register, restarting
the hardware once it reaches zero. The register is auto decremented
every APB clock cycle.
Signed-off-by: Jonas Jensen
---
Notes
Hi Mark,
Thanks for the replies.
On 2 August 2013 13:41, Mark Rutland wrote:
> It would be nice to have a fuller description here.
I have tried to elaborate the commit message, please point out if it
should be formatted differently.
>> +Example:
>> +
>> + watchdog: watchdog@9850 {
>> +
driver or client application.
Signed-off-by: Jonas Jensen
---
Notes:
Thanks for the replies.
Changes since v6:
1. move callback from interrupt context to tasklet
2. remove callback and callback_param, use those provided by tx_desc
3. don't rely on structs for reg
driver or client application.
Signed-off-by: Jonas Jensen
---
Notes:
Add test dummy DMA channels to MMC, prove the controller
has support for interchangeable channel numbers [0].
Add new filter data struct, store dma_spec passed in xlate,
similar to proposed patch for omap/edma
Add SDHCI driver for MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
Changes since v3:
1. don't rely on structs for register offsets
2. use DT probed DMA, remove extern bool moxart_filter_fn()
3. remove unnecessary ternary operator in moxart_get_ro
4. check r
Hi Mark,
On 2 August 2013 11:35, Mark Rutland wrote:
>> The MOXA ART irqchip driver was added without accompanying devicetree
>> document.
>> ( in next-20130716 drivers/irqchip/irq-moxart.c )
>
> Aaargh. That should not have happened >:(
Sorry about this, my plan was to submit all doc
et/moxa/moxart_ether.c
new file mode 100644
index 000..e1aa0f0
--- /dev/null
+++ b/drivers/net/ethernet/moxa/moxart_ether.c
@@ -0,0 +1,559 @@
+/* MOXA ART Ethernet (RTL8201CP) driver.
+ *
+ * Copyright (C) 2013 Jonas Jensen
+ *
+ * Jonas Jensen
+ *
+ * Based on code from
+ * Moxa Technology Co., Ltd.
+ *
+ *
On 18 July 2013 13:02, Mark Rutland wrote:
> Ok. I'm just concerned that the linkage isn't explicit or obvious.
> This does leave apb-clock completely dependent on core-clock, and unless
> I've missed something there's no linkage between the two described in
> the dt.
I can add a description in
On 18 July 2013 15:56, Mark Rutland wrote:
> When you say look up the apb-clock node, I assume they find it via their
> clocks property with of_clk_get or similar, rather than scanning the
> tree for a "moxart,moxa-apb-clock" node specifically?
Yes, all use of_clk_get(node, 0), which is fortunate
This patch adds MOXA ART SoCs clock driver support.
Signed-off-by: Jonas Jensen
---
Notes:
Changes since v3:
1. remove apb-clock
2. read clock-output-names of property
3. update device tree bindings document
Applies to next-20130716
.../bindings/clock/moxa,moxart
This patch adds MOXA ART SoCs clock driver support.
Signed-off-by: Jonas Jensen
---
Notes:
Changes since v4:
1. remove unnecessary header includes
Applies to next-20130716
.../bindings/clock/moxa,moxart-core-clock.txt | 23
drivers/clk/Makefile
Add watchdog driver for MOXA ART SoCs.
Signed-off-by: Jonas Jensen
---
Notes:
v4 should fix remaining issues pointed out by Guenter.
Changes since v3:
1. remove unnecessary header includes:
linux/of.h
linux/of_address.h
linux/err.h
linux/init.h
Update device tree bindings document with the correct clock name.
Signed-off-by: Jonas Jensen
---
Notes:
Hi Daniel,
I apologize in advance if this causes trouble..
One of the device tree bindings files you merged
git://git.linaro.org/people/dlezcano/clockevents.git
On 19 July 2013 14:16, Daniel Lezcano wrote:
> Ok, pushed.
Thanks :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://w
I think this driver may have a bug.
After some time running ping successfully, the message "no TX space
for packet" is printed resulting in 100% packet loss.
The message is printed from .ndo_start_xmit and I think it may be
because of how priv->tx_desc_now is now set up in
moxart_mac_setup_desc_r
1 - 100 of 208 matches
Mail list logo
