Re: general protection fault in sctp_ulpevent_notify_peer_addr_change

2020-08-12 Thread Jonas Falkevik
On Mon, Aug 10, 2020 at 8:31 PM Marcelo Ricardo Leitner wrote: > > On Mon, Aug 10, 2020 at 08:37:18AM -0700, syzbot wrote: > > Hello, > > > > syzbot found the following issue on: > > > > HEAD commit:fffe3ae0 Merge tag 'for-linus-hmm' of git://git.kernel.org.. > > git tree: upstream > > c

[PATCH v2] sctp: check assoc before SCTP_ADDR_{MADE_PRIM,ADDED} event

2020-05-27 Thread Jonas Falkevik
or return to service of the reachability of an endpoint via a specific transport address). Signed-off-by: Jonas Falkevik --- Changes in v2: - Check asoc state to be at least established. Instead of associd being SCTP_FUTURE_ASSOC. - Common check for all peer addr change event net/sctp

[PATCH] sctp: fix typo sctp_ulpevent_nofity_peer_addr_change

2020-05-27 Thread Jonas Falkevik
change typo in function name "nofity" to "notify" sctp_ulpevent_nofity_peer_addr_change -> sctp_ulpevent_notify_peer_addr_change Signed-off-by: Jonas Falkevik --- include/net/sctp/ulpevent.h | 2 +- net/sctp/associola.c| 8 net/sctp/ulpevent.c | 2

Re: [PATCH] sctp: check assoc before SCTP_ADDR_{MADE_PRIM,ADDED} event

2020-05-25 Thread Jonas Falkevik
On Mon, May 25, 2020 at 6:10 PM Xin Long wrote: > > On Mon, May 25, 2020 at 9:10 PM Marcelo Ricardo Leitner > wrote: > > > > On Mon, May 25, 2020 at 04:42:16PM +0800, Xin Long wrote: > > > On Sat, May 23, 2020 at 8:04 PM Jonas Falkevik > > > wrote: > &

[PATCH] sctp: check assoc before SCTP_ADDR_{MADE_PRIM,ADDED} event

2020-05-13 Thread Jonas Falkevik
service of the reachability of an endpoint via a specific transport address). Signed-off-by: Jonas Falkevik --- net/sctp/associola.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/net/sctp/associola.c b/net/sctp/associola.c index 437079a4883d..0c5dd295f9b8 100644

Re: [PATCH] sctp: check assoc before SCTP_ADDR_{MADE_PRIM,ADDED} event

2020-05-13 Thread Jonas Falkevik
On Wed, May 13, 2020 at 6:01 PM Marcelo Ricardo Leitner wrote: > > On Wed, May 13, 2020 at 04:52:16PM +0200, Jonas Falkevik wrote: > > Do not generate SCTP_ADDR_{MADE_PRIM,ADDED} events for SCTP_FUTURE_ASSOC > > assocs. > > How did you get them? > I think one case i

Re: [PATCH] sctp: check assoc before SCTP_ADDR_{MADE_PRIM,ADDED} event

2020-05-23 Thread Jonas Falkevik
On Tue, May 19, 2020 at 10:42 PM Marcelo Ricardo Leitner wrote: > > On Fri, May 15, 2020 at 10:30:29AM +0200, Jonas Falkevik wrote: > > On Wed, May 13, 2020 at 11:32 PM Marcelo Ricardo Leitner > > wrote: > > > > > > On Wed, May 13, 2020 at 10:11:05PM +0200,

Re: [PATCH] sctp: check assoc before SCTP_ADDR_{MADE_PRIM,ADDED} event

2020-05-15 Thread Jonas Falkevik
On Wed, May 13, 2020 at 11:32 PM Marcelo Ricardo Leitner wrote: > > On Wed, May 13, 2020 at 10:11:05PM +0200, Jonas Falkevik wrote: > > On Wed, May 13, 2020 at 6:01 PM Marcelo Ricardo Leitner > > wrote: > > > > > > On Wed, May 13, 2020 at 04:52:16PM +0200,