Re: [PATCH v3] PCI: Document PCIE BUS MPS parameters

2013-01-28 Thread Jon Mason
meters pcie_bus_tune_off, pcie_bus_safe, > pcie_bus_peer2peer, pcie_bus_perf into Documentation/kernel-parameters.txt. > These parameters were introduced by Jon Mason at > commit 5f39e6705 and commit b03e7495a8. > > Signed-off-by: Yijing Wang > --- > Documentation/kernel-parameters.txt

Re: [PATCH v3] PCI: Document PCIE BUS MPS parameters

2013-01-29 Thread Jon Mason
On Mon, Jan 28, 2013 at 11:09 PM, Yijing Wang wrote: > On 2013/1/29 13:00, Jon Mason wrote: >> On Fri, Jan 25, 2013 at 2:36 AM, Yijing Wang wrote: >>> v0->v1: Update MPS parameters as non-arch and add MRRS >>> description into pci

Re: [patch] NTB: fix pointer math issues

2013-01-27 Thread Jon Mason
On Wed, Jan 23, 2013 at 10:26:05PM +0300, Dan Carpenter wrote: > ->remote_rx_info and ->rx_info are struct ntb_rx_info pointers. If we > add sizeof(struct ntb_rx_info) then it goes too far. Good catch, I'll add it to me pending patch queue. Thanks, Jon > > Signed-off-by: Dan Carpenter > --- >

[PATCH 2/2] net: Add support for NTB virtual ethernet device

2012-10-02 Thread Jon Mason
A virtual ethernet device that uses the NTB transport API to send/receive data. Signed-off-by: Jon Mason --- drivers/net/Kconfig |4 + drivers/net/Makefile |1 + drivers/net/ntb_netdev.c | 407 ++ 3 files changed, 412 insertions

[PATCH 0/2] PCI-Express Non-Transparent Bridge Support

2012-10-02 Thread Jon Mason
I am submitting version 4 of the PCI-Express Non-Transparent Bridge patches for inclusion in 3.7. All outstanding issues from the RFC process have been addressed. version 1 http://thread.gmane.org/gmane.linux.kernel.pci/16443 Version 2 incorporates numerous clean-ups http://thread.gmane.org/gma

Re: [PATCH] vxge: Declare MODULE_FIRMWARE usage

2012-07-26 Thread Jon Mason
On Thu, Jul 26, 2012 at 12:08 PM, Tim Gardner wrote: > Cc: Jon Mason > Cc: "David S. Miller" > Cc: Joe Perches > Cc: Jiri Pirko > Cc: Stephen Hemminger > Cc: Paul Gortmaker > Cc: net...@vger.kernel.org > Signed-off-by: Tim Gardner > --- > driver

[RFC v2 0/2] PCI-Express Non-Transparent Bridge Support

2012-07-29 Thread Jon Mason
Version 2 of the patch that adds support for PCI-Express Non-Transparent Bridges in Linux. This version incorporates the changes suggested by Stephen Hemminger Greg KH chetan loke Jiri Pirko Thanks, Jon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body o

[RFC v2 2/2] net: Add support for NTB virtual ethernet device

2012-07-29 Thread Jon Mason
A virtual ethernet device that uses the NTB transport API to send/receive data. Signed-off-by: Jon Mason --- drivers/net/Kconfig |4 + drivers/net/Makefile |1 + drivers/net/ntb_netdev.c | 417 ++ 3 files changed, 422 insertions

Re: [RFC v2 1/2] PCI-Express Non-Transparent Bridge Support

2012-07-30 Thread Jon Mason
On Mon, Jul 30, 2012 at 10:50:13AM -0600, Bjorn Helgaas wrote: > On Sun, Jul 29, 2012 at 6:26 PM, Jon Mason wrote: > > A PCI-Express non-transparent bridge (NTB) is a point-to-point PCIe bus > > connecting 2 systems, providing electrical isolation between the two > >

Re: [RFC v2 2/2] net: Add support for NTB virtual ethernet device

2012-07-30 Thread Jon Mason
On Mon, Jul 30, 2012 at 04:02:16PM +0200, Jiri Pirko wrote: > Mon, Jul 30, 2012 at 02:26:34AM CEST, jon.ma...@intel.com wrote: > >+static int __devinit ntb_netdev_probe(struct pci_dev *pdev) > >+{ > >+struct net_device *ndev; > >+struct ntb_netdev *dev; > >+int rc; > >+ > >+ndev = a

Re: [RFC v2 1/2] PCI-Express Non-Transparent Bridge Support

2012-07-31 Thread Jon Mason
On Tue, Jul 31, 2012 at 11:35:33AM +0800, Jianbin Kang wrote: > > I've tried to make it all generic enough that non-Intel NTBs should plug in > > with > > minimal changes to ntb_hw.c. If their design is too divergent, then a > > slight > > redesign of ntb_hw.c might be necessary. But from what

Re: [RFC v2 1/2] PCI-Express Non-Transparent Bridge Support

2012-07-31 Thread Jon Mason
On Tue, Jul 31, 2012 at 07:45:29AM -0600, Bjorn Helgaas wrote: > On Mon, Jul 30, 2012 at 12:15 PM, Jon Mason wrote: > > On Mon, Jul 30, 2012 at 10:50:13AM -0600, Bjorn Helgaas wrote: > >> On Sun, Jul 29, 2012 at 6:26 PM, Jon Mason wrote: > >> > A PCI-Express non

Re: [RFC v2 1/2] PCI-Express Non-Transparent Bridge Support

2012-07-31 Thread Jon Mason
On Tue, Jul 31, 2012 at 12:02:20PM -0400, chetan loke wrote: > On Tue, Jul 31, 2012 at 9:45 AM, Bjorn Helgaas wrote: > > On Mon, Jul 30, 2012 at 12:15 PM, Jon Mason wrote: > >> > >> I've tried to make it all generic enough that non-Intel NTBs should plug >

Re: [RFC v2 1/2] PCI-Express Non-Transparent Bridge Support

2012-07-31 Thread Jon Mason
On Tue, Jul 31, 2012 at 03:23:38PM -0700, Greg KH wrote: > On Sun, Jul 29, 2012 at 05:26:33PM -0700, Jon Mason wrote: > > + * You should have received a copy of the GNU General Public License > > + * along with this program; if not, write to the Free Software > > + *

[RFC v3 0/2] PCI-Express Non-Transparent Bridge Support

2012-09-21 Thread Jon Mason
Version 3 of the patch that adds support for PCI-Express Non-Transparent Bridges in Linux. This version incorporates changes to conform NTB and client devices to the Linux device model (per Greg KH's request). Thanks, Jon -- To unsubscribe from this list: send the line "unsubscribe linux-kern

[RFC v3 2/2] net: Add support for NTB virtual ethernet device

2012-09-21 Thread Jon Mason
A virtual ethernet device that uses the NTB transport API to send/receive data. Signed-off-by: Jon Mason --- drivers/net/Kconfig |4 + drivers/net/Makefile |1 + drivers/net/ntb_netdev.c | 407 ++ 3 files changed, 412 insertions

Re: [RFC v3 1/2] PCI-Express Non-Transparent Bridge Support

2012-09-21 Thread Jon Mason
On Fri, Sep 21, 2012 at 02:14:47PM -0400, David Miller wrote: > From: Jon Mason > Date: Fri, 21 Sep 2012 11:09:48 -0700 > > > A PCI-Express non-transparent bridge (NTB) is a point-to-point PCIe bus > > connecting 2 systems, providing electrical isolation between the two

Re: [PATCH RFC 77/77] vxge: Update MSI/MSI-X interrupts enablement code

2013-10-02 Thread Jon Mason
On Wed, Oct 02, 2013 at 12:49:33PM +0200, Alexander Gordeev wrote: > As result of recent re-design of the MSI/MSI-X interrupts enabling > pattern this driver has to be updated to use the new technique to > obtain a optimal number of MSI/MSI-X interrupts required. > > Signed-off-by: Alexander Gorde

Re: [PATCH RFC 01/77] PCI/MSI: Fix return value when populate_msi_sysfs() failed

2013-10-02 Thread Jon Mason
On Wed, Oct 02, 2013 at 12:48:17PM +0200, Alexander Gordeev wrote: > Signed-off-by: Alexander Gordeev Since you are changing the behavior of the msix_capability_init function on populate_msi_sysfs error, a comment describing why in this commit would be nice. > --- > drivers/pci/msi.c | 11 +++

Re: [PATCH RFC 54/77] ntb: Ensure number of MSIs on SNB is enough for the link interrupt

2013-10-02 Thread Jon Mason
On Wed, Oct 02, 2013 at 12:49:10PM +0200, Alexander Gordeev wrote: > Signed-off-by: Alexander Gordeev > --- > drivers/ntb/ntb_hw.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/ntb/ntb_hw.c b/drivers/ntb/ntb_hw.c > index de2062c..eccd5e5 100644 > --- a/dr

Re: [PATCH RFC 53/77] ntb: Fix missed call to pci_enable_msix()

2013-10-02 Thread Jon Mason
On Wed, Oct 02, 2013 at 12:49:09PM +0200, Alexander Gordeev wrote: > Current MSI-X enablement code assumes MSI-Xs were successfully > allocated in case less than requested vectors were available. > That assumption is wrong, since MSI-Xs should be enabled with > a repeated call to pci_enable_msix().

Re: [PATCH RFC 55/77] ntb: Update MSI/MSI-X interrupts enablement code

2013-10-02 Thread Jon Mason
On Wed, Oct 02, 2013 at 12:49:11PM +0200, Alexander Gordeev wrote: > As result of recent re-design of the MSI/MSI-X interrupts enabling > pattern this driver has to be updated to use the new technique to > obtain a optimal number of MSI/MSI-X interrupts required. > > Signed-off-by: Alexander Gorde

Re: [PATCH RFC 01/77] PCI/MSI: Fix return value when populate_msi_sysfs() failed

2013-10-03 Thread Jon Mason
On Thu, Oct 03, 2013 at 10:46:21PM +0100, Ben Hutchings wrote: > On Wed, 2013-10-02 at 17:39 -0700, Jon Mason wrote: > > On Wed, Oct 02, 2013 at 12:48:17PM +0200, Alexander Gordeev wrote: > > > Signed-off-by: Alexander Gordeev > > > > Since you ar

[GIT PULL] NTB bug fixes and features for v3.12

2013-09-05 Thread Jon Mason
location. Jon Mason (16): NTB: Add Error Handling in ntb_device_setup NTB: Correct Number of Scratch Pad Registers NTB: Correct USD/DSD Identification NTB: Correct debugfs to work with more than 1 NTB Device

Re: [PATCH v2 1/6] scsi/bfa: use pcie_set/get_readrq to simplify code

2013-09-06 Thread Jon Mason
On Thu, Sep 5, 2013 at 12:55 AM, Yijing Wang wrote: > v1->v2: use pcie_get/set_readrq to simplify code > a lot suggestd by Bjorn. > > Use pcie_get_readrq()/pcie_set_readrq() to simplify > code. Very similar to a patch I sent out in 2011 http://www.spinics.net/lists/linux-scsi/msg52990.html Hopef

Re: linux-next: Tree for Sep 9 (ntb)

2013-09-09 Thread Jon Mason
On Mon, Sep 09, 2013 at 11:12:51AM -0700, Randy Dunlap wrote: > On 09/08/13 23:16, Stephen Rothwell wrote: > > Hi all, > > > > Please do not add any code for v3.13 to your linux-next included branches > > until after v3.12-rc1 is released. > > > > Changes since 20130906: > > > > > on x86_64: >

[PATCH] dmadevices: dma_sync_wait and dma_find_channel undefined

2013-09-09 Thread Jon Mason
nctions if CONFIG_DMA_ENGINE is undefined. Signed-off-by: Jon Mason --- include/linux/dmaengine.h | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h index cb286b1..cd4d1ca 100644 --- a/include/linux/dmaengine.h +++ b/inc

Re: [PATCH RFC 54/77] ntb: Ensure number of MSIs on SNB is enough for the link interrupt

2013-10-07 Thread Jon Mason
On Sat, Oct 05, 2013 at 11:43:04PM +0200, Alexander Gordeev wrote: > On Wed, Oct 02, 2013 at 05:48:05PM -0700, Jon Mason wrote: > > On Wed, Oct 02, 2013 at 12:49:10PM +0200, Alexander Gordeev wrote: > > > Signed-off-by: Alexander Gordeev > > > --- > > > dri

Re: [PATCH RFC 54/77] ntb: Ensure number of MSIs on SNB is enough for the link interrupt

2013-10-07 Thread Jon Mason
On Mon, Oct 07, 2013 at 08:38:45PM +0200, Alexander Gordeev wrote: > On Mon, Oct 07, 2013 at 09:50:57AM -0700, Jon Mason wrote: > > On Sat, Oct 05, 2013 at 11:43:04PM +0200, Alexander Gordeev wrote: > > > On Wed, Oct 02, 2013 at 05:48:05PM -0700, Jon Mason wrote: > > > &

[RESEND PATCH] ioat: PM Support

2013-09-25 Thread Jon Mason
/documents/specification-updates/xeon-c5500-c3500-spec-update.pdf See BT92 in http://www.intel.com/content/dam/www/public/us/en/documents/specification-updates/xeon-e5-family-spec-update.pdf Tested-by: Gary Hade Signed-off-by: Jon Mason --- drivers/dma/ioat/dma.c|1 + drivers/dma/ioat

Re: [1/2] PCI-Express Non-Transparent Bridge Support

2012-10-10 Thread Jon Mason
On Sun, Oct 07, 2012 at 02:13:44PM +0200, Jakub Kicinski wrote: > Hi, > > it's good to see some NTB code getting into mainline! I have a few comments > though. > > On Tue, 02 Oct 2012 21:26:16 -, Jon Mason > wrote: > > [...] > >+/** > >+ * ntb

[PATCH v5 0/2] PCI-Express Non-Transparent Bridge Support

2012-11-05 Thread Jon Mason
I am submitting version 5 of the PCI-Express Non-Transparent Bridge patches for inclusion in 3.8 via Greg KH's char-misc-next tree. All outstanding issues have been addressed. Version 1 http://thread.gmane.org/gmane.linux.kernel.pci/16443 Version 2 incorporates numerous clean-ups http://thread.g

[PATCH v5 2/2] net: Add support for NTB virtual ethernet device

2012-11-05 Thread Jon Mason
A virtual ethernet device that uses the NTB transport API to send/receive data. Signed-off-by: Jon Mason Reviewed-by: Nicholas Bellinger --- MAINTAINERS |1 + drivers/net/Kconfig |4 + drivers/net/Makefile |1 + drivers/net/ntb_netdev.c | 415

Re: scsi target, likely GPL violation

2012-11-07 Thread Jon Mason
On Wed, Nov 7, 2012 at 9:50 AM, Andy Grover wrote: > Nick, > > Your company appears to be shipping kernel features in RTS OS that are > not made available under the GPL, specifically support for the > EXTENDED_COPY and COMPARE_AND_WRITE SCSI commands, in order to claim > full Vmware vSphere 5 VAAI

Re: [PATCH] dmaengine/dmatest: terminate transfers only in case of errors

2012-11-09 Thread Jon Mason
On Fri, Nov 09, 2012 at 06:44:18PM +, Dan Williams wrote: > > > On 11/9/12 7:26 AM, "Viresh Kumar" wrote: > > >From: Shiraz Hashim > > > >dmatest erroneously terminated transfers in normal cases also leading to > >test failures for multiple threads over a channel. Fix this and > >terminate

[PATCH] dmatest: Fix NULL pointer dereference on ioat

2012-11-09 Thread Jon Mason
checking for a non-existant device_control function pointer there. Signed-off-by: Jon Mason CC: Vinod Koul CC: Dan Williams --- drivers/dma/dmatest.c |4 ++-- include/linux/dmaengine.h |5 - 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/dma/dmatest.c b

Re: [PATCH] dmatest: Fix NULL pointer dereference on ioat

2012-11-11 Thread Jon Mason
On Sat, Nov 10, 2012 at 09:00:15AM +0530, viresh kumar wrote: > On Sat, Nov 10, 2012 at 2:27 AM, Jon Mason wrote: > > device_control is an optional and not implemented in all DMA drivers. > > Any calls to these will result in a NULL pointer dereference. dmatest > > makes tw

[PATCH v2] dmatest: Fix NULL pointer dereference on ioat

2012-11-11 Thread Jon Mason
checking for a non-existant device_control function pointer there. Signed-off-by: Jon Mason CC: Vinod Koul CC: Dan Williams --- drivers/dma/dmatest.c |4 ++-- include/linux/dmaengine.h |5 - 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/dma/dmatest.c b

Re: [PATCH v5 1/2] PCI-Express Non-Transparent Bridge Support

2012-11-15 Thread Jon Mason
On Thu, Nov 15, 2012 at 04:29:04PM -0800, Greg KH wrote: > On Mon, Nov 05, 2012 at 05:11:08PM -0700, Jon Mason wrote: > > --- /dev/null > > +++ b/drivers/ntb/ntb_hw.h > > @@ -0,0 +1,195 @@ > > +/* > > + * This file is provided under a dual BSD/GPLv2 license. When

Re: [PATCH v5 2/2] net: Add support for NTB virtual ethernet device

2012-11-15 Thread Jon Mason
On Thu, Nov 15, 2012 at 04:30:43PM -0800, Greg KH wrote: > On Mon, Nov 05, 2012 at 05:11:09PM -0700, Jon Mason wrote: > > A virtual ethernet device that uses the NTB transport API to > > send/receive data. > > > > Signed-off-by: Jon Mason > >

[PATCH v6 0/2] PCI-Express Non-Transparent Bridge Support

2012-11-16 Thread Jon Mason
I am submitting version 6 of the PCI-Express Non-Transparent Bridge patches for inclusion in 3.8 via Greg KH's char-misc-next tree. All outstanding issues have been addressed. Version 6 corrects Greg KH's issues, most notably the improper usage of the Linux device model. http://thread.gmane.org/g

[PATCH v6 2/2] net: Add support for NTB virtual ethernet device

2012-11-16 Thread Jon Mason
A virtual ethernet device that uses the NTB transport API to send/receive data. Signed-off-by: Jon Mason Reviewed-by: Nicholas Bellinger --- MAINTAINERS |1 + drivers/net/Kconfig |4 + drivers/net/Makefile |1 + drivers/net/ntb_netdev.c | 419

Re: [PATCH] dmatest: masking tests for channel capabilities

2013-06-17 Thread Jon Mason
On Mon, Jun 17, 2013 at 11:59:00AM +0300, Andy Shevchenko wrote: > On Thu, Jun 13, 2013 at 8:24 PM, Jubin Mehta wrote: > > The current dmatest module tests all the hardware capabilities (MEMCPY, XOR > > and PQ) supported by a particular DMA channel and these tests are performed > > concurrently by

[PATCH 0/2] DMA Offload fixes

2013-06-18 Thread Jon Mason
These 2 patches address issues encountered while attempting to use the DMA subsystem in the NTB driver. While outside of the scope of that patch (which will be forthcoming), these fixes are necessary to get it working. Thanks, Jon -- To unsubscribe from this list: send the line "unsubscribe linu

[PATCH 1/2] dmadevices: dma_sync_wait undefined

2013-06-18 Thread Jon Mason
unction if CONFIG_DMA_ENGINE is undefined. Signed-off-by: Jon Mason Acked-by: Dave Jiang --- include/linux/dmaengine.h |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h index 96d3e4a..e3652ac 100644 --- a/inc

[PATCH 2/2] ioatdma: add DMA_PRIVATE capabilities flag

2013-06-18 Thread Jon Mason
Set the DMA_PRIVATE dma_transaction_type in the capability mask. This enables the ability to get an exclusive ioatdma DMA channel for any devices that requests one via the dma_request_channel function call. Signed-off-by: Jon Mason Acked-by: Dave Jiang --- drivers/dma/ioat/dma_v3.c |1

Re: [PATCH 1/2] dmadevices: dma_sync_wait undefined

2013-06-19 Thread Jon Mason
On Tue, Jun 18, 2013 at 06:13:28PM -0700, Dan Williams wrote: > On Tue, Jun 18, 2013 at 5:46 PM, Jon Mason wrote: > > dma_sync_wait is declared regardless of whether CONFIG_DMA_ENGINE is > > enabled, but calling the function without CONFIG_DMA_ENGINE enabled > > results in th

Re: [PATCH 2/2] ioatdma: add DMA_PRIVATE capabilities flag

2013-06-19 Thread Jon Mason
On Tue, Jun 18, 2013 at 05:59:59PM -0700, Dan Williams wrote: > On Tue, Jun 18, 2013 at 5:46 PM, Jon Mason wrote: > > Set the DMA_PRIVATE dma_transaction_type in the capability mask. This > > enables the ability to get an exclusive ioatdma DMA channel for any > > devices

Re: [PATCH 2/2] ioatdma: add DMA_PRIVATE capabilities flag

2013-06-19 Thread Jon Mason
On Wed, Jun 19, 2013 at 11:56:38AM -0700, Dan Williams wrote: > On Wed, Jun 19, 2013 at 10:52 AM, Jon Mason wrote: > >> DMA_PRIVATE here keeps all channels private, so they couldn't be used > >> elsewhere, for example raid offload. Do you need a private allocation >

Re: [PATCH] dmatest: add ability to disable pq and xor

2013-06-03 Thread Jon Mason
On Fri, May 31, 2013 at 11:22:10AM +0300, Andy Shevchenko wrote: > On Fri, May 17, 2013 at 8:54 PM, Jon Mason wrote: > > dmatest would create a thread to stress XOR and PQ, if the capability is > > present in the hardware. Add the ability to disable XOR and PQ by > > disa

[RFC] NTB: Use DMA Engine to transmit and receive

2013-07-01 Thread Jon Mason
Allocate and use a DMA engine channel to transmit and receive data over NTB. If none is allocated, fall back to using the CPU to transfer data. Signed-off-by: Jon Mason --- drivers/ntb/ntb_hw.c| 19 ++- drivers/ntb/ntb_hw.h|1 + drivers/ntb/ntb_transport.c | 285

Re: [PATCH v2] dmatest: masking tests for channel capabilities

2013-06-26 Thread Jon Mason
On Fri, Jun 21, 2013 at 04:46:59PM -0700, Jubin Mehta wrote: > The current dmatest module tests all the hardware capabilities (MEMCPY, XOR > and PQ) supported by a particular DMA channel and these tests are performed > concurrently by default. This patch allows the user to enable or disable the > t

Re: [PATCH 1/2] dmadevices: dma_sync_wait undefined

2013-06-26 Thread Jon Mason
On Thu, Jun 20, 2013 at 02:20:30PM -0700, Dan Williams wrote: > On Wed, Jun 19, 2013 at 9:28 AM, Jon Mason wrote: > > On Tue, Jun 18, 2013 at 06:13:28PM -0700, Dan Williams wrote: > [..] > > NTB is currently using it to flush any pending DMAs. This is needed > > to allo

Re: [PATCH 2/2] ioatdma: add DMA_PRIVATE capabilities flag

2013-06-26 Thread Jon Mason
On Wed, Jun 19, 2013 at 01:44:08PM -0700, Dan Williams wrote: > On Wed, Jun 19, 2013 at 1:10 PM, Jon Mason wrote: > > On Wed, Jun 19, 2013 at 11:56:38AM -0700, Dan Williams wrote: > >> On Wed, Jun 19, 2013 at 10:52 AM, Jon Mason wrote: > >> >> DMA_PRIVATE here ke

Re: [PATCH 09/15] NTB: Use DMA Engine to Transmit and Receive

2013-08-19 Thread Jon Mason
On Mon, Aug 19, 2013 at 03:01:54AM -0700, Dan Williams wrote: > On Fri, Aug 2, 2013 at 10:35 AM, Jon Mason wrote: > > Allocate and use a DMA engine channel to transmit and receive data over > > NTB. If none is allocated, fall back to using the CPU to transfer data. > >

Re: [PATCH 09/15] NTB: Use DMA Engine to Transmit and Receive

2013-08-19 Thread Jon Mason
On Mon, Aug 19, 2013 at 11:36:13PM +, Dan Williams wrote: > > > On 8/19/13 1:37 PM, "Jon Mason" wrote: > > >On Mon, Aug 19, 2013 at 03:01:54AM -0700, Dan Williams wrote: > >> On Fri, Aug 2, 2013 at 10:35 AM, Jon Mason wrote: > >> > Allo

[PATCH v2] NTB: Use DMA Engine to Transmit and Receive

2013-08-19 Thread Jon Mason
Allocate and use a DMA engine channel to transmit and receive data over NTB. If none is allocated, fall back to using the CPU to transfer data. Cc: Dan Williams Cc: Vinod Koul Cc: Dave Jiang Signed-off-by: Jon Mason --- drivers/ntb/ntb_hw.c| 17 +++ drivers/ntb/ntb_hw.h

Re: ioatdma: add ioat_raid_enabled module parameter

2013-08-01 Thread Jon Mason
On Wed, Jul 31, 2013 at 03:14:07PM -0700, Jiang, Dave wrote: > I'm ok with enabling this for people that just want to use DMA and not > RAID. I might be crazy, but I'd be in favor of disabling the RAID offload by default on non-Atom platforms. Thanks, Jon > > Acked-by: Dave Jiang > > On Thu,

[PATCH 00/15] NTB: Bug Fixes and New Features

2013-08-02 Thread Jon Mason
A fairly major update for NTB. Numerous fixes and features being added, including adding support for NTB-RP and using DMA engines to transmit/receive data. Reviews are appreciated! Thanks, Jon MAINTAINERS |2 + drivers/ntb/Kconfig |2 +- drivers/ntb/ntb_hw.c

[PATCH 12/15] NTB: Remove References of non-B2B BWD HW

2013-08-02 Thread Jon Mason
NTB-RP is not a supported configuration on BWD hardware. Remove the code attempting to set it up. Signed-off-by: Jon Mason --- drivers/ntb/ntb_hw.c | 16 drivers/ntb/ntb_regs.h |1 - 2 files changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/ntb/ntb_hw.c b

[PATCH 07/15] NTB: Update Device IDs

2013-08-02 Thread Jon Mason
rface exposed to the remote system. Signed-off-by: Jon Mason --- drivers/ntb/ntb_hw.c | 29 - drivers/ntb/ntb_hw.h | 15 ++- 2 files changed, 30 insertions(+), 14 deletions(-) diff --git a/drivers/ntb/ntb_hw.c b/drivers/ntb/ntb_hw.c index d259d41..fc6b19d

[PATCH 13/15] NTB: Comment Fix

2013-08-02 Thread Jon Mason
Add "data" ntb_register_db_callback parameter description comment and correct poor spelling. Signed-off-by: Jon Mason --- drivers/ntb/ntb_hw.c|5 +++-- drivers/ntb/ntb_transport.c |6 +++--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/ntb/

[PATCH 03/15] NTB: Correct USD/DSD Identification

2013-08-02 Thread Jon Mason
Due to ambiguous documentation, the USD/DSD identification is backward when compared to the setting in BIOS. Correct the bits to match the BIOS setting. Signed-off-by: Jon Mason --- drivers/ntb/ntb_hw.c |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/ntb

[PATCH 05/15] NTB: Xeon Errata Workaround

2013-08-02 Thread Jon Mason
been added. See BF113 in http://www.intel.com/content/dam/www/public/us/en/documents/specification-updates/xeon-c5500-c3500-spec-update.pdf See BT119 in http://www.intel.com/content/dam/www/public/us/en/documents/specification-updates/xeon-e5-family-spec-update.pdf Signed-off-by: Jon Mason

[PATCH 10/15] NTB: Rename Variables for NTB-RP

2013-08-02 Thread Jon Mason
Many variable names in the NTB driver refer to the primary or secondary side. However, these variables will be used to access the reverse case when in NTB-RP mode. Make these names more generic in anticipation of NTB-RP support. Signed-off-by: Jon Mason --- drivers/ntb/ntb_hw.c| 83

[PATCH 09/15] NTB: Use DMA Engine to Transmit and Receive

2013-08-02 Thread Jon Mason
Allocate and use a DMA engine channel to transmit and receive data over NTB. If none is allocated, fall back to using the CPU to transfer data. Cc: Dan Williams Cc: Vinod Koul Cc: Dave Jiang Signed-off-by: Jon Mason --- drivers/ntb/ntb_hw.c| 17 +++ drivers/ntb/ntb_hw.h

[PATCH 11/15] NTB: NTB-RP support

2013-08-02 Thread Jon Mason
xeon_errata_workaround=0 modparm. However, this can cause the hang described in the errata. Signed-off-by: Jon Mason --- drivers/ntb/ntb_hw.c | 239 +--- drivers/ntb/ntb_regs.h |5 +- 2 files changed, 150 insertions(+), 94 deletions(-) diff --git a/drivers

[PATCH 02/15] NTB: Correct Number of Scratch Pad Registers

2013-08-02 Thread Jon Mason
The NTB Xeon hardware has 16 scratch pad registers and 16 back-to-back scratch pad registers. Correct the #define to represent this and update the variable names to reflect their usage. Signed-off-by: Jon Mason --- drivers/ntb/ntb_hw.c |2 +- drivers/ntb/ntb_regs.h |4 ++-- 2 files

[PATCH 08/15] NTB: Enable 32bit Support

2013-08-02 Thread Jon Mason
Correct the issues on NTB that prevented it from working on x86_32 and modify the Kconfig to allow it to be permitted to be used in that environment as well. Signed-off-by: Jon Mason --- drivers/ntb/Kconfig |2 +- drivers/ntb/ntb_hw.c |4 ++-- drivers/ntb/ntb_hw.h | 17

[PATCH 15/15] MAINTAINERS: Add Website and Git Tree for NTB

2013-08-02 Thread Jon Mason
Add website and git tree for the NTB entry in MAINTAINERS Signed-off-by: Jon Mason --- MAINTAINERS |2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ad7e322..821f468 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5741,6 +5741,8 @@ F:drivers/scsi

[PATCH 14/15] NTB: Update Version

2013-08-02 Thread Jon Mason
Update NTB version to 1.0 Signed-off-by: Jon Mason --- drivers/ntb/ntb_hw.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ntb/ntb_hw.c b/drivers/ntb/ntb_hw.c index 95603f8..9dd69d8 100644 --- a/drivers/ntb/ntb_hw.c +++ b/drivers/ntb/ntb_hw.c @@ -57,7 +57,7

[PATCH 01/15] NTB: Add Error Handling in ntb_device_setup

2013-08-02 Thread Jon Mason
round this issue, return if an error is encountered prior to attempting to write to the spci_cmd offset. Signed-off-by: Jon Mason --- drivers/ntb/ntb_hw.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/ntb/ntb_hw.c b/drivers/ntb/ntb_hw.c index 2dacd19..51

[PATCH 06/15] NTB: BWD Link Recovery

2013-08-02 Thread Jon Mason
. Signed-off-by: Jon Mason --- drivers/ntb/ntb_hw.c | 110 ++-- drivers/ntb/ntb_hw.h |5 +++ drivers/ntb/ntb_regs.h | 15 +++ 3 files changed, 127 insertions(+), 3 deletions(-) diff --git a/drivers/ntb/ntb_hw.c b/drivers/ntb/ntb_hw.c index

[PATCH 04/15] NTB: Correct debugfs to work with more than 1 NTB Device

2013-08-02 Thread Jon Mason
ed on cleanup). Correct this by creating a secondary directory of the PCI BDF for each device present, and nesting the previously existing information in those directories. Signed-off-by: Jon Mason --- drivers/ntb/ntb_hw.c| 27 +++ drivers/ntb/ntb_hw.h|

Re: ioatdma: add ioat_raid_enabled module parameter

2013-08-02 Thread Jon Mason
On Fri, Aug 02, 2013 at 04:57:44PM +, Dan Williams wrote: > > > On 8/2/13 12:34 AM, "Brice Goglin" wrote: > > >Le 01/08/2013 19:15, Jiang, Dave a écrit : > >> On Thu, 2013-08-01 at 10:11 -0700, Jon Mason wrote: > >>> On Wed, Jul 31, 2013 a

[PATCH] ioat: PM Support

2013-08-21 Thread Jon Mason
/documents/specification-updates/xeon-c5500-c3500-spec-update.pdf See BT92 in http://www.intel.com/content/dam/www/public/us/en/documents/specification-updates/xeon-e5-family-spec-update.pdf Tested-by: Gary Hade Signed-off-by: Jon Mason --- drivers/dma/ioat/dma.c|1 + drivers/dma/ioat

[PATCH] ioatdma: Fix compiler warning

2013-08-06 Thread Jon Mason
to the possibility of idx being negative, thus being outside the boulds of the array. Correct this by making idx an unsigned int. Signed-off-by: Jon Mason --- drivers/dma/ioat/dma_v3.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/ioat/dma_v3.c b/drivers

Re: [PATCH] ioatdma: Fix compiler warning

2013-08-06 Thread Jon Mason
On Tue, Aug 06, 2013 at 11:52:35PM +0200, Paul Bolle wrote: > On Tue, 2013-08-06 at 14:36 -0700, Jon Mason wrote: > > GCC v4.6.3 complains: > > drivers/dma/ioat/dma_v3.c: In function ‘__ioat3_prep_pq16_lock’: > > drivers/dma/ioat/dma_v3.c:264:11: warning: array subscript is be

Re: [PATCH 1/1] module: fix sprintf format specifier in param_get_byte()

2013-08-07 Thread Jon Mason
ac_template, byte, NULL, S_IRUGO); > drivers/ntb/ntb_transport.c:68:module_param(max_num_clients, byte, 0644); This shouldn't affect NTB negatively. Acked-by: Jon Mason > drivers/scsi/lpfc/lpfc_attr.c:4207:module_param(lpfc_prot_guard, byte, > S_IRUGO); > drivers/usb/atm/spe

Re: [PATCH 10/16] ntb: clean up unnecessary MSI/MSI-X capability find

2013-08-08 Thread Jon Mason
ci_find_capability(pci_dev, PCI_CAP_ID_MSI/MSIX). > Access to PCIe device config space again will consume more time. > > Signed-off-by: Yijing Wang > Cc: Jon Mason Acked-by: Jon Mason > Cc: linux-kernel@vger.kernel.org > --- > drivers/ntb/ntb_hw.c |7 +++ > 1 f

Re: [RFC PATCH v2 3/7] dmaengine: enhance dmaengine to support DMA device hotplug

2013-08-08 Thread Jon Mason
On Thu, Aug 8, 2013 at 3:59 AM, Wang, Rui Y wrote: > (resend adding cc list) The e-mail you are responding to is over a year old, but doesn't appear to have been accepted. I suppose late is better than never... Adding Dan Williams new e-mail address and Dave Jiang. Thanks, Jon > > Hi Jiang, >

Re: ioatdma: add ioat_raid_enabled module parameter

2013-08-12 Thread Jon Mason
On Fri, Aug 02, 2013 at 09:18:03PM +0200, Brice Goglin wrote: > Le 02/08/2013 19:47, Dan Williams a écrit : > > Yup, but should also fold in the deletions of the other is_xeon_cb32() > > alignment fixups further below. > > > > Actually all the alignment settings can be removed now. > > > > ...and t

[GIT PULL] NTB bug fixes for v3.10

2013-05-10 Thread Jon Mason
(2): ntb: off by one sanity checks NTB: fix pointer math issues Jon Mason (8): NTB: variable dereferenced before check NTB: Handle 64bit BAR sizes NTB: Link toggle memory leak NTB: reset tx_index on link toggle NTB: Correctly handle receive buffers of the

[PATCH 05/10] NTB: Link toggle memory leak

2013-05-06 Thread Jon Mason
trying to alloc a new one. Signed-off-by: Jon Mason --- drivers/ntb/ntb_transport.c | 32 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c index 79a3203..be416d6 100644 --- a/drivers/ntb

[PATCH 06/10] NTB: reset tx_index on link toggle

2013-05-06 Thread Jon Mason
If the NTB link toggles, the driver could stop receiving due to the tx_index not being set to 0 on the transmitting size on a link-up event. This is due to the driver expecting the incoming data to start at the beginning of the receive buffer and not at a random place. Signed-off-by: Jon Mason

[PATCH 10/10] NTB: Multiple NTB client fix

2013-05-06 Thread Jon Mason
Fix issue with adding multiple ntb client devices to the ntb virtual bus. Previously, multiple devices would be added with the same name, resulting in crashes. To get around this issue, add a unique number to the device when it is added. Signed-off-by: Jon Mason --- drivers/ntb

[PATCH 09/10] ntb_netdev: remove from list on exit

2013-05-06 Thread Jon Mason
The ntb_netdev device is not removed from the global list of devices upon device removal. If the device is re-added, the removal code would find the first instance and try to remove an already removed device. Signed-off-by: Jon Mason --- drivers/net/ntb_netdev.c |2 ++ 1 file changed, 2

[PATCH 02/10] ntb: off by one sanity checks

2013-05-06 Thread Jon Mason
From: Dan Carpenter These tests are off by one. If "mw" is equal to NTB_NUM_MW then we would go beyond the end of the ndev->mw[] array. Signed-off-by: Dan Carpenter Signed-off-by: Jon Mason --- drivers/ntb/ntb_hw.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH 04/10] NTB: Handle 64bit BAR sizes

2013-05-06 Thread Jon Mason
64bit BAR sizes are permissible with an NTB device. To support them various modifications and clean-ups were required, most significantly using 2 32bit scratch pad registers for each BAR. Also, modify the driver to allow more than 2 Memory Windows. Signed-off-by: Jon Mason --- drivers/ntb

[PATCH 08/10] NTB: memcpy lockup workaround

2013-05-06 Thread Jon Mason
The system will appear to lockup for long periods of time due to the NTB driver spending too much time in memcpy. Avoid this by reducing the number of packets that can be serviced on a given interrupt. Signed-off-by: Jon Mason --- drivers/ntb/ntb_transport.c | 11 --- 1 file changed

[PATCH 07/10] NTB: Correctly handle receive buffers of the minimal size

2013-05-06 Thread Jon Mason
The ring logic of the NTB receive buffer/transmit memory window requires there to be at least 2 payload sized allotments. For the minimal size case, split the buffer into two and set the transport_mtu to the appropriate size. Signed-off-by: Jon Mason --- drivers/ntb/ntb_transport.c |8

[PATCH 01/10] NTB: variable dereferenced before check

2013-05-06 Thread Jon Mason
Correct instances of variable dereferencing before checking its value on the functions exported to the client drivers. Also, add sanity checks for all exported functions. Reported-by: Dan Carpenter Signed-off-by: Jon Mason --- drivers/ntb/ntb_transport.c | 16 ++-- 1 file

[PATCH 0/10] NTB: Bug Fixes

2013-05-06 Thread Jon Mason
one sanity checks NTB: fix pointer math issues Jon Mason (8): NTB: variable dereferenced before check NTB: Handle 64bit BAR sizes NTB: Link toggle memory leak NTB: reset tx_index on link toggle NTB: Correctly handle receive buffers of the minimal size NTB

[PATCH 03/10] NTB: fix pointer math issues

2013-05-06 Thread Jon Mason
From: Dan Carpenter ->remote_rx_info and ->rx_info are struct ntb_rx_info pointers. If we add sizeof(struct ntb_rx_info) then it goes too far. Signed-off-by: Dan Carpenter Signed-off-by: Jon Mason --- drivers/ntb/ntb_transport.c |4 ++-- 1 file changed, 2 insertions(+), 2 del

Re: [GIT PULL] NTB bug fixes for v3.10

2013-05-16 Thread Jon Mason
On Sat, May 11, 2013 at 03:22:52PM -0700, Linus Torvalds wrote: > On Fri, May 10, 2013 at 6:30 PM, Jon Mason wrote: > > > > https://github.com/jonmason/ntb.git for-linus > > This has so much wrong that I don't know where to start. > > Don't use the https

[PATCH] ioat: device control support

2013-05-17 Thread Jon Mason
Add device control support for CBDMA v2 and v3 in the ioat driver. This allows DMA engine clients to call into the ioat driver and issue a DMA_TERMINATE_ALL. Signed-off-by: Jon Mason --- drivers/dma/ioat/dma_v2.c | 22 ++ drivers/dma/ioat/dma_v3.c | 22

[PATCH] dmatest: add ability to disable pq and xor

2013-05-17 Thread Jon Mason
dmatest would create a thread to stress XOR and PQ, if the capability is present in the hardware. Add the ability to disable XOR and PQ by disabling it if *_sources are set to zero. Signed-off-by: Jon Mason --- drivers/dma/dmatest.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Re: [PATCH 3.9-stable] ntb: off by one sanity checks

2013-05-18 Thread Jon Mason
> > These tests are off by one. If "mw" is equal to NTB_NUM_MW then we > would go beyond the end of the ndev->mw[] array. > > Signed-off-by: Dan Carpenter > Signed-off-by: Jon Mason > Signed-off-by: Jonghwan Choi > --- > drivers/ntb/ntb_hw.c | 6 ++

Re: [PATCH 3.9-table] NTB: Handle 64bit BAR sizes

2013-05-18 Thread Jon Mason
On Sat, May 18, 2013 at 11:41:56AM +0900, Jonghwan Choi wrote: > From: Jon Mason > > This patch looks like it should be in the 3.9-stable tree, should we apply > it? Yes, thanks. > > ------ > > From: "Jon Mason " > > commit 113fc505b

Re: [PATCH 3.9-table] NTB: Link toggle memory leak

2013-05-18 Thread Jon Mason
On Sat, May 18, 2013 at 11:44:51AM +0900, Jonghwan Choi wrote: > From: Jon Mason > > This patch looks like it should be in the 3.9-stable tree, should we apply > it? Yes, thanks. > > ------ > > From: "Jon Mason " > > commit b77b2637b

  1   2   3   4   5   6   7   8   >