[PATCH 0/6] keucr: checkpatch fixes

b) in .../keucr/transport.c, as suggested by checkpatch all in all we're on a good way to get clean here, by far the biggest part that is left is "externs should be avoided in .c files", those will need some more careful work. regards, laura lawniczak, johannes schillin

[PATCH 1/6] keucr: remove some unneccesary typedefs

resolves checkpatch.pl warning "do not add new typedefs" Signed-off-by: Laura Lawniczak Signed-off-by: Johannes Schilling --- drivers/staging/keucr/init.c |2 +- drivers/staging/keucr/smil.h | 16 drivers/staging/keucr/usb.c |4 ++-- drivers/staging/k

[PATCH 2/6] keucr: fix some camelCase warnings

resolves checkpatch warning "Avoid CamelCase" Signed-off-by: Laura Lawniczak Signed-off-by: Johannes Schilling --- drivers/staging/keucr/init.c |8 drivers/staging/keucr/init.h |8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/sta

[PATCH 4/6] keucr: make error messages less aggressive

here's a flower: ⚘. have a very happy day ☺ Signed-off-by: Laura Lawniczak Signed-off-by: Johannes Schilling --- drivers/staging/keucr/smilsub.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/keucr/smilsub.c b/drivers/staging/

[PATCH 6/6] keucr: use more specific max_t(int, ..

as advised by checkpatch, changed generic max(..) to max_t(int, .. Signed-off-by: Laura Lawniczak Signed-off-by: Johannes Schilling --- drivers/staging/keucr/transport.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/keucr/transport.c b/drivers

[PATCH 3/6] keucr: migrate printk to dev_dbg/info/warn/err

as per suggestion of checkpatch.pl; this resolves warnings like "Prefer netdev_info .. then dev_info .. to printk". Signed-off-by: Laura Lawniczak Signed-off-by: Johannes Schilling --- drivers/staging/keucr/init.c | 62 ++ drivers/sta

[PATCH 5/6] keucr: fix some alignment- and whitespace-problems

resolves checkpatch errors and warnings regarding whitespace around operators, line lengths and indentation. Signed-off-by: Laura Lawniczak Signed-off-by: Johannes Schilling --- drivers/staging/keucr/scsiglue.c |5 +- drivers/staging/keucr/smilmain.c | 122

[PATCH 0/6] keucr: checkpatch fixes

hi, did some improvement on our previous patch series, see the more detailed replies below. [PATCH 1/6] keucr: remove some unneccesary typedefs On Wed, Jun 05, 2013 at 12:25:02PM +0300, Dan Carpenter wrote: > On Wed, Jun 05, 2013 at 10:50:01AM +0200, Johannes Schilling wrote: > >

[PATCH 6/6] keucr: fix some alignment- and whitespace-problems

resolves checkpatch errors and warnings regarding whitespace around operators, line lengths and indentation. Signed-off-by: Laura Lawniczak Signed-off-by: Johannes Schilling --- drivers/staging/keucr/init.c | 24 +--- drivers/staging/keucr/scsiglue.c |5 +- drivers/staging

[PATCH 1/6] keucr: remove some unneccesary typedefs

resolves checkpatch.pl warning "do not add new typedefs" and renames allcaps structures. Signed-off-by: Laura Lawniczak Signed-off-by: Johannes Schilling --- drivers/staging/keucr/init.c|2 +- drivers/staging/keucr/smil.h| 28 ++-- drivers/sta

[PATCH 2/6] keucr: use more specific max_t(int, ..

as advised by checkpatch, changed generic max(..) to max_t(int, .. Signed-off-by: Laura Lawniczak Signed-off-by: Johannes Schilling --- drivers/staging/keucr/transport.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/keucr/transport.c b/drivers

[PATCH 5/6] keucr: moved function to other file

From: Laura Lawniczak Function usb_stor_print_cmd was declared in init.c but only used in transport.c. So it was reasonable to move it there and declare it static Signed-off-by: Laura Lawniczak --- drivers/staging/keucr/init.c | 51 - drivers/staging/

[PATCH 4/6] keucr: more readable and friendly error messages

From: Laura Lawniczak Signed-off-by: Laura Lawniczak Signed-off-by: Johannes Schilling --- drivers/staging/keucr/init.c| 13 + drivers/staging/keucr/smilsub.c | 21 ++--- 2 files changed, 23 insertions(+), 11 deletions(-) diff --git a/drivers/staging/keucr

[PATCH 3/6] keucr: migrate printk to dev_dbg/info/warn/err

From: Laura Lawniczak as per suggestion of checkpatch.pl; this resolves warnings like "Prefer netdev_info .. then dev_info .. to printk". Changed signature of function usb_stor_print_cmd in init.c to enable usage of dev_err Signed-off-by: Laura Lawniczak Signed-off-by: Johannes

[PATCH] keucr: removed unnecessary variables and comments

From: Laura Lawniczak blen and bn were only used in commented code fragments. since comments should be informative and not for storing old code, both, commented code and variables, were removed. Signed-off-by: Laura Lawniczak Signed-off-by: Johannes Schilling --- this one is against latest