before
> > invoking the force threaded handler which preserves the regular semantics
> > and the usefulness of the interrupt force threading as a general debugging
> > tool.
> >
> > For not RT this is not changing much, except that during the execution of
> > the thr
There's no need to clear the interface driver data on failed probe (and
driver core will clear it anyway).
Signed-off-by: Johan Hovold
---
drivers/usb/class/cdc-acm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index 36dd1e0
This series fixes a couple of bugs in the probe errors paths and does
some clean up in preparation for adding the missing error handling when
claiming the data interface.
The first two should probably go into 5.12-rc, while the rest could be
held off for 5.13 if preferred.
Johan
Johan Hovold
Use negation consistently throughout the driver for NULL checks.
Signed-off-by: Johan Hovold
---
drivers/usb/class/cdc-acm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index e3c45f5880fc..6991ffd66c5d 100644
The interface driver data has already been set by
usb_driver_claim_interface() so drop the redundant subsequent
assignment.
Signed-off-by: Johan Hovold
---
drivers/usb/class/cdc-acm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
error handling in acm_probe()")
Cc: sta...@vger.kernel.org # 3.9
Cc: Alexey Khoroshilov
Signed-off-by: Johan Hovold
---
drivers/usb/class/cdc-acm.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index d75a78ad464d..df
: cae2bc768d17 ("usb: cdc-acm: Decrement tty port's refcount if probe()
fail")
Cc: sta...@vger.kernel.org # 4.19
Cc: Jaejoong Kim
Signed-off-by: Johan Hovold
---
drivers/usb/class/cdc-acm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/class/cdc-acm.c b/driver
Make sure to always claim the data interface and bail out if it's
already bound to another driver or isn't authorised.
Signed-off-by: Johan Hovold
---
drivers/usb/class/cdc-acm.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/class/cdc-acm.c b/d
Name the probe error labels after what they do rather than using
sequence numbers which is harder to review and maintain (e.g. may
require renaming unrelated labels when a label is added or removed).
Signed-off-by: Johan Hovold
---
drivers/usb/class/cdc-acm.c | 35
It's been almost twenty years since USB drivers returned a data pointer
from their probe routines in order to bind to an interface.
Time to update the documentation for usb_driver_claim_interface().
Signed-off-by: Johan Hovold
---
drivers/usb/core/driver.c | 4
1 file changed, 4 dele
It's been almost twenty years since the interface "private data" pointer
was removed in favour of using the driver-data pointer of struct device.
Let's rename the driver-data parameter of usb_driver_claim_interface()
so that it better reflects how it's used.
Si
The driver data for the data interface has already been set by
usb_driver_claim_interface() so drop the subsequent redundant
assignment.
Signed-off-by: Johan Hovold
---
drivers/input/misc/ims-pcu.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/misc/ims-pcu.c b/drivers/input
ned-off-by: Johan Hovold
---
drivers/net/usb/cdc-phonet.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/usb/cdc-phonet.c b/drivers/net/usb/cdc-phonet.c
index 02e6bbb17b15..8d1f69dad603 100644
--- a/drivers/net/usb/cdc-phonet.c
+++ b/drivers/net/usb/cdc-phonet.c
@@ -387,6 +387,8 @@
The driver data for the data interface has already been set by
usb_driver_claim_interface() so drop the subsequent redundant
assignment.
Note that this also avoids setting the driver data three times in case
of a combined interface.
Signed-off-by: Johan Hovold
---
drivers/net/usb/cdc_ncm.c | 1
On Wed, Apr 07, 2021 at 01:25:00AM +0300, Andy Shevchenko wrote:
> On Tuesday, April 6, 2021, Pho Tran wrote:
> > Because CP2108 has 16 GPIO pins, the parameter passed by cp210x functions
> > will be different from other CP210x devices. So need to check part number
> > of the device to use correc
value when requesting an unavailable pin will now
be -EINVAL instead of -ENODEV.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/cp210x.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
Use the new GPIO valid-mask feature to inform gpiolib which pins are
available for use instead of handling that in a request callback.
This also allows user space to figure out which pins are available
through the chardev interface without having to request each pin in
turn.
Johan
Johan
Add a debug printk to dump the GPIO configuration stored in EEPROM
during probe.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/cp210x.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index ceb3a656a075..ee595d1bea0a
On Fri, Apr 09, 2021 at 07:22:26PM +0300, Andy Shevchenko wrote:
> On Fri, Apr 9, 2021 at 6:52 PM Johan Hovold wrote:
> >
> > Add a debug printk to dump the GPIO configuration stored in EEPROM
> > during probe.
> >
> > Signed-off-by: Johan Hovold
> > -
On Mon, Feb 22, 2021 at 04:27:34PM +0100, Mauro Carvalho Chehab wrote:
> Hi Johan,
>
> Em Tue, 26 Jan 2021 17:26:36 +0100
> Johan Hovold escreveu:
>
> > On Tue, Jan 26, 2021 at 09:16:04PM +0530, Manivannan Sadhasivam wrote:
> > > On Thu, Jan 21, 2021 at 11:19:
On Mon, Nov 16, 2020 at 02:31:02PM -0800, Davidlohr Bueso wrote:
> On Mon, 16 Nov 2020, Johan Hovold wrote:
>
> >On Fri, Nov 13, 2020 at 08:27:25PM -0800, Davidlohr Bueso wrote:
> >> @@ -1883,21 +1724,17 @@ static void mos7720_release(struct usb_serial
> >&g
On Tue, Nov 17, 2020 at 08:48:37AM -0800, Davidlohr Bueso wrote:
> The parallel port restore operation currently defers writes
> to a tasklet, if it sees a locked disconnect mutex. The
> driver goes to a lot of trouble to ensure writes happen
> in a non-blocking context, but things can be greatly
>
On Tue, Dec 08, 2020 at 11:33:11PM -0800, syzbot wrote:
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit:15ac8fdb Add linux-next specific files for 20201207
> git tree: linux-next
> console output: https://syzkaller.appspot.com/x/log.txt?x=17dc6adf50
> kernel config
Fixes: c3a65808f04a ("USB: serial: option: reimplement interface masking")
Cc: sta...@vger.kernel.org
Signed-off-by: Johan Hovold
---
drivers/usb/serial/option.c | 23 +--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/serial/option.c b/d
On Wed, Dec 09, 2020 at 05:29:17PM +0800, Zheng Yongjun wrote:
> Simplify the return expression.
>
> Signed-off-by: Zheng Yongjun
> ---
> drivers/usb/serial/ark3116.c | 13 -
> 1 file changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/usb/serial/ark3116.c b/drivers/us
On Wed, Dec 09, 2020 at 03:19:26AM +0100, Thomas Gleixner wrote:
> On Tue, Dec 08 2020 at 11:05, Johan Hovold wrote:
>
> > On Tue, Nov 24, 2020 at 02:42:47PM +0100, Johan Hovold wrote:
> >> Fix CPU devicetree-node lookups by implementing
> >> arch_match_cpu_phys_id()
On Wed, Dec 09, 2020 at 11:52:45AM +0100, Greg Kroah-Hartman wrote:
> On Wed, Dec 09, 2020 at 11:42:21AM +0100, Johan Hovold wrote:
> > Add an interface-number sanity check before testing the device flags to
> > avoid relying on undefined behaviour when left shifting in case a dev
On Wed, Dec 09, 2020 at 03:30:33PM +0100, Greg Kroah-Hartman wrote:
> On Wed, Dec 02, 2020 at 12:39:35PM +0100, Johan Hovold wrote:
> > This series adds a new NORDY port flag to suppress raising the
> > modem-control lines on open to signal DTE readiness.
> >
> > This
On Tue, Dec 08, 2020 at 01:41:52PM +0100, Linus Walleij wrote:
> On Tue, Dec 8, 2020 at 10:57 AM Johan Hovold wrote:
> > Well we started discussing this back when we only had the sysfs
> > interface which suffered from the same problem. I thought the chardev
> > interface wa
On Tue, Dec 08, 2020 at 06:22:50PM +0530, Manivannan Sadhasivam wrote:
> On Tue, Dec 08, 2020 at 01:41:52PM +0100, Linus Walleij wrote:
> > On Tue, Dec 8, 2020 at 10:57 AM Johan Hovold wrote:
> > I think if this driver already has unique line-names per-gpiochip
> > we c
On Wed, Dec 09, 2020 at 10:20:38AM +0100, Linus Walleij wrote:
> On Mon, Dec 7, 2020 at 4:48 PM Johan Hovold wrote:
> > On Mon, Dec 07, 2020 at 03:34:23PM +, Marc Zyngier wrote:
>
> > > If they claim that their lines are available, and then refuse to
> > > let
On Wed, Dec 09, 2020 at 10:35:53AM +0100, Linus Walleij wrote:
> On Mon, Dec 7, 2020 at 4:19 PM Johan Hovold wrote:
> > On Mon, Dec 07, 2020 at 03:00:37PM +, Marc Zyngier wrote:
> > > On 2020-12-07 14:29, Johan Hovold wrote:
> > > > On Fri, Dec 04, 2020 at 04:47:
On Wed, Dec 09, 2020 at 06:05:58PM +0100, Johan Hovold wrote:
> On Wed, Dec 09, 2020 at 10:35:53AM +0100, Linus Walleij wrote:
> > It sounds like we agree that this patch sans prints is acceptable.
> >
> > It makes things better so let's go with that.
>
> Soun
On Wed, Dec 09, 2020 at 05:18:21PM +0100, Linus Walleij wrote:
> If a GPIO line cannot be exported using a symbolic name from
> the .names array in the gpiochip, fall back to using the
> "gpioN" naming system instead of just failing.
>
> Cc: Manivannan Sadhasivam
> C
On Wed, Dec 09, 2020 at 05:25:32PM +0100, Linus Walleij wrote:
> On Wed, Dec 9, 2020 at 4:24 PM Johan Hovold wrote:
> > On Tue, Dec 08, 2020 at 01:41:52PM +0100, Linus Walleij wrote:
>
> > > depends on !GPIO_SYSFS
> > >
> > > so it can't even
On Thu, Dec 10, 2020 at 09:53:45AM +0100, Johan Hovold wrote:
> On Wed, Dec 09, 2020 at 05:25:32PM +0100, Linus Walleij wrote:
> > On Wed, Dec 9, 2020 at 4:24 PM Johan Hovold wrote:
> > > So it sounds like there's nothing preventing per-chip-unique names in
> > >
know.
Fixes: 4e07db9c8db8 ("x86/devicetree: Use CPU description from Device Tree")
Cc: stable # 4.17
Signed-off-by: Johan Hovold
---
Thomas,
Hope this looks better to you.
My use case for this is still out-of-tree, but since CPU-node lookup is
generic functionality and with observa
On Fri, Nov 20, 2020 at 09:26:53AM +0800, Tian Tao wrote:
> The code has been in a irq-disabled context since it is hard IRQ. There
> is no necessity to do it again.
>
> Signed-off-by: Tian Tao
> ---
> drivers/tty/serial/rda-uart.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
On Thu, Nov 19, 2020 at 05:01:29PM +0800, Tian Tao wrote:
> The code has been in a irq-disabled context since it is hard IRQ. There
> is no necessity to do it again.
>
> Signed-off-by: Tian Tao
> ---
> drivers/tty/serial/owl-uart.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
On Thu, Nov 19, 2020 at 08:53:00PM -0800, Davidlohr Bueso wrote:
> The parallel port restore operation currently defers writes
> to a tasklet, if it sees a locked disconnect mutex. The
> driver goes to a lot of trouble to ensure writes happen
> in a non-blocking context, but things can be greatly
>
On Fri, Nov 20, 2020 at 10:28:28AM +0100, vpala...@chromium.org wrote:
> From: Vincent Palatin
>
> Update the USB serial option driver support for the Fibocom NL668 Cat.4
> LTE modules as there are actually several different variants.
> Got clarifications from Fibocom, there are distinct products
On Fri, Nov 20, 2020 at 07:25:03PM +0800, tiantao (H) wrote:
> 在 2020/11/20 16:23, Johan Hovold 写道:
> > On Thu, Nov 19, 2020 at 05:01:29PM +0800, Tian Tao wrote:
> >> The code has been in a irq-disabled context since it is hard IRQ. There
> >> is no necessity to do it
.
Signed-off-by: Johan Hovold
---
Documentation/ABI/testing/sysfs-tty | 7 +++
drivers/tty/serial/serial_core.c| 29 +
2 files changed, 36 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-tty
b/Documentation/ABI/testing/sysfs-tty
index e157130a6792
.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/bus.c | 38 --
1 file changed, 36 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/serial/bus.c b/drivers/usb/serial/bus.c
index eb0195cf37dd..37bbeabe 100644
--- a/drivers/usb/serial/bus.c
+++ b/drivers
Johan
Johan Hovold (3):
tty: add port flag to suppress ready signalling on open
serial: core: add sysfs attribute to suppress ready signalling on open
USB: serial: add sysfs attribute to suppress ready signalling on open
Mychaela N. Falconia (2):
USB: serial: ftdi_sio: pass port to
7;s ADBUS2 and ADBUS4 outputs
actually being RTS and DTR rather than something else.
Signed-off-by: Mychaela N. Falconia
[johan: reimplement using new NORDY flag, trim quirk comment]
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ftdi_sio.c | 22 ++
drivers/usb/serial/f
27;s port_probe function needs
to figure out which channel of a multichannel device is currently
being considered, it needs access to the port pointer passed to the
ftdi_sio_port_probe() function, so it can traverse USB data structures
from there.
Signed-off-by: Mychaela N. Falconia
Signed-off-b
sysfs, which also allows
control over the lines on first open.
This can be use to prevent undesirable side-effects on open for
applications where the DTR and RTS lines are used for non-standard
purposes such as generating power-on and reset pulses.
Signed-off-by: Johan Hovold
---
drivers/tty
On Mon, Nov 30, 2020 at 08:27:54PM +0200, Andy Shevchenko wrote:
> On Mon, Nov 30, 2020 at 5:42 PM Johan Hovold wrote:
> >
> > Add a nordy sysfs attribute to suppress raising the modem-control lines
> > on open to signal DTE readiness.
>
> Why not call it nom
On Mon, Nov 30, 2020 at 01:22:07PM -0800, Mychaela Falconia wrote:
> Johan's patch comments say that the new flag can also be brought out
> to termios in the future, similarly to HUPCL, but I question the
> usefulness of doing so, as it is a chicken and egg problem: one needs
> to open the tty dev
On Tue, Dec 01, 2020 at 06:49:07AM +0100, Jiri Slaby wrote:
> On 30. 11. 20, 16:37, Johan Hovold wrote:
> > --- a/include/linux/tty.h
> > +++ b/include/linux/tty.h
> > @@ -683,6 +684,19 @@ static inline void tty_port_set_kopened(struct
> > tty_port *port, bool val
On Tue, Dec 01, 2020 at 07:54:10AM +0100, Jiri Slaby wrote:
> On 30. 11. 20, 16:37, Johan Hovold wrote:
> > --- a/drivers/usb/serial/ftdi_sio.c
> > +++ b/drivers/usb/serial/ftdi_sio.c
> ...
> > @@ -2386,6 +2393,21 @@ static int ftdi_stmclite_probe(struct usb_serial
>
On Tue, Dec 01, 2020 at 12:48:48PM +0200, Andy Shevchenko wrote:
> On Mon, Nov 30, 2020 at 11:25 PM Mychaela Falconia
> wrote:
> > > Why not call it nomctrl ?
> >
> > I have no opinion one way or another as to what the new sysfs attribute
> > should be called - my use case won't involve this sysf
On Tue, Dec 01, 2020 at 12:55:54PM +0200, Andy Shevchenko wrote:
> On Tue, Dec 1, 2020 at 10:20 AM Johan Hovold wrote:
> > On Mon, Nov 30, 2020 at 08:27:54PM +0200, Andy Shevchenko wrote:
> > > On Mon, Nov 30, 2020 at 5:42 PM Johan Hovold wrote:
>
> > > > +
in devicetree using their APIC ids and
that those do not generally coincide with the logical ids (e.g. used by
the default arch_match_cpu_phys_id() implementation).
Signed-off-by: Johan Hovold
---
arch/x86/kernel/apic/apic.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/x86/kernel
On Fri, Dec 04, 2020 at 10:13:50AM +0800, Wang Hai wrote:
> Add the missing unlock before return from function
> gbaudio_dapm_free_controls() in the error handling case.
>
> Fixes: 510e340efe0c ("staging: greybus: audio: Add helper APIs for dynamic
> audio module")
> Reported-by: Hulk Robot
> Si
Hi Himadri,
and sorry about the late feedback on this one. I'm still trying to dig
myself out of some backlog.
On Wed, Nov 04, 2020 at 12:16:48PM +0530, Himadri Pandya wrote:
> There are many usages of usb_control_msg() that can use the new wrapper
> functions usb_contro_msg_send() & usb_control_
On Wed, Nov 04, 2020 at 12:16:49PM +0530, Himadri Pandya wrote:
> The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps
> usb_control_msg() with proper error check. Hence use the wrappers
> instead of calling usb_control_msg() directly.
>
> Signed-off-by: Himadri Pandya
> ---
>
On Wed, Nov 04, 2020 at 12:16:50PM +0530, Himadri Pandya wrote:
> The new usb_control_msg_send() nicely wraps usb_control_msg() with
> proper error check. Hence use the wrapper instead of calling
> usb_control_msg() directly.
>
> Signed-off-by: Himadri Pandya
> ---
> drivers/usb/serial/belkin_sa
On Wed, Nov 04, 2020 at 12:16:51PM +0530, Himadri Pandya wrote:
> The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps
> usb_control_msg() with proper error check. Hence use the wrappers
> instead of calling usb_control_msg() directly.
>
> Signed-off-by: Himadri Pandya
> ---
>
On Wed, Nov 04, 2020 at 12:16:52PM +0530, Himadri Pandya wrote:
> The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps
> usb_control_msg() with proper error check. Hence use the wrappers
> instead of calling usb_control_msg() directly.
This too is a good example of when the new h
On Wed, Nov 04, 2020 at 12:16:53PM +0530, Himadri Pandya wrote:
> The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps
> usb_control_msg() with proper error check. Hence use the wrappers
> instead of calling usb_control_msg() directly.
>
> Signed-off-by: Himadri Pandya
> ---
>
On Wed, Nov 04, 2020 at 12:16:54PM +0530, Himadri Pandya wrote:
> The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps
> usb_control_msg() with proper error check. Hence use the wrappers
> instead of calling usb_control_msg() directly.
>
> Signed-off-by: Himadri Pandya
> ---
>
On Wed, Nov 04, 2020 at 12:16:55PM +0530, Himadri Pandya wrote:
> The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps
> usb_control_msg() with proper error check. Hence use the wrappers
> instead of calling usb_control_msg() directly.
>
> Signed-off-by: Himadri Pandya
> ---
>
On Wed, Nov 04, 2020 at 12:16:56PM +0530, Himadri Pandya wrote:
> The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps
> usb_control_msg() with proper error check. Hence use the wrappers
> instead of calling usb_control_msg() directly.
>
> Signed-off-by: Himadri Pandya
> ---
>
On Wed, Nov 04, 2020 at 12:16:57PM +0530, Himadri Pandya wrote:
> The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps
> usb_control_msg() with proper error check. Hence use the wrappers
> instead of calling usb_control_msg() directly.
>
> Signed-off-by: Himadri Pandya
> ---
>
On Wed, Nov 04, 2020 at 12:16:58PM +0530, Himadri Pandya wrote:
> The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps
> usb_control_msg() with proper error check. Hence use the wrappers
> instead of calling usb_control_msg() directly
>
> Signed-off-by: Himadri Pandya
> ---
> d
On Wed, Nov 04, 2020 at 12:16:59PM +0530, Himadri Pandya wrote:
> The new usb_control_msg_send() nicely wraps usb_control_msg() with proper
> error check. Hence use the wrapper instead of calling usb_control_msg()
> directly.
>
> Signed-off-by: Himadri Pandya
> ---
> drivers/usb/serial/ipaq.c |
On Wed, Nov 04, 2020 at 12:17:00PM +0530, Himadri Pandya wrote:
> The new usb_control_msg_send() nicely wraps usb_control_msg() with proper
> error check. Hence use the wrapper instead of calling usb_control_msg()
> directly.
>
> Signed-off-by: Himadri Pandya
> ---
> drivers/usb/serial/ipw.c | 1
On Wed, Nov 04, 2020 at 12:17:01PM +0530, Himadri Pandya wrote:
> The new usb_control_msg_send() nicely wraps usb_control_msg() with proper
> error check. Hence use the wrapper instead of calling usb_control_msg()
> directly.
>
> Signed-off-by: Himadri Pandya
> ---
> drivers/usb/serial/iuu_phoen
On Wed, Nov 04, 2020 at 12:17:02PM +0530, Himadri Pandya wrote:
> The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps
> usb_control_msg() with proper error check. Hence use the wrappers
> instead of calling usb_control_msg() directly.
>
> Signed-off-by: Himadri Pandya
> ---
>
On Wed, Nov 04, 2020 at 12:17:03PM +0530, Himadri Pandya wrote:
> The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps
> usb_control_msg() with proper error check. Hence use the wrappers
> instead of calling usb_control_msg() directly
>
> Signed-off-by: Himadri Pandya
> ---
> d
On Fri, Dec 04, 2020 at 05:19:25PM +0800, wanghai (M) wrote:
>
> 在 2020/12/4 16:40, Johan Hovold 写道:
> > On Fri, Dec 04, 2020 at 10:13:50AM +0800, Wang Hai wrote:
> >> Add the missing unlock before return from function
> >> gbaudio_dapm_free_controls() in the error
On Mon, Nov 16, 2020 at 05:18:20PM +0100, Johan Hovold wrote:
> Unlike other drivers cp210x have been retrieving the current terminal
> settings from the device on open and reflecting those in termios.
>
> Due to how set_termios() was implemented this saved a few control
> r
Rob,
On Mon, Nov 23, 2020 at 11:23:12AM +0100, Johan Hovold wrote:
> Specify type alignment when declaring linker-section match-table entries
> to prevent gcc from increasing alignment and corrupting the various
> tables with padding (e.g. timers, irqchips, clocks, reserved memory).
>
Greg,
On Mon, Nov 23, 2020 at 11:23:13AM +0100, Johan Hovold wrote:
> Instead of using the array-of-pointers trick to avoid having gcc mess up
> the earlycon array stride, specify type alignment when declaring entries
> to prevent gcc from increasing alignment.
>
> This is
On Mon, Nov 30, 2020 at 06:58:47AM +0530, Anant Thazhemadam wrote:
> The newer usb_control_msg_{send|recv}() API are an improvement on the
> existing usb_control_msg() as it ensures that a short read/write is treated
> as an error,
Short writes have always been treated as an error. The new send he
On Mon, Nov 30, 2020 at 06:59:25AM +0530, Anant Thazhemadam wrote:
> The newer usb_control_msg_{send|recv}() API are an improvement on the
> existing usb_control_msg() as it ensures that a short read/write is treated
> as an error, data can be used off the stack, and raw usb pipes need not be
> cre
On Mon, Nov 30, 2020 at 07:00:31AM +0530, Anant Thazhemadam wrote:
> The newer usb_control_msg_{send|recv}() API are an improvement on the
> existing usb_control_msg() as it ensures that a short read/write is treated
> as an error, data can be used off the stack, and raw usb pipes need not be
> cre
On Tue, Dec 01, 2020 at 01:19:30PM +0200, Andy Shevchenko wrote:
> On Tue, Dec 1, 2020 at 1:04 PM Johan Hovold wrote:
> > 0x01 is 1 and is generally treated as boolean true as you know.
>
> Depends how you interpret this. kstrtobool() uses one character (and
> in some cases
On Tue, Dec 01, 2020 at 03:37:38PM +0100, Linus Walleij wrote:
> On Sun, Nov 22, 2020 at 6:08 PM Manivannan Sadhasivam wrote:
>
> > Add gpiochip support for Maxlinear/Exar USB to serial converter
> > for controlling the available gpios.
> One minor notice:
>
> > +enum gpio_pins {
> > + GP
On Tue, Dec 01, 2020 at 05:44:10PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Dec 01, 2020 at 12:05:23PM +0100, Johan Hovold wrote:
> > On Tue, Dec 01, 2020 at 12:55:54PM +0200, Andy Shevchenko wrote:
> > > On Tue, Dec 1, 2020 at 10:20 AM Johan Hovold wrote:
> > > >
On Tue, Dec 01, 2020 at 03:49:19PM +0200, Andy Shevchenko wrote:
> On Tue, Dec 1, 2020 at 3:21 PM Johan Hovold wrote:
> > On Tue, Dec 01, 2020 at 01:19:30PM +0200, Andy Shevchenko wrote:
> > > On Tue, Dec 1, 2020 at 1:04 PM Johan Hovold wrote:
>
> ...
>
> &g
.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/bus.c | 35 +--
1 file changed, 33 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/serial/bus.c b/drivers/usb/serial/bus.c
index eb0195cf37dd..db75cc5c3dfb 100644
--- a/drivers/usb/serial/bus.c
+++ b/drivers/usb
commit messages (Andy)
- use bool constant with port-flag accessor in ftdi quirk (Jiri)
- add Mychaela's Reviewed-by tag to patch 3/7
- mention a few more example applications in the cover letter
v1
- https://lore.kernel.org/r/20201130153742.9163-1-jo...@kernel.org
Johan Hovold (5):
tty:
Use the new assign_bit() wrapper in the port-flag accessors instead of
open coding.
Suggested-by: Jiri Slaby
Signed-off-by: Johan Hovold
---
include/linux/tty.h | 30 ++
1 file changed, 6 insertions(+), 24 deletions(-)
diff --git a/include/linux/tty.h b/include
: Johan Hovold
---
drivers/tty/tty_port.c | 2 +-
include/linux/tty.h| 11 +++
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/tty_port.c b/drivers/tty/tty_port.c
index ea80bf872f54..2613debc1d06 100644
--- a/drivers/tty/tty_port.c
+++ b/drivers/tty/tty_port.c
.
Signed-off-by: Johan Hovold
---
Documentation/ABI/testing/sysfs-tty | 7 +++
drivers/tty/serial/serial_core.c| 26 ++
2 files changed, 33 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-tty
b/Documentation/ABI/testing/sysfs-tty
index e157130a6792
7;s ADBUS2 and ADBUS4 outputs
actually being RTS and DTR rather than something else.
Signed-off-by: Mychaela N. Falconia
[johan: reimplement using new NORDY flag, trim quirk comment]
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ftdi_sio.c | 22 ++
drivers/usb/serial/f
27;s port_probe function needs
to figure out which channel of a multichannel device is currently
being considered, it needs access to the port pointer passed to the
ftdi_sio_port_probe() function, so it can traverse USB data structures
from there.
Signed-off-by: Mychaela N. Falconia
Signed-off-b
Declare the port parameter to the flag-test accessors as const.
This is currently mostly cosmetic as the accessors are already inlined.
Suggested-by: Jiri Slaby
Signed-off-by: Johan Hovold
---
include/linux/tty.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a
On Tue, Dec 01, 2020 at 08:14:07AM +0100, Jiri Slaby wrote:
> On 30. 11. 20, 22:22, Mychaela Falconia wrote:
> > 2) For situations in which the luxury of a custom USB ID is not
> > available, e.g., a situation where the device that does not tolerate
> > automatic DTR/RTS assertion on open is a phys
On Wed, Dec 02, 2020 at 10:07:58AM -0800, Mychaela Falconia wrote:
> On 12/2/20, Johan Hovold wrote:
> > Also let me know if you prefer to hold this off for 5.12. The change is
> > minimal, self-contained and low-risk, but it is a new interface and late
> > in the release
On Fri, Feb 26, 2021 at 01:54:12PM -0800, Saravana Kannan wrote:
> On Fri, Feb 26, 2021 at 6:55 AM Johan Hovold wrote:
> >
> > Fix a NULL-pointer deference when deregistering the gpio character
> > device that was introduced by the recent stub-driver hack. When the new
>
On Mon, Mar 01, 2021 at 08:13:46AM +, Pho Tran wrote:
> Similar to other CP210x devices, GPIO interfaces (gpiochip) should be
> supported for CP2108.
>
> CP2108 has 4 serial interfaces but only 1 set of GPIO pins are shared to all
> of those interfaces.
> So, just need to initialize GPIOs of
is no longer needed
after patch 1/2
- add Saravanas's reviewed-by tag to patch 2/2
Johan Hovold (2):
gpio: fix NULL-deref-on-deregistration regression
gpio: fix gpio-device list corruption
drivers/gpio/gpiolib.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
--
2.26.2
ot+d27b4c8adbbff70fb...@syzkaller.appspotmail.com
Signed-off-by: Johan Hovold
---
drivers/gpio/gpiolib.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index adf55db080d8..6e0572515d02 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpioli
6
Reviewed-by: Saravana Kannan
Signed-off-by: Johan Hovold
---
drivers/gpio/gpiolib.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 6e0572515d02..4253837f870b 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -475
On Tue, Feb 16, 2021 at 11:03:10AM -0500, Karan Singhal wrote:
> IDs of nLight Air Adapter, Acuity Brands, Inc.:
> vid: 10c4
> pid: 88d8
>
> Signed-off-by: Karan Singhal
> ---
Next time when amending a patch, please include a changelog here so we
know what changes between revisions.
Now applied
On Tue, Feb 23, 2021 at 05:44:18PM +0100, Sebastian Reichel wrote:
> GE CS1000 has some more custom USB IDs for CP2102N; add them
> to the driver to have working auto-probing.
>
> Signed-off-by: Sebastian Reichel
Now applied, thanks.
Johan
901 - 1000 of 2824 matches
Mail list logo
