Re: [PATCH 3/5] USB: serial: f81232: enable remote wakeup via RX/RI pin

2018-01-29 Thread Johan Hovold
On Mon, Jan 22, 2018 at 03:58:45PM +0800, Ji-Ze Hong (Peter Hong) wrote: > The F81232 can do remote wakeup via RX/RI pin with pulse. > This patch will use device_set_wakeup_enable to enable this > feature. This is a policy decision that should be made by user space by setting the power/wakeup attr

Re: [PATCH 5/5] USB: serial: f81232: fix bulk_in/out size

2018-01-29 Thread Johan Hovold
On Mon, Jan 22, 2018 at 03:58:47PM +0800, Ji-Ze Hong (Peter Hong) wrote: > Fix Fintek F81232 bulk_in/out size to 64/16 according to the spec. > http://html.alldatasheet.com/html-pdf/406315/FINTEK/F81232/1762/8/F81232.html > > Signed-off-by: Ji-Ze Hong (Peter Hong) > --- > drivers/usb/serial/f812

Re: [PATCH v3] USB: serial: option: add id for Motorola Solutions TETRA PEI

2018-01-17 Thread Johan Hovold
9403] usb 1-1.4: motorola_tetra converter now attached to ttyUSB0 > [  172.249502] usb_serial_simple 1-1.4:1.1: motorola_tetra converter > detected > [  172.249578] usb 1-1.4: motorola_tetra converter now attached to ttyUSB1 > > > >From a7ab87acf85b67303e7bf606734176a365aae9cd

Re: [PATCH v5 3/5] misc serdev: Add w2sg0004 (gps receiver) power control driver

2018-01-17 Thread Johan Hovold
On Fri, Jan 12, 2018 at 06:59:59PM +0100, H. Nikolaus Schaller wrote: > Hi Johan, > > > Am 12.01.2018 um 16:39 schrieb Johan Hovold : > > > >> Let's restart this discussion and focus on the main roadblock (others > >> are minor details which can be sorte

Re: [Letux-kernel] [PATCH v5 3/5] misc serdev: Add w2sg0004 (gps receiver) power control driver

2018-01-17 Thread Johan Hovold
On Fri, Jan 12, 2018 at 07:40:35PM +0100, Andreas Kemnade wrote: > On Fri, 12 Jan 2018 15:46:47 +0100 > Johan Hovold wrote: > > > On Tue, Jan 09, 2018 at 06:43:47PM +0100, Andreas Kemnade wrote: > > > On Fri, 22 Dec 2017 13:44:27 +0100 > > > Johan Hovold wrote:

Re: [PATCH 1/3] Input: twl4030-vibra: fix sibling-node lookup

2018-01-09 Thread Johan Hovold
On Mon, Jan 08, 2018 at 05:36:38PM -0800, Dmitry Torokhov wrote: > On Mon, Jan 08, 2018 at 02:55:02PM +0100, Johan Hovold wrote: > > On Mon, Dec 11, 2017 at 11:21:21AM +0100, Johan Hovold wrote: > > > On Sat, Nov 11, 2017 at 04:43:37PM +0100, Johan Hovold wrote: > > > &

Re: [PATCH v2] Staging: greybus: camera: cleanup multiple checks for null pointers

2018-01-09 Thread Johan Hovold
On Mon, Jan 08, 2018 at 10:20:15PM +0530, Sumit Pundir wrote: > Fixed coding style issue regarding null comparison at multiple lines. > Issue reported by checkpatch.pl > > Signed-off-by: Sumit Pundir > --- > v2: > Updated the patch title and description. Thanks for the upd

Re: [PATCH V2 1/5] usb: serial: f81534: add high baud rate support

2018-01-09 Thread Johan Hovold
On Thu, Jan 04, 2018 at 10:29:17AM +0800, Ji-Ze Hong (Peter Hong) wrote: > The F81532/534 had 4 clocksource 1.846/18.46/14.77/24MHz and baud rates > can be up to 1.5Mbits with 24MHz. > > This device may generate data overrun when baud rate setting to 921600bps > or higher with old UART trigger lev

Re: [PATCH V2 2/5] usb: serial: f81534: add auto RTS direction support

2018-01-09 Thread Johan Hovold
On Thu, Jan 04, 2018 at 10:29:18AM +0800, Ji-Ze Hong (Peter Hong) wrote: > The F81532/534 had auto RTS direction support for RS485 mode. > We'll read it from internal Flash with address 0x2f01~0x2f04 for 4 ports. > There are 4 conditions below: > 0: F81534_PORT_CONF_RS232. > 1: F81534_P

Re: [PATCH V2 3/5] usb: serial: f81534: add output pin control

2018-01-09 Thread Johan Hovold
On Thu, Jan 04, 2018 at 10:29:19AM +0800, Ji-Ze Hong (Peter Hong) wrote: > The F81532/534 had 3 output pin (M0/SD, M1, M2) with open-drain mode to > control transceiver. We'll read it from internal Flash with address > 0x2f05~0x2f08 for 4 ports. The value is range from 0 to 7. The M0/SD is > MSB of

Re: [PATCH V2 4/5] usb: serial: f81534: add H/W disable port support

2018-01-09 Thread Johan Hovold
On Thu, Jan 04, 2018 at 10:29:20AM +0800, Ji-Ze Hong (Peter Hong) wrote: > The F81532/534 can be disable port by manufacturer with > following H/W design. > 1: Connect DCD/DSR/CTS/RI pin to ground. > 2: Connect RX pin to ground. > > In driver, we'll implements some detect method likes foll

Re: [PATCH V2 5/5] usb: serial: f81534: fix tx error on some baud rate

2018-01-09 Thread Johan Hovold
On Thu, Jan 04, 2018 at 10:29:21AM +0800, Ji-Ze Hong (Peter Hong) wrote: > The F81532/534 had 4 clocksource 1.846/18.46/14.77/24MHz and baud rates > can be up to 1.5Mbits with 24MHz. But on some baud rate (384~500kps), the > TX side will send the data frame too close to treat frame error on RX > si

Re: [PATCH v2 1/2] USB: serial: ark3116: Remove unused TIOCSSERIAL ioctl case.

2018-01-09 Thread Johan Hovold
On Tue, Jan 09, 2018 at 12:45:30AM +0300, Mikhail Zaytsev wrote: > On Mon, 8 Jan 2018 16:28:58 +0100 Johan Hovold wrote: > > > On Mon, Jan 08, 2018 at 11:33:32AM +0100, Oliver Neukum wrote: > > > Am Samstag, den 06.01.2018, 20:14 +0300 schrieb Mikhail Zaytsev: > > &

Re: [PATCH v2 2/2] USB: serial: ark3116: Move TIOCGSERIAL ioctl case to function.

2018-01-09 Thread Johan Hovold
On Sat, Jan 06, 2018 at 08:15:22PM +0300, Mikhail Zaytsev wrote: > The patch moves TIOCGSERIAL ioctl case to get_serial_info function. > > Signed-off-by: Mikhail Zaytsev > static int ark3116_ioctl(struct tty_struct *tty, >unsigned int cmd, unsigned long arg) > { >

Re: [PATCH 1/2] serdev: do not generate modaliases for controllers

2018-01-09 Thread Johan Hovold
On Tue, Jan 09, 2018 at 04:48:03PM +0100, Greg Kroah-Hartman wrote: > On Mon, Jan 08, 2018 at 01:42:32PM +0100, Johan Hovold wrote: > > Serdev controllers are not bound to any drivers and it therefore makes > > no sense to generate modaliases for them. > > > >

[PATCH v2 2/2] serdev: only match serdev devices

2018-01-09 Thread Johan Hovold
Only serdev devices (a.k.a. clients or slaves) are bound to drivers so bail out early from match() in case the device is not a serdev device (i.e. if it's a serdev controller). Signed-off-by: Johan Hovold --- drivers/tty/serdev/core.c | 8 1 file changed, 8 insertions(+) diff --

[PATCH v2 0/2] serdev: bus-code clean ups

2018-01-09 Thread Johan Hovold
. This series applies on top of Hans's minimal fix which suppresses the uevent errors for ACPI controllers (even though it could replace it entirely if preferred). Johan v2 - add the missing static keyword for the modalias attribute when moving the definition (noted by Greg) Johan Hovo

[PATCH v2 1/2] serdev: do not generate modaliases for controllers

2018-01-09 Thread Johan Hovold
missing static keyword for the modalias device attribute when moving the definition. Reported-by: Hans de Goede Signed-off-by: Johan Hovold --- drivers/tty/serdev/core.c | 72 ++- 1 file changed, 34 insertions(+), 38 deletions(-) diff --git a/drivers/tty

Re: [PATCH V2 1/5] usb: serial: f81534: add high baud rate support

2018-01-10 Thread Johan Hovold
On Wed, Jan 10, 2018 at 01:30:18PM +0800, Ji-Ze Hong (Peter Hong) wrote: > Hi Johan, > > Johan Hovold 於 2018/1/9 下午 07:08 寫道: > > On Thu, Jan 04, 2018 at 10:29:17AM +0800, Ji-Ze Hong (Peter Hong) wrote: > >> The F81532/534 had 4 clocksource 1.846/18.46/14.77/24MHz and baud

Re: [PATCH V2 5/5] usb: serial: f81534: fix tx error on some baud rate

2018-01-10 Thread Johan Hovold
On Wed, Jan 10, 2018 at 01:42:32PM +0800, Ji-Ze Hong (Peter Hong) wrote: > Hi Johan, > > Johan Hovold 於 2018/1/9 下午 07:32 寫道: > > On Thu, Jan 04, 2018 at 10:29:21AM +0800, Ji-Ze Hong (Peter Hong) wrote: > >> + /* > >> + * We'll make tx frame error wh

Re: [PATCH V2 1/5] usb: serial: f81534: add high baud rate support

2018-01-10 Thread Johan Hovold
On Wed, Jan 10, 2018 at 05:16:01PM +0800, Ji-Ze Hong (Peter Hong) wrote: > Hi Johan, > > Johan Hovold 於 2018/1/10 下午 04:49 寫道: > >> Normally, the communication with F81534 ep0 will take less than 1 sec > >> (even only some milliseconds), but It maybe take much long

Re: [PATCH 1/2] staging: irda: Replace mdelay with usleep_range in stir421x_fw_upload

2018-04-11 Thread Johan Hovold
; avoid busy waiting. > > This is found by a static analysis tool named DCNS written by myself. > And I also manually check it. > > Signed-off-by: Jia-Ju Bai This all looks good (also note the call to usb_control_msg(), which may sleep, just above the mdelay()). Reviewed-by: Johan Hovold Thanks, Johan

Re: [PATCH 2/2] staging: irda: Replace mdelay with usleep_range in irda_usb_probe

2018-04-11 Thread Johan Hovold
() to busily wait. > This is not necessary and can be replaced with usleep_range() to > avoid busy waiting. > > This is found by a static analysis tool named DCNS written by myself. > And I also manually check it. > > Signed-off-by: Jia-Ju Bai Reviewed-by: Johan Hovold

[PATCH 2/3] USB: musb: host: prevent core phy initialisation

2018-04-13 Thread Johan Hovold
ferences to usb-nop-xceiv devices"). Something similar may now be needed for other USB phys, and in particular if we eventually want to let USB core manage musb generic phys. Cc: Arnd Bergmann Cc: Martin Blumenstingl Signed-off-by: Johan Hovold --- drivers/usb/musb/musb_host.c | 1 + 1 file

[PATCH 0/3] USB: musb: dsps: phy fix and DT-topology support

2018-04-13 Thread Johan Hovold
probe and which is fixed by the first patch. Johan Johan Hovold (3): USB: musb: dsps: drop duplicate phy initialisation USB: musb: host: prevent core phy initialisation USB: musb: dsps: propagate device-tree node drivers/usb/musb/musb_dsps.c | 3 +-- drivers/usb/musb/musb_host.c | 1 + 2

[PATCH 3/3] USB: musb: dsps: propagate device-tree node

2018-04-13 Thread Johan Hovold
glue drivers will require similar changes to be able to describe their buses in DT. Signed-off-by: Johan Hovold --- drivers/usb/musb/musb_dsps.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c index 6a60bc0490c5..23dba59045a7 100644

[PATCH 1/3] USB: musb: dsps: drop duplicate phy initialisation

2018-04-13 Thread Johan Hovold
utdowns on remove). Drop the duplicate phy init and shutdown calls from the dsps glue in favour of the ones in musb core, which other glue drivers rely on. Note however that any generic phy is still initialised in the glue init callback (just as for the other drivers). Cc: Uwe Kleine-König Signed-off

Re: [PATCH] soc/tegra: pmc: fix child-node lookup

2018-03-22 Thread Johan Hovold
On Fri, Jan 12, 2018 at 10:19:51AM +0100, Johan Hovold wrote: > On Thu, Nov 16, 2017 at 01:40:24PM +0200, Mikko Perttunen wrote: > > On 15.11.2017 11:44, Johan Hovold wrote: > > > Fix child-node lookup during probe, which ended up searching the whole > > > device tree

Re: [PATCH] usb: serial: option: add HP LT4220 support

2018-04-10 Thread Johan Hovold
On Tue, Apr 03, 2018 at 10:34:39AM +0800, Edward Chang wrote: > This patch adds support for HP LT4220. > > Signed-off-by: Edward Chang > +/* HP products */ > +#define HP_VENDOR_ID 0x03f0 > +#define HP_PRODUCT_LT42200x0857 > + > struct option_blacklis

Re: [PATCH] net: usb: hso: Replace GFP_ATOMIC with GFP_KERNEL in hso_create_device

2018-04-10 Thread Johan Hovold
ol named DCNS written by myself. > And I also manually check it. > > Signed-off-by: Jia-Ju Bai Thanks for the patch. This looks good to me. Reviewed-by: Johan Hovold Johan

Re: [PATCH] usb: serial: option: add HP LT4220 support

2018-04-10 Thread Johan Hovold
On Wed, Apr 11, 2018 at 02:36:52PM +0800, Edward Chang wrote: > This patch adds support for HP LT4220 > > Signed-off-by: Edward Chang > --- Thanks for the update. Please always include a changelog here when revising patches so we know what has changed since the previous version(s). Also include

Re: [PATCH 4.14 58/62] mtd: rawnand: atmel: fix OF child-node lookup

2018-11-26 Thread Johan Hovold
oard on 4.14 due to this patch ? > > > > > > On Mon, 26 Nov 2018 at 16:31, Greg Kroah-Hartman > > > wrote: > > > > > > > > 4.14-stable review patch. If anyone has any objections, please let me > > > > know. > > > > > > > > -

Re: [PATCH 2/4] serdev: make synchronous write return bytes written

2018-11-20 Thread Johan Hovold
On Mon, Nov 19, 2018 at 09:15:37AM -0600, Rob Herring wrote: > On Wed, Nov 14, 2018 at 9:10 AM Johan Hovold wrote: > > > > Make the synchronous serdev_device_write() helper behave analogous to > > the asynchronous serdev_device_write_buf() by returning the number of > &g

Re: [PATCH 0/4] serdev: make serdev_device_write() more usable

2018-11-20 Thread Johan Hovold
On Mon, Nov 19, 2018 at 09:16:35AM -0600, Rob Herring wrote: > On Wed, Nov 14, 2018 at 9:10 AM Johan Hovold wrote: > > > > This series make the synchronous serdev_device_write() helper more > > usable by > > > > 1) allowing drivers to pass a z

Re: [PATCH v2 5/9] mtd: nand: atmel: fix OF child-node lookup

2018-11-15 Thread Johan Hovold
On Tue, Oct 23, 2018 at 08:51:17PM +0200, Boris Brezillon wrote: > On Tue, 23 Oct 2018 13:28:09 -0500 > Rob Herring wrote: > > > On Mon, Aug 27, 2018 at 4:44 AM Johan Hovold wrote: > > > > > > On Mon, Aug 27, 2018 at 10:48:42AM +0200, Boris Brezillon wrote:

Re: [PATCH v1 1/4] Bluetooth: hci_qca: use wait_until_sent() for power pulses

2018-11-16 Thread Johan Hovold
On Thu, Nov 15, 2018 at 08:04:29PM +0530, Balakrishna Godavarthi wrote: > Hi Johan, > > On 2018-11-14 20:57, Johan Hovold wrote: > > On Tue, Nov 06, 2018 at 05:35:25PM +0530, Balakrishna Godavarthi wrote: > >> wcn3990 requires a power pulse to turn ON/OFF along with >

Re: [PATCH] staging: greybus: arche-platform: Switch to the gpio descriptor interface

2018-11-16 Thread Johan Hovold
On Fri, Nov 16, 2018 at 08:47:44PM +0530, Nishad Kamdar wrote: > Use the gpiod interface instead of the deprecated > old non-descriptor interface. > > Signed-off-by: Nishad Kamdar > --- Always include a change log here after the cut-off line so we know what changed since previous versions. Also

Re: [PATCH] staging: greybus: arche-platform: Switch to the gpio descriptor interface

2018-11-17 Thread Johan Hovold
On Sat, Nov 17, 2018 at 12:41:11PM +0530, Nishad Kamdar wrote: > On Fri, Nov 16, 2018 at 05:06:22PM +0100, Johan Hovold wrote: > > On Fri, Nov 16, 2018 at 08:47:44PM +0530, Nishad Kamdar wrote: > > > Use the gpiod interface instead of the deprecated > > > o

[PATCH] gpio: drop broken to_gpio_irq_chip() helper

2018-11-12 Thread Johan Hovold
Move irqchip into struct gpio_irq_chip") Cc: Thierry Reding Cc: Grygorii Strashko Signed-off-by: Johan Hovold --- include/linux/gpio/driver.h | 5 - 1 file changed, 5 deletions(-) diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h index 2db62b550b95..21bff1f14fde 10

Re: [PATCH] greybus: gpio: switch GPIO portions to use GPIOLIB_IRQCHIP

2018-11-12 Thread Johan Hovold
On Fri, Nov 09, 2018 at 01:17:41PM +0530, Nishad Kamdar wrote: > Convert the GPIO driver to use the GPIO irqchip library > GPIOLIB_IRQCHIP instead of reimplementing the same. Thanks for picking this up. Linus W took a stab at it a couple of years ago, but it was never completed. You may want to ta

Re: [PATCH] staging: greybus: arche-apb-ctrl.c: Switch to the gpio descriptor interface

2018-11-12 Thread Johan Hovold
On Sun, Nov 11, 2018 at 11:14:14AM +0530, Nishad Kamdar wrote: > Use the gpiod interface instead of the deprecated old non-descriptor > interface. > > Signed-off-by: Nishad Kamdar > --- > drivers/staging/greybus/arche-apb-ctrl.c | 158 ++- > 1 file changed, 65 insertions(+),

Re: [PATCH v3] cpufreq: ti-cpufreq: Only register platform_device when supported

2018-11-13 Thread Johan Hovold
use > of the driver. There is already functionality in place to match the > SoC compatible so let's factor this out into a separate call and > make sure we find a match before creating the ti-cpufreq platform device. > > Reviewed-by: Johan Hovold > Signed

[GIT PULL] GNSS fixes for v4.20-rc3

2018-11-14 Thread Johan Hovold
to wait indefinitely, something which could result in incomplete writes when the controller write buffer was getting full. Signed-off-by: Johan Hovold Johan Hovold (2): gnss: serial: fix synchronous write timeout gnss

[PATCH 0/4] serdev: make serdev_device_write() more usable

2018-11-14 Thread Johan Hovold
a non-zero timeout and doesn't check the return value and therefore does not need to be updated. Note that this series depends on the two above mentioned GNSS fixes (submitted for v4.20-rc3). Johan Johan Hovold (4): serdev: use zero to indicate infinite write timeout serdev: make synchrono

[PATCH 2/4] serdev: make synchronous write return bytes written

2018-11-14 Thread Johan Hovold
data was written. Also update the only two users that checked the return value. Signed-off-by: Johan Hovold --- drivers/gnss/serial.c | 2 +- drivers/gnss/sirf.c | 2 +- drivers/tty/serdev/core.c | 12 ++-- 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a

[PATCH 3/4] serdev: make synchronous write helper interruptible

2018-11-14 Thread Johan Hovold
Allow the synchronous serdev_device_write() helper to be interrupted. This is useful for cases where I/O is performed on behalf of user space and we don't want to block indefinitely when using flow control. Signed-off-by: Johan Hovold --- drivers/tty/serdev/core.c

[PATCH 4/4] serdev: document the write functions using kernel-doc

2018-11-14 Thread Johan Hovold
called in the driver write_wakeup() callback. Signed-off-by: Johan Hovold --- drivers/tty/serdev/core.c | 37 + 1 file changed, 37 insertions(+) diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c index c7006bbb793a..a0ac16ee6575 100644 --- a

[PATCH 1/4] serdev: use zero to indicate infinite write timeout

2018-11-14 Thread Johan Hovold
serdev_device_wait_until_sent(). Note that passing zero to the current helper makes no sense; just call the asynchronous serdev_device_write_buf() directly instead. Signed-off-by: Johan Hovold --- drivers/tty/serdev/core.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/tty

Re: [PATCH v1 1/4] Bluetooth: hci_qca: use wait_until_sent() for power pulses

2018-11-14 Thread Johan Hovold
On Tue, Nov 06, 2018 at 05:35:25PM +0530, Balakrishna Godavarthi wrote: > wcn3990 requires a power pulse to turn ON/OFF along with > regulators. Sometimes we are observing the power pulses are sent > out with some time delay, due to queuing these commands. This is > causing synchronization issues w

Re: [PATCH] greybus: gpio: switch GPIO portions to use GPIOLIB_IRQCHIP

2018-11-14 Thread Johan Hovold
On Tue, Nov 13, 2018 at 11:48:09PM +0530, Nishad Kamdar wrote: > On Mon, Nov 12, 2018 at 04:15:09PM +0100, Johan Hovold wrote: > > On Fri, Nov 09, 2018 at 01:17:41PM +0530, Nishad Kamdar wrote: > > > @@ -40,8 +38,6 @@ struct gb_gpio_controller { > > > s

[GIT PULL] GNSS fixes for v4.20-rc3 (take 2)

2018-11-14 Thread Johan Hovold
full. Signed-off-by: Johan Hovold Johan Hovold (2): gnss: serial: fix synchronous write timeout gnss: sirf: fix synchronous write timeout drivers/gnss/serial.c | 3 ++- drivers/gnss/sirf.c | 3 ++- 2 files changed, 4 inser

Re: linux-next: Signed-off-by missing for commits in the gnss-fixes tree

2018-11-14 Thread Johan Hovold
On Thu, Nov 15, 2018 at 06:33:21AM +1100, Stephen Rothwell wrote: > Hi Johan, > > Commits > > 9ac9252b4bcd ("gnss: sirf: fix synchronous write timeout") > b1a003961711 ("gnss: serial: fix synchronous write timeout") > > are missing a Signed-off-by from their author and committer. Thanks for

Re: [PATCH v3 1/4] Bluetooth: hci_qca: use wait_until_sent() for power pulses

2018-12-04 Thread Johan Hovold
On Fri, Nov 30, 2018 at 08:32:44PM +0530, Balakrishna Godavarthi wrote: > wcn3990 requires a power pulse to turn ON/OFF along with > regulators. Sometimes we are observing the power pulses are sent > out with some time delay, due to queuing these commands. This is > causing synchronization issues w

Re: [PATCH] USB: serial: console: fix reported terminal settings

2018-12-05 Thread Johan Hovold
On Wed, Dec 05, 2018 at 11:36:52AM +0200, Jarkko Nikula wrote: > On 12/4/18 6:31 PM, Johan Hovold wrote: > > On Tue, Dec 04, 2018 at 05:15:18PM +0100, Greg Kroah-Hartman wrote: > >> On Tue, Dec 04, 2018 at 05:00:36PM +0100, Johan Hovold wrote: > >>> The USB-serial co

[PATCH] gnss: sirf: fix activation retry handling

2018-12-05 Thread Johan Hovold
") Cc: stable # 4.19 Signed-off-by: Johan Hovold --- drivers/gnss/sirf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gnss/sirf.c b/drivers/gnss/sirf.c index 71d014edd167..2c22836d3ffd 100644 --- a/drivers/gnss/sirf.c +++ b/drivers/gnss/sirf.c @@ -16

Re: [PATCH 1/5] gnss: sirf: write data to gnss only when the gnss device is open

2018-12-05 Thread Johan Hovold
On Sun, Nov 18, 2018 at 10:57:57PM +0100, Andreas Kemnade wrote: > The api forbids writing data there otherwise. Prepare for the > serdev_open()/close() being a part of runtime pm. > > Signed-off-by: Andreas Kemnade > --- > drivers/gnss/sirf.c | 16 +++- > 1 file changed, 15 insertio

Re: [PATCH 2/5] gnss: sirf: power on logic for devices without wakeup signal

2018-12-05 Thread Johan Hovold
On Sun, Nov 18, 2018 at 10:57:58PM +0100, Andreas Kemnade wrote: > Some Wi2Wi devices do not have a wakeup output, so device state can > only be indirectly detected by looking whether there is communitcation > over the serial lines. > Additionally it checks for the initial state of the device durin

Re: [PATCH 3/5] dt-bindings: gnss: add w2sg0004 compatible string

2018-12-05 Thread Johan Hovold
On Sun, Nov 18, 2018 at 10:57:59PM +0100, Andreas Kemnade wrote: > Add w2sg0004 compatible string since devices without wakeup > pins are now supported. > > Signed-off-by: Andreas Kemnade > --- > Documentation/devicetree/bindings/gnss/sirfstar.txt | 1 + > 1 file changed, 1 insertion(+) > > dif

Re: [PATCH RFC 4/5] gnss: sirf: add a separate supply for a lna

2018-12-05 Thread Johan Hovold
On Sun, Nov 18, 2018 at 10:58:00PM +0100, Andreas Kemnade wrote: > Devices might have a separate lna between antenna output of the gps > chip and the antenna which might have a separate supply > > Signed-off-by: Andreas Kemnade > --- > drivers/gnss/sirf.c | 15 +++ > 1 file changed,

Re: [PATCH RFC 5/5] dt-bindings: gnss: add lna-supply property

2018-12-05 Thread Johan Hovold
On Sun, Nov 18, 2018 at 10:58:01PM +0100, Andreas Kemnade wrote: > Add lna-supply property. > > Signed-off-by: Andreas Kemnade > --- > Documentation/devicetree/bindings/gnss/sirfstar.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/gnss/sirfstar.txt

Re: [Letux-kernel] [PATCH 0/5] gnss: sirf: add support for w2sg0004 + lna

2018-12-05 Thread Johan Hovold
On Mon, Nov 19, 2018 at 07:44:14PM +0100, Andreas Kemnade wrote: > On Mon, 19 Nov 2018 09:22:59 +0100 > "H. Nikolaus Schaller" wrote: > > > Am 18.11.2018 um 22:57 schrieb Andreas Kemnade : > > > > > > Here is another chapter of the story to get gta04 gnss power > > > management into the mainlin

Re: [Letux-kernel] [PATCH 0/5] gnss: sirf: add support for w2sg0004 + lna

2018-12-05 Thread Johan Hovold
On Wed, Dec 05, 2018 at 04:19:16PM +0100, Johan Hovold wrote: > On Mon, Nov 19, 2018 at 07:44:14PM +0100, Andreas Kemnade wrote: > > > On Mon, 19 Nov 2018 09:22:59 +0100 > > "H. Nikolaus Schaller" wrote: > > > > > Am 18.11.2018 um 22:57 schrieb Andreas

[PATCH 1/2] MAINTAINERS: add gnss scm tree

2018-12-05 Thread Johan Hovold
Add SCM tree for the gnss subsystem. Signed-off-by: Johan Hovold --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6682420421c1..03766ddf95a3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6316,6 +6316,7 @@ F:include/uapi/linux

[PATCH 2/2] MAINTAINERS: exclude gnss from SIRFPRIMA2 regex matching

2018-12-05 Thread Johan Hovold
Exclude the gnss subsystem from SIRMPRIMA2 regex matching, which would otherwise match the unrelated gnss sirf driver. Cc: Barry Song Signed-off-by: Johan Hovold --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 03766ddf95a3..0f083103d625

[GIT PULL] GNSS fixes for 4.20-rc6

2018-12-07 Thread Johan Hovold
o two MAINTAINERS updates. All have been in linux-next with no reported issues. Signed-off-by: Johan Hovold Johan Hovold (3): gnss: sirf: fix activation retry handling MAINTAINERS: add gnss scm tree MAINTAINERS: ex

Re: [PATCH][next] gnss: make struct ubx_gserial_ops static

2018-07-02 Thread Johan Hovold
was not declared. Should it be static? > > Signed-off-by: Colin Ian King This was reported by the kbuild test robot and an automated RFC patch submitted was a while back. I prefer this man-generated one with a proper commit message, so: Acked-by: Johan Hovold > --- > drivers/gnss/

Re: [PATCH v3 0/8] gnss: add new GNSS subsystem

2018-07-03 Thread Johan Hovold
On Mon, Jul 02, 2018 at 09:32:26PM +0200, Pavel Machek wrote: > On Fri 2018-06-29 14:09:14, Johan Hovold wrote: > > On Fri, Jun 29, 2018 at 02:05:54PM +0200, Pavel Machek wrote: > > > On Fri 2018-06-29 13:46:46, Johan Hovold wrote: > > > > On Fri, Jun 29, 2018 at

[PATCH 2/2] misc: sram: enable clock before registering regions

2018-07-03 Thread Johan Hovold
Make sure to enable the clock before registering regions and exporting partitions to user space at which point we must be prepared for I/O. Fixes: ee895ccdf776 ("misc: sram: fix enabled clock leak on error path") Cc: Vladimir Zapolskiy Signed-off-by: Johan Hovold --- drivers/misc/s

[PATCH 1/2] misc: sram: fix resource leaks in probe error path

2018-07-03 Thread Johan Hovold
ic here. A follow up patch will address this. Fixes: 2ae2e28852f2 ("misc: sram: add Atmel securam support") Cc: stable # 4.9 Cc: Alexandre Belloni Signed-off-by: Johan Hovold --- drivers/misc/sram.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/m

Re: [PATCH 2/2] misc: sram: enable clock before registering regions

2018-07-03 Thread Johan Hovold
On Tue, Jul 03, 2018 at 01:23:30PM +0300, Vladimir Zapolskiy wrote: > Hi Johan, > > On 07/03/2018 01:05 PM, Johan Hovold wrote: > > Make sure to enable the clock before registering regions and exporting > > partitions to user space at which point we must be prepared fo

Re: [PATCH] gnss: fix potential error pointer dereference

2018-07-03 Thread Johan Hovold
re if you want to send a v2, or if Greg can fix that when applying. Apart from that: Acked-by: Johan Hovold Johan

Re: [PATCH 2/2] misc: sram: enable clock before registering regions

2018-07-03 Thread Johan Hovold
On Tue, Jul 03, 2018 at 03:30:09PM +0300, Vladimir Zapolskiy wrote: > On 07/03/2018 02:47 PM, Johan Hovold wrote: > > On Tue, Jul 03, 2018 at 01:23:30PM +0300, Vladimir Zapolskiy wrote: > >> Hi Johan, > >> > >> On 07/03/2018 01:05 PM, Johan Hovold wrote: > &

Re: [PATCH v2] rtc: OMAP: Add support for rtc-only mode

2018-07-09 Thread Johan Hovold
On Mon, Jul 09, 2018 at 11:41:49AM +0530, Keerthy wrote: > Prepare rtc driver for rtc-only with DDR in self-refresh mode. > omap_rtc_power_off now should cater to two features: > > 1) RTC plus DDR in self-refresh is power a saving mode where in the > entire system including the different voltage r

Re: [PATCH v4 6/7] Bluetooth: mediatek: Add protocol support for MediaTek serial devices

2018-06-27 Thread Johan Hovold
On Thu, Jun 28, 2018 at 11:06:13AM +0800, Sean Wang wrote: > On Wed, 2018-06-27 at 20:04 +0300, Andy Shevchenko wrote: > > On Wed, Jun 27, 2018 at 7:59 PM, Andy Shevchenko > > wrote: > > > On Wed, Jun 27, 2018 at 8:43 AM, wrote: > > >> From: Sean Wang > > >> +#include > > >> +#include > > >

Re: [PATCH v3 0/8] gnss: add new GNSS subsystem

2018-06-29 Thread Johan Hovold
On Fri, Jun 29, 2018 at 11:46:07AM +0200, Pavel Machek wrote: > > > > Finally, note that documentation (including kerneldoc) remains to be > > > written, but hopefully this will not hinder review given that the > > > current interfaces are fairly self-describing. > > > > This all looks great. Th

Re: [PATCH v3 0/8] gnss: add new GNSS subsystem

2018-06-29 Thread Johan Hovold
On Fri, Jun 29, 2018 at 02:05:54PM +0200, Pavel Machek wrote: > On Fri 2018-06-29 13:46:46, Johan Hovold wrote: > > On Fri, Jun 29, 2018 at 11:46:07AM +0200, Pavel Machek wrote: > > > > > > > > Finally, note that documentation (including kerneldoc) remains to be

[RFC PATCH 1/3] USB: serial: add device-tree support

2018-05-25 Thread Johan Hovold
#address-cells = <1>; #size-cells = <0>; serial@0 { reg = <0>; }; }; FIXME: binding doc Not-signed-off-by: Johan Hovold --- drivers/usb/serial/usb-serial.c | 28 +++

[RFC PATCH 0/3] USB: serial: add device tree (and serdev) support

2018-05-25 Thread Johan Hovold
https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/log/?h=usb-serial-of Johan Johan Hovold (3): USB: serial: add device-tree support USB: serial: enable serdev support dbg: ARM: dts: boneblack: add USB topology and serdev nodes arch/a

[RFC PATCH 3/3] dbg: ARM: dts: boneblack: add USB topology and serdev nodes

2018-05-25 Thread Johan Hovold
the same address size. Also note that serial ports have a standardised node name in ePAPR. Not-signed-off-by: Johan Hovold --- arch/arm/boot/dts/am335x-boneblack.dts | 57 ++ 1 file changed, 57 insertions(+) diff --git a/arch/arm/boot/dts/am335x-boneblack.dts b/arch/arm

[RFC PATCH 2/3] USB: serial: enable serdev support

2018-05-25 Thread Johan Hovold
support hotplugging (e.g. tty port hangups) Not-signed-off-by: Johan Hovold --- drivers/usb/serial/bus.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/usb/serial/bus.c b/drivers/usb/serial/bus.c index eb0195cf37dd..5f574a418c52 100644 --- a/drivers/usb/serial

Re: OMAP serial runtime PM and autosuspend (was: Re: [PATCH 4/7] dt-bindings: gnss: add u-blox binding))

2018-05-25 Thread Johan Hovold
On Thu, May 24, 2018 at 06:32:37AM -0700, Tony Lindgren wrote: > * Johan Hovold [180524 09:20]: > > On Mon, May 21, 2018 at 08:48:32AM -0700, Tony Lindgren wrote: > > > Well if you have some better mechanism in mind let's try it out. Short of > > > sprinkling

Re: [PATCH 1/2] serdev: add controller runtime PM support

2018-05-11 Thread Johan Hovold
On Fri, May 11, 2018 at 05:56:27AM -0700, Tony Lindgren wrote: > * Johan Hovold [180511 08:09]: > > On Thu, May 10, 2018 at 09:48:31AM -0700, Tony Lindgren wrote: > > > If this solution works for GPS then this should also work for modems > > > that might produce data

Re: [PATCH 0/7] gnss: add new GNSS subsystem

2018-05-30 Thread Johan Hovold
Hi Marcel, Sorry about the late reply. I got side-tracked with other things. On Tue, May 08, 2018 at 10:03:57PM +0200, Marcel Holtmann wrote: > Hi Johan, > > >> I have one concern, though. While providing raw data by > >> default is fine generally, it is a problem with device > >> au

[PATCH v2 4/8] dt-bindings: gnss: add u-blox binding

2018-05-30 Thread Johan Hovold
Add binding for u-blox GNSS receivers. Note that the u-blox product names encodes form factor (e.g. "neo"), chipset (e.g. "8") and variant (e.g. "q"), but that only formfactor and chipset is used for the compatible strings (for now). Signed-off-by: Johan Hovold ---

[PATCH v2 2/8] dt-bindings: add generic gnss binding

2018-05-30 Thread Johan Hovold
Describe generic properties for GNSS receivers. Reviewed-by: Rob Herring Signed-off-by: Johan Hovold --- .../devicetree/bindings/gnss/gnss.txt | 36 +++ MAINTAINERS | 1 + 2 files changed, 37 insertions(+) create mode 100644

[PATCH v2 0/8] gnss: add new GNSS subsystem

2018-05-30 Thread Johan Hovold
Rob) - add optional u-blox v-bckp supply (Rob) - add optional u-blox extint gpio - minor clean ups - add Rob's Reviewed-by tag to patches (2/8 and 6/8) Johan Hovold (8): gnss: add GNSS receiver subsystem dt-bindings: add generic gnss binding gnss: add generic serial driver dt-

[PATCH v2 8/8] gnss: add device type support

2018-05-30 Thread Johan Hovold
"UBX" UBX Note that both SiRF and UBX type devices typically support a subset of NMEA 0183 with vendor extensions (e.g. to allow switching to the vendor protocol). Signed-off-by: Johan Hovold --- Documentation/ABI/testing/sysfs-class-gnss | 15 +++ MAINTAINERS

[PATCH v2 6/8] dt-bindings: gnss: add sirfstar binding

2018-05-30 Thread Johan Hovold
timings. Note that the wakeup gpio is not intended to be used as a wakeup source, but rather to detect the current power state of the device (active or hibernate). Reviewed-by: Rob Herring Signed-off-by: Johan Hovold --- .../devicetree/bindings/gnss/sirfstar.txt | 45

[PATCH v2 5/8] gnss: add driver for u-blox receivers

2018-05-30 Thread Johan Hovold
simply means that the main supply is disabled in STANDBY and OFF (the optional backup supply is kept enabled while the driver is bound). Note that timepulse-support is not yet implemented. Signed-off-by: Johan Hovold --- drivers/gnss/Kconfig | 13 drivers/gnss/Makefile | 3 + drivers/gnss

[PATCH v2 3/8] gnss: add generic serial driver

2018-05-30 Thread Johan Hovold
, STANDBY and OFF. Signed-off-by: Johan Hovold --- drivers/gnss/Kconfig | 7 ++ drivers/gnss/Makefile | 3 + drivers/gnss/serial.c | 275 ++ drivers/gnss/serial.h | 47 4 files changed, 332 insertions(+) create mode 100644 drivers/gnss/serial.c

[PATCH v2 1/8] gnss: add GNSS receiver subsystem

2018-05-30 Thread Johan Hovold
cripts and services. While the current interface is kept minimal, it could be extended using IOCTLs, sysfs or uevents as needs and proper abstraction levels are identified and determined (e.g. for device and feature identification). Signed-off-by: Johan Hovold --- MAINTAINERS | 6

[PATCH v2 7/8] gnss: add driver for sirfstar-based receivers

2018-05-30 Thread Johan Hovold
this this is the main reason for not using the generic serial implementation for this driver). Note that timepulse-support is left unimplemented. Signed-off-by: Johan Hovold --- drivers/gnss/Kconfig | 12 ++ drivers/gnss/Makefile | 3 + drivers/gnss/sirf.c | 407

[PATCH RESEND] serdev: add controller runtime PM support

2018-05-30 Thread Johan Hovold
the underlying hardware to idle when no I/O is expected, regardless of the slave device RPM state. Acked-by: Tony Lindgren Reviewed-by: Sebastian Reichel Signed-off-by: Johan Hovold --- Hi Rob and Greg, This is a resend of the serdev controller runtime PM patch, which you haven't comment

Re: [PATCH v2 4/8] dt-bindings: gnss: add u-blox binding

2018-05-31 Thread Johan Hovold
On Wed, May 30, 2018 at 10:58:05PM -0500, Rob Herring wrote: > On Wed, May 30, 2018 at 12:32:38PM +0200, Johan Hovold wrote: > > Add binding for u-blox GNSS receivers. > > > > Note that the u-blox product names encodes form factor (e.g. "neo"), > > chipset (

Re: [PATCH v2 0/8] gnss: add new GNSS subsystem

2018-05-31 Thread Johan Hovold
On Wed, May 30, 2018 at 07:38:22AM -0700, Richard Cochran wrote: > On Wed, May 30, 2018 at 12:32:34PM +0200, Johan Hovold wrote: > > Another possible extension is to add generic 1PPS support. > > There are two possibilities to consider. > > 1. If the PPS causes an interrupt

Re: [PATCH v2 0/8] gnss: add new GNSS subsystem

2018-05-31 Thread Johan Hovold
On Thu, May 31, 2018 at 11:52:18AM +0200, H. Nikolaus Schaller wrote: > > > Am 31.05.2018 um 10:52 schrieb Johan Hovold : > > > > On Wed, May 30, 2018 at 07:38:22AM -0700, Richard Cochran wrote: > >> On Wed, May 30, 2018 at 12:32:34PM +0200, Johan Hovold wrote: &g

Re: [PATCH v2 0/8] gnss: add new GNSS subsystem

2018-05-31 Thread Johan Hovold
On Thu, May 31, 2018 at 03:33:41PM +0200, H. Nikolaus Schaller wrote: > > Am 31.05.2018 um 13:47 schrieb Johan Hovold : > > Using pps-gpio would not allow you to describe the hardware properly, > > something which, for example, may be needed for power management (e.g. > &

Re: [PATCH v2 4/8] dt-bindings: gnss: add u-blox binding

2018-05-31 Thread Johan Hovold
On Thu, May 31, 2018 at 08:55:10AM -0500, Rob Herring wrote: > On Thu, May 31, 2018 at 3:22 AM, Johan Hovold wrote: > > On Wed, May 30, 2018 at 10:58:05PM -0500, Rob Herring wrote: > >> On Wed, May 30, 2018 at 12:32:38PM +0200, Johan Hovold wrote: > >> > Add bin

Re: [PATCH v2 4/8] dt-bindings: gnss: add u-blox binding

2018-06-01 Thread Johan Hovold
On Thu, May 31, 2018 at 10:58:59AM -0500, Rob Herring wrote: > On Thu, May 31, 2018 at 9:34 AM, Johan Hovold wrote: > > On Thu, May 31, 2018 at 08:55:10AM -0500, Rob Herring wrote: > >> On Thu, May 31, 2018 at 3:22 AM, Johan Hovold wrote: > >> > On Wed, May 30,

[PATCH v3 0/8] gnss: add new GNSS subsystem

2018-06-01 Thread Johan Hovold
ix to sirf gpios (Rob) - add optional u-blox v-bckp supply (Rob) - add optional u-blox extint gpio - minor clean ups - add Rob's Reviewed-by tag (patches 2/8 and 6/8) Johan Hovold (8): gnss: add GNSS receiver subsystem dt-bindings: add generic gnss binding gnss: add ge

<    1   2   3   4   5   6   7   8   9   10   >