Use gpio_is_valid rather than open coding the more restrictive != -1
test.
Signed-off-by: Johan Hovold
---
drivers/video/backlight/atmel-pwm-bl.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/video/backlight/atmel-pwm-bl.c
b/drivers/video/backlight/atmel
Clean up probe error handling by checking parameters before any
allocations and removing an obsolete error label. Also remove
unnecessary reset of private gpio number.
Signed-off-by: Johan Hovold
---
drivers/video/backlight/atmel-pwm-bl.c | 31 ---
1 file changed, 12
Add missing module alias which is needed for module autoloading.
Signed-off-by: Johan Hovold
---
drivers/video/backlight/atmel-pwm-bl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/atmel-pwm-bl.c
b/drivers/video/backlight/atmel-pwm-bl.c
index 3cb0094..cc5a5ed
Clean up get_intensity to increase readability.
Signed-off-by: Johan Hovold
---
drivers/video/backlight/atmel-pwm-bl.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/video/backlight/atmel-pwm-bl.c
b/drivers/video/backlight/atmel-pwm-bl.c
index 52a8134
These patches fix a few issues and clean up the atmel-pwm-bl driver
somewhat.
Johan
Johan Hovold (9):
backlight: atmel-pwm-bl: fix reported brightness
backlight: atmel-pwm-bl: fix gpio polarity in remove
backlight: atmel-pwm-bl: fix module autoload
backlight: atmel-pwm-bl: clean up probe
Make sure to honour gpio polarity also at remove so that the backlight
is actually disabled on boards with active-low enable pin.
Cc: sta...@vger.kernel.org
Signed-off-by: Johan Hovold
---
drivers/video/backlight/atmel-pwm-bl.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff
The driver supports 16-bit brightness values, but the value returned
from get_brightness was truncated to eight bits.
Cc: sta...@vger.kernel.org
Signed-off-by: Johan Hovold
---
drivers/video/backlight/atmel-pwm-bl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
Use devm_gpio_request_one rather than requesting and setting direction
in two calls.
Signed-off-by: Johan Hovold
---
drivers/video/backlight/atmel-pwm-bl.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/video/backlight/atmel-pwm-bl.c
b/drivers/video
Remove unused include of clk.h.
Signed-off-by: Johan Hovold
---
drivers/video/backlight/atmel-pwm-bl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/backlight/atmel-pwm-bl.c
b/drivers/video/backlight/atmel-pwm-bl.c
index 504061c..db68cab 100644
--- a/drivers/video/backlight
Add helper function to control the gpio_on signal.
Signed-off-by: Johan Hovold
---
drivers/video/backlight/atmel-pwm-bl.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/drivers/video/backlight/atmel-pwm-bl.c
b/drivers/video/backlight/atmel-pwm
On Wed, Oct 23, 2013 at 10:20:59AM +0900, Jingoo Han wrote:
> On Wednesday, October 23, 2013 2:27 AM, Johan Hovold wrote:
> >
> > The driver supports 16-bit brightness values, but the value returned
> > from get_brightness was truncated to eight bits.
> >
>
The driver supports 16-bit brightness values, but the value returned
from get_brightness was truncated to eight bits.
Cc: sta...@vger.kernel.org
Acked-by: Jingoo Han
Signed-off-by: Johan Hovold
---
drivers/video/backlight/atmel-pwm-bl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
Use gpio_is_valid rather than open coding the more restrictive != -1
test.
Acked-by: Jingoo Han
Signed-off-by: Johan Hovold
---
drivers/video/backlight/atmel-pwm-bl.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/video/backlight/atmel-pwm-bl.c
b/drivers
Remove unused include of clk.h.
Acked-by: Jingoo Han
Signed-off-by: Johan Hovold
---
drivers/video/backlight/atmel-pwm-bl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/backlight/atmel-pwm-bl.c
b/drivers/video/backlight/atmel-pwm-bl.c
index 504061c..db68cab 100644
--- a
Clean up get_intensity to increase readability.
Acked-by: Jingoo Han
Signed-off-by: Johan Hovold
---
drivers/video/backlight/atmel-pwm-bl.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/video/backlight/atmel-pwm-bl.c
b/drivers/video/backlight/atmel
Clean up probe error handling by checking parameters before any
allocations and removing an obsolete error label. Also remove
unnecessary reset of private gpio number.
Acked-by: Jingoo Han
Signed-off-by: Johan Hovold
---
drivers/video/backlight/atmel-pwm-bl.c | 31
Add helper function to control the gpio_on signal.
Acked-by: Jingoo Han
Signed-off-by: Johan Hovold
---
drivers/video/backlight/atmel-pwm-bl.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/drivers/video/backlight/atmel-pwm-bl.c
b/drivers/video
These patches fix a few issues and clean up the atmel-pwm-bl driver
somewhat.
Resend with added ack from Jingo Han.
Johan
Johan Hovold (9):
backlight: atmel-pwm-bl: fix reported brightness
backlight: atmel-pwm-bl: fix gpio polarity in remove
backlight: atmel-pwm-bl: fix module autoload
Use devm_gpio_request_one rather than requesting and setting direction
in two calls.
Acked-by: Jingoo Han :w
Signed-off-by: Johan Hovold
---
drivers/video/backlight/atmel-pwm-bl.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/video/backlight/atmel
Make sure to honour gpio polarity also at remove so that the backlight
is actually disabled on boards with active-low enable pin.
Cc: sta...@vger.kernel.org
Acked-by: Jingoo Han
Signed-off-by: Johan Hovold
---
drivers/video/backlight/atmel-pwm-bl.c | 6 --
1 file changed, 4 insertions
Add missing module alias which is needed for module autoloading.
Acked-by: Jingoo Han
Signed-off-by: Johan Hovold
---
drivers/video/backlight/atmel-pwm-bl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/atmel-pwm-bl.c
b/drivers/video/backlight/atmel-pwm-bl.c
On Thu, Feb 06, 2014 at 05:25:33PM +0900, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message.
>
> Signed-off-by: Jingoo Han
Acked-by: Johan Hovold
Thanks,
Johan
> ---
> drivers/video/backlight/
nd make sure to keep
you CC:ed on the sleep_on-killing patches.
Thanks,
Johan
> Signed-off-by: Arnd Bergmann
> Cc: Johan Hovold
> Cc: Greg Kroah-Hartman
> Cc: linux-...@vger.kernel.org
> ---
> drivers/usb/serial/ch341.c | 29
> drivers/usb/serial/cy
7;t
> leak information (struct has a hole after 'iomem_reg_shift')
>
> vim +149 drivers/usb/serial/pl2303.c
>
> 8bf769eb Johan Hovold 2012-10-15 133 };
> 8bf769eb Johan Hovold 2012-10-15 134
> ^1da177e Linus Torvalds 2005-04-16 135 struct pl2303_privat
On Fri, Sep 05, 2014 at 06:17:57PM +0300, Octavian Purdila wrote:
> This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO
> Master Adapter DLN-2. Details about the device can be found here:
>
> https://www.diolan.com/i2c/i2c_interface.html.
>
> Information about the USB protocol can b
On Mon, Sep 08, 2014 at 01:32:33PM +0200, Johan Hovold wrote:
> On Fri, Sep 05, 2014 at 06:17:57PM +0300, Octavian Purdila wrote:
> > +static int _dln2_transfer(struct dln2_dev *dln2, u16 handle, u16 cmd,
> > + void *obuf, int obuf_len, void *ibuf
On Mon, Sep 08, 2014 at 04:20:34PM +0300, Octavian Purdila wrote:
> On Mon, Sep 8, 2014 at 2:32 PM, Johan Hovold wrote:
> > > +static bool find_free_slot(struct dln2_mod_rx_slots *rxs, int *slot)
> > > +{
> > > + unsigned long flags;
> > > +
> >
On Fri, Sep 05, 2014 at 06:17:58PM +0300, Octavian Purdila wrote:
> From: Laurentiu Palcu
>
> This patch adds support for the Diolan DLN-2 I2C master module. Due
> to hardware limitations it does not support SMBUS quick commands.
>
> Information about the USB protocol interface can be found in t
On Fri, Sep 05, 2014 at 06:17:59PM +0300, Octavian Purdila wrote:
> From: Daniel Baluta
>
> This patch adds GPIO and IRQ support for the Diolan DLN-2 GPIO module.
>
> Information about the USB protocol interface can be found in the
> Programmer's Reference Manual [1], see section 2.9 for the GPI
On Mon, Sep 08, 2014 at 06:57:29PM +0300, Octavian Purdila wrote:
> On Mon, Sep 8, 2014 at 5:44 PM, Johan Hovold wrote:
>
>
>
> Hi Johan,
>
> Again, thanks for the detailed review, I am addressing your review
> comments as we speak. Some questions below.
>
>
On Fri, Sep 05, 2014 at 06:17:59PM +0300, Octavian Purdila wrote:
> --- /dev/null
> +++ b/drivers/gpio/gpio-dln2.c
> @@ -0,0 +1,537 @@
> +/*
> + * Driver for the Diolan DLN-2 USB-GPIO adapter
> + *
> + * Copyright (c) 2014 Intel Corporation
> + *
> + * This program is free software; you can redist
On Mon, Sep 08, 2014 at 08:15:07PM +0300, Octavian Purdila wrote:
> Just one more question on this subject: is the following allowed:
>
> int ret, len;
>
> or should it be:
>
> int ret;
> int len;
I try to avoid it, at least unless obviously related such as min/max or
x/y.
Johan
--
To unsubsc
On Fri, Sep 05, 2014 at 07:04:51PM +0300, Octavian Purdila wrote:
> On Fri, Sep 5, 2014 at 6:38 PM, Johan Hovold wrote:
> > On Fri, Sep 05, 2014 at 06:17:59PM +0300, Octavian Purdila wrote:
> > In general, how well have these patches been tested with disconnect
> > events
On Fri, Sep 05, 2014 at 09:30:11AM +0800, Wang YanQing wrote:
> On Thu, Sep 04, 2014 at 06:44:31PM +0200, Benjamin Henrion wrote:
> > On Thu, Sep 4, 2014 at 6:14 PM, Benjamin Henrion wrote:
> > > I have subscribed to the lkml.
> > >
> > > Can you make me a favour, send me your email as you posted
On Tue, Sep 09, 2014 at 06:21:31PM +0800, Wang YanQing wrote:
> On Tue, Sep 09, 2014 at 12:08:56PM +0200, Johan Hovold wrote:
> > On Fri, Sep 05, 2014 at 09:30:11AM +0800, Wang YanQing wrote:
> > > On Thu, Sep 04, 2014 at 06:44:31PM +0200, Benjamin Henrion wrote:
> > >
On Tue, Sep 09, 2014 at 12:43:56PM +0200, Johan Hovold wrote:
> On Tue, Sep 09, 2014 at 06:21:31PM +0800, Wang YanQing wrote:
> > On Tue, Sep 09, 2014 at 12:08:56PM +0200, Johan Hovold wrote:
> > > On Fri, Sep 05, 2014 at 09:30:11AM +0800, Wang YanQing wrote:
> > > >
s them the same (and perhaps someone else could do the HXD
testing?).
>
> Changes
> v7-v8:
> 1: add support for four dedicated gpios on HXD and RA
> 2: fix problem reported by Johan Hovold in v7
> 3: fix checkpatch.pl's warning
>
> v6-v7:
> 1: add g
On Wed, Sep 03, 2014 at 10:45:34AM +0200, Boris BREZILLON wrote:
> Signed-off-by: Boris BREZILLON
> ---
> .../devicetree/bindings/rtc/atmel,at91sam9-rtc.txt | 20
>
> 1 file changed, 20 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/rtc/atmel,at91
On Wed, Sep 10, 2014 at 02:43:15PM +0200, Boris BREZILLON wrote:
> Hi Johan,
>
> On Wed, 10 Sep 2014 14:14:24 +0200
> Johan Hovold wrote:
>
> > On Wed, Sep 03, 2014 at 10:45:34AM +0200, Boris BREZILLON wrote:
> > > Signed-off-by: Boris BREZILLON
> > >
On Wed, Sep 10, 2014 at 03:20:19PM +0200, Boris BREZILLON wrote:
> On Wed, 10 Sep 2014 14:14:24 +0200
> Johan Hovold wrote:
> > This does not describe the hardware, but rather a specific software
> > configuration.
> >
> > The RTT is first of all not an RTC (altho
On Wed, Sep 10, 2014 at 05:31:14PM +0200, Boris BREZILLON wrote:
> On Wed, 10 Sep 2014 17:07:02 +0200
> Johan Hovold wrote:
> > Yes, this essentially what I suggested in the thread (and my last reply)
> > and relying on syscon rather than a custom driver seems like a good
On Wed, Sep 10, 2014 at 05:35:32PM +0200, Boris BREZILLON wrote:
> On Wed, 10 Sep 2014 17:07:02 +0200 Johan Hovold wrote:
> > Yes, this essentially what I suggested in the thread (and my last reply)
> > and relying on syscon rather than a custom driver seems like a good
> >
On Wed, Aug 20, 2014 at 02:24:45PM +0300, Daniel Baluta wrote:
> From: Octavian Purdila
>
> This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO
> Master Adapter DLN-2. Details about the device can be found here:
>
> https://www.diolan.com/i2c/i2c_interface.html.
>
> Information ab
On Wed, Sep 03, 2014 at 04:39:48PM +0300, Octavian Purdila wrote:
> On Tue, Sep 2, 2014 at 6:23 PM, Johan Hovold wrote:
> > That should be possible using the regmap bus read and write operations.
>
> I took a closer look on the regmap bus read/write operations and I
> think th
On Thu, Sep 04, 2014 at 09:12:05AM +0200, Frans Klaver wrote:
> > static int xsens_mt_probe(struct usb_serial *serial,
> > const struct usb_device_id *id)
> > {
> > - if (!has_required_endpoints(serial->interface->cur_altsetting))
> > -
On Thu, Sep 04, 2014 at 11:05:47AM +0200, Frans Klaver wrote:
> On Thu, Sep 04, 2014 at 10:15:22AM +0200, Johan Hovold wrote:
> > On Thu, Sep 04, 2014 at 09:12:05AM +0200, Frans Klaver wrote:
> >
> > > > static int xsens_mt_prob
On Fri, Sep 05, 2014 at 06:17:59PM +0300, Octavian Purdila wrote:
> +static int dln2_do_remove(struct dln2_gpio *dln2)
> +{
> + /* When removing the DLN2 USB device, gpiochip_remove may fail
> + * due to i2c drivers holding a GPIO pin. However, the i2c bus
> + * will eventually be re
On Thu, Aug 28, 2014 at 07:38:10AM +0800, Wang YanQing wrote:
> On Tue, Aug 12, 2014 at 04:02:59PM +0200, Johan Hovold wrote:
> > On Sat, Aug 09, 2014 at 02:46:56AM +0800, Wang YanQing wrote:
> > > On Fri, Aug 08, 2014 at 09:54:42AM +0200, Johan Hovold wrote:
> > > >
On Thu, Aug 28, 2014 at 07:43:01AM +0800, Wang YanQing wrote:
> On Mon, Aug 18, 2014 at 12:07:20PM +0200, Johan Hovold wrote:
> > On Sun, Aug 17, 2014 at 10:05:36AM +0800, Wang YanQing wrote:
> > > Hi Johan Hovold.
> > >
> > > Another two questions.
> >
On Mon, Sep 01, 2014 at 07:22:39PM +0300, Octavian Purdila wrote:
> On Mon, Sep 1, 2014 at 6:46 PM, Lee Jones wrote:
> > On Mon, 01 Sep 2014, Octavian Purdila wrote:
> >
> >> On Mon, Sep 1, 2014 at 2:39 PM, Lee Jones wrote:
> >> > On Mon, 01 Sep 2014, Octavian Purdila wrote:
> >> >> On Mon, Sep 1
On Tue, Sep 02, 2014 at 09:00:10AM +0100, Lee Jones wrote:
> On Mon, 01 Sep 2014, Johan Hovold wrote:
> > No, no. USB is not a function of the MFD device, it's the transport.
> > Thus there should be no USB MFD-cell. No subdriver can work without it.
> >
> > A
On Tue, Sep 02, 2014 at 11:45:55AM +0300, Octavian Purdila wrote:
> On Tue, Sep 2, 2014 at 11:00 AM, Lee Jones wrote:
> > On Mon, 01 Sep 2014, Johan Hovold wrote:
> >> I haven't looked at the details of the protocol for the device in
> >> question, but it migh
On Fri, Aug 08, 2014 at 03:10:34AM +0800, Wang YanQing wrote:
> On Tue, Aug 05, 2014 at 03:54:08PM +0200, Johan Hovold wrote:
> > > > I noticed that setting direction to output and setting the gpio high has
> > > > no effect on the read-back value (i.e. I still read back
On Sat, Aug 09, 2014 at 02:46:56AM +0800, Wang YanQing wrote:
> On Fri, Aug 08, 2014 at 09:54:42AM +0200, Johan Hovold wrote:
> > On Fri, Aug 08, 2014 at 03:10:34AM +0800, Wang YanQing wrote:
> > > On Tue, Aug 05, 2014 at 03:54:08PM +0200, Johan Hovold wrote:
> > > &
te suggested by Andreas Mohr.
> 2: drop different label names for different pl2303 instance suggested by
> Johan Hovold.
> 3: fix missing lock corrected by Johan Hovold.
> 4: use prefix pl2303hx_gpio instead pl2303_gpio, pl2303_gpio is over generic
> for current code
On Wed, Aug 13, 2014 at 08:17:50AM +0200, Hannes Petermaier wrote:
> > >
> > > Known issue:
> > > If gpios are in use(export to userspace through sysfs interface, etc),
> > > then call pl2303_release(unplug usb-serial convertor, modprobe -r,
> etc),
> > > will cause trouble, so we need to make su
On Sun, Aug 17, 2014 at 09:04:32AM +0800, Wang YanQing wrote:
> On Tue, Aug 12, 2014 at 04:46:25PM +0200, Johan Hovold wrote:
> > On Sat, Aug 09, 2014 at 01:28:28PM +0800, Wang YanQing wrote:
> > > PL2303 USB Serial devices always has GPIOs,
> >
> > Always? Are you
On Sun, Aug 17, 2014 at 10:05:36AM +0800, Wang YanQing wrote:
> Hi Johan Hovold.
>
> Another two questions.
>
> On Tue, Aug 12, 2014 at 04:46:25PM +0200, Johan Hovold wrote:
> >
> > > + int (*gpio_startup)(struct usb_serial *serial);
> > > + void (*
On Wed, Jul 30, 2014 at 12:57:09AM +0800, Wang YanQing wrote:
> PL2303HX has two GPIOs, this patch add interface for it.
In fact, PL2303HX (rev D) has four dedicated GPIOs (and an additional
four multiplexed ones).
Even if we do not know how to use the other two at this time, we should
not be har
aces, see below:
>
> On Mon, Aug 04, 2014 at 04:00:32PM +0200, Johan Hovold wrote:
> > > +config USB_SERIAL_PL2303_GPIO
> > > + bool "USB Prolific 2303 Single Port GPIOs support"
> > > + depends on USB_SERIAL_PL2303 && GPIOLIB
> > > +
On Mon, Oct 20, 2014 at 09:12:17PM -0700, Guenter Roeck wrote:
> v2:
> - poweroff -> power_off
Do you want to stick to power[-_ ]off consistently throughout?
> - Add defines for default priorities
> - Use raw notifiers protected by spinlocks instead of atomic notifiers
> - Add register_poweroff_
Make platform-device id table const.
Signed-off-by: Johan Hovold
---
drivers/rtc/rtc-omap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c
index dbb88e46c25d..bdee29674589 100644
--- a/drivers/rtc/rtc-omap.c
+++ b/drivers/rtc
Use dev_info rather than pr_info.
Signed-off-by: Johan Hovold
---
drivers/rtc/rtc-omap.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c
index c750678de652..dbb88e46c25d 100644
--- a/drivers/rtc/rtc-omap.c
+++ b/drivers
Add struct omap_rtc to hold previously global data as well as the
IP-block feature flags.
Also convert the register-access macros to proper inline helper functions.
Signed-off-by: Johan Hovold
---
drivers/rtc/rtc-omap.c | 239 +++--
1 file changed
property must be left unset in order to be
able to wake up on RTC alarms.
Tested on BeagleBone Black (rev A5).
Reviewed-by: Felipe Balbi
Signed-off-by: Johan Hovold
---
arch/arm/boot/dts/am335x-boneblack.dts | 4
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/am335x
Cc: stable
Reviewed-by: Felipe Balbi
Signed-off-by: Johan Hovold
---
drivers/rtc/rtc-omap.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c
index f842c216f2dd..828cb9983cc2 100644
--- a/drivers/rtc/rtc-omap.c
+++ b/drivers/rtc/
.
This is based on earlier work by Colin Foe-Parker and AnilKumar Ch. [1]
[1] https://www.mail-archive.com/linux-omap@vger.kernel.org/msg82127.html
Signed-off-by: Johan Hovold
---
Documentation/devicetree/bindings/rtc/rtc-omap.txt | 9 ++-
drivers/rtc/rtc-omap.c
Fix minor coding style issues like comment style, indentation and remove
a few unnecessary casts.
Also drop the 1 from OMAP1 in the driver description.
Signed-off-by: Johan Hovold
---
drivers/rtc/rtc-omap.c | 46 +++---
1 file changed, 27 insertions
Enable am33xx specific RTC features (e.g. PMIC control) by adding
"ti,am3352-rtc" to the compatible property of the rtc node.
Reviewed-by: Felipe Balbi
Signed-off-by: Johan Hovold
---
arch/arm/boot/dts/am33xx.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Remove some debug messages and return errors from subsystems rather than
always fail with -EIO.
Note that the class-registration error has already been logged by rtc
core.
Signed-off-by: Johan Hovold
---
drivers/rtc/rtc-omap.c | 41 ++---
1 file changed, 18
Add structured device-type info to encode IP-block revision differences.
Signed-off-by: Johan Hovold
---
drivers/rtc/rtc-omap.c | 103 -
1 file changed, 51 insertions(+), 52 deletions(-)
diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc
pdates to use these new interfaces once the infrastructure
is in place.
Johan
[1] https://lkml.org/lkml/2014/10/9/427
[2] https://lkml.org/lkml/2014/10/7/30
[3] https://lkml.org/lkml/2014/10/7/654
Johan Hovold (20):
rtc: omap: fix clock-source configuration
rtc: omap: fix missing wakealarm att
Add helper to read full register width.
Signed-off-by: Johan Hovold
---
drivers/rtc/rtc-omap.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c
index bcdf3c596214..c508e45ca3ce 100644
--- a/drivers/rtc/rtc-omap.c
+++ b/drivers/rtc/rtc
t for enabling
32khz clock")
Cc: stable
Reviewed-by: Felipe Balbi
Signed-off-by: Johan Hovold
---
drivers/rtc/rtc-omap.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c
index 21142e6574a9..f842c216f2dd 100644
--- a/d
Add helper to read raw BCD time that can be used in interrupt context.
Signed-off-by: Johan Hovold
---
drivers/rtc/rtc-omap.c | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c
index ee20f2d36065..bcdf3c596214
Add myself to the list of copyright holders.
Signed-off-by: Johan Hovold
---
drivers/rtc/rtc-omap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c
index 4278421183e5..e74750f00b18 100644
--- a/drivers/rtc/rtc-omap.c
+++ b/drivers/rtc/rtc
Use writel instead of writeb when disabling interrupts at probe as
ALARM2 is not cleared otherwise on some IP-block revisions (e.g.
AM3352).
Note that the driver currently never enables the ALARM2 interrupt.
Signed-off-by: Johan Hovold
---
drivers/rtc/rtc-omap.c | 8 +---
1 file changed, 5
Make sure not to register the class device until after the device has
been configured.
Currently, the device is not fully configured (e.g. 24-hour mode) when
the class device is registered, something which involves driver
callbacks for example to read the current time.
Signed-off-by: Johan
-off-by: Johan Hovold
---
drivers/rtc/rtc-omap.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c
index 1abd88e24c22..ee20f2d36065 100644
--- a/drivers/rtc/rtc-omap.c
+++ b/drivers/rtc/rtc-omap.c
@@ -106,6 +106,7
The ALARM interrupt must not be disabled during shutdown in order to be
able to power up the system using an RTC alarm.
Signed-off-by: Johan Hovold
---
drivers/rtc/rtc-omap.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc
Remove DRIVER_NAME macro which was used for unrelated strings (e.g.
id-table entry and module name), but not for related ones (e.g. module
name and alias).
Also move the module alias to the other module-info entries.
Signed-off-by: Johan Hovold
---
drivers/rtc/rtc-omap.c | 8 +++-
1 file
Remove register-base define, which is no longer used.
Signed-off-by: Johan Hovold
---
drivers/rtc/rtc-omap.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c
index 813bed270867..c750678de652 100644
--- a/drivers/rtc/rtc-omap.c
+++ b/drivers
On Tue, Oct 21, 2014 at 08:50:47AM -0700, Guenter Roeck wrote:
> On Tue, Oct 21, 2014 at 11:34:05AM +0200, Johan Hovold wrote:
> > On Mon, Oct 20, 2014 at 09:12:17PM -0700, Guenter Roeck wrote:
> >
> > > v2:
> > > - poweroff -> power_off
> >
> > Do
On Fri, Oct 03, 2014 at 12:01:20PM -0400, Nathaniel Ting wrote:
> From: Nathaniel Ting
>
> Enable Silicon Labs Ember VID chips to enumerate with the cp210x usb serial
> driver. EM358x devices operating with the Ember Z-Net 5.1.2 stack may now
> connect to host PCs over a USB serial link.
>
> Sig
On Fri, Oct 10, 2014 at 11:52:08AM +0200, Frans Klaver wrote:
> Add new IDs for the Xsens Awinda Station and Awinda Dongle.
>
> While at it, order the definitions by PID and add a logical separation
> between devices using Xsens' VID and those using FTDI's VID.
>
> Cc:
> Signed-off-by: Frans Kla
On Sat, Oct 11, 2014 at 07:20:49AM -0700, Greg Kroah-Hartman wrote:
> On Sat, Oct 11, 2014 at 03:49:43PM +0200, Philip Munksgaard wrote:
> > Fix a style issue
> >
> > Signed-off-by: Philip Munksgaard
> > ---
> > drivers/usb/serial/option.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-
On Wed, Oct 22, 2014 at 10:31:17AM +0100, Nix wrote:
> On 14 Oct 2014, Johan Hovold verbalised:
>
> > On Sun, Oct 12, 2014 at 10:36:30PM +0100, Nix wrote:
> >> I have checked: this code is being executed against a symlink that
> >> points to /dev/ttyACM0, and the t
On Fri, Oct 10, 2014 at 01:07:27PM -0500, Felipe Balbi wrote:
> On Thu, Oct 09, 2014 at 09:06:31PM +0200, Johan Hovold wrote:
> > - /* clear pending irqs, and set 1/second periodic,
> > -* which we'll use instead of update irqs
> > + /*
>
On Wed, Oct 15, 2014 at 12:08:32PM -0500, Felipe Balbi wrote:
> On Wed, Oct 15, 2014 at 07:06:28PM +0200, Johan Hovold wrote:
> > On Wed, Oct 15, 2014 at 11:55:02AM -0500, Felipe Balbi wrote:
> > > BTW, how do you test this series ?
> >
> > Set a 30 second wakealar
On Sat, Oct 11, 2014 at 07:47:58PM -0500, Felipe Balbi wrote:
> On Sat, Oct 11, 2014 at 12:12:01PM +0200, Johan Hovold wrote:
> > On Fri, Oct 10, 2014 at 01:02:31PM -0500, Felipe Balbi wrote:
> > > Hi,
> > >
> > > On Thu, Oct 09, 2014 at 09:06:30PM +0200, Joha
On Sat, Oct 11, 2014 at 12:08:18PM -0700, Tony Lindgren wrote:
> * Johan Hovold [141011 02:42]:
> > On Fri, Oct 10, 2014 at 12:54:22PM -0500, Felipe Balbi wrote:
> > >
> > > is this power-off feature "RTC-only mode" ?
> >
> > Yes, I believe so,
On Wed, Oct 22, 2014 at 04:40:24PM +0200, Philip Munksgaard wrote:
> On 22 October 2014 16:18, Greg KH wrote:
> > On Wed, Oct 22, 2014 at 11:51:12AM +0200, Johan Hovold wrote:
> >> On Sat, Oct 11, 2014 at 07:20:49AM -0700, Greg Kroah-Hartman wrote:
> >> > On Sat, Oc
On Wed, Oct 22, 2014 at 08:29:56AM -0700, Tony Lindgren wrote:
> * Johan Hovold [141022 04:12]:
> > On Sat, Oct 11, 2014 at 12:08:18PM -0700, Tony Lindgren wrote:
> > > * Johan Hovold [141011 02:42]:
> > > > On Fri, Oct 10, 2014 at 12:54:22PM -0500, Felipe Balbi
[ +CC: Guenter, Lee, linux-pm ]
On Tue, Oct 14, 2014 at 06:31:09AM +, Romain Perier wrote:
> Several drivers create their own devicetree property when they register
> poweroff capabilities. This is for example the case for mfd, regulator
> or power drivers which define "vendor,system-power-con
On Thu, Oct 23, 2014 at 12:18:15PM +0100, One Thousand Gnomes wrote:
> > > drivers/usb/serial/ftdi_sio.c | 111
> > > +-
> > > drivers/usb/serial/ftdi_sio.h | 41
> > > 2 files changed, 151 insertions(+), 1 deletion(-)
> >
> > Funny patch
On Wed, Oct 15, 2014 at 05:48:08PM +0300, Octavian Purdila wrote:
Here's some late feedback due to travels. You managed to get two updates
in there so commenting on the diff from v6.
> +struct dln2_event_cb_entry {
> + struct list_head list;
> + u16 id;
> + struct platform_device *pde
On Wed, Oct 15, 2014 at 05:48:09PM +0300, Octavian Purdila wrote:
> +static int dln2_i2c_xfer(struct i2c_adapter *adapter,
> + struct i2c_msg *msgs, int num)
> +{
> + struct dln2_i2c *dln2 = i2c_get_adapdata(adapter);
> + struct i2c_msg *pmsg;
> + struct device *de
[ Resend with lkml, arm, Felipe on CC -- why were these dropped from CC? ]
On Wed, Oct 29, 2014 at 07:35:32AM +, Romain Perier wrote:
> As discussed on the mailing list, it makes more sense to rename this property
> to "system-power-controller".
Please also refer to the commit in the regulat
On Fri, Oct 31, 2014 at 04:44:46PM +, Nix wrote:
> Sorry for the delay: illness and work-related release time flurries.
>
> On 24 Oct 2014, Johan Hovold told this:
>
> > [ +CC: linux-usb ]
> >
> > On Wed, Oct 22, 2014 at 04:36:59PM +0100, Nix wrote:
> >>
On Mon, Oct 27, 2014 at 06:31:12PM +0200, Octavian Purdila wrote:
> From: Daniel Baluta
>
> This patch adds GPIO and IRQ support for the Diolan DLN-2 GPIO module.
[...]
> +static void dln2_gpio_pin_set_out_val(struct dln2_gpio *dln2,
> + unsigned int pin, int v
1301 - 1400 of 2826 matches
Mail list logo
