On Mon, Apr 14, 2014 at 01:53:33PM +0100, One Thousand Gnomes wrote:
> On Fri, 11 Apr 2014 11:41:24 +0200
> Johan Hovold wrote:
>
> > Fix characters being dropped by n_tty_write() due to a failure to
> > check the return value of tty_put_char() in do_output_char().
&g
On Sun, Apr 13, 2014 at 11:57:16PM +0200, Tristan Bruns wrote:
> Signed-off-by: Tristan Bruns
Signed-off-by: Johan Hovold
Thanks for the patch.
Johan
> ---
> drivers/usb/serial/cp210x.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/serial/cp21
the queue properly at shutdown.
Reported-by: Xiao Jin
Signed-off-by: Johan Hovold
---
Let's fix the current runtime-suspend implementation before considering
adding a write fifo.
Since this has never really worked, I'll let someone else decide whether
the fix should be back-ported to
On Tue, Apr 15, 2014 at 04:24:10PM +0800, Xiao Jin wrote:
> On 04/15/2014 03:58 AM, Johan Hovold wrote:
> > Jin, did you check what closing_wait setting your application is using?
>
> I check the closing_wait is 30s by default. Below is the trace we get
> when
On Tue, Apr 15, 2014 at 10:35:19AM +0200, Oliver Neukum wrote:
> On Mon, 2014-04-14 at 21:58 +0200, Johan Hovold wrote:
>
> > Fix this by implementing a delayed-write queue using urb anchors and
> > making sure to discard the queue properly at shutdown.
>
> Looks very
On Tue, Apr 15, 2014 at 11:13:17AM +0200, Johan Hovold wrote:
> On Tue, Apr 15, 2014 at 10:35:19AM +0200, Oliver Neukum wrote:
> > On Mon, 2014-04-14 at 21:58 +0200, Johan Hovold wrote:
> >
> > > Fix this by implementing a delayed-write queue using urb anchors and
> >
On Wed, Jun 18, 2014 at 07:05:02PM +0300, Janne Kanniainen wrote:
> This driver adds support for USB controlled led panels that exists in
> MSI GT683R laptop
>
> Signed-off-by: Janne Kanniainen
Reviewed-by: Johan Hovold
Thanks, Janne!
Johan
> ---
> Changes in v2:
>
On Wed, Jun 18, 2014 at 09:41:35PM +0300, Janne Kanniainen wrote:
> >> This driver adds support for USB controlled led panels that exists in
> >> MSI GT683R laptop
> >>
> >> Signed-off-by: Janne Kanniainen
> >
> > Reviewed-by: Johan Hovold
> &g
On Mon, Jun 30, 2014 at 04:17:10PM -0700, Bryan Wu wrote:
> On Mon, Jun 30, 2014 at 4:33 AM, Jiri Kosina wrote:
> > On Mon, 30 Jun 2014, Johan Hovold wrote:
> >
> >> > I think the better place is HID/input tree, since this patch depends
> >> > on
On Tue, Jul 01, 2014 at 08:50:54PM +0300, Janne Kanniainen wrote:
> -static DEVICE_ATTR_RW(leds_mode);
> +static DEVICE_ATTR_RW(mode);
> +
> +static struct attribute *gt683r_led_attrs[] = {
> + &dev_attr_mode.attr,
> + NULL
> +};
> +
> +ATTRIBUTE_GROUPS(gt683r_led);
I was referring to t
On Wed, Jul 02, 2014 at 08:37:59PM +0300, Janne Kanniainen wrote:
> Move led_mode attribute from HID device to led-class devices. This will also
> fix race condition by using attribute-groups.
>
> Signed-off-by: Janne Kanniainen
Looks good now. Thanks!
Perhaps you can resend both patches as a
On Thu, Jul 03, 2014 at 08:17:08PM +0300, Janne Kanniainen wrote:
> This will fix race condition noticed by Oliver Neukum. Sysfs files are
> created before mutex and work are initialized.
>
> Signed-off-by: Janne Kanniainen
Reviewed-by: Johan Hovold
> ---
> drivers/hi
re applying?
> attribute-groups.
>
> Signed-off-by: Janne Kanniainen
Reviewed-by: Johan Hovold
Otherwise both patches (v6) are ready to be merged, Bryan.
Thanks, Janne!
Johan
> ---
>
> Changes in v3:
> - Style fixes
> - Rename sysfs-class-hid-driver-gt683
On Wed, Jun 25, 2014 at 09:13:09PM +0300, Janne Kanniainen wrote:
> Move led_mode attribute from HID device to led-class devices and rename it
> msi_mode. This will also fix race condition by using attribute-groups.
>
> Signed-off-by: Janne Kanniainen
> ---
>
> Changes in v3:
> - Style fix
On Wed, Jun 25, 2014 at 03:55:10PM -0700, Bryan Wu wrote:
> On Wed, Jun 25, 2014 at 12:09 PM, Jiri Kosina wrote:
> > On Wed, 25 Jun 2014, Johan Hovold wrote:
> >
> >> Did you see the attribute-race series I posted? Not sure how best to
> >> handle the dependency,
On Sat, Jun 28, 2014 at 02:44:09PM +0200, Fabian Frederick wrote:
> Cc: Johan Hovold
> Cc: Greg Kroah-Hartman
> Cc: linux-...@vger.kernel.org
> Signed-off-by: Fabian Frederick
Applied, thanks.
Johan
> ---
> drivers/usb/serial/mos7840.c | 5 +
> 1 file chang
On Fri, Jun 27, 2014 at 02:50:11PM +0200, and...@mail.sth.sze.hu wrote:
> From: Andras Kovacs
>
> Corsair USB Dongles are shipped with Corsair AXi series PSUs.
> These are cp210x serial usb devices, so make driver detect these.
> I have a program, that can get information from these PSUs.
>
> Te
On Wed, Jul 02, 2014 at 12:36:48PM +0300, Bernd Wachter wrote:
>
> Add ID of the Telewell 4G v2 hardware to option driver to get legacy
> serial interface working
>
>
> Signed-off-by: Bernd Wachter
Applied, thanks.
Johan
> ---
> --- linux-3.15.3/drivers/usb/serial/option.c.orig 2014-07-0
On Sun, Jun 01, 2014 at 11:31:17AM +0200, Johan Hovold wrote:
> On Sat, May 31, 2014 at 01:03:00PM -0300, Peter Senna Tschudin wrote:
> > This patch remove the function klsi_105_tiocmset which was only
> > returning -EINVAL. It also removes the function prototype and
> > the .
[ +CC: Jiri, linux-input, linux-usb (again) ]
First of all, please reply to the original thread and make sure to not
drop people or lists from CC.
On Fri, Jun 06, 2014 at 12:29:06AM +0300, Janne Kanniainen wrote:
> This driver adds support for USB controlled led panels that exist in
> MSI GT683R
On Sat, Jun 07, 2014 at 01:12:39PM +0300, Janne Kanniainen wrote:
> > First of all, please reply to the original thread and make sure to not
> > drop people or lists from CC.
>
> Sorry this is my first patch and i didn't know that. Now I know.
>
> > For arrays you can use the ARRAY_SIZE() macro i
On Mon, Jun 09, 2014 at 03:21:55PM +0200, Sascha Silbe wrote:
> Most FTDI USB serial / parallel adapter chips support an asynchronous
> "bitbang" mode. Make this functionality available as a GPIO controller
> so they can be used with the Linux GPIO API instead of requiring
> special user space soft
On Wed, Jun 11, 2014 at 12:21:39AM +0300, Janne Kanniainen wrote:
> This driver adds support for USB controlled led panels that exists in MSI
> GT683R laptop
Can you break this line by 72 columns or so as well?
> Changes in v2:
> - sorted headers to alphabetic order
> - using devm_kz
On Wed, Jun 11, 2014 at 01:25:49PM +0200, Jiri Kosina wrote:
> On Wed, 11 Jun 2014, Janne Kanniainen wrote:
>
> > This driver adds support for USB controlled led panels that exists in MSI
> > GT683R laptop
> >
> > Changes in v2:
> > - sorted headers to alphabetic order
> > - using devm_k
On Wed, Jun 11, 2014 at 04:05:42PM +0200, Johan Hovold wrote:
> On Wed, Jun 11, 2014 at 12:21:39AM +0300, Janne Kanniainen wrote:
> > +static const char gt683r_led_select_leds[GT683R_BUFFER_SIZE] = { 0x01,
> > 0
On Wed, Jun 11, 2014 at 04:05:42PM +0200, Johan Hovold wrote:
>
On Wed, Jun 11, 2014 at 12:21:39AM +0300, Janne Kanniainen wrote:
> > +static int gt683r_led_snd_msg(struct gt683r_led *led, char *msg)
> > +{
> > + int ret;
> > +
> > + ret = hid_hw
On Thu, Jun 12, 2014 at 01:48:41AM +0300, Janne Kanniainen wrote:
> This driver adds support for USB controlled led panels that exists in MSI
> GT683R laptop
You forgot to break this line.
>
> Signed-off-by: Janne Kanniainen
> ---
> Changes in v2:
> - sorted headers to alphabetic order
On Thu, Jun 12, 2014 at 11:34:12PM +0300, Janne Kanniainen wrote:
> This driver adds support for USB controlled led panels that exists in
> MSI GT683R laptop
>
> Signed-off-by: Janne Kanniainen
> ---
> Changes in v2:
> - sorted headers to alphabetic order
> - using devm_kzalloc
>
On Tue, Mar 25, 2014 at 07:00:51PM +, Michele Baldessari wrote:
> Custom VID/PID for Brainboxes VX-001 ExpressCard RS232 as reported in
> https://bugzilla.redhat.com/show_bug.cgi?id=1071914
Thanks for the patch.
How about including the other PIDs listed in the report (in the attached
udev-ru
On Sat, Mar 29, 2014 at 08:55:11PM +, Michele Baldessari wrote:
> Custom VID/PIDs for Brainboxes cards as reported in
> https://bugzilla.redhat.com/show_bug.cgi?id=1071914
Thanks for including the remaining PIDs from the report.
There was a duplicate entry in the device-id table below, but I'
From: Michele Baldessari
Custom VID/PIDs for Brainboxes cards as reported in
https://bugzilla.redhat.com/show_bug.cgi?id=1071914
Signed-off-by: Michele Baldessari
Cc: stable
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ftdi_sio.c | 33 +
drivers/usb
s, Dirk? 3.14 is still basically unusable with the
intel_pstate driver.
Any fixes or workarounds posted elsewhere that I can apply in the
meantime?
Thanks,
Johan
> > On 6 May 2014 22:05, Johan Hovold wrote:
> >> After updating my main system from v3.13 to v3.14.2, I found that the
On Mon, Apr 14, 2014 at 09:58:12PM +0200, Johan Hovold wrote:
> The current ACM runtime-suspend implementation is broken in several
> ways:
>
> Firstly, it buffers only the first write request being made while
> suspended -- any further writes are silently dropped.
>
> S
On Sat, May 24, 2014 at 12:59:07PM -0700, Greg Kroah-Hartman wrote:
> On Sat, May 24, 2014 at 04:42:42PM +0200, Johan Hovold wrote:
> > Could you please discard this one for now? I've found a couple of more
> > PM related problems and I'll submit a slight update of
thread is posted to linux-usb only.
Johan
Johan Hovold (61):
USB: sierra: fix AA deadlock in open error path
USB: sierra: fix use after free at suspend/resume
USB: sierra: fix urb and memory leak in resume error path
USB: sierra: fix urb and memory leak on disconnect
USB: sierra: fix rem
[ +CC: Greg, Doug, Stratos, Yuyang ]
On Wed, May 21, 2014 at 11:00:51AM +0200, Johan Hovold wrote:
> On Wed, May 07, 2014 at 07:10:49AM -0700, Dirk Brandewie wrote:
> > On 05/06/2014 10:40 PM, Viresh Kumar wrote:
> > > Cc'ing Dirk who is taking care of intel-pstate driver
On Sun, May 04, 2014 at 11:38:41AM -0400, Greg Kroah-Hartman wrote:
> 3.14-stable review patch. If anyone has any objections, please let me know.
This one should not be backported without commit
a2f8d6b30321 ("ARM: dts: am335x: update USB DT references")
which is in Linus' tree but is n
After updating my main system from v3.13 to v3.14.2, I found that the
git bash-completion was extremely sluggish. Completing a file name would
take roughly six rather than one second on this Haswell machine
(i7-4770). (Other things, such as git rebase, also felt slower, but
the completion issue was
On Wed, May 07, 2014 at 11:10:34AM +0530, Viresh Kumar wrote:
> Cc'ing Dirk who is taking care of intel-pstate driver.
>
> On 6 May 2014 22:05, Johan Hovold wrote:
> > After updating my main system from v3.13 to v3.14.2, I found that the
> > git bash-completion was extr
These patches against v3.15-rc4 fix a few issues in the cpsw and
mdio-gpio drivers.
Johan
Johan Hovold (5):
net: mdio-gpio: fix device-tree binding documentation
net: mdio-gpio: warn about missing bus alias id
Revert "net: eth: cpsw: Correctly attach to GPIO bitbang MDIO driver&q
Use a sane default bus id (rather than -ENODEV) and print a warning when
the bus alias id is missing.
Signed-off-by: Johan Hovold
---
drivers/net/phy/mdio-gpio.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/phy/mdio-gpio.c b/drivers/net/phy/mdio-gpio.c
index 9c4defdec67b
Add missing of_node_put to avoid kref leak.
Signed-off-by: Johan Hovold
---
drivers/net/ethernet/ti/cpsw.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index db9360cd861c..c331b7ebc812 100644
--- a/drivers/net/ethernet/ti
Fix aliases syntax in device-tree binding example to avoid
copy-paste errors (the alias would be dropped silently).
Signed-off-by: Johan Hovold
---
Documentation/devicetree/bindings/net/mdio-gpio.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree
These patches against v3.15-rc4 fix a few issues in the cpsw and
mdio-gpio drivers.
Resend with proper stable CC (git send-email still fails to parse the
#-part of the tag unless address is enclosed in <> it seems).
Sorry about the noise.
Johan
Johan Hovold (5):
net: mdio-gpio: fix
Fix aliases syntax in device-tree binding example to avoid
copy-paste errors (the alias would be dropped silently).
Signed-off-by: Johan Hovold
---
Documentation/devicetree/bindings/net/mdio-gpio.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree
Cc: Stefan Roese
Cc: stable # v3.14
Signed-off-by: Johan Hovold
---
drivers/net/ethernet/ti/cpsw.c | 14 ++
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index 36aa109416c4..18d83d8d7f74 100644
Add missing of_node_put to avoid kref leak.
Signed-off-by: Johan Hovold
---
drivers/net/ethernet/ti/cpsw.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index db9360cd861c..c331b7ebc812 100644
--- a/drivers/net/ethernet/ti
Use a sane default bus id (rather than -ENODEV) and print a warning when
the bus alias id is missing.
Signed-off-by: Johan Hovold
---
drivers/net/phy/mdio-gpio.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/phy/mdio-gpio.c b/drivers/net/phy/mdio-gpio.c
index 9c4defdec67b
Fix null-pointer dereference at probe when the mdio platform device is
missing (e.g. when it has been disabled in DT).
Cc: stable # v3.8
Signed-off-by: Johan Hovold
---
drivers/net/ethernet/ti/cpsw.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/ti/cpsw.c b
Make sure ethernet and mdio nodes are disabled by default and enable
them explicitly only on boards that actually use them.
Signed-off-by: Johan Hovold
---
arch/arm/boot/dts/am335x-bone-common.dtsi | 3 ++-
arch/arm/boot/dts/am335x-evm.dts | 2 ++
arch/arm/boot/dts/am335x-evmsk.dts
On Thu, May 29, 2014 at 07:27:34PM -0700, Greg Kroah-Hartman wrote:
> On Wed, May 28, 2014 at 09:59:45AM +0200, Johan Hovold wrote:
> > [ +CC: Greg, Doug, Stratos, Yuyang ]
> >
> > On Wed, May 21, 2014 at 11:00:51AM +0200, Johan Hovold wrote:
> > > On Wed, May 07,
On Thu, May 29, 2014 at 04:09:48PM -0700, Andrew Morton wrote:
> On Fri, 9 May 2014 18:36:52 +0200 Johan Hovold wrote:
>
> > On Thu, May 08, 2014 at 07:28:04PM +0200, Boris BREZILLON wrote:
> >
> > > > You should also keep the flush (read of IMR) regardless (to m
On Sat, May 31, 2014 at 10:14:01AM -0300, Peter Senna Tschudin wrote:
> This patch remove variables that are initialized with a constant,
> are never updated, and are only used as parameter of return.
> Return the constant instead of using a variable.
>
> Verified by compilation only.
>
> The coc
ompilation only.
>
> Signed-off-by: Peter Senna Tschudin
Signed-off-by: Johan Hovold
> ---
> Changes from V1:
> - remove the function klsi_105_tiocmset instead of simplifying it
> - remove the function prototype
> - remove the .tiocmset entry in the struct usb_serial_driver
&g
Remove the remaining two obsolete usb-serial subdriver entries from
MAINTAINERS, which were missed in the recent purge by commit
f896b7968b62 ("USB: Maintainers change for usb serial drivers").
Signed-off-by: Johan Hovold
---
MAINTAINERS | 12
1 file changed, 12 deletion
On Sun, Jun 01, 2014 at 10:45:59AM -0700, Greg Kroah-Hartman wrote:
> On Sun, Jun 01, 2014 at 11:32:17AM +0200, Johan Hovold wrote:
> > Remove the remaining two obsolete usb-serial subdriver entries from
> > MAINTAINERS, which were missed in the recent purge by commit
> &g
On Mon, Jun 02, 2014 at 10:25:39AM -0400, Mike Remski wrote:
> Please CC me as not subscribed to list.
> Third party device, with FTDI chip on it. Get this when plugging device
> in. Discovered in kernel 2.6.32
Wow, that kernel is ancient. Please upgrade to a more recent kernel such
as v3.14.5,
[ Please avoid top-posting. ]
On Mon, Jun 02, 2014 at 11:16:11AM -0400, Mike Remski wrote:
> Thanks Johan, that's why I looked at the cross references for ftdi_sio.c
> over on
> http://lxr.free-electrons.com/source/drivers/usb/serial/ftdi_sio.c,
> latest version it's showing is 3.14. It appears
On Mon, Jun 02, 2014 at 12:02:40PM -0400, Mike Remski wrote:
> On 06/02/2014 11:40 AM, Johan Hovold wrote:
> > [ Please avoid top-posting. ]
> >
> > On Mon, Jun 02, 2014 at 11:16:11AM -0400, Mike Remski wrote:
> >> Thanks Johan, that's why I looked at the cross
On Mon, Jun 02, 2014 at 12:24:44PM -0400, Mike Remski wrote:
> On 06/02/2014 12:20 PM, Johan Hovold wrote:
> > On Mon, Jun 02, 2014 at 12:02:40PM -0400, Mike Remski wrote:
> >> On 06/02/2014 11:40 AM, Johan Hovold wrote:
> >>> [ Please avoid top-posting. ]
> >&g
On Mon, Jun 02, 2014 at 01:11:37PM -0400, Mike Remski wrote:
> On 06/02/2014 12:49 PM, Johan Hovold wrote:
> > On Mon, Jun 02, 2014 at 12:24:44PM -0400, Mike Remski wrote:
> >> On 06/02/2014 12:20 PM, Johan Hovold wrote:
> >>> On Mon, Jun 02, 2014 at 12:02:40PM -0400
On Tue, Jun 03, 2014 at 06:17:33AM -0400, Mike Remski wrote:
> On 06/02/2014 01:46 PM, Johan Hovold wrote:
> > On Mon, Jun 02, 2014 at 01:11:37PM -0400, Mike Remski wrote:
> >> On 06/02/2014 12:49 PM, Johan Hovold wrote:
> >>> On Mon, Jun 02, 2014 at 12:24:44PM -0400
On Wed, Jun 04, 2014 at 10:29:37AM -0400, Mike Remski wrote:
> On 06/04/2014 10:19 AM, Johan Hovold wrote:
> > >From 4ddea3a573b8c15beefb67bc35c440850063d79d Mon Sep 17 00:00:00 2001
> > From: Johan Hovold
> > Date: Wed, 4 Jun 2014 14:09:43 +0200
> > Subject: [PATC
On Wed, Jun 04, 2014 at 10:55:28AM -0400, Mike Remski wrote:
> On 06/04/2014 10:52 AM, Johan Hovold wrote:
> > On Wed, Jun 04, 2014 at 10:29:37AM -0400, Mike Remski wrote:
> >> On 06/04/2014 10:19 AM, Johan Hovold wrote:
> >>> >From 4ddea3a573b8c15beefb67bc35c44085
On Wed, Jun 04, 2014 at 11:41:47AM -0400, Mike Remski wrote:
> Ok, had a chance to try the cdc-acm; yes it's the ancient one that is
> in the base install of CentOS 6.4 (2.6.32-71.29.1 centos patched). I'm
> hitting something similar; I noticed there where a few commits for NULL
> pointer der
On Wed, Jun 04, 2014 at 01:05:03PM -0400, Mike Remski wrote:
> On 06/04/2014 12:00 PM, Johan Hovold wrote:
> > On Wed, Jun 04, 2014 at 11:41:47AM -0400, Mike Remski wrote:
> >> Ok, had a chance to try the cdc-acm; yes it's the ancient one that is
> >> in the ba
[ +CC: linux-usb ]
On Sat, May 31, 2014 at 06:46:44PM +0300, Janne Kanniainen wrote:
> This driver adds support for USB controlled led panels that exist in MSI
> GT683R laptop.
>
> Signed-off-by: Janne Kanniainen
> ---
> drivers/leds/Kconfig | 6 ++
> drivers/leds/Makefile | 1 +
On Sun, Jun 15, 2014 at 05:59:40PM +0300, Janne Kanniainen wrote:
> >> Ok, so you decided to continue setting mode on every LED brightness
> >> update. That should be fine, but you never answered my question about
> >> whether it is necessary?
> >
> > I decided to do it that way because official dr
On Sun, Jun 15, 2014 at 02:23:25AM +0300, Janne Kanniainen wrote:
> > Hi!
>
> Hi.
>
> >> --- /dev/null
> >> +++ b/Documentation/ABI/testing/sysfs-class-hid-driver-gt683r
> >> @@ -0,0 +1,10 @@
> >> +What:/sys/class/hidraw//device/state
> >> +Date:Jun 2014
> >> +Kern
On Tue, Jun 17, 2014 at 01:01:55AM +0300, Janne Kanniainen wrote:
> This driver adds support for USB controlled led panels that exists in
> MSI GT683R laptop
>
> Signed-off-by: Janne Kanniainen
> ---
> Changes in v2:
> - sorted headers to alphabetic order
> - using devm_kzalloc
>
On Tue, Jun 17, 2014 at 07:41:44PM +0300, Janne Kanniainen wrote:
> This driver adds support for USB controlled led panels that exists in
> MSI GT683R laptop
>
> Changes in v2:
> - sorted headers to alphabetic order
> - using devm_kzalloc
> - using BIT(n)
> - using usb_cont
I'll be using my kernel.org address for upstream work from now on so
update my MAINTAINERS entry.
Signed-off-by: Johan Hovold
---
Greg, I intend to include this one in my upcoming v3.16-rc pull request.
Johan
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
On Tue, Jun 03, 2014 at 02:01:57PM +0200, Matthias Urlichs wrote:
> Hi,
>
> Matthias Urlichs:
> > Fine by me.
>
> or, in other words:
>
> Signed-Off-By: Matthias Urlichs
I've now applied this to my usb-linus branch with yours and Oliver's
signed-offs.
Thanks,
Johan
--
To unsubscribe from this
On Mon, Jun 23, 2014 at 04:35:13PM +0200, Oliver Neukum wrote:
> On Wed, 2014-06-18 at 19:05 +0300, Janne Kanniainen wrote:
> > This driver adds support for USB controlled led panels that exists in
> > MSI GT683R laptop
> >
>
> > +static int gt683r_led_probe(struct hid_device *hdev,
> > +
On Mon, Jun 23, 2014 at 08:16:48PM +0300, Janne Kanniainen wrote:
> This driver adds support for USB controlled led panels that exists in
> MSI GT683R laptop
>
> Signed-off-by: Janne Kanniainen
> ---
> Changes in v2:
> - sorted headers to alphabetic order
> - using devm_kzalloc
>
On Mon, Jun 23, 2014 at 02:24:32PM -0400, Greg KH wrote:
> On Mon, Jun 23, 2014 at 02:23:24PM -0400, Greg KH wrote:
> > On Mon, Jun 23, 2014 at 08:16:48PM +0300, Janne Kanniainen wrote:
> > > + ret = sysfs_create_group(&led->hdev->dev.kobj, >683r_attribute_group);
> > > + if (ret) {
> > > +
On Mon, Jun 23, 2014 at 03:40:59PM -0400, Greg KH wrote:
> On Mon, Jun 23, 2014 at 09:31:34PM +0200, Johan Hovold wrote:
> > On Mon, Jun 23, 2014 at 02:24:32PM -0400, Greg KH wrote:
> > > On Mon, Jun 23, 2014 at 02:23:24PM -0400, Greg KH wrote:
> > > > On Mon, Ju
On Mon, Jun 23, 2014 at 04:24:48PM -0400, Greg KH wrote:
> On Mon, Jun 23, 2014 at 09:52:12PM +0200, Johan Hovold wrote:
> > On Mon, Jun 23, 2014 at 03:40:59PM -0400, Greg KH wrote:
> > > On Mon, Jun 23, 2014 at 09:31:34PM +0200, Johan Hovold wrote:
> > > > On Mon, Ju
On Tue, Jun 24, 2014 at 03:10:43PM +0200, Bjørn Mork wrote:
> Johan Hovold writes:
>
> > This is a non-standard attribute of this particular laptop. It has three
> > individual LEDs that can be enabled separately (using standard LED class
> > attributes), but they will
trs[] = {
&dev_attr_msi_mode.attr,
NULL,
};
ATTRIBUTE_GROUPS(gt683r_led);
and then set .groups to gt683r_led_groups.
I have started fixing some of the other led drivers and I'll try to
submit a series (including the below patch) later today.
Allow led-class devices to be created with optional attribute groups.
This is needed in order to allow led drivers to create custom device
attributes in a race-free manner.
Signed-off-by: Johan Hovold
---
drivers/leds/led-class.c | 5 +++--
include/linux/leds.h | 2 ++
2 files changed, 5
Use the attribute groups of the led-class to create the mode attribute
during probe in order to avoid racing with userspace.
Signed-off-by: Johan Hovold
---
drivers/leds/leds-lm3530.c | 20 +++-
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/drivers/leds/leds
Use the attribute groups of the led-class to create the mode attribute
during probe in order to avoid racing with userspace.
Signed-off-by: Johan Hovold
---
drivers/leds/leds-max8997.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/drivers/leds/leds-max8997
Use the attribute groups of the led-class to create the src attribute
during probe in order to avoid racing with userspace.
Signed-off-by: Johan Hovold
---
drivers/leds/leds-wm831x-status.c | 23 +--
1 file changed, 9 insertions(+), 14 deletions(-)
diff --git a/drivers/leds
Use the attribute groups of the led-class to create the blink attribute
during probe in order to avoid racing with userspace.
Signed-off-by: Johan Hovold
---
drivers/leds/leds-ss4200.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/leds/leds-ss4200.c
Use the attribute groups of the led-class to create the time attribute
during probe in order to avoid racing with userspace.
Signed-off-by: Johan Hovold
---
drivers/input/keyboard/lm8323.c | 22 +-
1 file changed, 9 insertions(+), 13 deletions(-)
diff --git a/drivers/input
Make sure the sysfs group is removed when the LEDs are unregistered.
Signed-off-by: Johan Hovold
---
drivers/leds/leds-lp55xx-common.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/leds/leds-lp55xx-common.c
b/drivers/leds/leds-lp55xx-common.c
index 88317b4f7bf3..3fbfb31602c7
Use the attribute groups of the led-class to create the LED attributes
during probe in order to avoid racing with userspace.
Signed-off-by: Johan Hovold
---
drivers/leds/leds-lp55xx-common.c | 22 +++---
1 file changed, 3 insertions(+), 19 deletions(-)
diff --git a/drivers/leds
Use the attribute groups of the led-class to create the attributes
during probe in order to avoid racing with userspace.
Signed-off-by: Johan Hovold
---
drivers/leds/leds-lm3533.c | 20
1 file changed, 8 insertions(+), 12 deletions(-)
diff --git a/drivers/leds/leds-lm3533
to remove the attribute group it is currently
creating, something which is fixed separately.
Note that this series include one driver from drivers/input/keyboard.
The individual led-driver patches have been compile tested only.
Johan
Johan Hovold (13):
leds: add led-class attribute-group
Use the attribute groups of the led-class to create the flash and
torch-LED attributes during probe in order to avoid racing with
userspace.
Signed-off-by: Johan Hovold
---
drivers/leds/leds-lm3642.c | 30 ++
1 file changed, 14 insertions(+), 16 deletions(-)
diff
Use the attribute groups of the led-class to create the sata attribute
during probe in order to avoid racing with userspace.
Signed-off-by: Johan Hovold
---
drivers/leds/leds-netxbig.c | 26 --
1 file changed, 12 insertions(+), 14 deletions(-)
diff --git a/drivers/leds
attribute before LM3554 support was added).
Signed-off-by: Johan Hovold
---
drivers/leds/leds-lm355x.c | 21 +
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/drivers/leds/leds-lm355x.c b/drivers/leds/leds-lm355x.c
index 591eb5e58ae3..f5112cb2d991 100644
--- a/drivers
Use the attribute groups of the led-class to create the sata attribute
during probe in order to avoid racing with userspace.
Signed-off-by: Johan Hovold
---
drivers/leds/leds-ns2.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/drivers/leds/leds-ns2.c b
On Wed, Jun 25, 2014 at 06:59:26PM +0300, Janne Kanniainen wrote:
> Use attribute-groups to fix race condition.
The primary thing you're doing here is moving and renaming the attribute
to the led class devices, so you need to mention that (and update the
patch subject). But you can mention the rac
On Sun, Feb 02, 2014 at 12:10:56PM +0100, Ulrich Hahn wrote:
Please use a more descriptive subject line (which will end up as the
commit log summary), e.g.
"[PATCH v3] USB: ftdi_sio: add Tagsys RFID Reader ids"
Note that the patch version should go in the [PATCH vX] (which will not
show
ary delays before enabling the
backlight at boot. The second patch fixes this by making sure
pwm-devices are probed before any backlight devices.
Johan
Johan Hovold (2):
misc: atmel_pwm: add deferred-probing support
misc: atmel_pwm: set initcall level to subsys
drivers/misc/atmel_
Even with the atmel_pwm driver and the atmel-pwm-bl backlight driver
supporting deferred probing, we still want to make sure that any
pwm-device is available when the backlight devices are probed to avoid
any unnecessary delays before enabling the backlight.
Signed-off-by: Johan Hovold
.
Signed-off-by: Johan Hovold
---
drivers/misc/atmel_pwm.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/atmel_pwm.c b/drivers/misc/atmel_pwm.c
index 494d050..a6dc56e 100644
--- a/drivers/misc/atmel_pwm.c
+++ b/drivers/misc/atmel_pwm.c
@@ -90,8 +90,10 @@ int
Add missing module device table which is needed for module autoloading.
Signed-off-by: Johan Hovold
---
drivers/video/atmel_lcdfb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
index 088511a..67b339c 100644
--- a/drivers/video
1201 - 1300 of 2826 matches
Mail list logo
