On Tue, Oct 22, 2013 at 06:32:39PM +0200, Johan Hovold wrote:
> Two drivers (atmel-pwm-bl and leds-atmel-pwm) currently depend on the
> atmel_pwm driver to have bound to any pwm-device before their devices
> are probed.
>
> Support deferred probing of such devices by making
On Tue, Oct 29, 2013 at 11:15:21PM +0100, Andrew Lunn wrote:
> On Tue, Oct 29, 2013 at 07:17:46PM +0100, Johan Hovold wrote:
> > On Wed, Oct 23, 2013 at 01:18:21PM +0200, Andrew Lunn wrote:
> > > Add the missing C_MSPAR(tty) macro.
> >
> > Please rename the macro
tries for USB serial drivers
> that don't make sense anymore, given that the developers are no longer
> around, and individual driver maintainerships for tiny things like this
> is pretty pointless.
>
> Cc: Johan Hovold
> Signed-off-by: Greg Kroah-Hartman
Acked-by: Johan Hov
On Wed, Oct 30, 2013 at 09:46:17PM +0100, Arnd Bergmann wrote:
> On Wednesday 30 October 2013, Johan Hovold wrote:
> > > I really hate this type of patch, as it's papering over the real
> > > problem. What happens when someone else moves their driver to this
> > &g
On Thu, Oct 31, 2013 at 06:30:37AM +0100, Jean-Christophe PLAGNIOL-VILLARD
wrote:
> On 09:19 Thu 31 Oct , Bo Shen wrote:
> > Hi Arnd,
> >
> > On 10/31/2013 04:46, Arnd Bergmann wrote:
> > >On Wednesday 30 October 2013, Johan Hovold wrote:
> > >>
Use devm_gpio_request_one rather than requesting and setting direction
in two calls.
Cc: Jingoo Han
Signed-off-by: Johan Hovold
---
drivers/video/backlight/atmel-pwm-bl.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/video/backlight/atmel-pwm-bl.c
Clean up probe error handling by checking parameters before any
allocations and removing an obsolete error label. Also remove
unnecessary reset of private gpio number.
Acked-by: Jingoo Han
Signed-off-by: Johan Hovold
---
drivers/video/backlight/atmel-pwm-bl.c | 31
Make sure to honour gpio polarity also at remove so that the backlight
is actually disabled on boards with active-low enable pin.
Cc: sta...@vger.kernel.org
Acked-by: Jingoo Han
Signed-off-by: Johan Hovold
---
drivers/video/backlight/atmel-pwm-bl.c | 6 --
1 file changed, 4 insertions
The driver supports 16-bit brightness values, but the value returned
from get_brightness was truncated to eight bits.
Cc: sta...@vger.kernel.org
Signed-off-by: Johan Hovold
---
drivers/video/backlight/atmel-pwm-bl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
Add helper function to control the gpio_on signal.
Acked-by: Jingoo Han
Signed-off-by: Johan Hovold
---
drivers/video/backlight/atmel-pwm-bl.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/drivers/video/backlight/atmel-pwm-bl.c
b/drivers/video
Add missing module alias which is needed for module autoloading.
Acked-by: Jingoo Han
Signed-off-by: Johan Hovold
---
drivers/video/backlight/atmel-pwm-bl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/atmel-pwm-bl.c
b/drivers/video/backlight/atmel-pwm-bl.c
9/9)
Johan Hovold (9):
backlight: atmel-pwm-bl: fix reported brightness
backlight: atmel-pwm-bl: fix gpio polarity in remove
backlight: atmel-pwm-bl: fix module autoload
backlight: atmel-pwm-bl: clean up probe error handling
backlight: atmel-pwm-bl: clean up get_intensity
backlight
Remove unused include of clk.h.
Acked-by: Jingoo Han
Signed-off-by: Johan Hovold
---
drivers/video/backlight/atmel-pwm-bl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/backlight/atmel-pwm-bl.c
b/drivers/video/backlight/atmel-pwm-bl.c
index abfaada..bfd6a96 100644
--- a
Use gpio_is_valid rather than open coding the more restrictive != -1
test.
Acked-by: Jingoo Han
Signed-off-by: Johan Hovold
---
drivers/video/backlight/atmel-pwm-bl.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/video/backlight/atmel-pwm-bl.c
b/drivers
Clean up get_intensity to increase readability.
Acked-by: Jingoo Han
Signed-off-by: Johan Hovold
---
drivers/video/backlight/atmel-pwm-bl.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/video/backlight/atmel-pwm-bl.c
b/drivers/video/backlight/atmel
ll+0x0/0x48)
Signed-off-by: Johan Hovold
---
I got this new lockdep warning with 3.15-rc, but this dates back to at
least 0daeed381c6a ("USB-BKL: Remove BKL use for usb serial driver
probing").
As far as I can tell, moving driver deregistration out of the table lock
should be fine. Anoth
On Thu, Apr 24, 2014 at 10:35:17AM -0400, Tejun Heo wrote:
> On Thu, Apr 24, 2014 at 04:29:15PM +0800, Li Zhong wrote:
> > On Wed, 2014-04-23 at 10:19 -0400, Tejun Heo wrote:
> > > cc'ing Li Zhong who's working on a simliar issue in the following
> > > thread and quoting whole body.
> > >
> > >
On Wed, Jul 30, 2014 at 12:57:09AM +0800, Wang YanQing wrote:
> PL2303HX has two GPIOs, this patch add interface for it.
>
> Signed-off-by: Wang YanQing
> ---
> Changes v5-v6:
> 1: fix typo error in Kconfig reported by Andreas Mohr
> 2: add const qulification to gpio_dir_mask and gpio_value_ma
On Wed, Sep 17, 2014 at 10:25:18AM +0300, Octavian Purdila wrote:
> On Wed, Sep 17, 2014 at 2:21 AM, Lee Jones wrote:
> >
> > On Tue, 09 Sep 2014, Octavian Purdila wrote:
> >
> > > This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO
> > > Master Adapter DLN-2. Details about the devic
On Tue, Sep 09, 2014 at 10:24:44PM +0300, Octavian Purdila wrote:
> This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO
> Master Adapter DLN-2. Details about the device can be found here:
>
> https://www.diolan.com/i2c/i2c_interface.html.
>
> Information about the USB protocol can b
On Tue, Sep 09, 2014 at 10:24:45PM +0300, Octavian Purdila wrote:
> From: Laurentiu Palcu
>
> This patch adds support for the Diolan DLN-2 I2C master module. Due
> to hardware limitations it does not support SMBUS quick commands.
>
> Information about the USB protocol interface can be found in t
On Wed, Sep 17, 2014 at 01:07:51PM +0300, Octavian Purdila wrote:
> On Wed, Sep 17, 2014 at 12:44 PM, Johan Hovold wrote:
>
>
>
> >> + /*
> >> + * Buffer to hold the packet for read or write transfers. One
> >> + * is enough si
On Thu, Sep 18, 2014 at 11:49:19AM +0300, Octavian Purdila wrote:
> On Thu, Sep 18, 2014 at 11:19 AM, Johan Hovold wrote:
> > On Wed, Sep 17, 2014 at 01:07:51PM +0300, Octavian Purdila wrote:
> >> On Wed, Sep 17, 2014 at 12:44 PM, J
On Tue, Sep 09, 2014 at 10:24:46PM +0300, Octavian Purdila wrote:
> +#define DLN2_GPIO_DIRECTION_IN 0
> +#define DLN2_GPIO_DIRECTION_OUT 1
> +
> +static int dln2_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
> +{
> + int ret;
> + struct dln2_gpio
On Tue, Sep 09, 2014 at 10:24:44PM +0300, Octavian Purdila wrote:
> +static int alloc_rx_slot(struct dln2_mod_rx_slots *rxs)
> +{
> + int ret;
> + int slot;
> +
> + /* No need to timeout here, the wait is bounded by the timeout
> + * in _dln2_transfer
> + */
> + ret = wai
On Thu, Sep 18, 2014 at 03:43:07PM +0300, Octavian Purdila wrote:
> On Thu, Sep 18, 2014 at 1:54 PM, Johan Hovold wrote:
> > On Tue, Sep 09, 2014 at 10:24:46PM +0300, Octavian Purdila wrote:
> > Either way, it looks like this could race with get_direction() if you
> > get a
On Tue, Sep 09, 2014 at 10:24:44PM +0300, Octavian Purdila wrote:
> +MODULE_AUTHOR("Octavian Purdila ");
> +MODULE_DESCRIPTION(DRIVER_NAME " driver");
> +MODULE_LICENSE("GPL");
Just noticed both the i2c and gpio driver is lacking a MODULE_ALIAS to
enable module auto-loading.
Johan
--
To unsubscr
On Thu, Sep 18, 2014 at 06:54:34PM +0300, Octavian Purdila wrote:
> On Thu, Sep 18, 2014 at 3:46 PM, Johan Hovold wrote:
> > On Thu, Sep 18, 2014 at 03:43:07PM +0300, Octavian Purdila wrote:
> >> On Thu, Sep 18, 2014 at 1:54 PM, Johan Hovold wrote:
> >> > On Tue, Se
On Mon, Sep 22, 2014 at 09:50:43AM +0200, Andreas Bomholtz wrote:
> Added the Seluxit ApS USB Serial Dongle to cp210x driver.
>
> Signed-off-by: Andreas Bomholtz
> ---
Thanks for resending. Applied just fine now.
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" i
On Mon, Sep 22, 2014 at 03:02:52PM +0530, Muthu Mani wrote:
> Adds support for USB-I2C/GPIO interfaces of Cypress Semiconductor
> CYUSBS234 USB-Serial Bridge controller.
>
> Details about the device can be found at:
> http://www.cypress.com/?rID=84126
Ok, so this is a bit of an odd bird.
First o
On Mon, Sep 22, 2014 at 03:03:46PM +0530, Muthu Mani wrote:
> Adds support for USB-I2C interface of Cypress Semiconductor
> CYUSBS234 USB-Serial Bridge controller.
>
> The read/write operation is setup using vendor command through
> control endpoint and actual data transfer happens through
> bulk
On Mon, Sep 22, 2014 at 03:04:18PM +0530, Muthu Mani wrote:
> Adds support for USB-GPIO interface of Cypress Semiconductor
> CYUSBS234 USB-Serial Bridge controller.
>
> The GPIO get/set can be done through vendor command
> on control endpoint.
>
> Details about the device can be found at:
> http:
On Mon, Sep 22, 2014 at 11:10:54AM +0200, Boris BREZILLON wrote:
> The GPBR registers are not part of the RTT block and thus should not be
> defined in the reg property of the rtt node.
>
> Use syscon to provide a proper DT representation and reference the GPBR
> syscon device in a new "atmel,time
On Mon, Sep 22, 2014 at 11:10:57AM +0200, Boris BREZILLON wrote:
> Signed-off-by: Boris BREZILLON
> ---
> .../devicetree/bindings/rtc/atmel,at91sam9-rtc.txt | 23
> ++
> 1 file changed, 23 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/rtc/atmel,at91
[ Please don't drop people from CC. ]
On Mon, Sep 22, 2014 at 11:10:53AM +0200, Boris BREZILLON wrote:
> Add of_match_table to the existing driver so that rtc nodes defined in at91
> DTs can be attached to this driver.
That should be rtt nodes.
Johan
--
To unsubscribe from this list: send the li
On Mon, Sep 22, 2014 at 05:46:52PM +0300, Octavian Purdila wrote:
> Currently the I/O buffer is allocated part of the device status
> structure, potentially sharing the same cache line with other members
> in this structure.
>
> Allocate the buffer separately, to avoid the I/O operations corruptin
On Mon, Sep 22, 2014 at 07:19:37PM +0300, Octavian Purdila wrote:
> On Mon, Sep 22, 2014 at 7:08 PM, Johan Hovold wrote:
> > On Mon, Sep 22, 2014 at 05:46:52PM +0300, Octavian Purdila wrote:
> > Don't mix fixes and clean ups like this, but rather submit them as
> > se
On Mon, Sep 22, 2014 at 10:39:18PM +0300, Octavian Purdila wrote:
> Currently the I/O buffer is allocated part of the device status
> structure, potentially sharing the same cache line with other members
> in this structure.
>
> Allocate the buffer separately, to avoid the I/O operations corruptin
On Tue, Sep 23, 2014 at 09:35:41AM +0200, Johan Hovold wrote:
> On Mon, Sep 22, 2014 at 10:39:18PM +0300, Octavian Purdila wrote:
> > Currently the I/O buffer is allocated part of the device status
> > structure, potentially sharing the same cache line with other members
> &
I/O operations corrupting
> the device status structure due to cache line sharing.
>
> Compiled tested only as I don't have access to hardware.
>
> Signed-off-by: Octavian Purdila
Reviewed-by: Johan Hovold
> ---
> drivers/mfd/viperboard.c | 8
> incl
On Mon, Sep 22, 2014 at 05:42:42PM +0200, Boris BREZILLON wrote:
> Signed-off-by: Boris BREZILLON
> ---
> .../devicetree/bindings/rtc/atmel,at91sam9-rtc.txt | 23
> ++
> 1 file changed, 23 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/rtc/atmel,at91
On Tue, Sep 23, 2014 at 11:38:48AM +0200, Boris BREZILLON wrote:
> @@ -328,6 +328,7 @@ static int at91_rtc_probe(struct platform_device *pdev)
> struct sam9_rtc *rtc;
> int ret, irq;
> u32 mr;
> + unsigned intsclk_rate;
>
> irq = platform_g
an RTC"
Boris, perhaps you should also update the Kconfig entries for
RTC_DRV_AT91SAM9_RTT and RTC_DRV_AT91SAM9_GPBR to clarify that they are
only used for legacy booting (and otherwise have no effect)?
> With that, good description: thanks!
>
> Acked-by: Nicolas Ferre
>
> S
te).
> Doing this allows us to reference the clk thus preventing the CCF from
> disabling it during the "disable unused" phase.
>
> Signed-off-by: Boris BREZILLON
> Acked-by: Alexandre Belloni
> Acked-by: Nicolas Ferre
> Acked-by: Johan Hovol
On Wed, Sep 10, 2014 at 03:06:27PM -0400, Peter Hurley wrote:
> The tty core does not test tty->hw_stopped; remove from drivers
> which don't test it themselves.
>
> cc: Johan Hovold
> Signed-off-by: Peter Hurley
Acked-by: Johan Hovold
--
To unsubscribe from t
On Tue, Sep 23, 2014 at 09:44:48PM -0700, Greg Kroah-Hartman wrote:
> On Mon, Sep 22, 2014 at 10:52:56AM +0200, Johan Hovold wrote:
> > On Mon, Sep 22, 2014 at 09:50:43AM +0200, Andreas Bomholtz wrote:
> > > Added the Seluxit ApS USB Serial Dongle to cp210x driver.
> >
On Wed, Sep 24, 2014 at 11:12:06AM +0100, Lee Jones wrote:
> On Mon, 22 Sep 2014, Octavian Purdila wrote:
>
> > Currently the I/O buffer is allocated part of the device status
> > structure, potentially sharing the same cache line with other members
> > in this structure.
> >
> > Allocate the buf
On Fri, Sep 19, 2014 at 11:22:42PM +0300, Octavian Purdila wrote:
> This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO
> Master Adapter DLN-2. Details about the device can be found here:
>
> https://www.diolan.com/i2c/i2c_interface.html.
>
> Information about the USB protocol can b
On Fri, Sep 19, 2014 at 11:22:43PM +0300, Octavian Purdila wrote:
> +struct dln2_i2c {
> + struct platform_device *pdev;
> + struct i2c_adapter adapter;
> + u32 freq;
> + u32 min_freq;
> + u32 max_freq;
> + /*
> + * Buffer to hold the packet for read or write transfers
On Wed, Sep 24, 2014 at 10:54:51AM +0200, Linus Walleij wrote:
> On Fri, Sep 19, 2014 at 10:22 PM, Octavian Purdila
> wrote:
>
> > Some GPIO chips (e.g. the DLN2 USB adapter) have blocking get/set
> > operation but do not need a threaded irq handler.
> >
> > Signed-off-by: Octavian Purdila
>
>
On Wed, Sep 24, 2014 at 01:00:02PM +0100, Lee Jones wrote:
> On Wed, 24 Sep 2014, Johan Hovold wrote:
>
> > On Wed, Sep 24, 2014 at 11:12:06AM +0100, Lee Jones wrote:
> > > On Mon, 22 Sep 2014, Octavian Purdila wrote:
> > >
> > > > Currently the I/O buf
On Wed, Sep 24, 2014 at 03:34:08PM +0300, Octavian Purdila wrote:
> I can follow-up with a v3 3 patch series: first for the fix, second
> for the OOM & error path cleanup, third for devm conversion.
I'd include the error-path clean up bit in the devres conversion as that
is what it's really all a
On Fri, Sep 19, 2014 at 11:22:45PM +0300, Octavian Purdila wrote:
> +struct dln2_gpio {
> + struct platform_device *pdev;
> + struct gpio_chip gpio;
> +
> + /*
> + * Cache pin direction to save us one transfer, since the
> + * hardware has separate commands to read the in and
On Wed, Sep 24, 2014 at 04:36:22PM +0300, Octavian Purdila wrote:
> On Wed, Sep 24, 2014 at 1:48 PM, Johan Hovold wrote:
> > On Fri, Sep 19, 2014 at 11:22:42PM +0300, Octavian Purdila wrote:
>
>
>
> >> + * dln2_dev.mod_rx_slots and then the echo header field to ind
On Wed, Sep 24, 2014 at 05:54:15PM +0300, Octavian Purdila wrote:
> On Wed, Sep 24, 2014 at 4:54 PM, Johan Hovold wrote:
> > On Wed, Sep 24, 2014 at 04:36:22PM +0300, Octavian Purdila wrote:
> >> On Wed, Sep 24, 2014 at 1:48 PM, Johan Hovold wrote:
> >> > On Fri, Se
On Thu, Sep 25, 2014 at 01:25:24PM +0300, Octavian Purdila wrote:
> Johan, I think we don't really need the spinlock, the disconnect flag
> and an atomic counter should work. Do you see any issues with that?
No, you need to test and increment atomically so the lock is needed.
Consider what could
On Thu, Sep 25, 2014 at 01:41:16PM +0300, Octavian Purdila wrote:
> On Thu, Sep 25, 2014 at 1:30 PM, Johan Hovold wrote:
> > On Thu, Sep 25, 2014 at 01:25:24PM +0300, Octavian Purdila wrote:
> >
> >> Johan, I think we don't really need the spinlock, the disconnect fl
On Thu, Sep 25, 2014 at 05:43:16PM +0300, Octavian Purdila wrote:
> Switch to using devm_ allocation to simplify the error path. Also
> remove a redundant OOM error message.
>
> Signed-off-by: Octavian Purdila
> ---
> drivers/mfd/viperboard.c | 18 +-
> 1 file changed, 5 insertio
On Thu, Sep 25, 2014 at 05:43:17PM +0300, Octavian Purdila wrote:
Where's the commit message body?
> Signed-off-by: Octavian Purdila
> ---
> drivers/mfd/viperboard.c | 1 -
> include/linux/mfd/viperboard.h | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/mfd/viperboard.c
On Thu, Sep 25, 2014 at 06:29:48PM +0300, Octavian Purdila wrote:
> On Thu, Sep 25, 2014 at 6:07 PM, Johan Hovold wrote:
> > Still feels like the kind of clean up that should have a Tested-by.
>
> Unfortunately I do not have access to hardware to test.
On second thought, compile
I/O operations corrupting
> the device status structure due to cache line sharing.
>
> Compiled tested only as I don't have access to hardware.
>
> Signed-off-by: Octavian Purdila
Reviewed-by: Johan Hovold
> ---
> drivers/mfd/viperboard.c | 8
> incl
On Thu, Sep 25, 2014 at 06:41:36PM +0300, Octavian Purdila wrote:
> Switch to using devm_ allocation to simplify the error path. Also
> remove a redundant OOM error message.
>
> Signed-off-by: Octavian Purdila
Reviewed-by: Johan Hovold
> ---
> drivers/mfd
On Thu, Sep 25, 2014 at 06:41:37PM +0300, Octavian Purdila wrote:
> Remove pdev field from struct vpbrd as it is not used in the MFD
> driver or in any of the sub-drivers.
>
> Signed-off-by: Octavian Purdila
Reviewed-by: Johan Hovold
> ---
> drivers/mfd/viperboard.c
ell-id for platform devices. Note
that the final patch is a pre-requisite for this.
Johan
[1] http://marc.info/?l=linux-kernel&m=141094514827834&w=2
Johan Hovold (6):
mfd: viperboard: fix platform-device id collision
mfd: rtsx_usb: fix platform device-id collision
mfd: core: add h
-function devices to be registered
with PLATFORM_DEVID_AUTO while still having non-zero cell ids.
Signed-off-by: Johan Hovold
---
drivers/mfd/mfd-core.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
index 892d343193ad
Use mfd_add_hotplug_devices helper to register the subdevices.
Signed-off-by: Johan Hovold
---
drivers/mfd/rtsx_usb.c | 4 ++--
drivers/mfd/viperboard.c | 5 ++---
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/mfd/rtsx_usb.c b/drivers/mfd/rtsx_usb.c
index 78073e4b87e4
Hot-pluggable multi-function devices should always be registered with
PLATFORM_DEVID_AUTO to avoid name collisions on the platform bus. This
helper also hides the memory map and irq parameters, which aren't used
by hot-pluggable (e.g. USB-based) devices.
Signed-off-by: Johan Hovold
---
in
with error -17
Signed-off-by: Johan Hovold
---
drivers/mfd/viperboard.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/viperboard.c b/drivers/mfd/viperboard.c
index e00f5340ed87..3c2b8f9e3c84 100644
--- a/drivers/mfd/viperboard.c
+++ b/drivers/mfd/viperboard.
Use mfd_add_hotplug_devices helper to register the subdevices.
Compile-only tested.
Signed-off-by: Johan Hovold
---
drivers/hid/hid-sensor-hub.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
index
assigned the same address.
Signed-off-by: Johan Hovold
---
drivers/mfd/rtsx_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/rtsx_usb.c b/drivers/mfd/rtsx_usb.c
index 71f387ce8cbd..78073e4b87e4 100644
--- a/drivers/mfd/rtsx_usb.c
+++ b/drivers/mfd/rtsx_usb.c
On Thu, Sep 11, 2014 at 10:55:59AM +0200, Boris BREZILLON wrote:
> Johan, let me know if this version addresses part of your concerns.
Looks good to me. I just have a few minor comments on two of the patches.
> I'm open to any suggestion/rework to address other previously discussed
> issues, as
On Thu, Sep 11, 2014 at 10:56:04AM +0200, Boris BREZILLON wrote:
> The GPBR registers are not part of the RTT block and thus should not be
> defined in the reg property of the rtt node.
>
> Use syscon to provide a proper DT representation and reference the GPBR
> syscon device in a new "atmel,time
On Thu, Sep 11, 2014 at 10:56:07AM +0200, Boris BREZILLON wrote:
> Signed-off-by: Boris BREZILLON
> ---
> .../devicetree/bindings/rtc/atmel,at91sam9-rtc.txt | 24
> ++
> 1 file changed, 24 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/rtc/atmel,at91
On Thu, Sep 11, 2014 at 12:06:59PM +0200, Boris BREZILLON wrote:
> On Thu, 11 Sep 2014 11:39:42 +0200
> Johan Hovold wrote:
>
> > On Thu, Sep 11, 2014 at 10:55:59AM +0200, Boris BREZILLON wrote:
> >
> > > Johan, let me know if this version addresses part of your co
On Thu, Sep 25, 2014 at 11:20:12AM +0530, Muthu Mani wrote:
> Adds support for USB-I2C/GPIO interfaces of Cypress Semiconductor
> CYUSBS234 USB-Serial Bridge controller.
>
> Details about the device can be found at:
> http://www.cypress.com/?rID=84126
>
> Signed-off-by: Muthu Mani
> Signed-off-b
On Thu, Sep 25, 2014 at 05:46:16AM +, Muthu Mani wrote:
> > > +static int cy_i2c_xfer(struct i2c_adapter *adapter,
> > > +struct i2c_msg *msgs, int num) {
> > > + int ret = 0;
> > > + struct cyusbs_i2c *cy_i2c;
> > > + struct cyusbs23x *cyusbs = (struct cyusbs23
On Thu, Sep 25, 2014 at 11:21:15AM +0530, Muthu Mani wrote:
> Adds support for USB-I2C interface of Cypress Semiconductor
> CYUSBS234 USB-Serial Bridge controller.
>
> The read/write operation is setup using vendor command through control
> endpoint
> and actual data transfer happens through bulk
On Thu, Sep 25, 2014 at 11:21:58AM +0530, Muthu Mani wrote:
> Adds support for USB-GPIO interface of Cypress Semiconductor
> CYUSBS234 USB-Serial Bridge controller.
>
> The GPIO get/set can be done through vendor command on control endpoint.
>
> Details about the device can be found at:
> http://
On Tue, Sep 30, 2014 at 01:08:29PM +0200, Johan Hovold wrote:
> On Thu, Sep 25, 2014 at 11:21:58AM +0530, Muthu Mani wrote:
> > +static int cy_gpio_direction_input(struct gpio_chip *chip,
> > + unsigned offset)
> > +{
> > + return
On Thu, Sep 25, 2014 at 05:47:11AM +, Muthu Mani wrote:
> > -Original Message-
> > From: Johan Hovold [mailto:jhov...@gmail.com] On Behalf Of Johan Hovold
> > > +static int cy_gpio_direction_input(struct gpio_chip *chip,
> > > +
On Fri, Apr 25, 2014 at 08:57:15AM +0800, xiao jin wrote:
> When enable usb serial for modem data, sometimes the tty is blocked
> in tty_wait_until_sent because portdata->out_busy always is set and
> have no chance to be cleared.
>
> We have found two scenarios lead to portdata->out_busy problem.
>
On Fri, Apr 25, 2014 at 10:16:57AM +0800, Li Zhong wrote:
> On Thu, 2014-04-24 at 16:52 +0200, Johan Hovold wrote:
> > No, this isn't self removal. The driver-attribute (not device-attribute)
> > store operation simply grabs a lock that is also held while the driver
> >
Remove use of property ti,vcc-aux-disable-is-sleep, which does not
exist.
Signed-off-by: Johan Hovold
---
arch/arm/boot/dts/am335x-boneblack.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/am335x-boneblack.dts
b/arch/arm/boot/dts/am335x-boneblack.dts
index 6b71ad95a5cf
On Fri, Apr 25, 2014 at 09:54:33AM -0400, Alan Stern wrote:
> On Fri, 25 Apr 2014, Li Zhong wrote:
>
> > > I don't get why try_module_get() matters here. We can't call into
> > > ->store if the object at hand is already destroyed and the underlying
> > > module can't go away if the target device
On Sun, Apr 27, 2014 at 10:15:45AM +0800, Xiao Jin wrote:
> > They are however two distinct bugs and should be fixed separately. Could
> > you split the fixes into two patches and resubmit?
> >
> > Please also include a more descriptive subject line for each patch, for
> > example:
> >
> > "USB
On Thu, May 15, 2014 at 11:55:10PM +0200, Rickard Strandqvist wrote:
> There is otherwise a risk of a possible null pointer dereference.
I don't think this can be triggered unless the URB allocation fails at
probe, but let's move the offending line nonetheless.
I'll fix up the patch subject as we
Cc: stable # v2.6.12
Signed-off-by: Johan Hovold
---
drivers/usb/serial/keyspan.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/serial/keyspan.c b/drivers/usb/serial/keyspan.c
index d3acaead5a81..93cb7cebda62 100644
--- a/drivers/usb/serial/keyspan.c
Hi Greg,
I noticed that v3.14 broke my development system which relies on nfsroot
for embedded targets, but soon found Bruce's fix (which has now been in
Linus' tree for a while):
082f31a2169b ("nfsd: revert v2 half of "nfsd: don't return high
mode bits")
The fix d
On Wed, May 07, 2014 at 06:20:49PM +0200, Boris BREZILLON wrote:
> The RTC IMR register is not reliable on sam9x5 SoCs, hence why me have to
> mask all interrupts no matter what IMR claims about already masked irqs.
Crap, I totally forgot about this. Doug reported the problem off-list
back in Dece
[ Sorry for the resend -- forgot to add Doug as CC. ]
On Wed, May 07, 2014 at 06:20:49PM +0200, Boris BREZILLON wrote:
> The RTC IMR register is not reliable on sam9x5 SoCs, hence why me have to
> mask all interrupts no matter what IMR claims about already masked irqs.
Crap, I totally forgot abou
d IRQs
> and just disable all IRQs.
>
> Cc: Andrew Morton
> Cc: # v3.10+
> Signed-off-by: Boris BREZILLON
> Acked-by: Nicolas Ferre
Reviewed-by: Johan Hovold
Looks good, but for the future: Why do you break the comment lines you
added at column 60?
Thanks,
Johan
> ---
&
On Thu, May 08, 2014 at 07:28:04PM +0200, Boris BREZILLON wrote:
> > You should also keep the flush (read of IMR) regardless (to make sure
> > the write has reached the peripheral), and remember to remove the now
> > unused mask variable.
>
> Does it has something to do with memory barriers ?
> I
Remove all remaining uses of gpmc,device-nand that have been added since
the property was removed by commit f40739faba8e ("ARM: dts: OMAP2+:
Simplify NAND support").
Signed-off-by: Johan Hovold
---
arch/arm/boot/dts/am335x-igep0033.dtsi | 1 -
arch/arm/boot/dts/omap3-devkit800
[ +CC: Oliver ]
On Tue, Apr 08, 2014 at 12:22:29PM +0100, One Thousand Gnomes wrote:
> > (2) acm tty port ASYNCB_INITIALIZED flag will be cleared when
> > close. If acm resume callback run after ASYNCB_INITIALIZED flag
> > cleared, there will have no chance for delayed write to start.
> > That lea
[ +CC: Alan ]
On Tue, Apr 08, 2014 at 12:33:31PM +0200, Oliver Neukum wrote:
> On Tue, 2014-04-08 at 09:33 +0200, Johan Hovold wrote:
> > On Tue, Apr 08, 2014 at 11:05:20AM +0800, Xiao Jin wrote:
>
> > > (2) acm tty port ASYNCB_INITIALIZED flag will be cleared when
>
> > > If I see this correctly, then ASYNCB_INITIALIZED is cleared in
> > > tty_port_close() we is called from acm_tty_close(). Thus it should
> > > be enough to make sure that the device is resumed at the beginning
> > > of acm_tty_close() and acm_resume() will do the job automatically.
> > > What
[ +CC: Jiri and Peter ]
On Thu, Apr 10, 2014 at 10:02:03AM +0200, Oliver Neukum wrote:
> On Wed, 2014-04-09 at 22:57 +0800, Xiao Jin wrote:
> > Thanks all for the review. We meet with the problems when developing
> > product. I would like to explain my understanding.
> >
> > On 04/08/2014 11:05
buffer is processed in a loop.
Signed-off-by: Johan Hovold
---
drivers/tty/n_tty.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
index d15624c1b751..d22a2d8f1cb7 100644
--- a/drivers/tty/n_tty.c
+++ b/drivers/tty/n_tty.c
@@ -513,7
.
Signed-off-by: Johan Hovold
---
drivers/usb/class/cdc-acm.c | 28 +++-
drivers/usb/class/cdc-acm.h | 1 -
2 files changed, 7 insertions(+), 22 deletions(-)
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index 900f7ff805ee..c85bf3062bba 100644
--- a
On Tue, Apr 08, 2014 at 12:22:22PM +0200, Oliver Neukum wrote:
> On Tue, 2014-04-08 at 09:33 +0200, Johan Hovold wrote:
> > On Tue, Apr 08, 2014 at 11:05:20AM +0800, Xiao Jin wrote:
> > > We find two problems on acm tty write delayed mechanism.
> >
> > Then you shou
1101 - 1200 of 2826 matches
Mail list logo
