those other seven drivers did not expect DTR
to have been dropped by tty_port_close_start in the first place. ]
Signed-off-by: Johan Hovold
---
drivers/tty/mxser.c| 4
drivers/tty/n_gsm.c| 4
drivers/tty/tty_port.c | 27 +++
3 files changed, 23
Untangle port-shutdown logic and make sure the initialised flag is
always cleared for non-console ports.
Signed-off-by: Johan Hovold
---
drivers/tty/tty_port.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/tty_port.c b/drivers/tty/tty_port.c
index
ng on tty_port_close_start directly but
that did not manage DTR themselves
Johan Hovold (6):
TTY: clean up port shutdown
TTY: wake up processes last at hangup
TTY: fix DTR being raised on hang up
TTY: fix DTR not being dropped on hang up
TTY: clean up port drain-delay handling
TTY: fix
Make sure to check ASYNC_INITIALISED before raising DTR when waking up
from blocked open in tty_port_block_til_ready.
Currently DTR could get raised at hang up as a blocked process would
raise DTR unconditionally before checking for hang up and returning.
Signed-off-by: Johan Hovold
Move port drain-delay handling to a separate function.
Signed-off-by: Johan Hovold
---
drivers/tty/tty_port.c | 27 ---
1 file changed, 16 insertions(+), 11 deletions(-)
diff --git a/drivers/tty/tty_port.c b/drivers/tty/tty_port.c
index cd65f7e..048cc85 100644
--- a
ed
the section mismatch for probe, but left remove marked with __exit.
Signed-off-by: Johan Hovold
---
drivers/w1/masters/w1-gpio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/w1/masters/w1-gpio.c b/drivers/w1/masters/w1-gpio.c
index d39dfa4..012817a 100644
--
Commit 8a1861d997 ("w1-gpio: Simplify & get rid of defines") removed the
compile guards from the device-tree id table, thereby generating a
warning when building without device-tree support.
Signed-off-by: Johan Hovold
---
drivers/w1/masters/w1-gpio.c | 2 ++
1 file changed
s not sufficient.
Tested on at91sam9g45.
Cc: stable
Signed-off-by: Johan Hovold
---
drivers/rtc/rtc-at91rm9200.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c
index b6469e2..936c75a 100644
--- a/drivers/rtc/rtc-at91rm9200
.
Tested on at91sam9263 and at91sam9g45.
Signed-off-by: Johan Hovold
---
arch/arm/mach-at91/at91rm9200.c | 9
arch/arm/mach-at91/at91sam9260.c | 6 ++
arch/arm/mach-at91/at91sam9261.c | 6 ++
arch/arm/mach-at91/at91sam9263.c | 7
This reverts commit 75984df05d86956541795f01e62d7dc67bc522fd.
A couple of these register definitions are needed by arch code as the
RTC-interrupts must be disabled at early boot.
Signed-off-by: Johan Hovold
---
arch/arm/mach-at91/include/mach/at91_rtc.h | 75
when adding new SOCs either.
The patches have been tested on at91sam9263 and at91sam9g45, and
compile-tested for the other SOCs.
Johan
Johan Hovold (3):
ARM: at91/rtc: fix boot after RTC wake-up
Revert "arm: at91: move at91rm9200 rtc header in drivers/rtc"
ARM: at91: fix hanged b
On Fri, Mar 08, 2013 at 05:02:58PM +0100, Jean-Christophe PLAGNIOL-VILLARD
wrote:
> On 13:51 Fri 08 Mar , Johan Hovold wrote:
> > Make sure the RTC and RTT-interrupts are masked at boot by adding a new
> > SOC-initialiser and helpers functions.
> >
> > This fixes h
On Mon, Mar 11, 2013 at 12:06:37PM +0100, Jean-Christophe PLAGNIOL-VILLARD
wrote:
> On 11:02 Mon 11 Mar , Johan Hovold wrote:
> > On Fri, Mar 08, 2013 at 05:02:58PM +0100, Jean-Christophe PLAGNIOL-VILLARD
> > wrote:
> > > On 13:51 Fri 08 Mar , Johan Hovold wrot
(non-DT),
and compile-tested for the other SOCs and DT.
Johan
v2:
- add DT-support
- make sys_irq_mask non-mandatory
Johan Hovold (5):
ARM: at91/rtc: fix boot after RTC wake-up
ARM: at91/dts: add RTC nodes
ARM: at91/dts: add RTT nodes
Revert "arm: at91: move at91rm9200 rtc head
s not sufficient.
Tested on at91sam9g45.
Cc: stable
Signed-off-by: Johan Hovold
---
drivers/rtc/rtc-at91rm9200.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c
index b6469e2..936c75a 100644
--- a/drivers/rtc/rtc-at91rm9200
This reverts commit 75984df05d86956541795f01e62d7dc67bc522fd.
A couple of these register definitions are needed by arch code as the
RTC-interrupts must be disabled at early boot.
Signed-off-by: Johan Hovold
---
arch/arm/mach-at91/include/mach/at91_rtc.h | 75
Add RTT nodes for Atmel SOCs.
Signed-off-by: Johan Hovold
---
arch/arm/boot/dts/at91sam9260.dtsi | 5 +
arch/arm/boot/dts/at91sam9263.dtsi | 10 ++
arch/arm/boot/dts/at91sam9g45.dtsi | 5 +
3 files changed, 20 insertions(+)
diff --git a/arch/arm/boot/dts/at91sam9260.dtsi
b
.
Tested on at91sam9263 and at91sam9g45.
Signed-off-by: Johan Hovold
---
arch/arm/mach-at91/at91sam9260.c | 6 +++
arch/arm/mach-at91/at91sam9261.c | 6 +++
arch/arm/mach-at91/at91sam9263.c | 7
arch/arm/mach-at91/at91sam9g45.c | 7
arch/arm/mach-at91/at91sam9rl.c | 7
arch/arm/mach
Add RTC nodes for Atmel SOCs.
Use two different compatible properties to reflect the fact that the
RTC-peripherals are backup powered (VDDBU) and are thus not reset on
wake-up, user, watchdog or software reset on all SOCs but at91rm9200.
Signed-off-by: Johan Hovold
---
arch/arm/boot/dts
On Tue, Aug 14, 2012 at 09:29:21PM +0100, Jonathan Cameron wrote:
> On 08/02/2012 11:10 AM, Axel Lin wrote:
> > Fix below build warnings:
> > CC [M] drivers/iio/light/lm3533-als.o
> > drivers/iio/light/lm3533-als.c:667:8: warning: initialization from
> > incompatible pointer type [enabled by de
Replace tps65910_misc_init with a dedicated init function for the
32-kHz-crystal input.
Signed-off-by: Johan Hovold
---
Hi Samuel,
How about something like this? My thought with misc_init was that it could be
extended should more simple initialisation like for the ck32k_xtal need to be
done
Add two entries to map to my primary address.
Signed-off-by: Johan Hovold
---
.mailmap | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.mailmap b/.mailmap
index de22daefd9da..9fc0e8d1d7da 100644
--- a/.mailmap
+++ b/.mailmap
@@ -74,6 +74,8 @@ Jean Tourrilhes
Jeff Garzik
Jens Axboe
Add tree entry for USB Serial.
Signed-off-by: Johan Hovold
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 6781a3febd59..c7131a91013a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12267,6 +12267,7 @@ F: drivers/net/usb/rtl8150.c
USB
On Thu, Sep 15, 2016 at 11:19:26AM +0100, Aidan Thornton wrote:
> On Thu, Sep 15, 2016 at 6:56 AM, Greg KH wrote:
> > On Thu, Sep 15, 2016 at 12:03:48AM +0100, Aidan Thornton wrote:
> >>
> >> It looks like someone by the name of Grigori Goronzy (CCed) had a patch
> >> series
> >> or four attempti
On Sun, Jul 24, 2016 at 01:53:30PM +0200, Lubomir Rintel wrote:
> The device has three interfaces; the three serial ports ought to be
I assumed you meant "four interfaces" above and updated the commit
message before applying.
> handled by this driver:
>
> 00 Diagnostic interface serial port
> 01
On Thu, Jul 28, 2016 at 05:01:45PM -0400, Sheng-Hui J. Chu wrote:
> BCM20706V2_EVAL is a WICED dev board designed with FT2232H USB 2.0 UART/FIFO
> IC.
>
> To support BCM920706V2_EVAL dev board for WICED development on Linux. Add
> the VID(0a5c) and
> PID(6422) to ftdi_sio driver to allow loadi
On Tue, Aug 02, 2016 at 11:29:25AM +0200, Daniele Palmas wrote:
> This patch adds a set of compositions for Telit LE920A4.
>
> Compositions in short are:
>
> 0x1207: tty + tty
> 0x1208: tty + adb + tty + tty
> 0x1211: tty + adb + ecm
> 0x1212: tty + adb
> 0x1213: ecm + tty
> 0x1214: tty + adb + e
On Mon, Aug 08, 2016 at 02:34:46AM +0100, Alexey Klimov wrote:
> udriver struct allocated by kzalloc() will not be freed
> if usb_register() and next calls fail. This patch fixes this
> by adding one more step with kfree(udriver) in error path.
>
> Cc: Alan Stern
> Signed-off-by: Alexey Klimov
On Tue, Aug 09, 2016 at 09:55:16AM -0500, Andrew F. Davis wrote:
> The TI SM-USB-DIG is a USB to SPI/I2C/1Wire/GPIO adapter.
> Add MFD core support.
>
> Signed-off-by: Andrew F. Davis
> ---
> drivers/mfd/Kconfig | 9 +++
> drivers/mfd/Makefile| 2 +
> drivers/mfd/ti-s
Make sure to drop the reference to the dma device taken by
of_find_device_by_node() on probe errors and on driver unbind.
Fixes: 334ae614772b ("sparc: Kill SBUS DVMA layer.")
Signed-off-by: Johan Hovold
---
No comment to this one for over a month so resending. Also added David
Mi
On Sat, Oct 14, 2017 at 09:26:59AM +0200, Ingo Molnar wrote:
>
> * Johan Hovold wrote:
>
> > Hi,
> >
> > I had noticed that the BeagleBone Black boot time appeared to have
> > increased significantly with 4.14 and yesterday I finally had time to
> > i
Add missing error handling for tty-driver open() which may fail (e.g. if
resource allocation fails or if a port is being disconnected).
Note that close() must be called also in case of failed open() and that
the operation sanity check is amended to catch buggy drivers.
Signed-off-by: Johan
The tty-driver open routine is mandatory, but the serdev
tty-port-controller implementation did not treat it as such and would
instead fall back to calling tty_port_open() directly.
Signed-off-by: Johan Hovold
---
drivers/tty/serdev/serdev-ttyport.c | 14 ++
1 file changed, 10
On Fri, Oct 13, 2017 at 08:56:00AM -0700, Andrey Smirnov wrote:
> On Fri, Oct 13, 2017 at 12:27 AM, Johan Hovold wrote:
> > On Thu, Oct 12, 2017 at 11:13:21PM -0700, Andrey Smirnov wrote:
> >> Add a driver for RAVE Supervisory Processor, an MCU implementing
> >> v
5ddad ("of/acpi: Configure dma operations at probe time
for platform/amba/pci bus devices")
Johan
Johan Hovold (7):
USB: core: fix device node leak
USB: of: document reference taken by child-lookup helper
driver core: add helper to reuse a device-tree node
driver core: fix auto
_dt_to_map()) which would specifically have prevented
intentional use of a parent's pinctrl properties by a child device
(should such a need ever arise).
Fixes: ab78029ecc34 ("drivers/pinctrl: grab default handles from device core")
Signed-off-by: Johan Hovold
---
drivers/base/pinctrl.c |
ly balances the unconditional put in the platform-device
destructor.
Signed-off-by: Johan Hovold
---
drivers/base/core.c| 16
include/linux/device.h | 2 ++
2 files changed, 18 insertions(+)
diff --git a/drivers/base/core.c b/drivers/base/core.c
index bbecaf9293be..c3064ff09a
thing which now prevents driver core from trying
to reclaim any pinctrl pins during probe.
Fixes: dc5878abf49c ("usb: core: move root hub's device node assignment after
it is added to bus")
Fixes: 51fa91475e43 ("usb/core: Added devspec sysfs entry for devices behind
the us
# v4.6
Cc: Peter Chen
Signed-off-by: Johan Hovold
---
drivers/usb/core/usb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c
index 28b053cacc90..62e1906bb2f3 100644
--- a/drivers/usb/core/usb.c
+++ b/drivers/usb/core/usb.c
@@ -416,6 +416,8 @@ s
pinmux resources already claimed by
the parent device.
Fixes: ec4664b3fd6d ("thermal: max77620: Add thermal driver for reporting
junction temp")
Cc: Laxman Dewangan
Signed-off-by: Johan Hovold
---
drivers/thermal/max77620_thermal.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletion
: max77620: Add thermal driver for reporting
junction temp")
Cc: stable # 4.9
Cc: Laxman Dewangan
Signed-off-by: Johan Hovold
---
drivers/thermal/max77620_thermal.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal/max77620_thermal.c
b/
Document that the child-node lookup helper takes a reference to the
device-tree node which needs to be dropped after use.
Signed-off-by: Johan Hovold
---
drivers/usb/core/of.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/core/of.c b/drivers/usb/core/of.c
index d563cbcf76cf
v' is
> never read
You could also have mentioned that it was a leftover since commit
4134069f3ea6 ("hso: Use static attribute groups for sysfs entry").
> Signed-off-by: Colin Ian King
Reviewed-by: Johan Hovold
Thanks,
Johan
On Mon, Oct 23, 2017 at 11:30:54AM +0200, Pavel Machek wrote:
> Hi!
>
> > > drivers/platform/Kconfig| 2 +
> > > drivers/platform/Makefile | 1 +
> > > drivers/platform/rave/Kconfig | 26 ++
> > > drivers/platform/rave/Makefile | 1 +
> > > drivers/platform/rave/rave-sp.c
On Tue, Oct 24, 2017 at 11:40:38AM -0700, Andrey Smirnov wrote:
> On Tue, Oct 24, 2017 at 8:13 AM, Johan Hovold wrote:
> > On Mon, Oct 23, 2017 at 11:30:54AM +0200, Pavel Machek wrote:
> >> Hi!
> >>
> >> > > drivers/platform/Kconfig| 2 +
>
On Fri, Nov 10, 2017 at 05:43:00PM -0800, Stephen Boyd wrote:
> In ulpi_of_register() we call of_find_node_by_name() which
> unconditionally calls of_node_put() on the 'from' argument. We
> haven't called of_node_get() though, so we've put the node once
> without getting it first. Add the of_node_g
: ef6a7bcfb01c ("usb: ulpi: Support device discovery via DT")
Reported-by: Peter Robinson
Reported-by: Stephen Boyd
Cc: stable # 4.10
Signed-off-by: Johan Hovold
---
drivers/usb/common/ulpi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/common/ulpi.c
Fix child-node lookup during probe, which ended up searching the whole
device tree depth-first starting at the parent rather than just matching
on its children.
To make things worse, the parent node was prematurely freed, while the
child node was leaked.
Note that the CONFIG_OF compile guard can
A helper purported to look up a child node based on its name was using
the wrong of-helper and ended up prematurely freeing the parent of-node
while leaking any matching node.
To make things worse, any matching node would not even necessarily be a
child node as the whole device tree was searched d
ernel")
Fixes: e661d0a04462 ("Input: twl4030-vibra - fix ERROR: Bad of_node_put()
warning")
Cc: stable # 3.7
Cc: Peter Ujfalusi
Cc: Marek Belisko
Signed-off-by: Johan Hovold
---
drivers/input/misc/twl4030-vibra.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
evice tree support")
Cc: stable # 3.7
Cc: Haojian Zhuang
Signed-off-by: Johan Hovold
---
drivers/input/touchscreen/88pm860x-ts.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/input/touchscreen/88pm860x-ts.c
b/drivers/input/touchscreen/88p
de memory management")
Cc: stable # 3.6
Cc: Peter Ujfalusi
Cc: H. Nikolaus Schaller
Signed-off-by: Johan Hovold
---
drivers/input/misc/twl6040-vibra.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/input/misc/twl6040-vibra.c
b/drivers/input/misc/twl6
stable.
Fixes: 9ac33b0ce81f ("CLK: TI: Driver for DRA7 ATL (Audio Tracking Logic)")
Fixes: 660e15519399 ("clk: ti: dra7-atl-clock: Fix of_node reference counting")
Cc: stable # 3.16: 660e15519399
Cc: Peter Ujfalusi
Signed-off-by: Johan Hovold
---
drivers/clk/ti/clk-d
to register board clocks
backwards compatibly")
Signed-off-by: Johan Hovold
---
drivers/clk/qcom/common.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/qcom/common.c b/drivers/clk/qcom/common.c
index b35564c0493f..b8064a336d46 100644
--- a/drivers/clk/q
("irqchip/gic-v3: Add support for partitioned PPIs")
Cc: stable # 4.7
Cc: Marc Zyngier
Signed-off-by: Johan Hovold
---
drivers/irqchip/irq-gic-v3.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-
")
Cc: stable # 4.14
Cc: Loic Poulain
Signed-off-by: Johan Hovold
---
drivers/net/wireless/ath/wcn36xx/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/wcn36xx/main.c
b/drivers/net/wireless/ath/wcn36xx/main.c
index 71812a2dd513..f7d228b5b
[ +CC: Lee, Rob and device-tree list ]
On Sat, Nov 11, 2017 at 09:50:59AM -0800, Dmitry Torokhov wrote:
> On Sat, Nov 11, 2017 at 04:43:37PM +0100, Johan Hovold wrote:
> > A helper purported to look up a child node based on its name was using
> > the wrong of-helper and ended
Fix child-node lookup during initialisation, which ended up searching
the whole device tree depth-first starting at the parent rather than
just matching on its children.
To make things worse, the parent pci node was prematurely freed, while
the child interrupt-controller node was leaked.
Fixes: 0
On Sun, Nov 12, 2017 at 12:32:08PM +, Marc Zyngier wrote:
> On Sat, 11 Nov 2017 17:51:25 +0100
> Johan Hovold wrote:
>
> Johan,
>
> > Fix child-node lookup during initialisation, which ended up searching
> > the whole device tree depth-first starting at the
On Mon, Nov 13, 2017 at 08:30:53AM +0100, H. Nikolaus Schaller wrote:
> Hi Johan,
>
> > Am 11.11.2017 um 16:43 schrieb Johan Hovold :
> >
> > Fix child-node lookup during probe, which ended up searching the whole
> > device tree depth-first starting at parent rather
On Mon, Nov 13, 2017 at 09:11:44AM +, Lee Jones wrote:
> On Sun, 12 Nov 2017, Johan Hovold wrote:
>
> > [ +CC: Lee, Rob and device-tree list ]
> >
> > On Sat, Nov 11, 2017 at 09:50:59AM -0800, Dmitry Torokhov wrote:
> > > On Sat, Nov 11, 2017 at 04:
On Mon, Nov 13, 2017 at 08:51:49AM +, Kalle Valo wrote:
> Johan Hovold writes:
>
> > Fix child-node lookup during probe, which ended up searching the whole
> > device tree depth-first starting at the parent rather than just matching
> > on its children.
> >
to
stable.
Fixes: 47654a162081 ("usb: chipidea: msm: Restore wrapper settings after reset")
Fixes: b74c43156c0c ("usb: chipidea: msm: ci_hdrc_msm_probe() missing
of_node_get()")
Cc: stable # 4.10: b74c43156c0c
Cc: Stephen Boyd
Cc: Frank Rowand
Signed-off-by: Johan Hovo
("mfd: max8925: Support dt for backlight")
Cc: stable # 3.9
Cc: Qing Xu
Cc: Haojian Zhuang
Signed-off-by: Johan Hovold
---
drivers/video/backlight/max8925_bl.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/video/backlight/max8925_bl.c
b/dri
n the tree.
Fixes: eebfdc17cc6c ("backlight: Add TPS65217 WLED driver")
Cc: stable # 3.7
Cc: Matthias Kaehlcke
Signed-off-by: Johan Hovold
---
drivers/video/backlight/tps65217_bl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/backlight/tps6
of_parse_phandle()
are also leaking, but fixing that is a bit more involved as pointers to
node fields are being stored for later use.
Fixes: 59eb2b5e57ea ("drivers/video/backlight/as3711_bl.c: add OF support")
Cc: stable # 3.10
Cc: Guennadi Liakhovetski
Signed-off-by: Johan Hovold
---
dri
put after a
successful dt-initialisation so the nodes would leak on later probe
deferrals and on driver unbind.
Fixes: b985172b328a ("video: atmel_lcdfb: add device tree suport")
Cc: stable # 3.13
Cc: Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by: Johan Hovold
---
drivers/v
;ASoC: twl4030: Support for DT booted kernel")
Cc: stable # 3.7
Cc: Peter Ujfalusi
Signed-off-by: Johan Hovold
---
sound/soc/codecs/twl4030.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c
index c482b2e7a7d2..cf
river")
Cc: stable # 4.5
Cc: Adam Thomson
Signed-off-by: Johan Hovold
---
sound/soc/codecs/da7218.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/da7218.c b/sound/soc/codecs/da7218.c
index b2d42ec1dcd9..56564ce90cb6 100644
--- a/sound/soc/codecs/da72
Hi,
I'm trying to fix up incorrect usage of of_find_node_by_name() to lookup
child nodes, and found the following code in
sound/soc/mediatek/mt8173/mt8173-rt5650.c:
static int mt8173_rt5650_dev_probe(struct platform_device *pdev)
{
...
platform_node = of_parse_phandle(pdev->dev.o
On Mon, Nov 13, 2017 at 10:20:28AM +, Lee Jones wrote:
> On Mon, 13 Nov 2017, Johan Hovold wrote:
>
> > On Mon, Nov 13, 2017 at 09:11:44AM +, Lee Jones wrote:
> > > On Sun, 12 Nov 2017, Johan Hovold wrote:
> > >
> > > > [ +CC: Lee, Rob and devic
On Mon, Nov 13, 2017 at 04:10:52PM +0200, Peter Ujfalusi wrote:
> On 2017-11-11 17:43, Johan Hovold wrote:
> > Fix child-node lookup during probe, which ended up searching the whole
> > device tree depth-first starting at parent rather than just matching on
> > its children.
On Mon, Nov 13, 2017 at 03:39:48PM +0100, H. Nikolaus Schaller wrote:
> Hi,
>
> > Am 13.11.2017 um 15:19 schrieb Johan Hovold :
> >
> > On Mon, Nov 13, 2017 at 04:10:52PM +0200, Peter Ujfalusi wrote:
> >
> >> On 2017-11-11 17:43, Johan Hovold wrote:
&
On Mon, Nov 13, 2017 at 10:43:06AM +, Lorenzo Pieralisi wrote:
> Hi Johan,
>
> On Sun, Nov 12, 2017 at 01:28:50PM +0100, Johan Hovold wrote:
> > Fix child-node lookup during initialisation, which ended up searching
> > the whole device tree depth-first starting at t
On Mon, Nov 13, 2017 at 02:16:09PM +, Daniel Thompson wrote:
> On 13/11/17 10:20, Johan Hovold wrote:
> > Fix child-node lookup during probe, which ended up searching the whole
> > device tree depth-first starting at the parent rather than just matching
> > on its child
On Mon, Nov 13, 2017 at 10:13:42PM +0200, Peter Ujfalusi wrote:
> On 11/11/2017 05:38 PM, Johan Hovold wrote:
> > A helper purported to look up a child node based on its name was using
> > the wrong of-helper and ended up prematurely freeing the parent of-node
> > while leak
The tty_ldisc_receive_buf() helper returns the number of bytes
processed so drop the bogus "not" from the kernel doc comment.
Fixes: 8d082cd300ab ("tty: Unify receive_buf() code paths")
Signed-off-by: Johan Hovold
---
drivers/tty/tty_buffer.c | 2 +-
1 file changed, 1 inse
Make sure to use a properly refcounted tty_struct in write_wake up to
avoid dereferencing a NULL-pointer when a port is being hung up.
Fixes: bed35c6dfa6a ("serdev: add a tty port controller driver")
Cc: stable # 4.11
Signed-off-by: Johan Hovold
---
drivers/tty/serdev/serdev-ttyp
This series addresses a few issues with the serdev code, including
potential information leaks due to missing sanity checks in the receive
path, a NULL-deref in write_wakeup() due to missing reference handling,
and missing tty locking in close().
Johan
Johan Hovold (8):
serdev: ttyport: add
tight loop when the tty buffer pointers are
incremented with -EINVAL (-22).
The missing sanity checks have now been added to the tty-port
controller, but let's fix up the serdev-controller helper as well.
Signed-off-by: Johan Hovold
---
include/linux/serdev.h | 2 +-
1 file changed, 1 inse
Release the tty lock once tty-driver open returns to make it clear that
it does not protect neither tty->termios or the serport flags.
Signed-off-by: Johan Hovold
---
drivers/tty/serdev/serdev-ttyport.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/ser
Serdev does not use the file abstraction and specifically there will
never be anyone polling a file descriptor for POLLOUT events.
Just use plain wake_up_interruptible() in the write_wakeup callback and
document why it's there.
Signed-off-by: Johan Hovold
---
drivers/tty/serdev/s
callbacks.
Fixes: cd6484e1830b ("serdev: Introduce new bus for serial attached devices")
Cc: stable # 4.11
Signed-off-by: Johan Hovold
---
drivers/tty/serdev/serdev-ttyport.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/serdev/serdev
Serdev currently does not support hangups so make sure to set CLOCAL to
prevent loss of carrier from triggering one.
Note however that not all tty drivers honour CLOCAL.
Signed-off-by: Johan Hovold
---
drivers/tty/serdev/serdev-ttyport.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a
for serial attached devices")
Signed-off-by: Johan Hovold
---
drivers/tty/serdev/serdev-ttyport.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/tty/serdev/serdev-ttyport.c
b/drivers/tty/serdev/serdev-ttyport.c
index 31c05665a0e6..334bce00364f 100644
--- a/drivers/tty/serdev/s
while the receive_buf callback returns an integer, the
returned value is still expected to be non-negative (and no greater than
the buffer-size argument).
Signed-off-by: Johan Hovold
---
include/linux/serdev.h | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/include/linux
; Cc: Thomas Gleixner
> Cc: Kate Stewart
> Cc: Philippe Ombredanne
> Signed-off-by: Greg Kroah-Hartman
For USB serial:
Acked-by: Johan Hovold
I noticed several MODULE_LICENSE macros which did not match the headers
(e.g. "GPL" being used for version 2 only modules) for which
h and get/set
As I mentioned in my review of v3 (back in January), this should be
s/operation.h/struct gb_operation/.
> methods to access that pointer.
>
> Signed-off-by: Bryan O'Donoghue
Reviewed-by: Johan Hovold
> --- a/drivers/staging/greybus/operation.h
> +++ b/drivers/
hanks for respinning this one, Bryan. Nice diff stat too.
Note however that this patch depends on Arnd's
[PATCH 2/2] staging: greybus/loopback: use ktime_get() for time
intervals
which hasn't been applied yet.
> Signed-off-by: Bryan O'Donoghue
> Cc: Johan Hovold
&g
ah-Hartman
> Cc: Pavel Machek
> Cc: Andy Shevchenko
> Cc: Guenter Roeck
> Cc: Rob Herring
> Cc: Johan Hovold
> Cc: Sebastian Reichel
> Tested-by: Chris Healy
> Reviewed-by: Guenter Roeck
> Reviewed-by: Andy Shevchenko
> Signed-off-by: Andrey Smirnov
>
).
>
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-ser...@vger.kernel.org
> Cc: Rob Herring
> Cc: cphe...@gmail.com
> Cc: Guenter Roeck
> Cc: Lucas Stach
> Cc: Nikita Yushchenko
> Cc: Lee Jones
> Cc: Greg Kroah-Hartman
> Cc: Pavel Machek
> Cc: Andy Shevchenko
> Cc: Lee Jones
> Cc: Greg Kroah-Hartman
> Cc: Pavel Machek
> Cc: Andy Shevchenko
> Cc: Guenter Roeck
> Cc: Rob Herring
> Cc: Johan Hovold
> Cc: Sebastian Reichel
> Signed-off-by: Nikita Yushchenko
> Signed-off-by: Andrey Smirnov
> +static const struct of_devi
at it neglects to do though is increment the per-connection
> gb->iteration_count on an asynchronous operation error. This patch fixes
> that omission.
>
> Fixes: 12927835d211 ("greybus: loopback: Add asynchronous bi-directional
> support")
>
> Signed-off-by: Br
mmit d9fb3754ecf8 ("greybus: loopback: Relax locking during
> loopback operations").
>
> Fixes: 8e1d6c336d74 ("greybus: loopback: drop bus aggregate calculation")
>
> Signed-off-by: Bryan O'Donoghue
> Cc: Johan Hovold
> Cc: Alex Elder
> Cc: Greg Kroah-H
>
> Signed-off-by: Bryan O'Donoghue
Reviewed-by: Johan Hovold
On Mon, Nov 06, 2017 at 02:39:44PM +0100, Sebastian Reichel wrote:
> Hi,
>
> On Fri, Nov 03, 2017 at 03:18:05PM +0100, Johan Hovold wrote:
> > The tty_ldisc_receive_buf() helper returns the number of bytes
> > processed so drop the bogus "not" from the ker
On Tue, Oct 17, 2017 at 11:08:53AM -0500, Rob Herring wrote:
> On Mon, Oct 16, 2017 at 8:06 AM, Johan Hovold wrote:
> > Add missing error handling for tty-driver open() which may fail (e.g. if
> > resource allocation fails or if a port is being disconnected).
> >
> >
On Mon, Oct 16, 2017 at 09:45:58AM -0700, Andrey Smirnov wrote:
> On Mon, Oct 16, 2017 at 7:14 AM, Johan Hovold wrote:
> > On Fri, Oct 13, 2017 at 08:56:00AM -0700, Andrey Smirnov wrote:
> >> On Fri, Oct 13, 2017 at 12:27 AM, Johan Hovold wrote:
> >> > On Thu, Oc
accessing
the freed controller when CONFIG_DEBUG_SHIRQ is set.
Defer controller release until free_irq() returns to prevent this
from ever becoming an issue should this code be replicated in other
drivers.
Cc: Lars-Peter Clausen
Signed-off-by: Johan Hovold
---
drivers/spi/spi-axi-spi-engine.c | 4
c: Karthik Tummala
Signed-off-by: Johan Hovold
---
drivers/spi/spi.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index e8b5a5e21b2e..3ff0ee88c467 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -2245,11 +2245,12 @@
101 - 200 of 2824 matches
Mail list logo
