[PATCH resend] ARM: at91/ide: remove unsused at91-ide Kconfig entry

2013-02-05 Thread Johan Hovold
Commit cf844751fb25e ("ARM: at91: drop ide driver in favor of the pata one") removed the at91-ide driver but did not remove the Kconfig entry. Signed-off-by: Johan Hovold --- Resend of patch first posted mid-November with trivial added as CC. Perhaps it can go in via the AT91-folks,

Re: [PATCH resend] ARM: at91/ide: remove unsused at91-ide Kconfig entry

2013-02-05 Thread Johan Hovold
On Tue, Feb 5, 2013 at 2:59 PM, Jiri Kosina wrote: > On Tue, 5 Feb 2013, Johan Hovold wrote: > >> Commit cf844751fb25e ("ARM: at91: drop ide driver in favor of the pata >> one") removed the at91-ide driver but did not remove the Kconfig entry. >&

Re: [PATCH 0/5] at91: atmel_lcdfb: regression fixes and cpu_is removal

2013-02-10 Thread Johan Hovold
f the controller uses the intensity-bit and restore the >> old layout in that case. >> >> The last patch is a removal of uses of cpu_is_() macros in >> atmel_lcdfb with a platform-device-id table and static >> configurations. >> >> >> Patches

Re: [RFC PATCH v2] rtc: rtc-at91rm9200: manage IMR depending on revision

2013-04-03 Thread Johan Hovold
On Tue, Apr 02, 2013 at 06:36:06PM +0200, Nicolas Ferre wrote: > Signed-off-by: Nicolas Ferre > --- > Hi again, > > Here is my latest revision of this fix. It depends on the patch that is > already > in Andrew's patch stack: "drivers-rtc-rtc-at91rm9200c-add-dt-support.patch". That is a problem,

[PATCH] Revert "drivers/rtc/rtc-at91rm9200.c: use a variable for storing IMR"

2013-04-03 Thread Johan Hovold
, which this driver currently does not support. Cc: stable Signed-off-by: Johan Hovold --- drivers/rtc/rtc-at91rm9200.c | 50 +--- drivers/rtc/rtc-at91rm9200.h | 1 + 2 files changed, 20 insertions(+), 31 deletions(-) diff --git a/drivers/rtc/rtc-at91rm9200.c

[RFC v2 1/4] rtc-at91rm9200: add configuration support

2013-04-03 Thread Johan Hovold
Add configuration support which can be used to implement SoC-specific workarounds for broken hardware. Signed-off-by: Johan Hovold --- drivers/rtc/rtc-at91rm9200.c | 42 -- 1 file changed, 36 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc

[RFC v2 4/4] rtc-at91rm9200: add support for at91sam9x5

2013-04-03 Thread Johan Hovold
Add support for the at91sam9x5-family which must use the shadow interrupt mask due to a hardware issue. Signed-off-by: Johan Hovold --- Documentation/devicetree/bindings/rtc/atmel,at91rm9200-rtc.txt | 2 +- drivers/rtc/rtc-at91rm9200.c | 7 +++ 2 files

[RFC v2 0/4] rtc-at91rm9200: add support for at91sam9x5

2013-04-03 Thread Johan Hovold
n support added in the first patch could easily be reduced to a single flag set based on the compatible-property matching sam9x5. Johan v2 - rebase on top of DT-support patch by Joachim Eastwood - add missing brace in DT-id table Johan Hovold (4): rtc-at91rm9200: add configuration support

[RFC v2 2/4] rtc-at91rm9200: refactor interrupt-register handling

2013-04-03 Thread Johan Hovold
Add accessors for the interrupt register. This will allow us to easily add a shadow interrupt-mask register to use on SoCs where the interrupt-mask register cannot be used. Signed-off-by: Johan Hovold --- drivers/rtc/rtc-at91rm9200.c | 43 +-- 1 file

[RFC v2 3/4] rtc-at91rm9200: add shadow interrupt mask

2013-04-03 Thread Johan Hovold
infrequent interrupt-mask updates. We do, however, only use the shadow mask value as a fall-back when it actually needed as there is still a theoretical possibility that the mask is incorrect (see the code for details). Signed-off-by: Johan Hovold --- drivers/rtc/rtc-at91rm9200.c | 50

Re: [RFC PATCH v2] rtc: rtc-at91rm9200: manage IMR depending on revision

2013-04-03 Thread Johan Hovold
On Wed, Apr 03, 2013 at 12:37:47PM +0200, Nicolas Ferre wrote: > On 04/03/2013 11:51 AM, Johan Hovold : > > On Tue, Apr 02, 2013 at 06:36:06PM +0200, Nicolas Ferre wrote: [...] > >> I now use a different compatibility string to figure out what is the IP > >> revisi

[PATCH] ARM: w1-gpio: fix erroneous gpio requests

2013-03-12 Thread Johan Hovold
hich could break other uses of the corresponding pin. On AT91 requesting gpio 0 changes the pin muxing for PIOA0, which, for instance, breaks SPI0 on at91sam9g20. Cc: stable Signed-off-by: Johan Hovold --- Not sure whose tree this should go in through, so adding relevant maintainers and aut

Re: [PATCH] ARM: w1-gpio: fix erroneous gpio requests

2013-03-12 Thread Johan Hovold
On Wed, Mar 13, 2013 at 04:24:20AM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote: > On Mar 13, 2013, at 4:20 AM, Greg Kroah-Hartman > wrote: > > On Tue, Mar 12, 2013 at 08:21:34PM +0100, Johan Hovold wrote: > >> Fix regression introduced by commit d2323cf773 (&

[PATCH] ARM: at91/avr32/atmel-mci: fix DMA-channel leak on module unload

2013-03-13 Thread Johan Hovold
is always enabled (if supported), but the DMA-channel is not released on module unload unless the DMA-config option is selected. Remove the no longer used CONFIG_MMC_ATMELMCI_DMA option completely. Cc: stable Signed-off-by: Johan Hovold --- arch/arm/configs/at91sam9g45_defconfig | 1 - arch/avr

Re: [PATCH v3 3/6] TTY: fix DTR being raised on hang up

2013-03-15 Thread Johan Hovold
On Wed, Mar 13, 2013 at 03:43:43PM -0400, Peter Hurley wrote: > On Thu, 2013-03-07 at 15:55 +0100, Johan Hovold wrote: > > Make sure to check ASYNC_INITIALISED before raising DTR when waking up > > from blocked open in tty_port_block_til_ready. > > > > Currently DTR cou

Re: [PATCH v3 0/6] TTY: port hangup and close fixes

2013-03-15 Thread Johan Hovold
On Wed, Mar 13, 2013 at 03:50:32PM -0400, Peter Hurley wrote: > On Thu, 2013-03-07 at 15:55 +0100, Johan Hovold wrote: > > These patches against 3.9-rc1 fix a few issues with tty-port hangup and > > close. > > > > The first and fifth patch are essentially clean ups. &g

Re: [PATCH v3 3/6] TTY: fix DTR being raised on hang up

2013-03-15 Thread Johan Hovold
On Fri, Mar 15, 2013 at 07:03:08AM -0400, Peter Hurley wrote: > On Fri, 2013-03-15 at 10:24 +0100, Johan Hovold wrote: > > On Wed, Mar 13, 2013 at 03:43:43PM -0400, Peter Hurley wrote: > > > On Thu, 2013-03-07 at 15:55 +0100, Johan Hovold wrote: > > > > Make sure to

Re: [PATCH v3 0/6] TTY: port hangup and close fixes

2013-03-15 Thread Johan Hovold
On Fri, Mar 15, 2013 at 12:05:58PM -0700, Greg KH wrote: > On Thu, Mar 07, 2013 at 03:55:47PM +0100, Johan Hovold wrote: > > These patches against 3.9-rc1 fix a few issues with tty-port hangup and > > close. > > Are these for 3.9-final? I'd say it can wait for 3.10

Re: Fix memory leak in sierra_release() (this time with signed-off-by)

2012-10-24 Thread Johan Hovold
a with recent kernels: http://marc.info/?l=linux-usb&m=135100550421848&w=2 I'll rebase my patch on top of this one as your patch should be backported to all stable kernels, whereas mine is only required for v3.6 and later. > Signed-off-by: Len Sorensen Cc: Acked-by: Johan

Re: [PATCH 1/5] USB : serial : remove tty arg of handle_dcd_change.

2013-09-09 Thread Johan Hovold
On Mon, Sep 09, 2013 at 06:01:16PM +0200, Paul Chavent wrote: > Do the same way as in serialcore.c for uart_handle_dcd_change. It > removes duplicated code around the usb_serial_handle_dcd_change calls. > > Signed-off-by: Paul Chavent > --- > drivers/usb/serial/ch341.c | 7 ++- > drivers/

Re: [PATCH 1/5] USB : serial : remove tty arg of handle_dcd_change.

2013-09-09 Thread Johan Hovold
On Mon, Sep 09, 2013 at 07:45:23PM +0200, Johan Hovold wrote: > On Mon, Sep 09, 2013 at 06:01:16PM +0200, Paul Chavent wrote: > > Do the same way as in serialcore.c for uart_handle_dcd_change. It > > removes duplicated code around the usb_serial_handle_dcd_change calls. > &g

Re: [PATCH 1/3] USB : serial : call handle_dcd_change in ftdi driver.

2013-09-13 Thread Johan Hovold
On Fri, Sep 13, 2013 at 05:35:11PM +0200, Paul Chavent wrote: > Signed-off-by: Paul Chavent > --- > drivers/usb/serial/ftdi_sio.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c > index c45f9c0..df66495

Re: [PATCH 2/3] USB : serial : invoke dcd_change ldisc's handler.

2013-09-13 Thread Johan Hovold
On Fri, Sep 13, 2013 at 05:35:12PM +0200, Paul Chavent wrote: > Signed-off-by: Paul Chavent > --- > Documentation/pps/pps.txt| 15 +++ > drivers/usb/serial/generic.c | 9 + > 2 files changed, 24 insertions(+) > > diff --git a/Documentation/pps/pps.txt b/Documentation/pps

Re: [PATCH 3/3] USB : serial : pl2303 wake up after dcd status check.

2013-09-13 Thread Johan Hovold
On Fri, Sep 13, 2013 at 05:35:13PM +0200, Paul Chavent wrote: > Seems to be done this way in other drivers (ch341, 8250, ...). > And get tty reference only if dcd_change need to be called. This is fine. I have a patch here doing the same two changes as part of a larger clean-up of the pl2303 inter

[PATCH] driver core: prevent deferred probe with platform_driver_probe

2013-09-23 Thread Johan Hovold
currently return subsystem errors from probe and that these can include -EPROBE_DEFER (e.g. if a gpio request fails). Signed-off-by: Johan Hovold --- drivers/base/platform.c | 17 + include/linux/platform_device.h | 1 + 2 files changed, 14 insertions(+), 4 deletions

Re: [PATCH] driver core: prevent deferred probe with platform_driver_probe

2013-09-23 Thread Johan Hovold
On Mon, Sep 23, 2013 at 12:01:40PM +0100, Mark Brown wrote: > On Mon, Sep 23, 2013 at 10:48:47AM +0200, Johan Hovold wrote: > > Prevent drivers relying on platform_driver_probe from requesting > > deferred probing in order to avoid further futile probe attempts (either > >

[PATCH 2/7] mmc: mvsdio: fix deferred probe from __init

2013-09-23 Thread Johan Hovold
Cc: Chris Ball Signed-off-by: Johan Hovold --- drivers/mmc/host/mvsdio.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c index 06c5b0b..deecee0 100644 --- a/drivers/mmc/host/mvsdio.c +++ b/drivers/mmc/host/mvs

[PATCH 7/7] backlight: atmel-pwm-bl: fix deferred probe from __init

2013-09-23 Thread Johan Hovold
o Han Cc: Jean-Christophe Plagniol-Villard Signed-off-by: Johan Hovold --- drivers/video/backlight/atmel-pwm-bl.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/video/backlight/atmel-pwm-bl.c b/drivers/video/backlight/atmel-pwm-bl.c index 0393d82..f7447

[PATCH 5/7] usb: gadget: pxa25x_udc: fix deferred probe from __init

2013-09-23 Thread Johan Hovold
ng Cc: Haojian Zhuang Cc: Felipe Balbi Signed-off-by: Johan Hovold --- drivers/usb/gadget/pxa25x_udc.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/pxa25x_udc.c b/drivers/usb/gadget/pxa25x_udc.c index cc92074..0ac6064 100644 --- a/dri

[PATCH 3/7] mtd: atmel_nand: fix deferred probe from __init

2013-09-23 Thread Johan Hovold
Wu Signed-off-by: Johan Hovold --- drivers/mtd/nand/atmel_nand.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c index 060feea..bd1ce7d 100644 --- a/drivers/mtd/nand/atmel_nand.c +++ b/drivers/mtd/na

[PATCH 4/7] pcmcia: at91_cf: fix deferred probe from __init

2013-09-23 Thread Johan Hovold
IOL-VILLARD Cc: Nicolas Ferre Signed-off-by: Johan Hovold --- drivers/pcmcia/at91_cf.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/pcmcia/at91_cf.c b/drivers/pcmcia/at91_cf.c index b8f5acf..de24232 100644 --- a/drivers/pcmcia/at91_cf.c +++ b/drivers/p

[PATCH 0/7] driver core: prevent deferred probe with platform_driver_probe

2013-09-23 Thread Johan Hovold
t91_cf and pxa25x_udc patches are completely untested. Johan Johan Hovold (7): driver core: prevent deferred probe with platform_driver_probe mmc: mvsdio: fix deferred probe from __init mtd: atmel_nand: fix deferred probe from __init pcmcia: at91_cf: fix deferred probe from __init usb: gadget:

[PATCH 1/7] driver core: prevent deferred probe with platform_driver_probe

2013-09-23 Thread Johan Hovold
currently return subsystem errors from probe and that these can include -EPROBE_DEFER (e.g. if a gpio request fails). Add a warning to platform_drv_probe that can be used to catch drivers that inadvertently request probe deferral while using platform_driver_probe. Signed-off-by: Johan Hovold

[PATCH 6/7] usb: phy: gpio-vbus: fix deferred probe from __init

2013-09-23 Thread Johan Hovold
return -EPROBE_DEFER if a gpio_request or regulator_get fails. Cc: Felipe Balbi Signed-off-by: Johan Hovold --- drivers/usb/phy/phy-gpio-vbus-usb.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/usb/phy/phy-gpio-vbus-usb.c b/drivers/usb/phy/phy-gpio-vbus-usb

Re: [PATCH 0/7] driver core: prevent deferred probe with platform_driver_probe

2013-09-23 Thread Johan Hovold
On Mon, Sep 23, 2013 at 04:50:29PM +0200, Sascha Hauer wrote: > On Mon, Sep 23, 2013 at 04:27:25PM +0200, Johan Hovold wrote: > > Deferred probing cannot be used with platform_driver_probe as by the > > time probing is retried either the driver has been unregistered or its > &g

[PATCH] ARM: at91/ide: remove unsused at91-ide Kconfig entry

2012-11-14 Thread Johan Hovold
Commit cf844751fb25e ("ARM: at91: drop ide driver in favor of the pata one") removed the at91-ide driver but did not remove the Kconfig entry. Signed-off-by: Johan Hovold --- drivers/ide/Kconfig | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/ide/Kconfig b/drivers/i

Re: kmemleak report on isp1763 and sierra MC8705

2012-11-14 Thread Johan Hovold
On Wed, Nov 14, 2012 at 12:12:01PM -0500, Richard Retanubun wrote: > On 10/11/12 09:30 AM, Johan Hovold wrote: > Hi Johan, > > > There was a reference-count fix for the probe error path that went in to > > v3.5. Haven't read all the details on how you trigger your leak,

[PATCH] USB: mos7840: remove unused variable

2012-11-08 Thread Johan Hovold
le Signed-off-by: Johan Hovold --- This patch against v3.4 also applies to v3.0 (and v3.2). Thanks, Johan drivers/usb/serial/mos7840.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c index 0179d34..c854235 100644 --- a/drivers/

Re: [PATCH usb-linus] USB: keyspan: fix typo causing GPF on open

2012-11-10 Thread Johan Hovold
rt is opened. > > Reported-by: Richard > Cc: > Cc: Johan Hovold > Signed-off-by: Bjørn Mork Acked-by: Johan Hovold > --- > Hello Richard, > > I wonder if you are able to test and verify this? I do not guarantee > that there aren't other issues around, but this smal

Re: kmemleak report on isp1763 and sierra MC8705

2012-11-10 Thread Johan Hovold
On Fri, Nov 9, 2012 at 11:14 PM, Richard Retanubun wrote: > On 29/10/12 06:14 PM, Alan Stern wrote: >> >> On Mon, 29 Oct 2012, Richard Retanubun wrote: >>> >>> Focusing down on one of the dumps: >>> >>> unreferenced object 0xd3849740 (size 8): >>> comm "khubd", pid 1026, jiffies 232553037 (age

Re: [RFC] raise the maximum number of usb-serial devices to 512

2013-06-04 Thread Johan Hovold
On Mon, Jun 03, 2013 at 07:49:59PM -0700, Greg KH wrote: > On Mon, May 27, 2013 at 02:28:51PM +0200, Bjørn Mork wrote: > > But, IMHO, a nicer approach would be to make the allocation completely > > dynamic, using e.g. the idr subsystem. Static tables are always feel > > like straight jackets to me,

Re: [PATCH 1/3] USB: serial: ports: add minor and port number

2013-06-06 Thread Johan Hovold
On Wed, Jun 05, 2013 at 10:55:39AM -0700, Greg KH wrote: > From: Greg Kroah-Hartman > > The usb_serial_port structure had the number field, which was the minor > number for the port, which almost no one really cared about. They > really wanted the number of the port within the device, which you

[PATCH] USB: whiteheat: fix broken port configuration

2013-06-06 Thread Johan Hovold
When configuring the port (e.g. set_termios) the port minor number rather than the port number was used in the request (and they only coincide for minor number 0). Cc: sta...@vger.kernel.org Signed-off-by: Johan Hovold --- drivers/usb/serial/whiteheat.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH 2/3] USB: serial: make minor allocation dynamic

2013-06-06 Thread Johan Hovold
On Wed, Jun 05, 2013 at 10:54:55AM -0700, Greg KH wrote: > From: Greg Kroah-Hartman > > This moves the allocation of minor device numbers from a static array to > be dynamic, using the idr interface. This means that you could > potentially get "gaps" in a minor number range for a single USB seri

Re: [PATCH v2 2/3] USB: serial: make minor allocation dynamic

2013-06-07 Thread Johan Hovold
On Thu, Jun 06, 2013 at 10:31:21AM -0700, Greg KH wrote: > From: Greg Kroah-Hartman [...] > --- a/drivers/usb/serial/usb-serial.c > +++ b/drivers/usb/serial/usb-serial.c > @@ -37,6 +37,7 @@ > #include > #include > #include > +#include > #include "pl2303.h" > > #define DRIVER_AUTHOR "G

Re: [PATCH v2 2/3] USB: serial: make minor allocation dynamic

2013-06-07 Thread Johan Hovold
On Fri, Jun 07, 2013 at 11:40:25AM +0200, Johan Hovold wrote: > On Thu, Jun 06, 2013 at 10:31:21AM -0700, Greg KH wrote: > > From: Greg Kroah-Hartman > > [...] > > > /* Functions needed by other parts of the usbserial core */ > > -extern struct usb_serial *usb_se

Re: [PATCH v2 2/3] USB: serial: make minor allocation dynamic

2013-06-07 Thread Johan Hovold
On Thu, Jun 06, 2013 at 10:31:21AM -0700, Greg KH wrote: > From: Greg Kroah-Hartman > @@ -1040,11 +1044,10 @@ static int usb_serial_probe(struct usb_i >*/ > serial->disconnected = 1; > > - if (get_free_serial(serial, num_ports, &minor) == NULL) { > + if (get_free_serial(se

Re: [PATCH v3 2/3] USB: serial: make minor allocation dynamic

2013-06-18 Thread Johan Hovold
> > > @@ -123,8 +116,9 @@ static void return_serial(struct usb_ser > > > > > > mutex_lock(&table_lock); > > > for (i = 0; i < serial->num_ports; ++i) > > > - serial_table[serial->minor + i] = NULL; > > > + idr_remove(&serial_minors, serial->port[i]->minor); > > > mutex_unloc

Re: [PATCH v3 2/3] USB: serial: make minor allocation dynamic

2013-06-08 Thread Johan Hovold
+ serial->minors_reserved = 0; This isn't strictly needed as the serial struct release_serial is only called once when the struct is about to be freed. > } > > static void destroy_serial(struct kref *kref) > @@ -136,7 +130,7 @@ static void destroy_serial(struct kref * > serial = to_usb_serial(kref); > > /* return the minor range that this device had */ > - if (serial->minor != SERIAL_TTY_NO_MINOR) > + if (serial->minors_reserved) > return_serial(serial); > > if (serial->attached && serial->type->release) All three patches look good otherwise. The port-number disambiguation was indeed long overdue. Feel free to add Reviewed-by: Johan Hovold Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 0/2] *** SUBJECT HERE ***

2013-07-02 Thread Johan Hovold
On Tue, Jul 02, 2013 at 01:22:01AM +0200, Anders Hammarquist wrote: > In a message of Fri, 28 Jun 2013 12:23:33 +0200, Johan Hovold writes: > >> I did a quick check of adding the device id though sysfs, and although > >> it partly works, it doesn't find the correct f

Re: [PATCH 0/2] *** SUBJECT HERE ***

2013-06-26 Thread Johan Hovold
look in to it. I already have a few patches here (part of a larger 3.11 clean-up series) which removes the vid/pid module parameters from all usb-serial modules including ti_usb_3410_5052. I hope to be able to submit the whole series a later tonight, but here's the ti_usb_3410_5052 part i

Re: [PATCH 0/2] *** SUBJECT HERE ***

2013-06-28 Thread Johan Hovold
On Thu, Jun 27, 2013 at 11:50:52PM +0200, Anders Hammarquist wrote: > In a message of Wed, 26 Jun 2013 12:39:24 +0200, Johan Hovold writes: > >On Wed, Jun 26, 2013 at 10:29:59AM +0200, Anders Hammarquist wrote: > >> In a message of Tue, 25 Jun 2013 16:39:11 -0700, Greg KH writ

[PATCH] USB: ti_usb_3410_5052: fix dynamic-id matching

2013-06-28 Thread Johan Hovold
Hammarquist Cc: stable Signed-off-by: Johan Hovold --- drivers/usb/serial/ti_usb_3410_5052.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c index 5585b20..5c07d55 100644 --- a/drivers/usb/serial

Re: [PATCH 098/150] USB: serial: add modem-status-change wait queue

2013-03-26 Thread Johan Hovold
-usb&m=136428758202815&w=2 and should show up in 3.9-rc5. This patch and the following use-after-free patches should not be applied without that fix. Johan > -- > > From: Johan Hovold > > commit e5b33dc9d16053c2ae4c2c669cf008829530364b upstream. > >

Re: [ 084/104] USB: serial: add modem-status-change wait queue

2013-03-26 Thread Johan Hovold
02815&w=2 and should show up in 3.9-rc5. This patch and the following use-after-free patches should not be applied without that fix. Johan > ------ > > From: Johan Hovold > > commit e5b33dc9d16053c2ae4c2c669cf008829530364b upstream. > > Add modem-st

Re: [PATCH] rtc: rtc-at91rm9200: use a variable for storing IMR

2013-03-26 Thread Johan Hovold
On Fri, Mar 15, 2013 at 06:37:12PM +0100, Nicolas Ferre wrote: > On some revisions of AT91 SoCs, the RTC IMR register is not working. > Instead of elaborating a workaround for that specific SoC or IP version, > we simply use a software variable to store the Interrupt Mask Register and > modify it f

Re: [PATCH 0/5] at91: atmel_lcdfb: regression fixes and cpu_is removal

2013-03-04 Thread Johan Hovold
etermine if the > > controller uses the intensity-bit and restore the old layout in that case. > > > > The last patch is a removal of uses of cpu_is_() macros in atmel_lcdfb > > with > > a platform-device-id table and static configurations. > > > > > > Pat

[PATCH 2/2] ARM: at91: remove trailing semicolon from macros

2013-04-07 Thread Johan Hovold
Remove trailing semicolon from register-access macros. Signed-off-by: Johan Hovold --- arch/arm/mach-at91/at91_rstc.h| 2 +- arch/arm/mach-at91/at91_shdwc.h | 2 +- arch/arm/mach-at91/at91x40_time.c | 2 +- arch/arm/mach-at91/include/mach/at91_matrix.h

[PATCH 1/2] ARM: at91/setup: fix trivial typos

2013-04-07 Thread Johan Hovold
Fix a few trivial typos in panic, warning and debug messages. Signed-off-by: Johan Hovold --- arch/arm/mach-at91/setup.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-at91/setup.c b/arch/arm/mach-at91/setup.c index 4b67847..9e7c1e1 100644 --- a/arch

Re: [PATCH 035/102] USB: serial: add modem-status-change wait queue

2013-04-08 Thread Johan Hovold
On Mon, Apr 08, 2013 at 10:49:50AM +0100, Luis Henriques wrote: > 3.5.7.10 -stable review patch. If anyone has any objections, please let me > know. > > -- > > From: Johan Hovold > > commit e5b33dc9d16053c2ae4c2c669cf008829530364b upstream. > >

Re: Regression: ftdi_sio is slow (since Wed Oct 10 15:05:06 2012)

2013-05-04 Thread Johan Hovold
On Sat, May 04, 2013 at 01:50:42AM +0400, Stas Sergeev wrote: > 04.05.2013 00:34, Greg KH пишет: > > On Fri, May 03, 2013 at 10:27:18PM +0400, Stas Sergeev wrote: > >> 03.05.2013 21:16, Greg KH пишет: [...] > >>> There's no guarantee as to how long select or an ioctl will take, and > >>> now that

Re: Regression: ftdi_sio is slow (since Wed Oct 10 15:05:06 2012)

2013-05-05 Thread Johan Hovold
On Sat, May 04, 2013 at 07:39:57AM -0400, Peter Hurley wrote: > On 05/04/2013 07:15 AM, Johan Hovold wrote: > > On Sat, May 04, 2013 at 01:50:42AM +0400, Stas Sergeev wrote: > >> 04.05.2013 00:34, Greg KH пишет: > >>> On Fri, May 03, 2013 at 10:27:18PM +0400, Stas Se

[PATCH 6/7] USB: ti_usb_3410_5052: fix chars_in_buffer overhead

2013-05-05 Thread Johan Hovold
us in chars_in_buffer") without breaking tty_wait_until_sent (used by, for example, tcdrain, tcsendbreak and close). Signed-off-by: Johan Hovold --- drivers/usb/serial/ti_usb_3410_5052.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/drivers/

[PATCH 3/7] USB: ftdi_sio: clean up get_modem_status

2013-05-05 Thread Johan Hovold
Use usb-serial port rather than tty as argument to get_modem_status. Signed-off-by: Johan Hovold --- drivers/usb/serial/ftdi_sio.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c index 242b577..1159fd4

[PATCH 0/7] USB: serial: add wait_until_sent-support

2013-05-05 Thread Johan Hovold
also currently checked in chars_in_buffer in io_ti (since 3.8) and ti_usb_3410_5052 (in 3.10). Note that simply removing the hardware-buffer checks (e.g. for the stable trees) would break tty_wait_until_sent, which is used, for instance, by tcdrain, tcsendbreak, and close. Johan Johan Hovold (7

[PATCH 1/7] USB: serial: add wait_until_sent operation

2013-05-05 Thread Johan Hovold
Add wait_until_sent operation which can be used to wait for hardware buffers to drain. Signed-off-by: Johan Hovold --- drivers/usb/serial/usb-serial.c | 17 + include/linux/usb/serial.h | 1 + 2 files changed, 18 insertions(+) diff --git a/drivers/usb/serial/usb-serial.c

[PATCH 2/7] USB: serial: add generic wait_until_sent implementation

2013-05-05 Thread Johan Hovold
Add generic wait_until_sent implementation which polls for empty hardware buffers using the new port-operation tx_empty. The generic implementation will be used for all sub-drivers that implement tx_empty but does not define wait_until_sent. Signed-off-by: Johan Hovold --- drivers/usb/serial

[PATCH 5/7] USB: io_ti: fix chars_in_buffer overhead

2013-05-05 Thread Johan Hovold
uffer") without breaking tty_wait_until_sent (used by, for example, tcdrain, tcsendbreak and close). Signed-off-by: Johan Hovold --- drivers/usb/serial/io_ti.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/drivers/usb/serial/io_ti.c b/drivers/

[PATCH 7/7] USB: serial: clean up chars_in_buffer

2013-05-05 Thread Johan Hovold
No need to grab disconnect mutex in chars_in_buffer now that no sub-driver is or should be querying hardware buffers anymore. (They should use wait_until_sent.) Signed-off-by: Johan Hovold --- drivers/usb/serial/usb-serial.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions

[PATCH 4/7] USB: ftdi_sio: fix chars_in_buffer overhead

2013-05-05 Thread Johan Hovold
ction") without breaking tty_wait_until_sent (used by, for example, tcdrain, tcsendbreak and close). Reported-by: Stas Sergeev Signed-off-by: Johan Hovold --- drivers/usb/serial/ftdi_sio.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/

Re: [PATCH 2/7] USB: serial: add generic wait_until_sent implementation

2013-05-08 Thread Johan Hovold
On Wed, May 08, 2013 at 06:25:13PM +0400, Stas Sergeev wrote: > 05.05.2013 22:32, Johan Hovold пишет: > > Add generic wait_until_sent implementation which polls for empty > > hardware buffers using the new port-operation tx_empty. > > > > The generic implementation will

[PATCH v2 2/8] USB: serial: add generic wait_until_sent implementation

2013-05-08 Thread Johan Hovold
Add generic wait_until_sent implementation which polls for empty hardware buffers using the new port-operation tx_empty. The generic implementation will be used for all sub-drivers that implement tx_empty but does not define wait_until_sent. Signed-off-by: Johan Hovold --- v2: make sure to

[PATCH] rtc: rtc-at91rm9200: fix missing iounmap

2013-04-11 Thread Johan Hovold
Add missing iounmap to probe error path and remove. Cc: stable Signed-off-by: Johan Hovold --- drivers/rtc/rtc-at91rm9200.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c index 434ebc3..eebd8ac

Re: [PATCH v2 0/5] ARM: at91: fix hanged boot

2013-04-11 Thread Johan Hovold
On Mon, Mar 11, 2013 at 07:07:54PM +0100, Johan Hovold wrote: > These patches fix a few severe issues affecting most AT91 SOCs where > boot can hang after a non-general reset, and where the only way to get > the system booting again is to do a general reset -- something which > c

[PATCH 2/4] TTY: synclink_gt: fix DTR being raised on hang up

2013-04-12 Thread Johan Hovold
Make sure to check ASYNC_INITIALISED before raising DTR when waking up from blocked open in block_til_ready. Currently DTR could get raised at hang up as a blocked process would raise DTR unconditionally before checking for hang up and returning. Signed-off-by: Johan Hovold --- drivers/tty

[PATCH 3/4] TTY: synclinkmp: fix DTR being raised on hang up

2013-04-12 Thread Johan Hovold
Make sure to check ASYNC_INITIALISED before raising DTR when waking up from blocked open in block_til_ready. Currently DTR could get raised at hang up as a blocked process would raise DTR unconditionally before checking for hang up and returning. Signed-off-by: Johan Hovold --- drivers/tty

[PATCH 4/4] TTY: ircomm: fix DTR being raised on hang up

2013-04-12 Thread Johan Hovold
: Johan Hovold --- net/irda/ircomm/ircomm_tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/irda/ircomm/ircomm_tty.c b/net/irda/ircomm/ircomm_tty.c index 362ba47..41ac7938 100644 --- a/net/irda/ircomm/ircomm_tty.c +++ b/net/irda/ircomm/ircomm_tty.c @@ -328,7 +328,7

[PATCH 1/4] TTY: synclink: fix DTR being raised on hang up

2013-04-12 Thread Johan Hovold
Make sure to check ASYNC_INITIALISED before raising DTR when waking up from blocked open in block_til_ready. Currently DTR could get raised at hang up as a blocked process would raise DTR unconditionally before checking for hang up and returning. Signed-off-by: Johan Hovold --- drivers/tty

[PATCH 0/4] TTY: fix DTR being raised on hang up

2013-04-12 Thread Johan Hovold
ffers from this behaviour but is broken in other ways as it, for example, does not honour CBAUD or raise DTR at non-blocking open. Thanks, Johan Johan Hovold (4): TTY: synclink: fix DTR being raised on hang up TTY: synclink_gt: fix DTR being raised on hang up TTY: synclinkmp: fix DTR being rais

Re: [rtc-linux] Re: [PATCH v2 0/5] ARM: at91: fix hanged boot

2013-04-12 Thread Johan Hovold
On Thu, Apr 11, 2013 at 06:54:14PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 17:55 Thu 11 Apr , Johan Hovold wrote: > > On Mon, Mar 11, 2013 at 07:07:54PM +0100, Johan Hovold wrote: > > > These patches fix a few severe issues affecting most AT91 SOCs where > &g

Re: [PATCH 0/7] USB: serial: add wait_until_sent-support

2013-05-20 Thread Johan Hovold
d-by: Caylan Larson > > Caylan > > > On May 5, 2013, at 1:32 PM, Johan Hovold wrote: > > > These patches add wait_until_sent-support to usb-serial, which removes > > the need to check hardware buffers in chars_in_buffer. > > > > This fixes a pro

[PATCH v3 5/5] rtc-at91rm9200: use shadow IMR on at91sam9x5

2013-05-23 Thread Johan Hovold
Add support for the at91sam9x5-family which must use the shadow interrupt mask due to a hardware issue (causing RTC_IMR to always be zero). Signed-off-by: Johan Hovold --- Documentation/devicetree/bindings/rtc/atmel,at91rm9200-rtc.txt | 2 +- arch/arm/boot/dts/at91sam9x5.dtsi

[PATCH v3 0/5] rtc-at91rm9200: add shadow interrupt mask

2013-05-23 Thread Johan Hovold
? Note that the first patch (adding a missing OF compile guard) could be applied straight away. Thanks, Johan v3: - rebase against v3.10-rc2 - remove some comments v2: - rebase on top of DT-support patch by Joachim Eastwood - add missing brace in DT-id table Johan Hovold (5): rtc

[PATCH v3 2/5] rtc-at91rm9200: add configuration support

2013-05-23 Thread Johan Hovold
Add configuration support which can be used to implement SoC-specific workarounds for broken hardware. Signed-off-by: Johan Hovold --- drivers/rtc/rtc-at91rm9200.c | 46 1 file changed, 38 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc

[PATCH v3 4/5] rtc-at91rm9200: add shadow interrupt mask

2013-05-23 Thread Johan Hovold
infrequent interrupt-mask updates. We do, however, only use the shadow mask value as a fall-back when it actually needed as there is still a theoretical possibility that the mask is incorrect (see the code for details). Signed-off-by: Johan Hovold --- drivers/rtc/rtc-at91rm9200.c | 39

[PATCH v3 1/5] rtc-at91rm9200: add match-table compile guard

2013-05-23 Thread Johan Hovold
Add missing match-table compile guard. Signed-off-by: Johan Hovold --- drivers/rtc/rtc-at91rm9200.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c index 0eab77b..eeeb73f 100644 --- a/drivers/rtc/rtc-at91rm9200.c +++ b/drivers

[PATCH v3 3/5] rtc-at91rm9200: refactor interrupt-register handling

2013-05-23 Thread Johan Hovold
Add accessors for the interrupt register. This will allow us to easily add a shadow interrupt-mask register to use on SoCs where the interrupt-mask register cannot be used. Signed-off-by: Johan Hovold --- drivers/rtc/rtc-at91rm9200.c | 43 +-- 1 file

Re: [PATCH] rtc: rtc-at91rm9200: use a variable for storing IMR

2013-03-28 Thread Johan Hovold
On Tue, Mar 26, 2013 at 05:09:59PM -0400, Douglas Gilbert wrote: > On 13-03-26 03:27 PM, Johan Hovold wrote: > > On Fri, Mar 15, 2013 at 06:37:12PM +0100, Nicolas Ferre wrote: > >> On some revisions of AT91 SoCs, the RTC IMR register is not working. > >> Instead of e

Re: [PATCH] rtc: rtc-at91rm9200: use a variable for storing IMR

2013-03-29 Thread Johan Hovold
On Thu, Mar 28, 2013 at 05:16:00PM +0100, Nicolas Ferre wrote: > On 03/28/2013 10:57 AM, Johan Hovold : > > On Tue, Mar 26, 2013 at 05:09:59PM -0400, Douglas Gilbert wrote: > >> On 13-03-26 03:27 PM, Johan Hovold wrote: > >>> On Fri, Mar 15, 2013 at 06:37:1

Re: [PATCH] rtc: rtc-at91rm9200: use a variable for storing IMR

2013-03-29 Thread Johan Hovold
On Thu, Mar 28, 2013 at 02:20:17PM -0400, Douglas Gilbert wrote: > On 13-03-28 05:57 AM, Johan Hovold wrote: > > On Tue, Mar 26, 2013 at 05:09:59PM -0400, Douglas Gilbert wrote: > >> On 13-03-26 03:27 PM, Johan Hovold wrote: > >>> On Fri, Mar 15, 2013 at 06:37:1

[RFC 5/5] rtc-at91rm9200: add support for at91sam9x5

2013-03-29 Thread Johan Hovold
Add support for the at91sam9x5-family which must use the shadow interrupt mask due to a hardware issue. --- drivers/rtc/rtc-at91rm9200.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c index 2921866..f3e351f 100644 --- a/drive

[RFC 1/5] rtc-at91rm9200: add configuration support

2013-03-29 Thread Johan Hovold
Add configuration support which can be used to implement SoC-specific workarounds for broken hardware. --- drivers/rtc/rtc-at91rm9200.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c index 434ebc3..5bae0a1 100644 -

[RFC 3/5] rtc-at91rm9200: refactor interrupt-register handling

2013-03-29 Thread Johan Hovold
Add accessors for the interrupt register. This will allow us to easily add a shadow interrupt-mask register to use on SoCs where the interrupt-mask register cannot be used. --- drivers/rtc/rtc-at91rm9200.c | 43 +-- 1 file changed, 29 insertions(+), 14 dele

[RFC 4/5] rtc-at91rm9200: add shadow interrupt mask

2013-03-29 Thread Johan Hovold
Add shadow interrupt-mask register which can be used on SoCs where the actual hardware register is broken. Note that some care needs to be taken to make sure the shadow mask corresponds to the actual hardware state. The added overhead is not an issue for the non-broken SoCs due to the relatively i

[RFC 2/5] rtc-at91rm9200: add device-tree support

2013-03-29 Thread Johan Hovold
Add device tree support. --- drivers/rtc/rtc-at91rm9200.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c index 5bae0a1..67260f9 100644 --- a/drivers/rtc/rtc-at91rm9200.c +++ b/drivers/rtc/rtc-at91rm9200.c @@

Re: [RFC 2/5] rtc-at91rm9200: add device-tree support

2013-03-29 Thread Johan Hovold
On Fri, Mar 29, 2013 at 05:03:46PM +0100, Johan Hovold wrote: > Add device tree support. > --- > drivers/rtc/rtc-at91rm9200.c | 23 +++ > 1 file changed, 23 insertions(+) > > diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c > i

Re: [Fwd: [PATCH v2 0/4] TTY: port hangup and close fixes]

2013-03-06 Thread Johan Hovold
Hi Jiri, On Tue, Mar 05, 2013 at 05:02:44PM +0100, Jiri Slaby wrote: > On 02/28/2013 09:57 PM, Peter Hurley wrote: > > Hi Jiri, > > > > Just wanted to make sure you saw this series. > > Hi, thanks for letting me know. Johan, care to CC Alan Cox and me (or at > least LKML) when you're changing th

Re: [Fwd: [PATCH v2 0/4] TTY: port hangup and close fixes]

2013-03-07 Thread Johan Hovold
On Wed, Mar 06, 2013 at 02:14:56PM -0500, Peter Hurley wrote: > On Wed, 2013-03-06 at 17:52 +0100, Johan Hovold wrote: > > > > > @@ -225,15 +232,13 @@ void tty_port_hangup(struct tty_port *port) > > > spin_lock_irqsave(&port->lock, flags); > > >

[PATCH v3 6/6] TTY: fix close of uninitialised ports

2013-03-07 Thread Johan Hovold
drain delay for an uninitialised port. Currently a drain delay of up to two seconds could be added when a tty fails to open. Signed-off-by: Johan Hovold --- drivers/tty/tty_port.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/tty/tty_port.c b

[PATCH v3 2/6] TTY: wake up processes last at hangup

2013-03-07 Thread Johan Hovold
Move wake up of processes on blocked-open and modem-status wait queues to after port shutdown at hangup. This way the woken up processes can use the ASYNC_INITIALIZED flag to detect port shutdown. Note that this is the order currently used by serial-core. Signed-off-by: Johan Hovold

  1   2   3   4   5   6   7   8   9   10   >