On 10/02/2013 11:36 PM, Jason Gunthorpe wrote:
> On Wed, Oct 02, 2013 at 07:11:14PM -0500, Ashley D Lai wrote:
>
>>> I somewhat have the feeling that we should maybe begin to deprecate
>>> the vendor specific 1.1 tpms...
>
>> I agree. If we have a machine to test and it fails then we know we don'
> There is also the fact that the driver may not be able to tell if a
> locality is available without doing some kind of test command. The Xen
> TPM interface doesn't expose what localities are available, for example,
> and the TIS interface may need to test to see if locality 3 and 4 are
> actua
deletions(-)
> create mode 100644 drivers/char/tpm/tpm-dev.c
> create mode 100644 drivers/char/tpm/tpm-sysfs.c
>
For what it's worth I have nothing to say except the cleanups look sane
to me.
Reviewed-by: Joel Schopp
--
To unsubscribe from this list: send the line "un
mpile anymore.
Acked-by: Joel Schopp <[EMAIL PROTECTED]>
Signed-off-by: Dave Boutcher <[EMAIL PROTECTED]>
--- linux-2.6.13-rc6-mm1-orig/drivers/scsi/ibmvscsi/ibmvscsi.c 2005-08-22
13:54:20.111955197 -0500
+++ linux-2.6.13-rc6-mm1/drivers/scsi/ibmvscsi/ibmvscsi.c 2005-08-22
1
/* If flip is full, just reschedule a later read */
if (count == 0) {
poll_mask |= HVC_POLL_READ;
shouldn't be deleting the declaration of count.
and possibly the "flip removal" was incomplete (line 636) ???
Yep. You can remove the tty->fli
Try the diff below although I suspect much of the extra logic can go
away and something like
len = tty_buffer_request_root(tty, HVCS_BUFF_LEN);
if(len) {
len = hvc_get_chars(, len);
tty_insert_flip_string(tty, buf, len);
}
is better.
-inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME_SEC;
+inode->i_mtime = CURRENT_TIME_SEC;
+inode->i_atime = CURRENT_TIME_SEC;
+inode->i_ctime = CURRENT_TIME_SEC;
multiple assignments like "x = y = z = value;" can potentially
(depending on the compiler and arch) be
.text+0x26db8): In function `.initMatrox2':
: undefined reference to `.mac_vmode_to_var'
Signed-off-by: Joel Schopp <[EMAIL PROTECTED]>
---
diff -puN drivers/video/Makefile~matrox drivers/video/Makefile
--- 2.6.11-bk10/drivers/video/Makefile~matrox 2005-03-15 11:08:44.0
Mikael Pettersson wrote:
Andrew Morton writes:
> "Martin J. Bligh" <[EMAIL PROTECTED]> wrote:
> >
> > drivers/built-in.o(.text+0x182bc): In function `.matroxfb_probe':
> > : undefined reference to `.mac_vmode_to_var'
> > make: *** [.tmp_vmlinux1] Error 1
> >
> > Anyone know what that is?
>
cpus instead of
replacing use of smp_processor_id with _smp_processor_id.
Signed-off-by: Nathan Lynch <[EMAIL PROTECTED]>
Acked-by: Joel Schopp <[EMAIL PROTECTED]>
Index: linux-2.6.11-rc5-mm1/init/main.c
===
--- linux-2.
his should work.
Acked-by: Joel Schopp <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
foo_ioctl()
{
switch(ioctl) {
case FOO:
lots
of
code
error:
return result;
case BAR:
return result;
}
Notice that the "error:" label is indented. Each of the case is kinda
like a mini
Several of our on-disk filesystems have an ioctl function that already
has indented goto labels. I don't think it's quite worth churning all
of these (working) filesystems to make a style checker happy.
I think it's worse style to be mixing label indentation in a file as it
is to create new "cor
Randy Dunlap wrote:
On Sun, 27 May 2007 18:11:25 +0100 Andy Whitcroft wrote:
Also if either Joel or Randy want to be on on the MAINTAINERS
entry yell and we'll get it updated, wouldn't want to list
anyone without permission.
Yes, please.
Yes. Add me as well.
-
To u
+ if(!($prevline=~/\/\*\*/) && length($lineforcounting) > 80){
Actually, I think this should be "> 79" (after stripping a .diff's
control column), since the cursor may move to the 81th column when
editing an 80-col line - which is what we want to avoid, no?
80 tends to work for me
As a first step package up the current state of the patch style
checker and include it in the kernel tree. Add instructions
suggesting running it on submissions. This adds version v0.01 of
the checkpatch.pl script.
Signed-off-by: Andy Whitcroft <[EMAIL PROTECTED]>
Signed-off-by: Joel
Dan Williams wrote:
checkpatch currently complains about macros like the following:
#define for_each_dma_cap_mask(cap, mask) \
for ((cap) = first_dma_cap(mask); \
(cap) < DMA_TX_TYPE_END;\
(cap) = next_dma_cap((cap), (mask)))
Signed-off-by
Exhibiting a workload where the list patch breaks down and the zone
patch rescues it might help if it's felt that the combination isn't as
good as lists in isolation. I'm sure one can be dredged up somewhere.
I can't think of a workload that totally makes a mess out of list-based.
However, list
Linus Torvalds wrote:
On Thu, 1 Mar 2007, Andrew Morton wrote:
So some urgent questions are: how are we going to do mem hotunplug and
per-container RSS?
The people who were trying to do memory hot-unplug basically all stopped waiting for
these patches, or something similar, to solve the frag
But if you don't require a lot of higher order allocations anyway, then
guest fragmentation caused by ballooning doesn't seem like much problem.
If you only need to allocate 1 page size and smaller allocations then no it's not a
problem. As soon as you go above that it will be. You don't need
If you only need to allocate 1 page size and smaller allocations then no
it's not a problem. As soon as you go above that it will be. You don't
need to go all the way up to MAX_ORDER size to see an impact, it's just
increasingly more severe as you get away from 1 page and towards MAX_ORDER.
The only question is whether this should default to on. You are voting
off. I personally think on.
Andrew? Randy? Joel?
The main audience of this is new contributors, who should have more verbose
output, including nitpicky things like multiple assignments per line. The
default should tar
I agree that these patches would be very useful. I just rebased my fix
for a VTTBR_BADDR_MASK bug on one of these patches that could be pulled
out independently. See
https://lists.cs.columbia.edu/pipermail/kvmarm/2014-July/010480.html
The original author Jungseok Lee is no longer available to wo
I've been running and doing development on top of these patches. I
found a problem in an earlier version that i can confirm is now fixed in
this current version.
Reviewed-by: Joel Schopp
On 06/23/2014 07:32 PM, suravee.suthikulpa...@amd.com wrote:
From: Suravee Suthikulpanit
This
+ if (resource_size(&cpu_res) >= SZ_8K)
+ supports_deactivate = true;
+ else
+ pr_warn("GIC: CPU interface size is %x, DT is probably
wrong\n", (int)resource_size(&cpu_res));
This will not work on APM X-Gene because, for
X
On 10/22/2013 12:36 PM, Peter Huewe wrote:
> Since I'm actively maintaining the tpm subsystem for a few months now,
> it's time to step up and be an official maintainer for the tpm subsystem,
> atleast until I hear something different from my company.
>
> The maintaining is done solely in my priva
>> I have no objection to you adding yourself here. I do think we should
>> probably also cut the list down at the same time as I don't think all
>> the listed maintainers are active anymore. Also, the list is getting a
>> bit unwieldy. If everyone maintains it nobody maintains it.
>
> I agree wi
> These would have been posted as patch numbers 8 through 13 in the
> original series.
>
> I think what happened is at this point in the series module compile
> broke. That is fixed now in the for-james pull, so the rest of the
> series should be looked at.
>
> Peter's checkpatch clean up will c
On 11/05/2014 03:12 AM, Shannon Zhao wrote:
> Hi Rémy,
>
> On 2014/11/5 16:26, GAUGUEY Rémy 228890 wrote:
>> Hi Shannon,
>>
>>> Type of backend bandwith(GBytes/sec)
>>> virtio-net 0.66
>>> vhost-net 1.49
>>> vhost-net with irqfd2.01
>>>
>>> Test cmd: ./iperf
On 10/02/2014 08:47 AM, Alex Williamson wrote:
On Thu, 2014-10-02 at 16:05 +0300, Marti Raudsepp wrote:
AMD has confirmed that peer-to-peer between two southbridge functions
does not occur.
Joel Schopp at https://bugzilla.kernel.org/show_bug.cgi?id=81841#c15
+-14.4-[01]05.0
>> -clr_cr_intercept(svm, INTERCEPT_CR0_WRITE);
>> } else {
>> set_cr_intercept(svm, INTERCEPT_CR0_READ);
> (There is no point in checking fpu_active if cr0s are equal.)
>
>> -set_cr_intercept(svm, INTERCEPT_CR0_WRITE);
> KVM uses lazy FPU and the state is
On 02/25/2015 02:26 PM, Radim Krčmář wrote:
> 2015-02-24 15:25-0600, Joel Schopp:
>>>> - clr_cr_intercept(svm, INTERCEPT_CR0_WRITE);
>>>>} else {
>>>>set_cr_intercept(svm, INTERCEPT_CR0_READ);
>>> (There is n
On 03/11/2015 05:47 PM, Luck, Tony wrote:
>> When running as a guest under kvm, it's possible that the MSR
>> being accessed may not be implemented. All MSR accesses should
>> be prepared to handle exceptions.
> Isn't that a KVM bug? The code here first checks family/model before
> accessing th
There isn't really a valid reason for kvm to intercept cr* reads
on svm hardware. The current kvm code just ends up returning
the register
Signed-off-by: Joel Schopp
---
arch/x86/kvm/svm.c | 41 -
1 file changed, 4 insertions(+), 37 deletions(-)
larger removal of
INTERCEPT_CR0_WRITE, forward ported, tested]
Signed-off-by: Joel Schopp
---
arch/x86/kvm/svm.c |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index d319e0c..57f0240 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86
-off-by: David Kaplan
[separated out just cr_interception part from larger removal of
INTERCEPT_CR0_WRITE, forward ported, tested]
Signed-off-by: Joel Schopp
---
arch/x86/kvm/svm.c |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
if (val & BIT_64(62)) {
> - val &= ~BIT_64(62);
> - wrmsrl(msrs[i], val);
> - }
> + /* Clear CntP bit safely */
> + msr_clear_bit(msrs[i], 62);
>
On 03/12/2015 04:20 PM, Radim Krčmář wrote:
> 2015-03-12 15:17-0500, Joel Schopp:
>> There isn't really a valid reason for kvm to intercept cr* reads
>> on svm hardware. The current kvm code just ends up returning
>> the register
> There is no need to intercept CR
Thank you for your detailed review on several of my patches.
>>
>> +static int complete_fast_pio(struct kvm_vcpu *vcpu)
> (complete_fast_pio_in()?)
If I do a v4 I'll adopt that name.
>> +{
>> +unsigned long new_rax = kvm_register_read(vcpu, VCPU_REGS_RAX);
> Shouldn't we handle writes in EAX
On 03/03/2015 10:44 AM, Radim Krčmář wrote:
> 2015-03-02 15:02-0600, Joel Schopp:
>> +int kvm_fast_pio_in(struct kvm_vcpu *vcpu, int size, unsigned short port)
>> +{
>> +unsigned long val;
>> +int ret = emulator_pio_in_emulated(&am
KVM has nice wrappers to access the register values, clean up a few places
that should use them but currently do not.
Signed-off-by:David Kaplan
Signed-off-by:Joel Schopp
---
arch/x86/kvm/svm.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/arch/x86/k
On 02/20/2015 02:54 PM, Borislav Petkov wrote:
> On Fri, Feb 20, 2015 at 12:39:40PM -0600, Joel Schopp wrote:
>> KVM has nice wrappers to access the register values, clean up a few places
>> that should use them but currently do not.
>>
>> Signed-off-by:David Kaplan
&
From: David Kaplan
KVM has nice wrappers to access the register values, clean up a few places
that should use them but currently do not.
Signed-off-by: David Kaplan
[forward port and testing]
Signed-off-by: Joel Schopp
---
arch/x86/kvm/svm.c | 19 +--
1 file changed, 9
INTERCEPT_SELECTIVE_CR0 and not setting
INTERCEPT_CR0_WRITE.
Signed-off-by: David Kaplan
[added remove of clr_cr_intercept in init_vmcb, fixed check in handle_exit,
added emulation on interception back in, forward ported, tested]
Signed-off-by: Joel Schopp
---
arch/x86/kvm/svm.c | 13 +++--
1 file
From: David Kaplan
We can make the in instruction go faster the same way the out instruction is
already.
Signed-off-by: David Kaplan
[extracted from larger unlrelated patch, forward ported, tested]
Signed-off-by: Joel Schopp
---
arch/x86/kvm/svm.c |4 +++-
1 file changed, 3 insertions
From: David Kaplan
We can make the in instruction go faster the same way the out instruction is
already.
Signed-off-by: David Kaplan
[extracted from larger unlrelated patch, forward ported, tested]
Signed-off-by: Joel Schopp
---
arch/x86/kvm/svm.c |4 +++-
1 file changed, 3 insertions
From: David Kaplan
No need to re-decode WBINVD since we know what it is from the intercept.
Signed-off-by: David Kaplan
[extracted from larger unlrelated patch, forward ported, tested]
Signed-off-by: Joel Schopp
---
arch/x86/kvm/svm.c | 10 +-
1 file changed, 9 insertions(+), 1
+ if (in)
+ return kvm_fast_pio_in(vcpu, size, port);
Have I missed a patch that defined kvm_fast_pio_in()?
Not sure how I managed to leave out the bulk of the patch. Resending v2
momentarily.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
th
-off-by: Joel Schopp
---
arch/x86/include/asm/kvm_host.h |1 +
arch/x86/kvm/svm.c |4 +++-
arch/x86/kvm/x86.c | 33 +
3 files changed, 37 insertions(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86
On 03/02/2015 10:03 AM, Radim Krčmář wrote:
2015-03-02 10:25-0500, Bandan Das:
Radim Krčmář writes:
2015-03-01 21:29-0500, Bandan Das:
Joel Schopp writes:
+static int wbinvd_interception(struct vcpu_svm *svm)
+{
+ kvm_emulate_wbinvd(&svm->vcpu);
+ skip_emulated_inst
Currently kvm_emulate() skips the instruction but kvm_emulate_* sometimes
don't. The end reult is the caller ends up doing the skip themselves.
Let's make them consistant.
Signed-off-by: Joel Schopp
---
arch/x86/kvm/svm.c |2 --
arch/x86/kvm/vmx.c |9 +++--
arch/x86
Review comments from v1 that used kvm_emulate_wbinvd() pointed out that
kvm_emulate_* was inconsistant in using skipping, while kvm_emulate() always
skips. The first patch cleans up the existing use while the second patch
adds use of the updated version of kvm_emulate_wbinvd() in svm
---
Joel
From: David Kaplan
No need to re-decode WBINVD since we know what it is from the intercept.
Signed-off-by: David Kaplan
[extracted from larger unlrelated patch, forward ported, tested]
Signed-off-by: Joel Schopp
---
arch/x86/kvm/svm.c |9 -
1 file changed, 8 insertions(+), 1
---
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
@@ -4995,7 +4995,7 @@ static int handle_rmode_exception(struct kvm_vcpu *vcpu,
if (emulate_instruction(vcpu, 0) == EMULATE_DONE) {
if (vcpu->arch.halt_request) {
vcpu-
From: David Kaplan
No need to re-decode WBINVD since we know what it is from the intercept.
Signed-off-by: David Kaplan
[extracted from larger unlrelated patch, forward ported, tested,style cleanup]
Signed-off-by: Joel Schopp
---
arch/x86/kvm/svm.c |8 +++-
1 file changed, 7
Currently kvm_emulate() skips the instruction but kvm_emulate_* sometimes
don't. The end reult is the caller ends up doing the skip themselves.
Let's make them consistant.
Signed-off-by: Joel Schopp
---
arch/x86/include/asm/kvm_host.h |1 +
arch/x86/kvm/svm.c |
since v2:
* fixed email subject line on series short description
* renamed kvm_emulate_halt_noskip() to kvm_vcpu_halt()
* added header declaration for kvm_vcpu_halt()
* squashed blank line
---
David Kaplan (1):
x86: svm: make wbinvd faster
Joel Schopp (1
return emulate_instruction(vcpu, 0) == EMULATE_DONE;
port = io_info >> 16;
@@ -1907,6 +1907,8 @@ static int io_interception(struct vcpu_svm *svm)
svm->next_rip = svm->vmcb->control.exit_info_2;
skip_emulated_instruction(&svm->vcpu);
+ if (in)
+
* removed redundant clearing of count
Changes from v1[Joel]
* Added kvm_fast_pio_in() implementation that was left out of v1
Signed-off-by: David Kaplan
[extracted from larger unlrelated patch, forward ported, addressed reviews,
tested]
Signed-off-by: Joel Schopp
---
arch/x86/include
59 matches
Mail list logo
