Re: [PATCH 1/2] remove all uses of printf's %n

On Fri, 2013-09-20 at 12:24 -0700, Kees Cook wrote: > There are a few problems that have been discussed on the various > threads. Namely, we want to minimize the changes to the seq_file > structure and to not add additional work to all the seq_file users > that don't care about padding. I don't th

[PATCH 01/12] inet*.h: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/inet6_connection_sock.h | 32 +++ include/net/inet6_hashtables.h | 38 +- include/net/inet_common.h | 48 +++--- include/net/inet_connection_sock.h

[PATCH 09/12] iw_handler.h: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/iw_handler.h | 38 +- 1 file changed, 13 insertions(+), 25 deletions(-) diff --git a/include/net/iw_handler.h b/include/net/iw_handler.h index 5d5a6a4..a830b01 100644 --- a/includ

[PATCH 08/12] net_namespace.h: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/net_namespace.h | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/include/net/net_namespace.h b/include/net/net_namespace.h index 1313456..38c2afb 100644 --- a/includ

[PATCH 10/12] netevent/netlink.h: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/netevent.h | 6 ++--- include/net/netlink.h | 63 -- 2 files changed, 28 insertions(+), 41 deletions(-) diff --git a/include/net/netevent.h b/include/net/netevent.h

[PATCH 07/12] ndisc.h: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/ndisc.h | 61 +++-- 1 file changed, 26 insertions(+), 35 deletions(-) diff --git a/include/net/ndisc.h b/include/net/ndisc.h index ea0cc26..6bbda34 100644 --- a/includ

[PATCH 04/12] lapb.h: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/lapb.h | 52 ++-- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/include/net/lapb.h b/include/net/lapb.h index df892a9..9510f87 100644 --- a/include/net/l

[PATCH 05/12] llc*.h: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/llc.h | 50 ++-- include/net/llc_c_ac.h | 190 - include/net/llc_c_ev.h | 207 +++-- include/net/llc_conn.h

[PATCH 06/12] mrp.h: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/mrp.h | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/include/net/mrp.h b/include/net/mrp.h index 4fbf02a..687c8fe 100644 --- a/include/net/mrp.h +++ b/include/net/

[PATCH 03/12] ipx.h: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/ipx.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/include/net/ipx.h b/include/net/ipx.h index c1fec6b..9e9e354 100644 --- a/include/net/ipx.h +++ b/include/net/ipx.h @@ -123,23 +1

[PATCH 12/12] p8022.h: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/p8022.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/include/net/p8022.h b/include/net/p8022.h index 42e9fac..05e4138 100644 --- a/include/net/p8022.h +++ b/include/net/p8

[PATCH 02/12] ip*.h: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/ip.h| 169 +++--- include/net/ip6_fib.h | 53 +- include/net/ip6_route.h | 98 -- include/net/ip_fib.h| 61 ++- include/net/ip_vs.h

[PATCH 11/12] netrom.h: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/netrom.h | 89 ++-- 1 file changed, 44 insertions(+), 45 deletions(-) diff --git a/include/net/netrom.h b/include/net/netrom.h index 121dcf8..110350a 100644 --- a/includ

Re: [PATCH 12/19] wireless: Change variable type to bool

On Sun, 2013-09-22 at 00:27 +0200, Peter Senna Tschudin wrote: > The variable continual is only assigned the values true and false. > Change its type to bool. [] > diff --git a/drivers/net/wireless/rtlwifi/efuse.c > b/drivers/net/wireless/rtlwifi/efuse.c [] > @@ -1203,7 +1203,7 @@ static void efus

[PATCH 01/12] ping.h: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/ping.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/net/ping.h b/include/net/ping.h index 5db0224..3f67704 100644 --- a/include/net/ping.h +++ b/include/net/ping.h @@ -103,8 +103,8 @@

[PATCH 09/12] scm.h: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/scm.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/net/scm.h b/include/net/scm.h index 8de2d37..262532d 100644 --- a/include/net/scm.h +++ b/include/net/scm.h @@ -33,11 +

[PATCH 11/12] sock.h: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/sock.h | 223 - 1 file changed, 99 insertions(+), 124 deletions(-) diff --git a/include/net/sock.h b/include/net/sock.h index 6ba2e7b..4625d2e 100644 --- a/includ

[PATCH 12/12] stp.h: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/stp.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/net/stp.h b/include/net/stp.h index ad447f1..3af174d 100644 --- a/include/net/stp.h +++ b/include/net/stp.h @@ -8,7 +8,7 @@ s

[PATCH 07/12] route.h: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/route.h | 53 - 1 file changed, 28 insertions(+), 25 deletions(-) diff --git a/include/net/route.h b/include/net/route.h index afdeeb5..6f572ca 100644 --- a/includ

[PATCH 08/12] rtnetlink.h: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/rtnetlink.h | 40 +++- 1 file changed, 19 insertions(+), 21 deletions(-) diff --git a/include/net/rtnetlink.h b/include/net/rtnetlink.h index 7026648..bb13a18 100644 --- a/includ

[PATCH 10/12] secure_seq.h: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/secure_seq.h | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/include/net/secure_seq.h b/include/net/secure_seq.h index 6ca975b..52c1a90 100644 --- a/include/net/secure_

[PATCH 02/12] protocol.h: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/protocol.h | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/include/net/protocol.h b/include/net/protocol.h index 047c047..fbf7676 100644 --- a/include/net/protocol.h

[PATCH 05/12] request_sock.h: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/request_sock.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/include/net/request_sock.h b/include/net/request_sock.h index 59795e4..65c3e516 100644 --- a/include/net/request_sock.h

[PATCH 06/12] rose.h: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/rose.h | 114 - 1 file changed, 60 insertions(+), 54 deletions(-) diff --git a/include/net/rose.h b/include/net/rose.h index 555dd19..50811fe 100644 --- a/includ

[PATCH 03/12] psnap.h: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/psnap.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/net/psnap.h b/include/net/psnap.h index fe456c2..78db4cc 100644 --- a/include/net/psnap.h +++ b/include/net/psnap.h @@ -1,11

[PATCH 04/12] raw/rawv6.h: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/raw.h | 6 +++--- include/net/rawv6.h | 3 +-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/include/net/raw.h b/include/net/raw.h index 42ce6fe..6a40c65 100644 --- a/include/net/raw.h +++ b/includ

Re: [PATCH 1/5] scsi: Fix assignment of 0/1 to bool variables

On Sun, 2013-09-22 at 20:44 +0200, Peter Senna Tschudin wrote: > Convert 0 to false and 1 to true when assigning values to bool > variables. Inspired by commit 3db1cd5c05f35fb43eb134df6f321de4e63141f2. [] > @@ > bool b; > @@ > -b = 1 > +b = true You might also look for non-zero values other than 1

Re: [PATCH 01/12] ping.h: Remove extern from function prototypes

On Mon, 2013-09-23 at 11:59 +1000, Ryan Mallon wrote: > This seems like a lot of code churn for very little benefit. At a quick > glance: > > git grep extern include/ | wc -l > 11427 > > Not all of those will need to be removed, but that is still a huge > number to change, and doesn't include

Re: [PATCH 01/12] ping.h: Remove extern from function prototypes

On Mon, 2013-09-23 at 12:38 +1000, Ryan Mallon wrote: > A checkpatch rule might help, Extant. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: [PATCH] iio: add Bosch BMG160 gyroscope sensor driver

On Mon, 2013-09-23 at 13:35 +0800, jianlong wrote: > This patch adds IIO driver for Bosch BMG160 triaxial gyroscope sensor. This code could be made a lot more readable without the somewhat obfuscating 16 bit compiler support. Are there similar devices that this source needs to support in the futu

Re: [PATCH v5 1/4] media: s5p-tv: Replace mxr_ macro by default dev_

On Mon, 2013-09-23 at 17:48 +0200, Bartlomiej Zolnierkiewicz wrote: > On Monday, September 23, 2013 04:50:01 PM Tomasz Stanislawski wrote: > > May I ask what is the rationale for this patch? > > To reduce a few lines of code? > This patch makes source code more generic-like and easier to follow (mx

Re: [PATCH] iio: add Bosch BMG160 gyroscope sensor driver

On Mon, 2013-09-23 at 13:35 +0800, jianlong wrote: > This patch adds IIO driver for Bosch BMG160 triaxial gyroscope sensor. > Thanks a lot. Maybe some trivial, mostly whitespace, corrections before modifying the bmg160_api.c and bmg_iio.h files... --- drivers/iio/gyro/bmg160_core.c| 286 +

[PATCH 04/12] wext.h: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/wext.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/include/net/wext.h b/include/net/wext.h index 4f6e742..3459119 100644 --- a/include/net/wext.h +++ b/include/net/wext.h @@

[PATCH 05/12] wimax.h: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/wimax.h | 33 - 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/include/net/wimax.h b/include/net/wimax.h index bbb74f9..98498e1 100644 --- a/include/net/wimax.h +++ b/in

[PATCH 07/12] xfrm.h: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/xfrm.h | 375 +++-- 1 file changed, 190 insertions(+), 185 deletions(-) diff --git a/include/net/xfrm.h b/include/net/xfrm.h index e253bf0..7657461 100644 --- a/includ

[PATCH 08/12] bluetooth: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/bluetooth/bluetooth.h | 16 include/net/bluetooth/hci_core.h | 23 +++ include/net/bluetooth/rfcomm.h| 4 ++-- 3 files changed, 21 insertions(+), 22 deletions(-) diff --

[PATCH 09/12] caif_hsi.h: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/caif/caif_hsi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/caif/caif_hsi.h b/include/net/caif/caif_hsi.h index 4795e81..097f69c 100644 --- a/include/net/caif/caif_hsi.h +++ b/includ

[PATCH 11/12] netfilter: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/netfilter/ipv4/nf_conntrack_ipv4.h | 6 +-- include/net/netfilter/ipv4/nf_defrag_ipv4.h| 2 +- include/net/netfilter/ipv6/nf_defrag_ipv6.h| 17 +++ include/net/netfilter/nf_conntrack.h

[PATCH 12/12] sctp: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/sctp/sctp.h | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/include/net/sctp/sctp.h b/include/net/sctp/sctp.h index 3794c5a..c5fe806 100644 --- a/include/net/sctp/sctp.h +++ b/includ

[PATCH 01/12] tcp.h: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/tcp.h | 424 +++--- 1 file changed, 208 insertions(+), 216 deletions(-) diff --git a/include/net/tcp.h b/include/net/tcp.h index b1aa324..0e47551 100644 --- a/includ

[PATCH 06/12] x25.h: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/x25.h | 141 +++--- 1 file changed, 71 insertions(+), 70 deletions(-) diff --git a/include/net/x25.h b/include/net/x25.h index b4a8a89..c383aa4 100644 --- a/include/net/

[PATCH 10/12] irda: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/irda/ircomm_tty.h | 14 +++--- include/net/irda/irda.h| 21 ++--- include/net/irda/irlap_event.h | 2 +- include/net/irda/irlap_frame.h | 4 ++-- 4 files changed, 20 insertions(+

[PATCH 03/12] udplite.h: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/udplite.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/net/udplite.h b/include/net/udplite.h index 7137545..2caadab 100644 --- a/include/net/udplite.h +++ b/include/net/udpl

[PATCH 02/12] udp.h: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- include/net/udp.h | 94 +++ 1 file changed, 47 insertions(+), 47 deletions(-) diff --git a/include/net/udp.h b/include/net/udp.h index ef2e0b7..510b8cb 100644 --- a/include/net/

Re: checkpatch guide for newbies

On Mon, 2013-09-23 at 12:01 +0300, Dan Carpenter wrote: > I've written a checkpatch guide for newbies because it seems like they > make the same mistakes over and over. I intend to put it under > Documentation/. Could you look it over? > > > Introduction > > This document is aime

Re: checkpatch guide for newbies

On Mon, 2013-09-23 at 11:06 -0700, Joe Perches wrote: > Maybe I'll submit some auto-neatening script eventually > and see what you think. Maybe something like: From: Joe Perches Subject: [PATCH] scripts/fix_with_checkpatch.sh: Add a trivial script to fix simple style defects

Re: [PATCH] stable_kernel_rules.txt: Exclude networking from stable rules

On Sun, 2013-09-22 at 11:51 -0700, Christoph Hellwig wrote: > This is also the preferred way to do it for XFS. Maybe word it in a way > that we can easily add subsystems. > > To me it generally seems to be the best way to do it - having random Ccs > and lots of stable trees doesn't seem like a ve

Re: [PATCH 01/12] tcp.h: Remove extern from function prototypes

On Mon, 2013-09-23 at 16:30 -0400, David Miller wrote: > Series applied, How about the same changes for the .h files in drivers/net ? (slowly of course, and by maintained subsystem) $ git grep -E "^\s*\bextern(\s+\w+){1,4}\s*\(\s*[^\*]" drivers/net/ | wc -l 1445 Maybe something like groups of:

[PATCH 01/10] can: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- drivers/net/can/mscan/mscan.h | 6 +++--- drivers/net/can/softing/softing.h | 24 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/net/can/mscan/mscan.h b/drivers/net/can/

[PATCH 02/10] 8390: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- drivers/net/ethernet/8390/8390.h | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/net/ethernet/8390/8390.h b/drivers/net/ethernet/8390/8390.h index ef325ff..29

[PATCH 03/10] adi: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- drivers/net/ethernet/adi/bfin_mac.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/adi/bfin_mac.h b/drivers/net/ethernet/adi/bfin_mac.h index 7a07ee0..6dec86a 100644 --- a/drivers/net/eth

[PATCH 09/10] emulex: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- drivers/net/ethernet/emulex/benet/be.h | 24 +-- drivers/net/ethernet/emulex/benet/be_cmds.h | 238 +--- 2 files changed, 123 insertions(+), 139 deletions(-) diff --git a/drivers/net/ethernet/emulex/

[PATCH 04/10] amd/7990: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- drivers/net/ethernet/amd/7990.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/amd/7990.h b/drivers/net/ethernet/amd/7990.h index 0a5837b..ae33a99 100644 --- a/drivers/net/eth

[PATCH 10/10] gianfar: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- drivers/net/ethernet/freescale/gianfar.h | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/net/ethernet/freescale/gianfar.h b/drivers/net/ethernet/freescale/gianfar.h index 04

[PATCH 07/10] brocade: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- drivers/net/ethernet/brocade/bna/bnad.h | 43 - 1 file changed, 21 insertions(+), 22 deletions(-) diff --git a/drivers/net/ethernet/brocade/bna/bnad.h b/drivers/net/ethernet/brocade/bna/bnad.h

[PATCH 08/10] chelsio: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- drivers/net/ethernet/chelsio/cxgb/common.h | 46 +++--- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb/common.h b/drivers/net/ethernet/chelsio/cxgb/com

[PATCH 06/10] broadcom: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- drivers/net/ethernet/broadcom/cnic_if.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/cnic_if.h b/drivers/net/ethernet/broadcom/cnic_if.h index 0658b43..ebbfe25 100644

[PATCH 05/10] atheros: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- drivers/net/ethernet/atheros/atl1c/atl1c.h | 6 +++--- drivers/net/ethernet/atheros/atl1e/atl1e.h | 12 ++-- drivers/net/ethernet/atheros/atlx/atl2.h | 2 +- 3 files changed, 10 insertions(+), 10 deletions(-) diff --

Re: False positive in checkpatch

On Mon, 2013-09-23 at 15:59 -0700, Paul E. McKenney wrote: > Hello! > > The checkpatch.pl script complains as follows: > > ERROR: need consistent spacing around '*' (ctx:WxB) > #57: FILE: include/linux/rcupdate.h:564: > + ACCESS_ONCE(p) = (typeof(*(v)) __force space *)(v); \ > > Of c

Re: [PATCH v5 1/4] media: s5p-tv: Replace mxr_ macro by default dev_

On Tue, 2013-09-24 at 14:52 +0200, Tomasz Stanislawski wrote: > On 09/23/2013 07:44 PM, Joe Perches wrote: > > On Mon, 2013-09-23 at 17:48 +0200, Bartlomiej Zolnierkiewicz wrote: > >> On Monday, September 23, 2013 04:50:01 PM Tomasz Stanislawski wrote: > >>> May I

Re: [PATCH 04/10] amd/7990: Remove extern from function prototypes

Hey David. This ended up in your tree as commit 44da5c2f523876a02336c18dbcce93449fdbf0ca without your signoff. Is there something I need to do differently so your scripts add your sign-off properly or did this manage to just slip through via some manual git am without the -s? -- To unsubscribe

[PATCH] checkpatch: Find CamelCase definitions of struct/union/enum

Checkpatch doesn't currently find CamelCase definitions of structs, unions or enums. Add that ability. Signed-off-by: Joe Perches --- scripts/checkpatch.pl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index c0

[PATCH 00/10 - GIT PULL] drivers: net: Next block of Remove extern from function prototypes

294da3abaa73a0b69fd54e442b0b5bd9455b7be6: irda: Remove extern from function prototypes (2013-09-24 12:54:17 -0700) Joe Perches (10): ibm/emac: Remove extern from function prototypes intel: Remove extern from function prototypes oki-semi

[PATCH 04/10] qlogic: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- drivers/net/ethernet/qlogic/netxen/netxen_nic.h | 5 +-- drivers/net/ethernet/qlogic/qlge/qlge.h | 58 - 2 files changed, 30 insertions(+), 33 deletions(-) diff --git a/drivers/net/ethernet/q

[PATCH 02/10] intel: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- drivers/net/ethernet/intel/e1000/e1000.h | 32 ++--- drivers/net/ethernet/intel/e1000e/e1000.h| 45 --- drivers/net/ethernet/intel/igb/e1000_82575.h | 16 +-- drivers/net/ethernet/intel/igb/e1000_hw.h| 6 +- dr

[PATCH 09/10] fddi/skfp: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- drivers/net/fddi/skfp/h/smc.h | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/net/fddi/skfp/h/smc.h b/drivers/net/fddi/skfp/h/smc.h index 3ca308b..bd1166b 100644 --- a/dr

[PATCH 10/10] irda: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- drivers/net/irda/sir-dev.h | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/drivers/net/irda/sir-dev.h b/drivers/net/irda/sir-dev.h index 6d5b1e2..f50b9c1 100644 --- a/drivers/net

[PATCH 08/10] toshiba: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- drivers/net/ethernet/toshiba/ps3_gelic_net.h | 29 +++ drivers/net/ethernet/toshiba/ps3_gelic_wireless.h | 6 ++--- drivers/net/ethernet/toshiba/spider_net.h | 4 ++-- 3 files changed, 19 inser

[PATCH 06/10] stmicro: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- drivers/net/ethernet/stmicro/stmmac/common.h| 12 ++-- drivers/net/ethernet/stmicro/stmmac/dwmac_dma.h | 17 - drivers/net/ethernet/stmicro/stmmac/mmc.h | 6 +++--- drivers/net/ethernet/stmicro/s

[PATCH 03/10] oki-semi: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h | 56 - 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h b/drivers/net/ethernet/oki-semi/pc

[PATCH 05/10] sfc: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- drivers/net/ethernet/sfc/efx.h | 104 +- drivers/net/ethernet/sfc/mcdi.h | 120 ++--- drivers/net/ethernet/sfc/mdio_10g.h | 26 +++-- drivers/net/ethernet/sfc/nic.h

[PATCH 07/10] ti: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- drivers/net/ethernet/ti/cpts.h | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/ti/cpts.h b/drivers/net/ethernet/ti/cpts.h index fe993cd..1a581ef 100644 --- a/drivers/net/ethern

[PATCH 01/10] ibm/emac: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- drivers/net/ethernet/ibm/emac/debug.h | 14 +++--- drivers/net/ethernet/ibm/emac/rgmii.h | 18 +- drivers/net/ethernet/ibm/emac/tah.h | 14 +++--- drivers/net/ethernet/ibm/emac/zmii.h

[RFC patch] Update Jens Osterkamp email address

The old address isn't working. Signed-off-by: Joe Perches --- Maybe if you're still interested in receiving emails on this old driver... On Tue, 2013-09-24 at 14:10 -0700, postmas...@de.ibm.com wrote: > Your message > Subject: [PATCH 08/10] toshiba: Remove extern from fun

Re: [RFC patch] Update Jens Osterkamp email address

On Tue, 2013-09-24 at 14:21 -0700, Joe Perches wrote: > The old address isn't working. > > Signed-off-by: Joe Perches > --- > > Maybe if you're still interested in receiving emails > on this old driver... > > On Tue, 2013-09-24 at 14:10 -0700, postmas.

Re: [PATCH 02/10] intel: Remove extern from function prototypes

On Tue, 2013-09-24 at 15:07 -0700, Jeff Kirsher wrote: > On Tue, 2013-09-24 at 14:09 -0700, Joe Perches wrote: > > There are a mix of function prototypes with and without extern > > in the kernel sources. Standardize on not using extern for > > function prototypes. > &g

Re: [PATCH] checkpatch: Find CamelCase definitions of struct/union/enum

On Wed, 2013-09-25 at 16:24 +0100, Al Viro wrote: > On Tue, Sep 24, 2013 at 11:38:54AM -0700, Joe Perches wrote: > > Checkpatch doesn't currently find CamelCase definitions > > of structs, unions or enums. > > > > Add that ability. > > Fix your regex. As

Re: [PATCH] checkpatch: Find CamelCase definitions of struct/union/enum

On Wed, 2013-09-25 at 17:19 +0100, Al Viro wrote: > On Wed, Sep 25, 2013 at 08:35:44AM -0700, Joe Perches wrote: > > I think Propercase should be discouraged. > > ie: Qdisc et al. > > Excuse me, but "Joe happens to think that something should be discouraged"

[PATCH 01/11] vmxnet3: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- drivers/net/vmxnet3/vmxnet3_int.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_int.h b/drivers/net/vmxnet3/vmxnet3_int.h index a03f358..12040a3 100644 --- a/drivers/net/vm

[PATCH 00/11 - GIT PULL] drivers: net: Last block of Remove extern from function prototypes

a958df5dc3065ce517726dc54087639e13ffee8f: rtlwifi: Remove extern from function prototypes (2013-09-24 18:06:51 -0700) Joe Perches (11): vmxnet3: Remove extern from function prototypes wan: Remove extern from function prototypes

[PATCH 11/11] rtlwifi: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- drivers/net/wireless/rtlwifi/cam.h | 10 ++--- drivers/net/wireless/rtlwifi/efuse.h | 29 +++-- drivers/net/wireless/rtlwifi/rtl8188ee/phy.h | 49 ++ drivers/net/wireless/rtlwifi/rtl8

[PATCH 04/11] ath: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- drivers/net/wireless/ath/ath10k/debug.h | 8 drivers/net/wireless/ath/ath6kl/common.h | 3 +-- drivers/net/wireless/ath/ath6kl/debug.h | 9 - drivers/net/wireless/ath/ath9k/ath9k.h | 2 +- 4 files change

[PATCH 08/11] iwlwifi: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- drivers/net/wireless/iwlwifi/dvm/agn.h | 2 +- drivers/net/wireless/iwlwifi/dvm/dev.h | 2 +- drivers/net/wireless/iwlwifi/dvm/rs.h | 8 drivers/net/wireless/iwlwifi/mvm/rs.h | 9 - 4 files changed, 10 inser

[PATCH 07/11] iwlegacy: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- drivers/net/wireless/iwlegacy/3945.h | 82 -- drivers/net/wireless/iwlegacy/4965.h | 2 +- drivers/net/wireless/iwlegacy/common.h | 66 +-- 3 files changed, 73 inser

[PATCH 09/11] mwifiex: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- drivers/net/wireless/mwifiex/wmm.h | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/net/wireless/mwifiex/wmm.h b/drivers/net/wireless/mwifiex/wmm.h index 644d6e0..0f129d4 1

[PATCH 03/11] wimax: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- drivers/net/wimax/i2400m/i2400m-usb.h | 27 drivers/net/wimax/i2400m/i2400m.h | 117 +- 2 files changed, 70 insertions(+), 74 deletions(-) diff --git a/drivers/net/wimax/i2400m/i2400m-

[PATCH 10/11] orinoco: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- drivers/net/wireless/orinoco/orinoco.h | 31 ++- 1 file changed, 14 insertions(+), 17 deletions(-) diff --git a/drivers/net/wireless/orinoco/orinoco.h b/drivers/net/wireless/orinoco/orinoco.h index 3b

[PATCH 06/11] ipw2x00: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- drivers/net/wireless/ipw2x00/libipw.h | 87 +++ 1 file changed, 38 insertions(+), 49 deletions(-) diff --git a/drivers/net/wireless/ipw2x00/libipw.h b/drivers/net/wireless/ipw2x00/libipw.h index 6e

[PATCH 02/11] wan: Remove extern from function prototypes

clare automatic/local variables in a block. Signed-off-by: Joe Perches --- drivers/net/wan/x25_asy.h | 2 +- drivers/net/wan/z85230.h | 27 +-- 2 files changed, 14 insertions(+), 15 deletions(-) diff --git a/drivers/net/wan/x25_asy.h b/drivers/net/wan/x25_asy.h index 8f0fc2e..f5

Re: [PATCH] checkpatch: Find CamelCase definitions of struct/union/enum

On Wed, 2013-09-25 at 15:30 -0400, Theodore Ts'o wrote: > On Wed, Sep 25, 2013 at 12:22:00PM -0700, Joe Perches wrote: > > > > > * labels a-la Enomem, etc. I've been using those and I will > > > keep doing so, checkpatch.pl and its users be damned. > >

[PATCH] MAINTAINERS: wi...@linuxwimax.org is subscribers-only

Mark it so. Signed-off-by: Joe Perches --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index e61c2e8..a386a22 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4414,7 +4414,7 @@ F:arch/x86/kernel/tboot.c INTEL WIRELESS

Re: [PATCH] MAINTAINERS: wi...@linuxwimax.org is subscribers-only

On Wed, 2013-09-25 at 16:09 -0400, Dave Jones wrote: > On Wed, Sep 25, 2013 at 12:54:52PM -0700, Joe Perches wrote: > > Mark it so. [] > > diff --git a/MAINTAINERS b/MAINTAINERS [] > > @@ -4414,7 +4414,7 @@ F: arch/x86/kernel/tboot.c > > INTEL WIRELESS WI

Re: [PATCH v2] checkpatch: Suggest using min_t or max_t

On Wed, 2012-09-05 at 13:21 +0200, Philippe De Muyter wrote: > On 5/27/11, Joe Perches wrote: > > A common issue with min() or max() is using a cast on > > one or both of the arguments when using min_t/max_t could > > be better. > > > > Add cast detection

Re: [PATCH 2/3] x86/mce: Pack boolean MCE flags into a structure

On Wed, 2012-09-05 at 15:52 +0530, Naveen N. Rao wrote: > Many MCE flags are boolean in nature, but are declared as integers > currently. We can pack these into a bitfield to save some space. [] > diff --git a/arch/x86/kernel/cpu/mcheck/mce-internal.h > b/arch/x86/kernel/cpu/mcheck/mce-internal.h

Re: [PATCH v2] checkpatch: Suggest using min_t or max_t

On Thu, 2012-09-06 at 02:16 +0200, Philippe De Muyter wrote: > On Wed, Sep 5, 2012 at 7:07 PM, Joe Perches wrote: > > On Wed, 2012-09-05 at 13:21 +0200, Philippe De Muyter wrote: > >> > v2: Make $match_balanced_parentheses work in perl 5.8 > >> > >> Has this

Re: [PATCH 0/5] dev_ and dynamic_debug cleanups

On Thu, 2012-09-06 at 13:51 -0400, Jason Baron wrote: > On Sun, Aug 26, 2012 at 04:25:25AM -0700, Joe Perches wrote: > > The recent commit to fix dynamic_debug was a bit unclean. > > Neaten the style for dynamic_debug. > > Reduce the stack use of message logging that uses

Re: [PATCH 0/5] dev_ and dynamic_debug cleanups

On Thu, 2012-09-06 at 11:43 -0700, Joe Perches wrote: > On Thu, 2012-09-06 at 13:51 -0400, Jason Baron wrote: > > On Sun, Aug 26, 2012 at 04:25:25AM -0700, Joe Perches wrote: > > > The recent commit to fix dynamic_debug was a bit unclean. > > > Neaten the style for dyna

Re: [PATCH 0/5] dev_ and dynamic_debug cleanups

On Fri, 2012-09-07 at 10:52 -0400, Jason Baron wrote: > On Thu, Sep 06, 2012 at 11:43:46AM -0700, Joe Perches wrote: > > On Thu, 2012-09-06 at 13:51 -0400, Jason Baron wrote: > > > On Sun, Aug 26, 2012 at 04:25:25AM -0700, Joe Perches wrote: > > > > The recent commit

Re: [PATCH 0/5] dev_ and dynamic_debug cleanups

On Fri, 2012-09-07 at 11:35 -0400, Jason Baron wrote: > If nobody else thinks this patch is better, let's at least add a comment in > __dev_printk() and __netdev_printk() to fix dynamic debug, if these are > changed. Or maybe make dynamic_emit_prefix a public function and move the __dynamic__prin

Re: [PATCH/RFC] um: Preinclude include/linux/kern_levels.h

On Sun, 2012-09-09 at 10:33 +0200, Geert Uytterhoeven wrote: > Ping? Richard? Are you going to pick up this patch? It seems sensible. Geert, I suggest sending it directly to Linus as a fix if Richard doesn't respond in a few days. > On Thu, Aug 16, 2012 at 8:15 PM, Geert Uytterhoeven > wrote:

<    1   2   3   4   5   6   7   8   9   10   >