On Mon, 2012-11-26 at 06:37 -0800, Jacob Pan wrote:
> Intel PowerClamp driver performs synchronized idle injection across
> all online CPUs. The goal is to maintain a given package level C-state
> ratio.
trivial notes:
> diff --git a/drivers/thermal/intel_powerclamp.c
> b/drivers/thermal/intel_p
On Wed, 2012-11-28 at 12:10 +0100, Thierry Reding wrote:
> Add myself as the maintainer of the NVIDIA Tegra DRM driver.
> diff --git a/MAINTAINERS b/MAINTAINERS
[]
> @@ -2504,6 +2504,14 @@ S: Supported
> F: drivers/gpu/drm/exynos
> F: include/drm/exynos*
>
> +NVIDIA TEGRA DRM DRIVER
A
On Wed, 2012-11-28 at 16:06 -0300, Ezequiel Garcia wrote:
> On Tue, Oct 23, 2012 at 4:57 PM, Ezequiel Garcia
> wrote:
> > This is a large patchset that replaces struct memcpy with struct assignment,
> > whenever possible at drivers/media.
[]
> > A simplified version of the semantic match that fin
Signed-off-by: Joe Perches
---
MAINTAINERS |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index afc0b27..255dafb 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7658,6 +7658,7 @@ K:^Subject:.*(?i)trivial
TTY LAYER
M: Greg Kroah
Joe Perches (3):
cifs: Remove unused cEVENT macro
cifs: Make CIFS_DEBUG possible to undefine
cifs: Enable Kconfig control of CIFS_DEBUG
fs/cifs/Kconfig | 10 ++-
fs/cifs/cifs_debug.h | 74 +
2 files changed, 53 insertions(+), 31
It uses an undefined KERN_EVENT and is itself unused.
Signed-off-by: Joe Perches
---
fs/cifs/cifs_debug.h |7 ---
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/fs/cifs/cifs_debug.h b/fs/cifs/cifs_debug.h
index c0c68bb..b0fc344 100644
--- a/fs/cifs/cifs_debug.h
+++ b/fs
Make the compilation work again when CIFS_DEBUG is not #define'd.
Add format and argument verification for the various macros when
CIFS_DEBUG is not #define'd.
Signed-off-by: Joe Perches
---
fs/cifs/cifs_debug.h | 64 --
1 files c
Rather than havign a permanently enabled #define, allow
control over it.
This can reduce the size of the module by ~100KB which
could be useful for embedded systems.
Signed-off-by: Joe Perches
---
fs/cifs/Kconfig | 10 +-
fs/cifs/cifs_debug.h |5 -
2 files changed, 13
spinlock_t should always be used.
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index e0a674f..f27b0b5 100755
--- a/scripts/checkpatch.pl
+++ b/scripts
On Thu, 2012-11-29 at 22:08 +0100, Peter Huewe wrote:
> Bool initializations should use true and false. Bool tests don't need
> comparisons
[]
> .v3 for this tiny patch... shame on me.
Don't be silly...
> diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
[]
> @@ -545,7 +545,7
On Mon, 2012-11-12 at 15:26 -0800, Andrew Morton wrote:
> On Mon, 12 Nov 2012 14:54:10 -0800
> Joe Perches wrote:
>
> > On Fri, 2012-11-02 at 06:49 -0700, Joe Perches wrote:
> > > On Wed, 2012-10-24 at 20:43 -0700, Joe Perches wrote:
> > > > Make printk a bi
On Thu, 2012-11-29 at 14:54 -0700, Lance Ortiz wrote:
> This patch will provide a more reliable and easy way for user-space
> applications to have access to AER logs rather than reading them from the
> message buffer. It also provides a way to notify user-space when an AER
> event occurs.
[]
> diff
On Thu, 2012-11-29 at 14:21 -0800, Andrew Morton wrote:
> On Thu, 29 Nov 2012 14:08:15 -0800
> Joe Perches wrote:
> > Well, it's getting to be too late for this series.
>
> Yeah sorry, stuff got in the way, then people patched printk.c.
No worries.
> > When would
On Thu, 2012-11-29 at 15:58 -0700, Lance Ortiz wrote:
> This patch will provide a more reliable and easy way for user-space
> applications to have access to AER logs rather than reading them from the
> message buffer. It also provides a way to notify user-space when an AER
> event occurs.
[]
> 0 f
On Mon, 2013-03-18 at 20:05 +0200, Silviu Popescu wrote:
> On Wed, Mar 13, 2013 at 11:31 AM, David Miller wrote:
> > From: Silviu-Mihai Popescu
> > Date: Tue, 12 Mar 2013 20:13:15 +0200
> >
> >> @@ -590,10 +590,7 @@ int __init bt_sysfs_init(void)
> >> bt_debugfs = debugfs_create_dir("blueto
On Mon, 2013-03-18 at 16:20 -0700, Davidlohr Bueso wrote:
> This provides nicer message output. Since it seems more appropriate
> for the nature of this module, also use KERN_INFO instead of other
> levels.
[]
> diff --git a/lib/rbtree_test.c b/lib/rbtree_test.c
[]
> @@ -153,7 +156,7 @@ static int
On Mon, 2013-03-18 at 16:47 -0700, Davidlohr Bueso wrote:
> On Mon, 2013-03-18 at 16:44 -0700, Joe Perches wrote:
> > On Mon, 2013-03-18 at 16:20 -0700, Davidlohr Bueso wrote:
> > > This provides nicer message output. Since it seems more appropriate
> > > for the natu
On Mon, 2013-03-18 at 13:59 -0700, Andrew Morton wrote:
> On Sat, 16 Mar 2013 17:54:47 + Al Viro wrote:
>
> > On Sat, Mar 16, 2013 at 06:50:44AM -0700, Joe Perches wrote:
> > > Instead of converting the 800 or so uses of seq_printf with
> > > a constant format
Add a check for seq_printf use with a constant format
without additional arguments. Suggest seq_puts instead.
Suggested-by: Bjorn Helgaas
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl | 16
1 file changed, 16 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts
On Tue, 2013-03-19 at 15:16 +0100, Sebastian Andrzej Siewior wrote:
> DEFINE_SRCU() and DEFINE_STATIC_SRCU() does the same thing except for
> the "static" attribute. This patch moves the common pieces into
> _DEFINE_SRCU() which is used by the the former macros either adding the
> static attribute
Source files shouldn't have the executable bit set.
Signed-off-by: Joe Perches
---
include/sound/max98090.h| 0
sound/soc/codecs/max98090.c | 0
sound/soc/codecs/max98090.h | 0
3 files changed, 0 insertions(+), 0 deletions(-)
diff --git a/include/sound/max98090.h b/include/sound/max
Text files shouldn't be executable.
Signed-off-by: Joe Perches
---
Documentation/devicetree/bindings/mfd/tps6507x.txt | 0
1 file changed, 0 insertions(+), 0 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/tps6507x.txt
b/Documentation/devicetree/bindings/mfd/tps6507x.tx
Complain about files with an executable bit set that are
not in a scripts/ directory and are not type
.pl, .py, .awk, or .sh
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
On Wed, 2013-03-20 at 10:57 +0100, Mark Brown wrote:
> On Tue, Mar 19, 2013 at 02:58:43PM -0700, Joe Perches wrote:
> > Source files shouldn't have the executable bit set.
>
> I've applied this but I'm fed up to the back teeth of having to hand
> edit trivial pa
On Wed, 2013-03-20 at 15:29 +, Al Viro wrote:
> On Wed, Mar 20, 2013 at 03:47:53PM +0300, Dan Carpenter wrote:
>
> > The original code here needs to broken up into functions so it isn't
> > squashed up against the 80 character limit.
>
> I'd say what needs to be done to the original code...
Add Al's comments in from https://lkml.org/lkml/2013/3/20/345
Signed-off-by: Joe Perches
---
diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle
index e00b8f0..c4ba183 100644
--- a/Documentation/CodingStyle
+++ b/Documentation/CodingStyle
@@ -836,6 +836,141 @@ next instructi
On Wed, 2013-03-20 at 17:36 +0100, Mark Brown wrote:
> On Wed, Mar 20, 2013 at 08:22:16AM -0700, Joe Perches wrote:
> > On Wed, 2013-03-20 at 10:57 +0100, Mark Brown wrote:
>
> > > I've applied this but I'm fed up to the back teeth of having to hand
> > > e
On Wed, 2013-03-20 at 16:52 +, Al Viro wrote:
> On Wed, Mar 20, 2013 at 09:26:54AM -0700, Joe Perches wrote:
> > Add Al's comments in from https://lkml.org/lkml/2013/3/20/345
>
> > +Tip 7:
> > +Code flow is down, not across...
>
> That one is a lovely
On Sat, 2013-02-02 at 16:30 -0300, Ezequiel Garcia wrote:
> ptr = kmalloc(sizeof(foo));
> if (!ptr) {
> pr_err("Cannot allocate memory for foo\n");
> return -ENOMEM;
> }
> His argue against it was that kmalloc already takes care of
> reporting/printking
> a good deal of interesting
Remove all the OOM messages that follow kernel alloc
failures as there is already a generic equivalent to
these messages in the mm subsystem.
Joe Perches (8):
caif: Remove unnecessary alloc/OOM messages
can: Remove unnecessary alloc/OOM messages
ethernet: Remove unnecessary alloc/OOM
alloc failures already get standardized OOM
messages and a dump_stack.
Signed-off-by: Joe Perches
---
drivers/net/caif/caif_shmcore.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/net/caif/caif_shmcore.c b/drivers/net/caif/caif_shmcore.c
index bc497d7..bce8bac 100644
--- a
alloc failures already get standardized OOM
messages and a dump_stack.
Signed-off-by: Joe Perches
---
drivers/net/can/sja1000/ems_pci.c| 1 -
drivers/net/can/sja1000/peak_pci.c | 5 +
drivers/net/can/sja1000/peak_pcmcia.c| 1 -
drivers/net/can/sja1000/plx_pci.c
alloc failures already get standardized OOM
messages and a dump_stack.
Signed-off-by: Joe Perches
---
drivers/net/usb/ax88172a.c | 6 ++
drivers/net/usb/hso.c| 25 +++--
drivers/net/usb/sierra_net.c | 10 +++---
drivers/net/usb/smsc75xx.c | 6
alloc failures already get standardized OOM
messages and a dump_stack.
Hoist assigns from if tests.
Signed-off-by: Joe Perches
---
drivers/net/wan/cosa.c| 9 -
drivers/net/wan/farsync.c | 6 ++
drivers/net/wan/hdlc.c| 9 -
drivers/net/wan/x25_asy.c | 1 -
4 files
alloc failures already get standardized OOM
messages and a dump_stack.
Convert kzalloc's with multiplies to kcalloc.
Remove now unused size variables.
Signed-off-by: Joe Perches
---
drivers/net/wimax/i2400m/rx.c| 16 +---
drivers/net/wimax/i2400m/usb-notif.c | 1 -
2
nges.
Signed-off-by: Joe Perches
---
drivers/net/wireless/airo_cs.c | 5 ++--
drivers/net/wireless/at76c50x-usb.c| 4 +---
.../net/wireless/ath/ath9k/dfs_pattern_detector.c | 6 ++---
drivers/net/wireless/atmel_cs.c| 5 ++--
drivers
alloc failures already get standardized OOM
messages and a dump_stack.
Signed-off-by: Joe Perches
---
drivers/net/hamradio/dmascc.c | 7 +--
drivers/net/phy/spi_ks8995.c | 4 +---
drivers/net/virtio_net.c | 4 +---
3 files changed, 3 insertions(+), 12 deletions(-)
diff --git a
to vzalloc.
Remove now unused size variables.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/atheros/atl1c/atl1c_main.c| 6 ++---
drivers/net/ethernet/atheros/atl1e/atl1e_main.c| 2 --
drivers/net/ethernet/broadcom/b44.c| 4 +---
drivers/net/ethernet/broadcom/bcm6
alloc failures already get standardized OOM
messages and a dump_stack.
Signed-off-by: Joe Perches
---
net/core/dev.c| 14 +-
net/core/netprio_cgroup.c | 4 +---
2 files changed, 6 insertions(+), 12 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index a87bc74
On Thu, 2013-02-07 at 13:13 -0700, Tim Gardner wrote:
> Dynamically allocate the probe response template which
> avoids potential stack corruption. Observed with smatch:
trivial:
> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/main.c
> b/drivers/net/wireless/brcm80211/brcmsmac/main.c
[]
>
alloc failures already get standardized OOM
messages and a dump_stack.
Signed-off-by: Joe Perches
---
drivers/net/wireless/mwl8k.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/mwl8k.c b/drivers/net/wireless/mwl8k.c
index 224cf91..e31f779 100644
--- a/drivers/net
alignment.
Signed-off-by: Joe Perches
---
Let me know if you want multiple small patches instead.
drivers/net/can/usb/ems_usb.c | 4 +-
drivers/net/ethernet/amd/pcnet32.c | 47 +++---
drivers/net/ethernet/freescale/gianfar.c | 25
On Fri, 2013-02-08 at 17:45 -0500, David Miller wrote:
> From: Joe Perches
> Date: Thu, 07 Feb 2013 13:46:27 -0800
> > alloc failures already get standardized OOM
> > messages and a dump_stack.
Does anyone know if all the other alloc's like
dma_alloc_coherent
On Fri, 2013-02-08 at 13:04 -0700, Stephen Warren wrote:
> (?http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Fri, 2013-02-08 at 17:47 -0700, Stephen Warren wrote:
> On 02/08/2013 05:40 PM, Joe Perches wrote:
> > On Fri, 2013-02-08 at 13:04 -0700, Stephen Warren wrote:
> >> (? >
> > This doesn't work well. It matches too many
> > words like integral.
>
>
On Fri, 2013-02-08 at 20:15 -0700, Stephen Warren wrote:
> Perhaps a custom almost-equivalent (?i)[^a-z]tegra would work?
I didn't notice false positives with that one.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
On Sun, 2013-02-10 at 23:00 +0100, Daniel Borkmann wrote:
> add memcmp_nta ({n}o {t}iming {a}ttacks)
Why should this be in the kernel?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://v
On Mon, 2013-02-11 at 13:33 +1100, Stephen Rothwell wrote:
> Hi John,
>
> Today's linux-next merge of the wireless-next tree got conflicts in
> drivers/net/wireless/ti/wlcore/sdio.c and
> drivers/net/wireless/ti/wlcore/spi.c between commit 0d2e7a5c6080
> ("wireless: Remove unnecessary alloc/OOM me
On Mon, 2013-02-11 at 10:02 +0200, Luciano Coelho wrote:
> In commit 0d2e7a5c (wireless: Remove unnecessary alloc/OOM messages,
> alloc cleanups) OOM messages after alloc were removed from the wlcore
> modules.
>
> Commit afb43e6d (wlcore: remove if_ops from platform_data)
> reintroduced a couple
rd is far simpler and more compact than listing
> all Tegra-related drivers, even if wildcards were used.
>
> Words such as integrate or integrator are common. Ensure the character
> right before "tegra" isn't a-z (case-insensitive), to make sure the
> keyword doesn&#
On Mon, 2013-02-11 at 11:01 -0700, Stephen Warren wrote:
> On 02/11/2013 10:56 AM, Joe Perches wrote:
> > On Mon, 2013-02-11 at 10:51 -0700, Stephen Warren wrote:
> >> From: Stephen Warren
> >>
> >> The intent is to ensure that all Tegra-related patches are s
On Mon, 2013-02-11 at 11:12 -0700, Stephen Warren wrote:
> On 02/11/2013 11:04 AM, Joe Perches wrote:
> > ./scripts/get_maintainer.pl -f arch/arm/mach-tegra
> > wouldn't match anything.
>
> That's annoying; it kinda defeats the whole purpose of this patch then.
&g
On Mon, 2013-02-11 at 10:19 -0800, Joe Perches wrote:
> On Mon, 2013-02-11 at 11:12 -0700, Stephen Warren wrote:
> > On 02/11/2013 11:04 AM, Joe Perches wrote:
> > > ./scripts/get_maintainer.pl -f arch/arm/mach-tegra
> > > wouldn't match anything.
> >
>
alloc failures already get standardized OOM
messages and a dump_stack.
Signed-off-by: Joe Perches
---
drivers/staging/media/as102/as102_usb_drv.c | 4 +---
drivers/staging/media/go7007/go7007-fw.c| 24 +++-
drivers/staging/media/go7007/s2250-loader.c | 5 ++---
drivers
Lindent had its last good day more than a decade ago.
Time to put it down.
Remove suggestions to use it too.
Signed-off-by: Joe Perches
---
Documentation/CodingStyle | 15 ---
Documentation/hwmon/submitting-patches | 5 -
scripts/Lindent
On Mon, 2013-02-11 at 16:40 -0700, Stephen Warren wrote:
> From: Stephen Warren
>
> Allow K: entries in MAINTAINERS to match directly against filenames;
> either those extracted from patch +++ or --- lines, or those specified
> on the command-line using the -f option.
[]
> I don't think setting e
On Mon, 2013-02-11 at 16:40 -0700, Stephen Warren wrote:
> From: Stephen Warren
>
> The intent is to ensure that all Tegra-related patches are sent to the
> linux-tegra@ mailing list, so people can keep up-to-date on all misc
> driver changes.
>
> Doing this with a keyword is far simpler and mor
On Mon, 2013-02-11 at 17:08 -0700, Stephen Warren wrote:
> Does "that" above mean "not setting exact_pattern_match_hash", or
> "changing the patch so that it does set exact_pattern_match_hash". Sorry...
I think what you have is fine.
--
To unsubscribe from this list: send the line "unsubscribe l
On Mon, 2013-02-11 at 17:39 -0700, Stephen Warren wrote:
> From: Stephen Warren
>
> Allow K: entries in MAINTAINERS to match directly against filenames;
> either those extracted from patch +++ or --- lines, or those specified
> on the command-line using the -f option.
[]
> diff --git a/MAINTAINER
On Tue, 2013-02-12 at 11:17 -0700, Stephen Warren wrote:
> On 02/11/2013 11:17 PM, Joe Perches wrote:
> > If the -f pattern is a single file,
> > get_maintainer reads that file content and then
> > matches any K: patterns.
> >
> > When the -f pattern is a directo
His email bounces and he hasn't done work on
these sections in a couple of years.
Signed-off-by: Joe Perches
---
MAINTAINERS | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 1d0651e..8d47b3a 100644
--- a/MAINTAINERS
+++ b/MAINTA
Jerod? Remove you from MAINTAINERS or not?
Your wilsonet address is bouncing.
https://lkml.org/lkml/2013/2/12/531
cheers, Joe
Forwarded Message
From: Hans de Goede
To: Joe Perches
Subject: Re: [PATCH] MAINTAINERS: Remove Jarod Wilson and orphan LIRC
drivers
Hi
On 02/12
On Tue, 2013-04-02 at 15:15 -0700, Jacob Pan wrote:
> RAPL(Running Average Power Limit) interface provides platform software
> with the ability to monitor, control, and get notifications on SOC
> power consumptions. Since its first appearance on Sandy Bridge, more
> features have being added to ext
On Fri, 2013-04-05 at 18:31 +0200, Paul Bolle wrote:
> There's no Kconfig symbol NFC_DEBUG. Besides, there doesn't seem to be
> any nfc code that uses a DEBUG macro. This line can safely be removed.
[]
> diff --git a/drivers/nfc/Makefile b/drivers/nfc/Makefile
[]
> -ccflags-$(CONFIG_NFC_DEBUG) := -
On Fri, 2013-04-05 at 18:39 +0200, Paul Bolle wrote:
> On Fri, 2013-04-05 at 09:35 -0700, Joe Perches wrote:
> > On Fri, 2013-04-05 at 18:31 +0200, Paul Bolle wrote:
> > > -ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG
> >
> > pr_debug/dev_dbg/nfc_dev_dbg logging messages
&
Fix some defects in the logging too
Joe Perches (3):
nfc: Replace nfc_dev_dbg with dev_dbg, remove function tracing
nfc: Convert nfc_dev_info and nfc_dev_err to nfc_
nfc: Standardize logging style
drivers/nfc/microread/i2c.c | 32 ++---
drivers/nfc/microread/mei.c | 20
Use the generic kernel function instead of a home-grown
one that does the same thing. Remove empty function
tracing style uses as the kernel function tracer does
that too.
Add \n to uses not at the macro. Don't add \n where
the nfc_dev_dbg macro mistakenly had them already.
Signed-off-by
Use a more standard kernel style macro logging name.
Standardize the spacing of the "NFC: " prefix.
Add \n to uses, remove from macro.
Fix the defective uses that already had a \n.
Signed-off-by: Joe Perches
---
drivers/nfc/nfcwilink.c | 44 +++---
drivers/nfc/pn533.c
Use standardized styles to minimize coding defects.
Always use nfc_ where feasible.
Add \n to formats where appropriate.
Tyop "it it" correction.
Add #define pr_fmt where appropriate.
Remove function tracing logging messages.
Remove OOM messages.
Signed-off-by: Joe Perches
---
d
On Fri, 2013-04-05 at 14:02 -0700, Jacob Pan wrote:
> RAPL(Running Average Power Limit) interface provides platform software
> with the ability to monitor, control, and get notifications on SOC
> power consumptions. Since its first appearance on Sandy Bridge, more
> features have being added to ext
On Tue, 2013-01-29 at 10:55 -0500, valdis.kletni...@vt.edu wrote:
> On Sun, 27 Jan 2013 23:19:47 +0300, Dan Carpenter said:
>
> > Yeah. I think it would be, but adding bitflags together instead of
> > doing bitwise ORs is very common as well.
>
> The fact it's common doesn't mean it's good progr
On Tue, 2013-01-29 at 17:19 +0100, Julia Lawall wrote:
> > On Tue, 2013-01-29 at 10:55 -0500, valdis.kletni...@vt.edu wrote:
[]
> > > I wonder if there's a way to write a coccinelle patch to find places
> > > where we do arithmetic operations on bitmasks
[]
> If the definition of a bitmask is a
On Tue, 2013-01-29 at 18:49 +0100, Julia Lawall wrote:
> How about the following (from today's linux-next). They appear to be
> trying to do the same calculation, once with + and once with |.
(cc'ing the original developer and Russell King)
Likely the it8152_pci_platform_notify uses should use +
On Tue, 2013-01-29 at 15:40 -0600, Seth Jennings wrote:
> The code required for the flushing is in a separate patch now
> as requested.
What tree does this apply to?
Both -next and linus fail to compile.
There's a whitespace error applying 3/7 (line 543 in zswap.c)
and on 3.8-rc5 (allyesconfig x8
On Wed, 2013-01-30 at 00:41 +0100, Peter Hüwe wrote:
> ---> is there a way to consolidate these functions into one function (which
> can operate on the different types) ? It's almost a bit like 'templates'.
> Maybe with some gcc extensions or kernel magic functions ?
Nothing wrong with a macro.
On Wed, 2013-01-30 at 09:21 +0100, walter harms wrote:
> Am 29.01.2013 19:03, schrieb Joe Perches:
> > On Tue, 2013-01-29 at 18:49 +0100, Julia Lawall wrote:
> >> How about the following (from today's linux-next). They appear to be
> >> trying to do the same calcul
On Wed, 2013-01-30 at 11:35 +, Russell King - ARM Linux wrote:
> On Wed, Jan 30, 2013 at 12:21:21PM +0100, Julia Lawall wrote:
> > On Wed, 30 Jan 2013, Russell King - ARM Linux wrote:
> > > So, _either_ logical OR or addition works.
> > >
> > > If we _did_ end up with a PHYS_OFFSET with bits le
On Wed, 2013-01-30 at 11:15 -0800, Bruce Allan wrote:
> Do not test udelay() for a value less than 10usec when passed a variable
> instead of a hard-coded number;
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3237,9 +3237,9 @@ sub process {
[]
> # prefer usleep_range ove
On Fri, 2013-02-01 at 11:07 +0800, Ming Lei wrote:
> Currently, sizeof(struct parsed_partitions) may be 64KB in 32bit arch,
> so it is easy to trigger page allocation failure by check_partition,
[]
> This patch does below optimizations on the allocation of struct
> parsed_partitions to try to addre
On Fri, 2013-02-01 at 16:43 +0100, Greg Kroah-Hartman wrote:
> From: Greg Kroah-Hartman
>
> Maintainers have to hand-edit patches (body of patches and changelog
> entries) all the time. There needs to be some kind of penalty put into
> place to keep developers from abusing maintainers.
No, ther
On Fri, 2013-02-01 at 12:34 -0500, Chris Metcalf wrote:
> Using pr_info in a header exposes us to potential trouble from
> subsystems that define pr_fmt. This change fixes:
>
> In file included from include/linux/scatterlist.h:10,
>from include/scsi/scsi.h:12,
>
On Fri, 2013-01-25 at 10:09 +0100, Takashi Iwai wrote:
> At Fri, 25 Jan 2013 00:38:06 +0200,
> Stratos Karafotis wrote:
> > Fix the following build warnings
> > sound/pci/hda/patch_sigmatel.c: In function ‘stac92hd71bxx_fixup_hp’:
> > sound/pci/hda/patch_sigmatel.c:2434:24: warning: unused variable
sing match variables in $Float.
Avoid using match variables in $Assignment too.
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 9de3a69..3d0f577 100755
--- a/scripts/che
On Sat, 2013-01-26 at 01:45 +0100, Frederic Weisbecker wrote:
> > diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c
[]
> > @@ -282,7 +282,7 @@ static __always_inline bool
> > steal_account_process_tick(void)
[]
> > - return st;
> > + return !!st;
>
> I would
First number, then size.
Signed-off-by: Joe Perches
---
drivers/edac/edac_mc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/edac/edac_mc.c b/drivers/edac/edac_mc.c
index a641f62..fb219bc 100644
--- a/drivers/edac/edac_mc.c
+++ b/drivers/edac/edac_mc.c
First number, then size.
Signed-off-by: Joe Perches
---
include/net/gro_cells.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/net/gro_cells.h b/include/net/gro_cells.h
index e5062c9..734d9b5 100644
--- a/include/net/gro_cells.h
+++ b/include/net/gro_cells.h
kcalloc is sometimes misused with the
first and second arguments switched.
Same issue with kmalloc_array too.
Bleat if sizeof is the first argument
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl | 6 ++
1 file changed, 6 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts
On Sun, 2013-01-27 at 03:35 -0800, Jeff Kirsher wrote:
> This patch reverts a portion of the commit to allow multi-line code
> comments to use either style.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -1878,13 +1878,6 @@ sub process {
> }
>
>
On Sun, 2013-01-27 at 22:40 +0300, Dan Carpenter wrote:
> There is a kind of precedence problem here, but it doesn't affect how
> the code works because ->serial_signals is unsigned char. We want to
> clear two flags here.
>
> #define SerialSignal_RTS0x20 /* Request to Send */
> #
On Sun, 2013-01-27 at 23:19 +0300, Dan Carpenter wrote:
> On Sun, Jan 27, 2013 at 12:04:38PM -0800, Joe Perches wrote:
> > Wouldn't it be clearer still to use | instead of +
> Yeah. I think it would be, but adding bitflags together instead of
> doing bitwise ORs is
e bit operations.
Reorder the multiple fields for consistency.
Update the comments too.
cc: Dan Carpenter
Signed-off-by: Joe Perches
---
drivers/char/pcmcia/synclink_cs.c | 26 -
drivers/tty/synclink.c| 26 -
drivers/
On Mon, 2013-01-28 at 17:17 +, Allan, Bruce W wrote:
> David Miller Sent: Sunday, January 27, 2013 7:07 PM
> > From: Jeff Kirsher
> > > So will you be fine with cleanup patches which go through and
> > > convert all the existing code comments to the desired format?
> > Sure.
> Not all Intel dr
On Mon, 2013-02-25 at 12:58 -0600, Philip J. Kelleher wrote:
> From: Philip J Kelleher
>
> This patch includes changing the hardware branding name from
> IBM RamSan to IBM FlashSystem.
just a trivial comment
> diff -uprN -X linux-block-vanilla/Documentation/dontdiff
> linux-block-vanilla/drive
On Tue, 2013-02-26 at 13:30 +0800, Zhang Yanfei wrote:
> This is just a tweak: using min_t to simplify logic of variable
> assignments.
>
> v3:
> - cast type of (PAGE_SIZE - (maddr & ~PAGE_MASK)) into size_t.
Why? Isn't this just a redundant cast?
> diff --git a/kernel/kexec.c b/kernel/kexec.c
On Tue, 2013-02-26 at 10:23 -0800, Guenter Roeck wrote:
> diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775.c
[]
> +static const u16 NCT6779_REG_TEMP_CONFIG[11] = { 0x18, 0x152 };
Isn't 11 too magic a number?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" i
On Tue, 2013-02-26 at 22:10 +, Russell King - ARM Linux wrote:
> So... for a selected kernel version of a particular size, can we please
> have a comparison between the new LZO code and this LZ4 code, so that
> we can see whether it's worth updating the LZO code or replacing the
> LZO code with
On Wed, 2013-02-27 at 09:56 +, Russell King - ARM Linux wrote:
> On Tue, Feb 26, 2013 at 05:40:34PM -0800, Joe Perches wrote:
> > On Tue, 2013-02-26 at 22:10 +, Russell King - ARM Linux wrote:
> > > So... for a selected kernel version of a particular size, can we p
On Wed, 2013-02-27 at 16:31 +, Russell King - ARM Linux wrote:
> On Wed, Feb 27, 2013 at 07:49:12AM -0800, Joe Perches wrote:
> > On Wed, 2013-02-27 at 09:56 +, Russell King - ARM Linux wrote:
> > > On Tue, Feb 26, 2013 at 05:40:34PM -0800, Joe Perches wrote:
> > &
On Wed, 2013-02-27 at 12:16 -0500, Nicolas Pitre wrote:
> On Wed, 27 Feb 2013, Joe Perches wrote:
> > On Wed, 2013-02-27 at 16:31 +, Russell King - ARM Linux wrote:
> > > On Wed, Feb 27, 2013 at 07:49:12AM -0800, Joe Perches wrote:
> > > > On Wed, 2013-02-27 at 0
(removed Richard Purdie and Albin Tonnerre as their email addresses
seem to be bounding)
> While recently asking someone to enable VFP debugging, so I could help
> sort out a problem they had reported, this is the debug output I was
> greeted by thanks to your meddling:
:) Meddling... You sound
1 - 100 of 10413 matches
Mail list logo
