Convert the adc bindings from .txt to .yaml format.
Signed-off-by: Jishnu Prakash
Reviewed-by: Amit Kucheria
Reviewed-by: Rob Herring
Acked-by: Linus Walleij
---
.../devicetree/bindings/iio/adc/qcom,spmi-vadc.txt | 173 --
.../bindings/iio/adc/qcom,spmi-vadc.yaml | 252
The following changes are made in V7:
In the seventh patch, the function pointer is defined using typedef
instead of struct, to address a review comment.
There are no changes in any other patches, from V6.
Jishnu Prakash (7):
iio: adc: Convert the QCOM SPMI ADC bindings to .yaml format
iio
Add info property under adc_data to support adding ADC variants
which may use different iio_info than the one defined for PMIC5.
Signed-off-by: Jishnu Prakash
---
drivers/iio/adc/qcom-spmi-adc5.c | 4 +++-
drivers/iio/adc/qcom-vadc-common.h | 1 +
2 files changed, 4 insertions(+), 1 deletion
of ADC channel number and PMIC SID number)
per PMIC, to be used by ADC clients for PMIC7.
Signed-off-by: Jishnu Prakash
Reviewed-by: Amit Kucheria
Reviewed-by: Rob Herring
---
.../bindings/iio/adc/qcom,spmi-vadc.yaml | 38 --
include/dt-bindings/iio/qcom,spmi-adc7-pm8350.h
Add a common function used for read_raw callback for both PMIC5
and PMIC7 ADCs.
Signed-off-by: Jishnu Prakash
---
drivers/iio/adc/qcom-spmi-adc5.c | 49
1 file changed, 19 insertions(+), 30 deletions(-)
diff --git a/drivers/iio/adc/qcom-spmi-adc5.c b
Clean up some return value checks to make code more compact.
Signed-off-by: Jishnu Prakash
---
drivers/iio/adc/qcom-spmi-adc5.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/iio/adc/qcom-spmi-adc5.c b/drivers/iio/adc/qcom-spmi-adc5.c
index dcc7599
Change pr_err/pr_debug statements to dev_err/dev_dbg for
increased clarity.
Signed-off-by: Jishnu Prakash
Reviewed-by: Andy Shevchenko
---
drivers/iio/adc/qcom-spmi-adc5.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/iio/adc/qcom-spmi-adc5.c b
which the PBS needs to communicate. Add support for the same.
Signed-off-by: Jishnu Prakash
Reviewed-by: Andy Shevchenko
---
drivers/iio/adc/qcom-spmi-adc5.c | 215 +-
drivers/iio/adc/qcom-vadc-common.c | 262 +
drivers/iio/adc/qcom
Add ADC_TM peripheral definitions for PM6150 and PM6150L. Add
ADC peripheral definition for PM6150l, which is needed for ADC_TM.
Signed-off-by: Jishnu Prakash
---
arch/arm64/boot/dts/qcom/pm6150.dtsi | 10 ++
arch/arm64/boot/dts/qcom/pm6150l.dtsi | 24
2 files
series
and verified to work on SC7180.
Jishnu Prakash (1):
arm64: dts: qcom: pm6150x: add ADC_TM definitions
arch/arm64/boot/dts/qcom/pm6150.dtsi | 10 ++
arch/arm64/boot/dts/qcom/pm6150l.dtsi | 24
2 files changed, 34 insertions(+)
--
The Qualcomm Innovat
Hi Andy,
On 5/22/2020 9:07 PM, Andy Shevchenko wrote:
On Fri, May 22, 2020 at 5:25 PM Jishnu Prakash wrote:
The ADC architecture on PMIC7 is changed as compared to PMIC5. The
major change from PMIC5 is that all SW communication to ADC goes through
PMK8350, which communicates with other PMICs
Hi Jonathan,
On 5/24/2020 5:29 PM, Jonathan Cameron wrote:
On Fri, 22 May 2020 19:54:10 +0530
Jishnu Prakash wrote:
The ADC architecture on PMIC7 is changed as compared to PMIC5. The
major change from PMIC5 is that all SW communication to ADC goes through
PMK8350, which communicates with
Hi Andy,
On 5/22/2020 9:11 PM, Andy Shevchenko wrote:
On Fri, May 22, 2020 at 5:25 PM Jishnu Prakash wrote:
This commit includes the following changes:
Add a common function used for read_raw callback for both PMIC5
and PMIC7 ADCs.
Add exit function for ADC.
Add info_property under
Hi Jonathan,
On 5/24/2020 5:34 PM, Jonathan Cameron wrote:
On Fri, 22 May 2020 19:54:12 +0530
Jishnu Prakash wrote:
This commit includes the following changes:
Add a common function used for read_raw callback for both PMIC5
and PMIC7 ADCs.
Add exit function for ADC.
Hi Jishnu,
I don
is to add a common function used for read_raw callback
for both PMIC5 and PMIC7 ADC. Its the same change included in fifth
patch of V5, except that ADC exit function is removed and info change
is split out to third patch now.
Jishnu Prakash (7):
iio: adc: Convert the QCOM SPMI ADC bindings to
Convert the adc bindings from .txt to .yaml format.
Signed-off-by: Jishnu Prakash
Reviewed-by: Amit Kucheria
Reviewed-by: Rob Herring
Acked-by: Linus Walleij
---
.../devicetree/bindings/iio/adc/qcom,spmi-vadc.txt | 173 --
.../bindings/iio/adc/qcom,spmi-vadc.yaml | 252
Clean up some return value checks to make code more compact.
Signed-off-by: Jishnu Prakash
---
drivers/iio/adc/qcom-spmi-adc5.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/iio/adc/qcom-spmi-adc5.c b/drivers/iio/adc/qcom-spmi-adc5.c
index dcc7599
which the PBS needs to communicate. Add support for the same.
Signed-off-by: Jishnu Prakash
Reviewed-by: Andy Shevchenko
---
drivers/iio/adc/qcom-spmi-adc5.c | 215 +-
drivers/iio/adc/qcom-vadc-common.c | 262 +
drivers/iio/adc/qcom
Change pr_err/pr_debug statements to dev_err/dev_dbg for
increased clarity.
Signed-off-by: Jishnu Prakash
Reviewed-by: Andy Shevchenko
---
drivers/iio/adc/qcom-spmi-adc5.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/iio/adc/qcom-spmi-adc5.c b
Add info property under adc_data to support adding ADC variants
which may use different iio_info than the one defined for PMIC5.
Signed-off-by: Jishnu Prakash
---
drivers/iio/adc/qcom-spmi-adc5.c | 4 +++-
drivers/iio/adc/qcom-vadc-common.h | 1 +
2 files changed, 4 insertions(+), 1 deletion
of ADC channel number and PMIC SID number)
per PMIC, to be used by ADC clients for PMIC7.
Signed-off-by: Jishnu Prakash
Reviewed-by: Amit Kucheria
Reviewed-by: Rob Herring
---
.../bindings/iio/adc/qcom,spmi-vadc.yaml | 38 --
include/dt-bindings/iio/qcom,spmi-adc7-pm8350.h
Add a common function used for read_raw callback for both PMIC5
and PMIC7 ADCs.
Signed-off-by: Jishnu Prakash
---
drivers/iio/adc/qcom-spmi-adc5.c | 53 +++-
1 file changed, 25 insertions(+), 28 deletions(-)
diff --git a/drivers/iio/adc/qcom-spmi-adc5.c b
Hi Andy,
On 4/27/2020 6:58 PM, Andy Shevchenko wrote:
On Mon, Apr 27, 2020 at 3:56 PM Jishnu Prakash wrote:
On 4/17/2020 3:51 PM, Andy Shevchenko wrote:
On Thu, Apr 16, 2020 at 1:48 AM Jishnu Prakash wrote:
Stop using HTML. It breaks badly the reply and discussion.
...
+static const
Hi Amit,
On 5/5/2020 3:33 PM, Amit Kucheria wrote:
Hi Jishnu,
It is nice to cc a reviewer from a previous version. Just saw this.
On Mon, Apr 27, 2020 at 6:55 PM Jishnu Prakash wrote:
The ADC architecture on PMIC7 is changed as compared to PMIC5. The
major change from PMIC5 is that all SW
The following changes are made in V4:
Made some recommended minor changes in the third patch. Removed
the info member from adc5_data, and adc exit function, to be
added back in fifth patch.
Added a fifth patch to clean up code common to PMIC5 and PMIC7 ADC.
Jishnu Prakash (5):
iio: adc
Convert the adc bindings from .txt to .yaml format.
Signed-off-by: Jishnu Prakash
Reviewed-by: Amit Kucheria
Reviewed-by: Rob Herring
---
.../devicetree/bindings/iio/adc/qcom,spmi-vadc.txt | 173 --
.../bindings/iio/adc/qcom,spmi-vadc.yaml | 252 +
2
which the PBS needs to communicate. Add support for the same.
Signed-off-by: Jishnu Prakash
---
drivers/iio/adc/qcom-spmi-adc5.c | 225 +++-
drivers/iio/adc/qcom-vadc-common.c | 260 +
drivers/iio/adc/qcom-vadc-common.h | 14 ++
3
Change pr_err/pr_debug statements to dev_err/dev_dbg for
increased clarity. Also clean up some return value checks.
Signed-off-by: Jishnu Prakash
---
drivers/iio/adc/qcom-spmi-adc5.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/iio
This commit includes the following changes:
Add a common function used for read_raw callback for
both PMIC5 and PMIC7 ADCs.
Add exit function for ADC.
Add info_property under adc_data to more efficiently
distinguish PMIC5 and PMIC7 ADCs.
Signed-off-by: Jishnu Prakash
---
drivers/iio/adc/qcom
of ADC channel number and PMIC SID number)
per PMIC, to be used by ADC clients for PMIC7.
Signed-off-by: Jishnu Prakash
Reviewed-by: Amit Kucheria
Reviewed-by: Rob Herring
---
.../bindings/iio/adc/qcom,spmi-vadc.yaml | 38 --
include/dt-bindings/iio/qcom,spmi-adc7-pm8350.h
Hi Andy,
On 5/13/2020 3:18 PM, Andy Shevchenko wrote:
On Wed, May 13, 2020 at 12:23 PM Jishnu Prakash wrote:
The ADC architecture on PMIC7 is changed as compared to PMIC5. The
major change from PMIC5 is that all SW communication to ADC goes through
PMK8350, which communicates with other PMICs
Hi Andy,
On 5/13/2020 3:21 PM, Andy Shevchenko wrote:
On Wed, May 13, 2020 at 12:24 PM Jishnu Prakash wrote:
This commit includes the following changes:
Add a common function used for read_raw callback for
both PMIC5 and PMIC7 ADCs.
Add exit function for ADC.
Add info_property under adc_data
Hi Andy,
On 5/13/2020 3:19 PM, Andy Shevchenko wrote:
On Wed, May 13, 2020 at 12:23 PM Jishnu Prakash wrote:
Change pr_err/pr_debug statements to dev_err/dev_dbg for
increased clarity. Also clean up some return value checks.
'Also' on the commit message == 'split this to tw
The following changes are made in V5:
Made some recommended minor changes in the third patch and
accordingly moved some return value check corrections From
fourth patch to third.
Cleaned up commit message of fifth patch.
Jishnu Prakash (5):
iio: adc: Convert the QCOM SPMI ADC bindings to
which the PBS needs to communicate. Add support for the same.
Signed-off-by: Jishnu Prakash
---
drivers/iio/adc/qcom-spmi-adc5.c | 231 ++--
drivers/iio/adc/qcom-vadc-common.c | 260 +
drivers/iio/adc/qcom-vadc-common.h | 14 ++
3
of ADC channel number and PMIC SID number)
per PMIC, to be used by ADC clients for PMIC7.
Signed-off-by: Jishnu Prakash
Reviewed-by: Amit Kucheria
Reviewed-by: Rob Herring
---
.../bindings/iio/adc/qcom,spmi-vadc.yaml | 38 --
include/dt-bindings/iio/qcom,spmi-adc7-pm8350.h
Convert the adc bindings from .txt to .yaml format.
Signed-off-by: Jishnu Prakash
Reviewed-by: Amit Kucheria
Reviewed-by: Rob Herring
Acked-by: Linus Walleij
---
.../devicetree/bindings/iio/adc/qcom,spmi-vadc.txt | 173 --
.../bindings/iio/adc/qcom,spmi-vadc.yaml | 252
Change pr_err/pr_debug statements to dev_err/dev_dbg for
increased clarity.
Signed-off-by: Jishnu Prakash
---
drivers/iio/adc/qcom-spmi-adc5.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/iio/adc/qcom-spmi-adc5.c b/drivers/iio/adc/qcom-spmi-adc5
This commit includes the following changes:
Add a common function used for read_raw callback for both PMIC5
and PMIC7 ADCs.
Add exit function for ADC.
Add info_property under adc_data to more efficiently distinguish
PMIC5 and PMIC7 ADCs.
Signed-off-by: Jishnu Prakash
---
drivers/iio/adc/qcom
39 matches
Mail list logo