Re: [PATCHv3] tty: Added a CONFIG_TTY option to allow removal of TTY

2012-11-26 Thread Jiri Slaby
On 11/27/2012 12:38 AM, Greg Kroah-Hartman wrote: > Can you rediff this once 3.8-rc1 is out and send it to me then? So if you are going to respin, please take care of the newly added drivers like drivers/staging/fwserial. thanks, -- js -- To unsubscribe from this list: send the line "unsubscribe

kernel BUG at mm/huge_memory.c:212!

2012-11-27 Thread Jiri Slaby
Hi, I've hit BUG_ON(atomic_dec_and_test(&huge_zero_refcount)) in put_huge_zero_page right now. There are some "Bad rss-counter state" before that, but those are perhaps unrelated as I saw many of them in the previous -next. But even with yesterday's next I got the BUG. [ 7395.654928] BUG: Bad rss

"tuntap: multiqueue support" causes udev fork bombs

2012-11-28 Thread Jiri Slaby
Hi, with this commit: commit c8d68e6be1c3b242f1c598595830890b65cea64a Author: Jason Wang Date: Wed Oct 31 19:46:00 2012 + tuntap: multiqueue support I see fork bombs from udev. It is trying to create 2048 processes. 1024 for tx, 1024 for rx. OOM killer indeed steps in and kills every

Re: kswapd craziness in 3.7

2012-11-28 Thread Jiri Slaby
On 11/28/2012 02:35 PM, Zdenek Kabelac wrote: > and added slightly modified patch from Jiri > (https://lkml.org/lkml/2012/11/15/950 > (Unsure where it still applies for -rc7??) It is needed for -next only. And if you have recent -next, it's already there... thanks, -- js suse labs -- To unsubscr

Re: [PATCH] MAINTAINERS: TTY - Add linux-serial mailing list

2012-11-29 Thread Jiri Slaby
S > @@ -7658,6 +7658,7 @@ K: ^Subject:.*(?i)trivial > TTY LAYER > M: Greg Kroah-Hartman > M: Jiri Slaby > +L: linux-ser...@vger.kernel.org This might have the effect that people will try to reach us at that list. But this is not true at least for me. serial != tty.

Re: e1000e + suspend, 3.9-rc2

2013-03-19 Thread Jiri Slaby
On 03/12/2013 06:17 PM, Borislav Petkov wrote: > On Mon, Mar 11, 2013 at 09:25:37PM +0100, Borislav Petkov wrote: >> Yeah, it is already upstream. And yeah, it did trigger with it. >> >> $ git describe >> v3.9-rc2-112-g7c6baa304b84 >> >> But it somehow doesn't trigger with that same kernel anymore

Re: e1000e + suspend, 3.9-rc2

2013-03-19 Thread Jiri Slaby
On 03/19/2013 11:27 AM, Konstantin Khlebnikov wrote: > Jiri Slaby wrote: >> On 03/12/2013 06:17 PM, Borislav Petkov wrote: >>> On Mon, Mar 11, 2013 at 09:25:37PM +0100, Borislav Petkov wrote: >>>> Yeah, it is already upstream. And yeah, it did trigger with it. >

Re: linux-next: build failure after merge of the tty tree

2013-03-20 Thread Jiri Slaby
Hi, On 03/20/2013 04:12 AM, Stephen Rothwell wrote: > drivers/net/caif/caif_serial.c: In function 'update_tty_status': > drivers/net/caif/caif_serial.c:94:11: error: 'struct tty_struct' > has no member named 'warned' > > Caused by commit 6865ff222cca ("TTY: do not warn about setting > speed via

Re: kswapd craziness round 2

2013-03-20 Thread Jiri Slaby
On 03/20/2013 05:12 AM, Hillf Danton wrote: > Hey, would you all please try Mels new work? > http://marc.info/?l=linux-mm&m=136352546814642&w=4 Yeah, I was in CC and also asked Mel if I should apply those. I will as soon as I'm back home (next week). thanks, -- js suse labs -- To unsubscribe fro

Re: linux-next: build failure after merge of the tty tree

2013-03-20 Thread Jiri Slaby
On 03/20/2013 01:51 PM, Bill Pemberton wrote: > Jiri Slaby writes: >> >>> drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb': >>> drivers/usb/serial/quatech2.c:661:18: error: 'struct >>> qt2_port_private' has no member n

Re: linux-next: build failure after merge of the tty tree

2013-03-20 Thread Jiri Slaby
On 03/20/2013 03:42 PM, Bill Pemberton wrote: > Ok, for the unopened ports there *should* never be any actual data to > push so the push is really doing nothing anyhow in these cases. It's > coming from the device sending an initial change port command. > > Anyhow, so my patch adding more is_open

Re: Uhhuh. NMI received for unknown reason 2c on CPU 0.

2013-02-03 Thread Jiri Slaby
On 01/31/2013 02:18 PM, Borislav Petkov wrote: > On Thu, Jan 31, 2013 at 09:28:12AM +0100, Jiri Slaby wrote: >> And, does it happen if you switch all of them but NMI wtd in there? > > No, but something else happens. Here's the whole dance: > > 1. Switch all tunables e

Re: [PATCH] TTY: do not reset master's packet mode

2013-02-04 Thread Jiri Slaby
On 02/01/2013 06:59 PM, Josh Boyer wrote: > On Tue, Jan 15, 2013 at 5:26 PM, Jiri Slaby wrote: >> Now that login from util-linux is forced to drop all references to a >> TTY which it wants to hangup (to reach reference count 1) we are >> seeing issues with telnet. When

Re: [PATCH 07/10] TTY: switch tty_schedule_flip

2013-02-05 Thread Jiri Slaby
On 02/01/2013 09:39 PM, Peter Hurley wrote: > On Fri, 2013-02-01 at 16:06 +0100, Jiri Slaby wrote: >> On 02/01/2013 01:37 PM, Peter Hurley wrote: >>> On Thu, 2013-01-03 at 15:53 +0100, Jiri Slaby wrote: >>>> Now, we start converting tty buffer functions to actuall

Re: [PATCH 0/2] tty: metag_da: fix flipping after tty changes

2013-02-05 Thread Jiri Slaby
s? > > James Hogan (2): > tty: metag_da: update flip functions to use tty_port > tty: metag_da: avoid getting tty kref in dashtty_timer() They both look good. You can add my: Acked-by: Jiri Slaby if you want. thanks, -- js suse labs -- To unsubscribe from this list: send the

Re: Uhhuh. NMI received for unknown reason 2c on CPU 0.

2013-02-06 Thread Jiri Slaby
On 02/03/2013 12:04 AM, Rafael J. Wysocki wrote: > On Thursday, January 31, 2013 02:10:34 PM Borislav Petkov wrote: >> On Thu, Jan 31, 2013 at 02:12:58PM +0100, Rafael J. Wysocki wrote: >>> Yes, there are two bugs in e1000e, it appears. Konstantin's >>> patch [2/5] fixes one of them, but the other

Re: [PATCH 3/4] pps: Use lookup list to reduce ldisc coupling

2013-02-06 Thread Jiri Slaby
On 02/06/2013 04:55 PM, Peter Hurley wrote: > --- a/drivers/pps/clients/pps-ldisc.c > +++ b/drivers/pps/clients/pps-ldisc.c > @@ -25,17 +25,47 @@ ... > +struct pps_data { > + struct pps_device *pps; > + struct tty_struct *tty; > + struct list_head link; > +}; > + > +DEFINE_SPINLOCK(pps_

[PATCH] NET: ath5k, check ath5k_eeprom_mode_from_channel retval

2013-02-07 Thread Jiri Slaby
It can, if invalid argument given, return a negative value. In that case we would access arrays out-of-bounds and such. Check the value and yell loudly if that happened as it would be a bug in the implementation. (Instead of silently corrupting memory.) Signed-off-by: Jiri Slaby Cc: Nick

Re: [PATCH v3 01/23] tty: Add diagnostic for halted line discipline

2013-02-07 Thread Jiri Slaby
On 02/05/2013 09:20 PM, Peter Hurley wrote: > --- a/drivers/tty/tty_ldisc.c > +++ b/drivers/tty/tty_ldisc.c > @@ -375,6 +375,7 @@ static inline void tty_ldisc_put(struct tty_ldisc *ld) > > void tty_ldisc_enable(struct tty_struct *tty) > { > + clear_bit(TTY_LDISC_HALTED, &tty->flags); >

Re: [PATCH v3 03/23] n_tty: Don't flush buffer when closing ldisc

2013-02-07 Thread Jiri Slaby
On 02/05/2013 09:20 PM, Peter Hurley wrote: > A buffer flush is both undesirable and unnecessary when the ldisc > is closing. A buffer flush performs the following: > 1. resets ldisc data fields to their initial state > 2. resets tty->receive_room to indicate more data can be sent > 3. schedules

Re: [PATCH v3 02/23] n_tty: Factor packet mode status change for reuse

2013-02-07 Thread Jiri Slaby
On 02/05/2013 09:20 PM, Peter Hurley wrote: > Factor the packet mode status change from n_tty_flush_buffer > for use by follow-on patch. > > Signed-off-by: Peter Hurley > --- > drivers/tty/n_tty.c | 24 ++-- > 1 file changed, 14 insertions(+), 10 deletions(-) > > diff --git

Re: [PATCH v3 04/23] tty: Refactor wait for ldisc refs out of tty_ldisc_hangup()

2013-02-07 Thread Jiri Slaby
On 02/05/2013 09:20 PM, Peter Hurley wrote: > Refactor tty_ldisc_hangup() to extract standalone function, > tty_ldisc_hangup_wait_idle(), to wait for ldisc references > to be released. > > Signed-off-by: Peter Hurley > --- > drivers/tty/tty_ldisc.c | 54 > ---

Re: [PATCH v3 05/23] tty: Remove unnecessary re-test of ldisc ref count

2013-02-07 Thread Jiri Slaby
On 02/05/2013 09:20 PM, Peter Hurley wrote: > + char cur_n[TASK_COMM_LEN], tty_n[64]; > + long timeout = 3 * HZ; > + > + if (tty->ldisc) { /* Not yet closed */ > + tty_unlock(tty); > + > + while (tty_ldisc_wait_idle(tty, timeout) == -EBUSY) { > +

Re: [PATCH v3 07/23] tty: Strengthen no-subsequent-use guarantee of tty_ldisc_halt()

2013-02-07 Thread Jiri Slaby
On 02/05/2013 09:20 PM, Peter Hurley wrote: > @@ -688,9 +702,9 @@ int tty_set_ldisc(struct tty_struct *tty, int ldisc) >* parallel to the change and re-referencing the tty. >*/ > > - work = tty_ldisc_halt(tty); > + retval = tty_ldisc_halt(tty, &work, 5 * HZ); >

Re: [PATCH v3 12/23] tty: Kick waiters _after_ the ldisc is locked

2013-02-07 Thread Jiri Slaby
On 02/05/2013 09:20 PM, Peter Hurley wrote: The question is obvious: why? The waiters usually don't care about ldisc. > Signed-off-by: Peter Hurley > --- > drivers/tty/tty_ldisc.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/tty/tty_ldisc.c b/d

Re: [PATCH v3 01/23] tty: Add diagnostic for halted line discipline

2013-02-07 Thread Jiri Slaby
On 02/07/2013 04:53 PM, Peter Hurley wrote: >>> +static int tty_ldisc_halt(struct tty_struct *tty) >>> +{ >>> + int scheduled; >>> + clear_bit(TTY_LDISC, &tty->flags); >>> + scheduled = cancel_work_sync(&tty->port->buf.work); >>> + set_bit(TTY_LDISC_HALTED, &tty->flags); >>> + return sche

Re: [PATCH v3 05/23] tty: Remove unnecessary re-test of ldisc ref count

2013-02-07 Thread Jiri Slaby
On 02/07/2013 04:59 PM, Peter Hurley wrote: > On Thu, 2013-02-07 at 16:16 +0100, Jiri Slaby wrote: >> On 02/05/2013 09:20 PM, Peter Hurley wrote: >>> + char cur_n[TASK_COMM_LEN], tty_n[64]; >>> + long timeout = 3 * HZ; >>> + >>>

Re: [Bisected] [-next-20130204] usb/hcd: irq 18: nobody cared

2013-02-11 Thread Jiri Slaby
On 02/11/2013 07:40 AM, Yinghai Lu wrote: > Can you try attached debug patch? FWIW this fixes it for me. No more 'derived' or 'nobody' in dmesg. thanks, -- js suse labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.or

[stable request] fix stack overflow in __reserve_region_with_split

2013-02-11 Thread Jiri Slaby
Hi, I think this one should go to stable: commit 4965f5667f36a95b41cda6638875bc992bd7d18b Author: T Makphaibulchoke Date: Thu Oct 4 17:16:55 2012 -0700 kernel/resource.c: fix stack overflow in __reserve_region_with_split() To all up to 3.7 (exclusive). thanks, -- js suse labs -- To unsu

compositing broken in -next (idr bug)

2013-02-12 Thread Jiri Slaby
Hi, this commit in -next causes my KDE to get stuck while starting. I see only the splash screen. If I disable effects by alt-shift-f12, it continues. I bisected it to this commit: commit 430440fce7da4ad52c2af06a04a5132e5d19faaf Author: Tejun Heo Date: Thu Feb 7 12:31:37 2013 +1100 drm: c

Re: compositing broken in -next (idr bug)

2013-02-12 Thread Jiri Slaby
On 02/12/2013 10:58 PM, Tejun Heo wrote: > Hello, Jiri. > > On Tue, Feb 12, 2013 at 10:55:37PM +0100, Jiri Slaby wrote: >> this commit in -next causes my KDE to get stuck while starting. I see >> only the splash screen. If I disable effects by alt-shift-f12, it continues. &

Re: compositing broken in -next (idr bug)

2013-02-12 Thread Jiri Slaby
On 02/12/2013 10:55 PM, Jiri Slaby wrote: > --- a/drivers/gpu/drm/drm_gem.c > +++ b/drivers/gpu/drm/drm_gem.c > @@ -453,7 +453,8 @@ drm_gem_flink_ioctl(struct drm_device *dev, void *data, > spin_lock(&dev->object_name_lock); > if (!obj->name) { >

Re: compositing broken in -next (idr bug)

2013-02-12 Thread Jiri Slaby
On 02/12/2013 11:03 PM, Jiri Slaby wrote: > On 02/12/2013 10:55 PM, Jiri Slaby wrote: >> --- a/drivers/gpu/drm/drm_gem.c >> +++ b/drivers/gpu/drm/drm_gem.c >> @@ -453,7 +453,8 @@ drm_gem_flink_ioctl(struct drm_device *dev, void *data, >> spin_lock(&dev-&g

Re: Excessive stall times on ext4 in 3.9-rc2

2013-04-02 Thread Jiri Slaby
On 04/02/2013 04:27 PM, Mel Gorman wrote: > I'm testing a page-reclaim-related series on my laptop that is partially > aimed at fixing long stalls when doing metadata-intensive operations on > low memory such as a git checkout. I've been running 3.9-rc2 with the > series applied but found that the

Re: [PATCH] Documentation: fix a path in a DocBook template

2013-04-02 Thread Jiri Slaby
On 04/02/2013 06:39 PM, Guennadi Liakhovetski wrote: > A wrong path to a driver breaks DocBook built. > > Cc: Jiri Slaby > Signed-off-by: Guennadi Liakhovetski Yes, thanks for fixing. Acked-by: Jiri Slaby > Documentation/DocBook/device-drivers.tmpl |2 +- >

Re: Uhhuh. NMI received for unknown reason 2c on CPU 0.

2013-04-04 Thread Jiri Slaby
On 03/01/2013 01:55 PM, Jiri Slaby wrote: > On 01/31/2013 02:24 PM, Borislav Petkov wrote: >> On Thu, Jan 31, 2013 at 02:18:05PM +0100, Borislav Petkov wrote: >>>> And if I pass nmi_watchdog=0 to the image kernel, it should be gone I >>>> guess. >>> &g

Re: Uhhuh. NMI received for unknown reason 2c on CPU 0.

2013-04-04 Thread Jiri Slaby
On 04/04/2013 11:33 AM, Borislav Petkov wrote: > On Thu, Apr 04, 2013 at 09:32:09AM +0200, Jiri Slaby wrote: >> And yesterday I plugged in an ethernet cable for a wihle and guess >> what happened today: Uhhuh. NMI received for unknown reason 2c on CPU >> 0. >> >> S

[PATCH] MFD: rtsx_pcr, fix probe fail path

2013-04-04 Thread Jiri Slaby
. Signed-off-by: Jiri Slaby --- drivers/mfd/rtsx_pcr.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/rtsx_pcr.c b/drivers/mfd/rtsx_pcr.c index 2f12cc1..578a113 100644 --- a/drivers/mfd/rtsx_pcr.c +++ b/drivers/mfd/rtsx_pcr.c @@ -1138,7 +1138,7 @@ static int

[PATCH 3/5] SOUND: hda_generic, fix uninitialized variable

2013-04-04 Thread Jiri Slaby
changed is not initialized in path_power_down_sync, but it is expected to be false in case no change happened in the loop. So set it to false. Signed-off-by: Jiri Slaby Cc: Jaroslav Kysela Cc: Takashi Iwai --- sound/pci/hda/hda_generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 4/5] X86: boot, close opened descriptor

2013-04-04 Thread Jiri Slaby
In build, we open a file, read that but do not close it. Fix that by sticking fclose at the right place. Signed-off-by: Jiri Slaby Cc: "H. Peter Anvin" Cc: Thomas Gleixner Cc: Ingo Molnar Cc: x...@kernel.org --- arch/x86/boot/tools/build.c | 1 + 1 file changed, 1 insertion(+) di

[PATCH 1/5] BLOCK: rbd, return proper error from rbd_dev_probe_update_spec

2013-04-04 Thread Jiri Slaby
ret might be uninitialized and is returned that way when kstrdup of rbd_dev->spec->snap_name fails. Fix it by returning ENOMEM from that place. Signed-off-by: Jiri Slaby --- drivers/block/rbd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/block/rbd.c b/d

[PATCH 2/5] MEDIA: ttusbir, fix double free

2013-04-04 Thread Jiri Slaby
ff-by: Jiri Slaby Cc: Sean Young Cc: Mauro Carvalho Chehab Cc: linux-me...@vger.kernel.org --- drivers/media/rc/ttusbir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/rc/ttusbir.c b/drivers/media/rc/ttusbir.c index cf0d47f..891762d 100644 --- a/drivers/media/rc/ttusbir.c

[PATCH 5/5] HID: hid-lenovo-tpkbd, remove doubled hid_get_drvdata

2013-04-04 Thread Jiri Slaby
In pointer_press_speed_show, we do data_pointer = hid_get_drvdata(hdev); twice in a row. Remove one of those. Signed-off-by: Jiri Slaby Cc: Jiri Kosina Cc: linux-in...@vger.kernel.org --- drivers/hid/hid-lenovo-tpkbd.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/hid/hid

[PATCH] TTY: io_ti, stop dereferencing potential NULL

2013-04-04 Thread Jiri Slaby
tty_port_tty_get might return a tty which is NULL. But it is dereferenced unconditionally in edge_send. Stop dereferencing that by sending usb_serial_port pointer around. Signed-off-by: Jiri Slaby Cc: Johan Hovold Cc: linux-...@vger.kernel.org --- drivers/usb/serial/io_ti.c | 9 - 1

[stable 3.0 revert request] x86-32, mm: Remove reference to resume_map_numa_kva()

2013-04-05 Thread Jiri Slaby
Hi, in 3.0.67 there is this commit: commit dbb694e810c87e7e1760527a783437f26ac5a547 Author: H. Peter Anvin Date: Thu Jan 31 13:53:10 2013 -0800 x86-32, mm: Remove reference to resume_map_numa_kva() commit bb112aec5ee41427e9b9726e3d57b896709598ed upstream. Remove reference to remo

Re: Excessive stall times on ext4 in 3.9-rc2

2013-04-05 Thread Jiri Slaby
On 04/03/2013 12:19 PM, Mel Gorman wrote: > On Tue, Apr 02, 2013 at 11:14:36AM -0400, Theodore Ts'o wrote: >> On Tue, Apr 02, 2013 at 11:06:51AM -0400, Theodore Ts'o wrote: >>> >>> Can you try 3.9-rc4 or later and see if the problem still persists? >>> There were a number of ext4 issues especially

Re: Excessive stall times on ext4 in 3.9-rc2

2013-04-06 Thread Jiri Slaby
On 04/06/2013 01:16 AM, Theodore Ts'o wrote: > On Sat, Apr 06, 2013 at 12:18:11AM +0200, Jiri Slaby wrote: >> Ok, so now I'm runnning 3.9.0-rc5-next-20130404, it's not that bad, but >> it still sucks. Updating a kernel in a VM still results in "Your system >&

Re: Excessive stall times on ext4 in 3.9-rc2

2013-04-06 Thread Jiri Slaby
On 04/06/2013 09:29 AM, Jiri Slaby wrote: > On 04/06/2013 01:16 AM, Theodore Ts'o wrote: >> On Sat, Apr 06, 2013 at 12:18:11AM +0200, Jiri Slaby wrote: >>> Ok, so now I'm runnning 3.9.0-rc5-next-20130404, it's not that bad, but >>> it still sucks. Updati

Re: Excessive stall times on ext4 in 3.9-rc2

2013-04-06 Thread Jiri Slaby
On 04/06/2013 09:37 AM, Jiri Slaby wrote: > On 04/06/2013 09:29 AM, Jiri Slaby wrote: >> On 04/06/2013 01:16 AM, Theodore Ts'o wrote: >>> On Sat, Apr 06, 2013 at 12:18:11AM +0200, Jiri Slaby wrote: >>>> Ok, so now I'm runnning 3.9.0-rc5-next-20130404, it

Re: [PATCH 1/1] tty: set_termios/set_termiox should not return -EINTR

2013-01-29 Thread Jiri Slaby
On 01/29/2013 08:07 PM, Oleg Nesterov wrote: > See https://bugzilla.redhat.com/show_bug.cgi?id=904907 > read command causes bash to abort with double free or corruption (out). > > A simple test-case from Roman: > > // Compile the reproducer and send sigchld ti that process. > // EINTR

Re: [PATCH 1/1] tty: set_termios/set_termiox should not return -EINTR

2013-01-29 Thread Jiri Slaby
On 01/29/2013 08:49 PM, Oleg Nesterov wrote: > On 01/29, Jiri Slaby wrote: >> >> On 01/29/2013 08:07 PM, Oleg Nesterov wrote: >>> >>> Change set_termios/set_termiox to return -ERESTARTSYS to fix this >>> particular problem. >> >> This looks

Re: Uhhuh. NMI received for unknown reason 2c on CPU 0.

2013-01-30 Thread Jiri Slaby
On 01/30/2013 09:00 PM, Borislav Petkov wrote: > On Wed, Jan 30, 2013 at 08:43:55PM +0100, Jiri Slaby wrote: >> On 01/30/2013 06:44 PM, Borislav Petkov wrote: >>> On Wed, Jan 30, 2013 at 10:27:42AM -0700, Bjorn Helgaas wrote: >>>> You're right, I don'

Re: Uhhuh. NMI received for unknown reason 2c on CPU 0.

2013-01-30 Thread Jiri Slaby
On 01/30/2013 10:39 PM, Rafael J. Wysocki wrote: >> What is cool is that I have steps to reproduce: >> 1) boot >> 2) run the attached script (turn on all possible power savings -- in >> fact everything what powertop suggests) >> 3) suspend to _disk_ (mem is not enough, BIOS apparently has to >> int

Re: Uhhuh. NMI received for unknown reason 2c on CPU 0.

2013-01-30 Thread Jiri Slaby
On 01/30/2013 11:45 PM, Rafael J. Wysocki wrote: > On Wednesday, January 30, 2013 11:17:06 PM Jiri Slaby wrote: >> On 01/30/2013 10:39 PM, Rafael J. Wysocki wrote: >>>> What is cool is that I have steps to reproduce: >>>> 1) boot >>>> 2) run the attach

Re: Uhhuh. NMI received for unknown reason 2c on CPU 0.

2013-01-30 Thread Jiri Slaby
On 01/31/2013 12:12 AM, Jiri Slaby wrote: > I think I will start with commenting parts of `power' script to see > exactly which of the power savings cause this. ... NMI watchdog. If I remove it from the script, the problem disappears. If I try it alone, I have those NMIs. -- js suse

Re: Uhhuh. NMI received for unknown reason 2c on CPU 0.

2013-01-31 Thread Jiri Slaby
On 01/31/2013 08:09 AM, Borislav Petkov wrote: > On Thu, Jan 31, 2013 at 01:54:56AM +0100, Rafael J. Wysocki wrote: >> On Thursday, January 31, 2013 12:47:40 AM Jiri Slaby wrote: >>> On 01/31/2013 12:12 AM, Jiri Slaby wrote: >>>> I think I will start with commenting

Re: Uhhuh. NMI received for unknown reason 2c on CPU 0.

2013-01-31 Thread Jiri Slaby
On 01/31/2013 08:09 AM, Borislav Petkov wrote: > On Thu, Jan 31, 2013 at 01:54:56AM +0100, Rafael J. Wysocki wrote: >> On Thursday, January 31, 2013 12:47:40 AM Jiri Slaby wrote: >>> On 01/31/2013 12:12 AM, Jiri Slaby wrote: >>>> I think I will start with commenting

Re: [PATCH 07/10] TTY: switch tty_schedule_flip

2013-02-01 Thread Jiri Slaby
On 02/01/2013 01:37 PM, Peter Hurley wrote: > On Thu, 2013-01-03 at 15:53 +0100, Jiri Slaby wrote: >> Now, we start converting tty buffer functions to actually use >> tty_port. This will allow us to get rid of the need of tty in many >> call sites. Only tty_port will nee

Re: [patch] TTY: synclink, small cleanup in dtr_rts()

2013-01-27 Thread Jiri Slaby
On 01/27/2013 09:04 PM, Joe Perches wrote: > On Sun, 2013-01-27 at 22:40 +0300, Dan Carpenter wrote: >> There is a kind of precedence problem here, but it doesn't affect how >> the code works because ->serial_signals is unsigned char. We want to >> clear two flags here. >> >> #define SerialSignal_

Re: kswapd craziness round 2

2013-02-24 Thread Jiri Slaby
On 02/21/2013 01:07 PM, Hillf Danton wrote: > On Thu, Feb 21, 2013 at 6:14 AM, Jiri Slaby wrote: >>> >>> Does Ingo's revert help? https://lkml.org/lkml/2013/2/15/168 >> >> Not at all... >> > Then mind taking a try? Applied now, I'll report in

Re: WARNING: at drivers/pci/pci.c:1397 pci_disable_device

2013-02-24 Thread Jiri Slaby
On 02/19/2013 07:53 PM, Bjorn Helgaas wrote: > On Tue, Feb 19, 2013 at 11:34 AM, Jiri Slaby wrote: >> Hi, >> >> so I hit that one: >> + dev_WARN_ONCE(&dev->dev, atomic_read(&dev->enable_cnt) <= 0, >> + "disabling

Re: WARNING: at drivers/pci/pci.c:1397 pci_disable_device

2013-02-25 Thread Jiri Slaby
On 02/24/2013 10:28 PM, Jiri Slaby wrote: > On 02/19/2013 07:53 PM, Bjorn Helgaas wrote: >> On Tue, Feb 19, 2013 at 11:34 AM, Jiri Slaby wrote: >>> Hi, >>> >>> so I hit that one: >>> + dev_WARN_ONCE(&dev->dev, atomic_read(&dev->ena

[PATCH] ath5k: cleanup channel to eprom_mode function

2013-02-25 Thread Jiri Slaby
declaration to be moved to ath5k.h. Signed-off-by: Jiri Slaby --- drivers/net/wireless/ath/ath5k/ath5k.h | 3 ++- drivers/net/wireless/ath/ath5k/eeprom.c | 6 -- drivers/net/wireless/ath/ath5k/eeprom.h | 3 --- drivers/net/wireless/ath/ath5k/phy.c| 20 +++- drivers/net

Re: WARNING from tty driver in 3.9-rc0

2013-02-27 Thread Jiri Slaby
On 02/26/2013 10:56 PM, Daniel Mack wrote: > On Tue, Feb 26, 2013 at 10:25 PM, Larry Finger > wrote: >> Hi, >> >> With v3.8-8693-gbf722a0 from the mainline repo, I get the following warning >> because the pointer for tty is NULL: >> >> [ 34.956862] WARNING: at drivers/tty/tty_buffer.c:428 >> flu

[PATCH] TTY: disable debugging warning

2013-02-27 Thread Jiri Slaby
and we are hunting for another bugs. Signed-off-by: Jiri Slaby --- drivers/tty/tty_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c index bb11993..578aa75 100644 --- a/drivers/tty/tty_buffer.c +++ b/drivers/tty

Re: [PATCH] TTY: disable debugging warning

2013-02-27 Thread Jiri Slaby
On 02/27/2013 10:42 PM, Greg KH wrote: > On Wed, Feb 27, 2013 at 10:30:24PM +0100, Jiri Slaby wrote: >> We added a warning to flush_to_ldisc to report cases when it is called >> with a NULL tty. It was for debugging purposes and it lead to a >> patchset from Peter Hurley. The

Re: [PATCH] n_gsm: Add Mutex to avoid race when net destroy

2013-02-28 Thread Jiri Slaby
On 02/28/2013 06:31 AM, channing wrote: > > when gsm Net is enabled, data on dlci is transferrd by > gsm_mux_net_start_xmit(), while userspace may trigger > ioctrl to call gsm_destroy_network() during data was > transferring, because there is no mutex protection between > the two functions, follow

Re: WARNING from tty driver in 3.9-rc0

2013-02-28 Thread Jiri Slaby
On 02/27/2013 10:25 PM, Larry Finger wrote: > Thanks for looking into this. Will you be pushing a 3.9 patch to disable > the warning? Hi, yes, it's on its way already. -- js suse labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...

Re: kswapd craziness round 2

2013-02-28 Thread Jiri Slaby
On 02/21/2013 01:07 PM, Hillf Danton wrote: > On Thu, Feb 21, 2013 at 6:14 AM, Jiri Slaby wrote: >>> >>> Does Ingo's revert help? https://lkml.org/lkml/2013/2/15/168 >> >> Not at all... >> > Then mind taking a try? Ok, no difference, kswap is still

Re: [ 47/53] dca: check against empty dca_domains list before unregister provider

2013-02-28 Thread Jiri Slaby
On 02/27/2013 12:58 AM, Greg Kroah-Hartman wrote: > 3.0-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Maciej Sosnowski > > commit c419fcfd071cf34ba00f9f65282583772d2655e7 upstream. > > When providers get blocked unregister_dca_provider

Re: [ 47/53] dca: check against empty dca_domains list before unregister provider

2013-02-28 Thread Jiri Slaby
On 02/28/2013 11:04 PM, Jiri Slaby wrote: > On 02/27/2013 12:58 AM, Greg Kroah-Hartman wrote: >> 3.0-stable review patch. If anyone has any objections, please let me know. >> >> -- >> >> From: Maciej Sosnowski >> >> commit c419

Re: [ 17/53] s390/kvm: Fix store status for ACRS/FPRS

2013-02-28 Thread Jiri Slaby
On 02/27/2013 12:57 AM, Greg Kroah-Hartman wrote: > 3.0-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Christian Borntraeger > > commit 15bc8d8457875f495c59d933b05770ba88d1eacb upstream. > > On store status we need to copy the current s

Re: WARNING: at drivers/gpu/drm/nouveau/core/core/mm.c:242

2013-02-18 Thread Jiri Slaby
On 02/19/2013 12:23 AM, Marcin Slusarz wrote: > On Mon, Feb 18, 2013 at 11:27:43AM +0100, Jiri Slaby wrote: >> Hi, >> >> we have a report of WARNING from 3.7.6 in nouveau at >> drivers/gpu/drm/nouveau/core/core/mm.c:242 here: >> https://bugzilla.novell.com/show_bug

Re: [regression] openSUSE 12.2 stable kernel 3.7.8-1 big USB 2.0 slowdown

2013-02-19 Thread Jiri Slaby
On 02/19/2013 03:56 AM, Alan Stern wrote: > On Mon, 18 Feb 2013, Jiri Slaby wrote: > >> On 02/18/2013 06:25 AM, Anja Nützel wrote: >>> Maybe it startet with 3.7.7. >>> I could copy several MB onto my USB 2.0 sticks with 3.7.6. (I think). >>> Even with ful

Re: [PATCH] vt: add init_hide parameter to suppress boot output

2013-02-19 Thread Jiri Slaby
On 02/19/2013 10:38 AM, Kirill A. Shutemov wrote: > From: Andy Ross > > When vt.init_hide=1 is set, suppress output on newly created consoles > until an affirmative switched to that console. This prevents boot > output from displaying (and clobbering splash screens, etc...) without > disabling t

Re: [PATCH v2] tty: mxser: improve error handling in mxser_probe() and mxser_module_init()

2013-02-19 Thread Jiri Slaby
On 02/19/2013 06:57 AM, Alexey Khoroshilov wrote: > 1. Currently mxser_probe() and mxser_module_init() ignore errors > that can happen in tty_port_register_device(). > 2. mxser_module_init() does not deallocate resources allocated in > mxser_get_ISA_conf() > if mxser_initbrd() failed. > > The pat

Re: [PATCH] NET: ath5k, check ath5k_eeprom_mode_from_channel retval

2013-02-19 Thread Jiri Slaby
H5K_WARN there. Something like the attached patch? It needs ah to be propagated to eeprom. If you are fine with that, I'll send it as patch... thanks, -- js suse labs >From 0e75c33da1f8b35ff1d25f08650e95fc97c01528 Mon Sep 17 00:00:00 2001 From: Jiri Slaby Date: Tue, 19 Feb 2013 14:31:

Re: [regression] openSUSE 12.2 stable kernel 3.7.8-1 big USB 2.0 slowdown

2013-02-19 Thread Jiri Slaby
On 02/19/2013 05:44 PM, Dieter Nützel wrote: > Am 2013-02-19 10:16, schrieb Jiri Slaby: >> On 02/19/2013 03:56 AM, Alan Stern wrote: >>> A lot of people have reported problems caused by the last one >>> (269ef9f). I haven't had time to investigate yet (just got

WARNING: at drivers/pci/pci.c:1397 pci_disable_device

2013-02-19 Thread Jiri Slaby
Hi, so I hit that one: + dev_WARN_ONCE(&dev->dev, atomic_read(&dev->enable_cnt) <= 0, + "disabling already-disabled device"); during suspend (to ram): WARNING: at drivers/pci/pci.c:1397 pci_disable_device+0x90/0xa0() Hardware name: To Be Filled By O.E.M. Device e1000e di

[stable request] fix for nouveau mem corruption [was: WARNING: at drivers/gpu/drm/nouveau/core/core/mm.c:242]

2013-02-20 Thread Jiri Slaby
On 02/19/2013 08:07 AM, Marcin Slusarz wrote: >>> Crash/warning should be fixed by commit >>> cfd376b6bfccf33782a0748a9c70f7f752f8b869 >>> "drm/nouveau/vm: fix memory corruption when pgt allocation fails". >> >> Oh, thanks for the pointer. Could that bug cause real "memory >> corruption"? As we're

Re: [PATCH 1/1] tty: atmel_serial_probe(): index of atmel_ports[] fix

2013-02-20 Thread Jiri Slaby
On 02/13/2013 12:17 AM, Pawel Wieczorkiewicz wrote: > From: Pawel Wieczorkiewicz > > Index of atmel_ports[ATMEL_MAX_UART] should be smaller > than ATMEL_MAX_UART. > > Signed-off-by: Pawel Wieczorkiewicz > --- > drivers/tty/serial/atmel_serial.c |2 +- > 1 file changed, 1 insertion(+), 1 de

Re: [PATCH] TTY: do not reset master's packet mode

2013-02-20 Thread Jiri Slaby
On 02/20/2013 02:19 PM, Karel Zak wrote: > On Tue, Jan 15, 2013 at 11:26:22PM +0100, Jiri Slaby wrote: >> Now that login from util-linux is forced to drop all references to a >> TTY which it wants to hangup (to reach reference count 1) we are >> seeing issues with telnet.

Re: kswapd craziness round 2

2013-02-20 Thread Jiri Slaby
On 02/18/2013 12:42 PM, Hillf Danton wrote: > On Mon, Feb 18, 2013 at 2:18 PM, Daniel J Blueman > wrote: >> On Monday, 18 February 2013 06:10:02 UTC+8, Jiri Slaby wrote: >> >>> Hi, >>> >>> You still feel the sour taste of the "kswapd crazine

[stable-request] [Bisected] Kernel 3.8 hangs on boot

2013-02-22 Thread Jiri Slaby
On 02/22/2013 10:53 AM, ojab wrote: > On 22.02.2013 13:25, Jiri Slaby wrote: >> On 02/22/2013 07:32 AM, ojab wrote: >> >> Ideally with description of tha hang. Are there any messages (if you >> disable splash and enable debug)? Do keyboard LEDs blink? >> >>

Re: [stable-request] [Bisected] Kernel 3.8 hangs on boot

2013-02-22 Thread Jiri Slaby
On 02/22/2013 12:01 PM, Jiri Slaby wrote: > On 02/22/2013 10:53 AM, ojab wrote: >> On 22.02.2013 13:25, Jiri Slaby wrote: >>> On 02/22/2013 07:32 AM, ojab wrote: >>> >>> Ideally with description of tha hang. Are there any messages (if you >>> disab

Re: WARNING: at drivers/gpu/drm/nouveau/core/core/mm.c:242

2013-03-13 Thread Jiri Slaby
On 02/19/2013 11:32 PM, Marcin Slusarz wrote: > On Tue, Feb 19, 2013 at 08:07:44AM +0100, Marcin Slusarz wrote: >> On Tue, Feb 19, 2013 at 12:43:06AM +0100, Jiri Slaby wrote: >>> On 02/19/2013 12:23 AM, Marcin Slusarz wrote: >>>> Tomorrow I'll post a patch for pa

Re: [PATCH 07/16] TTY: quatech2, remove unneeded is_open

2013-03-13 Thread Jiri Slaby
On 03/13/2013 02:46 PM, Bill Pemberton wrote: > Jiri Slaby writes: >> >> tty->ops->break_ctl cannot be called outside the gap between open and >> close. So there is no need to check whether the port is open in >> break_ctl in quatech2. Remove the check a

[PATCH] TTY: serial, stop accessing potential NULLs

2013-03-13 Thread Jiri Slaby
and up->port.state->port.tty. There is perhaps more to fix in all those drivers, but they are at least in a state they were before. Signed-off-by: Jiri Slaby Cc: "David S. Miller" Cc: Grant Likely Cc: Rob Herring Cc: sparcli...@vger.kernel.org --- drivers/tty/serial/sunsab.c

[stable request] TTY: do not reset master's packet mode

2013-03-14 Thread Jiri Slaby
Hi, please include the patch below to all maintained stable trees. commit b81273a132177edd806476b953f6afeb17b786d5 Author: Jiri Slaby Date: Tue Jan 15 23:26:22 2013 +0100 TTY: do not reset master's packet mode thanks, -- js suse labs -- To unsubscribe from this list: send the

Re: [stable request] TTY: do not reset master's packet mode

2013-03-14 Thread Jiri Slaby
On 03/14/2013 12:01 PM, Jiri Slaby wrote: > Hi, > > please include the patch below to all maintained stable trees. > > commit b81273a132177edd806476b953f6afeb17b786d5 > Author: Jiri Slaby > Date: Tue Jan 15 23:26:22 2013 +0100 > > TTY: do not reset master&

Re: [PATCH] staging:fixed code to fit tty_driver's kref filed fixed code to fit tty_driver's kref filed for drivers/staging/net/pc300_tty.c

2012-08-30 Thread Jiri Slaby
On 08/27/2012 03:34 PM, Baodong Chen wrote: Sorry, I do not get this change. You should not touch tty_driver.kref at all. And what is the patch good for? > Signed-off-by: Baodong Chen > --- > drivers/staging/net/pc300_tty.c | 55 > ++- > 1 files changed,

Re: i2c-designware-core: KBUILD_MODNAME undeclared [was: Build regressions/improvements in v3.6-rc1]

2012-08-31 Thread Jiri Slaby
On 08/31/2012 02:44 PM, Jean Delvare wrote: > Hi Jiri, Geert, > > On Wed, 15 Aug 2012 22:01:38 +0200, Jiri Slaby wrote: >> On 08/04/2012 11:24 AM, Geert Uytterhoeven wrote: >>> Below is the list of build error/warning regressions/improvements in >>&g

Re: [PATCHv2] tty: Added a CONFIG_TTY option to allow removal of TTY

2012-09-03 Thread Jiri Slaby
On 09/03/2012 02:44 AM, Joe Millenbach wrote: > The option allows you to remove TTY and compile without errors. This > saves space on systems that won't support TTY interfaces anyway. > bloat-o-meter output is below. ... > --- a/drivers/tty/Kconfig > +++ b/drivers/tty/Kconfig > @@ -1,3 +1,14 @@ > +

Re: [PATCHv2] tty: Added a CONFIG_TTY option to allow removal of TTY

2012-09-03 Thread Jiri Slaby
On 09/03/2012 11:24 PM, Joe Millenbach wrote: > I do not have a Power PC system to test on Neither do I. But that is no excuse to break it. There are cross-compilers for instance. > so during my testing I did > not notice that option would need TTY also. Thanks for pointing that > out. Before I

Re: qemu-kvm loops after kernel udpate

2012-09-11 Thread Jiri Slaby
On 09/11/2012 09:03 PM, Marcelo Tosatti wrote: > On Tue, Sep 11, 2012 at 08:11:36PM +0200, Jiri Slaby wrote: >> Hi, >> >> it looks like an update from next-20120824 to next-20120910 makes kvm >> defunct. When I try to run qemu, it loops forever without printing

Re: qemu-kvm loops after kernel udpate

2012-09-12 Thread Jiri Slaby
On 09/12/2012 10:06 AM, Avi Kivity wrote: > On 09/11/2012 10:41 PM, Jiri Slaby wrote: >> On 09/11/2012 09:03 PM, Marcelo Tosatti wrote: >>> On Tue, Sep 11, 2012 at 08:11:36PM +0200, Jiri Slaby wrote: >>>> Hi, >>>> >>>> it looks like a

Re: qemu-kvm loops after kernel udpate

2012-09-12 Thread Jiri Slaby
On 09/12/2012 10:18 AM, Avi Kivity wrote: > On 09/12/2012 11:13 AM, Jiri Slaby wrote: >> kvm statistics >> >> exits 6778198 615942 >> host_state_reload 1988 187 >> irq_exits

Re: qemu-kvm loops after kernel udpate

2012-09-12 Thread Jiri Slaby
On 09/12/2012 10:18 AM, Avi Kivity wrote: > On 09/12/2012 11:13 AM, Jiri Slaby wrote: >> >>> Please provide the output of vmxcap >>> (http://goo.gl/c5lUO), >> >> Unrestricted guest no > > The big real mode fixes. > > &

Re: [RFC] tty: Add get- ioctls to fetch tty status

2012-09-13 Thread Jiri Slaby
On 09/13/2012 11:56 AM, Cyrill Gorcunov wrote: > For checkpoint/restore we need to know if tty has > exclusive or packet mode set, as well as if pty > is currently locked. Just to be able to restore > this characteristics. > > For this sake the following ioctl codes are introduced > > - TIOGPKT

[RFC 1/1] MISC: hpilo, remove pci_disable_device

2012-09-13 Thread Jiri Slaby
/2008/11/4/535 Signed-off-by: Jiri Slaby Cc: Grant Grundler Cc: Nobin Mathew Cc: Robert Hancock Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: David Altobelli --- drivers/misc/hpilo.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/misc/hpilo.c b/drivers

  1   2   3   4   5   6   7   8   9   10   >