Re: linux-next: manual merge of the net-next tree with the net tree

2013-02-02 Thread Jiri Pirko
Sat, Feb 02, 2013 at 04:22:53AM CET, s...@canb.auug.org.au wrote: >Hi all, > >Today's linux-next merge of the net-next tree got a conflict in >net/ipv6/route.c between commit bd30e947207e ("ipv6: do not create >neighbor entries for local delivery") from the net tree and commit >c440f1609b65 ("ipv6:

Re: [patch net] sky2: fix rx filter setup on link up

2012-10-04 Thread Jiri Pirko
Tue, Sep 18, 2012 at 02:38:52AM CEST, mlind...@marvell.com wrote: >>Mon, Sep 17, 2012 at 06:12:14PM CEST, shemmin...@vyatta.com wrote: >>>On Mon, 17 Sep 2012 17:10:17 +0200 >>>Jiri Pirko wrote: >>> >>>> In my case I have following problem. sky2_set_mul

Re: [PATCH 097/193] drivers/net/team: remove CONFIG_EXPERIMENTAL

2012-10-23 Thread Jiri Pirko
Tue, Oct 23, 2012 at 10:02:50PM CEST, keesc...@chromium.org wrote: >This config item has not carried much meaning for a while now and is >almost always enabled by default. As agreed during the Linux kernel >summit, remove it. > >CC: Jiri Pirko I wanted to do this anyway. Acked

Re: [RFC v2 2/2] net: Add support for NTB virtual ethernet device

2012-07-30 Thread Jiri Pirko
Mon, Jul 30, 2012 at 02:26:34AM CEST, jon.ma...@intel.com wrote: >+static int __devinit ntb_netdev_probe(struct pci_dev *pdev) >+{ >+ struct net_device *ndev; >+ struct ntb_netdev *dev; >+ int rc; >+ >+ ndev = alloc_etherdev(sizeof(struct ntb_netdev)); >+ if (!ndev) >+

Re: [RFC v2 2/2] net: Add support for NTB virtual ethernet device

2012-07-30 Thread Jiri Pirko
Mon, Jul 30, 2012 at 08:19:11PM CEST, jon.ma...@intel.com wrote: >On Mon, Jul 30, 2012 at 04:02:16PM +0200, Jiri Pirko wrote: >> Mon, Jul 30, 2012 at 02:26:34AM CEST, jon.ma...@intel.com wrote: >> >+static int __devinit ntb_netdev_probe(struct pci_dev *pdev) >> >+{ >

[patch net-next V5 01/15] net: introduce upper device lists

2013-01-02 Thread Jiri Pirko
dev->master, it is marked with "master" flag. New upper device list resolves this limitation. Also, the information stored in lists is used for preventing looping setups like "bond->somethingelse->samebond" Signed-off-by: Jiri Pirko --- include/linux/netde

[patch net-next V5 06/15] bridge: remove usage of netdev_set_master()

2013-01-02 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- net/bridge/br_if.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index 1edd71d..2148d47 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c @@ -148,7 +148,7 @@ static void del_nbp(struct

[patch net-next V5 07/15] netpoll: remove usage of dev->master

2013-01-02 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- net/core/netpoll.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/net/core/netpoll.c b/net/core/netpoll.c index 3151acf..d2bda8e 100644 --- a/net/core/netpoll.c +++ b/net/core/netpoll.c @@ -210,9 +210,12 @@ static void netpoll_poll_dev

[patch net-next V5 14/15] net: remove no longer used netdev_set_bond_master() and netdev_set_master()

2013-01-02 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- include/linux/netdevice.h | 6 + net/core/dev.c| 63 --- 2 files changed, 1 insertion(+), 68 deletions(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 52d1146..c3723ef 100644

[patch net-next V5 12/15] nes: remove usage of dev->master

2013-01-02 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- drivers/infiniband/hw/nes/nes.c| 8 +--- drivers/infiniband/hw/nes/nes_cm.c | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/nes/nes.c b/drivers/infiniband/hw/nes/nes.c index 748db2d..d129c36 100644 --- a/drivers

[patch net-next V5 09/15] qlcnic: guard __vlan_find_dev_deep() by rcu_read_lock

2013-01-02 Thread Jiri Pirko
rcu_read_lock was missing here Signed-off-by: Jiri Pirko Acked-by: Sony Chacko --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c index

[patch net-next V5 05/15] team: remove usage of netdev_set_master()

2013-01-02 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- drivers/net/team/team.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 918a901..3df5cc1 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team/team.c @@ -1055,10 +1055,11

[patch net-next V5 00/15] net: introduce upper device lists and remove dev->master

2013-01-02 Thread Jiri Pirko
;v2: - s/unique/master/ better naming + stays closer to the past - fixed vlan err goto - original patch 15 (WARN_ON change) is squashed into the first patch Jiri Pirko (15): net: introduce upper device lists macvlan: add link to upper device vlan: add link to upper device rtnetlink: remove

[patch net-next V5 08/15] cxgb3: remove usage of dev->master

2013-01-02 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c index 942dace..3f1f501 100644

[patch net-next V5 02/15] macvlan: add link to upper device

2013-01-02 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- drivers/net/macvlan.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 68a43fe..b7b614f 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -765,16 +765,22 @@ int

[patch net-next V5 15/15] net: kill dev->master

2013-01-02 Thread Jiri Pirko
Nobody uses this now. Remove it. Signed-off-by: Jiri Pirko --- include/linux/netdevice.h | 4 1 file changed, 4 deletions(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index c3723ef..009bad3 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h

[patch net-next V5 03/15] vlan: add link to upper device

2013-01-02 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- net/8021q/vlan.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c index a292e80..babfde9 100644 --- a/net/8021q/vlan.c +++ b/net/8021q/vlan.c @@ -105,6 +105,8 @@ void unregister_vlan_dev(struct

[patch net-next V5 04/15] rtnetlink: remove usage of dev->master

2013-01-02 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- net/core/rtnetlink.c | 69 1 file changed, 37 insertions(+), 32 deletions(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 2ef7a56..ae612f4 100644 --- a/net/core/rtnetlink.c +++ b/net/core

[patch net-next V5 11/15] vlan: remove usage of dev->master in __vlan_find_dev_deep()

2013-01-02 Thread Jiri Pirko
Also, since all users call __vlan_find_dev_deep() with rcu_read_lock, make no possibility to call this with rtnl mutex held only. Signed-off-by: Jiri Pirko --- net/8021q/vlan_core.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/net/8021q/vlan_core.c b

[patch net-next V5 10/15] qeth: ensure that __vlan_find_dev_deep() is called with rcu_read_lock

2013-01-02 Thread Jiri Pirko
Also benefit from rcu_read_lock held and use __in_dev_get_rcu() in ipv4 case. Signed-off-by: Jiri Pirko --- drivers/s390/net/qeth_l3_main.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net

[patch net-next V5 13/15] bonding: remove usage of dev->master

2013-01-02 Thread Jiri Pirko
Benefit from new upper dev list and free bonding from dev->master usage. Signed-off-by: Jiri Pirko --- drivers/net/bonding/bond_3ad.c | 30 ++--- drivers/net/bonding/bond_alb.c | 6 +-- drivers/net/bonding/bond_main.c | 94 - drivers/

[patch net-next V6 00/15] net: introduce upper device lists and remove dev->master

2013-01-04 Thread Jiri Pirko
n current net-next v1->v2: - s/unique/master/ better naming + stays closer to the past - fixed vlan err goto - original patch 15 (WARN_ON change) is squashed into the first patch Jiri Pirko (15): net: introduce upper device lists macvlan: add link to upper device vlan: add link to upper d

[patch net-next V6 05/15] team: remove usage of netdev_set_master()

2013-01-04 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- drivers/net/team/team.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 78c7d87..5f35d6b 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team/team.c @@ -1055,10 +1055,11

[patch net-next V6 04/15] rtnetlink: remove usage of dev->master

2013-01-04 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- net/core/rtnetlink.c | 69 1 file changed, 37 insertions(+), 32 deletions(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 2ef7a56..ae612f4 100644 --- a/net/core/rtnetlink.c +++ b/net/core

[patch net-next V6 09/15] qlcnic: guard __vlan_find_dev_deep() by rcu_read_lock

2013-01-04 Thread Jiri Pirko
rcu_read_lock was missing here Signed-off-by: Jiri Pirko Acked-by: Sony Chacko --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c index

[patch net-next V6 13/15] bonding: remove usage of dev->master

2013-01-04 Thread Jiri Pirko
Benefit from new upper dev list and free bonding from dev->master usage. Signed-off-by: Jiri Pirko --- drivers/net/bonding/bond_3ad.c | 30 ++--- drivers/net/bonding/bond_alb.c | 6 +-- drivers/net/bonding/bond_main.c | 94 - drivers/

[patch net-next V6 15/15] net: kill dev->master

2013-01-04 Thread Jiri Pirko
Nobody uses this now. Remove it. Signed-off-by: Jiri Pirko --- include/linux/netdevice.h | 4 1 file changed, 4 deletions(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index c3723ef..009bad3 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h

[patch net-next V6 10/15] qeth: ensure that __vlan_find_dev_deep() is called with rcu_read_lock

2013-01-04 Thread Jiri Pirko
Also benefit from rcu_read_lock held and use __in_dev_get_rcu() in ipv4 case. Signed-off-by: Jiri Pirko --- drivers/s390/net/qeth_l3_main.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net

[patch net-next V6 14/15] net: remove no longer used netdev_set_bond_master() and netdev_set_master()

2013-01-04 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- include/linux/netdevice.h | 6 + net/core/dev.c| 63 --- 2 files changed, 1 insertion(+), 68 deletions(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 52d1146..c3723ef 100644

[patch net-next V6 12/15] nes: remove usage of dev->master

2013-01-04 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- drivers/infiniband/hw/nes/nes.c| 8 +--- drivers/infiniband/hw/nes/nes_cm.c | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/nes/nes.c b/drivers/infiniband/hw/nes/nes.c index 748db2d..d129c36 100644 --- a/drivers

[patch net-next V6 11/15] vlan: remove usage of dev->master in __vlan_find_dev_deep()

2013-01-04 Thread Jiri Pirko
Also, since all users call __vlan_find_dev_deep() with rcu_read_lock, make no possibility to call this with rtnl mutex held only. Signed-off-by: Jiri Pirko --- net/8021q/vlan_core.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/net/8021q/vlan_core.c b

[patch net-next V6 08/15] cxgb3: remove usage of dev->master

2013-01-04 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c index 942dace..3f1f501 100644

[patch net-next V6 07/15] netpoll: remove usage of dev->master

2013-01-04 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- net/core/netpoll.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/net/core/netpoll.c b/net/core/netpoll.c index 3151acf..d2bda8e 100644 --- a/net/core/netpoll.c +++ b/net/core/netpoll.c @@ -210,9 +210,12 @@ static void netpoll_poll_dev

[patch net-next V6 02/15] macvlan: add link to upper device

2013-01-04 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- drivers/net/macvlan.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 68a43fe..b7b614f 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -765,16 +765,22 @@ int

[patch net-next V6 01/15] net: introduce upper device lists

2013-01-04 Thread Jiri Pirko
dev->master, it is marked with "master" flag. New upper device list resolves this limitation. Also, the information stored in lists is used for preventing looping setups like "bond->somethingelse->samebond" Signed-off-by: Jiri Pirko --- include/linux/netde

[patch net-next V6 06/15] bridge: remove usage of netdev_set_master()

2013-01-04 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- net/bridge/br_if.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index 1edd71d..2148d47 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c @@ -148,7 +148,7 @@ static void del_nbp(struct

[patch net-next V6 03/15] vlan: add link to upper device

2013-01-04 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- net/8021q/vlan.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c index a292e80..babfde9 100644 --- a/net/8021q/vlan.c +++ b/net/8021q/vlan.c @@ -105,6 +105,8 @@ void unregister_vlan_dev(struct

Re: [BUG] Crash with NULL pointer dereference in bond_handle_frame in -rt (possibly mainline)

2013-03-29 Thread Jiri Pirko
Thu, Mar 28, 2013 at 06:29:52PM CET, eric.duma...@gmail.com wrote: >On Thu, 2013-03-28 at 13:16 -0400, Steven Rostedt wrote: >> Hi, >> >> I'm currently debugging a crash in an old 3.0-rt kernel that one of our >> customers is seeing. The bug happens with a stress test that loads and >> unloads the

Re: [PATCH] net: add a synchronize_net() in netdev_rx_handler_unregister()

2013-03-29 Thread Jiri Pirko
Fri, Mar 29, 2013 at 04:38:15PM CET, eric.duma...@gmail.com wrote: >On Fri, 2013-03-29 at 16:11 +0100, Ivan Vecera wrote: > >> Erik, why doesn't help the write barrier between the assignments. It >> should guarantee their orders... or not? >> > >Its not enough, I wont explain here why as RCU is q

Re: [BUG] Crash with NULL pointer dereference in bond_handle_frame in -rt (possibly mainline)

2013-03-30 Thread Jiri Pirko
Fri, Mar 29, 2013 at 07:36:24PM CET, rost...@goodmis.org wrote: >On Fri, 2013-03-29 at 10:48 +0100, Jiri Pirko wrote: > >> Because, if rcu_dereference(dev->rx_handler) is null, >> rcu_dereference(dev->rx_handler_data) is never done. Therefore I believe >> we

[patch net] sky2: fix rx filter setup on link up

2012-09-17 Thread Jiri Pirko
receive packets with dst mac 01:80:C2:00:00:02 (LACPDU dst mac), which I set up previously by SIOCADDMULTI. So remember computed rx_filter data and write it to GM_MC_ADDR_H[1-4] on link_up. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/marvell/sky2.c | 30 ++ drivers

Re: [patch net] sky2: fix rx filter setup on link up

2012-09-17 Thread Jiri Pirko
Mon, Sep 17, 2012 at 06:12:14PM CEST, shemmin...@vyatta.com wrote: >On Mon, 17 Sep 2012 17:10:17 +0200 >Jiri Pirko wrote: > >> In my case I have following problem. sky2_set_multicast() sets registers >> GM_MC_ADDR_H[1-4] correctly to: >> 0800 0001 0410 >> Ho

Re: [patch net] sky2: fix rx filter setup on link up

2012-09-17 Thread Jiri Pirko
Mon, Sep 17, 2012 at 11:15:07PM CEST, shemmin...@vyatta.com wrote: >On Mon, 17 Sep 2012 22:47:24 +0200 >Jiri Pirko wrote: > >> Mon, Sep 17, 2012 at 06:12:14PM CEST, shemmin...@vyatta.com wrote: >> >On Mon, 17 Sep 2012 17:10:17 +0200 >> >Jiri Pirko wrote: >&

Re: [patch net] sky2: fix rx filter setup on link up

2012-09-17 Thread Jiri Pirko
Tue, Sep 18, 2012 at 02:38:52AM CEST, mlind...@marvell.com wrote: >>Mon, Sep 17, 2012 at 06:12:14PM CEST, shemmin...@vyatta.com wrote: >>>On Mon, 17 Sep 2012 17:10:17 +0200 >>>Jiri Pirko wrote: >>> >>>> In my case I have following problem. sky2_set_mul

Re: [patch net] sky2: fix rx filter setup on link up

2012-09-19 Thread Jiri Pirko
Wed, Sep 19, 2012 at 10:22:48PM CEST, shemmin...@vyatta.com wrote: >Rather than saving and restoring values, why not just redo the >full setup? This would also determine if the change was a result >of something outside the driver. You cannot call sky2_set_multicast() directly here. It is called fr

[patch net-next 06/16] bridge: remove usage of netdev_set_master()

2012-08-13 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- net/bridge/br_if.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index e1144e1..5933900 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c @@ -148,7 +148,7 @@ static void del_nbp(struct

[patch net-next 09/16] qlcnic: guard __vlan_find_dev_deep() by rcu_read_lock

2012-08-13 Thread Jiri Pirko
rcu_read_lock was missing here Signed-off-by: Jiri Pirko --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c index 212c121..9eadf17

[patch net-next 02/16] macvlan: add link to upper device

2012-08-13 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- drivers/net/macvlan.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 66a9bfe..f5bd8a2 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -765,16 +765,22 @@ int

[patch net-next 10/16] qeth: ensure that __vlan_find_dev_deep() is called with rcu_read_lock

2012-08-13 Thread Jiri Pirko
Also benefit from rcu_read_lock held and use __in_dev_get_rcu() in ipv4 case. Signed-off-by: Jiri Pirko --- drivers/s390/net/qeth_l3_main.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net

[patch net-next 12/16] nes: remove usage of dev->master

2012-08-13 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- drivers/infiniband/hw/nes/nes.c|8 +--- drivers/infiniband/hw/nes/nes_cm.c |2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/nes/nes.c b/drivers/infiniband/hw/nes/nes.c index 7140199..e58e9af 100644 --- a

[patch net-next 14/16] net: remove no longer used netdev_set_bond_master() and netdev_set_master()

2012-08-13 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- include/linux/netdevice.h |6 + net/core/dev.c| 63 - 2 files changed, 1 insertion(+), 68 deletions(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index e7a07f8..757f627 100644

[patch net-next 15/16] net: remove usage of dev->master

2012-08-13 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- net/core/dev.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index c0f9adb..8977404 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -5461,8 +5461,8 @@ static void rollback_registered_many(struct

[patch net-next 16/16] net: kill dev->master

2012-08-13 Thread Jiri Pirko
Nobody uses this now. Remove it. Signed-off-by: Jiri Pirko --- include/linux/netdevice.h |4 1 file changed, 4 deletions(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 757f627..28c5ef0 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h

[patch net-next 13/16] bonding: remove usage of dev->master

2012-08-13 Thread Jiri Pirko
Benefit from new upper dev list and free bonding from dev->master usage. Signed-off-by: Jiri Pirko --- drivers/net/bonding/bond_3ad.c | 30 ++--- drivers/net/bonding/bond_alb.c |6 +-- drivers/net/bonding/bond_main.c | 94 +++ drivers/

[patch net-next 11/16] vlan: remove usage of dev->master in __vlan_find_dev_deep()

2012-08-13 Thread Jiri Pirko
Also, since all users call __vlan_find_dev_deep() with rcu_read_lock, make no possibility to call this with rtnl mutex held only. Signed-off-by: Jiri Pirko --- net/8021q/vlan_core.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/net/8021q/vlan_core.c b

[patch net-next 00/16] net: introduce upper device lists and remove dev->master

2012-08-13 Thread Jiri Pirko
cnic, qeth would benefit by this in future by being able to get more appropriate info about l3 addresses. Jiri Pirko (16): net: introduce upper device lists macvlan: add link to upper device vlan: add link to upper device rtnetlink: remove usage of dev->master team: remove usage of netd

[patch net-next 04/16] rtnetlink: remove usage of dev->master

2012-08-13 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- net/core/rtnetlink.c | 44 1 file changed, 24 insertions(+), 20 deletions(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 34d975b..c341eb7 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c

[patch net-next 07/16] netpoll: remove usage of dev->master

2012-08-13 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- net/core/netpoll.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/net/core/netpoll.c b/net/core/netpoll.c index b4c90e4..5c8e560 100644 --- a/net/core/netpoll.c +++ b/net/core/netpoll.c @@ -207,12 +207,16 @@ static void

[patch net-next 08/16] cxgb3: remove usage of dev->master

2012-08-13 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c index 2dbbcbb..28365db

[patch net-next 05/16] team: remove usage of netdev_set_master()

2012-08-13 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- drivers/net/team/team.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index ba10c46..0533cbf 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team/team.c @@ -1040,10

[patch net-next 03/16] vlan: add link to upper device

2012-08-13 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- net/8021q/vlan.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c index 9096bcb..739665e 100644 --- a/net/8021q/vlan.c +++ b/net/8021q/vlan.c @@ -105,6 +105,8 @@ void unregister_vlan_dev(struct

[patch net-next 01/16] net: introduce upper device lists

2012-08-13 Thread Jiri Pirko
resolves this limitation. Also, the information stored in lists is used for preventing looping setups like "bond->somethingelse->samebond" Signed-off-by: Jiri Pirko --- include/linux/netdevice.h | 14 +++ net/core/dev.c| 232 - 2

Re: [patch net-next 01/16] net: introduce upper device lists

2012-08-13 Thread Jiri Pirko
Mon, Aug 13, 2012 at 07:04:11PM CEST, bhutchi...@solarflare.com wrote: >On Mon, 2012-08-13 at 17:27 +0200, Jiri Pirko wrote: >> This lists are supposed to serve for storing pointers to all upper devices. >> Eventually it will replace dev->master pointer which is used for >&g

Re: [patch net-next 15/16] net: remove usage of dev->master

2012-08-13 Thread Jiri Pirko
Mon, Aug 13, 2012 at 07:15:31PM CEST, bhutchi...@solarflare.com wrote: >On Mon, 2012-08-13 at 17:27 +0200, Jiri Pirko wrote: >> Signed-off-by: Jiri Pirko >> --- >> net/core/dev.c |4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff

Re: [patch net-next 03/16] vlan: add link to upper device

2012-08-14 Thread Jiri Pirko
Mon, Aug 13, 2012 at 09:04:21PM CEST, f...@redhat.com wrote: >On Mon, 13 Aug 2012 17:27:02 +0200 >Jiri Pirko wrote: > >> Signed-off-by: Jiri Pirko >> --- >> net/8021q/vlan.c | 10 +- >> 1 file changed, 9 insertions(+), 1 deletion(-) >> >&

Re: [patch net-next 01/16] net: introduce upper device lists

2012-08-14 Thread Jiri Pirko
Tue, Aug 14, 2012 at 11:02:33AM CEST, xiyou.wangc...@gmail.com wrote: >On 08/13/2012 11:27 PM, Jiri Pirko wrote: >>This lists are supposed to serve for storing pointers to all upper devices. >>Eventually it will replace dev->master pointer which is used for >>bonding, bridg

Re: [patch net-next 01/16] net: introduce upper device lists

2012-08-14 Thread Jiri Pirko
Mon, Aug 13, 2012 at 07:52:17PM CEST, f...@redhat.com wrote: >On Mon, 13 Aug 2012 17:27:00 +0200 >Jiri Pirko wrote: > >> This lists are supposed to serve for storing pointers to all upper devices. >> Eventually it will replace dev->master pointer which is used for >>

Re: [patch net-next 01/16] net: introduce upper device lists

2012-08-14 Thread Jiri Pirko
Tue, Aug 14, 2012 at 03:14:00PM CEST, f...@redhat.com wrote: >On Tue, 14 Aug 2012 14:24:33 +0200 >Jiri Pirko wrote: > >> Mon, Aug 13, 2012 at 07:52:17PM CEST, f...@redhat.com wrote: >> >On Mon, 13 Aug 2012 17:27:00 +0200 >> >Jiri Pirko wrote: >> >> +

[patch net-next v2 00/15] net: introduce upper device lists and remove dev->master

2012-08-14 Thread Jiri Pirko
cnic, qeth would benefit by this in future by being able to get more appropriate info about l3 addresses. v1->v2: - s/unique/master/ better naming + stays closer to the history - fixed vlan err goto - original patch 15 (WARN_ON change) is squashed into the first patch - fixed netdev_unique_uppe

[patch net-next v2 05/15] team: remove usage of netdev_set_master()

2012-08-14 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- drivers/net/team/team.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index ba10c46..dabddc5 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team/team.c @@ -1040,10

[patch net-next v2 07/15] netpoll: remove usage of dev->master

2012-08-14 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- net/core/netpoll.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/net/core/netpoll.c b/net/core/netpoll.c index b4c90e4..1f457a6 100644 --- a/net/core/netpoll.c +++ b/net/core/netpoll.c @@ -207,12 +207,16 @@ static void

[patch net-next v2 09/15] qlcnic: guard __vlan_find_dev_deep() by rcu_read_lock

2012-08-14 Thread Jiri Pirko
rcu_read_lock was missing here Signed-off-by: Jiri Pirko --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c index 212c121..9eadf17

[patch net-next v2 12/15] nes: remove usage of dev->master

2012-08-14 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- drivers/infiniband/hw/nes/nes.c|8 +--- drivers/infiniband/hw/nes/nes_cm.c |2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/nes/nes.c b/drivers/infiniband/hw/nes/nes.c index 7140199..6686251 100644 --- a

[patch net-next v2 15/15] net: kill dev->master

2012-08-14 Thread Jiri Pirko
Nobody uses this now. Remove it. Signed-off-by: Jiri Pirko --- include/linux/netdevice.h |4 1 file changed, 4 deletions(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index c689593..8459f72 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h

[patch net-next v2 08/15] cxgb3: remove usage of dev->master

2012-08-14 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c index 2dbbcbb..720425d

[patch net-next v2 14/15] net: remove no longer used netdev_set_bond_master() and netdev_set_master()

2012-08-14 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- include/linux/netdevice.h |6 + net/core/dev.c| 63 - 2 files changed, 1 insertion(+), 68 deletions(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 95345d4..c689593 100644

[patch net-next v2 13/15] bonding: remove usage of dev->master

2012-08-14 Thread Jiri Pirko
Benefit from new upper dev list and free bonding from dev->master usage. Signed-off-by: Jiri Pirko --- drivers/net/bonding/bond_3ad.c | 30 ++--- drivers/net/bonding/bond_alb.c |6 +-- drivers/net/bonding/bond_main.c | 94 +++ drivers/

[patch net-next v2 11/15] vlan: remove usage of dev->master in __vlan_find_dev_deep()

2012-08-14 Thread Jiri Pirko
Also, since all users call __vlan_find_dev_deep() with rcu_read_lock, make no possibility to call this with rtnl mutex held only. Signed-off-by: Jiri Pirko --- net/8021q/vlan_core.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/net/8021q/vlan_core.c b

[patch net-next v2 10/15] qeth: ensure that __vlan_find_dev_deep() is called with rcu_read_lock

2012-08-14 Thread Jiri Pirko
Also benefit from rcu_read_lock held and use __in_dev_get_rcu() in ipv4 case. Signed-off-by: Jiri Pirko --- drivers/s390/net/qeth_l3_main.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net

[patch net-next v2 01/15] net: introduce upper device lists

2012-08-14 Thread Jiri Pirko
dev->master, it is marked with "master" flag. New upper device list resolves this limitation. Also, the information stored in lists is used for preventing looping setups like "bond->somethingelse->samebond" Signed-off-by: Jiri Pirko --- include/linux/netdev

[patch net-next v2 03/15] vlan: add link to upper device

2012-08-14 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- net/8021q/vlan.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c index 9096bcb..2dca0fa 100644 --- a/net/8021q/vlan.c +++ b/net/8021q/vlan.c @@ -105,6 +105,8 @@ void unregister_vlan_dev(struct

[patch net-next v2 06/15] bridge: remove usage of netdev_set_master()

2012-08-14 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- net/bridge/br_if.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index e1144e1..8bea645 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c @@ -148,7 +148,7 @@ static void del_nbp(struct

[patch net-next v2 04/15] rtnetlink: remove usage of dev->master

2012-08-14 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- net/core/rtnetlink.c | 44 1 file changed, 24 insertions(+), 20 deletions(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 34d975b..4d41682 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c

[patch net-next v2 02/15] macvlan: add link to upper device

2012-08-14 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- drivers/net/macvlan.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 66a9bfe..f5bd8a2 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -765,16 +765,22 @@ int

Re: [patch net-next v2 00/15] net: introduce upper device lists and remove dev->master

2012-08-15 Thread Jiri Pirko
Tue, Aug 14, 2012 at 10:32:53PM CEST, bhutchi...@solarflare.com wrote: >On Tue, 2012-08-14 at 16:19 -0400, Andy Gospodarek wrote: >> On Tue, Aug 14, 2012 at 05:05:33PM +0200, Jiri Pirko wrote: >> > Hi all. >> > >> > Recent discussion around >> > &

Re: [patch net-next v2 01/15] net: introduce upper device lists

2012-08-15 Thread Jiri Pirko
Wed, Aug 15, 2012 at 12:33:44AM CEST, bhutchi...@solarflare.com wrote: >On Tue, 2012-08-14 at 17:05 +0200, Jiri Pirko wrote: >> This lists are supposed to serve for storing pointers to all upper devices. >> Eventually it will replace dev->master pointer which is used for >&g

Re: [patch net-next v2 01/15] net: introduce upper device lists

2012-08-15 Thread Jiri Pirko
Thu, Aug 16, 2012 at 12:15:49AM CEST, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Wed, 15 Aug 2012 09:46:12 +0200 > >> You are probably right. I'm not sure how to handle this correctly >> though. Adding some hard limit number might not be correct. > >

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2012-07-22 Thread Jiri Pirko
Sun, Jul 22, 2012 at 08:34:08AM CEST, s...@canb.auug.org.au wrote: >Hi Dave, > >After merging the final tree, today's linux-next build (powerpc >ppc44x_defconfig) failed like this: > >net/core/rtnetlink.c: In function 'rtnl_fill_ifinfo': >net/core/rtnetlink.c:895:46: error: 'struct net_device' has

Re: regression in bonding driver with VLAN challenged interfaces when 8021q module is loaded

2012-10-14 Thread Jiri Pirko
Thu, Oct 11, 2012 at 04:28:40PM CEST, jstan...@rmrf.net wrote: >Since commit cc0e40700656b09d93b062ef6c818aa45429d09a, there is a >problem if you have the 8021q module loaded and you then attempt to >enslave a VLAN challenged interface. This is because VLAN 0 is >automatically added to the bond, an

Re: [PATCH] mlxsw: spectrum: remove redundant check if err is zero

2016-09-23 Thread Jiri Pirko
ned-off-by: Colin Ian King Acked-by: Jiri Pirko

Re: [patch] leds: add driver for Mellanox systems leds

2016-09-07 Thread Jiri Pirko
Wed, Sep 07, 2016 at 02:49:00PM CEST, j.anaszew...@samsung.com wrote: >Hi Vadim, > >On 09/07/2016 03:35 PM, vad...@mellanox.com wrote: >> From: Vadim Pasternak >> >> This makes it possible to create a set of LEDs for Mellanox systems: >> "msx6710", "msx6720", "msb7700", "msn2700", "msx1410", "msn

Re: [PATCH] bonding: Prevent deletion of a bond, or the last slave from a bond, with active usage.

2016-09-08 Thread Jiri Pirko
Thu, Sep 08, 2016 at 05:05:05PM CEST, jasminder.k...@hpe.com wrote: >Hi Jay, Hi Jiri, > > > >Thank you for your inputs. > > > >Some of the requests we got for such preventive checks are from Admins working >on large scale up systems with multiple NICs, FlexNICs and IP addresses. > >ยง One use cas

Re: [PATCH] bonding: Prevent deletion of a bond, or the last slave from a bond, with active usage.

2016-09-08 Thread Jiri Pirko
Thu, Sep 08, 2016 at 06:32:02PM CEST, jasminder.k...@hpe.com wrote: >>The issue of interfaces being arbitrarily changed or deleted >> is not specific to bonding, and could affect any networking device (physical >> or virtual). Thus, if a facility such as this is to be provided, i

Re: linux-next: net/sched/cls_flower.c

2017-10-17 Thread Jiri Pirko
Tue, Oct 17, 2017 at 12:15:09PM CEST, broo...@kernel.org wrote: >Hi all, > >After merging the net-next tree, today's linux-next build >(x86_allmodconfig) failed like this: > >/home/broonie/tmpfs/next/net/sched/cls_flower.c: In function >'fl_hw_destroy_filter': >/home/broonie/tmpfs/next/net/sched/c

Re: [PATCH net-next 7/9] net: dsa: define port types

2017-10-26 Thread Jiri Pirko
Thu, Oct 26, 2017 at 05:22:57PM CEST, vivien.dide...@savoirfairelinux.com wrote: >Introduce an enumerated type for ports, which will be way more explicit >to identify a port type instead of digging into switch port masks. > >A port can be of type CPU, DSA, user, or unused by default. This is a >sta

Re: [PATCH net-next] net: sched: cls_u32: use hash_ptr() for tc_u_hash

2017-10-18 Thread Jiri Pirko
: cls_u32: use block instead of q in >tc_u_common") >Signed-off-by: Arnd Bergmann Acked-by: Jiri Pirko Thanks.

Re: [PATCH] mlxsw: fix warnings for big-endian 32-bit dma_addr_t

2015-10-06 Thread Jiri Pirko
the type of the local variable to u64, which gets rid of the >warning and seems nicer than adding #ifdefs. > >Signed-off-by: Arnd Bergmann >Fixes: eda6500a987a "mlxsw: Add PCI bus implementation" Acked-by: Jiri Pirko Thanks! -- To unsubscribe from this list: send the

Re: [PATCH] mlxsw: fix warnings for big-endian 32-bit dma_addr_t

2015-10-06 Thread Jiri Pirko
Wed, Oct 07, 2015 at 08:53:02AM CEST, j...@perches.com wrote: >On Tue, 2015-10-06 at 23:47 +0200, Arnd Bergmann wrote: >> The recently added mlxsw driver produces warnings in ARM >> allmodconfig: >> >> drivers/net/ethernet/mellanox/mlxsw/pci.c: In function 'mlxsw_pci_cmd_exec': >> drivers/net/ethe

Re: [PATCH v2] mlxsw: fix warnings for big-endian 32-bit dma_addr_t

2015-10-07 Thread Jiri Pirko
uses upper_32_bits() to extract the bits while avoiding that warning. > >Signed-off-by: Arnd Bergmann >Acked-by: Jiri Pirko >Fixes: eda6500a987a "mlxsw: Add PCI bus implementation" >--- >I've kept Jiri's Ack despite having in effect a completely different >pat

Re: [PATCH net-next 0/3] net: remove dsa.h from netdevice.h

2015-10-07 Thread Jiri Pirko
Tue, Oct 06, 2015 at 11:54:24PM CEST, vivien.dide...@savoirfairelinux.com wrote: >In order to push switchdev objects down to DSA drivers, I need to include >switchdev.h in dsa.h. But compilation fails because of a circular dependency >issue, since dsa.h is also included in linux/netdevice.h. > >dsa

  1   2   3   4   5   6   >