Re: [PATCH v2 10/15] scsi: pm_8001: use generic power management

On Mon, Jul 20, 2020 at 3:38 PM Vaibhav Gupta wrote: > > With legacy PM, drivers themselves were responsible for managing the > device's power states and takes care of register states. > > After upgrading to the generic structure, PCI core will take care of > required tasks and drivers should do o

Re: [PATCH v2 10/24] scsi: pm8001: pm8001_ctl: Provide descriptions for the many undocumented 'attr's

On Mon, Jul 13, 2020 at 10:00 AM Lee Jones wrote: > > ... even if they are completely unused. > > Fixes the following W=1 kernel build warning(s): > > drivers/scsi/pm8001/pm8001_ctl.c:56: warning: Function parameter or member > 'attr' not described in 'pm8001_ctl_mpi_interface_rev_show' > drive

Re: [PATCH] block/rnbd: send_msg_close if any error occurs after send_msg_open

On Fri, Sep 18, 2020 at 9:24 AM Gioh Kim wrote: > > From: Gioh Kim > > After send_msg_open is done, send_msg_close should be done > if any error occurs and it is necessary to recover > what has been done. > > Signed-off-by: Gioh Kim Looks good to me! Thanks! Acked-by: Jack Wang > --- > drivers

[RFC] pcie hotplug doesn't work with kernel 4.19

ENERIC=m CONFIG_HOTPLUG_PCI_SHPC=y CONFIG_HOTPLUG_PCI_PCIE=y Thanks in advance! -- Jinpu Wang Linux Kernel Developer Application Support (IONOS Cloud) 1&1 IONOS SE | Greifswalder Str. 207 | 10405 Berlin | Germany Phone: E-mail: jinpu.w...@cloud.ionos.com | Web: www.ionos.de Hauptsi

Re: [RFC] pcie hotplug doesn't work with kernel 4.19

Hi Lukas, see reply below On Wed, Sep 16, 2020 at 7:48 AM Lukas Wunner wrote: > > On Tue, Sep 15, 2020 at 04:15:15PM +0200, Jinpu Wang wrote: > > We are testing PCIe nvme SSD hotplug, it works out of box with kernel > > 5.4.62, > > dmesg during the hotplug: > [...] &

Re: [PATCH 4.14 067/115] crypto: testmgr - add AES-CFB tests

Hi Greg, This patch causes build failure for me: In file included from crypto/testmgr.c:54: crypto/testmgr.h:16081:4: error: 'const struct cipher_testvec' has no member named 'ptext' .ptext = "\x6b\xc1\xbe\xe2\x2e\x40\x9f\x96" ^ crypto/testmgr.h:16089:4: error: 'const struct cipher_tes

Re: [PATCH 4.14 067/115] crypto: testmgr - add AES-CFB tests

snip > > > > Can you drop the patch? > > Yes, now dropped. Sasha, I think I did this same thing in the past :) Thanks, I remember I probably reported same thing in the past too :) Jack

[BUG] divide error select_idle_sibling+0x36b

le due to clocksource watchdog [14792.092598] TSC found unstable after boot, most likely due to broken BIOS. Use 'tsc=unstable'. [14791.924432] sched_clock: Marking unstable (14792681905573, -589293039)<-(14792645239415, -552646967) [14792.093494] clocksource: Switched to clocksource

Re: [BUG] divide error select_idle_sibling+0x36b

Hi Peter, On Tue, Jun 16, 2020 at 3:15 PM Peter Zijlstra wrote: > > On Tue, Jun 16, 2020 at 03:07:00PM +0200, Jinpu Wang wrote: > > > [7623813.970839] CPU: 10 PID: 46544 Comm: qemu-2.7 Tainted: G > > O4.14.154-1-pserver #4.14.154-1.1~deb9 > > Please try on a kerne

Re: [PATCH 6/6] scsi: pm8001: remove the SAS host after the SCSI host

On Wed, Mar 29, 2017 at 11:41 AM, Johannes Thumshirn wrote: > After commit bcdde7e ("sysfs: make __sysfs_remove_dir() recursive") changed > the > removal path of kernfs to make it recursive we have to remove the SAS host > before the SCSI host or we will see sysfs warnings on not found sysfs grou

Re: [PATCH 1/2] scsi: sas: flush destruct workqueue on device unregister

On Wed, Mar 29, 2017 at 2:26 PM, Johannes Thumshirn wrote: > On Wed, Mar 29, 2017 at 12:53:28PM +0100, John Garry wrote: >> On 29/03/2017 12:29, Johannes Thumshirn wrote: >> >On Wed, Mar 29, 2017 at 12:15:44PM +0100, John Garry wrote: >> >>On 29/03/2017 10:41, Johannes Thumshirn wrote: >> >>>In th

Re: [PATCH] scsi: sas: move scsi_remove_host call into sas_remove_host

ysfs behaviour > from commit bcdde7e ("sysfs: make __sysfs_remove_dir() recursive"). > > Signed-off-by: Johannes Thumshirn > Suggested-by: Christoph Hellwig > Cc: Hannes Reinecke > Cc: James Bottomley > Cc: Jinpu Wang > Cc: John Garry > --- > drivers/scsi/a

Re: [PATCH 4.4 25/26] blk: Ensure users for current->bio_list can see the full list.

On Thu, Apr 6, 2017 at 8:17 PM, Ben Hutchings wrote: > On Thu, 2017-04-06 at 10:38 +0200, Greg Kroah-Hartman wrote: >> 4.4-stable review patch. If anyone has any objections, please let me know. >> >> -- >> >> From: NeilBrown >> >> commit f5fe1b51905df7cfe4fdfd85c5fb7bc5b71a094f u

Re: [PATCH 4.4 25/26] blk: Ensure users for current->bio_list can see the full list.

Hi Ben, On Fri, Apr 7, 2017 at 2:45 PM, Ben Hutchings wrote: > On Fri, 2017-04-07 at 10:33 +0200, Jinpu Wang wrote: >> On Thu, Apr 6, 2017 at 8:17 PM, Ben Hutchings >> wrote: >> > On Thu, 2017-04-06 at 10:38 +0200, Greg Kroah-Hartman wrote: >> >> 4.4-sta

Re: [PATCH 04/29] scsi: pm8001: constify pci_device_id.

On Sun, Jul 30, 2017 at 10:37 AM, Arvind Yadav wrote: > pci_device_id are not supposed to change at runtime. All functions > working with pci_device_id provided by work with > const pci_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav > --- > drivers/scsi/pm800

Re: scsi: pm8001: fix double free in pm8001_pci_probe

On Tue, Aug 8, 2017 at 1:40 PM, Pan Bian wrote: > In function pm8001_pci_probe(), on errors that the control flow jumps to > label err_out_ha_free, function pm8001_free() is called. In pm8001_free(), > scsi_host_put() is called to release shost, which keeps the return value > of scsi_host_alloc().

Re: scsi: mvsas: replace kfree with scsi_host_put

On Tue, Aug 8, 2017 at 2:02 PM, Pan Bian wrote: > The return value of scsi_host_alloc() should be released by > scsi_host_put(). However, in function mvs_pci_init(), kfree() > is used. This patch replaces kfree() with scsi_host_put() to avoid > possible memory leaks. > > Signed-off-by: Pan Bian >

<    1   2