Re: [PATCH v3 1/2] tpm: Use GFP_KERNEL for allocating struct tpm_buf

2019-10-07 Thread Jerry Snitselaar
. Fixes: a74f8b36352e (tpm: introduce tpm_buf) Signed-off-by: James Bottomley --- Reviewed-by: Jerry Snitselaar

Re: [PATCH] tpm: add check after commands attribs tab allocation

2019-10-07 Thread Jerry Snitselaar
&chip->dev, 4, nr_commands, GFP_KERNEL); + if (!chip->cc_attrs_tbl) { + rc = -ENOMEM; + goto out; + } rc = tpm_buf_init(&buf, TPM2_ST_NO_SESSIONS, TPM2_CC_GET_CAPABILITY); if (rc) Reviewed-by: Jerry Snitselaar

Re: [PATCH 0/2] iommu/vt-d: Select PCI_PRI for INTEL_IOMMU_SVM

2019-10-09 Thread Jerry Snitselaar
files changed, 31 insertions(+), 36 deletions(-) -- 2.23.0.581.g78d2f28ef7-goog ___ iommu mailing list io...@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu Reviewed-by: Jerry Snitselaar

Re: [PATCH v3 2/2] tpm: Detach page allocation from tpm_buf

2019-10-04 Thread Jerry Snitselaar
On Fri Oct 04 19, James Bottomley wrote: On Fri, 2019-10-04 at 13:37 -0400, Mimi Zohar wrote: On Fri, 2019-10-04 at 09:37 -0700, James Bottomley wrote: > On Thu, 2019-10-03 at 21:51 +0300, Jarkko Sakkinen wrote: > > As has been seen recently, binding the buffer allocation and > > tpm_buf > > tog

Re: [PATCH] KEYS: asym_tpm: Switch to get_random_bytes()

2019-10-04 Thread Jerry Snitselaar
On Fri Oct 04 19, Jerry Snitselaar wrote: On Fri Oct 04 19, James Bottomley wrote: On Fri, 2019-10-04 at 11:33 -0700, Jerry Snitselaar wrote: On Fri Oct 04 19, James Bottomley wrote: On Fri, 2019-10-04 at 21:22 +0300, Jarkko Sakkinen wrote: > On Thu, Oct 03, 2019 at 04:59:37PM -0700, Ja

Re: [PATCH] efi/tpm: fix section mismatch warning

2020-04-30 Thread Jerry Snitselaar
On Wed Apr 29 20, Arnd Bergmann wrote: Building with gcc-10 causes a harmless warning about a section mismatch: WARNING: modpost: vmlinux.o(.text.unlikely+0x5e191): Section mismatch in reference from the function tpm2_calc_event_log_size() to the function .init.text:early_memunmap() The functi

Re: [PATCH] efi/tpm: fix section mismatch warning

2020-04-30 Thread Jerry Snitselaar
On Thu Apr 30 20, Ard Biesheuvel wrote: On Thu, 30 Apr 2020 at 23:21, Arnd Bergmann wrote: On Thu, Apr 30, 2020 at 11:15 PM Jerry Snitselaar wrote: > > On Wed Apr 29 20, Arnd Bergmann wrote: > >Building with gcc-10 causes a harmless warning about a section mismatch: > > &

Re: [Patch v7 0/4] Create and consolidate trusted keys subsystem

2019-10-11 Thread Jerry Snitselaar
On Fri Oct 11 19, Jarkko Sakkinen wrote: On Mon, Oct 07, 2019 at 10:55:31AM +0530, Sumit Garg wrote: This patch-set does restructuring of trusted keys code to create and consolidate trusted keys subsystem. Also, patch #2 replaces tpm1_buf code used in security/keys/trusted.c and crypto/asymmert

Re: [PATCH -next] iommu/amd: fix a warning in increase_address_space

2019-10-16 Thread Jerry Snitselaar
On Wed Oct 16 19, Qian Cai wrote: After the commit 754265bcab78 ("iommu/amd: Fix race in increase_address_space()"), it could still possible trigger a race condition under some heavy memory pressure below. The race to trigger a warning is, CPU0: CPU1: in alloc_pte():

Re: [PATCH] iommu/amd: Check PM_LEVEL_SIZE() condition in locked section

2019-10-18 Thread Jerry Snitselaar
On Fri Oct 18 19, Joerg Roedel wrote: On Thu, Oct 17, 2019 at 07:36:51AM -0400, Qian Cai wrote: > On Oct 16, 2019, at 6:59 PM, Jerry Snitselaar wrote: > > I guess the mode level 6 check is really for other potential callers > increase_address_space, none exist at the mom

[PATCH] MAINTAINERS: add linux-security-module mailing list to TPM drivers

2019-02-19 Thread Jerry Snitselaar
I've seen requests to add linux-security-module to tpm patch submissions a couple of times recently, so just add the list to MAINTAINERS so get_maintainers.pl will mention it. Cc: Peter Huewe Cc: Jarkko Sakkinen Cc: Jason Gunthorpe Signed-off-by: Jerry Snitselaar --- MAINTAINERS | 1

Re: [PATCH] MAINTAINERS: add linux-security-module mailing list to TPM drivers

2019-02-20 Thread Jerry Snitselaar
On Wed Feb 20 19, Jarkko Sakkinen wrote: On Tue, Feb 19, 2019 at 08:58:46PM -0700, Jerry Snitselaar wrote: I've seen requests to add linux-security-module to tpm patch submissions a couple of times recently, so just add the list to MAINTAINERS so get_maintainers.pl will mention it. Cc:

Re: [PATCH] MAINTAINERS: add linux-security-module mailing list to TPM drivers

2019-02-20 Thread Jerry Snitselaar
On Thu Feb 21 19, James Morris wrote: On Wed, 20 Feb 2019, Jarkko Sakkinen wrote: > being cc'd to linux-security-module? Looking back at > recent patches, it looked like it was a general request. > If it is, I'll be more likely to remember if get_maintainers.pl > brings it up. :) I'm all open

Re: [PATCH v2] tpm/tpm_crb: Avoid unaligned reads in crb_recv()

2019-02-07 Thread Jerry Snitselaar
On Thu Feb 07 19, Sasha Levin wrote: Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: 30fc8d138e91 tpm: TPM 2.0 CRB Interface. The bot has tested the following trees: v4.20.6, v4.19.19, v4.14.97, v4.9.154, v4.4.172. v4.20.6: B

Re: [PATCH v11 15/16] tpm: take TPM chip power gating out of tpm_transmit()

2019-02-07 Thread Jerry Snitselaar
tpm_vtpm_proxy a locality change requires a virtual TPM command (a command made up just for that driver). The consequence of this is that this commit removes the remaining nested calls. Signed-off-by: Jarkko Sakkinen Reviewed-by: Stefan Berger Tested-by: Stefan Berger Reviewed-by: Jerry

Re: [PATCH v4 1/2] tpm: Unify the send callback behaviour

2019-02-09 Thread Jerry Snitselaar
On Fri Feb 08 19, Jarkko Sakkinen wrote: The send() callback should never return length as it does not in every driver except tpm_crb in the success case. The reason is that the main transmit functionality only cares about whether the transmit was successful or not and ignores the count completel

Re: [PATCH v4 1/2] tpm: Unify the send callback behaviour

2019-02-09 Thread Jerry Snitselaar
On Sat, Feb 9, 2019 at 11:20 AM Jerry Snitselaar wrote: > > On Fri Feb 08 19, Jarkko Sakkinen wrote: > >The send() callback should never return length as it does not in every > >driver except tpm_crb in the success case. The reason is that the main > >transmit functi

Re: [PATCH v4 0/2] tpm: Unify send() callbacks

2019-02-09 Thread Jerry Snitselaar
+- drivers/char/tpm/tpm_nsc.c | 2 +- drivers/char/tpm/tpm_tis_core.c | 2 +- drivers/char/tpm/tpm_vtpm_proxy.c| 3 +-- drivers/char/tpm/xen-tpmfront.c | 2 +- 11 files changed, 22 insertions(+), 15 deletions(-) -- 2.19.1 Reviewed-by: Jerry Snitselaar

[PATCH] iommu/amd: print reason for iommu_map_page failure in map_sg

2019-01-28 Thread Jerry Snitselaar
Since there are multiple possible failures in iommu_map_page it would be useful to know which case is being hit when the error message is printed in map_sg. While here, fix up checkpatch complaint about using function name in a string instead of __func__. Cc: Joerg Roedel Signed-off-by: Jerry

[PATCH] tpm: don't print error message in tpm_transmit_cmd when tpm still testing

2019-01-29 Thread Jerry Snitselaar
TPM2_RC_TESTING is the return code. Cc: Peter Huewe Cc: Jarkko Sakkinen Cc: Jason Gunthorpe Signed-off-by: Jerry Snitselaar --- drivers/char/tpm/tpm-interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c index

[PATCH] iommu: amd: call free_iova_fast with pfn in map_sg

2019-01-17 Thread Jerry Snitselaar
In the error path of map_sg, free_iova_fast is being called with address instead of the pfn. This results in a bad value getting into the rcache, and can result in hitting a BUG_ON when iova_magazine_free_pfns is called. Cc: Joerg Roedel Cc: Suravee Suthikulpanit Signed-off-by: Jerry Snitselaar

Question about out_unmap section of map_sg in amd_iommu.c

2019-01-18 Thread Jerry Snitselaar
out_unmap: pr_err("%s: IOMMU mapping error in map_sg (io-pages: %d)\n", dev_name(dev), npages); for_each_sg(sglist, s, nelems, i) { int j, pages = iommu_num_pages(sg_phys(s), s->length, PAGE_SIZE); for (j = 0; j < pages; ++

Re: [PATCH] iommu: amd: call free_iova_fast with pfn in map_sg

2019-01-19 Thread Jerry Snitselaar
On Thu Jan 17 19, Jerry Snitselaar wrote: In the error path of map_sg, free_iova_fast is being called with address instead of the pfn. This results in a bad value getting into the rcache, and can result in hitting a BUG_ON when iova_magazine_free_pfns is called. Cc: Joerg Roedel Cc: Suravee

[PATCH] iommu/amd: unmap all mapped pages in error path of map_sg

2019-01-19 Thread Jerry Snitselaar
page. Fix the condition, so it breaks out of the loop only after all the mapped pages have been unmapped. Fixes: 80187fd39dcb ("iommu/amd: Optimize map_sg and unmap_sg") Cc: Joerg Roedel Signed-off-by: Jerry Snitselaar --- drivers/iommu/amd_iommu.c | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH] tpm/tpm_crb: Avoid unaligned reads in crb_recv():

2019-02-01 Thread Jerry Snitselaar
. Cc: sta...@vger.kernel.org Cc: Linus Torvalds Cc: James Morris Cc: Tomas Winkler Cc: Jerry Snitselaar Fixes: 30fc8d138e91 ("tpm: TPM 2.0 CRB Interface") Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm_crb.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/driver

[PATCH] tpm_tis: verify locality released before returning from release_locality

2018-05-05 Thread Jerry Snitselaar
Sakkinen Cc: Peter Huewe Cc: Jason Gunthorpe Reported-by: Laurent Bigonville Signed-off-by: Jerry Snitselaar --- drivers/char/tpm/tpm_tis_core.c | 47 - 1 file changed, 46 insertions(+), 1 deletion(-) diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers

Re: [PATCH] tpm_tis: verify locality released before returning from release_locality

2018-05-05 Thread Jerry Snitselaar
On Sat May 05 18, Jerry Snitselaar wrote: For certain tpm chips releasing locality can take long enough that a subsequent call to request_locality will see the locality as being active when the access register is read in check_locality. So check that the locality has been released before

Re: [PATCH v4 05/22] iommu: introduce iommu invalidate API function

2018-05-05 Thread Jerry Snitselaar
On Mon Apr 16 18, Jacob Pan wrote: From: "Liu, Yi L" When an SVM capable device is assigned to a guest, the first level page tables are owned by the guest and the guest PASID table pointer is linked to the device context entry of the physical IOMMU. Host IOMMU driver has no knowledge of cachin

ima and tpm2.0

2016-06-08 Thread Jerry Snitselaar
Should the ima Kconfig have a select line for tpm_crb similar to the tpm_tis and tpm_ibmvtpm bits?

Re: [PATCH v3] tpm_crb: request and relinquish locality 0

2017-03-17 Thread Jerry Snitselaar
Jarkko Sakkinen @ 2017-03-16 11:55 GMT: > On Wed, Mar 15, 2017 at 08:27:54PM -0700, Jerry Snitselaar wrote: >> >> Jerry Snitselaar @ 2017-03-16 02:38 GMT: >> >> > Jarkko Sakkinen @ 2017-03-15 05:57 GMT: >> > >> >> From: Jarkko Sakkinen >

[PATCH] tpm: make check_locality return bool

2017-03-18 Thread Jerry Snitselaar
Since check_locality is checking to see if a certain locality is active, return true if active otherwise return false. Cc: Christophe Ricard Cc: Jason Gunthorpe Cc: Marcel Selhorst Cc: Jarkko Sakkinen Cc: Peter Huewe Signed-off-by: Jerry Snitselaar --- Tested tpm_tis, but don't hav

Re: [PATCH v4] tpm_crb: request and relinquish locality 0

2017-03-24 Thread Jerry Snitselaar
sure that the driver > will work properly with Intel TXT that uses locality 2. There's no > explicit guarantee that it would relinquish this locality. In more > general sense this commit enables tpm_crb to be a well behaving > citizen in a multi locality environment. > > Signe

Re: [PATCH v4] tpm_crb: request and relinquish locality 0

2017-03-25 Thread Jerry Snitselaar
Jarkko Sakkinen @ 2017-03-24 10:19 GMT: > On Fri, Mar 24, 2017 at 12:10:30PM +0200, Jarkko Sakkinen wrote: >> This commit adds support for requesting and relinquishing locality 0 in >> tpm_crb for the course of command transmission. >> >> In order to achieve this, two new callbacks are added to

[RFC PATCH 1/1] tpm_tis: convert to using locality callbacks

2017-03-25 Thread Jerry Snitselaar
request_locality prior to tpm_tis_send_data calls. Also drop release_locality call in middleof probe_itpm, and keep locality until release_locality called at end of probe_itpm. Cc: Peter Huewe Cc: Jarkko Sakkinen Cc: Jason Gunthorpe Cc: Marcel Selhorst Signed-off-by: Jerry Snitselaar

[RFC PATCH 0/1] tpm_tis: convert to use locality callbacks

2017-03-25 Thread Jerry Snitselaar
This is an attempt to convert tpm_tis over to using the locality callbacks added by Jarkko's tpm_crb patch. Requires the patch currently on tpmdd/locality which has moved the need_locality assignment inside the mutex in tpm_transmit. This is pretty much the same as Jarkko's earlier patch (I think)

Re: [PATCH v4] tpm_crb: request and relinquish locality 0

2017-03-26 Thread Jerry Snitselaar
- Original Message - > From: "Jarkko Sakkinen" > To: "Jerry Snitselaar" , "gang wei" > Cc: "Jarkko Sakkinen" , > tpmdd-de...@lists.sourceforge.net, > linux-security-mod...@vger.kernel.org, "Peter Huewe" , > &quo

Re: [RFC PATCH 1/1] tpm_tis: convert to using locality callbacks

2017-03-26 Thread Jerry Snitselaar
- Original Message - > From: "Jason Gunthorpe" > To: "Jerry Snitselaar" > Cc: tpmdd-de...@lists.sourceforge.net, linux-kernel@vger.kernel.org, "Peter > Huewe" , "Jarkko > Sakkinen" , "Marcel Selhorst" > > Sent: S

Re: [PATCH v4] tpm_crb: request and relinquish locality 0

2017-03-26 Thread Jerry Snitselaar
Jarkko Sakkinen @ 2017-03-26 19:51 GMT: > WTF, I applied old patch version by mistake. Sorry about that and > thanks for spotting that out. Better? > > /Jarkko Looks good now.

[PATCH v2] tpm_tis: convert to using locality callbacks

2017-03-27 Thread Jerry Snitselaar
request_locality prior to tpm_tis_send_data calls. Also drop release_locality call in middleof probe_itpm, and keep locality until release_locality called at end of probe_itpm. Cc: Peter Huewe Cc: Jarkko Sakkinen Cc: Jason Gunthorpe Cc: Marcel Selhorst Signed-off-by: Jerry Snitselaar --- v2

Re: [PATCH v3] tpm_crb: request and relinquish locality 0

2017-03-15 Thread Jerry Snitselaar
Jarkko Sakkinen @ 2017-03-15 05:57 GMT: > From: Jarkko Sakkinen > > This commit adds support for requesting and relinquishing locality 0 in > tpm_crb for the course of command transmission. > > In order to achieve this, two new callbacks are added to struct > tpm_class_ops: > > - request_localit

Re: [PATCH v3] tpm_crb: request and relinquish locality 0

2017-03-15 Thread Jerry Snitselaar
Jerry Snitselaar @ 2017-03-16 02:38 GMT: > Jarkko Sakkinen @ 2017-03-15 05:57 GMT: > >> From: Jarkko Sakkinen >> >> This commit adds support for requesting and relinquishing locality 0 in >> tpm_crb for the course of command transmission. >> >> In or

[PATCH] tpm_crb: check for bad response size

2017-03-10 Thread Jerry Snitselaar
Make sure size of response buffer is at least 6 bytes, or we will underflow and pass large size_t to memcpy_fromio(). This was encountered while testing earlier version of locality patchset. Fixes: 30fc8d138e912 ("tpm: TPM 2.0 CRB Interface") Signed-off-by: Jerry Snitselaar --- driver

Re: [PATCH v2] tpm_crb: request and relinquish locality 0

2017-03-12 Thread Jerry Snitselaar
Jarkko Sakkinen @ 2017-03-11 13:02 GMT: > Added two new callbacks to struct tpm_class_ops: > > - request_locality > - relinquish_locality > > These are called before sending and receiving data from the TPM. We > update also tpm_tis_core to use these callbacks. Small modification to > request_loc

Re: [PATCH v3 0/3] Locality support for tpm_crb

2017-03-03 Thread Jerry Snitselaar
+ > 1 file changed, 137 insertions(+), 48 deletions(-) Reviewed-by: Jerry Snitselaar

Re: [PATCH] dma: remove bad_dma_ops to fix build fail

2016-06-12 Thread Jerry Snitselaar
On Sun Jun 12 16, Sudip Mukherjee wrote: m32r allmodconfig is failng with errors like: ERROR: "bad_dma_ops" [sound/soc/bcm/snd-soc-cygnus.ko] undefined! On checking the code it turns out that struct bad_dma_ops has been declared as extern but no one has actually defined struct bad_dma_ops. Lets

Re: [PATCH] tpm: Define TPM2_SPACE_BUFFER_SIZE to replace the use of PAGE_SIZE

2020-07-02 Thread Jerry Snitselaar
Jarkko Sakkinen Reviewed-by: Jerry Snitselaar --- v2: Also use the new buffer size for chip->work_buffer (reported by stefanb) drivers/char/tpm/tpm-chip.c | 9 ++--- drivers/char/tpm/tpm.h| 5 - drivers/char/tpm/tpm2-space.c | 26 -- drivers/char/tpm

Re: [PATCH v2] tpm_tis: Remove the HID IFX0102

2020-06-24 Thread Jerry Snitselaar
IS driver by mistake. Fixes: 93e1b7d42e1e ("[PATCH] tpm: add HID module parameter") Link: https://bugzilla.kernel.org/show_bug.cgi?id=203877 Cc: Kylene Jo Hall Reported-by: Ferry Toth: Signed-off-by: Jarkko Sakkinen Reviewed-by: Jerry Snitselaar

Re: [PATCH v2] tpm_tis: Remove the HID IFX0102

2020-06-25 Thread Jerry Snitselaar
On Fri Jun 26 20, Jarkko Sakkinen wrote: On Wed, Jun 24, 2020 at 11:21:50PM -0700, Jerry Snitselaar wrote: On Thu Jun 25 20, Jarkko Sakkinen wrote: > Acer C720 running Linux v5.3 reports this in klog: > > tpm_tis: 1.2 TPM (device-id 0xB, rev-id 16) > tpm tpm0: tpm_try_transmit: send

Re: [PATCH v2] tpm: tpm2-space: Resize session and context buffers dynamically

2020-06-25 Thread Jerry Snitselaar
On Thu Jun 25 20, Jarkko Sakkinen wrote: Re-allocate context and session buffers when needed. Scale them in page increments so that the reallocation is only seldomly required, and thus causes minimal stress to the system. Add a static maximum limit of four pages for buffer sizes. Cc: James Botto

Re: [PATCH 00/13] iommu: Remove usage of dev->archdata.iommu

2020-06-25 Thread Jerry Snitselaar
/s5p-mfc/s5p_mfc_iommu.h| 4 +++- 17 files changed, 64 insertions(+), 71 deletions(-) -- 2.27.0 Reviewed-by: Jerry Snitselaar

Re: [PATCH 1/1] iommu/vt-d: Fix misuse of iommu_domain_identity_map()

2020-06-18 Thread Jerry Snitselaar
d-by: Alex Williamson Signed-off-by: Lu Baolu Reviewed-by: Jerry Snitselaar

Re: [PATCHv2] tpm: ibmvtpm: Wait for ready buffer before probing for TPM2 attributes

2020-06-18 Thread Jerry Snitselaar
lization, which will ensure the buffer is allocated. Fixes: 18b3670d79ae9 ("tpm: ibmvtpm: Add support for TPM2") Signed-off-by: David Gibson --- Reviewed-by: Jerry Snitselaar Changes from v1: * Fixed a formatting error in the commit message * Added some more detail to the commit

[PATCH 2/2] iommu/amd: Move Kconfig and Makefile bits down into amd directory

2020-06-12 Thread Jerry Snitselaar
Move AMD Kconfig and Makefile bits down into the amd directory with the rest of the AMD specific files. Cc: Joerg Roedel Cc: Suravee Suthikulpanit Signed-off-by: Jerry Snitselaar --- drivers/iommu/Kconfig | 45 +- drivers/iommu/Makefile | 5

[PATCH 1/2] iommu/vt-d: Move Kconfig and Makefile bits down into intel directory

2020-06-12 Thread Jerry Snitselaar
Move Intel Kconfig and Makefile bits down into intel directory with the rest of the Intel specific files. Cc: Joerg Roedel Cc: Lu Baolu Signed-off-by: Jerry Snitselaar --- drivers/iommu/Kconfig| 86 +--- drivers/iommu/Makefile | 8 +--- drivers

[PATCH 0/2] iommu: Move AMD and Intel Kconfig + Makefile bits into their directories

2020-06-12 Thread Jerry Snitselaar
This patchset imeplements the suggestion from Linus to move the Kconfig and Makefile bits for AMD and Intel into their respective directories. It also cleans up a couple Kconfig entries to use the newer help attribute instead of ---help--- (complaint from checkpatch). Jerry Snitselaar (2

Re: [PATCH v2 00/33] iommu: Move iommu_group setup to IOMMU core code

2020-05-29 Thread Jerry Snitselaar
On Tue Apr 14 20, Joerg Roedel wrote: Hi, here is the second version of this patch-set. The first version with some more introductory text can be found here: https://lore.kernel.org/lkml/20200407183742.4344-1-j...@8bytes.org/ Changes v1->v2: * Rebased to v5.7-rc1 * Re

Re: [PATCH v2 00/33] iommu: Move iommu_group setup to IOMMU core code

2020-06-02 Thread Jerry Snitselaar
On Tue Jun 02 20, Joerg Roedel wrote: Hi Jerry, On Mon, Jun 01, 2020 at 05:02:36PM -0700, Jerry Snitselaar wrote: Yeah, that will solve the panic. If you still see the kdump faults, can you please try with the attached diff? I was not able to reproduce them in my setup. Regards

Re: [PATCH v2 00/33] iommu: Move iommu_group setup to IOMMU core code

2020-06-02 Thread Jerry Snitselaar
On Tue Jun 02 20, Jerry Snitselaar wrote: On Tue Jun 02 20, Joerg Roedel wrote: Hi Jerry, On Mon, Jun 01, 2020 at 05:02:36PM -0700, Jerry Snitselaar wrote: Yeah, that will solve the panic. If you still see the kdump faults, can you please try with the attached diff? I was not able to

Re: [PATCH 0/2] iommu: Move Intel and AMD drivers into their own subdirectory

2020-06-03 Thread Jerry Snitselaar
el-pasid.c => intel/pasid.c} (100%) rename drivers/iommu/{intel-svm.c => intel/svm.c} (100%) rename drivers/iommu/{intel-trace.c => intel/trace.c} (100%) -- 2.17.1 Reviewed-by: Jerry Snitselaar

Re: [PATCH 0/2] iommu: Move Intel and AMD drivers into their own subdirectory

2020-06-03 Thread Jerry Snitselaar
On Thu Jun 04 20, Lu Baolu wrote: Hi Joerg, On 6/2/20 5:26 PM, Joerg Roedel wrote: Hi, two small patches to move the Intel and AMD IOMMU drivers into their own subdirectory under drivers/iommu/ to make the file structure a bit less cluttered. Does the MAINTAINERS file need to update? Best

[PATCH] iommu: Don't attach deferred device in iommu_group_do_dma_attach

2020-06-04 Thread Jerry Snitselaar
Attaching a deferred device should be delayed until dma api is called. Cc: io...@lists.linux-foundation.org Suggested-by: Joerg Roedel Signed-off-by: Jerry Snitselaar --- If you already have thrown a patch together, then ignore this. Also feel free to swap out the signed-off-by with your&#

[PATCH] iommu: add include/uapi/linux/iommu.h to MAINTAINERS file

2020-06-05 Thread Jerry Snitselaar
When include/uapi/linux/iommu.h was created it was never added to the file list in MAINTAINERS. Cc: Joerg Roedel Signed-off-by: Jerry Snitselaar --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index e1897ed32930..061648b6e393 100644 --- a

amd kdump failure with iommu=nopt

2020-05-13 Thread Jerry Snitselaar
We've seen kdump failures with recent kernels (5.5, 5.6, 5.7-rc1) on amd systems when iommu is enabled in translation mode. In the cases so far there has been mpt3sas involved, but I'm also seeing io page faults for ahci right before mpt3sas has an io page fault: [ 15.156620] ahci :63:00.0:

Re: amd kdump failure with iommu=nopt

2020-05-14 Thread Jerry Snitselaar
ach_deferred(domain, dev)) + __iommu_attach_device_no_defer(domain, dev); + + return domain; } /* ___ iommu mailing list io...@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu Yes, that works. Tested-by: Jerry Snitselaar

Re: [PATCH] ima: Remove __init annotation from ima_pcrread()

2020-06-07 Thread Jerry Snitselaar
t;ima: Call ima_calc_boot_aggregate() in ima_eventdigest_init()") Reported-by: Linus Torvalds Signed-off-by: Roberto Sassu Reviewed-by: Jerry Snitselaar --- security/integrity/ima/ima_crypto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/security/integrity/im

[PATCH] tpm_tis: Disable interrupts on ThinkPad T490s

2020-10-15 Thread Jerry Snitselaar
omley Signed-off-by: Jerry Snitselaar --- drivers/char/tpm/tpm_tis.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c index 0b214963539d..4ed6e660273a 100644 --- a/drivers/char/tpm/tpm_tis.c

Re: [PATCH] tpm_tis: Disable interrupts on ThinkPad T490s

2020-10-15 Thread Jerry Snitselaar
James should this get tacked on the end of your patchset? Regards, Jerry

Re: [PATCH v2 0/2] iommu: Move AMD and Intel Kconfig + Makefile bits into their directories

2020-07-27 Thread Jerry Snitselaar
Jerry Snitselaar @ 2020-06-30 13:06 MST: > This patchset imeplements the suggestion from Linus to move the > Kconfig and Makefile bits for AMD and Intel into their respective > directories. > > v2: Rebase against v5.8-rc3. Dropped ---help--- changes from Kconfig as that > wa

Re: [PATCH] Revert commit e918e570415c ("tpm_tis: Remove the HID IFX0102")

2020-07-06 Thread Jerry Snitselaar
eter"). > > Fixes: e918e570415c ("tpm_tis: Remove the HID IFX0102") > Reported-by: Peter Huewe > Signed-off-by: Jarkko Sakkinen Reviewed-by: Jerry Snitselaar > --- > drivers/char/tpm/tpm_tis.c | 8 > 1 file changed, 8 insertions(+) > > diff --gi

Re: [PATCH v9 1/2] acpi: Extend TPM2 ACPI table with missing log fields

2020-07-06 Thread Jerry Snitselaar
sion 1.2, Revision 8 > > https://trustedcomputinggroup.org/wp-content/uploads/TCG_ACPIGeneralSpecification_v1.20_r8.pdf > > Signed-off-by: Stefan Berger > Cc: linux-a...@vger.kernel.org > Acked-by: Rafael J. Wysocki > Reviewed-by: Jarkko Sakkinen Reviewed-by: Jerry Snits

Re: [PATCH v9 2/2] tpm: Add support for event log pointer found in TPM2 ACPI table

2020-07-06 Thread Jerry Snitselaar
s SeaBIOS, to pass an event log when using a TPM2. > > Signed-off-by: Stefan Berger Reviewed-by: Jerry Snitselaar > --- > drivers/char/tpm/eventlog/acpi.c | 63 +--- > 1 file changed, 42 insertions(+), 21 deletions(-) > > diff --git a/drivers/cha

Re: [PATCH v9 2/2] tpm: Add support for event log pointer found in TPM2 ACPI table

2020-07-06 Thread Jerry Snitselaar
Jarkko Sakkinen @ 2020-07-06 16:09 MST: > On Mon, Jul 06, 2020 at 02:19:53PM -0400, Stefan Berger wrote: >> From: Stefan Berger >> >> In case a TPM2 is attached, search for a TPM2 ACPI table when trying >> to get the event log from ACPI. If one is found, use it to get the >> start and length o

kdump boot failing with IVRS checksum failure

2020-09-21 Thread Jerry Snitselaar
Hello Joerg, We are seeing a kdump kernel boot failure in test on an HP DL325 Gen10 and it was tracked down to 387caf0b759a ("iommu/amd: Treat per-device exclusion ranges as r/w unity-mapped regions"). Reproduced on 5.9-rc5 and goes away with revert of the commit. There is a follow on commit tha

Re: [PATCH v2] tpm_tis: Remove the HID IFX0102

2020-06-30 Thread Jerry Snitselaar
On Fri Jun 26 20, Jarkko Sakkinen wrote: On Thu, Jun 25, 2020 at 02:19:23PM -0700, Jerry Snitselaar wrote: On Fri Jun 26 20, Jarkko Sakkinen wrote: > On Wed, Jun 24, 2020 at 11:21:50PM -0700, Jerry Snitselaar wrote: > > On Thu Jun 25 20, Jarkko Sakkinen wrote: > > > Acer C720

[PATCH v2 2/2] iommu/amd: Move Kconfig and Makefile bits down into amd directory

2020-06-30 Thread Jerry Snitselaar
Move AMD Kconfig and Makefile bits down into the amd directory with the rest of the AMD specific files. Cc: Joerg Roedel Cc: Suravee Suthikulpanit Signed-off-by: Jerry Snitselaar --- drivers/iommu/Kconfig | 45 +- drivers/iommu/Makefile | 5

[PATCH v2 1/2] iommu/vt-d: Move Kconfig and Makefile bits down into intel directory

2020-06-30 Thread Jerry Snitselaar
Move Intel Kconfig and Makefile bits down into intel directory with the rest of the Intel specific files. Cc: Joerg Roedel Cc: Lu Baolu Signed-off-by: Jerry Snitselaar --- drivers/iommu/Kconfig| 86 +--- drivers/iommu/Makefile | 8 +--- drivers

[PATCH v2 0/2] iommu: Move AMD and Intel Kconfig + Makefile bits into their directories

2020-06-30 Thread Jerry Snitselaar
This patchset imeplements the suggestion from Linus to move the Kconfig and Makefile bits for AMD and Intel into their respective directories. v2: Rebase against v5.8-rc3. Dropped ---help--- changes from Kconfig as that was dealt with in systemwide cleanup. Jerry Snitselaar (2): iommu

[PATCH 2/2] tpm: don't print error message in tpm_transmit_cmd when tpm still testing

2019-01-30 Thread Jerry Snitselaar
TPM2_RC_TESTING is the return code. Reviewed-by: Jarkko Sakkinen Signed-off-by: Jerry Snitselaar --- drivers/char/tpm/tpm-interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c index d9439f9abe78..6339a2e289ae

[PATCH 1/2] tpm: don't return bool from update_timeouts

2019-01-30 Thread Jerry Snitselaar
Set tpm_chip->timeouts_adjusted directly in the update_timeouts code instead of returning bool. In case of tpm read failing print warning that the read failed and continue on. Reviewed-by: Jarkko Sakkinen Signed-off-by: Jerry Snitselaar --- drivers/char/tpm/tpm1-cmd.c | 3 +-- driv

[PATCH 2/2] tpm: don't print error message in tpm_transmit_cmd when tpm still testing

2019-01-30 Thread Jerry Snitselaar
TPM2_RC_TESTING is the return code. Reviewed-by: Jarkko Sakkinen Signed-off-by: Jerry Snitselaar --- drivers/char/tpm/tpm-interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c index d9439f9abe78..6339a2e289ae

[PATCH 1/2] tpm: don't return bool from update_timeouts

2019-01-30 Thread Jerry Snitselaar
Set tpm_chip->timeouts_adjusted directly in the update_timeouts code instead of returning bool. In case of tpm read failing print warning that the read failed and continue on. Reviewed-by: Jarkko Sakkinen Signed-off-by: Jerry Snitselaar --- drivers/char/tpm/tpm1-cmd.c | 3 +-- driv

Re: Getting weird TPM error after rebasing my tree to security/next-general

2019-01-31 Thread Jerry Snitselaar
On Thu Jan 31 19, Linus Torvalds wrote: On Thu, Jan 31, 2019 at 12:47 PM Jarkko Sakkinen wrote: I'll try it first thing when I wake up tomorrow (11PM in Finland ATM). Thanks. Appreciate for taking time on this. Hey, it was my commit that broke it for you. Even if it happened to work befo

Re: [PATCH v4 0/3] Replace private domain with per-group default domain

2020-05-12 Thread Jerry Snitselaar
ierarchy to use DMA domain iommu/vt-d: Apply per-device dma_ops drivers/iommu/intel-iommu.c | 396 +++- 1 file changed, 26 insertions(+), 370 deletions(-) -- 2.17.1 Reviewed-by: Jerry Snitselaar

Re: [PATCH v4 1/7] ima: Switch to ima_hash_algo for boot aggregate

2020-05-07 Thread Jerry Snitselaar
rieve digest size of unknown algorithms with PCR read") Reported-by: Jerry Snitselaar Suggested-by: James Bottomley Signed-off-by: Roberto Sassu Thank you!  This patch set is now queued in next-integrity-testing during the open window.  Jerry, I assume this works for you.  Could we get your ta

[PATCH] tpm: print tpm error code in hex for TPM2.0 devices

2017-04-26 Thread Jerry Snitselaar
For easier decoding, output the error code returned from the tpm device in hex when the device is TPM2.0. Cc: Jarkko Sakkinen Cc: Peter Huewe Cc: Marcel Selhorst Cc: Jason Gunthorpe Reported-by: Ken Goldman Signed-off-by: Jerry Snitselaar --- drivers/char/tpm/tpm-interface.c | 11

question about usb_rebind_intf

2017-11-17 Thread Jerry Snitselaar
Should this skip warning that the rebind failed if device_attach is returning -EPROBE_DEFER? If I do something like 'rtcwake -m mem -s 30' on a laptop I have here I will see a couple "rebind failed: -517" messages as it comes back out of suspend. Since the device probe eventually happens once prob

Re: [PATCH] usb: Don't print a warning if interface driver rebind is deferred at resume

2017-12-04 Thread Jerry Snitselaar
e. Device probe will eventually take place later. [one-liner by Jerry Snitselaar posted in a mailing list question -Mathias] Suggested-by: Jerry Snitselaar Signed-off-by: Mathias Nyman --- drivers/usb/core/driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/

Re: [PATCH] tpm: print tpm error code in hex for TPM2.0 devices

2017-04-28 Thread Jerry Snitselaar
On Fri Apr 28 17, Jarkko Sakkinen wrote: On Wed, Apr 26, 2017 at 03:39:54PM -0700, Jerry Snitselaar wrote: For easier decoding, output the error code returned from the tpm device in hex when the device is TPM2.0. Cc: Jarkko Sakkinen Cc: Peter Huewe Cc: Marcel Selhorst Cc: Jason Gunthorpe

[PATCH] iommu/vt-d: only attempt to cleanup svm page request irq if one assigned

2017-10-05 Thread Jerry Snitselaar
Only try to clean up the svm page request irq if one has been assigned. Also clear pr_irq in the error path if irq request fails. Signed-off-by: Jerry Snitselaar --- drivers/iommu/intel-svm.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/iommu/intel-svm.c

[PATCH] iommu/vt-d: clean up pr_irq if request_threaded_irq fails

2017-12-06 Thread Jerry Snitselaar
78 67 a7 81 31 c0 e8 4c 37 fa ff <0f> ff 48 8b 34 24 4c 89 ef e 8 0e 4c 68 00 49 8b 46 40 48 8b 80 [0.669688] ---[ end trace 58a470248700f2fc ]--- Cc: Alex Williamson Cc: Joerg Roedel Cc: Ashok Raj Signed-off-by: Jerry Snitselaar --- drivers/iommu/intel-svm.c | 9 ++--- 1 fil

[tip: efi/urgent] efi/tpm: Only set 'efi_tpm_final_log_size' after successful event log parsing

2019-10-07 Thread tip-bot2 for Jerry Snitselaar
The following commit has been merged into the efi/urgent branch of tip: Commit-ID: e658c82be5561412c5e83b5e74e9da4830593f3e Gitweb: https://git.kernel.org/tip/e658c82be5561412c5e83b5e74e9da4830593f3e Author:Jerry Snitselaar AuthorDate:Wed, 02 Oct 2019 18:59:02 +02:00

<    1   2