Re: [PATCH v2 0/6] mailbox: arm_mhu: add support for doorbell mode

2017-05-24 Thread Jassi Brar
On Wed, May 24, 2017 at 3:46 PM, Sudeep Holla wrote: > > Hi, > > This series adds doorbell support to ARM MHU mailbox controller driver. > Since we need to callback the different client based on the doorbel bits > triggered from the remote, we can manage with single channel for the set > of 32 doo

Re: [PATCH v2 0/6] mailbox: arm_mhu: add support for doorbell mode

2017-05-25 Thread Jassi Brar
On Thu, May 25, 2017 at 5:00 PM, Sudeep Holla wrote: > > > On 24/05/17 11:56, Jassi Brar wrote: >> On Wed, May 24, 2017 at 3:46 PM, Sudeep Holla wrote: >>> >>> Hi, >>> >>> This series adds doorbell support to ARM MHU mailbox controller driver.

Re: [PATCH v2 2/6] Documentation: devicetree: add bindings to support ARM MHU doorbells

2017-05-25 Thread Jassi Brar
rsion of this binding can't support doorbells, > this patch extends the existing binding to support them. > > Cc: Alexey Klimov > Cc: Jassi Brar > Cc: Rob Herring > Cc: devicet...@vger.kernel.org > Signed-off-by: Sudeep Holla > --- > .../devicetree/bindings/mai

Re: [PATCH v2 0/6] mailbox: arm_mhu: add support for doorbell mode

2017-05-25 Thread Jassi Brar
On Thu, May 25, 2017 at 7:05 PM, Sudeep Holla wrote: >>> 1. The client driver is generic and expects it to be doorbell like >>>mailbox controller. I am referring to SCMI which will be released >>>soon. We can't embed ARM MHU or any other mailbox controller info >>>into that. >>> >> If

Re: [PATCH v2 0/6] mailbox: arm_mhu: add support for doorbell mode

2017-05-25 Thread Jassi Brar
On Thu, May 25, 2017 at 7:23 PM, Sudeep Holla wrote: > Just propose the binding yourself. > My proposed binding is what already exists. Zero change. I offer to adapt your driver for you, if you are too busy to do it yourself.

Re: [PATCH] mailbox: fix completion order for blocking requests

2017-05-25 Thread Jassi Brar
On Thu, May 25, 2017 at 10:10 PM, Alexey Klimov wrote: > On Sun, Apr 23, 2017 at 03:33:39PM +0530, Jassi Brar wrote: > > Sorry for delay -- this is not my main activity so please be patient. > No problem. >> > >> > Along with this patch you still need at le

Re: [PATCH 3/9] firmware: arm_scmi: add basic driver infrastructure for SCMI

2017-07-07 Thread Jassi Brar
Hi Roy, Matt, Nishant, Harb Abdulhamid, Loc, I have a gut feeling you guys were part of the SCMI spec committee. If so, could you please chime in? On Fri, Jul 7, 2017 at 11:09 PM, Sudeep Holla wrote: > > > On 07/07/17 17:52, Jassi Brar wrote: >> Hi Arnd, Hi Rob, Hi Mark, >

Re: [PATCH v2 2/6] Documentation: devicetree: add bindings to support ARM MHU doorbells

2017-07-05 Thread Jassi Brar
On Wed, Jul 5, 2017 at 11:32 PM, Sudeep Holla wrote: > > I have posted the SCMI patches now[1], > I wish I was CC'ed on that. Now LKML seems too busy to forward it. > please let me know how to get > both SCPI and SCMI working together with different doorbell bits on the > same channel. > You say

Re: [PATCH v2 2/6] Documentation: devicetree: add bindings to support ARM MHU doorbells

2017-07-06 Thread Jassi Brar
On Thu, Jul 6, 2017 at 2:48 PM, Sudeep Holla wrote: > Hi Jassi, > > On 06/07/17 07:28, Jassi Brar wrote: >> On Wed, Jul 5, 2017 at 11:32 PM, Sudeep Holla wrote: >> >>> >>> I have posted the SCMI patches now[1], >>> >> I wish I was CC'ed

Re: [PATCH v2 2/6] Documentation: devicetree: add bindings to support ARM MHU doorbells

2017-07-06 Thread Jassi Brar
On Thu, Jul 6, 2017 at 3:03 PM, Sudeep Holla wrote: > > > On 06/07/17 10:27, Jassi Brar wrote: >> On Thu, Jul 6, 2017 at 2:48 PM, Sudeep Holla wrote: >>> Hi Jassi, >>> >>> On 06/07/17 07:28, Jassi Brar wrote: >>>> On Wed, Jul 5, 2017 at

[GIT PULL] Mailbox changes for v4.13

2017-07-06 Thread Jassi Brar
Hi Linus, The following changes since commit 63f700aab4c11d46626de3cd051dae56cf7e9056: Merge tag 'xtensa-20170612' of git://github.com/jcmvbkbc/linux-xtensa (2017-06-13 15:09:10 +0900) are available in the git repository at: https://git.linaro.org/landing-teams/working/fujitsu/integration.g

Re: [PATCH v2 2/6] Documentation: devicetree: add bindings to support ARM MHU doorbells

2017-07-06 Thread Jassi Brar
On Thu, Jul 6, 2017 at 10:14 PM, Sudeep Holla wrote: > > On 06/07/17 15:37, Jassi Brar wrote: >> On Thu, Jul 6, 2017 at 3:03 PM, Sudeep Holla wrote: > >> I see no reason why you must have SCPI and SCMI both running. >> > > We can still have 2 different prot

Re: [PATCH v2 2/6] Documentation: devicetree: add bindings to support ARM MHU doorbells

2017-07-07 Thread Jassi Brar
On Fri, Jul 7, 2017 at 5:02 PM, Sudeep Holla wrote: > > > On 06/07/17 19:37, Jassi Brar wrote: >> On Thu, Jul 6, 2017 at 10:14 PM, Sudeep Holla wrote: >>> >>> On 06/07/17 15:37, Jassi Brar wrote: >>>> On Thu, Jul 6, 2017 at 3:03 PM, Sudeep Holla wr

[PATCH 3/9] firmware: arm_scmi: add basic driver infrastructure for SCMI

2017-07-07 Thread Jassi Brar
Hi Arnd, Hi Rob, Hi Mark, [CC'ing only those who I have the email id of] >+/** >+ * scmi_do_xfer() - Do one transfer >+ * >+ * @info: Pointer to SCMI entity information >+ * @xfer: Transfer to initiate and wait for response >+ * >+ * Return: -ETIMEDOUT in case of no response, if transmit error, >

Re: [PATCH v2 6/7] mailbox: bcm-flexrm-mailbox: Set msg_queue_len for each channel

2017-07-21 Thread Jassi Brar
Hi Anup, On Fri, Jul 21, 2017 at 12:25 PM, Anup Patel wrote: > The Broadcom FlexRM ring (i.e. mailbox channel) can handle > larger number of messages queued in one FlexRM ring hence > this patch sets msg_queue_len for each mailbox channel to > be same as RING_MAX_REQ_COUNT. > > Signed-off-by: Anu

[GIT PULL] Mailbox changes for v4.16

2018-02-04 Thread Jassi Brar
Hi Linus, The following changes since commit ef7f8cec80a0ba7bd00ece46844c8994117dc910: Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net (2018-01-08 20:21:39 -0800) are available in the git repository at: git://git.linaro.org/landing-teams/working/fujitsu/integration.git tags/ma

Re: [PATCH v11 2/6] mailbox: qcom: Create APCS child device for clock controller

2017-12-28 Thread Jassi Brar
Hi Bjorn, On Sun, Dec 24, 2017 at 10:36 AM, Bjorn Andersson wrote: > On Fri 22 Dec 20:57 PST 2017, Jassi Brar wrote: > >> On Tue, Dec 5, 2017 at 9:16 PM, Georgi Djakov >> wrote: >> > There is a clock controller functionality provided by the APCS hardware >>

[GIT PULL] Mailbox changes for v4.15

2017-11-15 Thread Jassi Brar
Hi Linus, The following changes since commit 15f859ae5c43c7f0a064ed92d33f7a5bc5de6de0: Merge tag 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dledford/rdma (2017-10-26 23:04:14 +0200) are available in the git repository at: git://git.linaro.org/landing-teams/working/fujitsu/

Re: [PATCH] mailbox: txdone_method shouldn't always be reset

2017-11-16 Thread Jassi Brar
On Thu, Nov 16, 2017 at 11:01 AM, Bjorn Andersson wrote: > A client that knows how to drive txdone would temporarily "upgrade" the > method to TXDONE_BY_ACK. But with the introduction of commit 33cd7123ac0ba > ("mailbox: reset txdone_method TXDONE_BY_POLL if client knows_txdone") > there is no lon

Re: [PATCH] mailbox: txdone_method shouldn't always be reset

2017-11-16 Thread Jassi Brar
On Thu, Nov 16, 2017 at 10:21 PM, Jassi Brar wrote: > On Thu, Nov 16, 2017 at 11:01 AM, Bjorn Andersson > wrote: >> A client that knows how to drive txdone would temporarily "upgrade" the >> method to TXDONE_BY_ACK. But with the introduction of commit 33cd7

Re: [PATCH] mailbox: txdone_method shouldn't always be reset

2017-11-17 Thread Jassi Brar
On Fri, Nov 17, 2017 at 12:34 PM, Bjorn Andersson wrote: > On Thu 16 Nov 22:47 PST 2017, Jassi Brar wrote: >> On 16 Nov 2017 23:12, "Bjorn Andersson" wrote: >> On Thu 16 Nov 09:06 PST 2017, Jassi Brar wrote: >> > diff --git a/drivers/mailbox/mailbox.c b/dr

Re: [PATCH v3 2/3] mailbox: Add support for Hi3660 mailbox

2017-12-04 Thread Jassi Brar
On Fri, Nov 17, 2017 at 2:54 PM, Xu YiPing wrote: > From: Kaihua Zhong > > Hi3660 mailbox controller is used to send message within multiple > processors, MCU, HIFI, etc. It supports 32 mailbox channels and every > channel can only be used for single transferring direction. Once the > channel i

Re: [PATCH v11 2/6] mailbox: qcom: Create APCS child device for clock controller

2017-12-22 Thread Jassi Brar
On Tue, Dec 5, 2017 at 9:16 PM, Georgi Djakov wrote: > There is a clock controller functionality provided by the APCS hardware > block of msm8916 devices. The device-tree would represent an APCS node > with both mailbox and clock provider properties. > The spec might depict a 'clock' box and 'mail

Re: mailbox: ti-msgmgr: Switch to SPDX Licensing

2017-12-16 Thread Jassi Brar
On Sun, Dec 17, 2017 at 3:19 AM, Nishanth Menon wrote: > On 08:21-20171213, Lokesh Vutla wrote: >> >> >> On Saturday 02 December 2017 03:52 PM, Nishanth Menon wrote: >> > Switch to SPDX licensing and drop the GPL text which comes redundant. >> > >> > Signed-off-by: Nishanth Menon >> >> >> Reviewe

Re: linux-next: Signed-off-by missing for commits in the mailbox tree

2017-08-30 Thread Jassi Brar
On 30 August 2017 at 22:45, Stephen Rothwell wrote: > Hi Jassi, > > Commits > > da91001cab90 ("mailbox: bcm-flexrm-mailbox: Set IRQ affinity hint for FlexRM > ring IRQs") > 6bee3ba26d4d ("mailbox: bcm-flexrm-mailbox: Add debugfs support") > 73c28265c82b ("mailbox: bcm-flexrm-mailbox: Fix mask use

Re: [PATCH net-next 3/3] net: phy: realtek: add RTL8201F phy-id and functions

2017-09-08 Thread Jassi Brar
On 9 September 2017 at 00:21, Florian Fainelli wrote: > On 09/08/2017 06:02 AM, Kunihiko Hayashi wrote: >> From: Jassi Brar >> >> Add RTL8201F phy-id and the related functions to the driver. >> >> The original patch is as follows: >> https://patchwork.ker

Re: [PATCH 1/3] driver: mailbox: add support for Hi3660

2017-09-02 Thread Jassi Brar
On Mon, Aug 7, 2017 at 2:47 PM, Zhong Kaihua wrote: > From: Kaihua Zhong > > Add mailbox driver for Hi3660. > > Signed-off-by: Leo Yan > Signed-off-by: Ruyi Wang > Tested-by: Kaihua Zhong > > --- > drivers/mailbox/Kconfig | 6 + > drivers/mailbox/Makefile | 2 + > drivers

Re: [PATCH v2] drivers/mailbox: Add Aspeed mailbox driver

2017-09-04 Thread Jassi Brar
On Mon, Sep 4, 2017 at 12:47 PM, Cyril Bur wrote: > Hi, > > I haven't heard anything about this driver. I'm trying to interpret if > the silence is because there is something fundamentally wrong with the > driver or is it because it doesn't use any of the mailbox > infrastructure it is being ignor

[GIT PULL] Mailbox changes for v4.14

2017-09-06 Thread Jassi Brar
Hi Linus, The following changes since commit 14ccee78fc82f5512908f4424f541549a5705b89: Linux 4.13-rc6 (2017-08-20 14:13:52 -0700) are available in the git repository at: git://git.linaro.org/landing-teams/working/fujitsu/integration.git tags/mailbox-v4.14 for you to fetch changes up to 1da

Re: [PATCH v4 3/5] soc: qcom: Introduce APCS IPC driver

2017-05-07 Thread Jassi Brar
On Mon, May 8, 2017 at 11:24 AM, Bjorn Andersson wrote: > On Fri 05 May 21:48 PDT 2017, Jassi Brar wrote: > > The APCS IPC register serves the basis for all inter-processor > communication in a Qualcomm platform, so it's not only the RPM driver > discussed earlier that uses

Re: [PATCH 2/6] Documentation: devicetree: add bindings to support ARM MHU subchannels

2017-05-08 Thread Jassi Brar
ng the >> interrupt thereby allowing it to be used as independent subchannels. >> >> Since the first version of this binding can't support sub-channels, >> this patch extends the existing binding to support them. >> >> Cc: Alexey Klimov >> Cc: Jass

Re: [PATCH 2/6] Documentation: devicetree: add bindings to support ARM MHU subchannels

2017-05-08 Thread Jassi Brar
On Mon, May 8, 2017 at 10:37 PM, Sudeep Holla wrote: > > > On 08/05/17 17:46, Jassi Brar wrote: >> On Mon, May 8, 2017 at 9:40 PM, Rob Herring wrote: >>> +Bjorn >>> >>> On Tue, May 02, 2017 at 02:55:49PM +0100, Sudeep Holla wrote: >>>> Th

Re: [PATCH 2/6] Documentation: devicetree: add bindings to support ARM MHU subchannels

2017-05-09 Thread Jassi Brar
On Tue, May 9, 2017 at 3:28 PM, Sudeep Holla wrote: >> >> If it is still not clear, please share your client driver. I will >> adapt that to work with existing MHU driver & bindings. >> > > Just take example of SCPI in the mainline. Assume there's another > protocol SCMI which uses few more bits

Re: [PATCH 2/6] Documentation: devicetree: add bindings to support ARM MHU subchannels

2017-05-09 Thread Jassi Brar
On Tue, May 9, 2017 at 4:23 PM, Sudeep Holla wrote: > > > On 09/05/17 11:31, Jassi Brar wrote: >> On Tue, May 9, 2017 at 3:28 PM, Sudeep Holla >> wrote: >> >>>> >>>> If it is still not clear, please share your client driver. I >>>&

Re: [PATCH 2/6] Documentation: devicetree: add bindings to support ARM MHU subchannels

2017-05-09 Thread Jassi Brar
On Tue, May 9, 2017 at 6:11 PM, Sudeep Holla wrote: > On 09/05/17 12:55, Jassi Brar wrote: >>>>>> >>>>>> If it is still not clear, please share your client driver. I >>>>>> will adapt that to work with existing MHU driver & bindings.

Re: [PATCH v4 3/5] soc: qcom: Introduce APCS IPC driver

2017-05-09 Thread Jassi Brar
On Tue, May 9, 2017 at 12:41 AM, Bjorn Andersson wrote: > On Sun 07 May 23:47 PDT 2017, Jassi Brar wrote: > >> On Mon, May 8, 2017 at 11:24 AM, Bjorn Andersson >> wrote: >> > On Fri 05 May 21:48 PDT 2017, Jassi Brar wrote: >> > >> > The APCS IPC regi

Re: [PATCH v4 3/5] soc: qcom: Introduce APCS IPC driver

2017-05-09 Thread Jassi Brar
On Wed, May 10, 2017 at 12:41 AM, Bjorn Andersson wrote: > On Tue 09 May 09:41 PDT 2017, Jassi Brar wrote: >> >> >> >> The client should call mbox_client_txdone() after >> >> >> mbox_send_message(). >> >> > >> >> &g

Re: [PATCH v4 3/5] soc: qcom: Introduce APCS IPC driver

2017-05-10 Thread Jassi Brar
On Thu, May 11, 2017 at 12:30 AM, Bjorn Andersson wrote: > On Tue 09 May 19:33 PDT 2017, Jassi Brar wrote: > >> On Wed, May 10, 2017 at 12:41 AM, Bjorn Andersson >> wrote: >> > On Tue 09 May 09:41 PDT 2017, Jassi Brar wrote: > [..] >> > The part where

Re: [PATCH v5 0/4] USB Audio Gadget refactoring

2017-06-25 Thread Jassi Brar
| 15 +- > drivers/usb/gadget/legacy/audio.c | 55 +- > 15 files changed, 2494 insertions(+), 1348 deletions(-) > create mode 100644 Documentation/ABI/testing/configfs-usb-gadget-uac1_legacy > create mode 100644 drivers/usb/gadget/function/f_uac1_legacy.c > create mode 100644 drivers/usb/gadget/function/u_audio.c > create mode 100644 drivers/usb/gadget/function/u_audio.h > rename drivers/usb/gadget/function/{u_uac1.c => u_uac1_legacy.c} (98%) > create mode 100644 drivers/usb/gadget/function/u_uac1_legacy.h > Acked-by: Jassi Brar Thanks.

Re: [PATCH RFC] mailbox: move controller timer to per-channel timers

2017-05-31 Thread Jassi Brar
On Tue, May 30, 2017 at 9:59 PM, Alexey Klimov wrote: > > I was able to come up with new version with only HR-timer spinlock in timer > callback. That one seems a little bit better. > Yes, this is what I meant by simply using a lock. However the lock around the last_tx_done() for all channels see

Re: [PATCH v2 2/6] Documentation: devicetree: add bindings to support ARM MHU doorbells

2017-06-01 Thread Jassi Brar
Hi Rob, On Wed, May 31, 2017 at 10:38 PM, Rob Herring wrote: > On Thu, May 25, 2017 at 02:23:44PM +0100, Sudeep Holla wrote: >> >> >> .../devicetree/bindings/mailbox/arm-mhu.txt| 46 >> >> -- >> >> 1 file changed, 43 insertions(+), 3 deletions(-) >> >> >> >> diff --g

Re: [PATCH v4 3/5] soc: qcom: Introduce APCS IPC driver

2017-05-16 Thread Jassi Brar
On Sat, May 13, 2017 at 4:18 AM, Bjorn Andersson wrote: > On Wed 10 May 19:07 PDT 2017, Jassi Brar wrote: > >> On Thu, May 11, 2017 at 12:30 AM, Bjorn Andersson >> wrote: >> > On Tue 09 May 19:33 PDT 2017, Jassi Brar wrote: > [..] >> > So please let me know

Re: [PATCH v4 2/3] usb: gadget: f_uac2: split out audio core

2017-05-22 Thread Jassi Brar
On Thu, May 18, 2017 at 4:07 AM, Ruslan Bilovol wrote: > Abstract the peripheral side ALSA sound card code from > the f_uac2 function into a component that can be called > by various functions, so the various flavors can be split > apart and selectively reused. > > Visible changes: > - add uac_pa

Re: [PATCH v3 2/4] soc: qcom: Introduce APCS IPC driver

2017-05-04 Thread Jassi Brar
On Thu, May 4, 2017 at 11:15 AM, Bjorn Andersson wrote: > On Wed 03 May 02:55 PDT 2017, Jassi Brar wrote: > >> Loic, thanks for adding me. >> >> On Wed, May 3, 2017 at 2:58 PM, Loic PALLARDY wrote: >> > >> > >> >> -Original Message--

Re: [PATCH v3 2/4] soc: qcom: Introduce APCS IPC driver

2017-05-04 Thread Jassi Brar
On Thu, May 4, 2017 at 9:40 PM, Bjorn Andersson wrote: > On Thu 04 May 00:54 PDT 2017, Jassi Brar wrote: > >> On Thu, May 4, 2017 at 11:15 AM, Bjorn Andersson >> wrote: >> > On Wed 03 May 02:55 PDT 2017, Jassi Brar wrote: >> > >> >> Loic, thanks f

Re: [PATCH v4 3/5] soc: qcom: Introduce APCS IPC driver

2017-05-05 Thread Jassi Brar
On Fri, May 5, 2017 at 1:35 AM, Bjorn Andersson wrote: > + > +static int qcom_apcs_ipc_send_data(struct mbox_chan *chan, void *data) > +{ > + struct qcom_apcs_ipc *apcs = container_of(chan->mbox, > + struct qcom_apcs_ipc, mbox); > + unsi

Re: [PATCH v4 1/5] mailbox: Make startup and shutdown ops optional

2017-05-05 Thread Jassi Brar
On Fri, May 5, 2017 at 1:35 AM, Bjorn Andersson wrote: > Some mailbox hardware doesn't have to perform any additional operations > on startup of shutdown, so make these optional. > Thanks, makes sense. > diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c > index 4671f8a12872..c88d

Re: [PATCH 0/6] mailbox: arm_mhu: add support for subchannels

2017-05-05 Thread Jassi Brar
On Wed, May 3, 2017 at 2:51 PM, Sudeep Holla wrote: > > > On 03/05/17 04:17, Jassi Brar wrote: >> Hi Sudeep, >> >> On Tue, May 2, 2017 at 7:25 PM, Sudeep Holla wrote: >>> Hi Jassi, >>> >>> This series adds subchannel support to ARM MHU mailb

Re: [PATCH v4 3/5] soc: qcom: Introduce APCS IPC driver

2017-05-05 Thread Jassi Brar
On Sat, May 6, 2017 at 12:07 AM, Bjorn Andersson wrote: > On Fri 05 May 03:26 PDT 2017, Jassi Brar wrote: > >> On Fri, May 5, 2017 at 1:35 AM, Bjorn Andersson >> wrote: >> >> > + >> > +static int qcom_apcs_ipc_send_data(struct mbox_chan *cha

Re: [PATCH v4 3/5] soc: qcom: Introduce APCS IPC driver

2017-05-05 Thread Jassi Brar
On Sat, May 6, 2017 at 1:23 AM, Jeffrey Hugo wrote: > On 5/5/2017 1:22 PM, Jassi Brar wrote: >> >> On Sat, May 6, 2017 at 12:07 AM, Bjorn Andersson >> wrote: >>> > > There is no way to determine if the remote processor has observed a message, > th

Re: [PATCH v4 3/5] soc: qcom: Introduce APCS IPC driver

2017-05-05 Thread Jassi Brar
On Sat, May 6, 2017 at 6:49 AM, Bjorn Andersson wrote: > On Fri 05 May 13:22 PDT 2017, Jassi Brar wrote: >> How is it supposed to work if a client queues more than one request? > > One such example is found in patch 5 in this series. There are two FIFOs > in shared memory, one

[GIT PULL] Mailbox changes for v4.12

2017-05-01 Thread Jassi Brar
Hi Linus, The following changes since commit ad0376eb1483bd9880770b346f6592aece669e4c: Merge tag 'edac_for_4.11_2' of git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp (2017-03-27 11:09:00 -0700) are available in the git repository at: https://git.linaro.org/landing-teams/working/fujitsu/

Re: [PATCH 0/6] mailbox: arm_mhu: add support for subchannels

2017-05-02 Thread Jassi Brar
Hi Sudeep, On Tue, May 2, 2017 at 7:25 PM, Sudeep Holla wrote: > Hi Jassi, > > This series adds subchannel support to ARM MHU mailbox controller > driver. Since SCPI never used second slot, we were able to use the > existing driver as is. However, that's changing soon and the new > SCMI protocol

Re: [PATCH v3 2/4] soc: qcom: Introduce APCS IPC driver

2017-05-03 Thread Jassi Brar
Loic, thanks for adding me. On Wed, May 3, 2017 at 2:58 PM, Loic PALLARDY wrote: > > >> -Original Message- >> From: linux-remoteproc-ow...@vger.kernel.org [mailto:linux-remoteproc- >> ow...@vger.kernel.org] On Behalf Of Bjorn Andersson >> Sent: Wednesday, May 03, 2017 7:29 AM >> To: Andy

Re: [PATCH v3 02/22] dt-bindings: arm: add support for ARM System Control and Management Interface(SCMI) protocol

2017-10-05 Thread Jassi Brar
On Wed, Oct 4, 2017 at 5:35 AM, Arnd Bergmann wrote: > On Wed, Oct 4, 2017 at 1:07 PM, Sudeep Holla wrote: >> On 04/10/17 11:50, Arnd Bergmann wrote: >>> On Thu, Sep 28, 2017 at 3:11 PM, Sudeep Holla wrote: > +- shmem : List of phandle pointing to the shared memory(SHM) area as per +

Re: [PATCH v3 03/22] dt-bindings: arm: scmi: add ARM MHU specific mailbox client bindings

2017-10-06 Thread Jassi Brar
On Fri, Oct 6, 2017 at 4:50 AM, Rob Herring wrote: > On Thu, Sep 28, 2017 at 02:11:27PM +0100, Sudeep Holla wrote: >> This patch adds ARM MHU specific mailbox client bindings to support >> SCMI. Since SCMI specification just requires doorbell mechanism from >> mailbox controllers, we add mailbox d

Re: [PATCH v3 16/22] firmware: arm_scmi: add arm_mhu specific mailbox interface

2017-10-06 Thread Jassi Brar
On Wed, Oct 4, 2017 at 5:06 PM, Arnd Bergmann wrote: > On Thu, Sep 28, 2017 at 3:11 PM, Sudeep Holla wrote: >> This patch adds ARM MHU specific mailbox interface for SCMI. >> >> Cc: Arnd Bergmann >> Signed-off-by: Sudeep Holla > > This clearly needs an explanation why we need another driver. >

Re: [PATCH v3 15/22] firmware: arm_scmi: abstract mailbox interface

2017-10-06 Thread Jassi Brar
On Wed, Oct 4, 2017 at 5:02 PM, Sudeep Holla wrote: > Also, I have added shim only for specific controllers that need them. > E.g. ARM MHU as Jassi disagreed to add doorbell mechanism to that. > mbox_if provides default implementation that just calls direct mailbox > APIs. > Yeah you could hack a

Re: [PATCH v3 15/22] firmware: arm_scmi: abstract mailbox interface

2017-10-06 Thread Jassi Brar
On Fri, Oct 6, 2017 at 6:57 PM, Sudeep Holla wrote: > > > On 06/10/17 12:34, Jassi Brar wrote: >> On Wed, Oct 4, 2017 at 5:02 PM, Sudeep Holla wrote: >> >>> Also, I have added shim only for specific controllers that need them. >>> E.g. ARM MHU as Jassi disa

Re: [PATCH v3 16/22] firmware: arm_scmi: add arm_mhu specific mailbox interface

2017-10-06 Thread Jassi Brar
On Fri, Oct 6, 2017 at 7:02 PM, Sudeep Holla wrote: > > > On 06/10/17 12:26, Jassi Brar wrote: >> On Wed, Oct 4, 2017 at 5:06 PM, Arnd Bergmann wrote: >>> On Thu, Sep 28, 2017 at 3:11 PM, Sudeep Holla wrote: >>>> This patch adds ARM MHU specific mailbox in

Re: [PATCH v3 03/22] dt-bindings: arm: scmi: add ARM MHU specific mailbox client bindings

2017-10-09 Thread Jassi Brar
On Tue, Oct 10, 2017 at 4:27 AM, Rob Herring wrote: > On Mon, Oct 9, 2017 at 9:46 AM, Jassi Brar wrote: >> On Mon, Oct 9, 2017 at 7:22 PM, Rob Herring wrote: >>> On Fri, Oct 6, 2017 at 9:26 PM, Jassi Brar wrote: >>>> On Fri, Oct 6, 2017 at 9:24 PM, Rob Herring wr

Re: [PATCH v3 16/22] firmware: arm_scmi: add arm_mhu specific mailbox interface

2017-10-13 Thread Jassi Brar
On Fri, Oct 13, 2017 at 7:12 PM, Sudeep Holla wrote: > > Hi Bjorn, > > Thanks for taking a look at this. Much appreciated. > > On 12/10/17 22:03, Bjorn Andersson wrote: >> On Fri, Oct 6, 2017 at 6:51 AM, Sudeep Holla wrote: >>> >>> >>> On 0

Re: [PATCH v3 16/22] firmware: arm_scmi: add arm_mhu specific mailbox interface

2017-10-13 Thread Jassi Brar
On Fri, Oct 13, 2017 at 8:17 PM, Sudeep Holla wrote: > On 13/10/17 15:12, Jassi Brar wrote: > >> In MHU the 32bits are tied together and all go to one target >> processor. Whereas on QCom, each bit corresponds to independent signal >> going to a different target processor

Re: [PATCH v3 03/22] dt-bindings: arm: scmi: add ARM MHU specific mailbox client bindings

2017-10-06 Thread Jassi Brar
On Fri, Oct 6, 2017 at 9:24 PM, Rob Herring wrote: > On Fri, Oct 6, 2017 at 6:01 AM, Jassi Brar wrote: >> On Fri, Oct 6, 2017 at 4:50 AM, Rob Herring wrote: >>> On Thu, Sep 28, 2017 at 02:11:27PM +0100, Sudeep Holla wrote: >>> >>>> +- mbox-data : For eac

Re: [PATCH v3 03/22] dt-bindings: arm: scmi: add ARM MHU specific mailbox client bindings

2017-10-09 Thread Jassi Brar
On Mon, Oct 9, 2017 at 7:22 PM, Rob Herring wrote: > On Fri, Oct 6, 2017 at 9:26 PM, Jassi Brar wrote: >> On Fri, Oct 6, 2017 at 9:24 PM, Rob Herring wrote: >>> On Fri, Oct 6, 2017 at 6:01 AM, Jassi Brar wrote: >>>> On Fri, Oct 6, 2017 at 4:50 AM, Rob Herring wro

Re: [PATCH v4 2/3] usb: gadget: f_uac2: split out audio core

2017-06-02 Thread Jassi Brar
On Tue, May 30, 2017 at 5:13 AM, Ruslan Bilovol wrote: > On Mon, May 22, 2017 at 6:58 PM, Jassi Brar wrote: >> On Thu, May 18, 2017 at 4:07 AM, Ruslan Bilovol >> wrote: >>> Abstract the peripheral side ALSA sound card code from >>> the f_uac2 function into a co

Re: [PATCH 3/9] firmware: arm_scmi: add basic driver infrastructure for SCMI

2017-07-24 Thread Jassi Brar
On Mon, Jul 24, 2017 at 3:20 PM, Sudeep Holla wrote: > > > On 08/07/17 06:32, Jassi Brar wrote: >> Hi Roy, Matt, Nishant, Harb Abdulhamid, Loc, >> >> I have a gut feeling you guys were part of the SCMI spec committee. If >> so, could you please chime in? >

Re: [PATCH v2 6/7] mailbox: bcm-flexrm-mailbox: Set msg_queue_len for each channel

2017-07-24 Thread Jassi Brar
On Mon, Jul 24, 2017 at 9:26 AM, Anup Patel wrote: > Hi Jassi, > > Sorry for the delayed response... > > On Fri, Jul 21, 2017 at 9:16 PM, Jassi Brar wrote: >> Hi Anup, >> >> On Fri, Jul 21, 2017 at 12:25 PM, Anup Patel wrote: >>> The Broadcom Fle

Re: [PATCH 3/9] firmware: arm_scmi: add basic driver infrastructure for SCMI

2017-07-24 Thread Jassi Brar
On Mon, Jul 24, 2017 at 9:51 PM, Sudeep Holla wrote: > On 24/07/17 16:41, Jassi Brar wrote: >> SCMI calls >> mbox_send_message(struct mbox_chan *chan, struct scmi_xfer *xfer); >> >> whereas the API expects >> mbox_send_message(struct mbox_chan *chan, str

Re: [PATCH 1/8] mailbox: introduce ARM SMC based mailbox

2017-07-24 Thread Jassi Brar
On Mon, Jul 24, 2017 at 4:50 AM, André Przywara wrote: > On 02/07/17 06:55, Jassi Brar wrote: > >>> + mbox_chan_received_data(link, (void *)res.a0); >>> + >> Or you can update the 'data' with value from 'a0' ? > > Mmh, I am a bit

Re: [PATCH 1/8] mailbox: introduce ARM SMC based mailbox

2017-07-24 Thread Jassi Brar
On Mon, Jul 24, 2017 at 11:08 PM, Sudeep Holla wrote: > On 24/07/17 18:20, Jassi Brar wrote: >> >>> I see that the SCPI firmware driver (as the user of the mailbox API) is >>> expecting the return value from a0 as returned above, translating the >>> f

Re: [PATCH v2 6/7] mailbox: bcm-flexrm-mailbox: Set msg_queue_len for each channel

2017-07-25 Thread Jassi Brar
On Tue, Jul 25, 2017 at 11:11 AM, Anup Patel wrote: > On Mon, Jul 24, 2017 at 10:06 PM, Jassi Brar wrote: >> On Mon, Jul 24, 2017 at 9:26 AM, Anup Patel wrote: >>> Hi Jassi, >>> >>> Sorry for the delayed response... >>> >>> On Fri, Jul 21,

Re: [PATCH v2 6/7] mailbox: bcm-flexrm-mailbox: Set msg_queue_len for each channel

2017-07-28 Thread Jassi Brar
On Fri, Jul 28, 2017 at 3:18 PM, Anup Patel wrote: > On Fri, Jul 28, 2017 at 2:34 PM, Jassi Brar wrote: >> On Fri, Jul 28, 2017 at 2:19 PM, Anup Patel wrote: >>> On Thu, Jul 27, 2017 at 5:23 PM, Jassi Brar >>> wrote: >>>> On Thu, Jul 27, 2017 at 11:20 AM

Re: [PATCH 2/4] mailbox: pcc: Drop uninformative output during boot

2017-07-31 Thread Jassi Brar
ailbox driver >> prints - >> >> [0.484261] PCCT header not found. >> >> during probe before returning -ENODEV. >> >> This message clutters the bootlog and doesn't provide any useful >> information. Drop this message. >> >> Signed-off-by

Re: [PATCH v2 03/18] firmware: arm_scmi: add basic driver infrastructure for SCMI

2017-08-07 Thread Jassi Brar
On Fri, Aug 4, 2017 at 8:01 PM, Sudeep Holla wrote: > +int scmi_do_xfer(const struct scmi_handle *handle, struct scmi_xfer *xfer) > +{ > + int ret; > + int timeout; > + struct scmi_info *info = handle_to_scmi_info(handle); > + struct device *dev = info->dev; > + > +

Re: [PATCH v2 03/18] firmware: arm_scmi: add basic driver infrastructure for SCMI

2017-08-08 Thread Jassi Brar
On Tue, Aug 8, 2017 at 2:59 PM, Sudeep Holla wrote: > > > On 08/08/17 03:46, Jassi Brar wrote: >> On Fri, Aug 4, 2017 at 8:01 PM, Sudeep Holla wrote: >> >> >>> +int scmi_do_xfer(const struct scmi_handle *handle, struct scmi_xfer *xfer) >>> +{

Re: [PATCH v2 0/3] mailbox: arm: introduce smc triggered mailbox

2017-08-01 Thread Jassi Brar
On Tue, Aug 1, 2017 at 4:20 PM, Alexander Graf wrote: > Hi Andre, > > On 24.07.17 01:23, Andre Przywara wrote: >> >> This is a reworked version of my previous post. It addresses Jassi's >> comments on the driver and also tries to cover Rob's and Mark's comments >> on the binding documentation. >>

Re: [PATCH v2 2/3] mailbox: introduce ARM SMC based mailbox

2017-08-01 Thread Jassi Brar
On Mon, Jul 24, 2017 at 4:53 AM, Andre Przywara wrote: > +static int arm_smc_send_data(struct mbox_chan *link, void *data) > +{ > + struct arm_smc_chan_data *chan_data = link->con_priv; > + u32 function_id = chan_data->function_id; > + struct arm_smccc_res res; > + u32 msg

Re: [PATCH 1/2] mailbox: reset txdone_method TXDONE_BY_POLL if client knows_txdone

2017-07-01 Thread Jassi Brar
NE_BY_POLL if client has set > knows_txdone. > > Cc: Alexey Klimov > Cc: Jassi Brar > Signed-off-by: Sudeep Holla > --- > drivers/mailbox/mailbox.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox

Re: [PATCH 1/8] mailbox: introduce ARM SMC based mailbox

2017-07-01 Thread Jassi Brar
On Fri, Jun 30, 2017 at 3:26 PM, Andre Przywara wrote: > This mailbox driver implements a mailbox which signals transmitted data > via an ARM smc (secure monitor call) instruction. The mailbox receiver > is implemented in firmware and can synchronously return data when it > returns execution to th

Re: [PATCH 1/2] mailbox: reset txdone_method TXDONE_BY_POLL if client knows_txdone

2017-07-03 Thread Jassi Brar
On 3 July 2017 at 15:05, Sudeep Holla wrote: > > > On 03/07/17 09:57, Sudeep Holla wrote: >> >> >> On 01/07/17 12:25, Jassi Brar wrote: >>> On Fri, Jun 30, 2017 at 8:44 PM, Sudeep Holla wrote: >>>> Currently the mailbox framework sets txdone_meth

Re: [PATCH v2 6/7] mailbox: bcm-flexrm-mailbox: Set msg_queue_len for each channel

2017-07-26 Thread Jassi Brar
On Thu, Jul 27, 2017 at 9:25 AM, Anup Patel wrote: > On Tue, Jul 25, 2017 at 9:37 PM, Jassi Brar wrote: >> On Tue, Jul 25, 2017 at 11:11 AM, Anup Patel wrote: >>> On Mon, Jul 24, 2017 at 10:06 PM, Jassi Brar >>> wrote: >>>> On Mon, Jul 24, 2017 at 9:2

Re: [PATCH v2 6/7] mailbox: bcm-flexrm-mailbox: Set msg_queue_len for each channel

2017-07-27 Thread Jassi Brar
On Thu, Jul 27, 2017 at 11:20 AM, Anup Patel wrote: > On Thu, Jul 27, 2017 at 10:29 AM, Jassi Brar wrote: >>>>>>> Sorry for the delayed response... >>>>>>> >>>>>>> On Fri, Jul 21, 2017 at 9:16 PM, Jassi Brar >>>>&

Re: [PATCH v2 6/7] mailbox: bcm-flexrm-mailbox: Set msg_queue_len for each channel

2017-07-28 Thread Jassi Brar
On Fri, Jul 28, 2017 at 2:19 PM, Anup Patel wrote: > On Thu, Jul 27, 2017 at 5:23 PM, Jassi Brar wrote: >> On Thu, Jul 27, 2017 at 11:20 AM, Anup Patel wrote: >>> On Thu, Jul 27, 2017 at 10:29 AM, Jassi Brar >>> wrote: >> >>>>>>>>>

Re: [PATCH v2 0/3] Add Platform MHU mailbox driver for Amlogic GXBB

2016-09-02 Thread Jassi Brar
On Sat, Sep 3, 2016 at 5:04 AM, Kevin Hilman wrote: > Hi Jassi, > > Neil Armstrong writes: > >> In order to support Mailbox links for the Amlogic GXBB SoC, add a generic >> platform MHU driver based on arm_mhu.c. >> >> This patchset follows a RFC thread along the GXBB SCPI support at : >> http://

Re: [PATCH v2 0/3] Add Platform MHU mailbox driver for Amlogic GXBB

2016-09-03 Thread Jassi Brar
On Sun, Sep 4, 2016 at 2:15 AM, Kevin Hilman wrote: > On Fri, Sep 2, 2016 at 10:33 PM, Jassi Brar wrote: >> On Sat, Sep 3, 2016 at 5:04 AM, Kevin Hilman wrote: >>> Hi Jassi, >>> >>> Neil Armstrong writes: >>> >>>> In order to supp

[GIT PULL] Mailbox fixes for v4.8-rc

2016-09-06 Thread Jassi Brar
Hi Linus, The following changes since commit 5e608a027082ae426e100a582031e0ff40becc83: Merge branch 'akpm' (patches from Andrew) (2016-08-26 23:12:12 -0700) are available in the git repository at: git://git.linaro.org/landing-teams/working/fujitsu/integration.git mailbox-devel for you to f

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

2016-10-04 Thread Jassi Brar
On 5 October 2016 at 08:24, Horng-Shyang Liao wrote: > On Fri, 2016-09-30 at 17:47 +0800, Horng-Shyang Liao wrote: >> On Fri, 2016-09-30 at 17:11 +0800, CK Hu wrote: > > After I trace mailbox driver, I realize that CMDQ driver cannot use > tx_done. > > CMDQ clients will flush many tasks into CMDQ

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

2016-10-05 Thread Jassi Brar
On 5 October 2016 at 18:01, Horng-Shyang Liao wrote: > On Wed, 2016-10-05 at 09:07 +0530, Jassi Brar wrote: >> On 5 October 2016 at 08:24, Horng-Shyang Liao wrote: >> > On Fri, 2016-09-30 at 17:47 +0800, Horng-Shyang Liao wrote: >> >> On Fri, 2016-09-

Re: [PATCH] mailbox, remoteproc: omap2+: fix compile testing

2024-09-22 Thread Jassi Brar
On Mon, Sep 9, 2024 at 3:38 PM Arnd Bergmann wrote: > > From: Arnd Bergmann > > Selecting CONFIG_OMAP2PLUS_MBOX while compile testing > causes a build failure: > > WARNING: unmet direct dependencies detected for OMAP2PLUS_MBOX > Depends on [n]: MAILBOX [=y] && (ARCH_OMAP2PLUS || ARCH_K3) > Se

<    1   2   3   4   5   6