Re: [PATCH v2 2/6] mailbox: dt-bindings: Add shared [driver <=> device tree] defines

2015-08-10 Thread Jassi Brar
On Mon, Aug 10, 2015 at 1:54 PM, Lee Jones wrote: > On Mon, 10 Aug 2015, Jassi Brar wrote: >> On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones wrote: >> > This header is currently only used for defines pertaining to data >> > direction i.e. Rx, Tx or Loopback. >>

Re: [PATCH 1/2] mailbox: switch to hrtimer for tx_complete polling

2015-07-26 Thread Jassi Brar
On Fri, Jul 24, 2015 at 2:17 PM, Sudeep Holla wrote: > On 24/07/15 06:02, Jassi Brar wrote: >> >> On Wed, Jul 22, 2015 at 5:58 PM, Sudeep Holla >> wrote: >> >>> we might end-up waiting >>> for atleast a jiffy even though the response for that message

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-13 Thread Jassi Brar
On Wed, Aug 12, 2015 at 3:53 PM, Lee Jones wrote: > On Mon, 10 Aug 2015, Jassi Brar wrote: > >> On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones wrote: >> > This particular Client implementation uses shared memory in order >> > to pass messages between Mailbox us

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-13 Thread Jassi Brar
On Thu, Aug 13, 2015 at 2:49 PM, Lee Jones wrote: > On Thu, 13 Aug 2015, Jassi Brar wrote: >> >> > + >> >> > +static void mbox_test_prepare_message(struct mbox_client *client, void >> >> > *message) >> >> > +{ >> >

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-13 Thread Jassi Brar
On Thu, Aug 13, 2015 at 3:53 PM, Lee Jones wrote: > On Thu, 13 Aug 2015, Jassi Brar wrote: > >> On Thu, Aug 13, 2015 at 2:49 PM, Lee Jones wrote: >> > On Thu, 13 Aug 2015, Jassi Brar wrote: >> >> >> >> > + >> >> >> &

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-13 Thread Jassi Brar
On Thu, Aug 13, 2015 at 4:30 PM, Lee Jones wrote: > On Thu, 13 Aug 2015, Jassi Brar wrote: > >> On Thu, Aug 13, 2015 at 3:53 PM, Lee Jones wrote: >> > On Thu, 13 Aug 2015, Jassi Brar wrote: >> > >> >> On Thu, Aug 13, 2015 at 2:49 PM, Lee Jones wrot

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-13 Thread Jassi Brar
On Thu, Aug 13, 2015 at 5:10 PM, Lee Jones wrote: > On Thu, 13 Aug 2015, Jassi Brar wrote: > >> On Thu, Aug 13, 2015 at 4:30 PM, Lee Jones wrote: >> > On Thu, 13 Aug 2015, Jassi Brar wrote: >> > >> >> On Thu, Aug 13, 2015 at 3:53 PM, Lee Jones wrot

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-13 Thread Jassi Brar
On Thu, Aug 13, 2015 at 6:37 PM, Lee Jones wrote: > > Now just agree with me that mbox_request_chan() should fail on request > of a known bad configuration request and I can code all this up and > re-submit. :D > You make me look like a jerk :( My problem is not with validation as such. I see pr

Re: [PATCH v2 3/6] mailbox: Add support for ST's Mailbox IP

2015-08-13 Thread Jassi Brar
On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones wrote: > + > +static bool sti_mbox_tx_is_ready(struct mbox_chan *chan) > +{ > + struct sti_channel *chan_info = chan->con_priv; > + struct sti_mbox_device *mdev = chan_info->mdev; > + unsigned int instance = chan_info->instance; > +

Re: [PATCH v2 3/6] mailbox: Add support for ST's Mailbox IP

2015-08-14 Thread Jassi Brar
On Fri, Aug 14, 2015 at 12:03 PM, Lee Jones wrote: > On Thu, 13 Aug 2015, Jassi Brar wrote: >> On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones wrote: >> >> > + >> > +static bool sti_mbox_tx_is_ready(struct mbox_chan *chan) >> > +{ >> > +

Re: Using the mailbox subsystem for plain doorbells?

2016-05-09 Thread Jassi Brar
On Tue, May 10, 2016 at 5:15 AM, Stephen Warren wrote: > Jassi, > > Does the HW described below sound like something that should be represented > using the Linux kernel's mailbox subsystem, and related DT bindings? I think > the existing drivers/mailbox/pcc.c is similar, but wanted to double-check

Re: Using the mailbox subsystem for plain doorbells?

2016-05-10 Thread Jassi Brar
On Tue, May 10, 2016 at 9:26 PM, Stephen Warren wrote: > On 05/09/2016 09:29 PM, Jassi Brar wrote: > >> Some controllers need a mask/list of destination cpus, to which the >> irq is raised, written to some 'data' register. You too probably need >> to program the

[GIT PULL] Mailbox changes for v4.7

2016-05-21 Thread Jassi Brar
Hi Linus, The following changes since commit c3b46c73264b03000d1e18b22f5caf63332547c9: Linux 4.6-rc4 (2016-04-17 19:13:32 -0700) are available in the git repository at: git://git.linaro.org/landing-teams/working/fujitsu/integration.git mailbox-for-next for you to fetch changes up to c430cf

Re: [PATCH] dmaengine: pl330: Fix race in pl330_get_desc()

2016-04-26 Thread Jassi Brar
On Tue, Apr 26, 2016 at 10:00 PM, Robin Murphy wrote: > The current logic in pl330_get_desc() contains a clear race condition, > whereby if the descriptor pool is empty, we will create a new > descriptor, add it to the pool with the lock held, *release the lock*, > then try to remove it from the p

Re: [PATCH] dmaengine: pl330: Fix race in pl330_get_desc()

2016-04-27 Thread Jassi Brar
On 27 April 2016 at 19:17, Robin Murphy wrote: >> Instead of churning the code, I would suggest either check in a loop >> that we have a desc OR allocate 2 or NR_DEFAULT_DESC descriptors >> there. Probably we get more descriptors at the same cost of memory. > > > Having had a quick look into how

Re: [PATCH v3 1/3] mailbox: Add support for APM X-Gene platform mailbox driver

2015-11-20 Thread Jassi Brar
On Mon, Nov 9, 2015 at 11:35 PM, Duc Dang wrote: > X-Gene mailbox controller provides 8 mailbox channels, with > each channel has a dedicated interrupt line. > > [dhdang: rebase over 4.3-rc5, some minor changes to > address comment in v2 patch set] > Do you want this to go into git logs? > Signed

Re: [PATCH] mailbox: constify mbox_chan_ops structure

2015-11-30 Thread Jassi Brar
On Sun, Nov 29, 2015 at 6:20 PM, Julia Lawall wrote: > This mbox_chan_ops structure is never modified, so declare it as const, > like all the other mbox_chan_ops structures. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall > Applied, Thanks. -- To unsubscribe from this list:

Re: [PATCHv7 2/2] mailbox: Adding driver for Xilinx LogiCORE IP mailbox.

2015-12-02 Thread Jassi Brar
On 2 December 2015 at 22:56, Moritz Fischer wrote: > Hi Jassi, > > thanks for your feedback. > > On Mon, Aug 10, 2015 at 1:05 AM, Jassi Brar wrote: >> On Wed, Jul 15, 2015 at 6:30 AM, Moritz Fischer >> wrote: >> >>> + >>> +sta

Re: [PATCH 3/6] mailbox: Add support for ST's Mailbox IP

2015-07-21 Thread Jassi Brar
On Fri, Jul 17, 2015 at 5:34 PM, Lee Jones wrote: > ST's platforms currently support a maximum of 5 Mailboxes, one for > each of the supported co-processors situated on the platform. Each > Mailbox is divided up into 4 instances which consist of 32 channels. > Messages are passed between the appl

Re: [PATCH 3/6] mailbox: Add support for ST's Mailbox IP

2015-07-21 Thread Jassi Brar
On Tue, Jul 21, 2015 at 8:36 PM, Lee Jones wrote: > On Tue, 21 Jul 2015, Jassi Brar wrote: > >> However, you need some mechanism to check if you succeeded 'owning' >> the channel by reading back what you write to own the channel (not >> sure which is that re

Re: [PATCH 3/6] mailbox: Add support for ST's Mailbox IP

2015-07-21 Thread Jassi Brar
On Tue, Jul 21, 2015 at 9:22 PM, Lee Jones wrote: > On Tue, 21 Jul 2015, Jassi Brar wrote: > >> > >> >> > +static int sti_mbox_send_data(struct mbox_chan *chan, void *data) >> >> > +{ >> >> > + struct sti_channel *chan_info =

Re: [PATCH 3/6] mailbox: Add support for ST's Mailbox IP

2015-07-21 Thread Jassi Brar
On Tue, Jul 21, 2015 at 11:18 PM, Lee Jones wrote: > On Tue, 21 Jul 2015, Jassi Brar wrote: > >> On Tue, Jul 21, 2015 at 9:22 PM, Lee Jones wrote: >> > On Tue, 21 Jul 2015, Jassi Brar wrote: >> > >> >> > >> >> >> >

Re: [PATCH 1/2] Documentation: dt: mailbox: Add TI Message Manager

2016-02-08 Thread Jassi Brar
On Fri, Feb 5, 2016 at 10:04 PM, Nishanth Menon wrote: > + > + msgmgr: msgmgr@02a0 { > + compatible = "ti,k2g-message-manager", "ti,message-manager"; > + #mbox-cells = <1>; > + reg-names = "queue_proxy_region", "queue_state_debug_region"; > +

Re: [PATCH 1/2] Documentation: dt: mailbox: Add TI Message Manager

2016-02-09 Thread Jassi Brar
On Tue, Feb 9, 2016 at 6:01 PM, Nishanth Menon wrote: > On 02/08/2016 10:14 PM, Jassi Brar wrote: > > Thanks for the review. > >> On Fri, Feb 5, 2016 at 10:04 PM, Nishanth Menon wrote: >>> + >>> + msgmgr: msgmgr@02a0 { >>> +

Re: [PATCH 1/2] Documentation: dt: mailbox: Add TI Message Manager

2016-02-09 Thread Jassi Brar
On Tue, Feb 9, 2016 at 8:24 PM, Jassi Brar wrote: > On Tue, Feb 9, 2016 at 6:01 PM, Nishanth Menon wrote: >> On 02/08/2016 10:14 PM, Jassi Brar wrote: >> >>>> + >>> I think we should get rid of consumer specifics from the provider node... >> >> &

Re: [PATCH v7 0/4] mailbox: hisilicon: add Hi6220 mailbox driver

2016-02-15 Thread Jassi Brar
On Thu, Feb 4, 2016 at 8:54 PM, Leo Yan wrote: > Hi6220 mailbox supports up to 32 channels. Each channel is unidirectional > with a maximum message size of 8 words. I/O is performed using register > access (there is no DMA) and the cell raises an interrupt when messages > are received. > > This pa

Re: [PATCH 0/4] mailbox: mailbox-test: support single channel with separate Tx and Rx buffer

2016-02-15 Thread Jassi Brar
On Mon, Feb 15, 2016 at 5:47 PM, Sudeep Holla wrote: > Hi Jassi, > > On 11/02/16 17:13, Sudeep Holla wrote: >> >> Hi Lee, Jassi, >> >> Assuming mailbox-test was designed to be generic, I am trying to extend >> it to support single channel with separate Tx and Rx buffer. With these >> changes I am

Re: [PATCH v7 RESEND 0/4] mailbox: hisilicon: add Hi6220 mailbox driver

2016-02-26 Thread Jassi Brar
On Mon, Feb 15, 2016 at 7:20 PM, Leo Yan wrote: > Hi6220 mailbox supports up to 32 channels. Each channel is unidirectional > with a maximum message size of 8 words. I/O is performed using register > access (there is no DMA) and the cell raises an interrupt when messages > are received. > > This p

Re: [PATCH 1/2] Documentation: dt: mailbox: Add TI Message Manager

2016-02-26 Thread Jassi Brar
On Thu, Feb 11, 2016 at 10:33 AM, Nishanth Menon wrote: > Hi Jassi, > > On 02/10/2016 10:23 PM, Jassi Brar wrote: > [...] > > > Thanks for taking the time and checking the TRM, I apologize that the > actual details of the hardware block which was supposed to be in > s

Re: [PATCH] mailbox: add tx_prepare client callback

2014-11-11 Thread Jassi Brar
The client driver can > implement this callback to ensure the payload is copied to the > shared memory. > > Signed-off-by: Sudeep Holla > Cc: Jassi Brar > Cc: Arnd Bergmann > --- > drivers/mailbox/mailbox.c | 2 ++ > include/linux/mailbox_client.h | 1 + > 2 files c

Re: [PATCH V5 05/12] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-11-24 Thread Jassi Brar
On 18 November 2014 at 04:11, Andrew Bresticker wrote: > + > +static int tegra_xusb_mbox_send_data(struct mbox_chan *chan, void *data) > +{ > + struct tegra_xusb_mbox *mbox = to_tegra_mbox(chan->mbox); > + struct tegra_xusb_mbox_msg *msg = data; > + unsigned long flags; > +

Re: [PATCH V5 07/12] pinctrl: tegra-xusb: Add USB PHY support

2014-11-24 Thread Jassi Brar
On 18 November 2014 at 04:11, Andrew Bresticker wrote: > In addition to the PCIe and SATA PHYs, the XUSB pad controller also > supports 3 UTMI, 2 HSIC, and 2 USB3 PHYs. Each USB3 PHY uses a single > PCIe or SATA lane and is mapped to one of the three UTMI ports. > > The xHCI controller will also

Re: [PATCH V5 04/12] of: Add NVIDIA Tegra XUSB mailbox binding

2014-11-24 Thread Jassi Brar
ephen Warren Acked-by: Jassi Brar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v4] mailbox/omap: adapt to the new mailbox framework

2014-11-24 Thread Jassi Brar
the signature modified to take in the new mbox_chan handle instead > of the OMAP specific omap_mbox handle. The first 2 will be removed when > the OMAP mailbox driver is adapted to runtime_pm. The other exported > API omap_mbox_request_channel will be removed once existing leg

Re: [PATCH V6 00/12] Tegra xHCI support

2014-11-25 Thread Jassi Brar
On 25 November 2014 at 05:47, Andrew Bresticker wrote: > This series adds support for xHCI on NVIDIA Tegra SoCs. This includes: > - patches 1, 2, and 3: minor cleanups for mailbox framework and xHCI, > - patches 4 and 5: adding a driver for the mailbox used to communicate >with the xHCI con

Re: [PATCH v2] mailbox: add tx_prepare client callback

2014-11-26 Thread Jassi Brar
The client driver can > implement this callback to ensure the payload is copied to the > shared memory. > > Signed-off-by: Sudeep Holla > Cc: Jassi Brar > Cc: Arnd Bergmann > --- > drivers/mailbox/mailbox.c | 2 ++ > include/linux/mailbox_client.h | 3 +++ >

Re: [PATCH v4] mailbox/omap: adapt to the new mailbox framework

2014-11-26 Thread Jassi Brar
the signature modified to take in the new mbox_chan handle instead > of the OMAP specific omap_mbox handle. The first 2 will be removed when > the OMAP mailbox driver is adapted to runtime_pm. The other exported > API omap_mbox_request_channel will be removed once existing leg

Re: [GIT PULL] New Mailbox framework for 3.18

2014-10-20 Thread Jassi Brar
On 8 October 2014 11:09, Jassi Brar wrote: > Hi Linus, > > A framework for Mailbox controllers and clients have been cooking for > more than a year now. Everybody in the CC list had been copied on > patchset revisions and most of them have made sounds of approval, > though

Re: [PATCH] mailbox: arm-mhu: update the binding document

2015-05-19 Thread Jassi Brar
me minor updates to replace references to the driver with > the hardware IP. > > Cc: Rob Herring > Cc: Mark Rutland > Cc: Jassi Brar > Signed-off-by: Sudeep Holla > --- > .../devicetree/bindings/mailbox/arm-mhu.txt| 29 > ++ > 1 file ch

Re: [PATCH 1/3 v6] dt/bindings: Add binding for the BCM2835 mailbox driver

2015-05-13 Thread Jassi Brar
On Wed, May 13, 2015 at 1:27 PM, Lee Jones wrote: > On Tue, 12 May 2015, Jassi Brar wrote: >> On Wed, May 6, 2015 at 1:57 AM, Eric Anholt wrote: >> > From: Lubomir Rintel >> > >> > This patch was split out of Lubomir's original mailbox patch by Eric

Re: [PATCH 1/4] mailbox: add support for System Control and Power Interface(SCPI) protocol

2015-05-13 Thread Jassi Brar
ovides interface for all the client drivers using > SCPI to make use of the features offered by the SCP. > Is the SCPI specification available somewhere to look into? > Signed-off-by: Sudeep Holla > Cc: Rob Herring > Cc: Mark Rutland > CC: Jassi Brar > Cc: Liviu Dudau

Re: [PATCH 1/4] mailbox: add support for System Control and Power Interface(SCPI) protocol

2015-05-14 Thread Jassi Brar
On Wed, May 13, 2015 at 10:39 PM, Sudeep Holla wrote: > On 13/05/15 17:52, Jassi Brar wrote: >> >>> This patch adds support for System Control and Power Interface (SCPI) >>> Message Protocol used between the Application Cores(AP) and the System >>> Contro

Re: [PATCH 1/4] mailbox: add support for System Control and Power Interface(SCPI) protocol

2015-05-14 Thread Jassi Brar
On Thu, May 14, 2015 at 12:32 PM, Jassi Brar wrote: > > BTW is scpi_protocol.c meant/tested to work over arm_mhu.c? The spec > says so but I don't see how because you pass 'struct scpi_xfer*' as > the message whereas arm_mhu.c expects u32* > It seems your remote

Re: [PATCH 1/1] mailbox: Add ability for clients to request channels by name

2015-05-11 Thread Jassi Brar
On 29 April 2015 at 21:29, Lee Jones wrote: > This patch supplies a new framework API; mbox_request_channel_byname(). > > It works by supplying the usual client pointer as the first argument and > a string as the second. The API will search the client's node for a > 'mbox-names' property then req

Re: [PATCH v8 0/9] Tegra xHCI support

2015-05-11 Thread Jassi Brar
On Mon, May 4, 2015 at 11:06 PM, Andrew Bresticker wrote: > This series adds support for xHCI on NVIDIA Tegra SoCs. This includes: > - patches 1, 2, and 3: minor cleanups for mailbox framework and xHCI, > - patches 4 and 5: adding an MFD driver for the XUSB cmoplex, > - patches 6 and 7: adding

Re: [PATCH 1/3 v6] dt/bindings: Add binding for the BCM2835 mailbox driver

2015-05-11 Thread Jassi Brar
On Wed, May 6, 2015 at 1:57 AM, Eric Anholt wrote: > From: Lubomir Rintel > > This patch was split out of Lubomir's original mailbox patch by Eric > Anholt, and the required properties documentation and examples have > been filled out more completely and updated for the driver being > changed to

Re: [PATCH 3/3] mailbox: Add support for ST's Mailbox IP

2015-03-18 Thread Jassi Brar
On Wed, Mar 18, 2015 at 6:42 PM, Lee Jones wrote: > On Wed, 04 Mar 2015, Jassi Brar wrote: > >> > + >> > + if ((!data) || (!sti_mbox_chan_is_tx(mbox))) >> > >> nit: too much protection. > > What makes you think that? > Usually we write

Re: [PATCH 3/3] mailbox: Add support for ST's Mailbox IP

2015-03-18 Thread Jassi Brar
On Wed, Mar 18, 2015 at 6:47 PM, Lee Jones wrote: > On Tue, 03 Mar 2015, Jassi Brar wrote: > >> On 3 March 2015 at 17:04, Arnd Bergmann wrote: >> > On Tuesday 03 March 2015 10:41:23 Lee Jones wrote: >> >> + >> >> +/* >> >>

Re: [PATCH 3/3] mailbox: Add support for ST's Mailbox IP

2015-03-18 Thread Jassi Brar
On Wed, Mar 18, 2015 at 8:56 PM, Lee Jones wrote: > On Wed, 18 Mar 2015, Jassi Brar wrote: >> >> > + mbox->irq = >> >> > irq_create_mapping(mbinst->irq_domain, >> >> > +

Re: [PATCH 3/3] mailbox: Add support for ST's Mailbox IP

2015-03-18 Thread Jassi Brar
On Wed, Mar 18, 2015 at 9:04 PM, Lee Jones wrote: > On Wed, 18 Mar 2015, Jassi Brar wrote: > >> On Wed, Mar 18, 2015 at 6:47 PM, Lee Jones wrote: >> > On Tue, 03 Mar 2015, Jassi Brar wrote: >> > >> >> On 3 March 2015 at 17:04, Arnd Bergmann wrote: >

Re: [PATCH v2] mailbox: Add Altera mailbox driver

2015-02-01 Thread Jassi Brar
On Mon, Dec 22, 2014 at 3:14 PM, Ley Foon Tan wrote: ... > diff --git a/drivers/mailbox/mailbox-altera.c > b/drivers/mailbox/mailbox-altera.c > new file mode 100644 > index 000..8019795 > --- /dev/null > +++ b/drivers/mailbox/mailbox-altera.c > @@ -0,0 +1,385 @@ > +/* > + * Copyright Altera

[PATCH 1/2] mailbox: check for bit set before polling

2015-02-01 Thread Jassi Brar
From: Jassi Brar Before polling we just need to see if the TXDONE_BY_POLL bit is set in txdone_method. There may be another bit (method) specified as well, like TXDONE_BY_ACK. Signed-off-by: Jassi Brar --- drivers/mailbox/mailbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH 3/3] mailbox: Add support for ST's Mailbox IP

2015-03-03 Thread Jassi Brar
On 3 March 2015 at 17:04, Arnd Bergmann wrote: > On Tuesday 03 March 2015 10:41:23 Lee Jones wrote: >> + >> +/* >> + * struct sti_mbox_msg - sti mailbox message description >> + * @dsize: data payload size >> + * @pdata: message data payload >> + */ >> +struct sti_mbox_msg

Re: [PATCH 3/3] mailbox: Add support for ST's Mailbox IP

2015-03-04 Thread Jassi Brar
On 3 March 2015 at 16:11, Lee Jones wrote: > --- > drivers/mailbox/Kconfig | 7 + > drivers/mailbox/Makefile | 2 + > drivers/mailbox/mailbox-sti.c | 664 > ++ > include/linux/mailbox_sti.h | 128 > How about the header in include

Re: [PATCH 2/3] mailbox: dt: Supply bindings for ST's Mailbox IP

2015-03-04 Thread Jassi Brar
On 3 March 2015 at 16:11, Lee Jones wrote: > Signed-off-by: Lee Jones > --- > .../devicetree/bindings/mailbox/sti-mailbox.txt| 66 > ++ > 1 file changed, 66 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mailbox/sti-mailbox.txt > > diff --git a/Doc

[GIT PULL] Mailbox changes for 3.20

2015-02-10 Thread Jassi Brar
f62092f6d77dfd9214ae753a24b76ba4ecd801d7: mailbox: Add Altera mailbox driver (2015-02-06 10:58:27 +0530) Jassi Brar (1): mailbox: check for bit set before polling Ley Foon Tan (1): mailbox: Add Altera mailbox driver Wei

Re: [PATCH 3/4] clk: Provide always-on clock support

2015-02-28 Thread Jassi Brar
On 28 February 2015 at 02:44, Lee Jones wrote: > Lots of platforms contain clocks which if turned off would prove fatal. > The only way to recover from these catastrophic failures is to restart > the board(s). Now, when a clock is registered with the framework it is > compared against a list of p

Re: [PATCH 3/4] clk: Provide always-on clock support

2015-03-02 Thread Jassi Brar
On Mon, Mar 2, 2015 at 2:06 PM, Lee Jones wrote: > On Sat, 28 Feb 2015, Jassi Brar wrote: > >> On 28 February 2015 at 02:44, Lee Jones wrote: >> > Lots of platforms contain clocks which if turned off would prove fatal. >> > The only way to recover from these catas

Re: [PATCH 3/4] clk: Provide always-on clock support

2015-03-02 Thread Jassi Brar
On 2 March 2015 at 15:48, Lee Jones wrote: > On Mon, 02 Mar 2015, Jassi Brar wrote: > >> On Mon, Mar 2, 2015 at 2:06 PM, Lee Jones wrote: >> > On Sat, 28 Feb 2015, Jassi Brar wrote: >> > >> >> On 28 February 2015 at 02:44, Lee Jones wrote: >>

Re: [PATCH] Mailbox: Complete wait event only if Tx was successful

2014-12-12 Thread Jassi Brar
On 11 December 2014 at 01:46, Ashwin Chaugule wrote: > If a wait_for_completion_timeout() call returns due to a timeout, > the mbox code can still call complete() after returning from the wait. > This can cause subsequent transmissions on a channel to fail, since > the wait_for_completion_timeout(

Re: [PATCH V2 2/2] mailbox: Introduce TI message manager driver

2016-03-14 Thread Jassi Brar
On Tue, Mar 8, 2016 at 8:07 PM, Nishanth Menon wrote: > Jassi, > > On Tue, Mar 8, 2016 at 1:10 AM, Jassi Brar wrote: >> On Tue, Mar 8, 2016 at 2:18 AM, Nishanth Menon wrote: >>> On 03/07/2016 12:31 PM, Jassi Brar wrote: >>>> On Fri, Mar 4, 20

Re: [PATCH V2 2/2] mailbox: Introduce TI message manager driver

2016-03-15 Thread Jassi Brar
On Tue, Mar 15, 2016 at 10:35 PM, Nishanth Menon wrote: > On Tue, Mar 15, 2016 at 12:31 AM, Jassi Brar wrote: >> On Tue, Mar 8, 2016 at 8:07 PM, Nishanth Menon wrote: >>> Jassi, >>> >>> On Tue, Mar 8, 2016 at 1:10 AM, Jassi Brar wrote: >>>> On Tu

Re: [PATCH 0/4] OMAP Mailbox legacy platform device support removal

2016-04-25 Thread Jassi Brar
On Wed, Apr 6, 2016 at 6:37 PM, Suman Anna wrote: > Hi Jassi, > > This series cleans up the OMAP Mailbox driver dropping the > support for legacy non-DT platform devices. The infrastructure > for creating any such devices has all been cleaned up from the > mach-omap2 layers. > > The removal from t

Re: [PATCH v2 0/5] mailbox: A few fixes due for the v4.6 -rcs

2016-04-12 Thread Jassi Brar
On Tue, Apr 12, 2016 at 12:57 PM, Lee Jones wrote: > On Wed, 23 Mar 2016, Lee Jones wrote: > >> Hi Jassi, >> >> Resending these with patches 1 and 2 merged, as requested. > > Jassi, > > Not heard anything from you in quite some time now. > Please feel free to call as soon as it goes beyond 2weeks.

[GIT PULL] Mailbox fixes for v4.6-rc

2016-04-13 Thread Jassi Brar
Hi Linus, The following changes since commit 3c9688876ace9ca4cd8630e5fbba8bb28235990a: Revert "ib_srpt: Convert to percpu_ida tag allocation" (2016-04-07 18:16:20 -0700) are available in the git repository at: git://git.linaro.org/landing-teams/working/fujitsu/integration.git mailbox-devel

[GIT PULL] Mailbox changes for v4.4

2015-11-06 Thread Jassi Brar
quirk to fix AM33xx CPU Idle Jassi Brar (1): mailbox: mailbox-test: avoid reading iomem twice Lee Jones (5): mailbox: dt: Supply bindings for ST's Mailbox IP mailbox: Add support for ST's Mailbox IP mailbox: Add generic mechanism for testing Mailbox Controllers

Re: [RFC 2/8] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2015-11-08 Thread Jassi Brar
On Mon, Nov 2, 2015 at 5:25 PM, Martyn Welch wrote: > From: Andrew Bresticker > > The Tegra xHCI controller's firmware communicates requests to the host > processor through a mailbox interface. While there is only a single > physical channel, messages sent by the controller can be divided > into

Re: linux-next: build failure after merge of the mailbox tree

2015-11-03 Thread Jassi Brar
On 1 November 2015 at 17:42, Stephen Rothwell wrote: > Hi Jassi, > > After merging the mailbox tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/mailbox/mailbox-test.c: In function 'mbox_test_receive_message': > drivers/mailbox/mailbox-test.c:226:11: error: impli

Re: [PATCH v5 1/2] dt-bindings: mailbox: add binding doc for the ARM SMC/HVC mailbox

2019-08-29 Thread Jassi Brar
On Tue, Aug 27, 2019 at 10:02 PM Peng Fan wrote: > > From: Peng Fan > > The ARM SMC/HVC mailbox binding describes a firmware interface to trigger > actions in software layers running in the EL2 or EL3 exception levels. > The term "ARM" here relates to the SMC instruction as part of the ARM > inst

Re: [PATCH v5 1/2] dt-bindings: mailbox: add binding doc for the ARM SMC/HVC mailbox

2019-08-30 Thread Jassi Brar
On Fri, Aug 30, 2019 at 1:28 AM Peng Fan wrote: > > > +examples: > > > + - | > > > +sram@91 { > > > + compatible = "mmio-sram"; > > > + reg = <0x0 0x93f000 0x0 0x1000>; > > > + #address-cells = <1>; > > > + #size-cells = <1>; > > > + ranges = <0 0x0 0x93f000 0x10

Re: [PATCH v5 1/2] dt-bindings: mailbox: add binding doc for the ARM SMC/HVC mailbox

2019-08-30 Thread Jassi Brar
On Fri, Aug 30, 2019 at 2:37 AM Peng Fan wrote: > > Hi Jassi, > > > Subject: Re: [PATCH v5 1/2] dt-bindings: mailbox: add binding doc for the > > ARM > > SMC/HVC mailbox > > > > On Fri, Aug 30, 2019 at 1:28 AM Peng Fan wrote: > > > > > > > +examples: > > > > > + - | > > > > > +sram@91 {

Re: [PATCH v5 1/2] dt-bindings: mailbox: add binding doc for the ARM SMC/HVC mailbox

2019-08-30 Thread Jassi Brar
On Fri, Aug 30, 2019 at 3:07 AM Peng Fan wrote: > > > Subject: Re: [PATCH v5 1/2] dt-bindings: mailbox: add binding doc for the > > ARM > > SMC/HVC mailbox > > > > On Fri, Aug 30, 2019 at 2:37 AM Peng Fan wrote: > > > > > > Hi Jassi, > > > > > > > Subject: Re: [PATCH v5 1/2] dt-bindings: mailbox

Re: [PATCH v5 1/2] dt-bindings: mailbox: add binding doc for the ARM SMC/HVC mailbox

2019-08-30 Thread Jassi Brar
On Fri, Aug 30, 2019 at 4:32 AM Sudeep Holla wrote: > > On Fri, Aug 30, 2019 at 02:52:40AM -0500, Jassi Brar wrote: > > On Fri, Aug 30, 2019 at 2:37 AM Peng Fan wrote: > > [...] > > > > > > > If I get your point correctly, > > > On UP, both could n

Re: [PATCH v2 1/2] dt-bindings: milbeaut-m10v-hdmac: Add Socionext Milbeaut HDMAC bindings

2019-09-03 Thread Jassi Brar
On Wed, Sep 4, 2019 at 12:51 AM Vinod Koul wrote: > > On 18-08-19, 00:17, jassisinghb...@gmail.com wrote: > > From: Jassi Brar > > > > Document the devicetree bindings for Socionext Milbeaut HDMAC > > controller. Controller has upto 8 floating channels, that nee

Re: [PATCH 2/2] dmaengine: milbeaut-hdmac: Add HDMAC driver for Milbeaut platforms

2019-08-15 Thread Jassi Brar
On Mon, Jun 24, 2019 at 1:47 AM Vinod Koul wrote: > > On 12-06-19, 19:52, jassisinghb...@gmail.com wrote: > > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > Do we need both, IIRC of_dma.h does

Re: [PATCH v5 1/2] dt-bindings: mailbox: add binding doc for the ARM SMC/HVC mailbox

2019-09-10 Thread Jassi Brar
On Mon, Sep 9, 2019 at 8:32 AM Andre Przywara wrote: > > On Fri, 30 Aug 2019 03:12:29 -0500 > Jassi Brar wrote: > > Hi, > > > On Fri, Aug 30, 2019 at 3:07 AM Peng Fan wrote: > > > > > > > Subject: Re: [PATCH v5 1/2] dt-bindings: mailbox: add bin

Re: [PATCH v5 1/2] dt-bindings: mailbox: add binding doc for the ARM SMC/HVC mailbox

2019-09-10 Thread Jassi Brar
On Mon, Sep 9, 2019 at 10:42 AM Andre Przywara wrote: > > On Wed, 28 Aug 2019 03:02:58 + > Peng Fan wrote: > > Hi, > > sorry for the late reply, eventually managed to have a closer look on this. > > > From: Peng Fan > > > > The ARM SMC/HVC mailbox binding describes a firmware interface to tr

Re: [PATCH v5 1/2] dt-bindings: mailbox: add binding doc for the ARM SMC/HVC mailbox

2019-09-11 Thread Jassi Brar
On Wed, Sep 11, 2019 at 10:03 AM Andre Przywara wrote: > > On Tue, 10 Sep 2019 21:44:11 -0500 > Jassi Brar wrote: > > Hi, > > > On Mon, Sep 9, 2019 at 10:42 AM Andre Przywara > > wrote: > > > > > > On Wed,

Re: [PATCH V6 1/2] dt-bindings: mailbox: add binding doc for the ARM SMC/HVC mailbox

2019-09-17 Thread Jassi Brar
On Tue, Sep 17, 2019 at 12:31 PM Andre Przywara wrote: > > On Mon, 16 Sep 2019 09:44:37 + > Peng Fan wrote: > > Hi, > > > From: Peng Fan > > > > The ARM SMC/HVC mailbox binding describes a firmware interface to trigger > > actions in software layers running in the EL2 or EL3 exception levels

Re: [BUGFIX PATCH] selftests: Use real temporary working directory for archiving

2019-10-04 Thread Jassi Brar
test${ext} created!" > > # clean up install directory > -rm -rf kselftest > +rm -rf $tmpdir > } > > main "$@" > FWIW, Acked-by: Jassi Brar -- Linaro.org │ Open source software for ARM SoCs | Follow Linaro http://facebook.com/pages/Linaro/155974581091106 - http://twitter.com/#!/linaroorg - http://linaro.org/linaro-blog

Re: [PATCH V6 2/2] mailbox: introduce ARM SMC based mailbox

2019-09-18 Thread Jassi Brar
On Wed, Sep 18, 2019 at 5:00 AM Andre Przywara wrote: > > > > > > > > > + }; > > > > +}; > > > > > > If this is the data structure that this mailbox controller uses, I would > > > expect > > > this to be documented somewhere, or even exported. > > > > Export this structure in include/linux/mailb

Re: [PATCH V6 1/2] dt-bindings: mailbox: add binding doc for the ARM SMC/HVC mailbox

2019-09-18 Thread Jassi Brar
On Wed, Sep 18, 2019 at 3:53 AM Peng Fan wrote: > > > > > > > + > > > > + "#mbox-cells": > > > > +const: 1 > > > > > > Why is this "1"? What is this number used for? It used to be the channel > > > ID, > > but since you are describing a single channel controller only, this should > > be 0

Re: [PATCH V6 1/2] dt-bindings: mailbox: add binding doc for the ARM SMC/HVC mailbox

2019-09-18 Thread Jassi Brar
On Wed, Sep 18, 2019 at 4:44 AM Andre Przywara wrote: > > > which needs 9 arguments to work. The fact that the fist argument is > > always going to be same on a platform is just the way we use this > > instruction. > > > > > We should be as strict as possible to avoid any security issues. > > > >

Re: [PATCH V6 2/2] mailbox: introduce ARM SMC based mailbox

2019-09-18 Thread Jassi Brar
On Wed, Sep 18, 2019 at 8:58 AM Andre Przywara wrote: > > > > Also there is mbox_chan_txdone() with which a controller driver can > > > signal TX completion explicitly. > > > > > No. Controller can use that only if it has specified txdone_irq, which > > is not the case here. > > I see. So does t

Re: [PATCH V6 1/2] dt-bindings: mailbox: add binding doc for the ARM SMC/HVC mailbox

2019-09-18 Thread Jassi Brar
On Wed, Sep 18, 2019 at 9:46 AM Andre Przywara wrote: > > On Wed, 18 Sep 2019 09:19:46 -0500 > Jassi Brar wrote: > > Hi, > > > On Wed, Sep 18, 2019 at 4:44 AM Andre Przywara > > wrote: > > > > > > > > > which needs 9 arguments to work. T

[GIT PULL] Mailbox changes for v5.4

2019-09-18 Thread Jassi Brar
Hi Linus, The following changes since commit f74c2bb98776e2de508f4d607cd519873065118e: Linux 5.3-rc8 (2019-09-08 13:33:15 -0700) are available in the Git repository at: git://git.linaro.org/landing-teams/working/fujitsu/integration.git tags/mailbox-v5.4 for you to fetch changes up to 556a09

Re: [PATCH 1/3] mailbox: Add ability for clients to abort data in channel

2019-01-16 Thread Jassi Brar
On Tue, Jan 15, 2019 at 11:07 PM CK Hu wrote: > > This patch supplies a new framework API, mbox_abort_channel(), and > a new controller interface, abort_data(). > > For some client's application, it need to clean up the data in channel > but keep the channel so it could send data to channel later.

Re: [PATCH 1/3] mailbox: Add ability for clients to abort data in channel

2019-01-17 Thread Jassi Brar
On Thu, Jan 17, 2019 at 2:00 AM CK Hu wrote: > > Hi, Jassi: > > On Wed, 2019-01-16 at 10:22 -0600, Jassi Brar wrote: > > On Tue, Jan 15, 2019 at 11:07 PM CK Hu wrote: > > > > > > This patch supplies a new framework API, mbox_abort_channel(), and > >

[GIT PULL] Mailbox changes for v5.2

2019-05-10 Thread Jassi Brar
Hi Linus, The following changes since commit 37624b58542fb9f2d9a70e6ea006ef8a5f66c30b: Linux 5.1-rc7 (2019-04-28 17:04:13 -0700) are available in the Git repository at: git://git.linaro.org/landing-teams/working/fujitsu/integration.git tags/mailbox-v5.2 for you to fetch changes up to 8fbbf

Re: [PATCH 0/2] mailbox: arm: introduce smc triggered mailbox

2019-05-26 Thread Jassi Brar
On Thu, May 23, 2019 at 12:50 AM Peng Fan wrote: > > This is a modified version from Andre Przywara's patch series > https://lore.kernel.org/patchwork/cover/812997/. > Can you please specify exact modifications on top of Andre's last submission? As in "Changes since v1: " Thanks.

[GIT PULL] Mailbox changes for v5.3

2019-07-13 Thread Jassi Brar
Hi Linus, The following changes since commit 6fbc7275c7a9ba97877050335f290341a1fd8dbf: Linux 5.2-rc7 (2019-06-30 11:25:36 +0800) are available in the Git repository at: git://git.linaro.org/landing-teams/working/fujitsu/integration.git tags/mailbox-v5.3 for you to fetch changes up to 25777

Re: [PATCH 1/4] mailbox: arm_mhuv2: add device tree binding documentation

2019-08-13 Thread Jassi Brar
On Fri, Aug 2, 2019 at 5:41 AM Morten Borup Petersen wrote: > > > > On 7/31/19 9:31 AM, Jassi Brar wrote: > > On Sun, Jul 28, 2019 at 4:28 PM Morten Borup Petersen > > wrote: > >> > >> > >> > >> On 7/25/19 7:49 AM, Jassi Brar wrote: &g

Re: [PATCH 1/4] mailbox: arm_mhuv2: add device tree binding documentation

2019-08-14 Thread Jassi Brar
On Wed, Aug 14, 2019 at 5:05 AM Sudeep Holla wrote: > > On Tue, Aug 13, 2019 at 11:36:56AM -0500, Jassi Brar wrote: > [...] > > > > >> > > > >> As mentioned in the response to your initial comment, the driver does > > > >> not curren

Re: [PATCH 1/4] mailbox: arm_mhuv2: add device tree binding documentation

2019-07-24 Thread Jassi Brar
On Sun, Jul 21, 2019 at 4:58 PM Jassi Brar wrote: > > On Wed, Jul 17, 2019 at 2:26 PM Tushar Khandelwal > wrote: > > > diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhuv2.txt > > b/Documentation/devicetree/bindings/mailbox/arm,mhuv2.txt > >

Re: [PATCH 1/4] mailbox: arm_mhuv2: add device tree binding documentation

2019-07-31 Thread Jassi Brar
On Sun, Jul 28, 2019 at 4:28 PM Morten Borup Petersen wrote: > > > > On 7/25/19 7:49 AM, Jassi Brar wrote: > > On Sun, Jul 21, 2019 at 4:58 PM Jassi Brar wrote: > >> > >> On Wed, Jul 17, 2019 at 2:26 PM Tushar Khandelwal > >> wrote: > >>

Re: [PATCH 0/2] Add Mailbox support for TI K3 SoCs

2019-06-24 Thread Jassi Brar
On Mon, Jun 24, 2019 at 3:39 PM Suman Anna wrote: > > Hi Jassi, > > On 6/4/19 12:01 PM, Suman Anna wrote: > > Hi Jassi, > > > > The following series adds the support for the Mailbox IP present > > within the Main NavSS module on the newer TI K3 AM65x and J721E SoCs. > > > > The Mailbox IP is simil

Re: [PATCH V2 2/2] mailbox: introduce ARM SMC based mailbox

2019-06-25 Thread Jassi Brar
On Tue, Jun 25, 2019 at 2:30 AM Peng Fan wrote: > > Hi Jassi > > > Subject: Re: [PATCH V2 2/2] mailbox: introduce ARM SMC based mailbox > > > > On Mon, Jun 3, 2019 at 3:28 AM wrote: > > > > > > From: Peng Fan > > > > > > This mailbox driver implements a mailbox which signals transmitted > > > da

Re: [PATCH V2 2/2] mailbox: introduce ARM SMC based mailbox

2019-06-26 Thread Jassi Brar
On Wed, Jun 26, 2019 at 8:31 AM Peng Fan wrote: > > > Hi All, > > > Subject: Re: [PATCH V2 2/2] mailbox: introduce ARM SMC based mailbox > > > > On Tue, Jun 25, 2019 at 2:30 AM Peng Fan wrote: > > > > > > Hi Jassi > > > > > > > Subject: Re: [PATCH V2 2/2] mailbox: introduce ARM SMC based mailbox

Re: [PATCH V2 2/2] mailbox: introduce ARM SMC based mailbox

2019-06-26 Thread Jassi Brar
On Wed, Jun 26, 2019 at 11:44 AM Florian Fainelli wrote: > > On 6/26/19 6:31 AM, Peng Fan wrote: > >>> The firmware driver might not have func-id, such as SCMI/SCPI. > >>> So add an optional func-id to let smc mailbox driver could > >>> use smc SiP func id. > >>> > >> There is no end to conforming

Re: [PATCH V2 2/2] mailbox: introduce ARM SMC based mailbox

2019-06-27 Thread Jassi Brar
On Thu, Jun 27, 2019 at 4:09 AM Sudeep Holla wrote: > > On Wed, Jun 26, 2019 at 01:27:41PM -0500, Jassi Brar wrote: > > On Wed, Jun 26, 2019 at 11:44 AM Florian Fainelli > > wrote: > > > > > > On 6/26/19 6:31 AM, Peng Fan wrote: > > > >>> Th

<    1   2   3   4   5   6   >