[PATCHv3 3/6] mailbox: pl320: Introduce common API driver

2014-02-15 Thread Jassi Brar
Convert the PL320 controller driver to work with the common mailbox API. Also convert the only user of PL320, highbank-cpufreq.c to work with thee API. Drop the obsoleted driver pl320-ipc.c Signed-off-by: Jassi Brar --- drivers/cpufreq/highbank-cpufreq.c | 22 +++- drivers/mailbox/Makefile

[PATCHv3 6/6] mailbox: move the internal definitions into a private file

2014-02-15 Thread Jassi Brar
From: Suman Anna This is needed for extracting the omap_mbox. The OMAP mailbox code has a need for exporting some pre-existing API to not break the current clients. Signed-off-by: Suman Anna --- drivers/mailbox/mailbox.c | 62 +- drivers/mailbox/mailbox_int

[PATCHv3 5/6] mailbox: Fix deleteing poll timer

2014-02-15 Thread Jassi Brar
From: LeyFoon Tan Try to delete the timer only if it was init/used. Signed-off-by: LeyFoon Tan Signed-off-by: Jassi Brar --- drivers/mailbox/mailbox.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index f8b31da

Re: [PATCHv3 2/6] mailbox: Introduce a new common API

2014-02-15 Thread Jassi Brar
[merging replies in one post] On Sun, Feb 16, 2014 at 12:45 AM, Greg KH wrote: > On Sat, Feb 15, 2014 at 11:55:27PM +0530, Jassi Brar wrote: >> +/* >> + * Call for IPC controller drivers to register a controller, adding >> + * its channels/mailboxes to the global

Re: [PATCHv3 6/6] mailbox: move the internal definitions into a private file

2014-02-15 Thread Jassi Brar
On Sun, Feb 16, 2014 at 12:46 AM, Greg KH wrote: > On Sat, Feb 15, 2014 at 11:57:02PM +0530, Jassi Brar wrote: >> From: Suman Anna >> >> This is needed for extracting the omap_mbox. The OMAP mailbox >> code has a need for exporting some pre-existing API to not &

Re: [PATCHv3] Generic Mailbox API

2014-02-16 Thread Jassi Brar
On 17 February 2014 11:27, Craig McGeachie wrote: > On 16/02/14 07:22, Jassi Brar wrote: >> >> Hello, >> >>Here is what the generic mailbox api looks like after modifications >> to make it work with 5 different platforms. >> Major feedback from Suman

Re: [PATCHv3] Generic Mailbox API

2014-02-16 Thread Jassi Brar
On Mon, Feb 17, 2014 at 11:33 AM, Craig McGeachie wrote: > On 16/02/14 07:22, Jassi Brar wrote: >> >> Hello, >> >>Here is what the generic mailbox api looks like after modifications >> to make it work with 5 different platforms. >> Major feedback

Re: [PATCH v3 1/3] dma: Support multiple interleaved frames with non-contiguous memory

2014-02-17 Thread Jassi Brar
On 15 February 2014 17:30, Srikanth Thokala wrote: > The current implementation of interleaved DMA API support multiple > frames only when the memory is contiguous by incrementing src_start/ > dst_start members of interleaved template. > > But, when the memory is non-contiguous it will restrict sl

Re: [PATCHv3 2/6] mailbox: Introduce a new common API

2014-02-17 Thread Jassi Brar
Hi Courtney, On 18 February 2014 06:22, Courtney Cavin wrote: > On Sat, Feb 15, 2014 at 07:25:27PM +0100, Jassi Brar wrote: >> +request_token_t ipc_send_message(void *channel, void *mssg) >> +{ >> + struct ipc_chan *chan = (struct ipc_chan *)channel; >>

Re: [PATCH] dma: pl330: Add support for DMA_PAUSE command

2014-05-14 Thread Jassi Brar
On Wed, May 14, 2014 at 8:53 AM, Tushar Behera wrote: > While playing back audio, pmc_dmaengine requests the DMA channel to > stop DMA transmission through DMA_PAUSE command. > > Currently PL330 driver doesn't support DMA pause command, leaving > the DMA state inconsistent when the system resumes.

Re: [PATCH] dma: pl330: Add support for DMA_PAUSE command

2014-05-14 Thread Jassi Brar
On Wed, May 14, 2014 at 5:37 PM, Tushar Behera wrote: > On 14 May 2014 17:29, Jassi Brar wrote: >> On Wed, May 14, 2014 at 8:53 AM, Tushar Behera >> wrote: >>> While playing back audio, pmc_dmaengine requests the DMA channel to >>> stop DMA trans

[PATCHv5 0/4] Common Mailbox Framework

2014-05-14 Thread Jassi Brar
Hi, Here is the next revision of Mailbox framwork. Changes since v4: o Common DT binding for Controller and Client drivers As a result, discard string based channel matching o Provide for an atomic 'peek' api, that a client could call to trigger the controller driver push data upwards.

[PATCHv5 1/4] mailbox: rename pl320-ipc specific mailbox.h

2014-05-14 Thread Jassi Brar
From: Suman Anna The patch 30058677 "ARM / highbank: add support for pl320 IPC" added a pl320 IPC specific header file as a generic mailbox.h. This file has been renamed appropriately to allow the introduction of the generic mailbox API framework. Acked-by: Mark Langsdorf Cc: Rafael J. Wysocki

[PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-05-14 Thread Jassi Brar
should have a look at include/linux/mailbox_controller.h Signed-off-by: Jassi Brar --- .../devicetree/bindings/mailbox/mailbox.txt| 30 ++ drivers/mailbox/Makefile | 4 + drivers/mailbox/mailbox.c | 480 + include

[PATCHv5 3/4] mailbox: Fix TX completion init

2014-05-14 Thread Jassi Brar
From: LeyFoon Tan For fast TX the complete could be called before being initialized as follows mbox_send_message --> poll_txdone --> tx_tick --> complete(&chan->tx_complete) Init the completion early enough to fix the race. Signed-off-by: LeyFoon Tan Signed-off-by: Jassi Br

[PATCHv5 4/4] mailbox: Fix deleteing poll timer

2014-05-14 Thread Jassi Brar
From: LeyFoon Tan Try to delete the timer only if it was init/used. Signed-off-by: LeyFoon Tan Signed-off-by: Jassi Brar --- drivers/mailbox/mailbox.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index befb256

Re: [PATCH v6 2/2] dma: Add Xilinx AXI Video Direct Memory Access Engine driver support

2014-03-23 Thread Jassi Brar
On Tue, Mar 18, 2014 at 12:36 AM, Srikanth Thokala wrote: > + > +/** > + * xilinx_vdma_prep_slave_sg - prepare a descriptor for a DMA_SLAVE > transaction Should be xilinx_vdma_dma_prep_interleaved here. > +/** > + * xilinx_vdma_channel_set_config - Configure VDMA channel > + * Run-time configu

Re: [PATCH v6 2/2] dma: Add Xilinx AXI Video Direct Memory Access Engine driver support

2014-03-24 Thread Jassi Brar
On 24 March 2014 14:30, Srikanth Thokala wrote: > Hi Jassi, > > Thanks for the Acked-by. > > On Mon, Mar 24, 2014 at 11:50 AM, Jassi Brar wrote: >> On Tue, Mar 18, 2014 at 12:36 AM, Srikanth Thokala >> wrote: >> >>> + >>> +/** >>>

Re: [PATCH v6 2/2] dma: Add Xilinx AXI Video Direct Memory Access Engine driver support

2014-03-24 Thread Jassi Brar
view. > From email below Srikanth got ACK from Jassi > and there should be a small fix which Srikanth will send in v7 > which I hope will be the last version. > +1 Any change may come incrementally. Btw, here's the ack Acked-by: Jassi Brar -- To unsubscribe from this list: send t

Re: [PATCH v6 2/2] dma: Add Xilinx AXI Video Direct Memory Access Engine driver support

2014-03-24 Thread Jassi Brar
On Mon, Mar 24, 2014 at 8:44 PM, Srikanth Thokala wrote: > On Mon, Mar 24, 2014 at 4:21 PM, Jassi Brar > wrote: >> On 24 March 2014 14:30, Srikanth Thokala wrote: >>> Hi Jassi, >>> >>> Thanks for the Acked-by. >>> >>> On Mon, Mar 24, 2

Re: [PATCHv7 2/5] mailbox: Introduce framework for mailbox

2014-06-18 Thread Jassi Brar
On 18 June 2014 22:33, Kevin Hilman wrote: > Jassi Brar writes: > >> On 18 June 2014 05:57, Kevin Hilman wrote: >>> Jassi Brar writes: >>> >>>> Introduce common framework for client/protocol drivers and >>>> controller drivers of Inter-

Re: [PATCH v3 0/3] Qualcomm Resource Power Manager driver

2014-06-18 Thread Jassi Brar
n there. >>> >>> Kevin >> >> I dont agree, I think having this in drivers/soc means that we can >> clearly go through drivers/soc in the future and look for patterns >> across SoCs that should be re-factored. > > I don't believe that was the goa

Re: [PATCH v3 0/3] Qualcomm Resource Power Manager driver

2014-06-19 Thread Jassi Brar
On 19 June 2014 23:52, Bjorn Andersson wrote: > On Wed, Jun 18, 2014 at 8:55 PM, Jassi Brar > wrote: >> On 18 June 2014 22:14, Kevin Hilman wrote: > [...] >>> Thinking more about what this RPM driver actually does, and since you >>> mentioned patterns across So

Re: [PATCHv7 2/5] mailbox: Introduce framework for mailbox

2014-06-19 Thread Jassi Brar
On 20 June 2014 00:33, Matt Porter wrote: > On Thu, Jun 19, 2014 at 07:17:11PM +0100, Sudeep Holla wrote: > >> >+ * After startup and before shutdown any data received on the chan >> >+ * is passed on to the API via atomic mbox_chan_received_data(). >> >+ * The controller should ACK the RX only af

Re: [PATCH v3 0/3] Qualcomm Resource Power Manager driver

2014-06-20 Thread Jassi Brar
lmented as a controller in the new common mailbox framwork[1] being >> worked on by Jassi Brar (added to Cc.) >> >> IIUC, RPM is actually only doing one-way IPC (it only exposes a write() >> interface to clients) so it seems like a rather simple implementation of >>

[PATCHv8 0/2] Common Mailbox Framework

2014-07-11 Thread Jassi Brar
Hello, Here is the next revision of Mailbox framwork. Changes since v7: o Added documentation and example usage. o Merged all patches into one that create api, bindings and documentation. Changes since v6: o Separate out generic DT bindings patch. o Discard unnecessary aligned attributes

[PATCHv8 1/2] mailbox: rename pl320-ipc specific mailbox.h

2014-07-11 Thread Jassi Brar
J. Wysocki Signed-off-by: Suman Anna Signed-off-by: Jassi Brar --- arch/arm/mach-highbank/highbank.c| 2 +- drivers/cpufreq/highbank-cpufreq.c | 2 +- drivers/mailbox/pl320-ipc.c | 2 +- include/linux/{mailbox.h => pl320-ipc.h} | 0 4 files changed, 3 insertions(+)

[PATCHv8 2/2] mailbox: Introduce framework for mailbox

2014-07-11 Thread Jassi Brar
should have a look at include/linux/mailbox_controller.h Signed-off-by: Jassi Brar --- .../devicetree/bindings/mailbox/mailbox.txt| 33 ++ Documentation/mailbox.txt | 107 + MAINTAINERS| 8 + drivers/mailbox/Makefile

Re: [PATCHv8 2/2] mailbox: Introduce framework for mailbox

2014-07-13 Thread Jassi Brar
On 11 July 2014 17:16, Ashwin Chaugule wrote: > Hi Jassi, > > Other than a few nits, this looks good to me. > Thanks for the nits. I will club them together with other feedback on the patchset. > > Hopefully you've run this through checkpatch as well? Also, were you > able to sort out the process

Re: [PATCHv8 2/2] mailbox: Introduce framework for mailbox

2014-07-13 Thread Jassi Brar
On 12 July 2014 03:39, Markus Mayer wrote: > On 11 July 2014 02:35, Jassi Brar wrote: >> Introduce common framework for client/protocol drivers and >> controller drivers of Inter-Processor-Communication (IPC). >> >> Client driver developers should have

Re: [PATCHv8 2/2] mailbox: Introduce framework for mailbox

2014-07-13 Thread Jassi Brar
On 11 July 2014 22:56, Arnd Bergmann wrote: > On Friday 11 July 2014, Jassi Brar wrote: >> + >> + This document aims to help developers write client and controller >> +drivers for the API. But before we start, let us note that the >> +client (especially) and controller

Re: [PATCHv7 0/5] Common Mailbox Framework

2014-06-30 Thread Jassi Brar
On 30 June 2014 21:46, Lubomir Rintel wrote: > Hi Jassi, > > On Thu, 2014-06-12 at 22:28 +0530, Jassi Brar wrote: >> Hello, >> Here is the next revision of Mailbox framwork. > > I'm wondering whether you keep a Git tree with the framework we could > keep the R

Re: [PATCHv8 2/2] mailbox: Introduce framework for mailbox

2014-07-16 Thread Jassi Brar
On 16 July 2014 15:46, Arnd Bergmann wrote: > On Wednesday 16 July 2014 10:40:19 Sudeep Holla wrote: >> > + >> > +Required property: >> > +- mbox: List of phandle and mailbox channel specifier. >> > + >> > +- mbox-names: List of identifier strings for each mailbox channel >> > + requ

Re: [PATCHv8 2/2] mailbox: Introduce framework for mailbox

2014-07-16 Thread Jassi Brar
On 16 July 2014 18:15, Arnd Bergmann wrote: > On Wednesday 16 July 2014 18:07:04 Jassi Brar wrote: >> On 16 July 2014 15:46, Arnd Bergmann wrote: >> > On Wednesday 16 July 2014 10:40:19 Sudeep Holla wrote: >> >> > + >> >> > +Required property: >

Re: [PATCHv8 2/2] mailbox: Introduce framework for mailbox

2014-07-16 Thread Jassi Brar
On 16 July 2014 18:39, Arnd Bergmann wrote: > On Wednesday 16 July 2014 18:35:33 Jassi Brar wrote: >> On 16 July 2014 18:15, Arnd Bergmann wrote: >> > On Wednesday 16 July 2014 18:07:04 Jassi Brar wrote: >> >> On 16 July 2014 15:46, Arnd Bergmann wrote: >>

Re: [PATCHv8 2/2] mailbox: Introduce framework for mailbox

2014-07-16 Thread Jassi Brar
On 16 July 2014 19:38, Arnd Bergmann wrote: > On Wednesday 16 July 2014 18:42:22 Jassi Brar wrote: >> On 16 July 2014 18:39, Arnd Bergmann wrote: >> > On Wednesday 16 July 2014 18:35:33 Jassi Brar wrote: >> >> On 16 July 2014 18:15, Arnd Bergmann wrote: >>

Re: [PATCHv8 2/2] mailbox: Introduce framework for mailbox

2014-07-17 Thread Jassi Brar
On 16 July 2014 21:39, Suman Anna wrote: > Hi, > > On 07/16/2014 09:18 AM, Jassi Brar wrote: >> On 16 July 2014 19:38, Arnd Bergmann wrote: >>> On Wednesday 16 July 2014 18:42:22 Jassi Brar wrote: >>>> On 16 July 2014 18:39, Arnd Bergmann wrote: >>&g

[PATCHv9 0/4] Common Mailbox Framework

2014-07-22 Thread Jassi Brar
o Added kernel-doc for exported API o Dropped the cl_id and use clients pointer for callbacks. o Fixed locking of channel pool o Return negative error code for unsuccessful ipc_send_message() o Module referencing during mailbox assignment to a client. o Made error code symbols specific

[PATCHv9 2/4] mailbox: Introduce framework for mailbox

2014-07-22 Thread Jassi Brar
should have a look at include/linux/mailbox_controller.h Signed-off-by: Jassi Brar --- MAINTAINERS| 8 + drivers/mailbox/Makefile | 4 + drivers/mailbox/mailbox.c | 467 + include/linux/mailbox_client.h | 45

[PATCHv9 1/4] mailbox: rename pl320-ipc specific mailbox.h

2014-07-22 Thread Jassi Brar
From: Suman Anna The patch 30058677 "ARM / highbank: add support for pl320 IPC" added a pl320 IPC specific header file as a generic mailbox.h. This file has been renamed appropriately to allow the introduction of the generic mailbox API framework. Acked-by: Mark Langsdorf Cc: Rafael J. Wysocki

[PATCHv9 3/4] doc: add documentation for mailbox framework

2014-07-22 Thread Jassi Brar
Some explanations with examples of how to write to implement users and providers of the mailbox framework. Signed-off-by: Jassi Brar --- Documentation/mailbox.txt | 122 ++ 1 file changed, 122 insertions(+) create mode 100644 Documentation

[PATCHv9 4/4] dt: mailbox: add generic bindings

2014-07-22 Thread Jassi Brar
Define generic bindings for the framework clients to request mailbox channels. Signed-off-by: Jassi Brar --- .../devicetree/bindings/mailbox/mailbox.txt| 36 ++ 1 file changed, 36 insertions(+) create mode 100644 Documentation/devicetree/bindings/mailbox/mailbox.txt

Re: [PATCHv9 2/4] mailbox: Introduce framework for mailbox

2014-07-23 Thread Jassi Brar
On 23 July 2014 14:24, Lee Jones wrote: > On Wed, 23 Jul 2014, Jassi Brar wrote: >> Introduce common framework for client/protocol drivers and >> controller drivers of Inter-Processor-Communication (IPC). >> >> Client driver developers should have a look at >>

Re: [PATCH v1] gpio: keystone: add dsp gpio controller driver

2014-07-24 Thread Jassi Brar
On 23 July 2014 20:40, Linus Walleij wrote: > On Wed, Jul 16, 2014 at 12:43 PM, Grygorii Strashko > wrote: > >> From: Murali Karicheri >> >> On Keystone SOCs, ARM host can send interrupts to DSP cores using the >> DSP GPIO controller IP. Each DSP GPIO controller provides 28 IRQ signals for >> ea

Re: [PATCH v1] gpio: keystone: add dsp gpio controller driver

2014-07-24 Thread Jassi Brar
On 24 July 2014 22:52, Santosh Shilimkar wrote: > On Thursday 24 July 2014 01:19 PM, Jassi Brar wrote: >> On 23 July 2014 20:40, Linus Walleij wrote: >>> On Wed, Jul 16, 2014 at 12:43 PM, Grygorii Strashko >>> wrote: >>> >>>> From: Murali Karicher

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-06-05 Thread Jassi Brar
On 5 June 2014 16:42, Matt Porter wrote: > On Tue, Jun 03, 2014 at 03:51:55PM +0530, Jassi Brar wrote: > >> BTW, here we at least have a hardware resource to specify in the DT >> node, there are examples in kernel where the DT nodes are purely >> virtual. For ex, grep for

Re: [PATCHv6 2/3] mailbox: Introduce framework for mailbox

2014-06-05 Thread Jassi Brar
On 5 June 2014 16:21, Matt Porter wrote: > On Tue, Jun 03, 2014 at 12:01:24AM +0530, Jassi Brar wrote: >> Introduce common framework for client/protocol drivers and >> controller drivers of Inter-Processor-Communication (IPC). >> >> Client driver developers should have

[PATCHv7 0/5] Common Mailbox Framework

2014-06-12 Thread Jassi Brar
Hello, Here is the next revision of Mailbox framwork. Changes since v6: o Separate out generic DT bindings patch. o Discard unnecessary aligned attributes. Changes since v5: o Use standard error types instead of special type mbox_result. o Constify client struct in request_channel o Use re

[PATCHv7 4/5] mailbox: Fix deleteing poll timer

2014-06-12 Thread Jassi Brar
From: LeyFoon Tan Try to delete the timer only if it was init/used. Signed-off-by: LeyFoon Tan Signed-off-by: Jassi Brar --- drivers/mailbox/mailbox.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index 336fa10

[PATCHv7 3/5] Mailbox: Generic: Specify mailbox api bindings

2014-06-12 Thread Jassi Brar
which this binding specifies. Signed-off-by: Jassi Brar --- .../devicetree/bindings/mailbox/mailbox.txt| 33 ++ 1 file changed, 33 insertions(+) create mode 100644 Documentation/devicetree/bindings/mailbox/mailbox.txt diff --git a/Documentation/devicetree/bindin

[PATCHv7 1/5] mailbox: rename pl320-ipc specific mailbox.h

2014-06-12 Thread Jassi Brar
From: Suman Anna The patch 30058677 "ARM / highbank: add support for pl320 IPC" added a pl320 IPC specific header file as a generic mailbox.h. This file has been renamed appropriately to allow the introduction of the generic mailbox API framework. Acked-by: Mark Langsdorf Cc: Rafael J. Wysocki

[PATCHv7 2/5] mailbox: Introduce framework for mailbox

2014-06-12 Thread Jassi Brar
should have a look at include/linux/mailbox_controller.h Signed-off-by: Jassi Brar --- drivers/mailbox/Makefile | 4 + drivers/mailbox/mailbox.c | 487 + include/linux/mailbox_client.h | 45 include/linux/mailbox_controller.h

[PATCHv7 5/5] MAINTAINERS: Add maintainer entry for Mailbox API

2014-06-12 Thread Jassi Brar
Add myself as the maintainer of mailbox api Signed-off-by: Jassi Brar --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b4a66b9..7f6651b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5633,6 +5633,14 @@ S: Maintained F

Re: [PATCHv4,2/5] mailbox: Introduce framework for mailbox

2014-03-28 Thread Jassi Brar
On Sat, Mar 29, 2014 at 3:38 AM, Markus Mayer wrote: . >> +int mbox_send_message(struct mbox_chan *chan, void *mssg) >> +{ >> + int t; >> + >> + if (!chan || !chan->cl) >> + return -EINVAL; >> + >> + t = _add_to_rbuf(chan, mssg); >> + if (t < 0) { >> +

Re: [PATCHv4 1/5] mailbox: rename pl320-ipc specific mailbox.h

2014-03-28 Thread Jassi Brar
On Fri, Mar 28, 2014 at 4:21 AM, Markus Mayer wrote: >> The patch 30058677 "ARM / highbank: add support for pl320 IPC" >> added a pl320 IPC specific header file as a generic mailbox.h. >> This file has been renamed appropriately to allow the >> introduction of the generic mailbox API framework. >>

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-05-20 Thread Jassi Brar
On Tue, May 20, 2014 at 1:25 AM, Bjorn Andersson wrote: > On Mon, May 19, 2014 at 11:03 AM, Jassi Brar > wrote: >> On 19 May 2014 18:38, Arnd Bergmann wrote: >>> On Friday 16 May 2014 19:03:25 Jassi Brar wrote: > [...] >>> Do you have an example for a pl

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-05-27 Thread Jassi Brar
On Wed, May 21, 2014 at 10:57 PM, Mark Brown wrote: > On Thu, May 15, 2014 at 11:41:00AM +0530, Jassi Brar wrote: >> Introduce common framework for client/protocol drivers and >> controller drivers of Inter-Processor-Communication (IPC). > > This looks pretty nice, though

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-05-29 Thread Jassi Brar
On Thu, May 29, 2014 at 9:13 PM, Matt Porter wrote: > On Fri, May 16, 2014 at 07:03:25PM +0530, Jassi Brar wrote: >> On 15 May 2014 19:57, Arnd Bergmann wrote: >> > On Thursday 15 May 2014 11:41:00 Jassi Brar wrote: > > ... > >> >> +struct mbox_cont

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-06-02 Thread Jassi Brar
On Mon, Jun 2, 2014 at 8:44 PM, Matt Porter wrote: > On Fri, May 30, 2014 at 11:01:55AM +0530, Jassi Brar wrote: > >> Being more specific to your platform, I think you need some server >> code (mailbox's client) that every driver (like clock, pmu, pinmux >> etc) re

[PATCHv6 0/3] Common Mailbox Framework

2014-06-02 Thread Jassi Brar
Hello, Here is the next revision of Mailbox framwork. Changes since v5: o Use standard error types instead of special type mbox_result. o Constify client struct in request_channel o Use reinit_completion instead of init_completion every time. o Improve commentary in bindings and code. Chang

[PATCHv6 2/3] mailbox: Introduce framework for mailbox

2014-06-02 Thread Jassi Brar
should have a look at include/linux/mailbox_controller.h Signed-off-by: Jassi Brar --- .../devicetree/bindings/mailbox/mailbox.txt| 33 ++ drivers/mailbox/Makefile | 4 + drivers/mailbox/mailbox.c | 487 + include

[PATCHv6 1/3] mailbox: rename pl320-ipc specific mailbox.h

2014-06-02 Thread Jassi Brar
From: Suman Anna The patch 30058677 "ARM / highbank: add support for pl320 IPC" added a pl320 IPC specific header file as a generic mailbox.h. This file has been renamed appropriately to allow the introduction of the generic mailbox API framework. Acked-by: Mark Langsdorf Cc: Rafael J. Wysocki

[PATCHv6 3/3] mailbox: Fix deleteing poll timer

2014-06-02 Thread Jassi Brar
From: LeyFoon Tan Try to delete the timer only if it was init/used. Signed-off-by: LeyFoon Tan Signed-off-by: Jassi Brar --- drivers/mailbox/mailbox.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index 336fa10

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-06-03 Thread Jassi Brar
On 3 June 2014 15:05, Sudeep Holla wrote: > Hi Jassi, > > On Mon, Jun 2, 2014 at 6:11 PM, Jassi Brar wrote: >> On Mon, Jun 2, 2014 at 8:44 PM, Matt Porter wrote: >>> On Fri, May 30, 2014 at 11:01:55AM +0530, Jassi Brar wrote: >>> >>>> Being more spe

Re: [PATCHv6 2/3] mailbox: Introduce framework for mailbox

2014-06-04 Thread Jassi Brar
On 3 June 2014 00:01, Jassi Brar wrote: > diff --git a/include/linux/mailbox_controller.h > b/include/linux/mailbox_controller.h > new file mode 100644 > index 000..49bd64e > --- /dev/null > +++ b/include/linux/mailbox_controller.h > @@ -0,0 +1,121 @@ > +/* &g

Re: [PATCHv7 2/5] mailbox: Introduce framework for mailbox

2014-06-18 Thread Jassi Brar
On 18 June 2014 05:57, Kevin Hilman wrote: > Jassi Brar writes: > >> Introduce common framework for client/protocol drivers and >> controller drivers of Inter-Processor-Communication (IPC). >> >> Client driver developers should have a look at >> include/linu

Re: [PATCH 1/2] ARM: LPAE: load upper bits of early TTBR0/TTBR1

2014-08-27 Thread Jassi Brar
On Tue, Jul 29, 2014 at 5:59 PM, Konstantin Khlebnikov wrote: > On Mon, Jul 28, 2014 at 10:47 PM, Will Deacon wrote: >> On Mon, Jul 28, 2014 at 07:40:58PM +0100, Konstantin Khlebnikov wrote: >>> On Mon, Jul 28, 2014 at 10:12 PM, Will Deacon wrote: >>> > On Tue, Jul 22, 2014 at 04:36:23PM +0100,

Re: [PATCH 1/2] ARM: LPAE: load upper bits of early TTBR0/TTBR1

2014-08-27 Thread Jassi Brar
On Wed, Aug 27, 2014 at 9:01 PM, Konstantin Khlebnikov wrote: > On Wed, Aug 27, 2014 at 7:26 PM, Jassi Brar wrote: >> On Tue, Jul 29, 2014 at 5:59 PM, Konstantin Khlebnikov >> wrote: >>>>> >> This patch fixes booting when idmap pgd lays above 4gb. Commit &

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-27 Thread Jassi Brar
On 27 August 2014 23:08, Andrew Bresticker wrote: > On Mon, Aug 25, 2014 at 12:01 PM, Stephen Warren > wrote: >> I'm not even sure if it's appropriate for the low-level mailbox driver to >> know about the semantics of the message, rather than simply sending them on >> to the client driver? Perh

Request to include Mailbox tree in linux-next

2014-08-05 Thread Jassi Brar
ext? Tree: git://git.linaro.org/landing-teams/working/fujitsu/integration.git Branch: mailbox-for-3.17 Contact: Jassi Brar Thanks, -Jassi -- Linaro.org │ Open source software for ARM SoCs | Follow Linaro http://facebook.com/pages/Linaro/155974581091106 - http://twitter.com/#!/linaroorg - http://li

Re: Request to include Mailbox tree in linux-next

2014-08-08 Thread Jassi Brar
On 8 August 2014 09:59, Stephen Rothwell wrote: > Hi Jassi, > > On Wed, 6 Aug 2014 12:25:49 +0530 Jassi Brar > wrote: >> >> The framework for Mailbox has undergone 10 revisions over the last >> one year, which has garnered support in the form of 'Reviewed-

Re: Request to include Mailbox tree in linux-next

2014-08-08 Thread Jassi Brar
On 8 August 2014 16:00, Russell King - ARM Linux wrote: > On Fri, Aug 08, 2014 at 02:29:12PM +1000, Stephen Rothwell wrote: >> Hi Jassi, >> >> On Wed, 6 Aug 2014 12:25:49 +0530 Jassi Brar >> wrote: >> > >> > The framework for Mailbox has under

Re: Request to include Mailbox tree in linux-next

2014-08-08 Thread Jassi Brar
On 8 August 2014 20:11, Russell King - ARM Linux wrote: > On Fri, Aug 08, 2014 at 07:55:52PM +0530, Jassi Brar wrote: >> On 8 August 2014 09:59, Stephen Rothwell wrote: >> > Hi Jassi, >> > >> > On Wed, 6 Aug 2014 12:25:49 +0530 Jassi Brar >> > wrot

Re: Request to include Mailbox tree in linux-next

2014-08-08 Thread Jassi Brar
On 8 August 2014 21:28, Stephen Rothwell wrote: > Hi Jassi, > > On Fri, 8 Aug 2014 20:40:47 +0530 Jassi Brar > wrote: >> >> On 8 August 2014 20:11, Russell King - ARM Linux >> wrote: >> >> Upon Mark's suggestion (and the right thing to do) I

[PATCHv10 0/4] Common Mailbox Framework

2014-08-01 Thread Jassi Brar
nts pointer for callbacks. o Fixed locking of channel pool o Return negative error code for unsuccessful ipc_send_message() o Module referencing during mailbox assignment to a client. o Made error code symbols specific to mailbox. Thanks -Jassi Jassi Brar (3): mailbox: Introduce framework fo

[PATCHv10 1/4] mailbox: rename pl320-ipc specific mailbox.h

2014-08-01 Thread Jassi Brar
From: Suman Anna The patch 30058677 "ARM / highbank: add support for pl320 IPC" added a pl320 IPC specific header file as a generic mailbox.h. This file has been renamed appropriately to allow the introduction of the generic mailbox API framework. Acked-by: Mark Langsdorf Cc: Rafael J. Wysocki

[PATCHv10 2/4] mailbox: Introduce framework for mailbox

2014-08-01 Thread Jassi Brar
should have a look at include/linux/mailbox_controller.h Signed-off-by: Jassi Brar --- MAINTAINERS| 8 + drivers/mailbox/Makefile | 4 + drivers/mailbox/mailbox.c | 466 + include/linux/mailbox_client.h | 46

[PATCHv10 3/4] doc: add documentation for mailbox framework

2014-08-01 Thread Jassi Brar
Some explanations with examples of how to write to implement users and providers of the mailbox framework. Signed-off-by: Jassi Brar --- Documentation/mailbox.txt | 122 ++ 1 file changed, 122 insertions(+) create mode 100644 Documentation

[PATCHv10 4/4] dt: mailbox: add generic bindings

2014-08-01 Thread Jassi Brar
Define generic bindings for the framework clients to request mailbox channels. Signed-off-by: Jassi Brar --- .../devicetree/bindings/mailbox/mailbox.txt| 36 ++ 1 file changed, 36 insertions(+) create mode 100644 Documentation/devicetree/bindings/mailbox/mailbox.txt

Re: [PATCHv10 4/4] dt: mailbox: add generic bindings

2014-08-02 Thread Jassi Brar
On 2 August 2014 00:13, Mark Brown wrote: > On Fri, Aug 01, 2014 at 06:02:45PM +0530, Jassi Brar wrote: > >> +Optional property: >> +- mbox-names: List of identifier strings for each mailbox channel >> + required by the client. The use of this property >>

Re: [PATCHv10 0/4] Common Mailbox Framework

2014-08-02 Thread Jassi Brar
On 1 August 2014 23:56, Mark Brown wrote: > On Fri, Aug 01, 2014 at 05:59:54PM +0530, Jassi Brar wrote: >> Hello, >> Here's v10. Not much different from v9. The code and the generic >> bindings looked good enough to relevant gods, but the patchset still >> needs s

Re: [PATCHv10 2/4] mailbox: Introduce framework for mailbox

2014-08-02 Thread Jassi Brar
On 2 August 2014 00:07, Mark Brown wrote: > On Fri, Aug 01, 2014 at 06:01:36PM +0530, Jassi Brar wrote: >> Introduce common framework for client/protocol drivers and >> controller drivers of Inter-Processor-Communication (IPC). >> >> Client driver developers should

Re: [GIT PULL] New Mailbox framework for 3.18

2014-10-21 Thread Jassi Brar
On 21 October 2014 13:13, Arnd Bergmann wrote: > On Monday 20 October 2014 15:23:38 Jassi Brar wrote: >> On 8 October 2014 11:09, Jassi Brar wrote: >> > Hi Linus, >> > >> > A framework for Mailbox controllers and clients have been cooking for >> > m

Re: [PATCH 1/2] mailbox: Avoid NULL-pointer dereference in mbox_chan_received_data()

2014-10-30 Thread Jassi Brar
On 31 October 2014 01:31, Andrew Bresticker wrote: > If a message has been received on a channel, but no client has yet bound > to it, mbox_chan_received_data() will dereference a NULL client pointer. > Check for the presence of a client first. > Let me quote from the documentation of the API

[GIT PULL] New Mailbox framework for 3.18

2014-10-07 Thread Jassi Brar
e28c7cf490bf543e4dcb2770a: dt: mailbox: add generic bindings (2014-10-08 10:39:42 +0530) ---- Jassi Brar (3): mailbox: Introduce framework for mailbox doc: add documentation for mailbox framework dt: mailbox: add generi

Re: [PATCH 2/2] mailbox: Don't unnecessarily re-arm the polling timer

2014-11-08 Thread Jassi Brar
On 31 October 2014 17:11, Thierry Reding wrote: > On Thu, Oct 30, 2014 at 01:01:07PM -0700, Andrew Bresticker wrote: >> poll_txdone() will unconditionally re-arm the polling timer if there was >> an active request, even if the active request completed and no other >> requests were submitted. This

[PATCH] mailbox: enable non-DT/ACPI clients to use the api

2014-11-09 Thread Jassi Brar
d (first 4bytes) of the SharedMemory Region corresponding to the subspace/channel the client is interested in. Signed-off-by: Jassi Brar --- drivers/mailbox/mailbox.c | 50 +- include/linux/mailbox_controller.h | 7 ++ 2 files changed, 35 in

Re: [PATCH 3/6] mailbox: Add support for ST's Mailbox IP

2015-07-23 Thread Jassi Brar
On Thu, Jul 23, 2015 at 1:59 PM, Lee Jones wrote: >> On Fri, Jul 17, 2015 at 5:34 PM, Lee Jones wrote: >> > +static void sti_mbox_enable_channel(struct mbox_chan *chan) >> > +{ >> > + struct sti_channel *chan_info = chan->con_priv; >> > + struct sti_mbox_device *mdev = chan_info->mde

Re: [PATCH 1/2] mailbox: switch to hrtimer for tx_complete polling

2015-07-23 Thread Jassi Brar
On Wed, Jul 22, 2015 at 5:58 PM, Sudeep Holla wrote: > we might end-up waiting > for atleast a jiffy even though the response for that message from the > remote is received via interrupt and processed in relatively smaller > time granularity. > That is wrong. If the controller supports TX inter

Re: [PATCH 3/6] mailbox: Add support for ST's Mailbox IP

2015-07-24 Thread Jassi Brar
On Fri, Jul 24, 2015 at 3:06 PM, Lee Jones wrote: > On Thu, 23 Jul 2015, Jassi Brar wrote: > >> >> > +static void sti_mbox_enable_channel(struct mbox_chan *chan) >> >> > +{ >> >> > + struct sti_channel *chan_info = chan->con_priv; &g

Re: [RFC PATCH 0/3] mailbox: hisilicon: add mailbox driver

2015-08-05 Thread Jassi Brar
On Mon, Aug 3, 2015 at 6:43 AM, Leo Yan wrote: > This patch series is to implement Hisilicon's mailbox driver and enable > the mailbox controller on Hi6220. > Cool. > The Hisilicon mailbox supports up to 32 channels. Each channel is > unidirectional with a maximum message size of 8 words. I/O is

Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

2015-07-29 Thread Jassi Brar
On Thu, Jul 23, 2015 at 4:40 PM, Sudeep Holla wrote: ... > +static int scpi_probe(struct platform_device *pdev) > +{ > + int count, idx, ret; > + struct resource res; > + struct scpi_chan *scpi_chan; > + struct device *dev = &pdev->dev; > + struct device_node *np =

Re: [PATCH 1/2] mailbox: switch to hrtimer for tx_complete polling

2015-07-29 Thread Jassi Brar
On Mon, Jul 27, 2015 at 3:18 PM, Sudeep Holla wrote: > On 27/07/15 04:26, Jassi Brar wrote: >> >>>> >>>>> we might end-up waiting >>>>> for atleast a jiffy even though the response for that message from the >>>>> remote is rec

Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

2015-07-29 Thread Jassi Brar
On Wed, Jul 29, 2015 at 2:08 PM, Sudeep Holla wrote: > On 29/07/15 09:05, Jassi Brar wrote: > >> >>> +static int scpi_probe(struct platform_device *pdev) >>> +{ >>> + int count, idx, ret; >>> + struct resource res; >>> +

Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

2015-07-30 Thread Jassi Brar
On Wed, Jul 29, 2015 at 6:20 PM, Sudeep Holla wrote: > On 29/07/15 12:19, Jassi Brar wrote: > >> Assuming the former, let me explain. When a client receives a >> response, it can be sure that the request has already been read by the >> remote. > > Waiting for the

Re: [PATCH 1/2] mailbox: switch to hrtimer for tx_complete polling

2015-07-30 Thread Jassi Brar
On Wed, Jul 29, 2015 at 2:18 PM, Sudeep Holla wrote: > > > On 29/07/15 09:33, Jassi Brar wrote: > >> On Mon, Jul 27, 2015 at 3:18 PM, Sudeep Holla >> wrote: >>> >>> On 27/07/15 04:26, Jassi Brar wrote: >>>> >>>> >>>>

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-09 Thread Jassi Brar
On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones wrote: > This particular Client implementation uses shared memory in order > to pass messages between Mailbox users; however, it can be easily > hacked to support any type of Controller. > > Signed-off-by: Lee Jones > --- > drivers/mailbox/Kconfig

Re: [PATCH v2 2/6] mailbox: dt-bindings: Add shared [driver <=> device tree] defines

2015-08-09 Thread Jassi Brar
On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones wrote: > This header is currently only used for defines pertaining to data > direction i.e. Rx, Tx or Loopback. > > Signed-off-by: Lee Jones > --- > include/dt-bindings/mailbox/mailbox.h | 14 ++ > 1 file changed, 14 insertions(+) > create

Re: [RFC PATCH 0/3] mailbox: hisilicon: add mailbox driver

2015-08-10 Thread Jassi Brar
On Thu, Aug 6, 2015 at 4:47 AM, Leo Yan wrote: > Hi Jassi, > > Thanks for review. > > On Wed, Aug 05, 2015 at 04:22:01PM +0530, Jassi Brar wrote: >> On Mon, Aug 3, 2015 at 6:43 AM, Leo Yan wrote: > > [...] > >> > For easily extending for Hisilicon series

Re: [PATCHv7 2/2] mailbox: Adding driver for Xilinx LogiCORE IP mailbox.

2015-08-10 Thread Jassi Brar
On Wed, Jul 15, 2015 at 6:30 AM, Moritz Fischer wrote: > + > +static void xilinx_mbox_rx_data(struct mbox_chan *chan) > +{ > + struct xilinx_mbox *mbox = mbox_chan_to_xilinx_mbox(chan); > + u32 data; > + > + if (xilinx_mbox_pending(mbox)) { > + data = readl_relaxed

<    1   2   3   4   5   6   >