Re: [RFC] dmaengine: pl330: fix a race condition in case of threaded irqs

2018-01-09 Thread Jassi Brar
On Mon, Dec 25, 2017 at 7:50 AM, Qi Hou wrote: > I found this problem below, and I now understand why it happens, but I'm not > 100% sure what is the best way to fix it. > > When booting up with "threadirqs" in command line, all irq handlers of the DMA > controller pl330 will be threaded forcedly

Re: [PATCH v3 2/2] dt-bindings: mailbox: Add Xilinx IPI Mailbox

2018-01-09 Thread Jassi Brar
On Wed, Jan 10, 2018 at 6:52 AM, Jiaying Liang wrote: >> From: Jassi Brar [mailto:jassisinghb...@gmail.com] >> > + >> > +Controller Device Node: >> > +=== >> > +Required properties: >> > + >> >

[GIT PULL] Mailbox changes for v4.17

2018-04-06 Thread Jassi Brar
Hi Linus, The following changes since commit 0aa3fdb8b3a6df3c2e3b61dbfe079db9d30e03cd: Merge tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi (2018-03-14 17:02:49 -0700) are available in the git repository at: git://git.linaro.org/landing-teams/working/fujitsu/int

Re: [PATCH v2 2/2] mailbox: add STMicroelectronics STM32 IPCC driver

2018-04-06 Thread Jassi Brar
On Fri, Apr 6, 2018 at 5:59 PM, Fabien DESSENNE wrote: > Hi > > > On 05/04/18 11:38, Jassi Brar wrote: >> On Mon, Mar 12, 2018 at 4:28 PM, Fabien Dessenne >> wrote: >> >>> + >>> + /* irq */ >>> + for (i = 0;

Re: [PATCH v2 2/2] mailbox: add STMicroelectronics STM32 IPCC driver

2018-04-06 Thread Jassi Brar
On Fri, Apr 6, 2018 at 8:35 PM, Fabien DESSENNE wrote: > > On 06/04/18 14:56, Jassi Brar wrote: >> On Fri, Apr 6, 2018 at 5:59 PM, Fabien DESSENNE >> wrote: >>> Hi >>> >>> >>> On 05/04/18 11:38, Jassi Brar wrote: >>>

Re: [PATCH v2 2/2] mailbox: add STMicroelectronics STM32 IPCC driver

2018-04-09 Thread Jassi Brar
On Mon, Apr 9, 2018 at 2:33 PM, Fabien DESSENNE wrote: > > > On 06/04/18 18:20, Jassi Brar wrote: >> On Fri, Apr 6, 2018 at 8:35 PM, Fabien DESSENNE >> wrote: >>> On 06/04/18 14:56, Jassi Brar wrote: >>>> On Fri, Apr 6, 2018 at 5:59

Re: [PATCH 00/19] mailbox: Device-managed registration

2018-12-06 Thread Jassi Brar
On Wed, Dec 5, 2018 at 10:14 AM Thierry Reding wrote: > > On Wed, Nov 28, 2018 at 10:39:50AM +0100, Thierry Reding wrote: > > On Wed, Nov 21, 2018 at 03:54:10PM +0100, Thierry Reding wrote: > > > From: Thierry Reding > > > > > > Hi, > > > > > > This series of patches adds device-managed registrat

Re: [PATCH V4 3/5] mailbox: imx: add imx mu support

2018-07-11 Thread Jassi Brar
On Wed, Jul 11, 2018 at 4:07 PM, A.s. Dong wrote: > > > -Original Message- > > From: Sascha Hauer [mailto:s.ha...@pengutronix.de] > > Sent: Wednesday, July 11, 2018 3:55 PM > > To: A.s. Dong > > Cc: linux-arm-ker...@lists.infradead.org; donga...@gmail.c

Re: [PATCH 6/8] serial: Add Tegra Combined UART driver

2018-05-13 Thread Jassi Brar
On Tue, May 8, 2018 at 5:14 PM, Mikko Perttunen wrote: > > +config SERIAL_TEGRA_TCU > + tristate "NVIDIA Tegra Combined UART" > + depends on ARCH_TEGRA && MAILBOX > + select SERIAL_CORE > + help > + Support for the mailbox-based TCU (Tegra Combined UART) seria

[GIT PULL] Mailbox changes for v4.19

2018-08-16 Thread Jassi Brar
Hi Linus, The following changes since commit 0585df468e8f4481b78256a2bf09449290bfcbf3: Merge tag 'media/v4.18-3' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media (2018-08-02 16:55:42 -0700) are available in the Git repository at: git://git.linaro.org/landing-teams/workin

Re: [PATCH 00/19] mailbox: Device-managed registration

2018-12-17 Thread Jassi Brar
On Mon, Dec 17, 2018 at 8:35 AM Thierry Reding wrote: > > On Tue, Dec 11, 2018 at 10:34:59PM +0530, Jassi Brar wrote: > > On Wed, Nov 21, 2018 at 8:24 PM Thierry Reding > > wrote: > > > > > > From: Thierry Reding > > > > > > Hi,

Re: [PATCH 00/19] mailbox: Device-managed registration

2018-12-11 Thread Jassi Brar
On Wed, Nov 21, 2018 at 8:24 PM Thierry Reding wrote: > > From: Thierry Reding > > Hi, > > This series of patches adds device-managed registration functions for > mailbox controllers. A number of drivers can be simplified by making use > of this new API both in the error cleanup paths in their pr

Re: [PATH v7 1/2] mailbox: ZynqMP IPI mailbox controller

2018-12-21 Thread Jassi Brar
On Thu, Dec 20, 2018 at 11:32 AM Wendy Liang wrote: > diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c > b/drivers/mailbox/zynqmp-ipi-mailbox.c > new file mode 100644 > index 000..bbddfd5 > --- /dev/null > +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c > @@ -0,0 +1,764 @@ .. > + > +/* IPI

[GIT PULL] Mailbox changes for v4.21

2019-01-01 Thread Jassi Brar
Hi Linus, The following changes since commit f5d582777bcb1c7ff19a5a2343f66ea01de401c6: Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid (2018-12-10 11:04:41 -0800) are available in the Git repository at: git://git.linaro.org/landing-teams/working/fujitsu/int

[GIT PULL] Mailbox changes for v4.20

2018-10-28 Thread Jassi Brar
The following changes since commit e704966c45e48d0220d1ee5e463034ae493a95b2: Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input (2018-09-28 18:04:50 -0700) are available in the Git repository at: git://git.linaro.org/landing-teams/working/fujitsu/integration

Re: [PATCH v6 03/34] mailbox: vpu-ipc-mailbox: Add support for Intel VPU IPC mailbox

2021-02-14 Thread Jassi Brar
On Fri, Feb 12, 2021 at 4:23 PM wrote: > > From: Daniele Alessandrelli > > Add mailbox controller enabling inter-processor communication (IPC) > between the CPU (aka, the Application Processor - AP) and the VPU on > Intel Movidius SoCs like Keem Bay. > > The controller uses HW FIFOs to enable suc

Re: [PATCH v2] soc: mediatek: cmdq: add address shift in jump

2021-02-14 Thread Jassi Brar
On Thu, Jan 7, 2021 at 7:48 PM Yongqiang Niu wrote: > > On Wed, 2020-12-23 at 16:34 +0800, Yongqiang Niu wrote: > > Add address shift when compose jump instruction > > to compatible with 35bit format. > > > > Fixes: 0858fde496f8 ("mailbox: cmdq: variablize address shift in platform") > > > > Signe

[GIT PULL] Mailbox changes for 3.19

2014-12-09 Thread Jassi Brar
Hi Linus, The following changes since commit 0df1f2487d2f0d04703f142813d53615d62a1da4: Linux 3.18-rc3 (2014-11-02 15:01:51 -0800) are available in the git repository at: http://git.linaro.org/landing-teams/working/fujitsu/integration.git mailbox-devel for you to fetch changes up to 86c22f8

Re: gpio: ARCH_MB86S7X?

2015-01-23 Thread Jassi Brar
Hi Paul, On 23 January 2015 at 15:51, Paul Bolle wrote: > Jassi, > > Your commit 0da094d82c27 ("gpio: Add Fujitsu MB86S7x GPIO driver") is > included in today's linux-next (ie, next-20150123). I noticed because a > script I use to check linux-next spotted a problem in it. > > That commit added th

Re: [PATCH 3/3] mailbox: Add support for ST's Mailbox IP

2015-03-19 Thread Jassi Brar
On Thu, Mar 19, 2015 at 2:47 PM, Lee Jones wrote: > On Thu, 19 Mar 2015, Jassi Brar wrote: > >> On Wed, Mar 18, 2015 at 9:04 PM, Lee Jones wrote: >> > On Wed, 18 Mar 2015, Jassi Brar wrote: >> > >> >> On Wed, Mar 18, 2015 at 6:47 PM, Lee Jones wrot

Re: [PATCH 3/3] mailbox: Add support for ST's Mailbox IP

2015-03-19 Thread Jassi Brar
On Thu, Mar 19, 2015 at 3:27 PM, Lee Jones wrote: > On Thu, 19 Mar 2015, Jassi Brar wrote: > >> And also no header that's included by exactly one file. > > So you also want me to drag in all of the controller structs into the > driver? > Yes, please. Why have structu

Re: [PATCH 3/4] clk: Provide always-on clock support

2015-04-01 Thread Jassi Brar
On Wed, Apr 1, 2015 at 7:12 AM, Michael Turquette wrote: > Quoting Jassi Brar (2015-03-02 02:28:44) >> On 2 March 2015 at 15:48, Lee Jones wrote: >> > On Mon, 02 Mar 2015, Jassi Brar wrote: >> > >> >> On Mon, Mar 2, 2015 at 2:06 PM, Lee Jones wrote: >&g

Re: [PATCH 1/3] mailbox: add support for APM X-Gene platform mailbox driver

2015-04-21 Thread Jassi Brar
On 22 April 2015 at 06:14, Feng Kan wrote: > On Tue, Apr 21, 2015 at 12:42 AM, Jassi Brar wrote: >> >>> +/* Configuration and Status Registers */ >>> +struct slimpro_mbox_reg { >>> + u32 in; >>> + u32 din0; >>> +

[GIT PULL] Mailbox changes for v4.1-rc1

2015-04-16 Thread Jassi Brar
mplify PCC mailbox code Jassi Brar (1): mailbox: arm_mhu: add driver for ARM MHU controller .../devicetree/bindings/mailbox/arm-mhu.txt| 43 + drivers/mailbox/Kconfig| 9 + drivers/mailbox/Makefile | 2 + drivers/mailbox

Re: [PATCH] dmaengine: pl330: fix the race condition in pl330 driver.

2015-03-30 Thread Jassi Brar
On Fri, Mar 27, 2015 at 5:25 AM, Scott Branden wrote: > From: ismail > > Update the thread running index before issuing the > GO command to the DMAC. > > Tested-by: Mohamed Ismail Abdul Packir Mohamed > Reviewed-by: Ray Jui > Reviewed-by: Arun Parameswaran > Reviewed-by: Scott Branden > Signe

Re: [PATCH] dmaengine: pl330: fix the race condition in pl330 driver.

2015-03-30 Thread Jassi Brar
On Tue, Mar 31, 2015 at 9:10 AM, Scott Branden wrote: > Hi Vinod, Jassi, > > Some details on the problem encountered. > > > On 15-03-30 10:25 AM, Vinod Koul wrote: >> >> On Mon, Mar 30, 2015 at 10:17:17PM +0530, Jassi Brar wrote: >>> >>> On Fri, M

Re: [PATCH V2 RESEND] mailbox: add ACPI support for mailbox framework

2015-04-28 Thread Jassi Brar
On Wed, Apr 22, 2015 at 7:34 AM, Rafael J. Wysocki wrote: > On Tuesday, April 21, 2015 04:53:14 PM Jassi Brar wrote: >> On Tue, Apr 21, 2015 at 6:28 AM, Feng Kan wrote: >> > >> > Just want to ping this. I haven't gotten any response from mailbox >> > ma

Re: [PATCH 1/3] mailbox: add support for APM X-Gene platform mailbox driver

2015-04-21 Thread Jassi Brar
On Wed, Feb 18, 2015 at 8:40 AM, Feng Kan wrote: > +#define MBOX_CON_NAME "slimpro-mbox" > +#define MBOX_REG_SET_OFFSET0x1000 > +#define MBOX_CNT 8 > +#define MBOX_STATUS_AVAIL_MASK 0x0001 > +#define MBOX_STATUS_ACK_MASK 0x0

Re: [PATCH V2 RESEND] mailbox: add ACPI support for mailbox framework

2015-04-21 Thread Jassi Brar
On Tue, Apr 21, 2015 at 6:28 AM, Feng Kan wrote: > > Just want to ping this. I haven't gotten any response from mailbox > maintainer for this > patch or any of my other mailbox patches. > Sorry I had been busy and still need to have a critical look at the new api. It would sooth my nerves to see a

Re: [PATCH] mailbox/bcm2835: Fix mailbox full detection.

2015-05-29 Thread Jassi Brar
On Fri, May 29, 2015 at 3:16 AM, Eric Anholt wrote: > Stephen Warren writes: > >> On 05/13/2015 02:10 PM, Eric Anholt wrote: >>> With the VC reader blocked and the ARM writing, MAIL0_STA reads empty >>> permanently while MAIL1_STA goes from empty (0x4000) to non-empty >>> (0x0001-0x00

Re: [PATCH] mailbox/bcm2835: Fix mailbox full detection.

2015-05-29 Thread Jassi Brar
On Fri, May 29, 2015 at 2:15 AM, Stephen Warren wrote: > On 05/13/2015 02:10 PM, Eric Anholt wrote: >> >> With the VC reader blocked and the ARM writing, MAIL0_STA reads empty >> permanently while MAIL1_STA goes from empty (0x4000) to non-empty >> (0x0001-0x0007) to full (0x8008).

Re: [PATCH v4 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

2015-06-11 Thread Jassi Brar
On 8 June 2015 at 16:09, Sudeep Holla wrote: ... > + > +static void scpi_process_cmd(struct scpi_chan *ch, u32 cmd) > +{ > + unsigned long flags; > + struct scpi_xfer *t, *match = NULL; > + > + spin_lock_irqsave(&ch->rx_lock, flags); > + if (list_empty(&ch->rx_pending)) { >

Re: [PATCH 3/3] mailbox: sunxi-msgbox: Add a new mailbox driver

2018-02-28 Thread Jassi Brar
On Wed, Feb 28, 2018 at 7:57 AM, Samuel Holland wrote: > +/* > + * The message box hardware provides 8 unidirectional channels. As the > mailbox > + * framework expects them to be bidirectional > That is incorrect. Mailbox framework does not require a channel to be TX and RX capable. You s

Re: [PATCH 3/3] mailbox: sunxi-msgbox: Add a new mailbox driver

2018-02-28 Thread Jassi Brar
On Wed, Feb 28, 2018 at 11:21 PM, Samuel Holland wrote: > Hi, > > On 02/28/18 03:16, Jassi Brar wrote: >> On Wed, Feb 28, 2018 at 7:57 AM, Samuel Holland wrote: >> >> >>> +/* >>> + * The message box hardware provides 8 unidirectional channels.

Re: [PATCH 3/3] mailbox: sunxi-msgbox: Add a new mailbox driver

2018-02-28 Thread Jassi Brar
On Thu, Mar 1, 2018 at 12:26 AM, Samuel Holland wrote: > On 02/28/18 12:14, Jassi Brar wrote: >> On Wed, Feb 28, 2018 at 11:21 PM, Samuel Holland wrote: >>> Hi, >>> >>> On 02/28/18 03:16, Jassi Brar wrote: >>>> On Wed, Feb

Re: [PATCH 2/3] mailbox: Avoid NULL dereference in mbox_chan_received_data

2018-03-01 Thread Jassi Brar
On Wed, Feb 28, 2018 at 7:57 AM, Samuel Holland wrote: > If a reception IRQ is pending when a mailbox channel is shut down (for > example, if the controller uses threaded interrupts), it is possible for > mbox_chan_received_data to be called while chan->cl is NULL. > We can add a check in mailbox.

Re: [PATCH v2 2/2] mailbox: add STMicroelectronics STM32 IPCC driver

2018-04-05 Thread Jassi Brar
On Mon, Mar 12, 2018 at 4:28 PM, Fabien Dessenne wrote: > + > + /* irq */ > + for (i = 0; i < IPCC_IRQ_NUM; i++) { > + ipcc->irqs[i] = of_irq_get_byname(dev->of_node, irq_name[i]); > + if (ipcc->irqs[i] < 0) { > + dev_err(dev, "no

Re: [PATCH] mailbox: arm_mhu: add support for mhuv2

2018-05-02 Thread Jassi Brar
On Wed, May 2, 2018 at 12:44 PM, Samarth Parikh wrote: > Hi Jassi, > > I am resending the patch for review, in case you have missed my previous > patch. Can you please go through it and let me know your thoughts on > the same? > You don't want this to go into git log :) If your patch isn't looked

Re: [PATCH v2] mailbox: arm_mhu: add support for mhuv2

2018-05-28 Thread Jassi Brar
On Thu, May 17, 2018 at 1:34 PM, Samarth Parikh wrote: > ARM has launched a next version of MHU i.e. MHUv2 with its latest > subsystems. The main change is that the MHUv2 is now a distributed IP > with different peripheral views (registers) for the sender and receiver. > > Another main difference

[GIT PULL] Mailbox changes for v4.18

2018-06-06 Thread Jassi Brar
Hi Linus, The following changes since commit 7fbb6157630f2ba6ee355689061f9596b84373ef: Merge tag 'armsoc-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc (2018-05-26 14:05:16 -0700) are available in the Git repository at: git://git.linaro.org/landing-teams/working/fujitsu

[GIT PULL] Mailbox changes for v5.1

2019-03-12 Thread Jassi Brar
Hi Linus, The following changes since commit 3717f613f48df0222311f974cf8a06c8a6c97bae: Merge branch 'core-rcu-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip (2019-03-05 14:49:11 -0800) are available in the Git repository at: git://git.linaro.org/landing-teams/working/fu

[GIT PULL] Mailbox changes for v5.12

2021-02-23 Thread Jassi Brar
Hi Linus, The following changes since commit 92bf22614b21a2706f4993b278017e437f7785b3: Linux 5.11-rc7 (2021-02-07 13:57:38 -0800) are available in the Git repository at: git://git.linaro.org/landing-teams/working/fujitsu/integration.git tags/mailbox-v5.12 for you to fetch changes up to 6b5

Re: [PATCH Resend] mailbox: arm_mhuv2: Fix sparse warnings

2021-02-09 Thread Jassi Brar
On Tue, Feb 9, 2021 at 5:18 AM Viresh Kumar wrote: > > This patch fixes a bunch of sparse warnings in the newly added arm_mhuv2 > driver. > > drivers/mailbox/arm_mhuv2.c:506:24: warning: incorrect type in argument 1 > (different address spaces) > drivers/mailbox/arm_mhuv2.c:506:24:expected vo

Re: [PATCH v6 03/34] mailbox: vpu-ipc-mailbox: Add support for Intel VPU IPC mailbox

2021-02-18 Thread Jassi Brar
On Thu, Feb 18, 2021 at 6:02 AM Alessandrelli, Daniele wrote: > > Hi Jassi, > > Thank you very much for your feedback. > > On Sun, 2021-02-14 at 22:54 -0600, Jassi Brar wrote: > > IIUIC, maybe the solution is simpler What if we set txdone_poll. > > Always retu

Re: [PATCH] add chan->cl check in mbox_chan_received_data()

2021-01-31 Thread Jassi Brar
On Thu, Jan 7, 2021 at 5:53 AM haidong yao wrote: > > Hi Jassi Brar > > Thank you very much for your reply. > > Look at the function sprd_mbox_outbox_isr . > > Chan is !NULL. > > chan->cl is NULL when the client driver not loaded, the controller > driver

Re: [PATCH v3 03/34] mailbox: vpu-ipc-mailbox: Add support for Intel VPU IPC mailbox

2021-01-31 Thread Jassi Brar
On Fri, Jan 29, 2021 at 8:21 PM wrote: > > From: Daniele Alessandrelli > > Add mailbox controller enabling inter-processor communication (IPC) > between the CPU (aka, the Application Processor - AP) and the VPU on > Intel Movidius SoCs like Keem Bay. > > The controller uses HW FIFOs to enable suc

Re: [PATCH v3 0/5] Add APCS support for SDX55

2021-02-08 Thread Jassi Brar
On Mon, Feb 8, 2021 at 12:20 PM Manivannan Sadhasivam wrote: > > On Mon, Feb 08, 2021 at 09:46:11AM -0800, Stephen Boyd wrote: > > Quoting Manivannan Sadhasivam (2021-01-17 20:11:51) > > > Changes in v2: > > > > > > * Modified the max_register value as per the SDX55 IPC offset in mailbox > > > d

Re: [PATCH] mailbox: no error log in mbox_client_txdone() for tx done by irq

2020-05-30 Thread Jassi Brar
On Mon, May 11, 2020 at 12:52 AM wrote: > > From: Joe Zhu > > client does not know and not care about how controller implement tx done. > mbox_client_txdone() may be called when controller uses irq method. > > Signed-off-by: Joe Zhu > --- > drivers/mailbox/mailbox.c | 4 +++- > 1 file changed,

Re: [PATCH v6] support gce on mt6779 platform

2020-05-30 Thread Jassi Brar
On Thu, May 28, 2020 at 12:05 PM Dennis YC Hsieh wrote: > > This patch support gce on mt6779 platform. > > Change since v5: > - spearate address shift code in client helper and mailbox controller > - separate write_s/write_s_mask and write_s_value/write_s_mask_value so that > client can decide u

Re: [PATCH] mailbox: imx: Add context save/restore for suspend/resume

2020-05-30 Thread Jassi Brar
On Wed, May 27, 2020 at 8:55 PM Anson Huang wrote: > > Gentle ping... > > > > Subject: RE: [PATCH] mailbox: imx: Add context save/restore for > > suspend/resume > > > > > > > > > Subject: RE: [PATCH] mailbox: imx: Add context save/restore for > > > suspend/resume > > > > > > > From: Anson Huang >

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-05-18 Thread Jassi Brar
On Mon, May 18, 2020 at 2:42 AM Viresh Kumar wrote: > > On 15-05-20, 11:46, Jassi Brar wrote: > > As I asked you yesterday over the call, it may help if you could share > > some numbers to back up the doomsday scenario. > > Yes, I have already asked Sudeep to get some n

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-05-18 Thread Jassi Brar
On Mon, May 18, 2020 at 10:40 PM Viresh Kumar wrote: > > On 18-05-20, 18:29, Bjorn Andersson wrote: > > On Thu 14 May 22:17 PDT 2020, Viresh Kumar wrote: > > > This stuff has been doing rounds on the mailing list since several years > > > now with no agreed conclusion by all the parties. And here

[GIT PULL] Mailbox changes for v5.9

2020-08-06 Thread Jassi Brar
Hi Linus, The following changes since commit 92ed301919932f13b9172e525674157e983d: Linux 5.8-rc7 (2020-07-26 14:14:06 -0700) are available in the Git repository at: git://git.linaro.org/landing-teams/working/fujitsu/integration.git tags/mailbox-v5.9 for you to fetch changes up to 88499

Re: [PATCH] dt-bindings: Drop redundant maxItems/items

2020-12-22 Thread Jassi Brar
for this is pending once these existing cases are > fixed. > > Cc: Laurent Pinchart > Cc: Vinod Koul > Cc: Mark Brown > Cc: Greg Kroah-Hartman > Cc: Jassi Brar > Cc: dri-de...@lists.freedesktop.org > Cc: dmaeng...@vger.kernel.org > Cc: alsa-de...@alsa-project.o

Re: [PATCH 02/22] dt-bindings: Add bindings for Keem Bay IPC driver

2020-12-07 Thread Jassi Brar
On Mon, Dec 7, 2020 at 12:43 PM Daniele Alessandrelli wrote: > > Hi Rob, > > Thanks for the feedback. > > On Mon, 2020-12-07 at 10:01 -0600, Rob Herring wrote: > > On Tue, Dec 01, 2020 at 02:34:51PM -0800, mgr...@linux.intel.com wrote: > > > From: Daniele Alessandrelli > > > > > > Add DT binding

Re: [PATCH] mailbox: bcm: Replace tasklet with threaded irq

2021-01-14 Thread Jassi Brar
On Thu, Jan 14, 2021 at 6:21 PM Davidlohr Bueso wrote: > > Tasklets have long been deprecated as being too heavy on the system > by running in irq context - and this is not a performance critical > path. If a higher priority process wants to run, it must wait for > the tasklet to finish before doi

Re: [PATCH] dt-bindings: mailbox: Add compatible for SM8350 IPCC

2021-03-25 Thread Jassi Brar
On Thu, Mar 25, 2021 at 1:08 AM Vinod Koul wrote: > > On 12-03-21, 11:28, Bjorn Andersson wrote: > > On Thu 11 Mar 23:12 CST 2021, Vinod Koul wrote: > > > > Adding Jassi as recipient. Please let Vinod know if you want him to > > resend this patch to you. (I send a patch for MAINTAINERS yesterday)

Re: [PATCH v2, 0/5] Revert "mailbox: mediatek: remove implementation related to atomic_exec"

2021-04-12 Thread Jassi Brar
On Mon, Apr 12, 2021 at 6:18 AM Yongqiang Niu wrote: > > This series base linux 5.12-rc2 > these patches will cause home ui flick when cursor moved, > there is no fix solution yet, revert these patches first. > > change since v1: > add mtk-gce.txt and dts modification > > Yongqiang Niu (5): > Re

Re: [PATCH] mailbox: hisilicon: Use the correct HiSilicon copyright

2021-04-12 Thread Jassi Brar
On Tue, Mar 30, 2021 at 2:22 AM Leo Yan wrote: > > On Tue, Mar 30, 2021 at 02:48:40PM +0800, Hao Fang wrote: > > s/Hisilicon/HiSilicon/g. > > It should use capital S, according to > > https://www.hisilicon.com/en/terms-of-use. > > > > Signed-off-by: Hao Fang > > Though the kernel has tons of "His

Re: [PATCH v6 04/34] dt-bindings: Add bindings for Keem Bay IPC driver

2021-04-12 Thread Jassi Brar
On Mon, Mar 8, 2021 at 2:20 PM mark gross wrote: > > On Fri, Mar 05, 2021 at 03:01:40PM -0600, Rob Herring wrote: > > On Fri, Feb 12, 2021 at 02:22:34PM -0800, mgr...@linux.intel.com wrote: > > > From: Daniele Alessandrelli > > > > > > Add DT binding documentation for the Intel Keem Bay IPC drive

Re: [PATCH v2, 0/5] Revert "mailbox: mediatek: remove implementation related to atomic_exec"

2021-04-14 Thread Jassi Brar
On Wed, Apr 14, 2021 at 3:51 AM Matthias Brugger wrote: > > > > On 12/04/2021 17:29, Jassi Brar wrote: > > On Mon, Apr 12, 2021 at 6:18 AM Yongqiang Niu > > wrote: > >> > >> This series base linux 5.12-rc2 > >> these patches will cause ho

Re: [PATCH 02/22] dt-bindings: Add bindings for Keem Bay IPC driver

2020-12-09 Thread Jassi Brar
On Tue, Dec 8, 2020 at 6:12 PM mark gross wrote: > > On Mon, Dec 07, 2020 at 02:31:37PM -0600, Jassi Brar wrote: > > On Mon, Dec 7, 2020 at 12:43 PM Daniele Alessandrelli > > wrote: > > > > > > Hi Rob, > > > > > > Thanks for the feedba

Re: [PATCH] add chan->cl check in mbox_chan_received_data()

2020-12-15 Thread Jassi Brar
On Tue, Dec 15, 2020 at 2:48 AM Haidong Yao wrote: > --- a/drivers/mailbox/mailbox.c > +++ b/drivers/mailbox/mailbox.c > @@ -152,7 +152,7 @@ static enum hrtimer_restart txdone_hrtimer(struct hrtimer > *hrtimer) > void mbox_chan_received_data(struct mbox_chan *chan, void *mssg) > { > /*

[GIT PULL] Mailbox changes for v5.11]

2020-12-16 Thread Jassi Brar
Hi Linus, The following changes since commit 509a15421674b9e1a3e1916939d0d0efd3e578da: Merge tag '5.10-rc6-smb3-fixes' of git://git.samba.org/sfrench/cifs-2.6 (2020-12-01 15:43:53 -0800) are available in the Git repository at: git://git.linaro.org/landing-teams/working/fujitsu/integration.gi

Re: [PATCH V5 2/2] mailbox: arm_mhuv2: Add driver

2020-11-20 Thread Jassi Brar
On Tue, Nov 17, 2020 at 4:02 AM Viresh Kumar wrote: > + > +/** > + * struct mhuv2 - MHUv2 mailbox controller data > + * > + * @mbox: Mailbox controller belonging to the MHU frame. > + * @send/recv: Base address of the register mapping region. > + * @frame: Frame type: RECEIVER_FRAME or S

Re: [PATCH v3 1/3] dma: Support multiple interleaved frames with non-contiguous memory

2014-02-23 Thread Jassi Brar
On 21 February 2014 23:37, Srikanth Thokala wrote: > On Thu, Feb 20, 2014 at 3:23 PM, Jassi Brar > wrote: >> On 20 February 2014 14:54, Srikanth Thokala wrote: >>> On Wed, Feb 19, 2014 at 12:33 AM, Jassi Brar >>> wrote: >>>> On 18 February 2014 23:16,

Re: [PATCH v3 1/3] dma: Support multiple interleaved frames with non-contiguous memory

2014-02-26 Thread Jassi Brar
On 26 February 2014 23:21, Srikanth Thokala wrote: > On Mon, Feb 24, 2014 at 7:39 AM, Jassi Brar > wrote: >> On 21 February 2014 23:37, Srikanth Thokala wrote: >>> On Thu, Feb 20, 2014 at 3:23 PM, Jassi Brar >>> wrote: >>>> On 20 February 2014 14:54,

Re: [PATCH 2/2] arm64: dts: exynos: added mailbox node

2014-03-17 Thread Jassi Brar
On Mon, Mar 17, 2014 at 5:45 PM, Arnd Bergmann wrote: > On Monday 17 March 2014 17:33:59 Girish K S wrote: >> +Samsung Mailbox Driver >> + >> +Required properties: >> +- compatible: Should be one of the following, >> + "samsung,gh7-mailbox" for >> +

Re: [PATCHv3] Generic Mailbox API

2014-03-05 Thread Jassi Brar
On Sun, Feb 16, 2014 at 2:22 AM, Jassi Brar wrote: > Hello, > > Here is what the generic mailbox api looks like after modifications > to make it work with 5 different platforms. > Major feedback from Suman Anna(TI), LeyFoon Tan(Intel), > Craig McGeachie(Broadcom) and Loic

[PATCHv4 0/5] Common Mailbox Framework

2014-03-18 Thread Jassi Brar
Hi, Here is the next revision of Mailbox code. Changes since v3: o Change name of symbols from ipc to mbox o Return real types instead of void * o Align structures o Change some symbol names rxcb -> rx_callback txcb -> tx_done o Added kernel-doc for exported API o Dropped t

[PATCHv4 3/5] mailbox: pl320: Introduce common API driver

2014-03-18 Thread Jassi Brar
Convert the PL320 controller driver to work with the common mailbox API. Also convert the only user of PL320, highbank-cpufreq.c to work with thee API. Drop the obsoleted driver pl320-ipc.c Signed-off-by: Jassi Brar --- drivers/cpufreq/highbank-cpufreq.c | 24 - drivers/mailbox/Makefile

[PATCHv4 4/5] mailbox: Fix TX completion init

2014-03-18 Thread Jassi Brar
From: LeyFoon Tan For fast TX the complete could be called before being initialized as follows mbox_send_message --> poll_txdone --> tx_tick --> complete(&chan->tx_complete) Init the completion early enough to fix the race. Signed-off-by: LeyFoon Tan Signed-off-by: Jassi Br

[PATCHv4 2/5] mailbox: Introduce framework for mailbox

2014-03-18 Thread Jassi Brar
should have a look at include/linux/mailbox_controller.h Signed-off-by: Jassi Brar --- drivers/mailbox/Makefile | 4 + drivers/mailbox/mailbox.c | 589 + include/linux/mailbox.h| 18 ++ include/linux/mailbox_client.h | 48

[PATCHv4 1/5] mailbox: rename pl320-ipc specific mailbox.h

2014-03-18 Thread Jassi Brar
From: Suman Anna The patch 30058677 "ARM / highbank: add support for pl320 IPC" added a pl320 IPC specific header file as a generic mailbox.h. This file has been renamed appropriately to allow the introduction of the generic mailbox API framework. Acked-by: Mark Langsdorf Cc: Rafael J. Wysocki

[PATCHv4 5/5] mailbox: Fix deleteing poll timer

2014-03-18 Thread Jassi Brar
From: LeyFoon Tan Try to delete the timer only if it was init/used. Signed-off-by: LeyFoon Tan Signed-off-by: Jassi Brar --- drivers/mailbox/mailbox.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index cdf7d45

Re: [PATCHv4 2/5] mailbox: Introduce framework for mailbox

2014-03-18 Thread Jassi Brar
On 19 March 2014 09:30, Girish KS wrote: > On Wed, Mar 19, 2014 at 12:15 AM, Jassi Brar wrote: >> +int mbox_send_message(struct mbox_chan *chan, void *mssg) >> +{ >> + int t; >> + >> + if (!chan || !chan->cl) >> + return -EIN

Re: [PATCHv4 3/5] mailbox: pl320: Introduce common API driver

2014-03-18 Thread Jassi Brar
On 19 March 2014 00:40, Rob Herring wrote: > On Tue, Mar 18, 2014 at 1:45 PM, Jassi Brar wrote: >> Convert the PL320 controller driver to work with the common >> mailbox API. Also convert the only user of PL320, highbank-cpufreq.c >> to work with thee API. Drop the obsolet

Re: [PATCH 2/2] arm64: dts: exynos: added mailbox node

2014-03-20 Thread Jassi Brar
On Wed, Mar 19, 2014 at 11:16 PM, Arnd Bergmann wrote: > On Monday 17 March 2014, Jassi Brar wrote: >> Perhaps the mailbox controller driver should name its links as it >> wants. By how the remote works with the mailbox links, the client >> driver asks for a specific mail

Re: [PATCH 2/2] arm64: dts: exynos: added mailbox node

2014-03-20 Thread Jassi Brar
On Thu, Mar 20, 2014 at 9:42 PM, Arnd Bergmann wrote: > On Thursday 20 March 2014 21:39:56 Jassi Brar wrote: >> On Wed, Mar 19, 2014 at 11:16 PM, Arnd Bergmann wrote: >> > On Monday 17 March 2014, Jassi Brar wrote: >> >> >> Perhaps the mailbox controlle

Re: [PATCH v3 1/3] dma: Support multiple interleaved frames with non-contiguous memory

2014-02-18 Thread Jassi Brar
On 18 February 2014 16:58, Srikanth Thokala wrote: > On Mon, Feb 17, 2014 at 3:27 PM, Jassi Brar > wrote: >> On 15 February 2014 17:30, Srikanth Thokala wrote: >>> The current implementation of interleaved DMA API support multiple >>> frames only when the memory

Re: [PATCHv3 2/6] mailbox: Introduce a new common API

2014-02-18 Thread Jassi Brar
On Tue, Feb 18, 2014 at 11:00 PM, Bjorn Andersson wrote: > On Mon, Feb 17, 2014 at 11:06 PM, Jassi Brar > wrote: >> Hi Courtney, >> >> On 18 February 2014 06:22, Courtney Cavin >> wrote: >>> On Sat, Feb 15, 2014 at 07:25:27PM +0100, Jassi Brar

Re: [PATCH v3 1/3] dma: Support multiple interleaved frames with non-contiguous memory

2014-02-18 Thread Jassi Brar
On 18 February 2014 23:16, Srikanth Thokala wrote: > On Tue, Feb 18, 2014 at 10:20 PM, Jassi Brar > wrote: >> On 18 February 2014 16:58, Srikanth Thokala wrote: >>> On Mon, Feb 17, 2014 at 3:27 PM, Jassi Brar >>> wrote: >>>> On 15 February 2014

Re: [PATCHv3 2/6] mailbox: Introduce a new common API

2014-02-19 Thread Jassi Brar
Hi Kumar, On 19 February 2014 03:02, Kumar Gala wrote: > > On Feb 15, 2014, at 12:25 PM, Jassi Brar wrote: > >> Introduce common framework for client/protocol drivers and >> controller drivers of Inter-Processor-Communication (IPC). >> >> Client driver

Re: [PATCHv3 2/6] mailbox: Introduce a new common API

2014-02-19 Thread Jassi Brar
On 19 February 2014 01:17, Courtney Cavin wrote: > On Tue, Feb 18, 2014 at 08:06:55AM +0100, Jassi Brar wrote: >> >> >> +void *ipc_request_channel(struct ipc_client *cl) >> >> +{ > [...] >> >> + spin_lock_irqsave(&ch

Re: [PATCH v3 1/3] dma: Support multiple interleaved frames with non-contiguous memory

2014-02-20 Thread Jassi Brar
On 20 February 2014 14:54, Srikanth Thokala wrote: > On Wed, Feb 19, 2014 at 12:33 AM, Jassi Brar > wrote: >> On 18 February 2014 23:16, Srikanth Thokala wrote: >>> On Tue, Feb 18, 2014 at 10:20 PM, Jassi Brar >>> wrote: >>>> On 18 February 2014 16

Re: [PATCH] dma: pl330: ensure DMA descriptors are zero-initialised

2013-11-29 Thread Jassi Brar
ro-initialised during allocation and > remove the dummy, per-field initialisation. > > Cc: Jassi Brar > Cc: Vinod Koul > Cc: Dan Williams > Signed-off-by: Will Deacon > --- > drivers/dma/pl330.c | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-) > > di

Re: [PATCHv9 2/4] mailbox: Introduce framework for mailbox

2014-07-31 Thread Jassi Brar
On 23 July 2014 20:56, Lee Jones wrote: > On Wed, 23 Jul 2014, Jassi Brar wrote: >> >> + if (chan->txdone_method == (TXDONE_BY_POLL | TXDONE_BY_ACK)) >> >> + chan->txdone_method = TXDONE_BY_POLL; >> > >> > Unless yo

Re: [PATCHv10 2/4] mailbox: Introduce framework for mailbox

2014-09-25 Thread Jassi Brar
On 24 September 2014 09:14, Ashwin Chaugule wrote: > On 22 September 2014 14:33, Sudeep Holla wrote: > +static void poll_txdone(unsigned long data) > +{ > + struct mbox_controller *mbox = (struct mbox_controller *)data; > + bool txdone, resched = false; > +

Re: Request to include Mailbox tree in linux-next

2014-09-15 Thread Jassi Brar
On 8 August 2014 08:58, Stephen Rothwell wrote: > Hi Jassi, > > On Fri, 8 Aug 2014 20:40:47 +0530 Jassi Brar > wrote: >> >> On 8 August 2014 20:11, Russell King - ARM Linux >> wrote: >> >> Upon Mark's suggestion (and the right thing to do) I

Re: [PATCH v4 2/2] dma: Add Xilinx AXI Video Direct Memory Access Engine driver support

2014-03-10 Thread Jassi Brar
On Thu, Mar 6, 2014 at 7:18 PM, Srikanth Thokala wrote: > +static struct dma_async_tx_descriptor * > +xilinx_vdma_dma_prep_interleaved(struct dma_chan *dchan, > +struct dma_interleaved_template *xt, > +unsigned long flags) > +{ > +

Re: [PATCH v4 2/2] dma: Add Xilinx AXI Video Direct Memory Access Engine driver support

2014-03-11 Thread Jassi Brar
On 11 March 2014 00:00, Srikanth Thokala wrote: > On Mon, Mar 10, 2014 at 9:30 PM, Jassi Brar wrote: >> On Thu, Mar 6, 2014 at 7:18 PM, Srikanth Thokala wrote: >> >>> +static struct dma_async_tx_descriptor * >>> +xilinx_vdma_dma_prep_i

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-05-16 Thread Jassi Brar
On 15 May 2014 19:57, Arnd Bergmann wrote: > On Thursday 15 May 2014 11:41:00 Jassi Brar wrote: >> Introduce common framework for client/protocol drivers and >> controller drivers of Inter-Processor-Communication (IPC). >> >> Client driver developers should have

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-05-19 Thread Jassi Brar
On 19 May 2014 18:38, Arnd Bergmann wrote: > On Friday 16 May 2014 19:03:25 Jassi Brar wrote: > >> Also, some platform might need to communicate with remote master >> during very early boot like for initializing system timers and clocks. >> The API isn't working the

Re: [RFC 0/6] mailbox: add common framework and port drivers

2014-02-14 Thread Jassi Brar
Hi, On 8 February 2014 06:20, Courtney Cavin wrote: > There is currently no common framework for mailbox drivers, so this is my > attempt to come up with something suitable. There seems to be a need for > making this generic, so I have attempted to do just that. Most of this is > modeled pretty

Re: [RFC 0/6] mailbox: add common framework and port drivers

2014-02-14 Thread Jassi Brar
On 15 February 2014 09:10, Greg Kroah-Hartman wrote: > On Sat, Feb 15, 2014 at 09:02:07AM +0530, Jassi Brar wrote: >> Hi, >> >> On 8 February 2014 06:20, Courtney Cavin >> wrote: >> > There is currently no common framework for mailbox drivers, so thi

Re: [RFC 0/6] mailbox: add common framework and port drivers

2014-02-14 Thread Jassi Brar
On 15 February 2014 09:41, Greg Kroah-Hartman wrote: > On Sat, Feb 15, 2014 at 09:27:48AM +0530, Jassi Brar wrote: >> On 15 February 2014 09:10, Greg Kroah-Hartman >> wrote: >> > On Sat, Feb 15, 2014 at 09:02:07AM +0530, Jassi Brar wrote: >> >> Hi, >> &

[PATCHv3] Generic Mailbox API

2014-02-15 Thread Jassi Brar
Hello, Here is what the generic mailbox api looks like after modifications to make it work with 5 different platforms. Major feedback from Suman Anna(TI), LeyFoon Tan(Intel), Craig McGeachie(Broadcom) and Loic Pallardy(ST). Signed-off-by: Jassi Brar -- To unsubscribe from this list: send the

[PATCHv3 1/6] mailbox: rename pl320-ipc specific mailbox.h

2014-02-15 Thread Jassi Brar
From: Suman Anna The patch 30058677 "ARM / highbank: add support for pl320 IPC" added a pl320 IPC specific header file as a generic mailbox.h. This file has been renamed appropriately to allow the introduction of the generic mailbox API framework. Acked-by: Mark Langsdorf Cc: Rafael J. Wysocki

[PATCHv3 2/6] mailbox: Introduce a new common API

2014-02-15 Thread Jassi Brar
should have a look at include/linux/mailbox_controller.h Signed-off-by: Jassi Brar --- drivers/mailbox/Makefile | 4 + drivers/mailbox/mailbox.c | 534 + include/linux/mailbox.h| 17 ++ include/linux/mailbox_client.h | 87

[PATCHv3 4/6] mailbox: Fix TX completion init

2014-02-15 Thread Jassi Brar
From: LeyFoon Tan For fast TX the complete could be called before being initialized as follows ipc_send_message --> poll_txdone --> tx_tick --> complete(&chan->tx_complete) Init the completion early enough to fix the race. Signed-off-by: LeyFoon Tan Signed-off-by: Jassi Br

<    1   2   3   4   5   6   >