Re: [PATCH] epoll: simplify ep_poll_safewake() for CONFIG_DEBUG_LOCK_ALLOC

2019-09-23 Thread Jason Baron
On 9/4/19 4:22 PM, Jason Baron wrote: > Currently, ep_poll_safewake() in the CONFIG_DEBUG_LOCK_ALLOC case uses > ep_call_nested() in order to pass the correct subclass argument to > spin_lock_irqsave_nested(). However, ep_call_nested() adds unnecessary > checks for epoll depth an

[PATCH] epoll: ensure ep_poll() doesn't miss wakeup events

2020-05-01 Thread Jason Baron
s now scheduled and missed the wakeup. Fixes: 339ddb53d373 ("fs/epoll: remove unnecessary wakeups of nested epoll") Signed-off-by: Jason Baron Cc: Alexander Viro Cc: Heiher Cc: Roman Penyaev Cc: Khazhismel Kumykov Cc: Andrew Morton Cc: Davidlohr Bueso Cc: --- fs/eventpoll.c | 23 +

Re: [PATCH 2/2] epoll: atomically remove wait entry on wake up

2020-05-01 Thread Jason Baron
presents event bandwidth, thus higher is > better; number of "run-time ms" represents overall time spent > doing the benchmark, thus lower is better) > > [1] tools/testing/selftests/filesystems/epoll/epoll_wakeup_test.c > [2] https://github.com/rouming/test-tools/bl

Re: [PATCH] epoll: ensure ep_poll() doesn't miss wakeup events

2020-05-01 Thread Jason Baron
eavail = ep_events_available(ep); + write_unlock_irq(&ep->lock); if (eavail) break; if (signal_pending(current)) { Thanks, -Jason > Other than that: > > Reviewed-by: Roman Penyaev > > -- > R

Re: [PATCH] epoll: ensure ep_poll() doesn't miss wakeup events

2020-05-03 Thread Jason Baron
On 5/3/20 6:24 AM, Roman Penyaev wrote: > On 2020-05-02 00:09, Jason Baron wrote: >> On 5/1/20 5:02 PM, Roman Penyaev wrote: >>> Hi Jason, >>> >>> That is indeed a nice catch. >>> Seems we need smp_rmb() pair between list_empty_careful(&am

Re: [PATCH] epoll: ensure ep_poll() doesn't miss wakeup events

2020-05-03 Thread Jason Baron
On 5/4/20 12:29 AM, Jason Baron wrote: > > > On 5/3/20 6:24 AM, Roman Penyaev wrote: >> On 2020-05-02 00:09, Jason Baron wrote: >>> On 5/1/20 5:02 PM, Roman Penyaev wrote: >>>> Hi Jason, >>>> >>>> That is indeed a nice catch. >

Re: [PATCH v2] eventpoll: fix missing wakeup for ovflist in ep_poll_callback

2020-04-28 Thread Jason Baron
On 4/28/20 2:10 PM, Roman Penyaev wrote: > On 2020-04-27 22:38, Jason Baron wrote: >> On 4/25/20 4:59 PM, Khazhismel Kumykov wrote: >>> On Sat, Apr 25, 2020 at 9:17 AM Jason Baron wrote: >>>> >>>> >>>> >>>> On 4/24/20 3:00 PM, K

Re: [PATCH net-next] tcp: Make tcp_fastopen_alloc_ctx static

2019-06-10 Thread Jason Baron
truct tcp_fastopen_context *new_ctx; > void *key = primary_key; > Thanks for fixing. Acked-by: Jason Baron

Re: [PATCH v3 5/6] x86/alternative: Use a single access in text_poke() where possible

2019-01-11 Thread Jason Baron
On 1/11/19 11:57 AM, Josh Poimboeuf wrote: > On Fri, Jan 11, 2019 at 05:46:36PM +0100, Alexandre Chartre wrote: >> >> >> On 01/11/2019 04:28 PM, Josh Poimboeuf wrote: >>> On Fri, Jan 11, 2019 at 01:10:52PM +0100, Alexandre Chartre wrote: To avoid any issue with live patching the call instructi

[PATCH] mm/madvise: allow MADV_DONTNEED to free memory that is MLOCK_ONFAULT

2018-06-08 Thread Jason Baron
hink allowing MADV_FREE for MLOCK_ONFAULT regions makes sense, since the point of MLOCK_ONFAULT is for userspace to know when pages are locked in memory and thus to know when page faults will occur. Signed-off-by: Jason Baron Cc: Andrew Morton Cc: Michal Hocko Cc: Vlastimil Babka Cc: Joonsoo Kim C

Re: [PATCH] mm/madvise: allow MADV_DONTNEED to free memory that is MLOCK_ONFAULT

2018-06-08 Thread Jason Baron
On 06/08/2018 03:57 PM, Andrew Morton wrote: > On Fri, 8 Jun 2018 14:56:52 -0400 Jason Baron wrote: > >> In order to free memory that is marked MLOCK_ONFAULT, the memory region >> needs to be first unlocked, before calling MADV_DONTNEED. And if the region >> is to be reu

Re: [PATCH] mm/madvise: allow MADV_DONTNEED to free memory that is MLOCK_ONFAULT

2018-06-11 Thread Jason Baron
On 06/11/2018 03:20 AM, Michal Hocko wrote: > [CCing linux-api - please make sure to CC this mailing list anytime you > are touching user visible apis] > > On Fri 08-06-18 14:56:52, Jason Baron wrote: >> In order to free memory that is marked MLOCK_ONFAULT, the memory region &g

Re: [PATCH] mm/madvise: allow MADV_DONTNEED to free memory that is MLOCK_ONFAULT

2018-06-11 Thread Jason Baron
On 06/11/2018 11:03 AM, Michal Hocko wrote: > On Mon 11-06-18 10:51:44, Jason Baron wrote: >> On 06/11/2018 03:20 AM, Michal Hocko wrote: >>> [CCing linux-api - please make sure to CC this mailing list anytime you >>> are touching user visible apis] >>>

[PATCH v2] jump_label: reduce the size of struct static_key

2017-01-04 Thread Jason Baron
ta bss dec hex filename 8315249 5061176 794624 14171049 d83ba9 vmlinux.pre 8315502 5046136 790528 14152166 d7f1e6 vmlinux.post Cc: Peter Zijlstra Cc: Steven Rostedt Cc: Ingo Molnar Cc: Joe Perches Signed-off-by: Jason Baron --- Changed in v2: -Replace static_key-&

[PATCH v3] jump_label: reduce the size of struct static_key

2017-01-31 Thread Jason Baron
ta bss dec hex filename 8092427 5016512 790528 13899467 d416cb vmlinux.pre 8092694 5001536 790528 13884758 d3dd56 vmlinux.post Cc: Peter Zijlstra Cc: Steven Rostedt Cc: Ingo Molnar Cc: Joe Perches Signed-off-by: Jason Baron --- Changed in v3: -added static_key_set_[entri

Re: [PATCH v3] jump_label: reduce the size of struct static_key

2017-02-01 Thread Jason Baron
Hi Steve, On 01/31/2017 07:32 PM, Steven Rostedt wrote: > On Tue, 31 Jan 2017 17:00:43 -0500 > Jason Baron wrote: > >> --- >> Documentation/static-keys.txt | 4 +- >> include/linux/jump_label.h| 23 +--- >> ke

Re: [PATCH v2] jump_label: reduce the size of struct static_key

2017-01-23 Thread Jason Baron
On 01/21/2017 02:07 AM, Ingo Molnar wrote: * Jason Baron wrote: For example the last line could sure be written as: key->entries = jlm->entries; key->type |= static_key_type(key); right? Hi, So that is going to over-

Re: [PATCH v2] jump_label: reduce the size of struct static_key

2017-01-19 Thread Jason Baron
On 01/04/2017 01:41 PM, Jason Baron wrote: The static_key->next field goes mostly unused. The field is used for associating module uses with a static key. Most uses of struct static_key define a static key in the core kernel and make use of it entirely within the core kernel, or define

Re: [PATCH v2] jump_label: reduce the size of struct static_key

2017-01-20 Thread Jason Baron
On 01/20/2017 02:19 AM, Ingo Molnar wrote: * Jason Baron wrote: struct static_key { atomic_t enabled; +/* + * bit 0 => 1 if key is initially true + * 0 if initially false + * bit 1 => 1 if points to struct static_key_mod + * 0 if points to struct jump

Re: [PATCH v2 4/4] dynamic_debug: add jump label support

2016-06-10 Thread Jason Baron
On 06/10/2016 05:54 AM, Arnd Bergmann wrote: > On Friday, May 20, 2016 5:16:36 PM CEST Jason Baron wrote: >> Although dynamic debug is often only used for debug builds, sometimes its >> enabled for production builds as well. Minimize its impact by using jump >> labels.

Re: [PATCH v2 4/4] dynamic_debug: add jump label support

2016-07-05 Thread Jason Baron
On 07/01/2016 03:30 PM, Chris Metcalf wrote: > On 6/10/2016 5:28 PM, Jason Baron wrote: >> On 06/10/2016 05:54 AM, Arnd Bergmann wrote: >>> On Friday, May 20, 2016 5:16:36 PM CEST Jason Baron wrote: >>>> Although dynamic debug is often only used for debug builds, &

[PATCH v3 0/7] convert dynamic_debug to use jump labels

2016-07-06 Thread Jason Baron
Fix concurrent static_key_slow_inc()) Thanks, -Jason Chris Metcalf (1): tile: support static_key usage in non-module __exit sections Jason Baron (6): powerpc: add explicit #include for jump label s390: add explicit #include for jump label sparc: support static_key usage in non-module __

[PATCH v3 3/7] sparc: support static_key usage in non-module __exit sections

2016-07-06 Thread Jason Baron
; of xxx.o: defined in discarded section `.exit.text' of xxx.o Cc: "David S. Miller" Cc: sparcli...@vger.kernel.org Signed-off-by: Jason Baron --- arch/sparc/kernel/vmlinux.lds.S | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/sparc/kernel/vmlinux.lds.S b/arch/sparc/k

[PATCH v3 4/7] tile: support static_key usage in non-module __exit sections

2016-07-06 Thread Jason Baron
; of xxx.o: defined in discarded section `.exit.text' of xxx.o Support this usage by keeping the .exit.text sections in the final image if JUMP_LABEL is defined, then discarding them once initialization is complete. Signed-off-by: Chris Metcalf Signed-off-by: Jason Baron --- arch/tile/kernel/vml

[PATCH v3 5/7] arm: jump label may reference text in __exit

2016-07-06 Thread Jason Baron
The jump table can reference text found in an __exit section. Thus, instead of discarding it at build time, include EXIT_TEXT as part of __init and it will be released when the system boots. Cc: Arnd Bergmann Cc: linux-arm-ker...@lists.infradead.org Cc: li...@armlinux.org.uk Signed-off-by: Jason

[PATCH v3 2/7] s390: add explicit for jump label

2016-07-06 Thread Jason Baron
Ensure that we always have __stringify(). Cc: Martin Schwidefsky Cc: Heiko Carstens Cc: linux-s...@vger.kernel.org Signed-off-by: Jason Baron --- arch/s390/include/asm/jump_label.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/s390/include/asm/jump_label.h b/arch/s390/include/asm

[PATCH v3 7/7] dynamic_debug: add jump label support

2016-07-06 Thread Jason Baron
the direction of the branches, and hence usually not in cache. textdata bss dec hex filename 8194852 4879776 925696 14000324 d5a0c4 vmlinux.pre 8187337 4960224 925696 14073257 d6bda9 vmlinux.post Signed-off-by: Jason Baron --- include/linux/dynamic_debug.h

[PATCH v3 1/7] powerpc: add explicit #include for jump label

2016-07-06 Thread Jason Baron
The stringify_in_c() macro may not be included. Make the dependency explicit. Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: linuxppc-...@lists.ozlabs.org Signed-off-by: Jason Baron --- arch/powerpc/include/asm/jump_label.h | 1 + 1 file changed, 1 insertion(+) diff

[PATCH v3 6/7] jump_label: remove bug.h, atomic.h dependencies for HAVE_JUMP_LABEL

2016-07-06 Thread Jason Baron
jump_label.h 'includable' from most places. Signed-off-by: Jason Baron --- include/linux/jump_label.h | 46 kernel/jump_label.c| 53 ++ 2 files changed, 76 insertions(+), 23 deletions(-) di

Re: [PATCH v3 7/7] dynamic_debug: add jump label support

2016-07-07 Thread Jason Baron
On 07/06/2016 06:52 PM, Joe Perches wrote: > On Wed, 2016-07-06 at 17:42 -0400, Jason Baron wrote: >> Although dynamic debug is often only used for debug builds, sometimes its >> enabled for production builds as well. Minimize its impact by using jump >> labels. This reduce

strange Mac OSX RST behavior

2016-07-01 Thread Jason Baron
I'm wondering if anybody else has run into this... On Mac OSX 10.11.5 (latest version), we have found that when tcp connections are abruptly terminated (via ^C), a FIN is sent followed by an RST packet. The RST is sent with the same sequence number as the FIN, and thus dropped since the stack only

Re: strange Mac OSX RST behavior

2016-07-01 Thread Jason Baron
On 07/01/2016 01:08 PM, Rick Jones wrote: > On 07/01/2016 08:10 AM, Jason Baron wrote: >> I'm wondering if anybody else has run into this... >> >> On Mac OSX 10.11.5 (latest version), we have found that when tcp >> connections are abruptly terminated (via ^C), a F

Re: strange Mac OSX RST behavior

2016-07-01 Thread Jason Baron
On 07/01/2016 02:16 PM, One Thousand Gnomes wrote: >> yes, we do in fact see a POLLRDHUP from the FIN in this case and >> read of zero, but we still have more data to write to the socket, and >> b/c the RST is dropped here, the socket stays in TIME_WAIT until >> things eventually time out... > >

Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands

2017-01-01 Thread Jason Baron
On 01/01/2017 09:22 AM, Bart Van Assche wrote: > On Sat, 2016-12-31 at 15:19 -0800, James Bottomley wrote: >> On Thu, 2016-12-29 at 00:02 -0800, Christoph Hellwig wrote: >>> On Wed, Dec 28, 2016 at 11:30:24PM -0500, Jason Baron wrote: >>>> Add a new parameter to s

[PATCH] jump_label: reduce the size of struct static_key

2017-01-03 Thread Jason Baron
ta bss dec hex filename 8315249 5061176 794624 14171049 d83ba9 vmlinux.pre 8315502 5046136 790528 14152166 d7f1e6 vmlinux.post Cc: Peter Zijlstra Cc: Steven Rostedt Cc: Ingo Molnar Cc: Joe Perches Signed-off-by: Jason Baron --- Documentation/static-keys.txt | 4

Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands

2017-01-03 Thread Jason Baron
On 01/01/2017 12:39 PM, James Bottomley wrote: On Sun, 2017-01-01 at 11:33 -0500, David Miller wrote: From: Bart Van Assche Date: Sun, 1 Jan 2017 14:22:11 + My recommendation is to revert commit 18f6084a989b ("scsi: mpt3sas: Fix secure erase premature termination"). Since the mpt3sas driv

[PATCH] scsi: mpt3sas: fix hang on ata passthru commands

2016-12-28 Thread Jason Baron
ecommand() wait code to SCSI core") adds a call to scsi_wait_for_queuecommand() from scsi_internal_device_block(). Add a new parameter to scsi_internal_device_block() to decide whether or not to invoke scsi_wait_for_queuecommand(). Signed-off-by: Jason Baron Cc: Sathya Prakash Cc: Chait

Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands

2016-12-29 Thread Jason Baron
On 12/29/2016 03:02 AM, Christoph Hellwig wrote: > On Wed, Dec 28, 2016 at 11:30:24PM -0500, Jason Baron wrote: >> Add a new parameter to scsi_internal_device_block() to decide whether >> or not to invoke scsi_wait_for_queuecommand(). > We'll also need to deal with the blk

[PATCH] binfmt_elf: use vmalloc() for allocation of vma_filesz

2016-11-21 Thread Jason Baron
with a 4k page size, and 8 bytes per seg, this is a max of 128 pages or an order 7 allocation. Other parts of the core dump path, such as fill_files_note() are already using vmalloc() for presumably similar reasons. Signed-off-by: Jason Baron --- fs/binfmt_elf.c | 6 -- 1 file changed, 4

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

2017-02-28 Thread Jason Baron
On 02/28/2017 01:16 PM, David Daney wrote: On 02/28/2017 08:21 AM, Steven Rostedt wrote: On Tue, 28 Feb 2017 10:25:46 +0530 Sachin Sant wrote: File: ./net/ipv4/xfrm4_input.o [12] __jump_table PROGBITS 000639 18 18 WAM 0 0 1 File: ./net/ipv4/udplite.o F

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

2017-02-28 Thread Jason Baron
On 02/28/2017 02:22 PM, David Daney wrote: > On 02/28/2017 11:05 AM, David Daney wrote: >> On 02/28/2017 10:39 AM, Jason Baron wrote: >>> > [...] >>>> I suspect that the alignment of the __jump_table section in the .ko >>>> files is not correct, a

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

2017-02-28 Thread Jason Baron
On 02/28/2017 03:15 PM, David Daney wrote: On 02/28/2017 11:34 AM, Jason Baron wrote: On 02/28/2017 02:22 PM, David Daney wrote: On 02/28/2017 11:05 AM, David Daney wrote: On 02/28/2017 10:39 AM, Jason Baron wrote: [...] I suspect that the alignment of the __jump_table section in the

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

2017-03-01 Thread Jason Baron
On 03/01/2017 11:40 AM, David Daney wrote: > On 02/28/2017 10:34 PM, Michael Ellerman wrote: >> Jason Baron writes: >> ... >>> I also checked all the other .ko files and they were properly aligned. >>> So I think this should hopefully work, and I lik

Re: [PATCH] module: set __jump_table alignment to 8

2017-03-02 Thread Jason Baron
good to me. Reviewed-by: Jason Baron Thanks, -Jason

Re: [PATCH] jump_label: Fix anonymous union initialization

2017-03-02 Thread Jason Baron
{ .entries = (void *)JUMP_TYPE_FALSE } } #else /* !HAVE_JUMP_LABEL */ (Adding Steve to 'cc) Thanks for the fix. Reviewed-by: Jason Baron Thanks, -Jason

Re: next-20170217 boot on POWER8 LPAR : WARNING @kernel/jump_label.c:287

2017-02-21 Thread Jason Baron
On 02/20/2017 10:05 PM, Sachin Sant wrote: On 20-Feb-2017, at 8:27 PM, Jason Baron mailto:jba...@akamai.com>> wrote: Hi, On 02/19/2017 09:07 AM, Sachin Sant wrote: While booting next-20170217 on a POWER8 LPAR following warning is displayed. Reverting the following commit helps boot c

Re: [RFC 0/3] fs,epoll: Add ability to call kcmp to find target files

2017-02-21 Thread Jason Baron
On 02/21/2017 11:59 AM, Cyrill Gorcunov wrote: Hi! In previous series EPOLL_CTL_DUP operation has been discussed but considered as potentially scary. So here is an another approach: - extend fdinfo of epoll files with inode, device and file position for every target, which allow the reader t

Re: next-20170217 boot on POWER8 LPAR : WARNING @kernel/jump_label.c:287

2017-02-22 Thread Jason Baron
On 02/22/2017 12:38 AM, Michael Ellerman wrote: > Jason Baron writes: > >> On 02/20/2017 10:05 PM, Sachin Sant wrote: >>> >>>> On 20-Feb-2017, at 8:27 PM, Jason Baron >>> <mailto:jba...@akamai.com>> wrote: >>>> >>>> H

Re: [PATCH] jump_label: don't export section tags

2017-02-10 Thread Jason Baron
On 02/10/2017 12:29 PM, Michael S. Tsirkin wrote: These are supplied by the linker and only used by jump_label.c. This trivial patch moves them out of jump_label.h. Cc: Jason Baron Cc: Peter Zijlstra Cc: Steven Rostedt Cc: Borislav Petkov Cc: Andrew Morton Cc: Linus Torvalds Cc: Thomas

Re: [RFC 1/2] fs,eventpoll: Add ability to install target file by its number

2017-02-17 Thread Jason Baron
On 02/17/2017 01:01 PM, Cyrill Gorcunov wrote: On Fri, Feb 17, 2017 at 09:20:34AM -0800, Andy Lutomirski wrote: This is a scary thing to let an unprivileged process do. I'm wondering if there might be a nicer way to address this using a better interface in /proc. Well, I tend to agree. Nee

Re: next-20170217 boot on POWER8 LPAR : WARNING @kernel/jump_label.c:287

2017-02-20 Thread Jason Baron
Hi, On 02/19/2017 09:07 AM, Sachin Sant wrote: > While booting next-20170217 on a POWER8 LPAR following > warning is displayed. > > Reverting the following commit helps boot cleanly. > commit 3821fd35b5 : jump_label: Reduce the size of struct static_key > > [ 11.393008] [ cut here

[PATCH] jump_label: align jump_entry table to at least 4-bytes

2017-02-27 Thread Jason Baron
: Michael Ellerman Cc: Anton Blanchard Cc: Rabin Vincent Cc: Russell King Cc: Ralf Baechle Cc: Chris Metcalf Cc: Zhigang Lu Cc: David Daney Signed-off-by: Jason Baron --- arch/arm/include/asm/jump_label.h | 2 ++ arch/mips/include/asm/jump_label.h| 2 ++ arch/powerpc/include/asm

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

2017-02-27 Thread Jason Baron
On 02/27/2017 01:57 PM, David Daney wrote: On 02/27/2017 10:49 AM, Jason Baron wrote: The core jump_label code makes use of the 2 lower bits of the static_key::[type|entries|next] field. Thus, ensure that the jump_entry table is at least 4-byte aligned. [...] diff --git a/arch/mips/include

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

2017-02-27 Thread Jason Baron
On 02/27/2017 05:45 PM, David Daney wrote: On 02/27/2017 02:36 PM, Steven Rostedt wrote: On Mon, 27 Feb 2017 14:21:21 -0800 David Daney wrote: See attached for mips. It seems to do the right thing. I leave it as an exercise to the reader to fix the other architectures. Consult your own

[PATCH v4] jump_label: reduce the size of struct static_key

2017-02-03 Thread Jason Baron
ss dec hex filename 8092427 5016512 790528 13899467 d416cb vmlinux.pre 8093205 5001600 790528 13885333 d3df95 vmlinux.post Cc: Peter Zijlstra Cc: Steven Rostedt Cc: Ingo Molnar Cc: Joe Perches Signed-off-by: Jason Baron --- Changed in v4: -added WARN*() invariants

Re: MAINTAINERS without commits in the last 3 years

2016-08-26 Thread Jason Baron
On 08/24/2016 07:33 PM, Joe Perches wrote: Many email addresses in MAINTAINERS no longer work so many sections in MAINTAINERS could likely be considered either obsolete or unmaintained. ... juhle...@akamai.com Hi Joe, So I can confirm that he is no longer here, and as far as I know is not in

Re: [PATCH v3 7/7] dynamic_debug: add jump label support

2016-07-11 Thread Jason Baron
On 07/08/2016 05:41 PM, Andrew Morton wrote: On Wed, 6 Jul 2016 17:42:36 -0400 Jason Baron wrote: Although dynamic debug is often only used for debug builds, sometimes its enabled for production builds as well. Minimize its impact by using jump labels. This reduces the text section by 7000

Re: [PATCH v3 7/7] dynamic_debug: add jump label support

2016-07-11 Thread Jason Baron
On 07/11/2016 03:23 PM, Andrew Morton wrote: On Mon, 11 Jul 2016 09:18:21 -0400 Jason Baron wrote: On 07/08/2016 05:41 PM, Andrew Morton wrote: On Wed, 6 Jul 2016 17:42:36 -0400 Jason Baron wrote: Although dynamic debug is often only used for debug builds, sometimes its enabled for

Re: [PATCH v2 4/4] dynamic_debug: add jump label support

2016-06-10 Thread Jason Baron
On 06/10/2016 05:54 AM, Arnd Bergmann wrote: > On Friday, May 20, 2016 5:16:36 PM CEST Jason Baron wrote: >> Although dynamic debug is often only used for debug builds, sometimes its >> enabled for production builds as well. Minimize its impact by using jump >> labels.

Re: [PATCH v2 4/4] dynamic_debug: add jump label support

2016-06-13 Thread Jason Baron
On 06/13/2016 04:23 PM, Arnd Bergmann wrote: > On Monday, June 13, 2016 6:05:22 PM CEST Arnd Bergmann wrote: >> On Friday, June 10, 2016 11:33:07 AM CEST Jason Baron wrote: >>> On 06/10/2016 05:54 AM, Arnd Bergmann wrote: >>>> On Friday, May 20, 2016 5:1

Re: [PATCH] epoll: add exclusive wakeups flag

2016-03-14 Thread Jason Baron
. > > On 03/15/2016 03:55 AM, Jason Baron wrote: >> On 03/11/2016 06:25 PM, Michael Kerrisk (man-pages) wrote: >>> On 03/11/2016 09:51 PM, Jason Baron wrote: >>>> On 03/11/2016 03:30 PM, Michael Kerrisk (man-pages) wrote: > > [...] >

Re: [PATCH] epoll: add exclusive wakeups flag

2016-03-14 Thread Jason Baron
Hi Michael, On 03/14/2016 05:03 PM, Michael Kerrisk (man-pages) wrote: > Hi Jason, > > On 03/15/2016 09:01 AM, Michael Kerrisk (man-pages) wrote: >> Hi Jason, >> >> On 03/15/2016 08:32 AM, Jason Baron wrote: >>> >>> >>> On 03/14/2016 01:47

Re: [PATCH] epoll: add exclusive wakeups flag

2016-03-14 Thread Jason Baron
Hi Michael, On 03/14/2016 07:26 PM, Michael Kerrisk (man-pages) wrote: > Hi Jason, > > On 03/15/2016 11:35 AM, Jason Baron wrote: >> Hi Michael, >> >> On 03/14/2016 05:03 PM, Michael Kerrisk (man-pages) wrote: >>> Hi Jason, >>> >>> On

Re: Kernel broken on processors without performance counters

2015-07-10 Thread Jason Baron
On 07/10/2015 10:13 AM, Peter Zijlstra wrote: > On Wed, Jul 08, 2015 at 05:36:43PM -0700, Andy Lutomirski wrote: In what universe is "static_key_false" a reasonable name for a function that returns true if a static key is true? >> I think the current naming is almost maximally bad. The n

Re: [PATCH] epoll: add exclusive wakeups flag

2016-02-01 Thread Jason Baron
On 01/29/2016 03:14 AM, Michael Kerrisk (man-pages) wrote: > Hello Jason, > On 01/28/2016 06:57 PM, Jason Baron wrote: >> Hi, >> >> On 01/28/2016 02:16 AM, Michael Kerrisk (man-pages) wrote: >>> Hi Jason, >>> >>> On 12/08/2015 04:23 AM, Jaso

Re: question about cpusets vs sched_setaffinity()

2015-12-11 Thread Jason Baron
On 12/10/2015 04:30 PM, Chris Friesen wrote: > Hi, > > I've got a question about the interaction between cpusets and > sched_setaffinity(). > > If I put a task into a cpuset and then call sched_setaffinity() on it, > it will be affined to the intersection of the two sets of cpus. (Those > spec

Re: [PATCH] epoll: add exclusive wakeups flag

2016-01-28 Thread Jason Baron
Hi, On 01/28/2016 02:16 AM, Michael Kerrisk (man-pages) wrote: > Hi Jason, > > On 12/08/2015 04:23 AM, Jason Baron wrote: >> Hi, >> >> Re-post of an old series addressing thundering herd issues when sharing >> an event source fd amongst multiple epoll fds. Last

Re: Linux 3.14.58

2015-12-22 Thread Jason Baron
Hi, We've noticed livelocks in shrink_dentry_list() very similar to this report on stable 3.14.56: http://lkml.iu.edu/hypermail/linux/kernel/1405.3/00470.html It appears that the patches that introduced this issue came into 3.14.51 in August with the same set of patches mentioned in the reference

Re: Linux 3.14.58

2015-12-22 Thread Jason Baron
On 12/22/2015 11:39 AM, Guillaume Morin wrote: > Jason, > > On 22 Dec 11:02, Jason Baron wrote: >> We've noticed livelocks in shrink_dentry_list() very similar to this >> report on stable 3.14.56: >> http://lkml.iu.edu/hypermail/linux/kernel/1405.3/00470.html &

[PATCH] epoll: restrict EPOLLEXCLUSIVE to POLLIN and POLLOUT

2016-02-04 Thread Jason Baron
LUSIVE. EPOLL_CTL_MOD is also not allowed if the fd was previously added as EPOLLEXCLUSIVE. It seems with the limited number of flags to not be as interesting, but this could be relaxed at some further point. Signed-off-by: Jason Baron --- fs/eventpoll.c | 38

Re: [linux-review:Jason-Baron/convert-dynamic_debug-to-use-jump-labels/20160126-055359] 30e241d11bfa30ea56c42028ef9776135d422b57 BUILD DONE

2016-01-26 Thread Jason Baron
- please revert this series until I work out these issues. Sorry for the noise. Thanks, -Jason On 01/26/2016 12:30 AM, kbuild test robot wrote: > https://github.com/0day-ci/linux > Jason-Baron/convert-dynamic_debug-to-use-jump-labels/20160126-055359 > 30e241d11bfa30ea56c42028ef9776135d

Re: 3.14 stable regression don't remove from shrink list in select_collect()

2016-01-25 Thread Jason Baron
On 01/25/2016 11:05 AM, Shawn Bohrer wrote: > I recently updated some machines to 3.14.58 and they reliably get soft > lockups. Sometimes the soft lockup recovers and some times it does > not. I've bisected this on the 3.14 stable branch and arrived at: > > c214cb82cdc744225d85899fc138251527f75f

[PATCH 0/3] convert dynamic_debug to use jump labels

2016-01-25 Thread Jason Baron
an be used with minimail dependencies. I think this is consistent with how this facility is often used, and should be useful for other use-cases as well. Patch #2 was required to get powerpc to compile. Thanks, -Jason Jason Baron (3): jump_label: create jump_label_branch.h powerpc: add explici

[PATCH 2/3] powerpc: add explicit #include for jump label

2016-01-25 Thread Jason Baron
The stringify_in_c() macro may not be included. Make the dependency explicit. Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Signed-off-by: Jason Baron --- arch/powerpc/include/asm/jump_label.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/include/asm

[PATCH 3/3] dynamic_debug: add jump label support

2016-01-25 Thread Jason Baron
the direction of the branches, and hence usually not in cache. text data bss dechex filename 10369421 206 917504 13320261 cb4045 vmlinux.pre 10363054 2103736 917504 13384294 cc3a66 vmlinux.post Cc: Joe Perches Signed-off-by: Jason Baron --- include/linux

[PATCH 1/3] jump_label: create jump_label_branch.h

2016-01-25 Thread Jason Baron
() definitions into a new jump_label_branch.h header. This is consistant with a common usage pattern for jump_label, where the branch locations are often separated from the branch updates. This makes jump_label more includable. Cc: Joe Perches Cc: Peter Zijlstra Signed-off-by: Jason Baron --- include/linux

Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-11 Thread Jason Baron
On 6/11/20 5:19 PM, jim.cro...@gmail.com wrote: > trimmed.. > Currently I think there not enough "levels" to map something like drm.debug to the new dyn dbg feature. I don't think it is intrinsic but I couldn't find the bit of the code where the 5-bit level in struct _ddebug

Re: [PATCH v3 20/21] dyndbg: add user-flag, negating-flags, and filtering on flags

2020-06-18 Thread Jason Baron
On 6/18/20 1:40 PM, Petr Mladek wrote: > On Thu 2020-06-18 18:19:12, Petr Mladek wrote: >> On Wed 2020-06-17 10:25:35, Jim Cromie wrote: >>> 1. Add a user-flag [u] which works like the [pfmlt] flags, but has no >>> effect on callsite behavior; it allows incremental marking of >>> arbitrary sets

Re: [PATCH v3 20/21] dyndbg: add user-flag, negating-flags, and filtering on flags

2020-06-18 Thread Jason Baron
On 6/18/20 3:11 PM, jim.cro...@gmail.com wrote: > On Thu, Jun 18, 2020 at 12:17 PM Jason Baron wrote: >> >> >> >> On 6/18/20 1:40 PM, Petr Mladek wrote: >>> On Thu 2020-06-18 18:19:12, Petr Mladek wrote: >>>> On Wed 2020-06-17 10:25:35, Jim

Re: [PATCH 09/16] dyndbg: accept 'file foo.c:func1' and 'file foo.c:10-100'

2020-06-12 Thread Jason Baron
On 6/5/20 12:26 PM, Jim Cromie wrote: > Accept these additional query forms: > >echo "file $filestr +_" > control > >path/to/file.c:100 # as from control, column 1 >path/to/file.c:1-100 # or any legal line-range >path/to/file.c:func_A # as from an editor/brow

Re: [PATCH 00/16] dynamic_debug: cleanups, 2 features

2020-06-12 Thread Jason Baron
On 6/5/20 12:26 PM, Jim Cromie wrote: > Patchset starts with 7 "cleanups"; > - it changes section name from vague "__verbose" to "__dyndbg" > - cleaner docs, drop obsolete comment & useless debug prints, refine > verbosity, fix a BUG_ON, ram reporting miscounts. > > It adds a few query parsin

Re: [PATCH 12/16] dyndbg: add filter parameter to ddebug_parse_flags

2020-06-12 Thread Jason Baron
On 6/5/20 12:26 PM, Jim Cromie wrote: > Add a new *filter param to ddebug_parse_flags(), allowing it to > communicate optional filter flags back to its caller: ddebug_change() > I think you meant ddebug_exec_query() here? Thanks, -Jason > Also, ddebug_change doesn't alter any of its argume

Re: [PATCH v4 13/17] dyndbg: accept 'file foo.c:func1' and 'file foo.c:10-100'

2020-07-13 Thread Jason Baron
On 6/20/20 2:06 PM, Jim Cromie wrote: > Accept these additional query forms: > >echo "file $filestr +_" > control > >path/to/file.c:100 # as from control, column 1 >path/to/file.c:1-100 # or any legal line-range >path/to/file.c:func_A # as from an editor/brow

Re: [PATCH 1/1] epoll: call final ep_events_available() check under the lock

2020-05-05 Thread Jason Baron
fully compliant to what is said in the comment of the patch > where the actual fatal_signal_pending() check was added: > c257a340ede0 ("fs, epoll: short circuit fetching events if thread > has been killed"). > > Signed-off-by: Roman Penyaev > Reported-by: Jason Baron &g

Re: [PATCH v2] dynamic debug: allow printing to trace event

2020-08-14 Thread Jason Baron
On 8/14/20 1:15 PM, Steven Rostedt wrote: > On Fri, 14 Aug 2020 15:31:51 +0200 > Vincent Whitchurch wrote: >> index aa9ff9e1c0b3..f599ed21ecc5 100644 >> --- a/include/linux/dynamic_debug.h >> +++ b/include/linux/dynamic_debug.h >> @@ -27,13 +27,16 @@ struct _ddebug { >> * writes commands

[PATCH] hwmon: (nct7904) Correct divide by 0

2020-08-21 Thread Jason Baron
] seq_read+0xd8/0x3e0 [ 1656.548127] vfs_read+0x89/0x130 [ 1656.548234] ksys_read+0x7d/0xb0 [ 1656.548342] do_syscall_64+0x48/0x110 [ 1656.548451] entry_SYSCALL_64_after_hwframe+0x44/0xa9 Signed-off-by: Jason Baron --- drivers/hwmon/nct7904.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH v5 00/18] dynamic_debug fixes, cleanups, features, export

2020-07-24 Thread Jason Baron
On 7/19/20 7:10 PM, Jim Cromie wrote: > this is v5, changes from previous: > - moved a chunk from patch 13 to 12, per Jason > - shorten logging prefix to "dyndbg", drop __func__ > - now with more commit-log advocacy > - shuffle EXPORT_GPL(ddebug_exec_queries) last. > - v4+ series Acked-by:

[PATCH] EDAC/ie31200: fallback if host bridge device is already initialized

2020-07-16 Thread Jason Baron
l be configured. This is similar in approach to other edac drivers. Signed-off-by: Jason Baron Cc: Borislav Petkov Cc: Mauro Carvalho Chehab Cc: Tony Luck Cc: linux-edac --- drivers/edac/ie31200_edac.c | 50 ++--- 1 file changed, 47 insertions(+), 3 del

Re: [PATCH v4 13/17] dyndbg: accept 'file foo.c:func1' and 'file foo.c:10-100'

2020-07-16 Thread Jason Baron
or as separate patch... >> >> Thanks, >> >> -Jason >> > > ok, I'll split it out, maybe merge with prior. > > Any other tweaks ? > maybe move export last in series ? sure. > how do you feel about changing the pr_fmt > to just mod-name "dynamic_debug" or "dyndbg" > So removing the function name? I'm fine either way. Feel free to add Ack-by: Jason Baron to the series. Thanks, -Jason

Re: [PATCH] EDAC/ie31200: fallback if host bridge device is already initialized

2020-07-16 Thread Jason Baron
On 7/16/20 2:52 PM, Luck, Tony wrote: > On Thu, Jul 16, 2020 at 02:25:11PM -0400, Jason Baron wrote: >> The Intel uncore driver may claim some of the pci ids from ie31200 which >> means that the ie31200 edac driver will not initialize them as part of >> pci_register_driver

Re: [PATCH] lib: dynamic_debug: no need to check return value of debugfs_create functions

2019-06-13 Thread Jason Baron
On 6/12/19 11:35 AM, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Jason Baron > Cc: linux-kern

Re: [PATCH] lib: dynamic_debug: no need to check return value of debugfs_create functions

2019-06-13 Thread Jason Baron
On 6/13/19 11:59 AM, Greg Kroah-Hartman wrote: > On Thu, Jun 13, 2019 at 10:33:23AM -0400, Jason Baron wrote: >> On 6/12/19 11:35 AM, Greg Kroah-Hartman wrote: >>> When calling debugfs functions, there is no need to ever check the >>> return value. The function ca

Re: [PATCH v3 20/21] dyndbg: add user-flag, negating-flags, and filtering on flags

2020-06-19 Thread Jason Baron
On 6/18/20 6:48 PM, jim.cro...@gmail.com wrote: > On Thu, Jun 18, 2020 at 4:34 PM Stanimir Varbanov > wrote: >> >> Hi Jason, Jim, >> > > > >>> I would be curious to see what Stanimir thinks of this proposal >>> and whether it would work for his venus driver, which is what >>> prompted this m

Re: [PATCH 1/3] jump_label: Pull get_online_cpus() into generic code

2017-04-21 Thread Jason Baron
On 04/18/2017 06:32 AM, Peter Zijlstra wrote: This change does two things; it moves the get_online_cpus() call into generic code, with the aim of later providing some static_key ops that avoid it. And as a side effect it inverts the relation between cpu_hotplug_lock and jump_label_mutex. Signed

[PATCH 1/3] livepatch: Add klp_object and klp_func iterators

2017-07-19 Thread Jason Baron
This patch is intended to effectively be a no-op until atomic replace is introduced. Signed-off-by: Jason Baron Cc: Josh Poimboeuf Cc: Jessica Yu Cc: Jiri Kosina Cc: Miroslav Benes Cc: Petr Mladek --- include/linux/livepatch.h | 106 -- kernel/live

[PATCH 3/3] livepatch: Add a sysctl livepatch_mode for atomic replace

2017-07-19 Thread Jason Baron
Introduce a sysctl knob such that by default livepatch is not in 'atomic replace' mode. A '0' in /proc/sys/kernel/livepatch_mode means the current default mode, while a '1' means do atomic replace. Signed-off-by: Jason Baron Cc: Josh Poimboeuf Cc: Jessica Yu Cc: J

[PATCH 0/3] livepatch: introduce atomic replace

2017-07-19 Thread Jason Baron
on't introduce a global sysctl that likely would also need to built-in, if there are patches in the initrd. Thanks, -Jason Jason Baron (3): livepatch: Add klp_object and klp_func iterators livepatch: add atomic replace livepatch: Add a sysctl livepatch_mode for atomic reve

[PATCH 2/3] livepatch: add atomic replace

2017-07-19 Thread Jason Baron
ow in a permanently disabled state. But if patch A is removed from the kernel with rmmod, it can be re-inserted (insmod), and act as an atomic replace on top of patch B. Signed-off-by: Jason Baron Cc: Josh Poimboeuf Cc: Jessica Yu Cc: Jiri Kosina Cc: Miroslav Benes Cc: Petr Mladek --- includ

Re: [PATCH 0/3] livepatch: introduce atomic replace

2017-07-21 Thread Jason Baron
On 07/21/2017 09:06 AM, Miroslav Benes wrote: On Wed, 19 Jul 2017, Jason Baron wrote: Hi, In testing livepatch, I found that when doing cumulative patches, if a patched function is completed reverted by a subsequent patch (back to its original state) livepatch does not revert the funtion

Re: [PATCH 1/3] jump_label: Warn on failed jump_label patch

2018-02-14 Thread Jason Baron
On 02/14/2018 12:01 PM, Steven Rostedt wrote: > On Wed, 14 Feb 2018 10:40:41 -0600 > Josh Poimboeuf wrote: > >> When the jump label code encounters an address which isn't recognized by >> kernel_text_address(), it just silently fails. >> >> This can be dangerous because jump labels are used in

<    1   2   3   4   5   >