[PATCH] unix: fix use-after-free with unix_dgram_poll()

2015-10-02 Thread Jason Baron
From: Jason Baron The unix_dgram_poll() routine calls sock_poll_wait() not only for the wait queue associated with the socket s that we've called poll() on, but it also calls sock_poll_wait() for a remote peer socket's wait queue, if it's connected. Thus, if we call poll()/selec

Re: [PATCH] unix: fix use-after-free with unix_dgram_poll()

2015-10-02 Thread Jason Baron
On 10/02/2015 03:30 PM, Rainer Weikusat wrote: > Jason Baron writes: >> From: Jason Baron >> >> The unix_dgram_poll() routine calls sock_poll_wait() not only for the wait >> queue associated with the socket s that we've called poll() on, but it also >> ca

[PATCH v2 0/3] af_unix: fix use-after-free

2015-10-02 Thread Jason Baron
Hi, These patches are against mainline, I can re-base to net-next, just let me know. They have been tested against: https://lkml.org/lkml/2015/9/13/195, which causes the use-after-free quite quickly and here: https://lkml.org/lkml/2015/10/2/693. Thanks, -Jason Jason Baron (3): unix: fix

[PATCH v2 2/3] af_unix: Convert gc_flags to flags

2015-10-02 Thread Jason Baron
Convert gc_flags to flags in preparation for the subsequent patch, which will make use of a flag bit for a non-gc purpose. Signed-off-by: Jason Baron --- include/net/af_unix.h | 2 +- net/unix/garbage.c| 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a

[PATCH v2 3/3] af_unix: optimize the unix_dgram_recvmsg()

2015-10-02 Thread Jason Baron
: Jason Baron --- include/net/af_unix.h | 1 + net/unix/af_unix.c| 72 ++- 2 files changed, 49 insertions(+), 24 deletions(-) diff --git a/include/net/af_unix.h b/include/net/af_unix.h index 6a4a345..cf21ffd 100644 --- a/include/net/af_unix.h +++ b

[PATCH v2 1/3] unix: fix use-after-free in unix_dgram_poll()

2015-10-02 Thread Jason Baron
epoll(). I've implemented this for sock-type, SOCK_RAW, SOCK_DGRAM, and SOCK_SEQPACKET but not for SOCK_STREAM, since SOCK_STREAM does not use unix_dgram_poll(). Signed-off-by: Jason Baron --- include/net/af_unix.h | 1 + net/unix/af_unix.c| 32 +++- 2 files c

Re: PATCH v6 6/6] livepatch: Add atomic replace

2018-01-25 Thread Jason Baron
On 01/25/2018 11:02 AM, Petr Mladek wrote: > From: Jason Baron > > Sometimes we would like to revert a particular fix. Currently, this > is not easy because we want to keep all other fixes active and we > could revert only the last applied patch. > > One solution would

[PATCH v5 1/3] livepatch: use lists to manage patches, objects and functions

2018-01-12 Thread Jason Baron
together via linked lists. This allows us to more easily allocate new objects and functions, while having the iterator be a simple linked list walk. This patch is intended to be a no-op until atomic replace is introduced by a subsequent patch. Signed-off-by: Jason Baron Cc: Josh Poimboeuf Cc: Jessica

[PATCH v5 3/3] livepatch: add atomic replace

2018-01-12 Thread Jason Baron
be re-enabled by removing them (rmmod) and then re-inserting them (insmod). Signed-off-by: Jason Baron Cc: Josh Poimboeuf Cc: Jessica Yu Cc: Jiri Kosina Cc: Miroslav Benes Cc: Petr Mladek --- include/linux/livepatch.h | 6 +- kernel/livepatch/core.c | 280 ++

[PATCH v5 2/3] livepatch: shuffle core.c function order

2018-01-12 Thread Jason Baron
In preparation for __klp_enable_patch() to call a number of 'static' functions, in a subsequent patch, move them earlier in core.c. This patch should be a nop from a functional pov. Signed-off-by: Jason Baron Cc: Josh Poimboeuf Cc: Jessica Yu Cc: Jiri Kosina Cc: Miroslav Benes

[PATCH v5 0/3] livepatch: introduce atomic replace

2018-01-12 Thread Jason Baron
to klp_patch, similar to the immediate field -a 'replace' patch now disables all previous patches -tried to shorten klp_init_patch_no_ops()... -Simplified logic klp_complete_transition (Petr Mladek) Jason Baron (3): livepatch: use lists to manage patches, objects and functions li

Re: [PATCH v5 0/3] livepatch: introduce atomic replace

2018-01-30 Thread Jason Baron
On 01/30/2018 10:06 AM, Evgenii Shatokhin wrote: > On 30.01.2018 17:03, Petr Mladek wrote: >> On Fri 2018-01-26 14:29:36, Evgenii Shatokhin wrote: >>> On 26.01.2018 13:23, Petr Mladek wrote: >>>> On Fri 2018-01-19 16:10:42, Jason Baron wrote: >>>>>

Re: [PATCH v5 0/3] livepatch: introduce atomic replace

2018-01-30 Thread Jason Baron
On 01/30/2018 02:24 PM, Joe Lawrence wrote: > On 01/30/2018 01:19 PM, Jason Baron wrote: >> [ ... snip ... ] >> >> Our main interest in 'atomic replace' is simply to make sure that >> cumulative patches work as expected in that they 'replace' any

Re: PROBLEM: epoll_wait does not obey edge triggering semantics for hierarchically constructed epoll sets

2018-01-18 Thread Jason Baron
ter' epoll fd will no longer show events and thus you have something resembling edge triggering for the 'outer' epoll fd in the current code. If that's not sufficient for what you are trying to do, you could try the patch I attached in the previous mail, and see if it match

Re: [PATCH] epoll: avoid calling ep_call_nested() from ep_poll_safewake()

2018-01-18 Thread Jason Baron
On 01/18/2018 06:00 AM, Hou Tao wrote: > Hi Jason, > > On 2017/10/18 22:03, Jason Baron wrote: >> >> >> On 10/17/2017 11:37 AM, Davidlohr Bueso wrote: >>> On Fri, 13 Oct 2017, Jason Baron wrote: >>> >>>> The ep_poll_safewake() function

Re: [PATCH v5 0/3] livepatch: introduce atomic replace

2018-01-19 Thread Jason Baron
On 01/19/2018 02:20 PM, Evgenii Shatokhin wrote: > On 12.01.2018 22:55, Jason Baron wrote: >> Hi, >>   While using livepatch, I found that when doing cumulative patches, >> if a patched >> function is completed reverted by a subsequent patch (back to its >> orig

Re: PROBLEM: epoll_wait does not obey edge triggering semantics for hierarchically constructed epoll sets

2018-01-17 Thread Jason Baron
On 01/12/2018 07:06 PM, Nick Murphy wrote: > [1.] One line summary of the problem: > epoll_wait does not obey edge triggering semantics for file > descriptors which are themselves epoll file descriptors (i.e., epoll > fd's added to an epoll set with the EPOLLET flag) > > [2.] Full description of

Re: [RFC PATCH 1/1] epoll: use rwlock in order to reduce ep_poll_callback() contention

2018-12-04 Thread Jason Baron
On 12/3/18 6:02 AM, Roman Penyaev wrote: > Hi all, > > The goal of this patch is to reduce contention of ep_poll_callback() which > can be called concurrently from different CPUs in case of high events > rates and many fds per epoll. Problem can be very well reproduced by > generating events (

Re: [RFC PATCH 1/1] epoll: use rwlock in order to reduce ep_poll_callback() contention

2018-12-05 Thread Jason Baron
On 12/5/18 6:16 AM, Roman Penyaev wrote: > On 2018-12-04 18:23, Jason Baron wrote: >> On 12/3/18 6:02 AM, Roman Penyaev wrote: > > [...] > >>> >>> ep_set_busy_poll_napi_id(epi); >>> >>> @@ -1156,8 +1187,8 @@ static int ep_poll_call

Re: [PATCH] mm/madvise: allow MADV_DONTNEED to free memory that is MLOCK_ONFAULT

2018-06-28 Thread Jason Baron
On 06/20/2018 07:00 AM, Michal Hocko wrote: > On Fri 15-06-18 15:36:07, Jason Baron wrote: >> >> >> On 06/13/2018 03:15 AM, Michal Hocko wrote: >>> On Wed 13-06-18 08:32:19, Vlastimil Babka wrote: > [...] >>>> BTW I didn't get why we should a

Re: [PATCH] mm/madvise: allow MADV_DONTNEED to free memory that is MLOCK_ONFAULT

2018-06-12 Thread Jason Baron
On 06/12/2018 03:46 AM, Michal Hocko wrote: > On Mon 11-06-18 12:23:58, Jason Baron wrote: >> On 06/11/2018 11:03 AM, Michal Hocko wrote: >>> So can we start discussing whether we want to allow MADV_DONTNEED on >>> mlocked areas and what downsides it might h

Re: [PATCH] mm/madvise: allow MADV_DONTNEED to free memory that is MLOCK_ONFAULT

2018-06-15 Thread Jason Baron
On 06/13/2018 05:13 AM, Michal Hocko wrote: > On Tue 12-06-18 10:11:33, Jason Baron wrote: > [...] >> Ok, I share the concern that there is a chance that userspace is relying >> on MADV_DONTNEED not free'ing locked memory. In that case, what if we >> introduce a MA

Re: [PATCH] mm/madvise: allow MADV_DONTNEED to free memory that is MLOCK_ONFAULT

2018-06-15 Thread Jason Baron
On 06/13/2018 03:15 AM, Michal Hocko wrote: > On Wed 13-06-18 08:32:19, Vlastimil Babka wrote: >> On 06/12/2018 04:11 PM, Jason Baron wrote: >>> >>> >>> On 06/12/2018 03:46 AM, Michal Hocko wrote: >>>> On Mon 11-06-18 12:23:58, Jason Baron wrote:

Re: [RFC PATCH 6/6] x86/jump_label,x86/alternatives: Batch jump label transformations

2018-10-08 Thread Jason Baron
islav Petkov > Cc: "H. Peter Anvin" > Cc: Greg Kroah-Hartman > Cc: Pavel Tatashin > Cc: Masami Hiramatsu > Cc: "Steven Rostedt (VMware)" > Cc: Zhou Chengming > Cc: Jiri Kosina > Cc: Josh Poimboeuf > Cc: "Peter Zijlstra (Intel)" > Cc

Re: [PATCH 1/2] jump_label: Allow jump labels to be used in assembly

2015-01-06 Thread Jason Baron
e also need to add -DCC_HAVE_ASM_GOTO to KBUILD_AFLAGS. > > Signed-off-by: Anton Blanchard (adding Steven) Acked-by: Jason Baron The jump label stuff often gets picked up by Steve, but I guess this could go through the powerpc tree as well... Thanks, -Jason -- To unsubscribe from this list: send the

[RFC PATCH 0/5] Remove global locks from epoll

2015-01-15 Thread Jason Baron
also like to potentially co-ordinate this series with the recent syscall enhancements from Fam Zheng: http://lwn.net/Articles/628828/ since these patches are somewhat invasive. Thanks, -Jason Jason Baron (5): epoll: Remove ep_call_nested() from ep_eventpoll_poll() epoll: Remove ep_call_nes

[RFC PATCH 1/5] epoll: remove ep_call_nested() from ep_eventpoll_poll()

2015-01-15 Thread Jason Baron
on of a global spin_lock() that was in use in ep_call_nested(). Signed-off-by: Jason Baron --- fs/eventpoll.c | 59 +++--- 1 file changed, 23 insertions(+), 36 deletions(-) diff --git a/fs/eventpoll.c b/fs/eventpoll.c index d77f944..e7b0c9e 1

[RFC PATCH 4/5] epoll: Allow topology checks to be parallelized

2015-01-15 Thread Jason Baron
x', we make use of per-instance data structures, such that these topology checks can safely be made in parallel. In addition, we make use of the ep_call_nested_nolock(), which avoids the nested_calls->lock. This is safe here, since we are already holding the 'epmutex' across all of t

[RFC PATCH 2/5] epoll: remove ep_call_nested() from ep_poll_safewake()

2015-01-15 Thread Jason Baron
think CONFIG_DEBUG_LOCK_ALLOC is generally used for production, so this should provide a decent speedup for the cases that we care about. Signed-off-by: Jason Baron --- fs/eventpoll.c | 47 ++- 1 file changed, 18 insertions(+), 29 deletions(-) diff --git a/fs/eventpoll.c

[RFC PATCH 3/5] epoll: add ep_call_nested_nolock()

2015-01-15 Thread Jason Baron
Add an ep_call_nested_nolock() variant which functions the same as the current ep_call_nested(), except it does not acquire any locks. This call wil be used by subsequent patches which have provide their own 'external' locking. Signed-off-by: Jason Baron --- fs/eventp

[RFC PATCH 5/5] epoll: introduce epoll connected components (remove the epmutex)

2015-01-15 Thread Jason Baron
almost 300% improvement. This is obviously a very contrived case, but shows the motivation for this patch. Signed-off-by: Jason Baron --- fs/eventpoll.c| 325 ++ include/linux/eventpoll.h | 52 +--- include/linux/fs.h| 3 + 3 fi

Re: [PATCH 3/3] powerpc: Include linux/jump_label.h to get HAVE_JUMP_LABEL define

2015-01-07 Thread Jason Baron
On 01/07/2015 05:35 AM, Anton Blanchard wrote: > Commit 1bc9e47aa8e4 ("powerpc/jump_label: Use HAVE_JUMP_LABEL") > converted uses of CONFIG_JUMP_LABEL to HAVE_JUMP_LABEL in > some assembly files. > > HAVE_JUMP_LABEL is defined in linux/jump_label.h, so we need to > include this or we always get the

Re: [RFC PATCH 5/5] epoll: introduce epoll connected components (remove the epmutex)

2015-01-16 Thread Jason Baron
On 01/15/2015 06:10 PM, Eric Wong wrote: > Jason Baron wrote: >> I've done a bit of performance evaluation on a dual socket, 10 core, hyper >> threading enabled box: Intel(R) Xeon(R) CPU E5-2650 v3 @ 2.30GHz. For the >> simple epfdN->epfdN->pipefdN topology case

Re: [RFC] Make dynamic debug infrastructure more flexible

2020-05-21 Thread Jason Baron
On 5/21/20 4:06 PM, Joe Perches wrote: > On Thu, 2020-05-21 at 09:08 -0700, Joe Perches wrote: >> On Thu, 2020-05-21 at 16:28 +0300, Stanimir Varbanov wrote: >>> Here we introduce few debug macros with levels (low, medium and >>> high) and debug macro for firmware. Enabling the particular level

Re: [PATCH] EDAC/ie31200: fallback if host bridge device is already initialized

2020-08-06 Thread Jason Baron
On 7/16/20 4:33 PM, Jason Baron wrote: > > > On 7/16/20 2:52 PM, Luck, Tony wrote: >> On Thu, Jul 16, 2020 at 02:25:11PM -0400, Jason Baron wrote: >>> The Intel uncore driver may claim some of the pci ids from ie31200 which >>> means that the ie31200 edac d

[PATCH 0/2] Use static_call for kvm_x86_ops

2021-01-11 Thread Jason Baron
Hi, Convert kvm_x86_ops to use static_call. Shows good performance gains for cpuid loop micro-benchmark (resulsts included in patch 2). Thanks, -Jason Jason Baron (2): KVM: x86: introduce definitions to support static calls for kvm_x86_ops KVM: x86: use static calls to reduce kvm_x86_ops

[PATCH 1/2] KVM: x86: introduce definitions to support static calls for kvm_x86_ops

2021-01-11 Thread Jason Baron
simlilar manner, but were omitted from this series to reduce scope and because I don't think they have as large of a performance impact. Cc: Paolo Bonzini Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Peter Zijlstra Cc: Andrea Arcangeli Signed-off-by: Jason Baron

[PATCH 2/2] KVM: x86: use static calls to reduce kvm_x86_ops overhead

2021-01-11 Thread Jason Baron
|default|mitigations=off --- vanilla|.671s |.486s static call|.573s(-15%)|.458s(-6%) Cc: Paolo Bonzini Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Peter Zijlstra Cc: Andrea Arcangeli Signed-off-by: Jason Baron --- arch/x86/include

Re: [PATCH 1/2] KVM: x86: introduce definitions to support static calls for kvm_x86_ops

2021-01-12 Thread Jason Baron
On 1/12/21 6:04 PM, Sean Christopherson wrote: On Mon, Jan 11, 2021, Jason Baron wrote: Use static calls to improve kvm_x86_ops performance. Introduce the definitions that will be used by a subsequent patch to actualize the savings. Note that all kvm_x86_ops are covered here except for

Re: [PATCH 1/2] KVM: x86: introduce definitions to support static calls for kvm_x86_ops

2021-01-13 Thread Jason Baron
On 1/13/21 7:53 AM, Paolo Bonzini wrote: > On 11/01/21 17:57, Jason Baron wrote: >> +#define DEFINE_KVM_OPS_STATIC_CALL(func)    \ >> +    DEFINE_STATIC_CALL_NULL(kvm_x86_##func,    \ >> +    *(((struct kvm_x86_ops *)0)->func)) >> +#defi

Re: [PATCH 1/2] KVM: x86: introduce definitions to support static calls for kvm_x86_ops

2021-01-13 Thread Jason Baron
On 1/13/21 11:16 AM, Jason Baron wrote: > > > On 1/13/21 7:53 AM, Paolo Bonzini wrote: >> On 11/01/21 17:57, Jason Baron wrote: >>> +#define DEFINE_KVM_OPS_STATIC_CALL(func)    \ >>> +    DEFINE_STATIC_CALL_NULL(kvm_x86_##func,    \ >>> +   

[PATCH v2 0/3] Use static_call for kvm_x86_ops

2021-01-14 Thread Jason Baron
) -add new patch (1/3), that adds a vmx/svm prefix to help facilitate svm_x86_ops and vmx_x86_ops future conversions. -added amd perf numbres to description of patch 3/3 Jason Baron (3): KVM: X86: append vmx/svm prefix to additional kvm_x86_ops functions KVM: x86: introduce definitions to support

[PATCH v2 2/3] KVM: x86: introduce definitions to support static calls for kvm_x86_ops

2021-01-14 Thread Jason Baron
k they have as large of a performance impact. Cc: Paolo Bonzini Cc: Sean Christopherson Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Peter Zijlstra Cc: Andrea Arcangeli Signed-off-by: Jason Baron --- arch/x86/include/asm/kvm-x86-ops.h | 127 + arch/x

[PATCH v2 3/3] KVM: x86: use static calls to reduce kvm_x86_ops overhead

2021-01-14 Thread Jason Baron
olo Bonzini Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Peter Zijlstra Cc: Andrea Arcangeli Cc: Sean Christopherson Signed-off-by: Jason Baron --- arch/x86/include/asm/kvm_host.h | 8 +- arch/x86/kvm/cpuid.c| 2 +- arch/x86/kvm/hyperv.c | 4 +

[PATCH v2 1/3] KVM: X86: append vmx/svm prefix to additional kvm_x86_ops functions

2021-01-14 Thread Jason Baron
(), update_cr8_intercept and enable_smi_window(). Cc: Paolo Bonzini Cc: Sean Christopherson Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Peter Zijlstra Cc: Andrea Arcangeli Signed-off-by: Jason Baron --- arch/x86/kvm/svm/svm.c| 20 ++-- arch/x86/kvm/vmx

Re: [PATCH 7/7] dyndbg: enable 'cache' of active pr_debug callsites

2020-11-25 Thread Jason Baron
On 11/25/20 2:36 PM, Jim Cromie wrote: > In ddebug_putsite(), dont zs_unmap the callsite if it is enabled for > printing. This means that the next time this pr_debug callsite is > executed, the _getsite() will succeed quickly without remapping the > zrec. > > Once the callsite is disabled via

Re: [PATCH v2 2/3] KVM: x86: introduce definitions to support static calls for kvm_x86_ops

2021-01-15 Thread Jason Baron
On 1/15/21 8:50 AM, Paolo Bonzini wrote: > On 15/01/21 10:26, Peter Zijlstra wrote: >>> +#define KVM_X86_OP(func) \ >>> +    DEFINE_STATIC_CALL_NULL(kvm_x86_##func, \ >>> +    *(((struct kvm_x86_ops *)0)->func)); >>> +#define KVM_X86_OP_NULL KV

Re: [PATCH v2 1/3] KVM: X86: append vmx/svm prefix to additional kvm_x86_ops functions

2021-01-15 Thread Jason Baron
On 1/15/21 4:22 AM, Peter Zijlstra wrote: > > On Thu, Jan 14, 2021 at 10:27:54PM -0500, Jason Baron wrote: > >> -static void update_exception_bitmap(struct kvm_vcpu *vcpu) >> +static void svm_update_exception_bitmap(struct kvm_vcpu *vcpu) > > Just to be a total pe

Re: [RFC][PATCH] jump_label/static_call: Add MAINTAINERS

2020-12-16 Thread Jason Baron
c/starfire* >> >> +STATIC BRANCH/CALL >> +M: Peter Zijlstra >> +M: Josh Poimboeuf >> +M: Jason Baron >> +R: Steven Rostedt >> +R: Ard Biesheuvel >> +S: Supported > > F:arch/*/include/asm/jump_label*.h > F:arch/*/i

Re: [PATCH 3/3] dynamic_debug: replace obselete simple_strtoul() with kstrtouint()

2014-01-24 Thread Jason Baron
Hi, I think we want some sort of commit message for this patch. But they all look good to me and they tested fine. Acked-by: Jason Baron Greg, Can you pick up this series? Thanks, -Jason On 01/23/2014 08:20 AM, Andrey Ryabinin wrote: > Signed-off-by: Andrey Ryabinin > ---

[PATCH 0/3] Add new ie31200_edac driver

2014-04-04 Thread Jason Baron
his edac driver submission. Thanks, -Jason Jason Baron (3): readq/writeq: Add explicit lo_hi_[read|write]_q and hi_lo_[read|write]_q x38_edac: make use of lo_hi_readq() ie31200_edac: Add driver drivers/edac/Kconfig| 7 + drivers/edac/Makefile

[PATCH 3/3] ie31200_edac: Add driver

2014-04-04 Thread Jason Baron
00v3-vol-2-datasheet.html I've tested this on bad memory hardware, and observed correlating bad reads and uncorrected memory errors as reported by the driver. Signed-off-by: Jason Baron --- drivers/edac/Kconfig| 7 + drivers/edac/Makefile | 1 + drivers/edac/ie312

[PATCH 2/3] x38_edac: make use of lo_hi_readq()

2014-04-04 Thread Jason Baron
Convert to the generic API. Signed-off-by: Jason Baron --- drivers/edac/x38_edac.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/edac/x38_edac.c b/drivers/edac/x38_edac.c index 4891b45..e644b52 100644 --- a/drivers/edac/x38_edac.c +++ b/drivers/edac

[PATCH 1/3] readq/writeq: Add explicit lo_hi_[read|write]_q and hi_lo_[read|write]_q

2014-04-04 Thread Jason Baron
ntent/www/us/en/processors/xeon/xeon-e3-1200-family-vol-2-datasheet.html p. 16) I can confirm this is true via several hard machine lockups. Thus, add explicit hi_lo_[readq|write]_q and lo_hi_[read|write]_q so that these uses are spelled out. Signed-off-by: Jason Baron --- include/asm-generic/io-64-no

Re: [PATCH v4 1/2] panic: setup panic_timeout early

2013-11-27 Thread Jason Baron
On 11/27/2013 01:17 AM, Felipe Contreras wrote: > Otherwise we might not reboot when the user needs it the most (early > on). > > Signed-off-by: Felipe Contreras > --- > kernel/panic.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/kernel/panic.c b/kernel/panic.c >

[PATCH] panic: Make panic_timeout configurable

2013-11-08 Thread Jason Baron
found two exceptions- one in mips and one in powerpc where settings didn't match these default values. In those two cases, I left the arch code so it continues to override. Perhaps, these cases can be converted to the default? Signed-off-by: Jason Baron --- arch/mips/netlogic/xlp/setup.c |

Re: [PATCH] panic: Make panic_timeout configurable

2013-11-12 Thread Jason Baron
On 11/11/2013 04:32 AM, Ingo Molnar wrote: > * Jason Baron wrote: > >> The panic_timeout can be set via the command line option 'panic=x', or via >> /proc/sys/kernel/panic, however that is not sufficient when the panic occurs >> before we are able t

Re: [PATCH v2] panic: Make panic_timeout configurable

2013-11-19 Thread Jason Baron
On 11/19/2013 04:02 AM, Ralf Baechle wrote: > On Mon, Nov 18, 2013 at 09:04:36PM +0000, Jason Baron wrote: > >> The panic_timeout value can be set via the command line option 'panic=x', or >> via >> /proc/sys/kernel/panic, however that is not sufficient when

Re: disappearing listen()ed SO_REUSEPORT sockets across fork() when using epoll

2013-11-25 Thread Jason Baron
On 11/22/2013 12:53 PM, Shawn Landden wrote: > Hello, when running the attached program on 3.12 child processes > are missing a socket fd opened, set with SO_REUSEPORT, listen()ed to, > and added to epoll_ctl(). > > This is the output I get when pointing "wget http://localhost:/"; > at the att

[PATCH 0/3 v3] build in panic_timeout value

2013-11-25 Thread Jason Baron
code -add set_arch_panic_timeout(), in case .config specifies a non-default timeout Jason Baron (2): panic: Make panic_timeout configurable powerpc: cleanup panic_timeout Ralf Baechle (1): mips: remove panic_timeout settings. arch/mips/ar7/setup.c | 1 - arch/mips/emma/ma

[PATCH 1/3 v3] panic: Make panic_timeout configurable

2013-11-25 Thread Jason Baron
ut. Signed-off-by: Jason Baron --- include/linux/kernel.h | 9 + kernel/panic.c | 2 +- lib/Kconfig.debug | 9 + 3 files changed, 19 insertions(+), 1 deletion(-) diff --git a/include/linux/kernel.h b/include/linux/kernel.h index d4e98d1..2ac0277 100644 --- a/include

[PATCH 3/3 v3] powerpc: cleanup panic_timeout

2013-11-25 Thread Jason Baron
ny case, if the user changes the default setting of 180 seconds, we honor that user setting. Signed-off-by: Jason Baron --- arch/powerpc/Kconfig | 4 arch/powerpc/include/asm/setup.h | 1 + arch/powerpc/kernel/setup_32.c | 3 --- arch/powerpc/kernel/setup_6

[PATCH 2/3 v3] mips: remove panic_timeout settings

2013-11-25 Thread Jason Baron
From: Ralf Baechle Now that we have a CONFIG_PANIC_TIMEOUT=x setting, remove the mips settings. The default is 0, which means don't reboot on panic. Signed-off-by: Ralf Baechle Acked-by: Shinya Kuribayashi Signed-off-by: Jason Baron --- arch/mips/ar7/setup.c | 1 - arch/mips

[PATCH] epoll: remove the on_list check for 'struct epitem'

2013-10-30 Thread Jason Baron
happen since EPOLL_CTL_DEL can't race with eventpoll_release_file() or ep_free() - it has to do an fget() to proceed. Further, eventpoll_release_file() can not race with ep_free(), since they both acquire the 'epmutex'. Signed-off-by: Jason Baron --- fs/eventpoll.c | 13 ++---

Re: linux-next: build failure after merge of the akpm-current tree

2013-10-30 Thread Jason Baron
On 10/30/2013 03:00 AM, Stephen Rothwell wrote: > Hi Andrew, > > After merging the akpm-current tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: > > In file included from include/linux/init.h:4:0, > from fs/eventpoll.c:14: > fs/eventpoll.c: In function

Re: [PATCH 3/3] ie31200_edac: Add driver

2014-04-08 Thread Jason Baron
Hi, On 04/08/2014 05:09 AM, Borislav Petkov wrote: > On Fri, Apr 04, 2014 at 09:14:04PM +0000, Jason Baron wrote: >> Add 'ie31200_edac' driver for the E3-1200 series of Intel processors. Driver >> is based on the following E3-1200 specs: >> >> http://www.i

Re: [PATCH 3/3] ie31200_edac: Add driver

2014-04-08 Thread Jason Baron
On 04/08/2014 06:34 PM, Luck, Tony wrote: >>> Btw, this driver is polling, AFAICT. Doesn't e3-12xx support the CMCI >>> interrupt which you can feed into this driver directly and thus not need >>> the polling at all? >> On the system with the ce and ue events that I'm testing on, I don't see >> 'MC

Re: [PATCH 3/3] ie31200_edac: Add driver

2014-04-09 Thread Jason Baron
On 04/09/2014 07:35 AM, Borislav Petkov wrote: > On Fri, Apr 04, 2014 at 09:14:04PM +0000, Jason Baron wrote: >> Add 'ie31200_edac' driver for the E3-1200 series of Intel processors. Driver >> is based on the following E3-1200 specs: >> >> http://www.intel.

Re: [PATCH 3/3] ie31200_edac: Add driver

2014-04-09 Thread Jason Baron
On 04/09/2014 01:36 PM, Borislav Petkov wrote: > On Wed, Apr 09, 2014 at 05:17:53PM +, Luck, Tony wrote: >> The E3-12xx processors connect out to a different (desktop) chipset >> from the E5 (server parts). Perhaps that means the memory controller >> are different too??? > > You gotta love how

Re: [PATCH 3/3] ie31200_edac: Add driver

2014-04-09 Thread Jason Baron
On 04/09/2014 03:14 PM, Borislav Petkov wrote: > On Wed, Apr 09, 2014 at 02:57:19PM -0400, Jason Baron wrote: >> Right, so maybe the fact that its a desktop chipset means that it >> behaves differently and doesn't raise MCEs on memory errors. We have a >> bunch of these

Re: [PATCH 3/3] ie31200_edac: Add driver

2014-04-09 Thread Jason Baron
On 04/09/2014 05:33 PM, Luck, Tony wrote: >> Unfortunately, the box reporting the ue errors just went into transit (so >> that I can better examine this issue), so I will probably not be able to >> run this experiment on that specific box until next week. > > Do you have any other logs from this m

Re: [PATCH 3/3] ie31200_edac: Add driver

2014-04-09 Thread Jason Baron
On 04/09/2014 06:44 PM, Luck, Tony wrote: >> So when the driver sees uncorrected errors, I'm also seeing them in my >> memory scanning program - so they correspond nicely. I didn't see anything >> logged in /var/log/mcelog, but I will update to the latest when possible. > I wonder if there are some

Re: [PATCH] intel_idle: use static_key to optimize idle enter/exit paths

2014-07-28 Thread Jason Baron
On 07/28/2014 04:38 PM, Len Brown wrote: > On Fri, Jul 11, 2014 at 1:54 PM, Jason Baron wrote: >> If 'arat' is set in the cpuflags, we can avoid the checks for >> entering/exiting >> the tick broadcast code entirely. It would seem that this is a hot enoug

Re: [PATCH] Remove soon to be dead email address

2014-07-11 Thread Jason Baron
e the interweb some bounces. >> >>> --- a/include/linux/jump_label.h >>> +++ b/include/linux/jump_label.h >>> @@ -4,8 +4,8 @@ >>> /* >>> * Jump label support >>> * >>> - * Copyright (C) 2009-2012 Jason Baron >>&g

[PATCH] intel_idle: use static_key to optimize idle enter/exit paths

2014-07-11 Thread Jason Baron
If 'arat' is set in the cpuflags, we can avoid the checks for entering/exiting the tick broadcast code entirely. It would seem that this is a hot enough code path to make this worthwhile. I ran a few hackbench runs, and consistenly see reduced branches and cycles. Signed-off-by: J

Re: [PATCH 0/3] static keys: fix test/set races

2014-06-30 Thread Jason Baron
indiana.edu/hypermail/linux/kernel/1304.2/01655.html >> >> Thus, introduce a new API that does the check and set under the >> 'jump_label_mutex'. This should also allow to simplify call sites a bit. >> >> Users of static keys should use either the inc/dec or the set_true/set_f

[PATCH 2/2] sched: fix static_key race with sched_feat

2014-07-02 Thread Jason Baron
ate. Take the i_mutex around these calls to resolve the race. Reported-by: Andi Kleen Signed-off-by: Jason Baron --- kernel/sched/core.c | 5 + 1 file changed, 5 insertions(+) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 3bdf01b..249c865 100644 --- a/kernel/sched/core.c ++

[PATCH 0/2] sched: static_key sched_feat race + cleanup

2014-07-02 Thread Jason Baron
Jason Baron (2): sched: remove extra static_key function indirection sched: fix static_key race with sched_feat kernel/sched/core.c | 5 + kernel/sched/sched.h | 12 +--- 2 files changed, 6 insertions(+), 11 deletions(-) -- 1.8.2.rc2 -- To unsubscribe from this list: send the

[PATCH 1/2] sched: remove extra static_key function indirection

2014-07-02 Thread Jason Baron
I think its a bit simpler without having to follow an extra layer of static inline fuctions. No functional change just cosmetic. Signed-off-by: Jason Baron --- kernel/sched/sched.h | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/kernel/sched/sched.h b/kernel

[PATCH v2 2/3] x38_edac: make use of lo_hi_readq()

2014-06-26 Thread Jason Baron
Convert to the generic API. Signed-off-by: Jason Baron --- drivers/edac/x38_edac.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/edac/x38_edac.c b/drivers/edac/x38_edac.c index 4891b45..e644b52 100644 --- a/drivers/edac/x38_edac.c +++ b/drivers/edac

[PATCH v2 1/3] readq/writeq: Add explicit lo_hi_[read|write]_q and hi_lo_[read|write]_q

2014-06-26 Thread Jason Baron
ntent/www/us/en/processors/xeon/xeon-e3-1200-family-vol-2-datasheet.html p. 16) I can confirm this is true via several hard machine lockups. Thus, add explicit hi_lo_[readq|write]_q and lo_hi_[read|write]_q so that these uses are spelled out. Signed-off-by: Jason Baron --- include/asm-generic/io-64-no

[PATCH v2 3/3] ie31200_edac: Introduce the driver

2014-06-26 Thread Jason Baron
GHz : 8086:0108 (sandy bridge) Signed-off-by: Jason Baron --- drivers/edac/Kconfig| 7 + drivers/edac/Makefile | 1 + drivers/edac/ie31200_edac.c | 542 3 files changed, 550 insertions(+) create mode 100644 drivers/edac/ie31200_edac.

[PATCH v2 0/3] Introduce ie31200_edac driver

2014-06-26 Thread Jason Baron
tested: CPU E3-1270 v3 @ 3.50GHz : 8086:0c08 (haswell) CPU E3-1270 V2 @ 3.50GHz : 8086:0158 (ivy bridge) CPU E31270 @ 3.40GHz : 8086:0108 (sandy bridge) Posted before as: https://lkml.org/lkml/2014/4/4/462 Patch against 3.16.0-rc2 Thanks, -Jason Changes since v1: - Cleanups and formatti

Re: [PATCH 3/3] ie31200_edac: Add driver

2014-06-11 Thread Jason Baron
On 04/09/2014 05:33 PM, Luck, Tony wrote: >> Unfortunately, the box reporting the ue errors just went into transit (so >> that I can better examine this issue), so I will probably not be able to >> run this experiment on that specific box until next week. > > Do you have any other logs from this m

Re: eventpoll __list_del_entry corruption

2014-06-03 Thread Jason Baron
On 05/15/2014 02:11 PM, Peter Zijlstra wrote: > On Mon, May 12, 2014 at 11:42:33AM -0400, Sasha Levin wrote: >> Hi all, >> >> While fuzzing with trinity inside a KVM tools guest running the latest -next >> kernel I've stumbled on the following spew. Maybe related to the very recent >> change in fre

Re: [PATCH] epoll: fix use-after-free in eventpoll_release_file

2014-06-17 Thread Jason Baron
er valid. So, I suspect that makes this more difficult to hit, but obviously it happens. Thanks for finding/fixing this! Acked-by: Jason Baron On 06/16/2014 10:58 PM, Konstantin Khlebnikov wrote: > This fixes use-after-free of epi->fllink.next inside list loop macro. > This loop actually r

Re: [PATCH 0/3] static keys: fix test/set races

2014-06-23 Thread Jason Baron
On 06/23/2014 10:28 PM, Steven Rostedt wrote: > Cleaning out my INBOX I found this patch series. It seems to have been > forgotten about. It ended up with Ingo and Peter agreeing with the way > things should be done and I thought Jason was going to send an update. > But that seems to never have hap

Re: [PATCH 1/2 v2] epoll: optimize EPOLL_CTL_DEL using rcu

2013-10-24 Thread Jason Baron
Thanks for looking at this. Comments below. -Jason On 10/24/2013 04:52 AM, Paul E. McKenney wrote: > On Tue, Oct 01, 2013 at 05:08:10PM +0000, Jason Baron wrote: >> Optimize EPOLL_CTL_DEL such that it does not require the 'epmutex' by >> converting the file->f_ep_lin

Re: [PATCH 2/2 v2] epoll: Do not take global 'epmutex' for simple topologies

2013-10-24 Thread Jason Baron
On 10/24/2013 06:09 AM, Paul E. McKenney wrote: > On Tue, Oct 01, 2013 at 05:08:14PM +0000, Jason Baron wrote: >> When calling EPOLL_CTL_ADD for an epoll file descriptor that is attached >> directly to a wakeup source, we do not need to take the global 'epmutex',

Re: [PATCH v6 7/7] jump_label: use defined macros instead of hard-coding for better readability

2013-12-18 Thread Jason Baron
\ >> { .enabled = ATOMIC_INIT(0), \ >>.entries = (void *)JUMP_LABEL_TYPE_FALSE_BRANCH }) >> >> >> Other than that. >> >> Acked-by: Steven Rostedt > Thanks Steve. > Will make this change. Works for me too, fe

[PATCH v2] panic: Make panic_timeout configurable

2013-11-18 Thread Jason Baron
at compile-time. Signed-off-by: Jason Baron --- -Restrict arch defaults to arch/ code -add set_arch_panic_timeout(), in case .config specifies a non-default timeout arch/mips/Kconfig | 4 arch/mips/ar7/setup.c | 2 +- arch/mips/emma/markeins/setup.c

[PATCH] epoll: Do not take the nested ep->mtx on EPOLL_CTL_DEL

2013-12-26 Thread Jason Baron
er, the original posting of this patch, which was tested for the intended performance gains, did not perform this additional locking. Signed-off-by: Jason Baron --- fs/eventpoll.c | 4 1 file changed, 4 deletions(-) diff --git a/fs/eventpoll.c b/fs/eventpoll.c index 8b5e258..af9

Re: [PATCH 1/1] jump_label: tidy jump_label_ratelimit.h

2014-08-22 Thread Jason Baron
On 08/20/2014 10:58 PM, Zhouyi Zhou wrote: > I have submitted two patches according to you suggestions: > https://lkml.org/lkml/2014/8/20/885 > https://lkml.org/lkml/2014/8/20/883 > Hope I have made them right > Thanks - they look good to me. -Jason -- To unsubscribe from this list: send the li

Re: [PATCH 1/1] jump_label: tidy jump_label_ratelimit.h

2014-08-20 Thread Jason Baron
Yes, that looks good. While at it I grep'd the tree for 'CONFIG_JUMP_LABEL', and found some uses in the netfilter code which should probably be 'HAVE_JUMP_LABEL' as well. Thanks, -Jason On 08/20/2014 05:29 AM, Zhouyi Zhou wrote: > jump_label_ratelimit.h is split from jump_label.h to enable the

Re: [PATCH 4/4] lib: Use seq_open_private() instead of seq_open()

2014-08-29 Thread Jason Baron
On 08/29/2014 12:06 PM, Rob Jones wrote: > Using seq_open_private() removes boilerplate code from ddebug_proc_open() > Looks good. Acked-by: Jason Baron -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger

Re: [RFC PATCH] Flipped jump labels

2014-08-10 Thread Jason Baron
On 08/10/2014 12:07 PM, Borislav Petkov wrote: > On Sun, Aug 10, 2014 at 05:45:15PM +0200, Ingo Molnar wrote: >> Indeed - but could we use that interface to cleanly expose the >> arch_static_branch_active() code you've written, or do we need new >> variants? > We could probably. > > The thing is, i

[PATCH] powercap/rapl: add support for cpu model 0x3f

2014-08-13 Thread Jason Baron
ot sure if the h/w simply doesn't support that, or if the driver could be improved here. In any case, adding the 0x3f makes the driver useful for me. Tested aginst cpu: Intel(R) Xeon(R) CPU E5-2650 v3 @ 2.30GHz Signed-off-by: Jason Baron --- drivers/powercap/intel_rapl.c | 1 + 1 file chang

Re: [PATCH] powercap/rapl: add support for cpu model 0x3f

2014-08-14 Thread Jason Baron
On 08/13/2014 06:50 PM, Jacob Pan wrote: > On Wed, 13 Aug 2014 20:33:26 + (GMT) > Jason Baron wrote: > >> I've confirmed that monitoring the package power usage as well >> as setting power limits appear to be working as expected. However, >> I do see

Re: [PATCH V5] kernel, add panic_on_warn

2014-10-28 Thread Jason Baron
On 10/28/2014 08:31 AM, Prarit Bhargava wrote: > There have been several times where I have had to rebuild a kernel to > cause a panic when hitting a WARN() in the code in order to get a crash > dump from a system. Sometimes this is easy to do, other times (such as > in the case of a remote admin)

Re: arm: JUMP_LABEL and DEBUG_SET_MODULE_RONX should be mutually exclusive?

2014-10-15 Thread Jason Baron
On 10/15/2014 11:34 AM, Kees Cook wrote: > On Wed, Oct 15, 2014 at 5:21 AM, Paolo Pisati wrote: >> Hi, >> >> i keep hitting this with BRIDGE=m, JUMP_LABEL=y and DEBUG_SET_MODULE_RONX=y: > I think my RO/NX patch series solves this. I sent a pull request, but > I haven't seen any movement on it. :(

<    1   2   3   4   5   >