happy.
Tested-by: Jan Stancek
Tested-by: Jan Stodola
CC: Herbert Xu
CC: Neil Horman
CC: "David S. Miller"
CC: Matt Mackall
CC: "Theodore Ts'o"
CC: linux-cry...@vger.kernel.org
CC: sta...@vger.kernel.org
Signed-off-by: Jarod Wilson
---
drivers/char/random.c | 30
On Tue, Mar 19, 2013 at 12:18:09PM -0400, Jarod Wilson wrote:
> Commit ec8f02da9e added priming of last_data per fips requirements.
> Unfortuantely, it did so in a way that can lead to multiple threads all
> incrementing nbytes, but only one actually doing anything with the extra
>
Stefan Richter wrote:
Add the same workaround as found in fw-sbp2 for feature parity and
compatibility of the workarounds module parameter.
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
Same deal as 2/9.
Signed-off-by: Jarod Wilson <[EMAIL PROTECTED]>
--
Jarod Wilson
[EMA
at may well benefit from this (once added to the workarounds
table, of course). Interesting that this is an encore appearance for a
DViCO Momobay device...
Signed-off-by: Jarod Wilson <[EMAIL PROTECTED]>
--
Jarod Wilson
[EMAIL PROTECTED]
--
To unsubscribe from this list: send the line &
is one, makes it much easier to figure out what's what
without having to poke around in config roms.
Signed-off-by: Jarod Wilson <[EMAIL PROTECTED]>
--
Jarod Wilson
[EMAIL PROTECTED]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a
Stefan Richter wrote:
Jarod Wilson wrote:
Stefan Richter wrote:
+static void sbp2_conditionally_block(struct sbp2_logical_unit *lu)
+{
+struct fw_card *card =
fw_device(lu->tgt->unit->device.parent)->card;
+
+if (!atomic_read(&lu->tgt->dont_block) &&
+
hit that or not. In
either case, not calling it when we know we don't need to makes sense.
Signed-off-by: Jarod Wilson <[EMAIL PROTECTED]>
--
Jarod Wilson
[EMAIL PROTECTED]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a messag
checks aren't being run against stale and possibly known data.
CC: Herbert Xu
CC: "David S. Miller"
CC: Neil Horman
CC: Matt Mackall
CC: linux-cry...@vger.kernel.org
Signed-off-by: Jarod Wilson
---
drivers/char/random.c | 11 +++
1 files changed, 11 insertions(+), 0 del
On Tue, Nov 06, 2012 at 07:05:23AM -0500, Neil Horman wrote:
> On Mon, Nov 05, 2012 at 04:00:10PM -0500, Jarod Wilson wrote:
> > The value stored in last_data must be primed for FIPS 140-2 purposes. Upon
> > first use, either on system startup or after an RNDCLEARPOOL ioctl, we
>
CC: linux-cry...@vger.kernel.org
Signed-off-by: Jarod Wilson
---
drivers/char/random.c | 15 +++
1 files changed, 15 insertions(+), 0 deletions(-)
diff --git a/drivers/char/random.c b/drivers/char/random.c
index b86eae9..6bdd57f 100644
--- a/drivers/char/random.c
+++ b/drivers/char/ran
extra lock/unlock calls.
CC: Herbert Xu
CC: "David S. Miller"
CC: Neil Horman
CC: Matt Mackall
CC: linux-cry...@vger.kernel.org
Signed-off-by: Jarod Wilson
---
drivers/char/random.c | 17 +
1 files changed, 17 insertions(+), 0 deletions(-)
diff --git a/drivers/char/ran
e're subsequently just reconnecting to
that failed setup... So the reconnect code may be doing the right thing, and
the real problem I'm looking at is us screwing up the setup of the device in
the first place, for some reason...
--
Jarod Wilson
[EMAIL PROTECTED]
--
To unsubscribe from th
od, does this work like I assume and fixes your setup of two OXFW911
> based disks?
Well, it results in the dmesg spew saying "sd 6:0:0:0: [sdc] Result:
hostbyte=DID_NO_CONNECT driverbyte=DRIVER_OK,SUGGEST_OK" -- i.e.,
DID_NO_CONNECT instead of DID_BUS_BUSY, but other than that,
#x27;, followed by a new login and
SCSI probe, both of which are successful this time, disk is available for use
and all that good stuff.
Signed-off-by: Jarod Wilson <[EMAIL PROTECTED]>
--
Jarod Wilson
[EMAIL PROTECTED]
--
To unsubscribe from this list: send the line "unsubscribe linux-
isk being unplugged
briefly, then plugged back in, is it? (I recall that being discussed,
but I think it was as a 'would be nice to do in the future' thing).
--
Jarod Wilson
[EMAIL PROTECTED]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
ances.
Signed-off-by: Jarod Wilson <[EMAIL PROTECTED]>
--
Jarod Wilson
[EMAIL PROTECTED]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-i
Stefan Richter wrote:
for easier readable logs if more than one SBP-2 device is present.
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
Agree this makes for easier to follow logs, esp. with lots of devices
(not just spb2).
Signed-off-by: Jarod Wilson <[EMAIL PROTECTED]>
--
upstream work to nearly nil. I hope to get
back into it once things settle down, which should be happening relativley
soon...
--
Jarod Wilson
ja...@redhat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.k
ed-off-by: Stefan Richter <[EMAIL PROTECTED]>
Verified in concert with parts 2 and 3 as well as with 2, 3 and 4, to fix
'giving up on config rom' issues on multiple system and drive combinations
that were previously affected.
Signed-off-by: Jarod Wilson <[EMAIL PROTECTED]>
t;[EMAIL PROTECTED]>
Verified in concert with parts 1 and 3 as well as with 1, 3 and 4, to fix
'giving up on config rom' issues on multiple system and drive combinations
that were previously affected.
Signed-off-by: Jarod Wilson <[EMAIL PROTECTED]>
--
Jarod Wilson
[EMAIL PROTECT
le system and drive combinations
that were previously affected.
Signed-off-by: Jarod Wilson <[EMAIL PROTECTED]>
--
Jarod Wilson
[EMAIL PROTECTED]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo in
gt; ...
> will take care that generation is read before node_id, won't it?
>
> Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
Based on a quick read through the code path, coupled with empirical evidence,
yes, it appears safe to remove the barrier in read_
Jarod Wilson wrote:
> Stefan Richter wrote:
>> read_rom() obtained a fresh new fw_device.generation for each read
>> transaction. Hence it was able to continue reading in the middle of the
>> ROM even if a bus reset happened. However the device may have modified
>> th
beating on locally, and I've yet to hit
another config rom read failure with it.
Signed-off-by: Jarod Wilson <[EMAIL PROTECTED]>
--
Jarod Wilson
[EMAIL PROTECTED]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PRO
hit this one a few times myself. Even if
we do end up still having the workqueue sleep time, nuking all the
unnecessary spew and saving a few cycles is definitely worth it.
Signed-off-by: Jarod Wilson <[EMAIL PROTECTED]>
--
Jarod Wilson
[EMAIL PROTECTED]
--
To unsubscribe from this list:
nough, and I'll give these a spin shortly and see if I
can reproduce the situation I was hitting with my raid array...
--
Jarod Wilson
[EMAIL PROTECTED]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More ma
On Monday 28 January 2008 01:54:14 pm Stefan Richter wrote:
> Jarod Wilson wrote:
> > We may have another issue there though, as when this happened to me, the
> > md layer apparently never noticed (after ~6 hours) that one of the array
> > members had disappeared -- not sure
blem of devices racing the grab the same fw* device node, and it seems
obvious that should indeed be the case from the code changes.
Signed-off-by: Jarod Wilson <[EMAIL PROTECTED]>
--
Jarod Wilson
[EMAIL PROTECTED]
--
To unsubscribe from this list: send the line "unsubscribe linux-kern
; it would succeed but be unable to do any IO on it of course. With this
> patch, process B's open() will fail immediately with -ENODEV.
>
> Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
Makes perfect sense to me, no problems with it in cursory testing.
Signed-off-by: J
rther
and we'd already have to wrap the conditionals.
CC: Jeff Kirsher
CC: intel-wired-...@lists.osuosl.org
CC: net...@vger.kernel.org
Signed-off-by: Jarod Wilson
---
drivers/net/ethernet/intel/e1000e/netdev.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/d
On Tue, Jul 19, 2016 at 08:49:03PM +, Rustad, Mark D wrote:
> Jarod Wilson wrote:
>
> >I've got reports that the Intel I-218V NIC in Intel NUC5i5RYH systems used
> >as a PTP slave experiences random ~10 hour clock jumps, which are resolved
> >if the same workarou
...@vger.kernel.org
Signed-off-by: Jarod Wilson
---
drivers/net/ethernet/intel/e1000e/netdev.c | 71 ++
1 file changed, 44 insertions(+), 27 deletions(-)
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c
b/drivers/net/ethernet/intel/e1000e/netdev.c
index 41f32c0
rg
CC: net...@vger.kernel.org
Signed-off-by: Jarod Wilson
---
drivers/net/ethernet/intel/e1000e/netdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c
b/drivers/net/ethernet/intel/e1000e/netdev.c
index 955b294..206bd6a 100644
--- a/drivers/net/eth
This little series factors out the systim sanitization code first, then
adds e1000_pch_lpt as a new case in the switch that calls the sanitize
function, fixing PTP clock issues I've had reported against an Intel
I-218V NIC in an Intel NUC5ik5RYH system.
Jarod Wilson (2):
e1000e: facto
even set it to 0) and
> see what happens?
Unfortunately, I don't have direct access to the affected hardware myself,
so I'd have to prep a test build, hand it off to someone and play relay. I
could do that, but it'd have some lag and possible multiple round-trips...
Anyone inside Intel have hardware handy to test on? :p
--
Jarod Wilson
ja...@redhat.com
On Wed, Sep 14, 2016 at 05:59:14AM +0800, kbuild test robot wrote:
> Hi Jarod,
>
> [auto build test ERROR on net-next/master]
>
> url:
> https://github.com/0day-ci/linux/commits/Jarod-Wilson/net-centralize-net_device-min-max-MTU-checking/20160913-042130
> config
al timeslice in
bond_ab_arp_probe(), has shown to produce 100% reliability in testing with
this hardware combination.
[jarod: manufacturing of changelog, addition of modparam gating]
CC: Jay Vosburgh
CC: Andy Gospodarek
CC: Veaceslav Falico
CC: net...@vger.kernel.org
Signed-off-by: Uwe Koziolek
Signed-off-b
Jarod Wilson wrote:
From: Uwe Koziolek
With some very finicky switch hardware, active backup bonding can get into
a situation where we play ping-pong between interfaces, trying to get one
to come up as the active slave. There seems to be an issue with the
switch's arp replies either takin
Alexander Duyck wrote:
On 09/21/2015 09:14 PM, Jarod Wilson wrote:
Alexander Duyck wrote:
On 09/21/2015 10:11 AM, Jarod Wilson wrote:
Some pci changes upcoming in 4.3 seem to cause additional disconnects,
which can happen at unfortuitous times for igb, leading to issues
such as
this, where
intel-wired-...@lists.osuosl.org
CC: net...@vger.kernel.org
Signed-off-by: Jarod Wilson
---
drivers/net/ethernet/intel/igb/e1000_regs.h | 7 +++
drivers/net/ethernet/intel/igb/igb_main.c | 14 +++---
2 files changed, 10 insertions(+), 11 deletions(-)
diff --git a/drivers/net/ethern
DDRCONF(NETDEV_UP): enp21s0: link is not ready
The device is still not functional at this point, but I believe that's a
pci hotplug issue, not an igb issue.
CC: Mark Rustad
CC: Jeff Kirsher
CC: Alexander Duyck
CC: intel-wired-...@lists.osuosl.org
CC: net...@vger.kernel.org
Signed-off-by: Jarod
Nikolay Aleksandrov wrote:
On 10/06/2015 09:53 PM, Jarod Wilson wrote:
From: Uwe Koziolek
With some very finicky switch hardware, active backup bonding can get into
a situation where we play ping-pong between interfaces, trying to get one
to come up as the active slave. There seems to be an
On 2015-08-17 4:51 PM, Uwe Koziolek wrote:
On Mon, Aug 17, 2015 at 09:14PM +0200, Jay Vosburgh wrote:
Uwe Koziolek wrote:
On2015-08-17 07:12 PM,Jarod Wilson wrote:
...
Uwe, can you perhaps further enlighten us as to what num_grat_arp
settings were tried that didn't help? I'm st
Jay Vosburgh wrote:
Jarod Wilson wrote:
Jarod Wilson wrote:
...
As Andy already stated I'm not a fan of such workarounds either but it's
necessary sometimes so if this is going to be actually considered then a
few things need to be fixed. Please make this a proper bonding option
wh
Duyck
CC: intel-wired-...@lists.osuosl.org
CC: net...@vger.kernel.org
Acked-by: Alexander Duyck
Signed-off-by: Jarod Wilson
---
Note: this patch is rebased on Jeff's next-queue/dev-queue branch, which
already had an earlier revision of this applied, so I've essentially
reverted a2675ab
Vosburgh
CC: Veaceslav Falico
CC: Andy Gospodarek
CC: Jiri Pirko
CC: Nikolay Aleksandrov
CC: Michal Kubecek
CC: net...@vger.kernel.org
Signed-off-by: Jarod Wilson
---
net/core/dev.c | 57 +
1 file changed, 57 insertions(+)
diff --git
This gcm variant is popular for ipsec use, and there are folks who would
like to use it while in fips mode. Mark it with fips_allowed=1 to
facilitate that.
CC: LKML
CC: Stephan Mueller
Signed-off-by: Jarod Wilson
---
crypto/testmgr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/crypto
at would be
calling the _nolock variant of whichever route, as it handles bd_mutex
acquisition within __blkdev_get().
As an aside, there's a piece of that function that could be worth
duplicating over into loop.c as well:
if (bdev->bd_invalidated) {
if (!ret)
"scan partitions error, retry %d rc %d",
Note: patch 6/6 in the series makes this whole while() loops pointless,
since the possibility of the -EBUSY return goes away.
--
Jarod Wilson
ja...@redhat.com
--
To unsubscribe from this list: send the line "unsubscribe lin
On Mon, Apr 06, 2015 at 09:42:27AM -0400, Jarod Wilson wrote:
> On Mon, Apr 06, 2015 at 12:40:12AM +0800, Ming Lei wrote:
> > On Mon, Apr 6, 2015 at 12:12 AM, Christoph Hellwig
> > wrote:
> > >> +/*
> > >> + * This is exported as API for block driver,
On Mon, Apr 06, 2015 at 09:46:55AM -0400, Jarod Wilson wrote:
> On Sun, Apr 05, 2015 at 03:24:47PM +0800, Ming Lei wrote:
> > Also remove the obsolete comment.
> >
> > Signed-off-by: Ming Lei
> > ---
> > drivers/s390/block/dasd_genhd.c |9 +++--
> &
raith
CC: Kent Overstreet
CC: Mikulas Patocka
Signed-off-by: Jarod Wilson
---
drivers/block/loop.c | 48
1 file changed, 44 insertions(+), 4 deletions(-)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index d1f168b..b30e32c 100644
--
nt issue for a number of folks. I'll take my patch, David's patch,
Ming's patch and your comments all back to the drawing board for a bit and
see what I can come up with...
Thanks much,
--
Jarod Wilson
ja...@redhat.com
--
To unsubscribe from this list: send the line "unsubscr
s ago,
based on Christoph's feedback. I've tested this out quite succesfully
in the scenario that prompted my first patch as well.
[1], https://lkml.org/lkml/2015/1/26/137
[2], https://lkml.org/lkml/2015/3/31/888
Jarod Wilson (3):
block: export blkdev_reread_part() and __blkdev_reread
CC: Peter Zijlstra
CC: nbd-gene...@lists.sourceforge.net
CC: linux-s...@vger.kernel.org
Signed-off-by: Jarod Wilson
---
block/ioctl.c | 26 +++---
include/linux/fs.h | 3 +++
2 files changed, 26 insertions(+), 3 deletions(-)
diff --git a/block/ioctl.c b/block/ioctl.c
abian Frederick
CC: Ming Lei
CC: David Herrmann
CC: Mike Galbraith
CC: Andrew Morton
CC: Peter Zijlstra
CC: nbd-gene...@lists.sourceforge.net
CC: linux-s...@vger.kernel.org
Signed-off-by: Jarod Wilson
---
drivers/s390/block/dasd_genhd.c | 13 +++--
1 file changed, 3 insertions(+
ter Zijlstra
CC: nbd-gene...@lists.sourceforge.net
CC: linux-s...@vger.kernel.org
Signed-off-by: Ming Lei
Signed-off-by: Jarod Wilson
---
drivers/block/loop.c | 32 ++--
drivers/block/loop.h | 1 +
2 files changed, 27 insertions(+), 6 deletions(-)
diff --git a/drivers/block/loop.c b/
Morton
CC: Peter Zijlstra
CC: nbd-gene...@lists.sourceforge.net
CC: linux-s...@vger.kernel.org
Signed-off-by: Ming Lei
Signed-off-by: Jarod Wilson
---
drivers/s390/block/dasd_genhd.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/s390/block/dasd_genhd.c b
rge.net
CC: linux-s...@vger.kernel.org
Signed-off-by: Ming Lei
Signed-off-by: Jarod Wilson
---
block/ioctl.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/block/ioctl.c b/block/ioctl.c
index 64a4fcb..47c8e6d 100644
--- a/block/ioctl.c
+++ b/bloc
ff-by: Jarod Wilson
---
drivers/block/loop.c | 28
1 file changed, 24 insertions(+), 4 deletions(-)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 81a6bc1..ab5c678 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -528,6 +528,26 @@ stati
-gene...@lists.sourceforge.net
CC: linux-s...@vger.kernel.org
Signed-off-by: Ming Lei
Signed-off-by: Jarod Wilson
---
drivers/block/nbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index a98c41f..7e9d26e 100644
--- a/drivers/block
On Wed, Apr 08, 2015 at 02:50:59PM +0800, Ming Lei wrote:
> Hi Jarod,
>
> On Wed, Apr 8, 2015 at 2:23 PM, Jarod Wilson wrote:
> > From: Ming Lei
> >
> > The lo_ctl_mutex is held for running all ioctl handlers, and
> > in some ioctl handlers, ioctl_by_bdev(BLKRR
On Wed, Apr 08, 2015 at 09:40:34AM -0400, Jarod Wilson wrote:
> On Wed, Apr 08, 2015 at 02:50:59PM +0800, Ming Lei wrote:
> > Hi Jarod,
> >
> > On Wed, Apr 8, 2015 at 2:23 PM, Jarod Wilson wrote:
> > > From: Ming Lei
> > >
> > > The lo_ctl_m
(!mutex_trylock(&bdev->bd_mutex))
> > > return -EBUSY;
>
> Is that really needed? It seems rather poor form.
It goes away later in the series and gets converted to a straight
mutex_lock().
--
Jarod Wilson
ja...@redhat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Wed, Apr 08, 2015 at 10:20:22PM +0800, Ming Lei wrote:
> On Wed, Apr 8, 2015 at 10:00 PM, Jarod Wilson wrote:
> > On Wed, Apr 08, 2015 at 09:40:34AM -0400, Jarod Wilson wrote:
> >> On Wed, Apr 08, 2015 at 02:50:59PM +0800, Ming Lei wrote:
> >> > Hi Jarod,
> >
were nearly identical
to this, and testing for my particular use case still looks good.
For the set:
Tested-by: Jarod Wilson
Acked-by: Jarod Wilson
Thanks much!
--
Jarod Wilson
ja...@redhat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of
On Wed, Apr 08, 2015 at 07:32:24PM +0200, Sebastian Ott wrote:
> On Wed, 8 Apr 2015, Ming Lei wrote:
> > From: Jarod Wilson
> >
> > With the mutex_trylock bit gone from blkdev_reread_part(), the retry logic
> > in dasd_scan_partitions() shouldn't be necessary
perately hoping that the patch fairy
> will come up with something which is less large and complex :(
Shudder-inducing though it may be, I do have to say I'm quite happy with
the resulting behavior with Alexey's patch. It's both more
memory-efficient and more user-friendly, despite
On Sat, Apr 11, 2015 at 01:09:06AM +0300, Alexey Dobriyan wrote:
> On Fri, Apr 10, 2015 at 02:01:32PM -0400, Jarod Wilson wrote:
> > On Fri, Apr 10, 2015 at 05:13:29PM +0300, Alexey Dobriyan wrote:
> > > /proc/$PID/cmdline truncates output at PAGE_SIZE. It is easy to see with
&g
On May 26, 2015, at 5:24 PM, Alexey Dobriyan wrote:
>
>> On Tue, May 26, 2015 at 04:42:36PM -0400, Jarod Wilson wrote:
>>> On 5/8/2015 8:28 AM, Alexey Dobriyan wrote:
>>> /proc/$PID/cmdline truncates output at PAGE_SIZE. It is easy to see with
>>>
>>&
On 5/21/2015 9:21 PM, Rafael J. Wysocki wrote:
On Thursday, May 21, 2015 11:11:46 AM Bjorn Helgaas wrote:
On Tue, May 19, 2015 at 03:27:58PM +0200, Rafael J. Wysocki wrote:
From: Rafael J. Wysocki
Jarod Wilson reports that the expresscard hotplug setup doesn't work
on HP ZBook G2.
On 6/11/2015 1:05 PM, Jarod Wilson wrote:
On 5/21/2015 9:21 PM, Rafael J. Wysocki wrote:
On Thursday, May 21, 2015 11:11:46 AM Bjorn Helgaas wrote:
On Tue, May 19, 2015 at 03:27:58PM +0200, Rafael J. Wysocki wrote:
From: Rafael J. Wysocki
Jarod Wilson reports that the expresscard hotplug
On 6/11/2015 5:16 PM, Rafael J. Wysocki wrote:
On Thursday, June 11, 2015 04:38:12 PM Jarod Wilson wrote:
On 6/11/2015 1:05 PM, Jarod Wilson wrote:
On 5/21/2015 9:21 PM, Rafael J. Wysocki wrote:
On Thursday, May 21, 2015 11:11:46 AM Bjorn Helgaas wrote:
On Tue, May 19, 2015 at 03:27:58PM
dev() after its unregister_netdevice()
call. Now I can load and unload no problem.
CC: Solarflare linux maintainers
CC: net...@vger.kernel.org
Signed-off-by: Jarod Wilson
---
drivers/net/ethernet/sfc/efx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/
On 6/15/2015 9:49 AM, Edward Cree wrote:
On 12/06/15 19:51, Jarod Wilson wrote:
Without this change, modprobe -r sfc hits the BUG_ON() in
efx_pci_remove_main(). Best as I can tell, this was just an oversight,
efx->state gets set to STATE_UNINIT in the error path of
efx_register_netdev() j
Vosburgh
CC: Veaceslav Falico
CC: Andy Gospodarek
CC: net...@vger.kernel.org (open list:BONDING DRIVER)
Signed-off-by: Jarod Wilson
---
drivers/net/bonding/bond_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index
et...@vger.kernel.org
Signed-off-by: Jarod Wilson
---
drivers/net/bonding/bond_main.c | 21 ++---
1 file changed, 18 insertions(+), 3 deletions(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 5ad43aaf76e5..c853ca67058c 100644
--- a/drivers/ne
On Thu, Jan 07, 2021 at 07:03:40PM -0500, Jarod Wilson wrote:
> On Fri, Dec 18, 2020 at 04:18:59PM -0800, Jay Vosburgh wrote:
> > Jarod Wilson wrote:
> >
> > >This comes from an end-user request, where they're running multiple VMs on
> > >hosts with bonded
On Tue, Jan 12, 2021 at 01:39:10PM -0800, Jay Vosburgh wrote:
> Jarod Wilson wrote:
>
> >On Thu, Jan 07, 2021 at 07:03:40PM -0500, Jarod Wilson wrote:
> >> On Fri, Dec 18, 2020 at 04:18:59PM -0800, Jay Vosburgh wrote:
> >> > Jarod Wilson wrote:
> >&
On Mon, Jan 18, 2021 at 04:10:38PM -0700, David Ahern wrote:
> On 1/15/21 12:21 PM, Jarod Wilson wrote:
> > diff --git a/Documentation/networking/bonding.rst
> > b/Documentation/networking/bonding.rst
> > index adc314639085..36562dcd3e1e 100644
> > --- a/Documenta
atch for iproute2 is also
posted, to properly support the new mode there as well.
Cc: Jay Vosburgh
Cc: Veaceslav Falico
Cc: Andy Gospodarek
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: Thomas Davis
Cc: net...@vger.kernel.org
Signed-off-by: Jarod Wilson
---
v2: verified netlink inte
nsider using team driver instead ? :)
That's actually one of the things that was suggested, since team I believe
already has support for this, but the user really wants to use bonding.
We're finding that a lot of users really still prefer bonding over team.
--
Jarod Wilson
ja...@redhat.com
On Fri, Dec 18, 2020 at 04:18:59PM -0800, Jay Vosburgh wrote:
> Jarod Wilson wrote:
>
> >This comes from an end-user request, where they're running multiple VMs on
> >hosts with bonded interfaces connected to some interest switch topologies,
> >where 802.3ad isn&#
b w/o team's userspace footprint".
I think this one is kind of hard for team to do anything about, bonding
really does have a smaller userspace footprint, which is a plus for
embedded type applications and high-security environments looking to keep
things as minimal as possible.
I think I've heard a few "we tried team years ago and it didn't work" as
well, which of course is ridiculous as a reason not to try something again,
since a lot can change in a few years in this world.
--
Jarod Wilson
ja...@redhat.com
lav Falico
Cc: Andy Gospodarek
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: Thomas Davis
Cc: net...@vger.kernel.org
Signed-off-by: Jarod Wilson
---
v2: verified netlink interfaces working, added Documentation, changed
tx hash mode name to vlan+mac for consistency and clarity.
Docume
On Wed, Jan 13, 2021 at 05:58:18PM -0800, Jakub Kicinski wrote:
> On Wed, 13 Jan 2021 17:35:48 -0500 Jarod Wilson wrote:
> > This comes from an end-user request, where they're running multiple VMs on
> > hosts with bonded interfaces connected to some interest switch topologie
On Thu, Jan 14, 2021 at 01:23:14PM -0800, Jakub Kicinski wrote:
> On Thu, 14 Jan 2021 16:11:41 -0500 Jarod Wilson wrote:
> > In truth, this code started out as a copy of bond_eth_hash(), which also
> > only uses the last byte, though of both source and destination macs. In
> >
On Fri, Mar 12, 2021 at 4:04 PM Kalle Valo wrote:
>
> Jarod Wilson writes:
>
> > Build currently fails with -Werror=maybe-uninitialized set:
> >
> > net/wireless/nl80211.c: In function '__cfg80211_wdev_from_attrs':
> > net/wireless/nl80211.c:124:44: err
On Tue, Dec 8, 2020 at 2:38 PM Jakub Kicinski wrote:
>
> On Sat, 5 Dec 2020 18:43:54 -0500 Jarod Wilson wrote:
> > I'm seeing a system get stuck unable to bring a downed interface back up
> > when it's got an updelay value set, behavior which ceased when loggi
On Tue, Dec 8, 2020 at 3:35 PM Jay Vosburgh wrote:
>
> Jarod Wilson wrote:
>
> >I'm seeing a system get stuck unable to bring a downed interface back up
> >when it's got an updelay value set, behavior which ceased when logging
> >spew was removed from bond_
On Thu, Dec 3, 2020 at 11:50 AM Jakub Kicinski wrote:
>
> On Wed, 2 Dec 2020 19:43:57 -0500 Jarod Wilson wrote:
> > bond_dev->hw_features |= NETIF_F_GSO_ENCAP_ALL | NETIF_F_GSO_UDP_L4;
> > -#ifdef CONFIG_XFRM_OFFLOAD
> > - bond_dev->hw_features |= B
quot;David S. Miller"
Cc: Jakub Kicinski
Cc: Thomas Davis
Cc: net...@vger.kernel.org
Signed-off-by: Jarod Wilson
---
drivers/net/bonding/bond_main.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bo
uot;)
Reported-by: Ivan Vecera
Suggested-by: Ivan Vecera
Cc: Jay Vosburgh
Cc: Veaceslav Falico
Cc: Andy Gospodarek
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: Thomas Davis
Cc: net...@vger.kernel.org
Signed-off-by: Jarod Wilson
---
v2: rework based on further testing and suggestions from
bond_dev->wanted_features |= BOND_XFRM_FEATURES;
> + else
> + bond_dev->wanted_features &= ~BOND_XFRM_FEATURES;
> +
> + netdev_update_features(bond_dev);
> +}
>
> (Assuming BOND_XFRM_FEATURES doesn't itself hide under an ifdef.)
It is, but doesn't need to be. I can mix these changes in as well.
--
Jarod Wilson
ja...@redhat.com
t;David S. Miller"
CC: Jakub Kicinski
CC: Thomas Davis
CC: net...@vger.kernel.org
Signed-off-by: Jarod Wilson
---
drivers/net/bonding/bond_main.c | 26 ++
include/net/bonding.h | 38 +
2 files changed, 44 insertions(+), 20 deletions(
Cc: Jay Vosburgh
Cc: Veaceslav Falico
Cc: Andy Gospodarek
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: Thomas Davis
Cc: net...@vger.kernel.org
Signed-off-by: Jarod Wilson
---
drivers/net/bonding/bond_main.c| 27 +--
drivers/net/bonding/bond_options.c |
On Tue, Dec 8, 2020 at 3:35 PM Jay Vosburgh wrote:
>
> Jarod Wilson wrote:
...
> >The addition of a case BOND_LINK_BACK in bond_miimon_commit() is somewhat
> >separate from the fix for the actual hang, but it eliminates a constant
> >"invalid new link 3 on slave&
van Vecera
Suggested-by: Ivan Vecera
Cc: Jay Vosburgh
Cc: Veaceslav Falico
Cc: Andy Gospodarek
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: Thomas Davis
Cc: net...@vger.kernel.org
Signed-off-by: Jarod Wilson
---
drivers/net/bonding/bond_main.c| 10 --
drivers/net/bon
On Wed, Dec 2, 2020 at 12:53 PM Jakub Kicinski wrote:
>
> On Wed, 2 Dec 2020 12:30:53 -0500 Jarod Wilson wrote:
> > + if (bond->dev->reg_state != NETREG_REGISTERED)
> > + goto noreg;
> > +
> > if (newval->value == BOND_MODE_AC
On Wed, Dec 2, 2020 at 12:55 PM Jay Vosburgh wrote:
>
> Jarod Wilson wrote:
>
> >Don't try to adjust XFRM support flags if the bond device isn't yet
> >registered. Bad things can currently happen when netdev_change_features()
> >is called without havin
1 - 100 of 405 matches
Mail list logo
